[02:49:23] Krenair: unblock as in? context? The most recent thing I remember talking about 'unblocking' (deploy wise) was account creation limits for events. [04:24:27] Yippee, build fixed! [04:24:27] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #742: 09FIXED in 32 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/742/ [04:33:03] 6Release-Engineering-Team, 15User-greg: Expand Onboarding page - https://phabricator.wikimedia.org/T129050#2093406 (10greg) [04:34:30] 6Release-Engineering-Team, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): MW 1.27-wmf.15 blockers - https://phabricator.wikimedia.org/T127565#2046969 (10greg) 5Open>3Resolved [04:37:28] 6Release-Engineering-Team, 10scap: git/http operations in scap should be secure - https://phabricator.wikimedia.org/T127498#2093426 (10greg) >>! In T127498#2046216, @hashar wrote: > Sounds to me it should be a service provided by the infrastructure. Ie all of our crap should not have to care about encrypting.... [05:26:56] Yippee, build fixed! [05:26:56] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #719: 09FIXED in 24 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/719/ [06:32:11] PROBLEM - puppet last run on gallium is CRITICAL: CRITICAL: Puppet has 1 failures [06:56:51] RECOVERY - puppet last run on gallium is OK: OK: Puppet is currently enabled, last run 16 seconds ago with 0 failures [08:36:26] PROBLEM - SSH on integration-make-wmf-branch is CRITICAL: Connection refused [09:05:18] (03PS2) 10Hashar: Delete MultimediaViewer IE 8 Selenium daily job [integration/config] - 10https://gerrit.wikimedia.org/r/274360 (https://phabricator.wikimedia.org/T94150) (owner: 10Zfilipin) [09:06:28] (03CR) 10Hashar: [C: 032] "Would be nice to have devs to dig in why IE8 fails, then there is not much interest in maintaining the job and IE8 is really a slice of th" [integration/config] - 10https://gerrit.wikimedia.org/r/274360 (https://phabricator.wikimedia.org/T94150) (owner: 10Zfilipin) [09:08:44] (03Merged) 10jenkins-bot: Delete MultimediaViewer IE 8 Selenium daily job [integration/config] - 10https://gerrit.wikimedia.org/r/274360 (https://phabricator.wikimedia.org/T94150) (owner: 10Zfilipin) [09:18:35] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Wikidata: Wikidata sauce browser tests time out - https://phabricator.wikimedia.org/T128065#2093670 (10zeljkofilipin) a:5hashar>3zeljkofilipin [10:28:26] 10Continuous-Integration-Infrastructure, 3Scap3, 10scap, 10Packaging: Develop a CI Testing and Release pipeline for the SCAP package (and potentially other debian packages that we maintain) - https://phabricator.wikimedia.org/T127741#2093750 (10akosiaris) > The nice thing is you don't have to make a new je... [10:33:53] 10MediaWiki-Codesniffer, 10Possible-Tech-Projects: Improving static analysis tools for MediaWiki - https://phabricator.wikimedia.org/T89682#2093756 (10Galorefitz) Hello! I am interested in working on this. By when will microtasks be posted for this project? [10:56:39] 10Browser-Tests-Infrastructure, 5Release-Engineering-Epics, 7Epic, 13Patch-For-Review, 7Tracking: Fix scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily - https://phabricator.wikimedia.org/T94150#2093841 (10zeljkofilipin) [11:17:17] Yippee, build fixed! [11:17:17] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #900: 09FIXED in 23 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/900/ [11:19:13] 10Browser-Tests-Infrastructure, 10Wikidata, 13Patch-For-Review: Wikidata browser test jobs fail with "Build ​timed ​out ​(after ​240 ​minutes). ​Marking ​the ​build ​as ​aborted." - https://phabricator.wikimedia.org/T128857#2093914 (10zeljkofilipin) [11:19:15] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Wikidata: Wikidata sauce browser tests time out - https://phabricator.wikimedia.org/T128065#2093915 (10zeljkofilipin) [11:20:04] 10Browser-Tests-Infrastructure, 5Release-Engineering-Epics, 7Epic, 13Patch-For-Review, 7Tracking: Fix scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily - https://phabricator.wikimedia.org/T94150#2093917 (10zeljkofilipin) [11:20:32] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Wikidata: Wikidata sauce browser tests time out - https://phabricator.wikimedia.org/T128065#2062946 (10zeljkofilipin) p:5Triage>3Normal [11:22:47] (03Abandoned) 10Zfilipin: WIP Increase job timeout for Wikidata browser tests from 240 to 300 minutes [integration/config] - 10https://gerrit.wikimedia.org/r/274932 (https://phabricator.wikimedia.org/T128857) (owner: 10Zfilipin) [11:43:28] Yippee, build fixed! [11:43:28] Project browsertests-Wikidata-PerformanceTests-linux-firefox build #127: 09FIXED in 21 sec: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-PerformanceTests-linux-firefox/127/ [11:46:49] Yippee, build fixed! [11:46:50] Project browsertests-Wikidata-PerformanceTests-linux-firefox-sauce build #555: 09FIXED in 32 sec: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-PerformanceTests-linux-firefox-sauce/555/ [11:55:54] 5Gerrit-Migration, 7Documentation: Update Code Review related documentation on wiki pages - https://phabricator.wikimedia.org/T207#2094023 (10Aklapper) Tempted to merge this into {T129067} and {T129068} - anyone disagreeing? [11:56:13] (03PS1) 10Hashar: [Arrays] inject dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/275431 [11:58:25] (03CR) 10Hashar: [C: 032] [Arrays] inject dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/275431 (owner: 10Hashar) [11:59:20] (03PS1) 10Zfilipin: WIP Fix various problems with browsertests-Wikidata* jobs [integration/config] - 10https://gerrit.wikimedia.org/r/275435 (https://phabricator.wikimedia.org/T128065) [11:59:25] (03Merged) 10jenkins-bot: [Arrays] inject dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/275431 (owner: 10Hashar) [12:23:01] hashar: nice progress on wikidata jobs, a couple of jobs are green, a couple ended up having problems with timeouts (not ci related), 3 jobs that timeout are still running https://integration.wikimedia.org/ci/view/BrowserTests/view/Wikidata/ [12:23:14] patch: https://gerrit.wikimedia.org/r/#/c/275435/ [12:23:29] zeljkof: is that an actual fix or are tests removed / ignored ? [12:23:54] I have only changed jjb configuration [12:24:07] disabling raita and enabling cucumber pretty formatter [12:24:09] ohhh [12:24:32] so raita causes the test to break somehow ? :( [12:26:21] (03PS3) 10Hashar: [AntiSpoof] Move jsonlint to check: and remove jshint test [integration/config] - 10https://gerrit.wikimedia.org/r/274498 (owner: 10Paladox) [12:27:47] (03CR) 10Hashar: [C: 032] [AntiSpoof] Move jsonlint to check: and remove jshint test [integration/config] - 10https://gerrit.wikimedia.org/r/274498 (owner: 10Paladox) [12:28:48] (03Merged) 10jenkins-bot: [AntiSpoof] Move jsonlint to check: and remove jshint test [integration/config] - 10https://gerrit.wikimedia.org/r/274498 (owner: 10Paladox) [12:35:23] hashar: yes, it is a known problem [12:35:57] https://phabricator.wikimedia.org/T110510 [12:38:13] hm, deployment-bastion has disappeared from deployment-prep [12:38:26] from where are we supposed to deploy from now on? [12:50:34] (03PS2) 10Zfilipin: WIP T128079 [selenium] - 10https://gerrit.wikimedia.org/r/274975 (https://phabricator.wikimedia.org/T128079) [12:52:41] (03CR) 10jenkins-bot: [V: 04-1] WIP T128079 [selenium] - 10https://gerrit.wikimedia.org/r/274975 (https://phabricator.wikimedia.org/T128079) (owner: 10Zfilipin) [12:59:29] (03CR) 10Paladox: "Thanks." [integration/config] - 10https://gerrit.wikimedia.org/r/274498 (owner: 10Paladox) [13:00:33] hashar: If you have time could you merge https://gerrit.wikimedia.org/r/#/c/274302/ and https://gerrit.wikimedia.org/r/#/c/274296/ please. [13:01:21] 5Gerrit-Migration, 10Analytics-Tech-community-metrics, 6Developer-Relations, 3DevRel-March-2016: Make MetricsGrimoire/korma support gathering Code Review statistics from Phabricator's Differential - https://phabricator.wikimedia.org/T118753#2094187 (10Aklapper) [13:20:17] mobrovac: deployment-tin afaik [13:30:27] (03CR) 10Hashar: [C: 04-1] [CirrusSearch] Update Jenkins tests (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/274990 (owner: 10Paladox) [13:31:33] (03PS2) 10Hashar: [Babel] Add npm test, Add composer test [integration/config] - 10https://gerrit.wikimedia.org/r/274803 (owner: 10Paladox) [13:31:35] (03PS2) 10Hashar: [CleanChanges] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/275000 (owner: 10Paladox) [13:31:37] (03PS2) 10Hashar: [Cite] Add jshint and jsonlint to check: [integration/config] - 10https://gerrit.wikimedia.org/r/274820 (owner: 10Paladox) [13:31:39] (03PS3) 10Hashar: [Citoid] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/274987 (owner: 10Paladox) [13:31:42] (03PS2) 10Hashar: [BookManager] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/274808 (owner: 10Paladox) [13:31:43] (03PS2) 10Hashar: [ClientSide] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275005 (owner: 10Paladox) [13:31:45] (03PS2) 10Hashar: [Cards] Add jshint and jsonlint to check: [integration/config] - 10https://gerrit.wikimedia.org/r/274817 (owner: 10Paladox) [13:31:47] (03PS2) 10Hashar: [Capiunto] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/274815 (owner: 10Paladox) [13:31:49] (03PS2) 10Hashar: [BookManagerv2] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/274812 (owner: 10Paladox) [13:31:51] (03PS2) 10Hashar: [CategoryTagSorter] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/274819 (owner: 10Paladox) [13:32:44] (03PS1) 10Hashar: Merge in npm/jshint/jsonlint related changes [integration/config] - 10https://gerrit.wikimedia.org/r/275451 [13:36:36] 5Gerrit-Migration, 10Analytics-Tech-community-metrics, 6Developer-Relations, 3DevRel-March-2016: Make MetricsGrimoire/korma support gathering Code Review statistics from Phabricator's Differential - https://phabricator.wikimedia.org/T118753#2094217 (10Lcanasdiaz) @Aklapper any news about when you guys are... [13:38:20] (03PS2) 10Paladox: [CirrusSearch] Update Jenkins tests [integration/config] - 10https://gerrit.wikimedia.org/r/274990 [13:38:52] (03CR) 10Paladox: "@Hashar thanks for spotting that mistake." [integration/config] - 10https://gerrit.wikimedia.org/r/274990 (owner: 10Paladox) [13:40:35] hashar: It seems https://integration.wikimedia.org/zuul/ has stalled again. [13:40:43] no [13:40:50] Never mind it was slow. [13:40:51] it is waiting for instances to boot :-) [13:40:59] hashar: Oh. [13:41:12] you can look at Jenkins https://integration.wikimedia.org/ci/ for nodes named ci-jessie-wikimedia-* [13:41:24] hashar: Ok thanks. [13:41:49] hashar: If you have time could you merge https://gerrit.wikimedia.org/r/#/c/274302/ and https://gerrit.wikimedia.org/r/#/c/274296/ please. [13:42:18] hashar: It seems to be slow starting up now. [13:47:45] hashar: Thanks for reviewing and merging my patches. [13:47:55] :) [13:48:32] :-} [13:48:45] my mail inbox is full now [13:50:37] hashar: Oh. [13:50:51] (03CR) 10Hashar: [C: 032] flake8: allow lambda expression assignment [integration/dashboard] - 10https://gerrit.wikimedia.org/r/274504 (owner: 10Paladox) [13:51:18] hashar: This https://gerrit.wikimedia.org/r/#/c/274810/ will need a v+2 since the testextension fails. [13:51:22] please. [13:51:26] (03PS3) 10Hashar: Add composer-test for labs/tools/stewardbots [integration/config] - 10https://gerrit.wikimedia.org/r/275164 (https://phabricator.wikimedia.org/T128503) (owner: 10Glaisher) [13:51:31] (03Merged) 10jenkins-bot: flake8: allow lambda expression assignment [integration/dashboard] - 10https://gerrit.wikimedia.org/r/274504 (owner: 10Paladox) [13:52:46] (03CR) 10Hashar: [C: 032] Add composer-test for labs/tools/stewardbots [integration/config] - 10https://gerrit.wikimedia.org/r/275164 (https://phabricator.wikimedia.org/T128503) (owner: 10Glaisher) [13:54:26] (03Merged) 10jenkins-bot: Add composer-test for labs/tools/stewardbots [integration/config] - 10https://gerrit.wikimedia.org/r/275164 (https://phabricator.wikimedia.org/T128503) (owner: 10Glaisher) [13:56:27] (03CR) 10Hashar: "Validated on https://gerrit.wikimedia.org/r/#/c/275163/ :-)" [integration/config] - 10https://gerrit.wikimedia.org/r/275164 (https://phabricator.wikimedia.org/T128503) (owner: 10Glaisher) [14:10:20] (03PS1) 10Paladox: [ContributionsList] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275457 [14:14:32] (03PS1) 10Hashar: [GoogleAPIClient] ship dependencies with composer [integration/config] - 10https://gerrit.wikimedia.org/r/275459 (https://phabricator.wikimedia.org/T119906) [14:21:14] (03CR) 10Hashar: [C: 032] "Validated using check experimental on https://gerrit.wikimedia.org/r/#/c/275295/" [integration/config] - 10https://gerrit.wikimedia.org/r/275459 (https://phabricator.wikimedia.org/T119906) (owner: 10Hashar) [14:22:19] (03Merged) 10jenkins-bot: [GoogleAPIClient] ship dependencies with composer [integration/config] - 10https://gerrit.wikimedia.org/r/275459 (https://phabricator.wikimedia.org/T119906) (owner: 10Hashar) [14:28:12] hashar: this job is stuck forever here :| https://integration.wikimedia.org/ci/view/BrowserTests/view/Wikidata/job/browsertests-Wikidata-WikidataTests-linux-firefox/127/console [14:34:13] dohhh [14:34:20] zeljkof: let me strace it :-) [14:34:39] zeljkof: wanna google hangouts about it ? [14:34:44] maybe there is something wrong with the scenario [14:34:50] I am in the middle of something else [14:34:58] but I have just stumbled upon it [14:35:03] will take a look myself later [14:35:10] that looks related to the wikidata test timing out [14:35:22] but at least we have something to work with now :) [14:36:17] zeljkof: if you are ever wondering what is happening [14:36:33] you can ssh to the instance, sudo as root then find out the pid with ps -u jenkins-deploy [14:36:40] (look for the cucumber process) [14:36:45] then inspect it via: strace -s1024 -ewrite,read -f -p [14:36:54] will dump system calls read() write() [14:37:18] write(7, "{\"script\":\"return jQuery.active\",\"args\":[]}", 43) = 43 [14:37:25] that is what the job is spamming over and over [14:37:53] zeljkof: do you remember the task we had about wikidata job being stuck ? [14:38:55] hashar: yes [14:38:57] here it is [14:39:10] https://phabricator.wikimedia.org/T128065 [14:39:38] the strange thing is, features/reference.feature:71 did not stall other jobs :| [14:39:43] https://integration.wikimedia.org/ci/view/BrowserTests/view/Wikidata/job/browsertests-Wikidata-WikidataTests-linux-chrome-sauce/325/consoleFull [14:39:46] https://integration.wikimedia.org/ci/view/BrowserTests/view/Wikidata/job/browsertests-Wikidata-WikidataTests-linux-firefox-sauce/548/consoleFull [14:39:54] it did fail, but did not stall the jobs [14:43:32] so basically " And I select the snak property stringprop " executes in the browser "return jQuery.active" which is never true [14:47:15] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Wikidata, 13Patch-For-Review: Wikidata sauce browser tests time out - https://phabricator.wikimedia.org/T128065#2094306 (10hashar) The job https://integration.wikimedia.org/ci/view/BrowserTests/view/Wikidata/job/browsertests-Wikidat... [14:47:23] commented on the task [14:53:18] (03PS1) 10Paladox: [CommonMessages] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275477 [14:55:12] (03CR) 10Hashar: [C: 032] [CommonMessages] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275477 (owner: 10Paladox) [14:55:33] (03CR) 10Paladox: "Thanks." [integration/config] - 10https://gerrit.wikimedia.org/r/275477 (owner: 10Paladox) [14:57:09] (03Merged) 10jenkins-bot: [CommonMessages] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275477 (owner: 10Paladox) [14:58:05] PROBLEM - Puppet failure on integration-slave-trusty-1017 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [15:01:39] (03PS2) 10Paladox: Change php-composer-test to composer-test [integration/dashboard] - 10https://gerrit.wikimedia.org/r/274503 [15:01:55] (03PS2) 10Hashar: [ContributionsList] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275457 (owner: 10Paladox) [15:02:12] (03CR) 10Hashar: [C: 032] [ContributionsList] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275457 (owner: 10Paladox) [15:03:29] (03Merged) 10jenkins-bot: [ContributionsList] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275457 (owner: 10Paladox) [15:07:56] (03PS1) 10Paladox: [CommunityApplications] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275485 [15:12:32] 10scap, 6Operations: mw1033 crashed, check it is healthy - https://phabricator.wikimedia.org/T129083#2094432 (10jcrespo) [15:14:19] (03Abandoned) 10Zfilipin: WIP T128079 [ruby/api] - 10https://gerrit.wikimedia.org/r/274973 (https://phabricator.wikimedia.org/T128079) (owner: 10Zfilipin) [15:14:22] (03Abandoned) 10Zfilipin: WIP T128079 [selenium] - 10https://gerrit.wikimedia.org/r/274975 (https://phabricator.wikimedia.org/T128079) (owner: 10Zfilipin) [15:15:02] 5Continuous-Integration-Scaling, 10Horizon, 6Labs: Labs project admin can not delete per project image on Horizon - https://phabricator.wikimedia.org/T110936#2094482 (10hashar) Dropping #labs-infrastructure since we now have #horizon [15:15:16] hashar: oh, the stupidest bug so far :D https://gerrit.wikimedia.org/r/#/c/274976/ [15:15:27] anyway, that should fix the last MMV job [15:15:52] hmm [15:16:44] $ curl -L --verbose http://mediawiki.org/wiki/ 2>&1 |grep Location [15:16:45] < Location: https://mediawiki.org/wiki/ [15:16:46] < Location: https://www.mediawiki.org/wiki/ [15:16:46] < Location: https://www.mediawiki.org/wiki/MediaWiki [15:16:49] we should follow redirects [15:18:16] (03PS1) 10Paladox: [CommunityHiring] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275490 [15:21:18] PROBLEM - Puppet failure on integration-slave-trusty-1001 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [15:22:08] (03CR) 10Hashar: [C: 032] [CommunityHiring] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275490 (owner: 10Paladox) [15:22:42] hashar: argh https://integration.wikimedia.org/ci/view/BrowserTests/view/MultimediaViewer/job/browsertests-MultimediaViewer-mediawiki.org-linux-firefox-sauce/902/console [15:22:52] 00:00:08.016

The document has moved here.

[15:23:02] yup [15:23:05] the change is in master [15:23:12] argh [15:23:14] but the job uses the wmf.15 branch, I have cherry picked the patch [15:23:18] will +2 it soonish [15:23:19] I always forget :) [15:23:28] https://gerrit.wikimedia.org/r/#/c/275495/ [15:23:32] waiting for tests [15:24:03] hashar: Hi, could you merge https://gerrit.wikimedia.org/r/#/c/274302/ please. [15:24:11] and https://gerrit.wikimedia.org/r/#/c/274296/ please. [15:24:12] paladox: it is in my backlog yes [15:24:16] that one as well :D [15:24:19] hashar: I have thought I have messed up something :) [15:24:20] hashar: Oh ok. thanks. [15:24:34] (03Merged) 10jenkins-bot: [CommunityHiring] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275490 (owner: 10Paladox) [15:26:26] hashar: Once the migration to npm for all the repos are complete will the jshint and jsonlint tests be deprecated and removed. [15:32:16] hashar: It looks like jessie is very slow, https://integration.wikimedia.org/zuul/ since it was much faster last week. [15:32:45] paladox: same as earlier; look at https://integration.wikimedia.org/ci/ for nodes named ci-jessie-wikimedia-* [15:32:49] pool is exhausted [15:33:02] I am deploying a change later to night that will speed it up [15:33:12] hashar: Oh, and thanks for replying. [15:33:13] RECOVERY - Puppet failure on integration-slave-trusty-1017 is OK: OK: Less than 1.00% above the threshold [0.0] [15:33:14] hashar: we need a bigger pool 🏊 [15:35:29] hashar: do we have a graph somewhere with nodepool utilization? [15:35:39] nop [15:35:53] nodepool is quite verbose, it sends metrics for a wild range of stuff we dont care about [15:36:00] I was sure I have saw one, maybe it was then for something else [15:36:02] for example for each job [15:36:05] which would overload graphite :( [15:36:18] gotta finish up a patch to whitelist the metrics we want to send [15:37:32] one of the slowdown is it waits 1 minute before deleting an instance [15:38:57] hashar: is Horizon looking more reasonable today? Are there still things you can do that you should not be able to do? [15:39:07] hashar: this is still failing :( https://integration.wikimedia.org/ci/view/BrowserTests/view/-Dashboard/job/browsertests-MultimediaViewer-mediawiki.org-linux-firefox-sauce/903/ [15:39:25] I guess we do not use environment file in the CI :( [15:39:29] argh [15:39:53] ok, another reason to finish up selenium-(name) jobs as soon as possible [15:40:55] zeljkof: the MultimediaViewer change against mediawiki.org should work now [15:41:02] oh [15:41:14] hashar: it _should_ :| [15:41:18] 00:00:07.993 757: unexpected token at ' [15:41:19] huhu [15:41:21] well [15:41:30] but apparently the huge shell script of doom messes things up somehow, again [15:41:33] it used to work previously ? [15:41:43] no, it worked fine on my machine [15:41:51] I mean on Jenkins [15:41:55] after I have fixed the environments.yml [15:41:58] not sure [15:42:07] it did not work in the last 30 days [15:42:15] and we do not have old logs [15:42:19] 10scap, 6Operations: mw1033 crashed, check it is healthy - https://phabricator.wikimedia.org/T129083#2094560 (10jcrespo) [15:42:37] ok [15:42:40] anyway, will finish up selenuim* jobs so we can move MMV there, it should work there [15:43:44] hashar: and wikidata is messed up for realz [15:43:50] https://saucelabs.com/jobs/25101fdbc0a840f0bc4fa180f5bafdc3 [15:43:59] Test exceeded maximum duration after 1800 seconds [15:44:11] script: "return jQuery.active" [15:44:41] Repeated 2508 times over 12.57s [15:44:54] there seems to be something wrong with jquery [15:45:10] that's why it is timing out [15:45:47] jzerebecki: ^ [15:46:20] :( [15:46:57] jzerebecki: can you check if everything looks good here? http://wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page [15:47:07] maybe there is just something wrong with jquery [15:47:18] (03PS2) 10Hashar: [CommunityApplications] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275485 (owner: 10Paladox) [15:47:25] (03CR) 10Hashar: [C: 032] [CommunityApplications] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275485 (owner: 10Paladox) [15:49:03] jzerebecki: good news is that two (performance) jobs are green :) https://integration.wikimedia.org/ci/view/BrowserTests/view/Wikidata/ [15:50:51] (03Merged) 10jenkins-bot: [CommunityApplications] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275485 (owner: 10Paladox) [15:53:06] RECOVERY - SSH on deployment-conftool is OK: SSH OK - OpenSSH_6.7p1 Debian-5+deb8u1 (protocol 2.0) [15:59:06] PROBLEM - SSH on deployment-conftool is CRITICAL: Server answer [16:01:33] zeljkof: I found no bug. but that doesn't mean much. what is weird is that in the screen shot the dropdown on the left is still there, but the focus is one to the right. [16:02:31] (03PS1) 10Paladox: [CommunityVoice] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275513 [16:03:53] (03CR) 10Hashar: [C: 032] [CommunityVoice] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275513 (owner: 10Paladox) [16:07:57] (03Merged) 10jenkins-bot: [CommunityVoice] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275513 (owner: 10Paladox) [16:11:41] (03PS1) 10Siebrand: Update WebChat settings [integration/config] - 10https://gerrit.wikimedia.org/r/275520 [16:24:09] (03PS2) 10Zfilipin: Disable Raita and enable Cucumber pretty formatter for browsertests-Wikidata* jobs. [integration/config] - 10https://gerrit.wikimedia.org/r/275435 (https://phabricator.wikimedia.org/T128065) [16:26:07] 5Gerrit-Migration, 7Documentation: Update Code Review related documentation on wiki pages - https://phabricator.wikimedia.org/T207#2094690 (10greg) Well, as long as all of the crazy stuff under Gerrit that isn't (or shouldn't be) Gerrit specific is cleaned up and moved somewhere else (like under the proposed [... [16:28:51] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling: DIB images have /puppet/hieradata files that are empty - https://phabricator.wikimedia.org/T128846#2094699 (10hashar) 5Open>3Resolved So my earlier summary in T128846#2089789 was accurate and `sync` before snapshotting is enough to h... [16:35:15] (03CR) 10Florianschmidtwelzow: "Thanks! Hashar, you're always much faster then me :P" [integration/config] - 10https://gerrit.wikimedia.org/r/275459 (https://phabricator.wikimedia.org/T119906) (owner: 10Hashar) [16:37:28] legoktm: To make the composer-test to run on all repos without needing to add it to each repo (For mediawiki repos) We can use some regix to make composer-test a no voter for repos that we know will fail. [16:38:58] hashar: Is there any code in zuul we can use to be able to for example if we were to add no voter to composer-test but no vote will actually only be applied to the repos we choose how would we do that please. [16:42:11] i had a look around beta cluster, and it doesn't seem like we run the same cron's that prod uses (mediawiki::maintenance::* in puppet). Did i miss something or is that correct? [16:42:22] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Wikidata, 13Patch-For-Review: Wikidata sauce browser tests time out - https://phabricator.wikimedia.org/T128065#2094754 (10zeljkofilipin) [[ https://saucelabs.com/jobs/de66fffab3964f1cb7c9af607dc543fa | de66fffab3964f1cb7c9af607dc54... [16:46:36] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7Puppet: Hiera is not properly configured on Nodepool instances - https://phabricator.wikimedia.org/T129092#2094783 (10hashar) [16:50:30] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Wikidata, 13Patch-For-Review: Wikidata sauce browser tests time out - https://phabricator.wikimedia.org/T128065#2094811 (10zeljkofilipin) Looks like the job gets stuck while executing `script: "return jQuery.active"`. It is called f... [16:54:28] 10Beta-Cluster-Infrastructure, 6Labs, 10Labs-Infrastructure, 6Operations: beta: Get SSL certificates for *.{projects}.beta.wmflabs.org - https://phabricator.wikimedia.org/T50501#2094832 (10Paladox) [16:54:33] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Wikidata, 13Patch-For-Review: Wikidata sauce browser tests time out - https://phabricator.wikimedia.org/T128065#2094836 (10zeljkofilipin) The problem is not reproducible while using local browser, but it is reproducible while using... [16:57:19] 10Beta-Cluster-Infrastructure, 6Labs, 10Labs-Infrastructure: Setup real ssl certs for Beta Cluster using a restricted project - https://phabricator.wikimedia.org/T75919#785524 (10Paladox) letsencrypt.org is now available but in beta mode. [17:00:51] ebernhardson: maybe they are not run anyway anymore :-((( [17:01:07] ebernhardson: can you fill a task against #beta-cluster-infrastructure please? That will spam everyone :-} [17:01:18] maybe we forgot to apply that mediawiki::maintenance class [17:01:24] hashar: lol, ok will do :) I'll check just a little more to make sure i didn't miss something... [17:01:34] puppet can get a bit difficult figuring out where things are [17:03:41] (03PS1) 10Paladox: [ContactPageFundraiser] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275541 [17:04:40] (03PS1) 10Siebrand: Update test configuration for CharInsert [integration/config] - 10https://gerrit.wikimedia.org/r/275542 [17:07:36] (03PS2) 10Siebrand: Update WebChat settings [integration/config] - 10https://gerrit.wikimedia.org/r/275520 [17:08:15] 10Beta-Cluster-Infrastructure: MediaWiki maintenance tasks from puppet not running on beta cluster - https://phabricator.wikimedia.org/T129095#2094943 (10EBernhardson) [17:22:26] 10Continuous-Integration-Infrastructure, 3Scap3, 10scap, 10Packaging: Develop a CI Testing and Release pipeline for the SCAP package (and potentially other debian packages that we maintain) - https://phabricator.wikimedia.org/T127741#2095031 (10mmodell) [17:22:28] 10Continuous-Integration-Infrastructure, 5Gerrit-Migration, 3releng-201516-q2, 3releng-201516-q3, 10Differential: [keyresult] Connect Differential code review with continuous integration - https://phabricator.wikimedia.org/T31#2095030 (10mmodell) [17:28:09] 10Beta-Cluster-Infrastructure: MediaWiki maintenance tasks from puppet not running on beta cluster - https://phabricator.wikimedia.org/T129095#2095055 (10hashar) I think we used to have `mediawiki::maintenance` applied on deployment-bastion at some point. Not sure where it would be applied now, maybe on an equi... [17:29:23] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Wikidata, 13Patch-For-Review: Wikidata sauce browser tests time out - https://phabricator.wikimedia.org/T128065#2095063 (10hashar) That EntityPage#ajax_wait should time out after X iterations at least :) [17:49:31] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7Puppet: Hiera is not properly configured on Nodepool instances - https://phabricator.wikimedia.org/T129092#2095169 (10mobrovac) You can add facts by passing in environment variables: ``` $ FACTER_MYVARNAME=blah puppet apply ``` This... [17:55:02] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Wikidata, 13Patch-For-Review: Wikidata sauce browser tests time out - https://phabricator.wikimedia.org/T128065#2095213 (10zeljkofilipin) Example code on how to do timeouts, used in [[ https://phabricator.wikimedia.org/diffusion/EVE... [17:56:49] (03PS1) 10Paladox: [FundraisingChart] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275574 [17:57:04] 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7Puppet: Hiera is not properly configured on Nodepool instances - https://phabricator.wikimedia.org/T129092#2095218 (10hashar) ``` $ facter labsproject $ FACTER_LABSPROJECT=foobar facter labsproject foobar $ ``` Super nice hack @mobr... [18:06:35] (03CR) 10Hashar: "@Florian pure luck! I have just noticed Jenkins voted -1 on that repo ;-}" [integration/config] - 10https://gerrit.wikimedia.org/r/275459 (https://phabricator.wikimedia.org/T119906) (owner: 10Hashar) [18:08:44] (03PS1) 10Paladox: [ContributionReporting] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275578 [18:15:52] (03PS1) 10Paladox: [CreditsSource] Move jsonlint to check: and remove jshint [integration/config] - 10https://gerrit.wikimedia.org/r/275581 [18:16:15] (03CR) 10Paladox: "check experimental" [integration/config] - 10https://gerrit.wikimedia.org/r/275581 (owner: 10Paladox) [18:21:16] (03PS1) 10Paladox: [CustomData] Move jsonlint to check: and remove jshint [integration/config] - 10https://gerrit.wikimedia.org/r/275586 [18:25:49] 3Scap3, 10scap, 7Documentation, 15User-mobrovac: Document Scap3 config-deploy - https://phabricator.wikimedia.org/T116634#2095336 (10mobrovac) [18:29:13] 10Continuous-Integration-Infrastructure, 3Scap3, 10scap, 10Packaging: Develop a CI Testing and Release pipeline for the SCAP package (and potentially other debian packages that we maintain) - https://phabricator.wikimedia.org/T127741#2095363 (10mmodell) @akosiaris: currently this works with differential re... [18:38:32] (03PS1) 10Ejegg: Check out REL1_25 vendor and skin for fr/1.25 [integration/config] - 10https://gerrit.wikimedia.org/r/275591 [18:42:39] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2095410 (10mmodell) >>! In T121751#2093243, @Luke081515 wrote: > But not the commit content, for example if a user made a little mistake :-/... [18:48:02] Hi, quick question: https://phabricator.wikimedia.org/T127136 <--- will this be released this week? It's been included in Tech News, but some question marks in the discussion. Yes/no/don't know yet? [18:48:37] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2095467 (10Dereckson) Actually, we have been using this workflow since 2012. This is the current Wikimedia practice to amend changes without... [18:50:02] greg-g: ^ (since you commented on the ticket) [19:01:48] JohanJ: commented :) [19:04:04] Hi folks, another bit of breakage for us out-of-sync fundraising folks, but I think this should fix it: https://gerrit.wikimedia.org/r/275591 [19:04:17] Anybody got time for some minor CR? [19:05:58] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2095639 (10greg) >>! In T121751#2095467, @Dereckson wrote: > Actually, we have been using this workflow since 2012. That, in and of itself,... [19:11:28] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2095668 (10Dereckson) Yes, I concur, we should evaluate the cost/benefit of the collaborative commit crafting model //per se//, and not only... [19:12:51] 5Gerrit-Migration, 7Documentation: Update Code Review related documentation on wiki pages from Gerrit to Differential - https://phabricator.wikimedia.org/T207#2095685 (10Aklapper) [19:13:25] 5Gerrit-Migration, 7Documentation: Update Code Review related documentation on wiki pages from Gerrit to Differential - https://phabricator.wikimedia.org/T207#2776 (10Aklapper) Makes a lot of sense. I clarified the task description and will keep this separate for the time being. [19:14:41] 5Gerrit-Migration, 7Documentation: Update Code Review related documentation on wiki pages from Gerrit to Differential - https://phabricator.wikimedia.org/T207#2095700 (10greg) Much better title, thanks :) [19:17:04] 3Scap3, 10scap, 7Documentation, 15User-mobrovac: Document Scap3 config-deploy - https://phabricator.wikimedia.org/T116634#2095713 (10mobrovac) Node.js services will need a way to separate the config in two parts: the main part that is provided via puppet, and the service-specific config that is taken from... [19:20:02] thcipriani: how's it going? I bet cwd has let you in on fr-tech's CI pains due to our lagging core branch. I think we need one more update to our php5.3 job now that short array syntax is spreading: https://gerrit.wikimedia.org/r/275591 Got a minute to CR? [19:20:46] * thcipriani looks [19:26:42] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2095761 (10mmodell) If we were modeling the wiki way, I would think that post-commit review would make more sense. But pre-commit review, whi... [19:30:46] 5Gerrit-Migration, 10Differential, 7Documentation, 7WorkType-NewFunctionality: Document gerrit workflows and demonstrate equivalent in arcanist workflows - https://phabricator.wikimedia.org/T117058#1765720 (10Dereckson) Could we also document on to easily use Arcanist to update three successive change? **... [19:37:16] (03CR) 10Thcipriani: [C: 031] "Testing" [integration/config] - 10https://gerrit.wikimedia.org/r/275591 (owner: 10Ejegg) [19:40:39] thanks thcipriani ! [19:41:25] ejegg|vps: should be updated live, give it a test. [19:43:08] cool, rechecking https://gerrit.wikimedia.org/r/275579 [19:44:49] ejegg: nice. Work as expected? [19:45:09] yep, that seemed to do it! [19:45:46] Thanks again thcipriani [19:46:54] (03CR) 10Thcipriani: [C: 032] "Works" [integration/config] - 10https://gerrit.wikimedia.org/r/275591 (owner: 10Ejegg) [19:48:19] (03Merged) 10jenkins-bot: Check out REL1_25 vendor and skin for fr/1.25 [integration/config] - 10https://gerrit.wikimedia.org/r/275591 (owner: 10Ejegg) [19:49:22] greg-g: thanks. :) [19:50:56] (03PS1) 10Paladox: [CustomUserSignup] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275604 [19:59:38] 10Continuous-Integration-Infrastructure, 10Wikidata: Cannot find site jenkins_u3_mw - https://phabricator.wikimedia.org/T121083#2095944 (10Krinkle) [20:01:41] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Wikidata-Sprint-2016-03-01: Cannot find site jenkins_u3_mw - https://phabricator.wikimedia.org/T121083#2095981 (10Krinkle) p:5Triage>3High [20:05:50] !log Upgrading Nodepool from 0.1.1-wmf3 to 0.1.1-wmf.4 with andrewbogott | T118573 [20:05:53] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [20:06:05] we are in #wikimedia-operations for the nodepool upgrade [20:41:20] 5Gerrit-Migration, 7Documentation: Update Commit Message Guidelines for phab - https://phabricator.wikimedia.org/T123081#1920573 (10mmodell) I like the Test Plan field. I'm not so sure if it should be required though. Generally for code that is getting deployed to production, I think even having a revert plan... [20:46:19] 3releng-201516-q2, 3releng-201516-q3, 10scap, 10Scap3 (scap3-adoption): [keyresult] Migrate all Service team owned services and MW deploys to scap3 - https://phabricator.wikimedia.org/T109926#2096264 (10thcipriani) the `repo_config` in salt is probably the canonical list of things deployed with Trebuchet.... [20:57:27] 5Continuous-Integration-Scaling, 7Nodepool, 13Patch-For-Review, 7Upstream: Nodepool delay instance deletions by one minute - https://phabricator.wikimedia.org/T113359#2096315 (10hashar) [20:57:29] 5Continuous-Integration-Scaling, 7Nodepool, 13Patch-For-Review, 7WorkType-Maintenance: nodepool can't update images - https://phabricator.wikimedia.org/T111377#2096316 (10hashar) [20:57:31] 5Continuous-Integration-Scaling: Upgrade Nodepool to 0.1.1-wmf4 - https://phabricator.wikimedia.org/T118573#2096313 (10hashar) 5Open>3Resolved a:3hashar [20:58:22] 5Continuous-Integration-Scaling, 7Nodepool, 13Patch-For-Review, 7Upstream: Nodepool delay instance deletions by one minute - https://phabricator.wikimedia.org/T113359#1662848 (10hashar) The delay is gone. Note deletion tasks are handle by a & minute internal cron: ``` cron: # Deletes old images and serv... [20:59:01] 5Continuous-Integration-Scaling, 7Nodepool, 13Patch-For-Review, 7Upstream: Nodepool delay instance deletions by one minute - https://phabricator.wikimedia.org/T113359#2096346 (10hashar) 5Open>3Resolved a:3hashar [21:02:25] 3Scap3, 10scap, 7Documentation, 15User-mobrovac: Document Scap3 config-deploy - https://phabricator.wikimedia.org/T116634#2096386 (10dduvall) One option here—completely unverified—might be to use Jinja2's macro feature: ```lang=yaml, name=service-common.yaml (in ops/puppet or a submodule) {% macro config(... [21:02:50] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy kibana with scap3 - https://phabricator.wikimedia.org/T129138#2096388 (10thcipriani) [21:03:41] !log Nodepool upgraded to 0.1.1-wmf.4 , it no more waits 1 minute before deleted a used node | T118573 [21:03:45] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [21:03:49] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy statsv with scap3 - https://phabricator.wikimedia.org/T129139#2096400 (10thcipriani) [21:05:09] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy zotero/translation-server with scap3 - https://phabricator.wikimedia.org/T129140#2096415 (10thcipriani) [21:06:20] 10Deployment-Systems, 10MediaWiki-Codesniffer, 10scap, 10Scap3 (scap3-adoption): Deploy mediawiki-tools-codesniffer with scap3 - https://phabricator.wikimedia.org/T129141#2096431 (10thcipriani) [21:07:06] (03PS2) 10Hashar: [ContributionReporting] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275578 (owner: 10Paladox) [21:07:08] (03PS2) 10Hashar: [CustomUserSignup] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275604 (owner: 10Paladox) [21:07:10] (03PS2) 10Hashar: [CustomData] Move jsonlint to check: and remove jshint [integration/config] - 10https://gerrit.wikimedia.org/r/275586 (owner: 10Paladox) [21:07:12] (03PS2) 10Hashar: [CreditsSource] Move jsonlint to check: and remove jshint [integration/config] - 10https://gerrit.wikimedia.org/r/275581 (owner: 10Paladox) [21:07:14] (03PS2) 10Hashar: [ContactPageFundraiser] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275541 (owner: 10Paladox) [21:07:19] 10Deployment-Systems, 10MediaWiki-Codesniffer, 10scap, 10Scap3 (scap3-adoption): Deploy mediawiki-tools-codesniffer with scap3 - https://phabricator.wikimedia.org/T129141#2096431 (10Legoktm) Erm, what? Where is it being deployed to? [21:07:34] 10Deployment-Systems, 10scap, 10OCG-PDF-renderer, 10Scap3 (scap3-adoption): Deploy ocg with scap3 - https://phabricator.wikimedia.org/T129142#2096453 (10thcipriani) [21:08:16] (03PS1) 10MaxSem: Add Kartographer [tools/release] - 10https://gerrit.wikimedia.org/r/275624 (https://phabricator.wikimedia.org/T127136) [21:08:16] legoktm: see https://phabricator.wikimedia.org/T109926#2096264 [21:10:41] (03CR) 10Hashar: [C: 032] [ContributionReporting] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275578 (owner: 10Paladox) [21:10:45] (03CR) 10Hashar: [C: 032] [CustomUserSignup] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275604 (owner: 10Paladox) [21:10:47] (03CR) 10Hashar: [C: 032] [CustomData] Move jsonlint to check: and remove jshint [integration/config] - 10https://gerrit.wikimedia.org/r/275586 (owner: 10Paladox) [21:10:49] (03CR) 10Hashar: [C: 032] [CreditsSource] Move jsonlint to check: and remove jshint [integration/config] - 10https://gerrit.wikimedia.org/r/275581 (owner: 10Paladox) [21:10:51] (03CR) 10Hashar: [C: 032] [ContactPageFundraiser] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275541 (owner: 10Paladox) [21:10:52] 3releng-201516-q2, 3releng-201516-q3, 10scap, 10Scap3 (scap3-adoption): [keyresult] Migrate all Service team owned services and MW deploys to scap3 - https://phabricator.wikimedia.org/T109926#1562968 (10Legoktm) > 8. integration/mediawiki-tools-codesniffer > 32. integration/phpcs These two are no longer... [21:11:02] greg-g: thanks for the pointer [21:11:12] :) [21:11:27] 10Deployment-Systems, 10MediaWiki-Codesniffer, 10scap, 10Scap3 (scap3-adoption): Deploy mediawiki-tools-codesniffer with scap3 - https://phabricator.wikimedia.org/T129141#2096486 (10Legoktm) See T109926#2096483 [21:12:32] (03Merged) 10jenkins-bot: [ContactPageFundraiser] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275541 (owner: 10Paladox) [21:13:01] (03Merged) 10jenkins-bot: [ContributionReporting] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275578 (owner: 10Paladox) [21:13:03] (03Merged) 10jenkins-bot: [CreditsSource] Move jsonlint to check: and remove jshint [integration/config] - 10https://gerrit.wikimedia.org/r/275581 (owner: 10Paladox) [21:13:20] (03Merged) 10jenkins-bot: [CustomData] Move jsonlint to check: and remove jshint [integration/config] - 10https://gerrit.wikimedia.org/r/275586 (owner: 10Paladox) [21:13:22] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy zotero/translators with scap3 - https://phabricator.wikimedia.org/T129143#2096492 (10thcipriani) [21:14:13] 10Deployment-Systems, 10scap, 6Discovery, 10Wikidata, and 2 others: Deploy wdqs with scap3 - https://phabricator.wikimedia.org/T129144#2096507 (10thcipriani) [21:14:33] (03Merged) 10jenkins-bot: [CustomUserSignup] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275604 (owner: 10Paladox) [21:15:17] 10Deployment-Systems, 10MediaWiki-Codesniffer, 10scap, 10Scap3 (scap3-adoption): Deploy mediawiki-tools-codesniffer with scap3 - https://phabricator.wikimedia.org/T129141#2096520 (10greg) 5Open>3Invalid One down.... ;) [21:15:40] 10Deployment-Systems, 10scap, 10Citoid, 10VisualEditor, 10Scap3 (scap3-adoption): Deploy zotero/translators with scap3 - https://phabricator.wikimedia.org/T129143#2096523 (10greg) [21:15:59] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy fluoride with scap3 - https://phabricator.wikimedia.org/T129145#2096525 (10thcipriani) [21:16:39] 10Deployment-Systems, 10scap, 10Tilerator, 10Scap3 (scap3-adoption): Deploy tilerator with scap3 - https://phabricator.wikimedia.org/T129146#2096538 (10thcipriani) [21:17:35] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy mobileapps/deploy with scap3 - https://phabricator.wikimedia.org/T129147#2096552 (10thcipriani) [21:18:35] 10Deployment-Systems, 10scap, 10MediaWiki-JobRunner, 10Scap3 (scap3-adoption): Deploy jobrunner with scap3 - https://phabricator.wikimedia.org/T129148#2096570 (10thcipriani) [21:19:17] thcipriani: hope you don't mind me going through and adding related projects for those [21:19:33] greg-g: please do. [21:19:48] 10Deployment-Systems, 10scap, 6Mobile-Apps, 10Scap3 (scap3-adoption): Deploy mobileapps/deploy with scap3 - https://phabricator.wikimedia.org/T129147#2096585 (10greg) [21:20:28] (03CR) 10Yurik: [C: 031] Add Kartographer [tools/release] - 10https://gerrit.wikimedia.org/r/275624 (https://phabricator.wikimedia.org/T127136) (owner: 10MaxSem) [21:20:50] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy discovery-analytics with scap3 - https://phabricator.wikimedia.org/T129149#2096588 (10thcipriani) [21:21:12] 10Deployment-Systems, 10scap, 10Monitoring, 10Scap3 (scap3-adoption): Deploy statsv with scap3 - https://phabricator.wikimedia.org/T129139#2096599 (10greg) [21:21:33] 10Deployment-Systems, 10scap, 10Kartotherian, 10Scap3 (scap3-adoption): Deploy kartotherian with scap3 - https://phabricator.wikimedia.org/T129150#2096601 (10thcipriani) [21:21:38] 10Deployment-Systems, 10scap, 10Wikimedia-Logstash, 10Scap3 (scap3-adoption): Deploy kibana with scap3 - https://phabricator.wikimedia.org/T129138#2096613 (10greg) [21:22:27] 10Deployment-Systems, 10scap, 6Discovery, 10Scap3 (scap3-adoption): Deploy discovery-analytics with scap3 - https://phabricator.wikimedia.org/T129149#2096616 (10greg) [21:22:46] 10Deployment-Systems, 10scap, 10Analytics, 10Scap3 (scap3-adoption): Deploy analytics-refinery with scap3 - https://phabricator.wikimedia.org/T129151#2096617 (10thcipriani) [21:23:20] 10Deployment-Systems, 10scap, 10Analytics, 10Analytics-Cluster, 10Scap3 (scap3-adoption): Deploy analytics-refinery with scap3 - https://phabricator.wikimedia.org/T129151#2096628 (10greg) [21:23:51] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy servermon with scap3 - https://phabricator.wikimedia.org/T129152#2096629 (10thcipriani) [21:24:52] 10Deployment-Systems, 10scap, 10Monitoring, 6Operations, 10Scap3 (scap3-adoption): Deploy servermon with scap3 - https://phabricator.wikimedia.org/T129152#2096645 (10greg) [21:25:27] 10Deployment-Systems, 10scap, 10Wikimedia-Stream, 10Scap3 (scap3-adoption): Deploy rcstream with scap3 - https://phabricator.wikimedia.org/T129153#2096650 (10thcipriani) [21:26:33] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy iegreview with scap3 - https://phabricator.wikimedia.org/T129154#2096664 (10thcipriani) [21:26:58] 10Deployment-Systems, 10scap, 10Wikimedia-IEG-grant-review, 10Scap3 (scap3-adoption): Deploy iegreview with scap3 - https://phabricator.wikimedia.org/T129154#2096675 (10greg) [21:27:10] 10Deployment-Systems, 10scap, 10Sentry, 10Scap3 (scap3-adoption): Deploy sentry with scap3 - https://phabricator.wikimedia.org/T129155#2096676 (10thcipriani) [21:28:29] 10Deployment-Systems, 10scap, 10Wikimedia-IEG-grant-review, 10Scap3 (scap3-adoption): Deploy iegreview with scap3 - https://phabricator.wikimedia.org/T129154#2096705 (10thcipriani) [21:28:31] 10Deployment-Systems, 10scap, 10Wikimedia-Stream, 10Scap3 (scap3-adoption): Deploy rcstream with scap3 - https://phabricator.wikimedia.org/T129153#2096706 (10thcipriani) [21:28:33] 10Deployment-Systems, 10scap, 10Monitoring, 6Operations, 10Scap3 (scap3-adoption): Deploy servermon with scap3 - https://phabricator.wikimedia.org/T129152#2096707 (10thcipriani) [21:28:35] 10Deployment-Systems, 10scap, 10Analytics, 10Analytics-Cluster, 10Scap3 (scap3-adoption): Deploy analytics-refinery with scap3 - https://phabricator.wikimedia.org/T129151#2096708 (10thcipriani) [21:28:37] 10Deployment-Systems, 10scap, 6Discovery, 10Scap3 (scap3-adoption): Deploy discovery-analytics with scap3 - https://phabricator.wikimedia.org/T129149#2096710 (10thcipriani) [21:28:39] 10Deployment-Systems, 10scap, 6Mobile-Apps, 10Scap3 (scap3-adoption): Deploy mobileapps/deploy with scap3 - https://phabricator.wikimedia.org/T129147#2096712 (10thcipriani) [21:28:42] 10Deployment-Systems, 10scap, 10MediaWiki-JobRunner, 10Scap3 (scap3-adoption): Deploy jobrunner with scap3 - https://phabricator.wikimedia.org/T129148#2096711 (10thcipriani) [21:28:44] 10Deployment-Systems, 10scap, 10OCG-PDF-renderer, 10Scap3 (scap3-adoption): Deploy ocg with scap3 - https://phabricator.wikimedia.org/T129142#2096717 (10thcipriani) [21:28:46] 10Deployment-Systems, 10scap, 10Tilerator, 10Scap3 (scap3-adoption): Deploy tilerator with scap3 - https://phabricator.wikimedia.org/T129146#2096713 (10thcipriani) [21:28:48] that's going to be a lot of spam :( [21:28:48] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy fluoride with scap3 - https://phabricator.wikimedia.org/T129145#2096714 (10thcipriani) [21:28:50] 10Deployment-Systems, 10scap, 10Monitoring, 10Scap3 (scap3-adoption): Deploy statsv with scap3 - https://phabricator.wikimedia.org/T129139#2096719 (10thcipriani) [21:28:51] thcipriani: :) [21:28:53] 10Deployment-Systems, 10scap, 10Citoid, 10VisualEditor, 10Scap3 (scap3-adoption): Deploy zotero/translators with scap3 - https://phabricator.wikimedia.org/T129143#2096716 (10thcipriani) [21:28:55] 10Deployment-Systems, 10scap, 10Wikimedia-Logstash, 10Scap3 (scap3-adoption): Deploy kibana with scap3 - https://phabricator.wikimedia.org/T129138#2096720 (10thcipriani) [21:28:57] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy zotero/translation-server with scap3 - https://phabricator.wikimedia.org/T129140#2096718 (10thcipriani) [21:29:00] 10Deployment-Systems, 10scap, 6Discovery, 10Wikidata, and 2 others: Deploy wdqs with scap3 - https://phabricator.wikimedia.org/T129144#2096715 (10thcipriani) [21:29:04] 3releng-201516-q2, 3releng-201516-q3, 10scap, 10Scap3 (scap3-adoption): [keyresult] Migrate all Service team owned services and MW deploys to scap3 - https://phabricator.wikimedia.org/T109926#2096703 (10thcipriani) [21:29:30] that was fun [21:29:46] it was something. [21:29:51] 3Scap3, 10scap, 7Documentation, 15User-mobrovac: Document Scap3 config-deploy - https://phabricator.wikimedia.org/T116634#2096723 (10mmodell) >>! In T116634#2096386, @dduvall wrote: > One option here—completely unverified—might be to use [[ http://jinja.pocoo.org/docs/dev/templates/#call | Jinja2's macro f... [21:30:27] thcipriani: greg-g well done! [21:30:49] a huge list of tasks was exactly what I have in mind ;} [21:30:57] heh, to find info on fluoride: https://www.mediawiki.org/wiki/Fluoride [21:31:10] I have another for you two: get integration/config deployment to be handled by scap3 ;} [21:31:11] such good documentation we have [21:33:43] 3Scap3, 10scap, 7Documentation, 15User-mobrovac: Document Scap3 config-deploy - https://phabricator.wikimedia.org/T116634#2096765 (10mmodell) I guess what I'm saying is, extra layers of abstraction don't help here, it just creates more work for each service to translate it's native config into 'scap style'... [21:34:33] https://phabricator.wikimedia.org/P2717 and https://phabricator.wikimedia.org/diffusion/MFLU/history/master/ make me think fluoride isn't in use? or is it? [21:35:25] 3Scap3, 10scap, 7Documentation, 15User-mobrovac: Document Scap3 config-deploy - https://phabricator.wikimedia.org/T116634#2096768 (10mmodell) but I'm also open to the possibility that jinja2 rocks and we should just convince everyone to start drinking the jinja2 koolaide instead of that yaml koolaide. [21:36:50] 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): remove fluoride from the deployments directory - https://phabricator.wikimedia.org/T129145#2096786 (10ori) a:3ori [21:36:58] greg-g: hmmm...maybe not. It doesn't make much of any appearance in puppet. I don't have permissions to run salt stuffs in prod, so I couldn't say what machines are deployment_targets for it. It _can_ be deployed via salt is all I can say. [21:37:23] thcipriani: I'm asking ori in _security [21:37:56] thcipriani: annnd, an answer "it's dead jim" [21:38:09] yarp. [21:38:49] heh, my email looks awesome, it's like thcipriani and I were in an epic edit war on phab [21:39:58] :( my phone was just continually buzzing during that little task-a-thon [21:40:04] greg-g: and my recent feed in phabricator looks similarly [21:40:17] task-a-thon, nice [21:41:02] thcipriani: you have no sense of fun, or I have a very odd one [21:41:40] heh, one doesn't preclude the other. [21:41:44] lol [21:42:08] I almost rofl'd [21:42:30] hashar: Could you re c+2 https://gerrit.wikimedia.org/r/#/c/275588/ please. [21:45:22] (03CR) 10Yurik: [C: 032] Add Kartographer [tools/release] - 10https://gerrit.wikimedia.org/r/275624 (https://phabricator.wikimedia.org/T127136) (owner: 10MaxSem) [21:46:05] (03Merged) 10jenkins-bot: Add Kartographer [tools/release] - 10https://gerrit.wikimedia.org/r/275624 (https://phabricator.wikimedia.org/T127136) (owner: 10MaxSem) [21:51:31] (03CR) 10Paladox: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/274432 (owner: 10Paladox) [22:01:28] paladox: done :) [22:01:38] hashar: Thanks. [22:01:40] :) [22:11:53] 10Beta-Cluster-Infrastructure, 10Staging, 10DBA, 3Collaboration-Team-Current, and 2 others: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2097031 (10Mattflaschen) >>! In T95871#2087771, @hashar wrote: > The `wikiadmin_pass` was provisioned via a puppet erb template: > ``` >... [22:16:20] (03PS1) 10Paladox: [DebugMode] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275682 [22:23:09] (03PS1) 10Paladox: [DeleteBatch] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275686 [22:25:37] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2097091 (10hashar) I constantly amend/finish up other authors changes. Either because I know the author is not going to respond any time soon... [22:27:52] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#1887024 (10Dzahn) >>! In T121751#1910101, @mmodell wrote: > Taking over someone's change is a rather heavy-handed thing to do so I don't thin... [22:31:12] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2097103 (10mmodell) >>! In T121751#2097093, @Dzahn wrote: >>>! In T121751#1910101, @mmodell wrote: >> Taking over someone's change is a rathe... [22:31:58] (03PS1) 10Paladox: [Disambiguator] Add jshint to check: [integration/config] - 10https://gerrit.wikimedia.org/r/275691 [22:40:43] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2097164 (10mmodell) >>! In T121751#2097091, @hashar wrote: > I constantly amend/finish up other authors changes. Either because I know the au... [22:41:12] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #979: 04FAILURE in 30 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/979/ [22:41:38] (03PS1) 10Paladox: [DiscussionThreading] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275697 [22:42:49] (03PS2) 10Paladox: [DiscussionThreading] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275697 [22:54:55] (03PS1) 10Legoktm: Add "MF cache pollution debug log" live hack [tools/release] - 10https://gerrit.wikimedia.org/r/275701 (https://phabricator.wikimedia.org/T124356) [22:55:01] ostriches: ^ [23:10:56] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2097325 (10hashar) @mmodell straight forward :-} That address **my** concern! [23:11:47] (03PS1) 10Paladox: [Drafts] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/275704 [23:13:39] legoktm: Any idea why BlueSky is showing up in these errors? [23:13:50] which errors? [23:13:51] Those extensions aren't even cloning or installing BlueSky explicitly [23:13:58] e.g. https://gerrit.wikimedia.org/r/#/c/275672/ [23:14:01] https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/5408/consoleFull [23:14:05] More workspace leak? [23:14:16] Something is including it. [23:14:39] https://phabricator.wikimedia.org/T113841 [23:14:57] their are experimental jobs on skins which get them into the generic workspace [23:15:19] and the installer autoloads all present skins while only explicitly enabled extensions for the job are enabled [23:15:32] Ah, Skins are still auto loaded [23:15:34] ugh [23:15:39] can we kill that? [23:15:40] And see https://gerrit.wikimedia.org/r/#/c/269624/ [23:16:04] Except for.. right, there is no easy way to fix that for existing installs. [23:16:10] We shoudl just git-cache and nuke the workspace cleanly [23:16:31] I agree, but who's going to do it? ;) [23:17:17] Well, I can write a book filling bugs it's absence has caused over the last 2 years and continues to create more problems. [23:17:31] I don't priotitize ci-infra issues. [23:17:50] I'm not sure why it's not a priority. [23:18:02] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2097361 (10greg) >>! In T121751#2097164, @mmodell wrote: >>>! In T121751#2097091, @hashar wrote: >> I constantly amend/finish up other author... [23:18:08] legoktm: so we merge that and then clean up the workspace manually? [23:18:40] Well, someone needs to actually edit the config to remove the bad jobs, I just wrote a test case to identify them [23:18:47] And then yeah, nuke all the workspaces [23:19:11] 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Builds from mwext-testextension jobs sometimes pick up tests from unrelated skins - https://phabricator.wikimedia.org/T117710#2097365 (10Krinkle) [23:21:07] 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Builds from mwext-testextension jobs sometimes pick up tests from unrelated skins - https://phabricator.wikimedia.org/T117710#1782002 (10Krinkle) This happens because Jenkins jobs currently use the workspace as an ad-hoc way of caching git clones. Me... [23:21:56] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2097376 (10greg) >>! In T121751#2097103, @mmodell wrote: >>>! In T121751#2097093, @Dzahn wrote: >>>>! In T121751#1910101, @mmodell wrote: >>>... [23:23:11] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2097379 (10greg) With these things documented, is this now resolvable? https://www.mediawiki.org/wiki/Phabricator/Differential [23:26:31] 10Deployment-Systems, 10scap, 6Discovery, 10Wikidata, and 2 others: Deploy wdqs with scap3 - https://phabricator.wikimedia.org/T129144#2097386 (10greg) @Smalyshev just FYI, this will require work from the WDQS team, we aren't going to do it (all) for you (We're of course going to assist). :) Just clarifyi... [23:33:14] 5Gerrit-Migration, 10Differential, 7Documentation, 7WorkType-NewFunctionality: Document gerrit workflows and demonstrate equivalent in arcanist workflows - https://phabricator.wikimedia.org/T117058#2097407 (10mmodell) >>! In T117058#2095777, @Dereckson wrote: > Could we also document on to easily use Arcan... [23:34:41] 5Gerrit-Migration, 10Differential, 7Documentation, 7WorkType-NewFunctionality: Document gerrit workflows and demonstrate equivalent in arcanist workflows - https://phabricator.wikimedia.org/T117058#2097409 (10mmodell) >>! In T117058#2095777, @Dereckson wrote: > Could we also document on to easily use Arcan... [23:47:14] 10Deployment-Systems, 10scap, 6Discovery, 10Wikidata, and 2 others: Deploy wdqs with scap3 - https://phabricator.wikimedia.org/T129144#2097505 (10Smalyshev) @greg Sure, the column means I need something from you (namely, some guidance what is scap3 and what needs to be done) before it can be worked on. [23:48:57] 10Deployment-Systems, 10scap, 6Discovery, 10Wikidata, and 2 others: Deploy wdqs with scap3 - https://phabricator.wikimedia.org/T129144#2097521 (10greg) Cool, will be coming.