[00:00:59] for a while he was changing his nick every other week, I seem to remember [00:01:06] Wasn't that Aaron? [00:01:10] Or Chad too? [00:01:11] I mean, would he get "tacotuesday@" as well? :) [00:01:21] Ooh right [00:01:26] but yeah, Aaron too [00:01:40] and Yuvi [00:13:54] 10Deployment-Systems, 6Release-Engineering-Team, 7Epic: Merge to deployed branches instead of cutting a new deployment branch every week. - https://phabricator.wikimedia.org/T89945#1049275 (10hashar) (sorry wall of text, but I was really curious if we could keep the hotfix commit sha1 across branches. Turns... [00:14:20] greg-g: could I get a deployment window next week for putting UrlShortener in production (but not enabling user facing features yet), see https://phabricator.wikimedia.org/T108557#2113621 [00:17:09] 10Continuous-Integration-Config, 10Deployment-Systems, 6Release-Engineering-Team: Skip running `test` pipeline for wmf branches (gate-and-submit is enough) - https://phabricator.wikimedia.org/T129719#2113847 (10hashar) [00:39:33] legoktm: suuuure [01:59:33] 10Deployment-Systems, 6Release-Engineering-Team, 7Epic: Merge to deployed branches instead of cutting a new deployment branch every week. - https://phabricator.wikimedia.org/T89945#2114060 (10mmodell) @Hashar: You're my hero. This is awesome [02:06:08] 3Scap3, 10scap, 7WorkType-NewFunctionality: Build a dependency graph resolver for deployment stages and tasks - https://phabricator.wikimedia.org/T120684#1858895 (10mmodell) a:5mmodell>3None [02:06:34] 10scap, 10Scap3 (Scap3-Adoption-Phase2), 7WorkType-NewFunctionality: create a scap3 command to bootstrap a new deployment repo - https://phabricator.wikimedia.org/T118760#2114083 (10mmodell) [02:06:59] 10scap, 10Scap3 (Scap3-Adoption-Phase2), 7WorkType-NewFunctionality: create a scap3 command to bootstrap a new deployment repo - https://phabricator.wikimedia.org/T118760#1808552 (10mmodell) p:5Normal>3Low [02:35:12] PROBLEM - Puppet run on deployment-sca02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:35:48] PROBLEM - Puppet run on deployment-sentry01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:36:16] PROBLEM - Puppet run on deployment-puppetmaster is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:37:02] PROBLEM - Puppet run on deployment-conf03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:37:12] PROBLEM - Puppet run on deployment-upload is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:37:48] PROBLEM - Puppet run on deployment-restbase01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:37:58] PROBLEM - Puppet run on deployment-aqs01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:38:58] PROBLEM - Puppet run on deployment-cache-mobile04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:39:04] PROBLEM - Puppet run on deployment-redis01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:39:12] PROBLEM - Puppet run on deployment-fluorine is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:39:14] PROBLEM - Puppet run on deployment-cache-parsoid05 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:39:14] PROBLEM - Puppet run on integration-slave-jessie-1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [04:10:07] 10Beta-Cluster-Infrastructure, 10Parsoid, 6Services: Migrate BetaCluster Node.JS services to Jessie and Node 4.2 - https://phabricator.wikimedia.org/T125003#2114228 (10mobrovac) [04:25:20] Yippee, build fixed! [04:25:21] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #747: 09FIXED in 33 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/747/ [05:58:24] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2114281 (10Dereckson) >>! In T121751#2108555, @mmodell wrote: > Also, I believe you can mark dependencies in Differential from the commit mes... [06:05:47] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2114282 (10mmodell) >>! In T121751#2114281, @Dereckson wrote: > Yes, with `Depends on Dxxx.` So how is this inferior to gerrit? [06:34:02] Yippee, build fixed! [06:34:03] Project browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #46: 09FIXED in 7 min 2 sec: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/46/ [06:41:09] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2114288 (10Dereckson) My statement "//we can mark [On Gerrit] a change depending on another in another repository in the commit message, forg... [08:30:05] 10Continuous-Integration-Config, 10Deployment-Systems, 6Release-Engineering-Team: Skip running `test` pipeline for wmf branches (gate-and-submit is enough) - https://phabricator.wikimedia.org/T129719#2113847 (10Umherirrender) This would make jenkins happy, when not running so much things. test and gate-and-... [08:32:29] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce build #907: 04FAILURE in 22 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/907/ [08:59:54] RECOVERY - Free space - all mounts on deployment-fluorine is OK: OK: All targets OK [09:44:42] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-monobook-sauce build #745: 04FAILURE in 23 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-monobook-sauce/745/ [10:03:06] 10MediaWiki-Codesniffer: Fix the bug of SpaceyParenthesisSniff - https://phabricator.wikimedia.org/T129231#2114437 (10Lethexie) 5Resolved>3Open [10:14:38] 10MediaWiki-Codesniffer: Fix the bug of SpaceyParenthesisSniff - https://phabricator.wikimedia.org/T129231#2114456 (10Lethexie) @Aklapper Should it be closed as RESOLVED util a patch is merged ? I thought mistakenly that it can be changed to RESOLVED once a patch had been submitted. [10:55:11] 10Beta-Cluster-Infrastructure, 10MediaWiki-JobRunner: Beta cluster job queue is quite crowed (~200 k jobs) - https://phabricator.wikimedia.org/T128357#2114497 (10hashar) The graph is the one from Beta. I could not find the MediaWiki.jobqueue.size metric on the labs graphite though :( commonswiki shows deleteL... [11:14:42] PROBLEM - Puppet run on deployment-mediawiki02 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [11:24:41] RECOVERY - Puppet run on deployment-mediawiki02 is OK: OK: Less than 1.00% above the threshold [0.0] [13:15:17] 10Beta-Cluster-Infrastructure: Change the SSL certificate of beta.wmflabs.org to remove SSL warnings/errors - https://phabricator.wikimedia.org/T129740#2114607 (10Pokefan95) [13:31:15] (03PS2) 10Hashar: [Nonlinear] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276816 (owner: 10Paladox) [13:31:17] (03PS2) 10Hashar: [MarkAsHelpful] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276775 (owner: 10Paladox) [13:31:19] (03PS2) 10Hashar: [MWSearch] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276800 (owner: 10Paladox) [13:31:21] (03PS2) 10Hashar: [NaturalLanguageList] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276802 (owner: 10Paladox) [13:31:23] (03PS2) 10Hashar: [NewestPages] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276804 (owner: 10Paladox) [13:31:25] (03PS2) 10Hashar: [MassAction] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276770 (owner: 10Paladox) [13:31:27] (03PS2) 10Hashar: [NewUserNotif] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276807 (owner: 10Paladox) [13:31:29] (03PS2) 10Hashar: [Mailgun] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/276768 (owner: 10Paladox) [13:31:31] (03PS2) 10Hashar: [OpenID] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276824 (owner: 10Paladox) [13:31:33] (03PS2) 10Hashar: [MolHandler] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276782 (owner: 10Paladox) [13:31:35] (03PS2) 10Hashar: [NoBogusUserpages] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276811 (owner: 10Paladox) [13:31:37] (03PS2) 10Hashar: [MixedNamespaceSearchSuggestions] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276780 (owner: 10Paladox) [13:31:39] (03PS2) 10Hashar: [MultiMaps] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276794 (owner: 10Paladox) [13:31:41] (03PS2) 10Hashar: [OpenIDConnect] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/276831 (owner: 10Paladox) [13:32:28] (03PS1) 10Hashar: Merge in npm/jshint/jsonlint related changes [integration/config] - 10https://gerrit.wikimedia.org/r/276962 [13:58:56] hashar: Hi thanks. [13:59:54] hashar: Could you merge https://gerrit.wikimedia.org/r/#/c/276119/ please. Plus there are a few others that were a bit furthur back to merge please. [14:00:21] hashar: https://gerrit.wikimedia.org/r/#/q/status:open+project:integration/config+branch:master,n,z [14:00:34] https://gerrit.wikimedia.org/r/#/q/status:open+project:integration/config+branch:master+owner:%22Paladox+%253Cthomasmulhall410%2540yahoo.com%253E%22,n,z [14:02:05] hashar: Im planing on doing the migration in one patch so there will be mutiple patches but one per couple to make it faster and easisar for you to review. [14:02:28] Im going to do the ones with js files seperate but ones like jsonlint can all be put together. [14:06:19] :) [14:08:04] 10MediaWiki-Codesniffer: Fix the bug of SpaceyParenthesisSniff - https://phabricator.wikimedia.org/T129231#2114687 (10Aklapper) See https://www.mediawiki.org/wiki/Bug_management/Bug_report_life_cycle - if no code has been merged, nothing has been resolved for anybody... I still don't know what "the bug" is in t... [14:28:41] hashar: Hi it says this https://integration.wikimedia.org/ci/job/composer-php55/4921/console [14:29:16] but it passes the hhvm one. [14:31:22] (03PS1) 10Paladox: [OpenID] Switch from generic test to composer test [integration/config] - 10https://gerrit.wikimedia.org/r/276969 [14:32:57] (03PS2) 10Paladox: [OpenID] Switch from generic test to composer test [integration/config] - 10https://gerrit.wikimedia.org/r/276969 [14:34:28] paladox: sorry I wasn't looking at IRC [14:34:37] paladox: I got a few npm patches merged / reviewed / tweaked etc :-} [14:34:45] hashar: Ok, thanks. [14:34:54] heading for a quick nap now ! have a good week-end! [14:35:04] hashar: Ok thanks and you too. [14:35:06] will handle the rest Monday afternoon [14:35:14] hhashar: Ok. [14:36:42] hashar: Would you like me to do a mass migration whereby i do them in the same patch but will do them over a couple of patches. [14:36:48] Will be easisar for you. [14:36:54] one by one is fine [14:36:59] ok. [14:37:15] the way I do it is quite easy to handle [14:37:26] I look for patches in integration/config [14:37:30] open each in a new browser tab [14:37:34] hashar: Ok, ive found a few extensions that have been archived. [14:37:35] Ok. [14:37:42] then cherry pick them one by one on my machine. Review and send to Gerrit [14:37:55] hashar: Oh [14:37:57] I then craft a merge commit of all the patches I have selected and send it for review [14:38:14] hashar: Ok so that makes it very easy :) [14:38:24] then review the Zuul diff of the merge commit. If happy I git push the merge commit in the repo [14:38:30] that get Gerrit to merge all the change [14:38:49] ok [14:39:01] then I head back to my browser tab, since for each integration/config change you have listed the commit in the mediawiki/extensions/* repo, I just click the link and review + hit CR+2 [14:39:08] then catch up with whatever fail -:} [14:39:19] hashar: Oh, ok. [14:39:23] :) [14:39:33] so quite easy :-} [14:39:58] the really long thing is to craft the package.json in the source repo and fix whatever issue there might be there [14:40:06] and doing the zuul/layout.yaml edit [14:40:28] the actual merge is fast ;-} [14:40:56] hashar: Yeh. I have a folder i created one called npm-json and one npm the npm is the one with jshint and json one is the one with jsonlint, all i have to do is copy and paste then i push merge and see if it passes. [14:41:02] paladox: as for MultiMaps tests failing with Zend PHP, that is due to the "float" type precision [14:41:12] it is not precise enough to handle the values used in the tests [14:41:20] hashar: Oh [14:41:28] 10MediaWiki-Codesniffer: Fix SpaceyParenthesisSniff can't fix not single space after opening parenthesis and before closing parenthesis - https://phabricator.wikimedia.org/T129231#2114723 (10Lethexie) [14:41:39] compare [14:41:39] 60.930432202923335 [14:41:40] 60.930432202923001 [14:41:40] hashar: It seems gmp is not installed on composer-php55 but is on composer-hhvm [14:41:54] unrelated [14:42:03] hashar: ok. [14:42:07] I suspect HHVM has a better precision for floats ;) [14:42:23] hashar: Yes plus it includes facebooks own changes. [14:42:29] so essentially the whole extension is broken ;)) [14:42:44] hashar: Yes, dosent look very active either. [14:43:44] 10MediaWiki-Codesniffer: Fix SpaceyParenthesisSniff can't fix not single space after opening parenthesis and before closing parenthesis - https://phabricator.wikimedia.org/T129231#2114724 (10Lethexie) @Aklapper I hava changed the summary of this task (T_T) [14:45:49] paladox: for https://gerrit.wikimedia.org/r/#/c/276968/ you should link to the task I created earlier https://phabricator.wikimedia.org/T129744 [14:46:14] hashar: Ok thanks i will do that now. [14:46:26] paladox: and you want to update the README file dramatically ;-} [14:46:34] it says to git clone [14:46:45] should be all about running "composer update" from the MediaWiki core base directory [14:47:16] * hashar and after that, one will want to actually setup OpenId and verify it works properly [14:47:20] 10Beta-Cluster-Infrastructure: Change the SSL certificate of beta.wmflabs.org to remove SSL warnings/errors - https://phabricator.wikimedia.org/T129740#2114607 (10Southparkfan) Duplicate of T50501? [14:49:24] hashar: Ok. [14:50:07] I am off ! [14:51:14] PROBLEM - Host cache-rsync is DOWN: CRITICAL - Host Unreachable (10.68.23.165) [14:56:15] 10Beta-Cluster-Infrastructure: Change the SSL certificate of beta.wmflabs.org to remove SSL warnings/errors - https://phabricator.wikimedia.org/T129740#2114607 (10Paladox) You can use https://letsencrypt.org/ which is free and trusted and funded by big company's such as facebook. [15:19:05] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-CentralAuth, 7Beta-Cluster-reproducible: Could not find local user data for - https://phabricator.wikimedia.org/T115198#2114779 (10Southparkfan) Still occuring in REL1_26 (reported a while ago in T115198#1948270, ran checkLocalUser.php --delete for those... [16:31:50] Krinkle hi dosent https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests-mysql-hhvm/8944/console test need converting to use the phpunit from mediawiki/core. [16:41:13] jzerebecki: ^^ too. [18:31:12] paladox: It already does [18:31:24] "PHPUnit already present" " PHPUnit 4.8.23 " [18:31:28] it doesn't use PHPUnit 3.7.x [18:31:54] Oh ok [18:33:16] You are right that it still mentions the old "/srv/deploymenet/integration/phpunit" path and that could be cleaned up, but it doesn't cause any issue [18:33:30] I think it was already removed in integration-config, but not yet recompiled [18:34:34] ok [22:29:50] 5Gerrit-Migration, 10Differential, 7Documentation: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2115082 (10mmodell) >>! In T121751#2114288, @Dereckson wrote: > But that doesn't address one of the need expressed by @hashar and @Ricordisam... [23:27:42] 10Beta-Cluster-Infrastructure: Change the SSL certificate of beta.wmflabs.org to remove SSL warnings/errors - https://phabricator.wikimedia.org/T129740#2115134 (10Pokefan95) >>! In T129740#2114729, @Southparkfan wrote: > Duplicate of T50501? I think this is not a duplicate, as the task you stated is about addin... [23:46:30] 10Beta-Cluster-Infrastructure: Change the SSL certificate of beta.wmflabs.org to remove SSL warnings/errors - https://phabricator.wikimedia.org/T129740#2115138 (10Krenair) [23:46:37] 10Beta-Cluster-Infrastructure, 6Labs, 10Labs-Infrastructure, 6Operations: beta: Get SSL certificates for *.{projects}.beta.wmflabs.org - https://phabricator.wikimedia.org/T50501#2115139 (10Krenair) [23:48:15] 10Beta-Cluster-Infrastructure: Change the SSL certificate of beta.wmflabs.org to remove SSL warnings/errors - https://phabricator.wikimedia.org/T129740#2115141 (10Pokefan95) >>! In T129740#2114738, @Paladox wrote: > You can use https://letsencrypt.org/ which is free and trusted and funded by big company's such a... [23:51:46] lol [23:53:58] 10Beta-Cluster-Infrastructure: Change the SSL certificate of beta.wmflabs.org to remove SSL warnings/errors - https://phabricator.wikimedia.org/T129740#2114607 (10Reedy) >>! In T129740#2115141, @Pokefan95 wrote: > Hmm... I don't recommend Let's Encrypt at the moment, because their intermediate certificate is not... [23:56:52] lol [23:56:56] this reminds me [23:57:08] I really need to deal with LE on beta :/ [23:57:24] I have a big list of domains in some email somewhere [23:59:59] https://www.mediawiki.org/wiki/Compatibility#Browsers really could do with an update