[00:07:30] (03PS2) 10Reedy: Don't branch OAI anymore [tools/release] - 10https://gerrit.wikimedia.org/r/277231 (https://phabricator.wikimedia.org/T70867) [00:07:40] (03CR) 10Reedy: [C: 032] Don't branch OAI anymore [tools/release] - 10https://gerrit.wikimedia.org/r/277231 (https://phabricator.wikimedia.org/T70867) (owner: 10Reedy) [00:23:17] (03Merged) 10jenkins-bot: Don't branch OAI anymore [tools/release] - 10https://gerrit.wikimedia.org/r/277231 (https://phabricator.wikimedia.org/T70867) (owner: 10Reedy) [00:23:44] (03Abandoned) 10Krinkle: Archive ArticleFeedbackv5 extension [integration/config] - 10https://gerrit.wikimedia.org/r/277275 (owner: 10Krinkle) [00:24:11] Reedy: s/OAI// [00:24:16] soon :) [00:24:25] lol [00:24:31] (Don't branch anymore) [00:25:52] Yeah, I know what s/foo/bar/ means ;) [00:40:21] Reedy: :) of course, just clarifying I'm talking about the literal message, and not the wider reality from which OAI will also be removed. [03:04:52] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #911: 04FAILURE in 14 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/911/ [03:11:40] 10MediaWiki-Codesniffer, 7Easy: Add sniff to detect usage of deprecated $wgUser - https://phabricator.wikimedia.org/T50963#2121258 (10Aashaka) @Addshore, I think that @hashar's patch with changes to the description and a few other changes is what I had in mind. May I amend @hashar's patch, or submit a new one?... [04:26:03] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #750: 04FAILURE in 34 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/750/ [05:29:59] Yippee, build fixed! [05:30:00] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #727: 09FIXED in 27 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/727/ [06:33:17] PROBLEM - Puppet run on deployment-memc02 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [07:02:58] RECOVERY - Free space - all mounts on deployment-fluorine is OK: OK: All targets OK [07:05:32] PROBLEM - Puppet run on deployment-salt is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [07:10:57] PROBLEM - Puppet run on integration-slave-trusty-1018 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [07:32:41] (03CR) 10Polybuildr: "Hello :) You should amend your patch here instead of submitting a new one. You can `git commit --amend` the previous commit and then submi" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/276466 (https://phabricator.wikimedia.org/T129474) (owner: 10Schenkerx) [07:40:37] RECOVERY - Puppet run on deployment-salt is OK: OK: Less than 1.00% above the threshold [0.0] [07:46:04] RECOVERY - Puppet run on integration-slave-trusty-1018 is OK: OK: Less than 1.00% above the threshold [0.0] [10:32:27] Yippee, build fixed! [10:32:28] Project browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox » hr,contintLabsSlave && UbuntuTrusty build #92: 09FIXED in 31 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox/LANGUAGE_SCREENSHOT_CODE=hr,label=contintLabsSlave%20&&%20UbuntuTrusty/92/ [11:46:45] 10MediaWiki-Codesniffer: Add the SpaceBeforeControlStructureBraceSniff for enforcing single space between closing parenthesis and opening brace - https://phabricator.wikimedia.org/T130004#2122233 (10Lethexie) [11:47:16] (03PS5) 10Lethexie: Add the SpaceBeforeControlStructureBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T89682) [11:53:46] (03PS2) 10Hashar: [ParserHooks] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277077 (owner: 10Paladox) [11:53:48] (03PS2) 10Hashar: [PageBlock] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277075 (owner: 10Paladox) [11:53:50] (03PS2) 10Hashar: [Prezi] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277083 (owner: 10Paladox) [11:53:52] (03PS2) 10Hashar: [Patroller] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277081 (owner: 10Paladox) [11:55:03] (03PS1) 10Hashar: Merge in npm/jshint/jsonlint related changes [integration/config] - 10https://gerrit.wikimedia.org/r/277494 [12:01:43] (03PS2) 10Hashar: [AutoProxyBlock] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277316 (owner: 10Paladox) [12:01:45] (03PS2) 10Hashar: [ArticleIndex] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277110 (owner: 10Paladox) [12:01:47] (03PS2) 10Hashar: [ApiExplorer] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277105 (owner: 10Paladox) [12:01:49] (03PS2) 10Hashar: [AccessControl] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277086 (owner: 10Paladox) [12:01:51] (03PS2) 10Hashar: [AWSSDK] Add npm test and add composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/277324 (owner: 10Paladox) [12:01:53] (03PS2) 10Hashar: [Awesomeness] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277320 (owner: 10Paladox) [12:01:55] (03PS2) 10Hashar: [AddHTMLMetaAndTitle] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277093 (owner: 10Paladox) [12:01:57] (03PS2) 10Hashar: [ActionEditSubmit] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277092 (owner: 10Paladox) [12:01:59] (03PS2) 10Hashar: [AdManager] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277095 (owner: 10Paladox) [12:02:01] (03PS2) 10Hashar: [Auth_remoteuser] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277296 (owner: 10Paladox) [12:02:03] (03PS2) 10Hashar: [AddThis] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277094 (owner: 10Paladox) [12:02:05] (03PS2) 10Hashar: [AuthorProtect] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277300 (owner: 10Paladox) [12:02:07] (03PS2) 10Hashar: [AutoCreateCategoryPages] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277304 (owner: 10Paladox) [12:02:09] (03PS2) 10Hashar: [AnchorHandler] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277102 (owner: 10Paladox) [12:02:11] (03PS2) 10Hashar: [AutomaticBoardWelcome] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277309 (owner: 10Paladox) [12:02:13] (03PS1) 10Hashar: Merge in npm/jshint/jsonlint related changes [integration/config] - 10https://gerrit.wikimedia.org/r/277496 [12:08:41] Project browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox » ms,contintLabsSlave && UbuntuTrusty build #92: 04FAILURE in 2 hr 7 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox/LANGUAGE_SCREENSHOT_CODE=ms,label=contintLabsSlave%20&&%20UbuntuTrusty/92/ [12:20:04] 10Browser-Tests-Infrastructure, 6Release-Engineering-Team, 7Epic, 13Patch-For-Review, 7Tracking: Fix scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily - https://phabricator.wikimedia.org/T94150#2122273 (10zeljkofilipin) [12:33:16] (03CR) 10Schenkerx: "Thanks!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/276466 (https://phabricator.wikimedia.org/T129474) (owner: 10Schenkerx) [12:35:50] hashar, jzerebecki: uh oh, wikidata browser tests jobs are failing with "requests.exceptions.ConnectionError: HTTPConnectionPool(host='wikidata.beta.wmflabs.org', port=80): Max retries exceeded with url: /w/api.php?action=query&meta=siteinfo&siprop=general&format=json (Caused by : [Errno -2] Name or service not known)" [12:35:57] example: https://integration.wikimedia.org/ci/view/BrowserTests/view/Wikidata/job/browsertests-Wikidata-WikidataTests-linux-firefox-sauce/557/console [12:36:52] "Max retries exceeded with url: /w/api.php..." [12:43:38] 10Browser-Tests-Infrastructure, 10Wikidata: Wikidata browser tests failing with "Max retries exceeded with url: /w/api.php" - https://phabricator.wikimedia.org/T130007#2122318 (10zeljkofilipin) [12:43:55] reported as https://phabricator.wikimedia.org/T130007 [12:45:35] 10Browser-Tests-Infrastructure, 6Release-Engineering-Team, 7Epic, 13Patch-For-Review, 7Tracking: Fix scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily - https://phabricator.wikimedia.org/T94150#2122333 (10zeljkofilipin) [12:45:49] 10Browser-Tests-Infrastructure, 10Wikidata: Wikidata browser tests failing with "Max retries exceeded with url: /w/api.php" - https://phabricator.wikimedia.org/T130007#2122318 (10zeljkofilipin) [12:52:10] Yippee, build fixed! [12:52:10] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #912: 09FIXED in 23 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/912/ [12:54:09] 10MediaWiki-Codesniffer: Add SpaceBeforeControlStructureBraceSniff to enforce single space between closing parenthesis and opening brace - https://phabricator.wikimedia.org/T130004#2122345 (10Aklapper) [12:54:14] Project browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #792: 04FAILURE in 13 sec: https://integration.wikimedia.org/ci/job/browsertests-GettingStarted-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/792/ [13:07:20] hashar: Hi thanks for merging my patches. [13:22:40] 10Continuous-Integration-Config, 10Mathoid, 15User-mobrovac: Enable node4 for mathoid tests (mathoid/deploy tests fail) - https://phabricator.wikimedia.org/T124447#2122370 (10hashar) This is how I reproduce it on my local machine: ``` cd mediawiki/services/mathoid/deploy export NPM_SET_PATH=./src export NODE... [13:25:42] hashar: hey, can you give me patroller right in en.beta? I think I know what's causing this [13:33:06] Yippee, build fixed! [13:33:07] Project browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox » br,contintLabsSlave && UbuntuTrusty build #92: 09FIXED in 3 hr 31 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox/LANGUAGE_SCREENSHOT_CODE=br,label=contintLabsSlave%20&&%20UbuntuTrusty/92/ [13:39:37] (03PS1) 10Mobrovac: npm-install-dev.py: Use config.dev.yaml instead of config.yaml [integration/jenkins] - 10https://gerrit.wikimedia.org/r/277508 (https://phabricator.wikimedia.org/T124447) [13:39:48] hashar: ^ [13:48:40] o/ [13:48:54] Wondering about scap3 vs. fabric in prod. [13:49:35] Currently, we use fabric to do deploys (staging and live) for ORES in wmflabs. [13:50:03] I talked to Yuvipanda about scap3 a bit before he went on vacation. I got the impression that scap3 was required for moving ORES to the prod cluster. [13:50:17] Is this true? Or are fabric deploy scripts OK? [13:54:59] For something not in prod yet? Yeah scap3 is what we'd support. [13:56:38] I don't even think we have `fab` installed in prod? [13:58:05] Good morning, all! I’m preparing to do some tricky migrations of dns addresses, so I’m looking at a big dump of all the addresses currently used in labs. [13:58:24] Deployment-prep has a bunch of addresses under beta.wmflabs.org but it also has a lot that are /not/ under the beta domain. [13:58:38] For example: *.m.wikisource.wmflabs.org [13:58:58] *.m.wikiquote.wmflabs.org [13:59:13] I have a technical question: what’s up with that? [14:02:46] andrewbogott: I have a very complicated technical answer: I have no idea why they're not! [14:03:30] ostriches: ok, I guess I’ll send an email to releng [14:04:20] Offhand I'd guess it was just...how we set them up...and there's no reason they couldn't be under *.beta.wmflabs.org [14:04:34] But I could be making things up. No coffee yet [14:06:21] 10Continuous-Integration-Config, 10Mathoid, 13Patch-For-Review, 15User-mobrovac: Enable node4 for mathoid tests (mathoid/deploy tests fail) - https://phabricator.wikimedia.org/T124447#2122420 (10hashar) Demo debug change is https://gerrit.wikimedia.org/r/#/c/277505/ [14:06:48] (03CR) 10Hashar: [C: 032] npm-install-dev.py: Use config.dev.yaml instead of config.yaml [integration/jenkins] - 10https://gerrit.wikimedia.org/r/277508 (https://phabricator.wikimedia.org/T124447) (owner: 10Mobrovac) [14:07:06] andrewbogott: hashar may know... [14:07:31] (03Merged) 10jenkins-bot: npm-install-dev.py: Use config.dev.yaml instead of config.yaml [integration/jenkins] - 10https://gerrit.wikimedia.org/r/277508 (https://phabricator.wikimedia.org/T124447) (owner: 10Mobrovac) [14:08:14] !log Deploying slave script change https://gerrit.wikimedia.org/r/#/c/277508/ "npm-install-dev.py: Use config.dev.yaml instead of config.yaml" for T124447 [14:08:16] T124447: Enable node4 for mathoid tests (mathoid/deploy tests fail) - https://phabricator.wikimedia.org/T124447 [14:08:17] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [14:10:04] andrewbogott: yeah I can help on beta.wmflabs.org entries [14:10:25] We have a few wildcard ones like *.m..wmflabs.org [14:10:44] oh man sorry [14:11:00] an example is http://en.m.wikipedia.beta.wmflabs.org/ [14:11:01] https://www.irccloud.com/pastebin/hGBgLcCC/ [14:11:09] so *.m..beta.wmflabs.org [14:11:23] the ones without ".beta." can probably be dropped (eg: *.m.wikiquote.wmflabs.org ) [14:11:38] stream.wmflabs.org is for RCStream I guess [14:11:44] a system to listen for recent changes [14:12:45] it should be stream.beta.wmflabs.org though, right? [14:14:32] !log Refreshing Nodepool snapshot images so it get a fresh copy of slave-scripts T124447 [14:14:33] T124447: Enable node4 for mathoid tests (mathoid/deploy tests fail) - https://phabricator.wikimedia.org/T124447 [14:14:34] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [14:14:42] 10Browser-Tests-Infrastructure, 10Wikidata: Wikidata browser tests failing with "Max retries exceeded with url: /w/api.php" - https://phabricator.wikimedia.org/T130007#2122439 (10JanZerebecki) $ curl -v 'http://wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page' * Could not resolve host: wikidata.beta.wmflabs.org [14:14:46] andrewbogott: I have no idea what is the canonical / public entry point for rc stream on beta [14:15:01] hashar: ok. I sent an email, we’ll see what other folks say [14:15:03] thanks [14:16:00] there is no entry in the web proxy at least [14:17:10] hashar: relatedly… what do those “*.m.beta.wmflabs.org” domains do? Do those wildcards really work? [14:17:14] and there is indeed a stream.wmflabs.org entry for the beta cluster instance handling it [14:17:17] andrewbogott: any idea why wikidata.beta.wmflabs.org can not be resolved anymore? [14:17:39] I think the issue is that *.beta.wmflabs.org wildcard entry points to the Varnish text cache. [14:18:03] (for rcstream) [14:18:14] so we ended up with a host entry under .wmflabs.org [14:19:05] jzerebecki: There were several dns records that were bound to IPs but the IPs were not themselves bound to VMs. [14:19:14] I think this was one. [14:19:25] !log Image ci-jessie-wikimedia-1458051246 in wmflabs-eqiad is ready T124447 [14:19:26] T124447: Enable node4 for mathoid tests (mathoid/deploy tests fail) - https://phabricator.wikimedia.org/T124447 [14:19:26] but I’m not sure, exactly — did it do something useful previously? Besides just resolve? [14:19:28] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [14:20:14] andrewbogott: yup that domain is the deployment prep beta equivalent of www.wikidata.org in production [14:20:16] ostriches, thanks for your response re. scap3. Regarding fab, I don't believe that you need anything installed in the cluster. I'd run fab from my own laptop. It uses ssh and lists of machines to execute commands remotely (e.g. pull version from repo, restart service) [14:20:27] jzerebecki: so it points to a host? [14:20:37] or, should? [14:20:54] halfak: Point being though that we'd need the package installed on the deployment master though, which we don't have [14:21:15] (also: scap3 does basically the same thing. funny about that :)) [14:21:21] jzerebecki: all this is managed on https://wikitech.wikimedia.org/wiki/Special:NovaAddress, you can most likely recreate it [14:21:22] andrewbogott: https://wikitech.wikimedia.org/wiki/Special:NovaAddress for deployment-prep lists *.beta.wmflabs.org as pointing to deployment-cache-text04.deployment-prep.eqiad.wmflabs [14:22:50] ostriches, still not clear about how this works with the "deployment master". [14:23:00] Is that a machine that manages all deploys? [14:23:08] And thus why it would need fab or scap installed? [14:23:09] Yep yep [14:23:14] OK. [14:23:17] * halfak learns. [14:23:29] So it'll be critical that we can get scap3 worked out [14:23:43] Yeah, but we're here to help with that :) [14:24:02] If it's /just/ a matter of pulling some code and restating a service (node?), we should be able to handle all that already [14:24:48] ostriches, that's going to generally be the case. [14:24:54] Are these docs up to date? https://doc.wikimedia.org/mw-tools-scap/index.html [14:25:03] Yep, those are auto-generated from master. [14:25:14] kk [14:25:18] Thanks ostriches :) [14:25:43] yw. you want the 3.0 docs. basically everything in the 2.0 section is mw-specific and going to change so don't worry about it :) [14:25:58] kk [14:27:06] ostriches, any other reading you recommend for learning about the deploy master and how we'll work with it? [14:28:43] Hmm, those docs should mostly cover the scap-y parts of it. tldr for how the master works is you'll ssh to tin (or mira, depending on dc). All the deployments live in /srv/deployments. You hop into your directory, do whatever git magic you need (checkout, pull, etc etc etc), then `deploy` does all the work [14:29:12] It'll go through the list of steps configured for your repo (pull code, restart services, status checks, etc) and then report back. [14:29:23] There's also rollback logic in case it goes BOOM halfway thru [14:29:59] ostriches, OK. make sense. [14:30:17] Would you mind if I copy and paste your last 3 messages in our phab task for notes? [14:30:17] We also have logic for doing subset of the full cluster deploys too, so you can do canary tests, etc. [14:30:23] Go for it :) [14:31:40] 10Continuous-Integration-Config, 10Mathoid, 13Patch-For-Review, 15User-mobrovac: Enable node4 for mathoid tests (mathoid/deploy tests fail) - https://phabricator.wikimedia.org/T124447#2122522 (10hashar) I have hacked the job to show a few things: ``` 14:30:55 + ls -l src/config.dev.yaml src/config.prod.yam... [14:31:49] For the curious: https://phabricator.wikimedia.org/T128670 [14:42:44] 5Continuous-Integration-Scaling, 6Services, 7Tracking, 7WorkType-NewFunctionality: [tracking] Migrate services CI jobs to node 4.3 - https://phabricator.wikimedia.org/T126991#2122542 (10mobrovac) [14:42:47] 10Continuous-Integration-Config, 10Mathoid, 15User-mobrovac: Enable node4 for mathoid tests (mathoid/deploy tests fail) - https://phabricator.wikimedia.org/T124447#2122538 (10mobrovac) 5stalled>3Resolved The tests are now passing, Merci beaucoup @hashar for your help! [14:46:50] 5Continuous-Integration-Scaling, 6Services, 7Tracking, 7WorkType-NewFunctionality: [tracking] Migrate services CI jobs to node 4.3 - https://phabricator.wikimedia.org/T126991#2122550 (10hashar) [14:50:14] zeljkof: jzerebecki: I will not be able to attend the CI meeting today [14:50:21] last minute change ;( [14:50:44] one good thing is that wikidata no more rely on integration/Phpunit [14:50:57] and all mw services npm jobs are on Nodepool (exception are the parsoid jobs) [14:51:12] hashar: thx for fixing what I broke in core :) [14:51:12] hashar: ok, if jzerebecki is around, I would like to chat about wikidata browser tests [14:54:25] zeljkof: i'll be there [14:57:11] (03CR) 10Reedy: [C: 04-1] Fix IfElseStructureSniff can't detect and fix multiple white spaces after else (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277227 (https://phabricator.wikimedia.org/T129840) (owner: 10Lethexie) [14:57:12] jzerebecki: see you soon then [14:58:07] (03CR) 10Reedy: [C: 04-1] Add the SpaceBeforeControlStructureBraceSniff (036 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T89682) (owner: 10Lethexie) [15:01:28] jzerebecki: hoo proposed a patch for wikidata phpunit-dir yesterday :-} I have merely +2 ! [15:10:49] (03CR) 10Aklapper: "I have a hard time to understand the commit message, maybe because there is "fix" two times: Does "Fix IfElseStructureSniff can't detect a" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277227 (https://phabricator.wikimedia.org/T129840) (owner: 10Lethexie) [15:13:40] (03CR) 10Aklapper: [C: 04-1] "Please use proper capitalization and whitespace (in front of commas) in the commit message, plus wrap lines as explained in https://www.me" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T89682) (owner: 10Lethexie) [15:14:08] 7Browser-Tests, 10Continuous-Integration-Config, 10Wikidata, 3Wikidata-Sprint-2016-03-15: [Task] Move Wikidata browsertests into Wikibase repository - https://phabricator.wikimedia.org/T118727#2122640 (10Tobi_WMDE_SW) [15:15:03] (03CR) 10Aklapper: "Please use proper capitalization in the commit message, plus wrap lines as explained in https://www.mediawiki.org/wiki/Gerrit/Commit_messa" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/276110 (https://phabricator.wikimedia.org/T89682) (owner: 10Lethexie) [15:17:42] !log added wikidata.beta.wmflabs.org in https://wikitech.wikimedia.org/wiki/Special:NovaAddress to deployment-cache-text04.deployment-prep.eqiad.wmflabs [15:17:45] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [15:19:22] 10Browser-Tests-Infrastructure, 10Wikidata: Wikidata browser tests failing with "Max retries exceeded with url: /w/api.php" - https://phabricator.wikimedia.org/T130007#2122668 (10JanZerebecki) `!log added wikidata.beta.wmflabs.org in https://wikitech.wikimedia.org/wiki/Special:NovaAddress to deployment-cache-t... [15:22:46] 7Browser-Tests, 10Browser-Tests-Infrastructure, 10Continuous-Integration-Config: [Task] Remove Wikidata performance-tests jobs - https://phabricator.wikimedia.org/T130017#2122670 (10Tobi_WMDE_SW) [15:23:03] 7Browser-Tests, 10Browser-Tests-Infrastructure, 10Continuous-Integration-Config, 10Wikidata: [Task] Remove Wikidata performance-tests jobs - https://phabricator.wikimedia.org/T130017#2122682 (10Tobi_WMDE_SW) [15:24:01] 7Browser-Tests, 10Wikidata: Make Wikidata performance test again able to load Italy - https://phabricator.wikimedia.org/T119950#2122689 (10Tobi_WMDE_SW) 5Open>3declined We now have https://grafana.wikimedia.org/dashboard/db/wikidata-webpagetest, and do not need this job anymore. Created T130017 to remove it. [15:26:45] 10Browser-Tests-Infrastructure, 10Wikidata, 13Patch-For-Review, 7Upstream: [Bug] fix negative argument (ArgumentError) in browsertests - https://phabricator.wikimedia.org/T110510#2122712 (10Tobi_WMDE_SW) Can this be closed? [15:26:55] 10Browser-Tests-Infrastructure, 10Wikidata: No test report files were found: job fails in jenkins but is shown as successful in raita - https://phabricator.wikimedia.org/T116164#2122715 (10Tobi_WMDE_SW) Can this be closed? [15:29:07] 7Browser-Tests, 10Continuous-Integration-Config, 10Wikidata, 3Wikidata-Sprint-2016-03-15: [Task] Move Wikidata browsertests into Wikibase repository - https://phabricator.wikimedia.org/T118727#2122721 (10JanZerebecki) [15:34:29] 7Browser-Tests, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Task] Thin out scenario outlines on data value browsertest - https://phabricator.wikimedia.org/T95420#2122746 (10Tobi_WMDE_SW) [15:34:32] 7Browser-Tests, 10Wikidata: move testing things from browser tests to qunit or phpunit tests where possible - https://phabricator.wikimedia.org/T118283#2122745 (10Tobi_WMDE_SW) [15:37:04] 10Browser-Tests-Infrastructure, 6Release-Engineering-Team, 7Epic, 13Patch-For-Review, 7Tracking: Fix scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily - https://phabricator.wikimedia.org/T94150#2122762 (10JanZerebecki) [15:37:06] 10Browser-Tests-Infrastructure, 10Wikidata: Wikidata browser tests failing with "Max retries exceeded with url: /w/api.php" - https://phabricator.wikimedia.org/T130007#2122760 (10JanZerebecki) 5Open>3Resolved a:3JanZerebecki [15:39:13] Yippee, build fixed! [15:39:14] Project browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox » yue,contintLabsSlave && UbuntuTrusty build #92: 09FIXED in 5 hr 37 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox/LANGUAGE_SCREENSHOT_CODE=yue,label=contintLabsSlave%20&&%20UbuntuTrusty/92/ [15:40:34] 7Browser-Tests, 10Wikidata: [Task] Find a sensible subset of browsertests that could be run on each commit - https://phabricator.wikimedia.org/T130019#2122791 (10Tobi_WMDE_SW) [15:41:12] halfak: huggle-rc.wmflabs.org looks to me like an abandoned relic… may I free up that address? [15:41:14] 7Browser-Tests, 10Continuous-Integration-Config, 10Wikidata, 3Wikidata-Sprint-2016-03-15: [Task] Move Wikidata browsertests into Wikibase repository - https://phabricator.wikimedia.org/T118727#2122803 (10Tobi_WMDE_SW) [15:41:31] o/ andrewbogott [15:41:38] I dunno. I'm not a huggle maintainer [15:41:42] oh [15:41:43] You might be thinking of Snuggle. [15:41:45] you’re right, sorry [15:41:49] My huggle critique :D [15:42:05] (03PS3) 10Lethexie: Also check for space after elseif in SpaceAfterControlStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/276110 (https://phabricator.wikimedia.org/T89682) [15:42:12] andrewbogott, try in #huggle [15:43:18] Yippee, build fixed! [15:43:19] Project browsertests-Wikidata-PerformanceTests-linux-firefox build #137: 09FIXED in 20 sec: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-PerformanceTests-linux-firefox/137/ [15:43:33] (03PS2) 10Schenkerx: Improve invalid whitespaces in comment detection. [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/276466 (https://phabricator.wikimedia.org/T129474) [15:45:43] (03Abandoned) 10Schenkerx: Fix trailing spaces and convert spaces to tabs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277235 (https://phabricator.wikimedia.org/T129474) (owner: 10Schenkerx) [15:49:11] Yippee, build fixed! [15:49:11] Project browsertests-Wikidata-PerformanceTests-linux-firefox-sauce build #564: 09FIXED in 29 sec: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-PerformanceTests-linux-firefox-sauce/564/ [15:50:23] 7Browser-Tests, 10Browser-Tests-Infrastructure, 10Continuous-Integration-Config, 10Wikidata: [Task] Remove Wikidata performance-tests jobs - https://phabricator.wikimedia.org/T130017#2122816 (10zeljkofilipin) I am fine with deleting the jobs, just a note that they are fixed, they were broken because of inf... [15:51:39] hashar: Should the layout.yaml file be done alphabetically, i mean just the mediawiki extensions and skins since there all over the place. But that would be a bigger task. [15:59:08] PROBLEM - SSH on deployment-conftool is CRITICAL: Server answer [16:07:50] Do we still use refresh-dblist? [16:11:28] Project browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox » zh-hans,contintLabsSlave && UbuntuTrusty build #92: 04FAILURE in 6 hr 10 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox/LANGUAGE_SCREENSHOT_CODE=zh-hans,label=contintLabsSlave%20&&%20UbuntuTrusty/92/ [16:12:07] thcipriani: is "staging.wmflabs.org using staging in project mobile” you? [16:12:30] Anything staging can be killed. [16:12:41] except it’s not in the ‘staging’ project [16:12:51] so it’s possible that someone in the mobile project is using that word differently... [16:12:52] andrewbogott: that's not me [16:12:52] Oh what? [16:12:54] Weird.... [16:13:20] What's it point to? [16:13:52] staging.wmflabs.org and staging-zero.wmflabs.org both point to staging.eqiad.wmflabs [16:14:05] um, that is, staging.mobile.eqiad.wmflabs [16:14:22] so yeah, not us probably [16:14:33] ‘mobile’ has so many admins, hard to know where to start [16:14:40] :) [16:20:48] Yippee, build fixed! [16:20:48] Project browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox » af,contintLabsSlave && UbuntuTrusty build #92: 09FIXED in 6 hr 19 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox/LANGUAGE_SCREENSHOT_CODE=af,label=contintLabsSlave%20&&%20UbuntuTrusty/92/ [16:30:55] Yippee, build fixed! [16:30:56] Project browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox » ce,contintLabsSlave && UbuntuTrusty build #92: 09FIXED in 6 hr 29 min: https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-os_x_10.10-firefox/LANGUAGE_SCREENSHOT_CODE=ce,label=contintLabsSlave%20&&%20UbuntuTrusty/92/ [16:41:09] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce-T94153 build #1: 04FAILURE in 47 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce-T94153/1/ [16:49:41] (03PS1) 10Paladox: [BatchUserRights] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277542 [16:53:52] (03PS1) 10Paladox: [BayesianFilter] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277544 [17:04:31] (03PS1) 10Paladox: [BiblioPlus] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277547 [17:22:10] (03PS1) 10Paladox: [BibManager] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277552 [17:47:15] 10Browser-Tests-Infrastructure, 6Release-Engineering-Team: Implement a smoke + parallel strategy for running end-to-end tests - https://phabricator.wikimedia.org/T130037#2123356 (10dduvall) [17:49:15] 10Browser-Tests-Infrastructure, 6Release-Engineering-Team: Implement a smoke + parallel strategy for running end-to-end tests - https://phabricator.wikimedia.org/T130037#2123371 (10dduvall) [17:51:03] 10Continuous-Integration-Config, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2016-03-15: add rake job to Wikibase to check browser tests - https://phabricator.wikimedia.org/T130038#2123380 (10JanZerebecki) [17:53:01] ostriches: I'm worrying about timelines and AuthManager. Do you have a guesstimate date yet for cutting the REL1.27 branches? [17:53:20] No, I hadn't even thought about it [17:53:44] ostriches: let's keep it that way ;) [17:55:30] 10Continuous-Integration-Config, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2016-03-01: add rake job to Wikibase to check browser tests - https://phabricator.wikimedia.org/T130038#2123428 (10JanZerebecki) [17:55:45] (03PS1) 10Billm: Add ability for IfElseStructureSniff to detect multiple white spaces after else [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) [17:56:20] (03CR) 10jenkins-bot: [V: 04-1] Add ability for IfElseStructureSniff to detect multiple white spaces after else [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) (owner: 10Billm) [18:27:29] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config: use a deployment branch for beta - https://phabricator.wikimedia.org/T130045#2123553 (10JanZerebecki) [18:27:50] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config: use a deployment branch for beta - https://phabricator.wikimedia.org/T130045#2123580 (10JanZerebecki) [18:27:52] 10Beta-Cluster-Infrastructure, 6Release-Engineering-Team, 7Tracking: Use Beta cluster as a true canary for code deployments (tracking) - https://phabricator.wikimedia.org/T53494#2123579 (10JanZerebecki) [18:28:15] 3Scap3, 6Revision-Scoring-As-A-Service, 10ores: Move to using scap3 for deployment for ORES service - https://phabricator.wikimedia.org/T128670#2123582 (10Ladsgroup) [18:36:42] 6Release-Engineering-Team, 7Epic: [EPIC] (WIP) End-to-end tests and deploys - https://phabricator.wikimedia.org/T129940#2123591 (10greg) [18:42:12] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config: integrate browsertests with beta deployment - https://phabricator.wikimedia.org/T130047#2123608 (10JanZerebecki) [18:42:54] greg-g: poke about WMPageViewInfo in beta cluster? [18:43:06] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config: integrate browsertests with beta deployment - https://phabricator.wikimedia.org/T130047#2123628 (10JanZerebecki) [18:43:10] 10Beta-Cluster-Infrastructure, 6Release-Engineering-Team, 7Tracking: Use Beta cluster as a true canary for code deployments (tracking) - https://phabricator.wikimedia.org/T53494#2123627 (10JanZerebecki) [18:43:27] gah, right [18:44:32] one sec, in the middle of something... [18:46:37] (03PS1) 10Awight: Run composer during wacky Fundraising back-compat [integration/config] - 10https://gerrit.wikimedia.org/r/277563 [18:49:13] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config: integrate browsertests with beta deployment - https://phabricator.wikimedia.org/T130047#2123640 (10JanZerebecki) [18:51:52] bd808: Question. Was talking with thcipriani and we're wondering if we even need to `exec` rsync in https://gerrit.wikimedia.org/r/#/c/266773/3/modules/scap/files/scap-master-sync if we're already doing `set -e` [18:51:56] legoktm: https://gerrit.wikimedia.org/r/#/c/277509/ [18:52:15] do you know how many wikis disabled patrolling? [18:53:17] Amir1: https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php it's off by default apparently [18:53:23] but we need to seriously reconsider that now [18:53:47] maybe it made sense in 2005? definitely doesn't now [18:53:59] hmm [18:54:02] 7Browser-Tests, 10Wikidata, 7Tracking: [tracking] make Wikidata browsertests non-flaky - https://phabricator.wikimedia.org/T92619#2123658 (10JanZerebecki) [18:54:05] 10Browser-Tests-Infrastructure, 10Wikidata: No test report files were found: job fails in jenkins but is shown as successful in raita - https://phabricator.wikimedia.org/T116164#2123654 (10JanZerebecki) 5Open>3declined See {T130017} [18:54:30] maybe an RFC needed [18:56:56] 10Beta-Cluster-Infrastructure, 10WikimediaPageViewInfo: Deploy WikimediaPageViewInfo extension to beta cluster - https://phabricator.wikimedia.org/T129602#2123685 (10greg) I'd like explicitly list the blockers to having the pageview api in beta. So far I see: * beta.wmflabs.org domains not working (how? by pol... [18:57:49] 10Browser-Tests-Infrastructure, 10Wikidata, 13Patch-For-Review, 7Upstream: [Bug] fix negative argument (ArgumentError) in browsertests - https://phabricator.wikimedia.org/T110510#2123687 (10JanZerebecki) No this is not yet fixed, there is only a work around in place. [18:59:17] 7Browser-Tests, 10Wikidata: [Task] Find a sensible subset of browsertests that could be run on each commit - https://phabricator.wikimedia.org/T130019#2123688 (10JanZerebecki) [19:00:42] 10Beta-Cluster-Infrastructure, 7Browser-Tests, 10Continuous-Integration-Config: integrate browsertests with beta deployment - https://phabricator.wikimedia.org/T130047#2123692 (10JanZerebecki) [19:02:25] ostriches: yeah. the exec made sense when there was only one rsync but that code is busted now [19:02:44] Yeah that's what we're trying to figure out before merging that bit [19:02:47] :) [19:03:30] (03PS2) 10Awight: Run composer during wacky Fundraising back-compat [integration/config] - 10https://gerrit.wikimedia.org/r/277563 [19:04:22] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-Scribunto, 10Wikidata: Scribuntu fails CI on 1.26 branch on php 5.3 - https://phabricator.wikimedia.org/T129854#2123764 (10JanZerebecki) [19:11:27] ostriches: hey, do you have some examples of scap3 configs? the only thing I found is https://github.com/wikimedia/phabricator-deployment/tree/master/scap [19:13:02] That's one. I can't seem to find the one for restbase offhand. [19:13:06] Around here somewhere... [19:14:15] [19:15:24] I tried reading https://doc.wikimedia.org/mw-tools-scap/scap3/ but it didn't answer all of my questions. I want to do run some commands before deployment [19:16:08] :D [19:18:09] 6Release-Engineering-Team, 15User-greg: 201516Q4 goals creation - https://phabricator.wikimedia.org/T130052#2123852 (10greg) [19:20:27] 6Release-Engineering-Team, 15User-greg: 201617 Annual plan/budget - RelEng - Final - https://phabricator.wikimedia.org/T130053#2123882 (10greg) [19:20:58] 6Release-Engineering-Team, 15User-greg: Respond to initial FDC budget narrative feedback - https://phabricator.wikimedia.org/T130054#2123898 (10greg) [19:21:13] 6Release-Engineering-Team, 15User-greg: Respond to initial FDC budget narrative feedback - https://phabricator.wikimedia.org/T130054#2123932 (10greg) [19:21:20] 6Release-Engineering-Team, 15User-greg: 201617 Annual plan/budget - RelEng - Final - https://phabricator.wikimedia.org/T130053#2123882 (10greg) [19:22:00] 6Release-Engineering-Team, 15User-greg: Create quarterly goals for FY201617 that correspond to milestones of annual plan/narrative - https://phabricator.wikimedia.org/T130057#2123953 (10greg) [19:22:34] 6Release-Engineering-Team, 15User-greg: 201516Q4 goals creation - https://phabricator.wikimedia.org/T130052#2123970 (10greg) [19:22:36] 6Release-Engineering-Team, 15User-greg: 201617 Annual plan/budget - RelEng - Final - https://phabricator.wikimedia.org/T130053#2123969 (10greg) [19:23:23] 6Release-Engineering-Team, 15User-greg: Find a home for the "end-to-end and deploys" idea - https://phabricator.wikimedia.org/T129718#2123982 (10greg) Crosslinking: {T129940} [19:37:11] Amir1: https://doc.wikimedia.org/mw-tools-scap/scap3/repo_config.html is probably useful, it'll have the config variables defined for you [19:38:23] thanks [19:38:51] let me give it a try [19:42:28] (03PS1) 10Paladox: [Blackout] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277575 [19:46:35] (03PS1) 10Paladox: [BlockAndNuke] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277579 [19:51:09] (03PS1) 10Paladox: [Bootstrap] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277581 [19:59:01] * Krinkle is happy https://secure.phabricator.com/T10570 got fixed [20:00:32] (03PS1) 10Paladox: [BreadCrumbs2] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277586 [20:02:08] hashar: Hi [20:05:36] (03PS1) 10Paladox: [Carp] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277588 [20:07:40] 10Continuous-Integration-Infrastructure: npm tests constantly failing for oojs/ui changesets - https://phabricator.wikimedia.org/T130063#2124170 (10matmarex) [20:07:40] Krinkle Do you know if mediawiki.api.query has ever existed or what to replace it with, fails in https://integration.wikimedia.org/ci/job/mwext-testextension-php55/2462/console [20:08:16] 10Continuous-Integration-Infrastructure, 6Release-Engineering-Team: npm tests constantly failing for oojs/ui changesets - https://phabricator.wikimedia.org/T130063#2124183 (10matmarex) [20:08:47] 10Continuous-Integration-Infrastructure, 6Release-Engineering-Team: npm tests constantly failing for oojs/ui changesets - https://phabricator.wikimedia.org/T130063#2124170 (10Paladox) You may want to upload a patch that debugs please. [20:18:38] (03CR) 10Ejegg: [C: 04-1] Run composer during wacky Fundraising back-compat (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/277563 (owner: 10Awight) [20:36:51] paladox: Never existed. [20:36:53] Doesn't exist [20:38:41] paladox: MarkTraceur must've mistyped that at some point [20:38:55] paladox: I'd ignore it for now. that extension is not maintained. The author can pick it up when they want to [20:39:32] What extension? [20:49:58] (03PS3) 10Awight: Run composer during wacky Fundraising back-compat [integration/config] - 10https://gerrit.wikimedia.org/r/277563 [20:51:26] 10Continuous-Integration-Infrastructure, 7Zuul: Circular dependencies break Zuul - https://phabricator.wikimedia.org/T129938#2120489 (10hashar) So we had A patch to mediawiki/core https://gerrit.wikimedia.org/r/#/c/277357/2 with: ``` Change-Id: I69df50403389fd40879e7d8d699cb54e6b655083 Depends-On: Ia5bd6aa68c... [20:56:37] hashar and others: How reliant are you on the beta.wmflabs.org address? [20:56:37] Krinkle hi what do you mean. And what extension. [20:59:54] 10Continuous-Integration-Infrastructure, 6Release-Engineering-Team, 13Patch-For-Review: npm tests constantly failing for oojs/ui changesets - https://phabricator.wikimedia.org/T130063#2124399 (10Paladox) Hi karma was part of the problem but not totally responsible see https://integration.wikimedia.org/ci/job... [21:03:44] paladox: You linked to https://integration.wikimedia.org/ci/job/mwext-testextension-php55/2462/console - which is the test result for extensions/CategorySlideShow [21:03:51] Why are you changing that extension? [21:04:05] It was already broken from before https://gerrit.wikimedia.org/r/#/c/272885/ [21:04:08] not caused by your change [21:05:01] Krinkle: Oh sorry, Yes i know but i would like to know is there anyway to fix it, cause i rember there was a patch in core that was adding this type of named module but i think it was abandoned. [21:05:43] paladox: You'll need to understand the extension, figure out how it uses mw.api and fix it to not use that broken dependency. [21:05:53] Krinkle: Could you merge https://gerrit.wikimedia.org/r/#/c/277593/ since this fixes karma issue for oojs-ui since there been having some issues with npm. But karma is not the only problem. https://phabricator.wikimedia.org/T130063 [21:05:59] Krinkle oh ok thanks for explaning [21:06:52] No, I can't merge that. [21:06:59] Karma is not part of the problem in anyway for OOjs UI [21:07:25] 5Gerrit-Migration, 10Gitblit-Deprecate, 6Release-Engineering-Team, 3releng-201516-q3, and 4 others: [RfC]: Migrate code review / management to Phabricator from Gerrit - https://phabricator.wikimedia.org/T119908#2124417 (10greg) [21:07:37] Krinkle ok. [21:07:40] 5Gerrit-Migration, 10Differential, 7Documentation: Document use of Owners in Phabricator and advertise it - https://phabricator.wikimedia.org/T128372#2072003 (10greg) [21:07:52] 5Gerrit-Migration, 10Differential, 7Documentation: Document use of Owners in Phabricator and advertise it - https://phabricator.wikimedia.org/T128372#2072003 (10greg) p:5Triage>3Normal [21:09:27] 10Continuous-Integration-Infrastructure, 6Release-Engineering-Team, 13Patch-For-Review: npm tests constantly failing for oojs/ui changesets - https://phabricator.wikimedia.org/T130063#2124429 (10Paladox) The tests were working on March the 11 so between then and now the tests broke. [21:19:41] Krinkle ive found the problem for ooui it is https://gerrit.wikimedia.org/r/#/c/277278/ [21:20:07] 10Continuous-Integration-Infrastructure, 6Release-Engineering-Team, 13Patch-For-Review: npm tests constantly failing for oojs/ui changesets - https://phabricator.wikimedia.org/T130063#2124456 (10Paladox) Found the problem patch. It is https://gerrit.wikimedia.org/r/#/c/277278/ ive tested by doing it here htt... [21:21:09] Krinkle would you be able to review https://gerrit.wikimedia.org/r/#/c/277614/ please. [21:21:14] (03PS2) 10Hashar: [BatchUserRights] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277542 (owner: 10Paladox) [21:21:22] (03PS2) 10Hashar: [BlockAndNuke] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277579 (owner: 10Paladox) [21:21:24] (03PS2) 10Hashar: [BayesianFilter] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277544 (owner: 10Paladox) [21:21:26] (03PS2) 10Hashar: [Bootstrap] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277581 (owner: 10Paladox) [21:21:28] (03PS2) 10Hashar: [BiblioPlus] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277547 (owner: 10Paladox) [21:21:30] (03PS2) 10Hashar: [BreadCrumbs2] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277586 (owner: 10Paladox) [21:21:32] (03PS3) 10Hashar: [BatchUserRights] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277542 (owner: 10Paladox) [21:21:34] (03PS2) 10Hashar: [Blackout] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277575 (owner: 10Paladox) [21:21:36] (03PS2) 10Hashar: [BibManager] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277552 (owner: 10Paladox) [21:21:38] (03PS2) 10Hashar: [Carp] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277588 (owner: 10Paladox) [21:21:40] (03PS1) 10Hashar: Merge in npm entry point additions [integration/config] - 10https://gerrit.wikimedia.org/r/277616 [21:22:46] hashar: Thanks. [21:22:48] :0 [21:22:50] :) [21:31:04] hashar: Hi can you review [21:31:05] https://gerrit.wikimedia.org/r/#/c/277291/ [21:31:10] https://gerrit.wikimedia.org/r/#/c/277108/ [21:31:15] https://gerrit.wikimedia.org/r/#/c/277106/ [21:31:20] https://gerrit.wikimedia.org/r/#/c/277100/ [21:31:24] https://gerrit.wikimedia.org/r/#/c/277099/ [21:31:29] https://gerrit.wikimedia.org/r/#/c/277099/ [21:31:29] goazheazeazea [21:31:37] https://gerrit.wikimedia.org/r/#/c/277084/ [21:31:39] please. [21:31:57] ok. [21:32:35] There are more but they can be done another time. [21:32:37] paladox: for the jsonlint being added to check [21:32:43] See https://gerrit.wikimedia.org/r/#/q/status:open+project:integration/config+branch:master+owner:%22Paladox+%253Cthomasmulhall410%2540yahoo.com%253E%22,n,z please. [21:32:46] that should probably be on all extensions [21:32:52] or we could even drop the job entirely [21:33:05] and have folks move to npm [21:34:04] hashar: Ok what do you think we should do, should we drop jsonlint and jshint. But woulden that mean that non-whitelisted users wont be able to test jsonlint and jshint files. Until npm is open. [21:34:13] paladox: and I would remove jshint from all extensions in a single patch [21:35:12] hashar: Yes ok, so we should remove jshint. [21:35:17] Should we drop jsonlint. [21:35:22] yup in favor of npm as an entry point [21:35:29] hashar: Ok. [21:35:30] same case for jsonlint really [21:35:45] and aim toward having npm for non whitelisted folks [21:37:12] How would we get the non whitelisted users to test. can we setup a temporarily npm test such as npm-non-whitelisted and manually have jsonlint and jshint set and put that job as non voting making jshint fail but wont cause anything else to fai; [21:37:20] if we have npm, the jshint and jsonlint jobs are redundant [21:37:27] hashar: Ok. [21:37:32] and people can still run them locally [21:37:47] hashar: Ok. [21:37:54] hashar: I will do that now. [21:38:25] I will upload the patch and review change because i am just going to remove jshint all together but have to keep some bits behind for the other repos not converted. [21:38:59] hashar: There was like 700+ occurences of jsonlint [21:39:32] yeah keep pushing for npm [21:39:42] we can cleanup jshint later on [21:40:11] for extensions archival we would need a good more or less automatic process [21:40:34] hashar: yeh. [21:41:10] the extensions we hosts are like the Augeas stables [21:41:12] hashar: Do i cleanup jshint now but do the rest later like we keep the bit about what jshint will start on like js files. [21:41:19] yes. [21:41:29] jshint can wait imho [21:41:38] hashar: Ok. [21:41:52] (03PS1) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [21:41:57] note there are a bunch of extensions you are updating that have been more or less abandonned [21:42:02] and might not work anymore. [21:42:11] some barely had any worthwhile commit in years :( [21:42:12] hashar ^^^ just need to quickly add a few things back. [21:42:22] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [21:42:24] hashar: yeh. [21:42:35] :) [21:43:53] (03PS2) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [21:44:58] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [21:45:52] (03Abandoned) 10Hashar: Archive 3 extensions [integration/config] - 10https://gerrit.wikimedia.org/r/263381 (owner: 10Paladox) [21:46:20] hashar: DO you know how to remove jsonlint with one click since it find jsonlint but leave a gap or space. [21:47:09] (03PS2) 10Hashar: [E3Experiments] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/276031 (owner: 10Paladox) [21:48:09] (03CR) 10Hashar: [C: 032] [E3Experiments] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/276031 (owner: 10Paladox) [21:49:20] greg-g: my toy version thing works -- https://tools.wmflabs.org/bd808-test/versions.php -- group0 == .17 [21:50:12] twentyafterfour: ^ :) [21:50:18] bd808: it's alive! [21:52:00] nice [21:52:14] bd808: does it just check Special:Version periodically? [21:52:26] (03Merged) 10jenkins-bot: [E3Experiments] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/276031 (owner: 10Paladox) [21:52:37] it reads the wikiversions.json file from noc [21:53:10] https://noc.wikimedia.org/conf/wikiversions.json [21:53:11] 5Gerrit-Migration, 10Phabricator, 13Patch-For-Review, 7Puppet, 7WorkType-Maintenance: Configure backula to backup the /srv/phab/repos directory - https://phabricator.wikimedia.org/T120045#2124601 (10Dzahn) ``` [helium:~] $ sudo bconsole Connecting to Director helium.eqiad.wmnet:9101 1000 OK: helium.eqiad... [21:53:58] and it reads the dblist files to learn which wikis are in each group [21:54:06] 5Gerrit-Migration, 10Phabricator, 7Puppet, 7WorkType-Maintenance: Configure backula to backup the /srv/phab/repos directory - https://phabricator.wikimedia.org/T120045#2124604 (10Dzahn) [21:54:27] (03PS2) 10Hashar: [AssertEdit] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/277291 (owner: 10Paladox) [21:54:34] (03CR) 10Hashar: [C: 032] [AssertEdit] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/277291 (owner: 10Paladox) [21:55:26] (03PS2) 10Hashar: [ApiSVGProxy] Archive repo [integration/config] - 10https://gerrit.wikimedia.org/r/277106 (owner: 10Paladox) [21:55:39] (03CR) 10Hashar: [C: 032] [ApiSVGProxy] Archive repo [integration/config] - 10https://gerrit.wikimedia.org/r/277106 (owner: 10Paladox) [21:55:55] bd808: cool [21:56:01] (03Merged) 10jenkins-bot: [AssertEdit] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/277291 (owner: 10Paladox) [21:56:20] (03PS3) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [21:57:07] (03Merged) 10jenkins-bot: [ApiSVGProxy] Archive repo [integration/config] - 10https://gerrit.wikimedia.org/r/277106 (owner: 10Paladox) [21:57:09] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [21:57:44] (03PS4) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [22:01:41] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [22:02:11] 10Continuous-Integration-Config, 6Discovery: Take wikimedia/portals repo out of "mediawiki" zuul pipeline in CI - https://phabricator.wikimedia.org/T129591#2124645 (10Deskana) [22:02:29] (03PS5) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [22:02:36] 10Continuous-Integration-Config, 6Discovery: Take wikimedia/portals repo out of "mediawiki" zuul pipeline in CI - https://phabricator.wikimedia.org/T129591#2110261 (10Deskana) Removing #discovery-search-sprint, this is not search related. I'm guessing it should be added to #discovery-portal-sprint? @debt can t... [22:03:54] (03PS6) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [22:04:36] 5Gerrit-Migration, 7Documentation: Update Commit Message Guidelines for phab - https://phabricator.wikimedia.org/T123081#2124655 (10greg) p:5Triage>3Normal [22:07:47] (03PS7) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [22:09:28] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [22:10:51] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [22:13:21] (03PS8) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [22:14:09] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [22:14:31] 5Gerrit-Migration: Ability for a privileged application to provide test status of a commit - https://phabricator.wikimedia.org/T190#2124683 (10greg) This actually happens right now with Jenkins and the rMSCA repository, see eg D145. {F3639909} Done via buildplans, eg https://phabricator.wikimedia.org/harbormast... [22:15:05] 5Gerrit-Migration, 10Differential: Ability for a privileged application to provide test status of a commit - https://phabricator.wikimedia.org/T190#2124685 (10greg) [22:16:34] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [22:16:45] (03PS9) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [22:17:38] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [22:20:52] (03PS10) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [22:20:58] hashar: ^^ Im not sure how to fix the above. [22:21:03] Could i have some help please. [22:21:40] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [23:00:13] (03PS11) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [23:01:58] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [23:02:39] 5Gerrit-Migration, 6Repository-Admins, 10pywikibot-core: Migrate Pywikibot to Differential code review - https://phabricator.wikimedia.org/T95526#2124900 (10greg) >>! In T95526#2124446, @greg wrote: > (NB: I removed that project from here because except for odd circumstances we won't have a task per reposito... [23:04:28] (03PS12) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [23:05:56] (03PS13) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [23:08:11] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [23:09:13] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [23:09:44] (03PS14) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [23:10:56] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [23:14:20] (03PS15) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [23:15:04] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [23:20:20] (03PS16) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [23:20:58] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [23:25:13] (03PS17) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [23:26:20] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [23:27:35] (03PS18) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [23:28:16] (03CR) 10jenkins-bot: [V: 04-1] Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [23:29:51] (03PS19) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [23:30:30] (03PS20) 10Paladox: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 [23:35:56] ugh I can't get make-deploy-notes to work right [23:52:07] why not? [23:53:17] * Reedy updates submodules