[00:46:59] twentyafterfour: ostriches: Any word on bringing back "Open Tasks" as an optoin for the sidebar in a less hacky way than currently required? [00:47:53] I have no clue what you're talking about :) [00:52:11] Krinkle: Open tasks in phabricator? [00:52:57] * twentyafterfour isn't sure either.. [03:05:06] PROBLEM - App Server bits response on deployment-mediawiki01 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [03:05:53] Project beta-scap-eqiad build #94247: 04FAILURE in 1 min 10 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/94247/ [03:13:55] Yippee, build fixed! [03:13:55] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #915: 09FIXED in 23 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/915/ [03:15:50] Yippee, build fixed! [03:15:50] Project beta-scap-eqiad build #94248: 09FIXED in 1 min 8 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/94248/ [03:19:48] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #1014: 04FAILURE in 37 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/1014/ [04:23:49] Yippee, build fixed! [04:23:49] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #754: 09FIXED in 31 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/754/ [08:20:56] Yippee, build fixed! [08:20:56] Project browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #894: 09FIXED in 55 sec: https://integration.wikimedia.org/ci/job/browsertests-CirrusSearch-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/894/ [09:30:05] PROBLEM - Puppet staleness on deployment-tin is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [43200.0] [10:52:43] 10Continuous-Integration-Config, 5Continuous-Integration-Scaling, 3releng-201516-q3, 7WorkType-NewFunctionality: [keyresult] Migrate php composer (Zend and HHVM) CI jobs to Nodepool - https://phabricator.wikimedia.org/T119139#2133596 (10Paladox) @Hashar php5 for Jessie https://packages.debian.org/jessie/php5 [10:56:36] 5Continuous-Integration-Scaling, 6Operations, 7HHVM: Provide a HHVM package for jessie-wikimedia matching version of trusty-wikimedia - https://phabricator.wikimedia.org/T125821#2133603 (10Paladox) @hashar Also we can now select the php flavours so we would need to update he description. [11:22:25] PROBLEM - Host deployment-mathoid is DOWN: CRITICAL - Host Unreachable (10.68.20.104) [11:33:58] RECOVERY - Host deployment-mathoid is UP: PING OK - Packet loss = 0%, RTA = 0.79 ms [11:37:38] PROBLEM - Puppet run on deployment-mathoid is CRITICAL: CRITICAL: 14.29% of data above the critical threshold [0.0] [11:46:53] PROBLEM - Free space - all mounts on deployment-fluorine is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine.diskspace._srv.byte_percentfree (<50.00%) [12:11:05] 10Deployment-Systems, 6Release-Engineering-Team, 6Operations: setup automatic deletion of old l10nupdate - https://phabricator.wikimedia.org/T130317#2133712 (10hashar) [12:29:38] 3Scap3: Support multiple service restart by supporting one service_name per service group - https://phabricator.wikimedia.org/T130361#2133742 (10Ladsgroup) [12:32:13] 3Scap3: Scap3 should support virtualenv for deployment of python packages - https://phabricator.wikimedia.org/T130205#2133775 (10Ladsgroup) @hashar: {T130361} [12:55:06] PROBLEM - App Server bits response on deployment-mediawiki01 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [12:55:54] Project beta-scap-eqiad build #94308: 04FAILURE in 1 min 13 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/94308/ [13:05:54] Yippee, build fixed! [13:05:54] Project beta-scap-eqiad build #94309: 09FIXED in 1 min 13 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/94309/ [13:13:25] 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#2133839 (10JanZerebecki) Patches that enable generating coverage reports and publishing it post-merge are definitively welcome. Does that answer your question? [14:02:41] 10Continuous-Integration-Config, 10MediaWiki-extensions-WikibaseMediaInfo, 10Wikidata: PHP Fatal error: Class 'PHPUnit_Util_Filter' not found in /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/extensions/WikibaseMediaInfo/src/View/Med... - https://phabricator.wikimedia.org/T130327#2133950 [14:04:26] 10Continuous-Integration-Config, 10MediaWiki-extensions-WikibaseMediaInfo, 10Wikidata: PHP Fatal erWikidata build broken: Class 'PHPUnit_Util_Filter' not found - https://phabricator.wikimedia.org/T130327#2133952 (10JanZerebecki) [14:07:23] zeljkof: Can you teake a look at T130335 ? [14:07:23] T130335: Create Diffusion repo for malu - https://phabricator.wikimedia.org/T130335 [14:09:51] Luke081515: done! :) [14:09:58] thanks :) [14:10:01] I thought you want _me_ to create the repo [14:10:17] Oh, I can do that to ;) [14:10:19] I just wanted to reply that I am not the one to ask :D [14:10:31] ok :D [14:35:30] hello folks, I have a newbie question (if anybody has time). I'd need to test a change in labs before prod (https://gerrit.wikimedia.org/r/#/c/277984) and the Analtics team has already a replica of the hadoop cluster in labs. [14:36:27] except using a self hosted puppet master, the only relevant thing that I've found is https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated#Cherry-picking_a_patch_from_gerrit [14:37:21] any suggestion about the best/suggested way to proceed? [14:39:53] elukey: in labs or in beta cluster? [14:40:07] * mobrovac creates confusion [14:40:43] labs == a labs project, beta cluster == the dpeloyment-prep labs project [14:42:23] If you're talking about an an analytics thing it's not beta/deployment-prep stuff. [14:42:35] mobrovac: ah yes moar confusion :D It should be labs https://wikitech.wikimedia.org/wiki/Hiera:Analytics [14:43:05] but I am probably super wrong so I'll ask to my team about this info [14:44:12] elukey: in general, if you have your own puppetmaster there, then just check out the module [14:44:21] module's sha1 that you want to test [15:27:47] made my first differential patch https://phabricator.wikimedia.org/D154 \o/ [15:27:52] for scap [15:31:20] Amir1: sweet! Thanks for the doc update :) [15:31:54] :) [15:35:47] (03CR) 10JanZerebecki: [C: 032] Whitelist user Robert Vogel [integration/config] - 10https://gerrit.wikimedia.org/r/278185 (owner: 10Paladox) [15:36:47] (03Merged) 10jenkins-bot: Whitelist user Robert Vogel [integration/config] - 10https://gerrit.wikimedia.org/r/278185 (owner: 10Paladox) [15:39:03] 10Continuous-Integration-Infrastructure, 6Release-Engineering-Team, 13Patch-For-Review: npm tests constantly failing for oojs/ui changesets - https://phabricator.wikimedia.org/T130063#2134136 (10matmarex) 5Open>3Resolved I suppose, it's still failing all the time, but for different reasons (T127100). [15:41:46] (03PS3) 10JanZerebecki: Wikidata Query Service does not need npm anymore, since GUI now has separate repo. [integration/config] - 10https://gerrit.wikimedia.org/r/276667 (owner: 10Smalyshev) [15:41:52] (03CR) 10JanZerebecki: [C: 032] Wikidata Query Service does not need npm anymore, since GUI now has separate repo. [integration/config] - 10https://gerrit.wikimedia.org/r/276667 (owner: 10Smalyshev) [15:43:11] (03Merged) 10jenkins-bot: Wikidata Query Service does not need npm anymore, since GUI now has separate repo. [integration/config] - 10https://gerrit.wikimedia.org/r/276667 (owner: 10Smalyshev) [15:47:47] (03PS2) 10JanZerebecki: Whitelist Purodha for Zuul pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/277898 (owner: 10Dereckson) [15:47:56] (03PS3) 10JanZerebecki: Whitelist Purodha for Zuul pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/277898 (owner: 10Dereckson) [15:48:20] (03CR) 10JanZerebecki: [C: 032] Whitelist Purodha for Zuul pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/277898 (owner: 10Dereckson) [15:49:32] (03Merged) 10jenkins-bot: Whitelist Purodha for Zuul pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/277898 (owner: 10Dereckson) [15:51:48] (03CR) 10JanZerebecki: [C: 04-1] "Why run composer only for that extension but at the same time use vendor.git ?" [integration/config] - 10https://gerrit.wikimedia.org/r/277563 (owner: 10Awight) [15:52:52] thcipriani: 1- It would be great if the new version of scap gets released, we need git_fat feature 2- since I spend some time playing with scap I would be happy to help you migrate some services to scap specially if it's in python [15:53:48] (03CR) 10Ejegg: "Good point, we should stop tacking mediawiki/extensions/DonationInterface/vendor on after deps.txt" [integration/config] - 10https://gerrit.wikimedia.org/r/277563 (owner: 10Awight) [15:56:57] Amir1: 1. Still determining what will make the cut to the newest release and we'll get it out ASAP. 2. That would be helpful. Trying to foist as much of the transition onto repo owners as possible by having some docs, but more than likely there'll be lots of questions. [15:57:07] (03CR) 10JanZerebecki: "If mediawiki/vendor.git is not used then the composer merge plugin can be used to include all dependencies for extensions with core in one" [integration/config] - 10https://gerrit.wikimedia.org/r/277563 (owner: 10Awight) [15:58:14] (03PS2) 10JanZerebecki: Announce all failures of beta jobs in -releng [integration/config] - 10https://gerrit.wikimedia.org/r/276238 (https://phabricator.wikimedia.org/T129374) (owner: 10Greg Grossmeier) [15:58:35] thcipriani: great, thanks [15:59:37] (03CR) 10Paladox: "Thanks." [integration/config] - 10https://gerrit.wikimedia.org/r/278185 (owner: 10Paladox) [16:02:35] (03CR) 10JanZerebecki: "Deployed to Jenkins: (['beta-code-update-eqiad', 'beta-cxserver-update-eqiad', 'beta-mediawiki-config-update-eqiad', 'beta-parsoid-update-" [integration/config] - 10https://gerrit.wikimedia.org/r/276238 (https://phabricator.wikimedia.org/T129374) (owner: 10Greg Grossmeier) [16:02:40] (03CR) 10JanZerebecki: [C: 032] Announce all failures of beta jobs in -releng [integration/config] - 10https://gerrit.wikimedia.org/r/276238 (https://phabricator.wikimedia.org/T129374) (owner: 10Greg Grossmeier) [16:04:44] (03Merged) 10jenkins-bot: Announce all failures of beta jobs in -releng [integration/config] - 10https://gerrit.wikimedia.org/r/276238 (https://phabricator.wikimedia.org/T129374) (owner: 10Greg Grossmeier) [16:05:25] (03PS2) 10JanZerebecki: Non voting php jobs to pipeline php5 [integration/config] - 10https://gerrit.wikimedia.org/r/276468 (owner: 10Hashar) [16:05:31] (03CR) 10JanZerebecki: [C: 032] Non voting php jobs to pipeline php5 [integration/config] - 10https://gerrit.wikimedia.org/r/276468 (owner: 10Hashar) [16:06:46] (03Merged) 10jenkins-bot: Non voting php jobs to pipeline php5 [integration/config] - 10https://gerrit.wikimedia.org/r/276468 (owner: 10Hashar) [16:12:57] 6Release-Engineering-Team, 15User-greg: Respond to initial FDC budget narrative feedback - https://phabricator.wikimedia.org/T130054#2134214 (10greg) 5Open>3Resolved [16:12:59] 6Release-Engineering-Team, 15User-greg: 201617 Annual plan/budget - RelEng - Final - https://phabricator.wikimedia.org/T130053#2134215 (10greg) [16:13:47] 6Release-Engineering-Team, 15User-greg: Create on-wiki quarterly goals for FY201617 that correspond to milestones of annual plan/narrative - https://phabricator.wikimedia.org/T130057#2134221 (10greg) [16:13:54] 6Release-Engineering-Team, 15User-greg: 201617 Annual plan/budget - RelEng - Final - https://phabricator.wikimedia.org/T130053#2123882 (10greg) 5Open>3Resolved [16:15:08] 6Release-Engineering-Team, 15User-greg: Create officewiki version of annual budget/plan - https://phabricator.wikimedia.org/T130375#2134227 (10greg) [16:25:15] 10Browser-Tests-Infrastructure, 10MediaWiki-extensions-MultimediaViewer: NeedCaptcha (MediawikiApi::CreateAccountError) in MultimediaViewer browser tests - https://phabricator.wikimedia.org/T129472#2134279 (10zeljkofilipin) Yes. We can solve problems one by one, but until T128190 is resolved, I do not think th... [16:37:48] (03CR) 10JanZerebecki: [C: 04-1] "The line before is running composer, why would it need to run again?" [integration/config] - 10https://gerrit.wikimedia.org/r/276514 (owner: 10Paladox) [16:55:33] 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#2134437 (10Jdlrobson) Yeh sorry, my question could have been clearer. I guess my question is will https://gerrit.wikimedia.org/r/276899 address https://phabricat... [17:00:33] (03PS2) 10JanZerebecki: Add one new experimental test to extension-unittests [integration/config] - 10https://gerrit.wikimedia.org/r/276513 (owner: 10Paladox) [17:00:37] 10MediaWiki-Codesniffer, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2016, 3Outreachy-Round-12: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki - https://phabricator.wikimedia.org/T130382#2134468 (10Aashaka) [17:00:52] (03CR) 10JanZerebecki: [C: 032] Add one new experimental test to extension-unittests [integration/config] - 10https://gerrit.wikimedia.org/r/276513 (owner: 10Paladox) [17:00:56] (03CR) 10Paladox: "Because on mediawiki 1.23 it doesn't have composer so it fails this test. With this added it will fallback to the old way we added php uni" [integration/config] - 10https://gerrit.wikimedia.org/r/276514 (owner: 10Paladox) [17:01:51] (03Merged) 10jenkins-bot: Add one new experimental test to extension-unittests [integration/config] - 10https://gerrit.wikimedia.org/r/276513 (owner: 10Paladox) [17:03:35] 10MediaWiki-Codesniffer, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2016, 3Outreachy-Round-12: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki - https://phabricator.wikimedia.org/T130382#2134514 (10Aashaka) @Legoktm, @EBernhardson and the rest of the community : Do have a lo... [17:16:03] 10scap, 10Scap3 (Scap3-MediaWiki-MVP): refreshCdbJsonFiles should be rewritten in python - https://phabricator.wikimedia.org/T125685#2134570 (10thcipriani) 5Open>3Resolved [17:16:45] !log reloading zuul for e33494f..89a9659 [17:16:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [17:20:45] (03CR) 10JanZerebecki: "If it doesn't have composer why run a -composer job? If it doesn't have composer how would mw-fetch-composer-dev work?" [integration/config] - 10https://gerrit.wikimedia.org/r/276514 (owner: 10Paladox) [17:25:24] (03CR) 10Paladox: "Because the extension may have it whereas the mediawiki/core doesn't." [integration/config] - 10https://gerrit.wikimedia.org/r/276514 (owner: 10Paladox) [17:26:10] (03CR) 10Paladox: "MediaWiki 1.23 supports it but it doesn't include its own composer.json file for that release whereas 1.24 does." [integration/config] - 10https://gerrit.wikimedia.org/r/276514 (owner: 10Paladox) [17:32:10] 6Release-Engineering-Team, 15User-greg: Backfill budget narrative with changes from annual plan spreadsheet - https://phabricator.wikimedia.org/T130386#2134629 (10greg) [17:42:03] not sure if it was intentional, but it looks like someone cleared out all the cherry-picks on deployment-puppetmaster [17:43:57] thcipriani: twentyafterfour ( bd808 ) ^^ [17:44:14] not me. :/ [17:44:23] not me [17:44:24] reflog may let you find them again [17:44:27] that sucks :\ [17:44:57] 6Release-Engineering-Team, 15User-greg: Backfill budget narrative with changes from annual plan spreadsheet - https://phabricator.wikimedia.org/T130386#2134629 (10greg) 5Open>3Resolved [17:44:59] * bd808 blames obama [17:48:50] deployment-mediawiki01 wont run puppet, Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find class mediawiki::conftool for deployment-mediawiki01.deployment-prep.eqiad.wmflabs on node deployment-mediawiki01.deployment-prep.eqiad.wmflabs [17:50:01] bd808: Thanks obama. [17:50:33] 6Release-Engineering-Team, 15User-greg: Add more granularity to FY1617 travel budget - https://phabricator.wikimedia.org/T130387#2134691 (10greg) [17:50:33] ebernhardson: i cherry-picked stuff today, but didn't remove anything [17:50:42] Amir1: are multiple service restarts something that can be handled via scap3 checks? [17:50:48] for you all? [17:51:10] mobrovac: hmm, might be since then. git log HEAD..origin/puppet doesn't show anything from you [17:51:25] thcipriani: I think it's possible [17:51:31] err origin/production [17:51:38] but I couldn't get through tests because of git_fat [17:51:42] (03CR) 10JanZerebecki: "The -composer jobs don't support a core without composer.json file." [integration/config] - 10https://gerrit.wikimedia.org/r/276514 (owner: 10Paladox) [17:52:15] * ebernhardson fails typing... i mean git log origin/production..HEAD from /var/lib/git/operations/puppet which should show all local changes that arn't merged to puppet repo [17:52:47] Amir1: we want to build something more robust, but we don't want to block you all, so if you can work with what's there now we can get you something better going forward :) [17:53:13] yeah that would be the best thing [17:53:32] I suggested that we use the same method for dsh_targets [17:53:45] like canary_service_name and service_name etc [17:54:02] ebernhardson: see also interactive rebase, this morning deployment-puppetmaster was in detached state (not on HEAD) [17:55:00] there was one c-p patch at the time [17:56:43] Amir1: canary_service_name isn't really what you want, as that implies that the service changes names between target groups [17:57:32] it does [17:57:45] Amir1: thcipriani: probably the easiest way to get away with it without resorting to checks would be to allow service_name to be an array or sth similar [17:58:06] but i concur with thcipriani, for the time being you can get away with checks [17:58:24] euh, no actually you can't [17:58:56] the scap target user has the permission to only restart the service defined under service_name [17:59:01] we have two service groups (actually three but the third one doesn't matter) web and worker [17:59:14] so putting service restart in checks.yaml won't do you any good [17:59:23] oh [18:00:15] Amir1: so with one repo you run two services? [18:00:25] yes [18:00:25] on different nodes/ [18:00:29] yes [18:00:37] damn [18:00:47] you'd have to add a permission in puppet, run: sudo service restart [name] in checks.yml [18:01:02] mobrovac: https://github.com/wiki-ai/ores-wikimedia-config/blob/master/fabfile.py [18:01:23] splitting them in two repos is not an option? [18:01:28] thcipriani: that would be fairly easy I guess [18:01:47] mobrovac: that would be very complicated [18:17:22] (03CR) 10Paladox: "Oh ok/" [integration/config] - 10https://gerrit.wikimedia.org/r/276514 (owner: 10Paladox) [18:32:06] 6Release-Engineering-Team, 15User-greg: Create officewiki version of annual budget/plan - https://phabricator.wikimedia.org/T130375#2134823 (10greg) {{done}} https://office.wikimedia.org/w/index.php?title=2016-17_WMF_Annual_Plan%2FRelease_Engineering_Narrative&type=revision&diff=175988&oldid=175845 [18:32:21] 6Release-Engineering-Team, 15User-greg: Create officewiki version of annual budget/plan - https://phabricator.wikimedia.org/T130375#2134227 (10greg) 5Open>3Resolved [18:54:53] 6Release-Engineering-Team, 15User-greg: Add more granularity to FY1617 travel budget - https://phabricator.wikimedia.org/T130387#2134931 (10greg) p:5High>3Low [19:46:17] 10Continuous-Integration-Infrastructure: Deal with bitbucket.org rate limit for downloading phantomjs (npm jobs intermittently fail) - https://phabricator.wikimedia.org/T127100#2032437 (10Paladox) We can always host these files https://bitbucket.org/ariya/phantomjs/downloads#clone on GitHub and download from Git... [19:49:20] 10Continuous-Integration-Infrastructure: Deal with bitbucket.org rate limit for downloading phantomjs (npm jobs intermittently fail) - https://phabricator.wikimedia.org/T127100#2032437 (10greg) *IF* we mirror (I'm not sure what the right solution is here of Krinkle's two options) we'd mirror it on Gerrit and/or... [20:29:31] RECOVERY - Puppet run on deployment-mathoid is OK: OK: Less than 1.00% above the threshold [0.0] [20:37:05] 5Continuous-Integration-Scaling, 13Patch-For-Review, 7WorkType-NewFunctionality: Migrate javascript npm CI jobs to Nodepool - https://phabricator.wikimedia.org/T119143#2135320 (10Krinkle) [20:39:26] Yippee, build fixed! [20:39:27] Project browsertests-Wikidata-PerformanceTests-linux-firefox build #141: 09FIXED in 25 sec: https://integration.wikimedia.org/ci/job/browsertests-Wikidata-PerformanceTests-linux-firefox/141/ [20:40:52] we run a perf test against beta cluster? [20:41:28] 6Release-Engineering-Team, 15User-greg: 201617 Annual plan/budget - RelEng - Final - https://phabricator.wikimedia.org/T130053#2135332 (10greg) [20:41:30] 6Release-Engineering-Team, 15User-greg: 201516Q4 goals creation - https://phabricator.wikimedia.org/T130052#2135331 (10greg) 5Open>3Resolved [20:41:37] 6Release-Engineering-Team, 15User-greg: 201617 Annual plan/budget - RelEng - Final - https://phabricator.wikimedia.org/T130053#2123882 (10greg) [20:41:39] 6Release-Engineering-Team, 15User-greg: Create on-wiki quarterly goals for FY201617 that correspond to milestones of annual plan/narrative - https://phabricator.wikimedia.org/T130057#2135333 (10greg) 5Open>3Resolved [21:12:50] thcipriani: does puppet still need to be disabled on deployment-tin? its been ~24 hours [21:13:17] ebernhardson: no, I thought I enabled it last night :\ [21:13:22] thcipriani: ok, i'll reenable [21:13:42] thanks [21:45:21] 5Gerrit-Migration, 3releng-201516-q4: Goal: Phase 1 repository migrations - https://phabricator.wikimedia.org/T130418#2135504 (10greg) [21:46:20] (03PS1) 10Paladox: Add mwext-testextension-{phpflavour}-non-voting to gate and submit [integration/config] - 10https://gerrit.wikimedia.org/r/278394 [21:52:41] 5Gerrit-Migration, 3releng-201617-q2: Goal: Phase 2 repository migrations - https://phabricator.wikimedia.org/T130420#2135548 (10greg) [21:53:10] 5Gerrit-Migration, 3releng-201617-q3: Goal: Phase 3 repository migrations - https://phabricator.wikimedia.org/T130421#2135563 (10greg) [21:54:01] 5Gerrit-Migration, 3releng-201617-q3: Goal: Phase 3 repository migrations - https://phabricator.wikimedia.org/T130421#2135577 (10greg) [21:54:37] (03PS1) 10Paladox: Remove Wikidata PerformanceTests browsertests [integration/config] - 10https://gerrit.wikimedia.org/r/278398 (https://phabricator.wikimedia.org/T130017) [21:57:26] 10Continuous-Integration-Config: Set up composer-test for all MW extensions where it isn't broken - https://phabricator.wikimedia.org/T124342#2135584 (10Paladox) I'm going through all the extensions since I'm adding npm so they should all be having a working composer soon. [21:59:27] Krinkle what do you think about enabling composer-test for all repos but non-voting for now. See task https://phabricator.wikimedia.org/T124342 the reason for non-voting is because some composer files doint include the test command so they will fail. But im going through the extension list at layout.xml and soon should be fixed. [21:59:40] 3releng-201516-q3, 10scap, 10Scap3 (Scap3-MediaWiki-MVP), 7WorkType-NewFunctionality: [keyresult] Migrate the MW weekly train deploy to scap3 - https://phabricator.wikimedia.org/T114313#2135585 (10mmodell) [22:05:06] 10Browser-Tests-Infrastructure, 10MobileFrontend: Watchstar broken on beta cluster - https://phabricator.wikimedia.org/T130423#2135607 (10Jdlrobson) [22:15:50] (03PS1) 10Paladox: Add new template composer-{phpflavour}-non-voting [integration/config] - 10https://gerrit.wikimedia.org/r/278405 (https://phabricator.wikimedia.org/T124342) [22:15:53] legoktm: Hi [22:15:59] legoktm ^^ :) [22:16:09] hi [22:16:12] why do we need that? [22:16:37] legoktm: See task https://phabricator.wikimedia.org/T124342 [22:17:27] this will allow us to fix the broken composer test for those repos when other can test. But any other repo are un affected if they have the composer-test template since that will also run, Yes duplicate but all repos can run it now. [22:18:52] I don't want to duplicate [22:19:10] (03CR) 10jenkins-bot: [V: 04-1] Add new template composer-{phpflavour}-non-voting [integration/config] - 10https://gerrit.wikimedia.org/r/278405 (https://phabricator.wikimedia.org/T124342) (owner: 10Paladox) [22:19:48] legoktm: Oh is there a way to know if composer-test template is detected doint use that test. [22:20:14] we'll have to hardcode a list somewhere I believe [22:21:45] legoktm: Oh [22:22:12] legoktm: Could we use skip-if [22:22:18] yeah [22:22:22] that seems like a good idea [22:23:35] legoktm: Im searching google to see if we could apply it to templates [22:37:12] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #992: 04FAILURE in 26 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/992/ [22:38:03] legoktm: Im not sure how we would set out skip-if since it is not posible to skip if a template matches, See http://docs.openstack.org/infra/zuul/zuul.html Section skip-if (optional) please [22:39:14] http://docs.openstack.org/infra/zuul/zuul.html#jobs [22:49:50] (03PS2) 10Paladox: Add new template composer-{phpflavour}-non-voting [integration/config] - 10https://gerrit.wikimedia.org/r/278405 (https://phabricator.wikimedia.org/T124342) [22:59:46] Yippee, build fixed! [22:59:46] Project browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-windows_7-firefox-sauce build #363: 09FIXED in 45 sec: https://integration.wikimedia.org/ci/job/browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-windows_7-firefox-sauce/363/ [23:01:59] 10Browser-Tests-Infrastructure, 10Reading-Web: Run browser tests on beta cluster from desktop domain - https://phabricator.wikimedia.org/T130429#2135772 (10Jdlrobson) [23:02:29] 10Browser-Tests-Infrastructure, 10Reading-Web: Run browser tests on beta cluster from desktop domain - https://phabricator.wikimedia.org/T130429#2135784 (10Jdlrobson) [23:04:35] 7Browser-Tests, 10Reading-Web: Run browser tests on beta cluster from desktop domain - https://phabricator.wikimedia.org/T130429#2135785 (10greg) [23:05:01] (03PS1) 10Paladox: [CategoryTests] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278417 [23:06:33] (03PS2) 10Paladox: [CategoryTests] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278417 [23:09:37] 7Browser-Tests, 10Reading-Web, 3Reading-Web-Sprint-69-k: Run browser tests on beta cluster from desktop domain - https://phabricator.wikimedia.org/T130429#2135789 (10Jdlrobson) [23:11:07] (03PS1) 10Paladox: [CategorySortHeaders] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278419 [23:17:50] (03CR) 10Paladox: "It looks like MobileFrontend fails this because jsduck is based on json as json is only supported on php jsduck wont work." [integration/config] - 10https://gerrit.wikimedia.org/r/278004 (https://phabricator.wikimedia.org/T119143) (owner: 10Hashar) [23:18:11] (03CR) 10Paladox: "See https://integration.wikimedia.org/ci/job/npm-node-4.3/784/console please" [integration/config] - 10https://gerrit.wikimedia.org/r/278004 (https://phabricator.wikimedia.org/T119143) (owner: 10Hashar) [23:18:41] hey paladox can you please respond to https://gerrit.wikimedia.org/r/270129 [23:18:46] id be keen to wrap up that patch [23:19:09] jdlrobson: Ok [23:19:31] paladox: thanks [23:20:15] jdlrobson: Sorry i forgot to publish the comments. I did it the day you comment but i thought i pressed the publish button but i didnt so sorry. [23:20:16] https://gerrit.wikimedia.org/r/#/c/270129/ [23:22:06] paladox: so with merge strategy array_plus what does it mean if in extension.json wgMFLazyLoadImages = { "base": false, "beta": true } and in LocalSettings.php I define wgMFLazyLoadImages = array( 'base' => true ); ? [23:22:25] jdlrobson: The reason why it is necessary to do it this way https://gerrit.wikimedia.org/r/#/c/270129/3/extension.json is because when you want to overide the config from LocalSettings.php sometimes it wont overide. Thats why legoktm introduced that. There was a task about this thats why it was fixed. [23:22:55] jdlrobson Im not sure if the config in LocalSettings.php will overide the one in MobileFrontend [23:23:07] well in php array( "base": false, "beta": true ) +array( 'base' => true ); would give array( 'base' => false, 'beta' => true ); [23:23:10] which would break production [23:23:26] would it not? [23:23:29] jdlrobson: Oh but it would be merging it wrong. [23:23:50] switch ( $mergeStrategy ) { [23:23:50] case 'array_merge_recursive': [23:23:50] $GLOBALS[$key] = array_merge_recursive( $GLOBALS[$key], $val ); [23:23:50] break; [23:23:50] case 'array_plus_2d': [23:23:53] $GLOBALS[$key] = wfArrayPlus2d( $GLOBALS[$key], $val ); [23:23:55] break; [23:23:57] case 'array_plus': [23:23:59] $GLOBALS[$key] += $val; [23:24:01] break; [23:24:03] case 'array_merge': [23:24:05] $GLOBALS[$key] = array_merge( $val, $GLOBALS[$key] ); [23:24:07] paladox:you can just link me to the code :) [23:24:07] break; [23:24:09] default: [23:24:11] throw new UnexpectedValueException( "Unknown merge strategy '$mergeStrategy'" ); [23:24:13] jdlrobson ^^ [23:24:18] jdlrobson: Sorry i will do that now. [23:24:30] So yes array_plus is wrong in this case. It should do array_merge [23:24:50] in the above example the result would need to be array( 'base' => true, 'beta' => true ); [23:25:06] jdlrobson https://github.com/wikimedia/mediawiki/blob/master/includes/registration/ExtensionRegistry.php#L256 [23:25:31] jdlrobson: array_merge is the default [23:27:26] jdlrobson: Im not sure if it works. It was broken for us so we had to introduce this so for example [23:27:52] what's broken exactly paladox ? [23:28:03] i didnt see any bug on the task so i've been unable to help with that [23:28:21] array_merge was used for single array whereas array_plus is used for merging in two array and array_plus_2d was used for murging array plus more arrays [23:28:30] I will find the task for you now [23:28:31] from what i heard aude fixed the issue in https://phabricator.wikimedia.org/T126273 few other mechanisms [23:28:39] fixed/worked around [23:29:14] 5Continuous-Integration-Scaling, 10OOjs-UI, 7WorkType-NewFunctionality: Provide composer on the nodepool servers so OOjs UI can use it in the npm job - https://phabricator.wikimedia.org/T128092#2135812 (10Jdforrester-WMF) [23:29:16] 10Continuous-Integration-Config, 5Continuous-Integration-Scaling, 3releng-201516-q3, 7WorkType-NewFunctionality: [keyresult] Migrate php composer (Zend and HHVM) CI jobs to Nodepool - https://phabricator.wikimedia.org/T119139#2135811 (10Jdforrester-WMF) [23:29:21] Anyway that task has nothing to do with MFRemovableClasses, MFLazyLoadReferences and MFSchemaMobileWebLanguageSwitcherSampleRate [23:30:44] jdlrobson: See https://phabricator.wikimedia.org/T100767 please [23:35:04] paladox: the bug tells me nothing.. [23:35:20] it has nothing to do with MobileFrontend [23:35:32] The values you are changing are behaving as they should [23:35:59] jdlrobson: Oh ok. if it works for you and its not broken we can then abandon the patch. [23:37:05] okay thanks paladox glad to wrap that up. [23:37:13] ok [23:56:47] Yippee, build fixed! [23:56:47] Project browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-windows_7-chrome-sauce build #364: 09FIXED in 46 sec: https://integration.wikimedia.org/ci/job/browsertests-CentralNotice-en.wikipedia.beta.wmflabs.org-windows_7-chrome-sauce/364/