[03:18:08] Yippee, build fixed! [03:18:08] Project browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #1018: 09FIXED in 36 min: https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/1018/ [04:24:19] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #758: 04FAILURE in 32 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/758/ [05:26:05] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #734: 04FAILURE in 24 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/734/ [05:49:53] 10MediaWiki-Codesniffer, 3Google-Summer-of-Code-2016: [GSoC 2016 Proposal] Improving static analysis tools for MediaWiki - https://phabricator.wikimedia.org/T130574#2139795 (10Lethexie) [05:57:08] 10MediaWiki-Codesniffer, 3Google-Summer-of-Code-2016: [GSoC 2016 Proposal] Improving static analysis tools for MediaWiki - https://phabricator.wikimedia.org/T130574#2139808 (10Lethexie) @Addshore , @EBernhardson , @Legoktm ,@all any suggestions? [06:07:43] 10MediaWiki-Codesniffer, 3Google-Summer-of-Code-2016: [GSoC 2016 Proposal] Improving static analysis tools for MediaWiki - https://phabricator.wikimedia.org/T130574#2139809 (10Lethexie) [07:48:25] 10MediaWiki-Codesniffer, 3Google-Summer-of-Code-2016: Improving static analysis tools for MediaWiki(GSoC 2016 Proposal) - https://phabricator.wikimedia.org/T130456#2139897 (10Billghost) [07:58:34] 10MediaWiki-Codesniffer, 3Google-Summer-of-Code-2016: Improving static analysis tools for MediaWiki(GSoC 2016 Proposal) - https://phabricator.wikimedia.org/T130456#2139912 (10Billghost) Thanks for reviewing and also for your comments on my proposal [09:13:44] 10MediaWiki-Codesniffer, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2016, 3Outreachy-Round-12: Improving static analysis tools for MediaWiki - https://phabricator.wikimedia.org/T89682#2140001 (10Addshore) [09:15:50] good morning [09:16:49] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T89682) (owner: 10Lethexie) [09:16:54] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) (owner: 10Billm) [09:16:59] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275796 (https://phabricator.wikimedia.org/T89682) (owner: 10Lethexie) [09:18:17] (03CR) 10Addshore: [C: 04-1] "tests should be added!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275796 (https://phabricator.wikimedia.org/T89682) (owner: 10Lethexie) [09:18:23] (03CR) 10Addshore: [C: 04-1] "tests should be added!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) (owner: 10Billm) [09:22:02] (03PS1) 10Hashar: [BookManagerv2] move to Nodepool npm job [integration/config] - 10https://gerrit.wikimedia.org/r/278847 [09:30:54] (03CR) 10jenkins-bot: [V: 04-1] Add the SpaceBeforeControlStructureBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T89682) (owner: 10Lethexie) [09:32:17] (03CR) 10jenkins-bot: [V: 04-1] Add ability for IfElseStructureSniff to detect multiple white spaces after else [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) (owner: 10Billm) [09:36:00] (03CR) 10jenkins-bot: [V: 04-1] Make SpaceyParenthesisSniff can fix multiple white spaces between parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275796 (https://phabricator.wikimedia.org/T89682) (owner: 10Lethexie) [09:43:53] morning hashar ! [09:58:46] addshore: morning :) [10:08:13] (03PS3) 10Billm: Add ability for IfElseStructureSniff to detect multiple white spaces after else [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) [10:12:31] (03CR) 10Billm: "Thanks to all for all the critics on the patch. @01tonythomas: I have corrected the styling issues. @Addshore: Working on the tests" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) (owner: 10Billm) [10:13:52] 5Continuous-Integration-Scaling, 10MobileFrontend, 7WorkType-NewFunctionality: Migrate MobileFrontend npm job to Nodepool - https://phabricator.wikimedia.org/T130587#2140148 (10hashar) [10:14:18] 10Continuous-Integration-Config, 6Operations: Switch CI from jsduck deb package to a gemfile/bundler system - https://phabricator.wikimedia.org/T109005#2140162 (10hashar) [10:14:20] 5Continuous-Integration-Scaling, 10MobileFrontend, 7WorkType-NewFunctionality: Migrate MobileFrontend npm job to Nodepool - https://phabricator.wikimedia.org/T130587#2140148 (10hashar) [10:14:41] 5Continuous-Integration-Scaling, 10MobileFrontend, 7WorkType-NewFunctionality: Migrate MobileFrontend npm job to Nodepool - https://phabricator.wikimedia.org/T130587#2140148 (10hashar) Should most probably use the `rake-jessie` job instead and jsduck provided via a Gemfile which is T109005. [10:15:11] (03PS2) 10Hashar: Move more mw extensions to Nodepool npm job [integration/config] - 10https://gerrit.wikimedia.org/r/278847 (https://phabricator.wikimedia.org/T119143) [10:18:29] (03CR) 10Hashar: [C: 032] Move more mw extensions to Nodepool npm job [integration/config] - 10https://gerrit.wikimedia.org/r/278847 (https://phabricator.wikimedia.org/T119143) (owner: 10Hashar) [10:19:24] (03Merged) 10jenkins-bot: Move more mw extensions to Nodepool npm job [integration/config] - 10https://gerrit.wikimedia.org/r/278847 (https://phabricator.wikimedia.org/T119143) (owner: 10Hashar) [10:25:26] (03PS1) 10Hashar: [MobileFrontend] point to task for npm-legacy [integration/config] - 10https://gerrit.wikimedia.org/r/278857 (https://phabricator.wikimedia.org/T130587) [10:25:28] (03PS1) 10Hashar: [SocialLogin] Migrate npm to Nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/278858 [10:27:29] (03CR) 10Hashar: [C: 032] [MobileFrontend] point to task for npm-legacy [integration/config] - 10https://gerrit.wikimedia.org/r/278857 (https://phabricator.wikimedia.org/T130587) (owner: 10Hashar) [10:27:36] (03CR) 10Hashar: [C: 032] [SocialLogin] Migrate npm to Nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/278858 (owner: 10Hashar) [10:28:25] (03Merged) 10jenkins-bot: [MobileFrontend] point to task for npm-legacy [integration/config] - 10https://gerrit.wikimedia.org/r/278857 (https://phabricator.wikimedia.org/T130587) (owner: 10Hashar) [10:28:33] (03Merged) 10jenkins-bot: [SocialLogin] Migrate npm to Nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/278858 (owner: 10Hashar) [10:31:08] (03Abandoned) 10Hashar: Install npm 2.14.20 for nodejs 4.3 [integration/config] - 10https://gerrit.wikimedia.org/r/278572 (owner: 10Paladox) [10:35:59] 5Continuous-Integration-Scaling, 13Patch-For-Review, 7WorkType-NewFunctionality: Migrate javascript npm CI jobs to Nodepool - https://phabricator.wikimedia.org/T119143#1869279 (10hashar) [11:04:27] 10MediaWiki-Codesniffer, 3Google-Summer-of-Code-2016: Improving static analysis tools for MediaWiki(GSoC 2016 Proposal) - https://phabricator.wikimedia.org/T130456#2140261 (10Billghost) a:3Billghost [11:16:19] (03PS7) 10Lethexie: Add the SpaceBeforeControlStructureBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T130004) [11:39:41] (03PS2) 10Hashar: [ExpandTemplates] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/276076 (owner: 10Paladox) [11:41:29] (03PS2) 10Hashar: [extensions/Nostalgia] Archive repo [integration/config] - 10https://gerrit.wikimedia.org/r/276819 (owner: 10Paladox) [11:41:44] (03CR) 10Hashar: [C: 032] [ExpandTemplates] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/276076 (owner: 10Paladox) [11:42:10] (03CR) 10Hashar: [C: 032] [extensions/Nostalgia] Archive repo [integration/config] - 10https://gerrit.wikimedia.org/r/276819 (owner: 10Paladox) [11:42:40] (03Merged) 10jenkins-bot: [ExpandTemplates] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/276076 (owner: 10Paladox) [11:43:23] (03Merged) 10jenkins-bot: [extensions/Nostalgia] Archive repo [integration/config] - 10https://gerrit.wikimedia.org/r/276819 (owner: 10Paladox) [11:45:57] (03Abandoned) 10Hashar: Remove jsonlint infavour of using npm [integration/config] - 10https://gerrit.wikimedia.org/r/277619 (owner: 10Paladox) [11:47:35] (03PS6) 10Lethexie: Make SpaceyParenthesisSniff can fix multiple white spaces between parentheses [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275796 [11:49:51] (03PS2) 10Hashar: [Comments] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278579 (owner: 10Paladox) [11:49:53] (03PS3) 10Hashar: [CategoryTests] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278417 (owner: 10Paladox) [11:49:55] (03PS2) 10Hashar: [CategorySlideShow] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277909 (owner: 10Paladox) [11:49:57] (03PS2) 10Hashar: [CommentPages] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278577 (owner: 10Paladox) [11:49:59] (03PS2) 10Hashar: [CategorySortHeaders] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278419 (owner: 10Paladox) [11:50:01] (03PS2) 10Hashar: [CharRangeSpan] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278531 (owner: 10Paladox) [11:50:03] (03PS2) 10Hashar: [Checkpoint] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278533 (owner: 10Paladox) [11:50:05] (03PS2) 10Hashar: [CloseWikis] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278537 (owner: 10Paladox) [11:50:07] (03PS2) 10Hashar: [CentralLogging] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278526 (owner: 10Paladox) [11:50:09] (03PS2) 10Hashar: [Commentbox] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278559 (owner: 10Paladox) [11:50:11] (03PS1) 10Hashar: Merge in npm entry point additions [integration/config] - 10https://gerrit.wikimedia.org/r/278872 [11:56:33] (03PS3) 10Hashar: [Comments] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278579 (owner: 10Paladox) [11:56:35] (03PS4) 10Hashar: [CategoryTests] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278417 (owner: 10Paladox) [11:56:38] (03PS3) 10Hashar: [CategorySlideShow] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/277909 (owner: 10Paladox) [11:56:39] (03PS3) 10Hashar: [CommentPages] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278577 (owner: 10Paladox) [11:56:42] (03PS3) 10Hashar: [CategorySortHeaders] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278419 (owner: 10Paladox) [11:56:44] (03PS3) 10Hashar: [CharRangeSpan] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278531 (owner: 10Paladox) [11:56:46] (03PS3) 10Hashar: [Checkpoint] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278533 (owner: 10Paladox) [11:56:48] (03PS3) 10Hashar: [CloseWikis] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278537 (owner: 10Paladox) [11:56:50] (03PS3) 10Hashar: [CentralLogging] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278526 (owner: 10Paladox) [11:56:52] (03PS3) 10Hashar: [Commentbox] Add npm test [integration/config] - 10https://gerrit.wikimedia.org/r/278559 (owner: 10Paladox) [11:56:54] (03PS2) 10Hashar: Merge in npm entry point additions [integration/config] - 10https://gerrit.wikimedia.org/r/278872 [12:09:14] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/276110 (https://phabricator.wikimedia.org/T89682) (owner: 10Lethexie) [12:09:20] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/276466 (https://phabricator.wikimedia.org/T129474) (owner: 10Schenkerx) [12:09:26] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277227 (https://phabricator.wikimedia.org/T129840) (owner: 10Lethexie) [12:09:37] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) (owner: 10Billm) [12:09:44] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T130004) (owner: 10Lethexie) [12:09:49] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275796 (owner: 10Lethexie) [12:22:56] (03PS2) 10Hashar: [Convert2Wiki] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278683 (owner: 10Paladox) [12:22:58] (03PS2) 10Hashar: [ConditionalShowSection] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278583 (owner: 10Paladox) [12:23:00] (03PS2) 10Hashar: [CopyToClipboard] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278686 (owner: 10Paladox) [12:23:02] (03PS2) 10Hashar: [CommunityTwitter] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278581 (owner: 10Paladox) [12:23:04] (03PS2) 10Hashar: [CreditTab] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278690 (owner: 10Paladox) [12:23:06] (03PS2) 10Hashar: [CreatePage] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278688 (owner: 10Paladox) [12:23:08] (03PS2) 10Hashar: [Contest] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278607 (owner: 10Paladox) [12:23:10] (03PS2) 10Hashar: [CSS] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278694 (owner: 10Paladox) [12:23:12] (03PS2) 10Hashar: [CryoKey] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278692 (owner: 10Paladox) [12:23:14] (03PS2) 10Hashar: [Contributors] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278679 (owner: 10Paladox) [12:23:16] (03PS2) 10Hashar: [CongressLookup] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/278588 (owner: 10Paladox) [12:23:18] (03PS1) 10Hashar: Merge in npm test and composer-test additions [integration/config] - 10https://gerrit.wikimedia.org/r/278878 [12:23:20] (03CR) 10jenkins-bot: [V: 04-1] Add ability for IfElseStructureSniff to detect multiple white spaces after else [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) (owner: 10Billm) [12:25:01] (03CR) 10jenkins-bot: [V: 04-1] Make IfElseStructureSniff can detect and fix multiple white spaces after else [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277227 (https://phabricator.wikimedia.org/T129840) (owner: 10Lethexie) [12:26:55] (03CR) 10jenkins-bot: [V: 04-1] Add the SpaceBeforeControlStructureBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T130004) (owner: 10Lethexie) [12:42:19] (03PS3) 10Lethexie: Make IfElseStructureSniff can detect and fix multiple white spaces after else [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277227 (https://phabricator.wikimedia.org/T129840) [12:46:17] (03PS2) 10Hashar: [InputBox] Move jshint to check: [integration/config] - 10https://gerrit.wikimedia.org/r/276622 (owner: 10Paladox) [12:46:19] (03PS2) 10Hashar: [Kartographer] Add jshint and jsonlint to check: [integration/config] - 10https://gerrit.wikimedia.org/r/276623 (owner: 10Paladox) [12:46:21] (03PS2) 10Hashar: [GitHub] Move jsonlint to check: and remove jshint [integration/config] - 10https://gerrit.wikimedia.org/r/276484 (owner: 10Paladox) [12:46:23] (03PS2) 10Hashar: [AllTimeZones] Add jsonlint to check: [integration/config] - 10https://gerrit.wikimedia.org/r/277100 (owner: 10Paladox) [12:46:25] (03PS2) 10Hashar: [AbsenteeLandlord] Add jsonlint to check: [integration/config] - 10https://gerrit.wikimedia.org/r/277084 (owner: 10Paladox) [12:46:27] (03PS2) 10Hashar: [AkismetKlik] Add jsonlint to check: [integration/config] - 10https://gerrit.wikimedia.org/r/277099 (owner: 10Paladox) [12:46:29] (03PS2) 10Hashar: [AdvancedMeta] Add jsonlint to check: [integration/config] - 10https://gerrit.wikimedia.org/r/277098 (owner: 10Paladox) [12:46:31] (03PS1) 10Hashar: Merge jshint/jsonlint to check: changes [integration/config] - 10https://gerrit.wikimedia.org/r/278882 [12:53:50] (03PS2) 10Hashar: [ArticleCreationWorkflow] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/277108 (owner: 10Paladox) [12:54:51] (03CR) 10Hashar: [C: 032] [ArticleCreationWorkflow] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/277108 (owner: 10Paladox) [12:55:05] PROBLEM - App Server bits response on deployment-mediawiki01 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [12:55:57] (03Merged) 10jenkins-bot: [ArticleCreationWorkflow] Archive extension [integration/config] - 10https://gerrit.wikimedia.org/r/277108 (owner: 10Paladox) [12:56:02] Project beta-scap-eqiad build #94888: 04FAILURE in 1 min 19 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/94888/ [13:01:47] (03PS8) 10Lethexie: Add the SpaceBeforeControlStructureBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T130004) [13:03:57] (03CR) 10Lethexie: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T130004) (owner: 10Lethexie) [13:06:03] Yippee, build fixed! [13:06:03] Project beta-scap-eqiad build #94889: 09FIXED in 1 min 18 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/94889/ [13:20:41] (03PS3) 10Zfilipin: WIP Simplify creating of Jenkins jobs for running browser tests daily [selenium] - 10https://gerrit.wikimedia.org/r/275820 (https://phabricator.wikimedia.org/T128190) [13:22:20] (03CR) 10jenkins-bot: [V: 04-1] WIP Simplify creating of Jenkins jobs for running browser tests daily [selenium] - 10https://gerrit.wikimedia.org/r/275820 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [13:44:50] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T130004) (owner: 10Lethexie) [13:44:54] (03CR) 10Addshore: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277227 (https://phabricator.wikimedia.org/T129840) (owner: 10Lethexie) [13:57:05] (03CR) 10jenkins-bot: [V: 04-1] Add the SpaceBeforeControlStructureBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T130004) (owner: 10Lethexie) [14:01:22] (03PS9) 10Lethexie: Add the SpaceBeforeControlStructureBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T130004) [14:09:33] 10Continuous-Integration-Config, 5Continuous-Integration-Scaling: Migrate leftover tox jobs to CI Nodepool - https://phabricator.wikimedia.org/T126588#2140582 (10hashar) p:5Normal>3Low [14:18:59] (03PS4) 10Billm: Add ability for IfElseStructureSniff to detect multiple white spaces after else [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) [14:31:12] 10Gitblit-Deprecate, 10Diffusion: Diffusion redirect from name to callsign doesn't always work - https://phabricator.wikimedia.org/T129447#2140752 (10demon) >>! In T129447#2138246, @Nemo_bis wrote: >>>! In T129447#2118845, @demon wrote: >> Fixed as part of {D139}, just needs deploying. > > Is such a manual du... [14:37:16] (03PS1) 10Hashar: [operations/software/conftool] migrate to tox-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/278896 (https://phabricator.wikimedia.org/T126588) [14:38:55] (03CR) 10Hashar: [C: 032] [operations/software/conftool] migrate to tox-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/278896 (https://phabricator.wikimedia.org/T126588) (owner: 10Hashar) [14:39:51] (03Merged) 10jenkins-bot: [operations/software/conftool] migrate to tox-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/278896 (https://phabricator.wikimedia.org/T126588) (owner: 10Hashar) [15:06:24] hashar: has this rsync fail happened before? https://integration.wikimedia.org/ci/job/npm-node-4.3/1327/console (happened trying to merge patch for SWAT) [15:07:37] thcipriani: ah yeah [15:07:40] I should hide it really [15:07:44] the actual error is: [15:07:45] 00:01:16.559 npm ERR! cb() never called! [15:07:46] 00:01:16.560 npm ERR! not ok code 0 [15:08:00] also: seems like zuul magically re-ran the job? [15:08:06] yeah [15:08:15] neat. [15:08:16] indeed the jobs got cancelled [15:08:28] most probably because another change ahead in the queue had a falling job [15:08:32] so if you have A <-- B [15:08:35] A fails for some reason [15:08:39] the jobs for B are cancelld [15:08:42] A is dropped [15:08:45] the queue becomes: [15:08:46] B [15:08:51] and new jobs for B are emitted [15:09:28] ah. you've mentioned that was a thing, but I don't know that I've ever been watching when it happened. [15:15:19] hashar: what kind of session lifespans are you getting with Horizon? I haven't run a proper test but I feel like the answer for me is 'not very long' even though I have it configured for 7 days. [15:15:44] andrewbogott: browser session I think [15:15:56] with 2FA asked everytme [15:16:27] In theory the horizon session length is 7 days and the keystone token lifespan is 7.1 days [15:16:32] but something else is clearly happening [15:16:38] maybe there is another session timeout when 2FA is enabled? [15:16:55] I don't think so, the 2fa is all wmf-custom code :) [15:18:01] yeah that is a good suspect so ? ;-} [15:18:37] I'm going to run some tests and see if I can figure out what the actual session length is [15:18:50] * andrewbogott opens Safari for the first time this year [15:23:33] hashar: as our resident git guru, any ideas how to configure Gemfile to fetch a gem from gerrit? [15:23:41] this is the docs: http://bundler.io/v1.11/git.html [15:23:44] I have tried this: [15:24:05] gem 'mediawiki_selenium', :git => 'https://gerrit.wikimedia.org/r/mediawiki/selenium', :ref => 'e0c077ef8264d95c519d08f606c65c3cc5633e93' [15:24:56] this works fine [15:24:57] gem 'mediawiki_selenium', :git => 'https://github.com/zeljkofilipin/mediawiki-selenium.git', :branch => 'T128190' [15:24:57] T128190: Simplify creating of Jenkins jobs for running browser tests daily - https://phabricator.wikimedia.org/T128190 [15:25:01] 10Gitblit-Deprecate, 10Diffusion: Diffusion redirect from name to callsign doesn't always work - https://phabricator.wikimedia.org/T129447#2140931 (10Nemo_bis) >>! In T129447#2140752, @demon wrote: >> Is such a manual dump required every time new repositories are added? > > Yep :D Thanks for clarifying. Does... [15:25:28] zeljkof: I have no idea how that syntax works really :( [15:25:35] same here :/ [15:26:04] I do not know how gerrit keeps patch sets [15:26:25] will ask Dan when he wakes up, maybe he knows [15:27:55] 10Gitblit-Deprecate, 10Diffusion: Diffusion redirect from name to callsign doesn't always work - https://phabricator.wikimedia.org/T129447#2140932 (10demon) >>! In T129447#2140931, @Nemo_bis wrote: >>>! In T129447#2140752, @demon wrote: >>> Is such a manual dump required every time new repositories are added?... [15:29:07] hashar: Hi thanks for merging some of my patches. [15:29:17] :) [15:30:10] (03CR) 10Polybuildr: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/275747 (https://phabricator.wikimedia.org/T130004) (owner: 10Lethexie) [15:42:59] (03PS1) 10Hashar: test: speed up valid_jobs_in_check_pipelines [integration/config] - 10https://gerrit.wikimedia.org/r/278914 [15:43:26] paladox: you are welcome :-} [15:43:45] zeljkof: e0c077ef8264d95c519d08f606c65c3cc5633e93 is not a reference [15:43:56] zeljkof: that is ac commit sha1 so you can not git fetch origin e0c077ef8264d95c519d08f606c65c3cc5633e93 [15:44:06] you need a reference, something like: refs/changes/45/12345 [15:44:30] hashar: tried that too :( [15:44:56] or really: :ref => refs/changes/20/275820/3 [15:45:02] the docs say [15:45:03] gem 'rails', :github => 'rails', :ref => 'a9752dcfd15bcddfe7b6f7126f3a6e0ba5927c56' [15:45:27] hashar: It seems that the npm jobs keep failing for the oojs/ui repo see https://gerrit.wikimedia.org/r/#/c/278870/ [15:45:35] so I thought "reference" is a generic term for them [15:45:42] meaning commit [15:45:49] zeljkof: I have no clue how the gem :git stuff works. Most probably it clones the repository listed in :git [15:46:07] zeljkof: and that clone definitely does NOT have the commits from refs/changes/* [15:46:23] yeah [15:46:29] complications [15:46:45] blame Bundler :-} [15:46:56] but indeed if you create abranch [15:47:06] anyway, not a big deal, I was just trying something out, workaround is to fork the repo at github, create a branch there and then it works fine [15:47:15] the branch will be included in the git clone [15:47:17] gem 'mediawiki_selenium', :git => 'https://github.com/zeljkofilipin/mediawiki-selenium.git', :branch => 'T128190' [15:47:18] T128190: Simplify creating of Jenkins jobs for running browser tests daily - https://phabricator.wikimedia.org/T128190 [15:47:30] grr stashbot ... :( [15:47:42] ah it is not logging at least [15:47:46] hashar: what do you mean, how to create a branch? where? [15:47:48] in gerrit? [15:47:57] paladox: for OO repositories, that are tasks filled iirc [15:48:12] zeljkof: https://gerrit-review.googlesource.com/Documentation/cmd-create-branch.html ? [15:48:14] Ok [15:48:48] zeljkof: or use the web ui https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/selenium,branches [15:49:57] (03CR) 10Paladox: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/277761 (https://phabricator.wikimedia.org/T128089) (owner: 10Paladox) [15:50:16] (03CR) 10jenkins-bot: [V: 04-1] [oojs/core] Switch repo to npm-node-4.3 [integration/config] - 10https://gerrit.wikimedia.org/r/277761 (https://phabricator.wikimedia.org/T128089) (owner: 10Paladox) [15:54:33] andrewbogott: so I have logged in Horizon. Looking at the cookies, there is a 'sessionid' one that expires after roughly 3 hours [15:55:51] 3 hours? That's… unexpected. But, thanks [15:57:12] andrewbogott: seems it is a 2 hours 15 minutes cookie [15:57:38] whenever I browse the site, the cookie expiration date is bumped further ahead 2 h 15 m from the time I visit the page [15:57:58] Ah, I see, so it expires after 2:15 idle? [15:57:59] so maybe 135 is lying around or 8100 seconds [15:58:01] or 8000 [15:58:04] yeah [15:58:06] hashar: Hi is it posible if we could cache phantomjs since it has rate limits causing errors [15:58:11] ok, that gives me something to grep for [15:58:16] James_F [15:58:31] andrewbogott: isn't there a Django frontend for horizon? [15:58:50] hashar: I don't know what you mean [15:58:55] paladox: No, the npm cache is meant to work for all npm packages. [15:59:13] andrewbogott: random mumbling forget me :-} [15:59:14] James_F: Oh dosent look like it works it downloads first [15:59:30] James_F: Ive opened an issue here https://github.com/ariya/phantomjs/issues/14124 [16:00:53] James_F: Would downloading the source from github https://github.com/ariya/phantomjs and then building it from source cause the tests times to go up and more resources uses or would it be quicker and less failures. [16:01:12] paladox: That is not the question. [16:01:43] paladox: The question is "why is the CI infrastructure apparently not working to cache npm requests?". [16:01:58] James_F: Yes im not sure [16:02:31] hashar: Hi do you know why caching in npm is not working [16:02:33] Per ^^ [16:02:47] it does [16:02:58] at least it definitely worked yesterday evening [16:03:20] hashar: Oh, it seems to fail this https://integration.wikimedia.org/ci/job/npm/59932/console [16:03:25] and for oojs-ui too [16:03:36] And for VE sometimes, I think. [16:04:45] James_F: and hashar maybe we can update the inbuilt version we use in jenkins to the one we want [16:04:53] hashar, marxarelli: I am in the wrong hangout? or did you forget about the meeting? :) [16:05:11] andrewbogott: it looks like Horizon uses Django as a web framework. Maybe it miss a configuration for the cookie / sessionid expiry time [16:05:40] andrewbogott: or whatever django plugin to auth against keystone miss the expiry/timeout setting [16:05:49] zeljkof: gotta rush actually :( [16:07:17] paladox: well bitbucket rate limit us downloading "https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-x86_64.tar.bz2 [16:07:40] paladox: and the npm install download it under the tmpfs /mnt/home/jenkins-deploy/tmpfs/jenkins-1/ which is discarded after each build [16:07:57] paladox: that should be saved in whatever "npm config cache" yields, i.e. ~/.npm/cache/ [16:08:04] this way it would be collected / cached properly [16:08:16] that is imho a bug in phantomjs-prebuilt [16:08:24] hm [16:08:39] or more precisely: phantomjs-prebuilt not caching [16:08:40] Oh, interesting. [16:08:53] 00:00:35.623 Error requesting archive. [16:08:53] 00:00:35.623 Status: 429 [16:08:58] 429 --- http error code for rate limiting [16:09:17] so one would have to dig in phantomjs-prebuilt to figure out how it deals with caching [16:09:42] and additionally, figure out why phantomjs ends up being a dependency :( [16:11:56] maybe we have a task about that, if not we definitely need one [16:12:56] mind you [16:13:01] even on my machine it is a 429 -:) [16:13:19] Downloading https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-macosx.zip [16:13:19] Saving to /var/folders/wz/nbgqkfqx1_zcsqz5l9j5x_th0000gn/T/phantomjs/phantomjs-2.1.1-macosx.zip [16:13:19] Status: 429 [16:13:27] too many people download it :-} [16:13:58] hashar: Would we be able to update the one in /usr/bin/phantomjs for now until it is fixed or they move from that site to another one [16:14:13] Update from version 1.9.0 to 2.1.1 [16:14:51] nop [16:14:56] not the .deb package [16:15:07] it is outdated on debian [16:15:07] oh [16:15:10] and not even present in Jessie [16:15:10] Ok [16:15:56] then https://www.npmjs.com/package/phantomjs-prebuilt [16:15:59] npm install phantomjs-prebuilt --phantomjs_cdnurl=http://cnpmjs.org/downloads [16:16:12] so potentially an alternative URL can be passed :-} [16:16:18] PHANTOMJS_CDNURL=http://cnpmjs.org/downloads npm install phantomjs [16:16:30] and that can be injected as an env variable from Zuul or in the package.json [16:16:32] or whatever [16:16:44] hashar: How would we do it in package.json [16:16:52] I have no idea! [16:16:52] -:D [16:16:58] That package is brought in by grunt-svg2png [16:17:01] gotta rush out .. [16:17:26] oojs/core list phantomjs-prebuild in its package.json [16:17:39] anyway, might be back later this evening [16:19:55] paladox: just quickly glanced at this channel, we had rate limit errors with phantomjs for the wikipedia.org portal project too. [16:20:33] you can add a git url to package.json, like we did with casper.js here: https://phabricator.wikimedia.org/diffusion/WPOR/browse/master/package.json [16:21:00] jan_drewniak: We are seeing if we can inject a env variable to zuul. Per hashar suggestions [16:21:06] PHANTOMJS_CDNURL=http://cnpmjs.org/downloads npm install phantomjs [16:21:32] jan_drewniak: Thanks for that [16:26:19] James_F: I may have figured out a way we can avoid the rate limit using hashar i idea [16:26:57] I will upload a patch in a sec a test patch. If proved succesful i may have to update a package that is linked to a repo you folked but updated [16:29:41] (03PS1) 10Glaisher: Drop php 5.3 support on labs/tools/stewardbots [integration/config] - 10https://gerrit.wikimedia.org/r/278926 [16:42:42] https://integration.wikimedia.org/ci/job/operations-puppet-pep8/5633/violations/ [16:42:49] What's this extra "Checking file" entry? [16:52:47] and this is rather useless: https://integration.wikimedia.org/ci/job/operations-puppet-pep8/5635/violations/ [17:09:43] 10Continuous-Integration-Config: adjust recheck regex to also act on comment with additional inline comments - https://phabricator.wikimedia.org/T130640#2141424 (10JanZerebecki) [17:10:46] (03PS4) 10Dduvall: WIP Simplify creating of Jenkins jobs for running browser tests daily [selenium] - 10https://gerrit.wikimedia.org/r/275820 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [17:14:55] (03CR) 10jenkins-bot: [V: 04-1] WIP Simplify creating of Jenkins jobs for running browser tests daily [selenium] - 10https://gerrit.wikimedia.org/r/275820 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [17:16:22] (03PS7) 10Dduvall: WIP Simplify creating of Jenkins jobs for running browser tests daily [integration/config] - 10https://gerrit.wikimedia.org/r/274136 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [17:26:15] (03CR) 10MarcoAurelio: [C: 031] Drop php 5.3 support on labs/tools/stewardbots [integration/config] - 10https://gerrit.wikimedia.org/r/278926 (owner: 10Glaisher) [17:30:56] (03PS5) 10Dduvall: WIP Simplify creating of Jenkins jobs for running browser tests daily [selenium] - 10https://gerrit.wikimedia.org/r/275820 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [17:33:59] (03CR) 10jenkins-bot: [V: 04-1] WIP Simplify creating of Jenkins jobs for running browser tests daily [selenium] - 10https://gerrit.wikimedia.org/r/275820 (https://phabricator.wikimedia.org/T128190) (owner: 10Zfilipin) [17:35:30] 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#2141554 (10Jdlrobson) @JanZerebecki that said, we have @cover tags in the repository but they are not showing up (see https://phabricator.wikimedia.org/T102006#2... [17:36:47] (03CR) 10Legoktm: [C: 032] Drop php 5.3 support on labs/tools/stewardbots [integration/config] - 10https://gerrit.wikimedia.org/r/278926 (owner: 10Glaisher) [17:37:42] (03Merged) 10jenkins-bot: Drop php 5.3 support on labs/tools/stewardbots [integration/config] - 10https://gerrit.wikimedia.org/r/278926 (owner: 10Glaisher) [17:40:37] !log deploying https://gerrit.wikimedia.org/r/278926 [17:40:40] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [17:46:36] 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#2141584 (10JanZerebecki) Best by fixing this task, as https://tools.wmflabs.org/coverage/ didn't update since somewhen in 2015, see the bottom right on a coverag... [17:48:29] Project selenium-Math » beta-chrome,contintLabsSlave && UbuntuTrusty build #29: 04FAILURE in 41 sec: https://integration.wikimedia.org/ci/job/selenium-Math/MEDIAWIKI_ENVIRONMENT=beta-chrome,label=contintLabsSlave%20&&%20UbuntuTrusty/29/ [17:49:23] Project selenium-Math » beta-firefox,contintLabsSlave && UbuntuTrusty build #29: 04FAILURE in 1 min 35 sec: https://integration.wikimedia.org/ci/job/selenium-Math/MEDIAWIKI_ENVIRONMENT=beta-firefox,label=contintLabsSlave%20&&%20UbuntuTrusty/29/ [17:49:40] 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#2141601 (10Jdlrobson) Thanks @JanZerebecki [17:55:47] thcipriani: will https://gerrit.wikimedia.org/r/#/c/278923/ make it into the branch? [17:56:07] legoktm: just missed it :( [17:56:11] I can cherry pick. [17:56:21] please :) [17:57:20] legoktm: done: https://gerrit.wikimedia.org/r/#/c/278943/ [17:57:44] +2'd [17:57:53] thank you! [18:14:57] greg-g: What do you think of making a project for deployment blockers, or a tag for it? [18:16:03] how changed the epic and the backlog column? [18:16:23] * Luke081515 moved a deployment blocker to epics because he doesn't read the column names :D [18:26:03] 6Release-Engineering-Team, 7Epic, 7Tracking: [EPIC] Provide pre-merge reports on patchsets (tracking) - https://phabricator.wikimedia.org/T101542#2141782 (10Luke081515) [18:26:33] 10Deployment-Systems, 6Release-Engineering-Team, 7Epic: [EPIC] The future of MediaWiki deployment: Tooling - https://phabricator.wikimedia.org/T94620#2141785 (10Luke081515) [18:26:41] 10Deployment-Systems, 6Release-Engineering-Team, 10ReleaseTaggerBot, 7Epic: [EPIC] Code Deploy Dashboard - https://phabricator.wikimedia.org/T280#2141788 (10Luke081515) [18:27:01] 10Continuous-Integration-Config, 10OOjs-UI, 7Documentation: Link to jsduck docs somewhere in OOUI demos - https://phabricator.wikimedia.org/T127281#2141791 (10Jdforrester-WMF) p:5Triage>3Low [19:05:17] 10Continuous-Integration-Infrastructure, 10puppet-compiler: puppet-compiler should not link to not existing change.*.pson file - https://phabricator.wikimedia.org/T126796#2142042 (10Joe) p:5Triage>3Lowest a:3Joe [19:08:37] 10Deployment-Systems, 6Release-Engineering-Team: Take heat off day before the weekly branch-cut? - https://phabricator.wikimedia.org/T118212#2142087 (10Krinkle) >>! In T118212#1814215, @greg wrote: > We can easily cut the next branch before we deploy it (say, on Friday for the upcoming Tuesday train start) but... [19:23:19] 6Release-Engineering-Team, 6Operations, 6Performance-Team, 7Availability, and 3 others: Dig through logs from 15 Mar 2016 read-only test and file bugs - https://phabricator.wikimedia.org/T129973#2142180 (10aaron) 5Open>3Resolved I did a comb through. AFAIK, everything I saw has a patch or a bug on the... [19:25:58] twentyafterfour: we don't do symlink patches anymore, correct? [19:28:02] Krinkle: ^ now that static.php is a thing, symlinks in /srv/mediawiki-staging are no longer needed? [19:28:02] thcipriani: No new ones indeed [19:28:02] okie doke. [19:28:02] thank you! [19:28:02] and we also made /current/ no longer need updating [19:28:10] before removing the old ones, I'd like to run through some searches with mwgrep [19:28:23] At least Discovery portal and various gadgets ended up using some of them recently [19:50:20] hashar: Hi [20:01:24] hashar: Ive done it here * ChanServ gives voice to hashar [20:01:24] Deployment-Systems, Release-Engineering-Team: Take heat off day before the weekly branch-cut? - https://phabricator.wikimedia.org/T118212#2142087 (Krinkle) >>! In T118212#1814215, @greg wrote: > We can easily cut the next branch before we deploy it (say, on Friday for the upcoming Tuesday train start) but... [20:01:24] * Luke081515 is now known as Luke|Dinner [20:01:24] * subbu is now known as subbu|away [20:01:24] T118212: Take heat off day before the weekly branch-cut? - https://phabricator.wikimedia.org/T118212 [20:01:25] * marxarelli is now known as marxarelli|afk [20:01:27] Release-Engineering-Team, Operations, Performance-Team, Availability, and 3 others: Dig through logs from 15 Mar 2016 read-only test and file bugs - https://phabricator.wikimedia.org/T129973#2142180 (aaron) Open>Resolved I did a comb through. AFAIK, everything I saw has a patch or a bug on the... [20:01:31] twentyafterfour: we don't do symlink patches anymore, correct? [20:01:33] Krinkle: ^ now that static.php is a thing, symlinks in /srv/mediawiki-staging are no longer needed? [20:01:36] thcipriani: No new ones indeed [20:01:38] okie doke. [20:01:40] thank you! [20:01:42] and we also made /current/ no longer need updating [20:01:44] before removing the old ones, I'd like to run through some searches with mwgrep [20:01:46] At least Discovery portal and various gadgets ended up using some of them recently [20:01:48] * yurik has quit (Read error: Connection reset by peer) [20:01:52] * yurik (~yurik@mediawiki/Yurik) has joined [20:01:54] * marxarelli|afk is now known as marxarelli [20:01:56] * yurik has quit (Ping timeout: 264 seconds) [20:01:58] hashar: Hi [20:02:00] Woops sorry [20:02:02] i doint know why it copied everything [20:02:04] It this https://gerrit.wikimedia.org/r/#/c/278928/ [20:02:25] I clicked paste and it pasted everything i viewed. Sorry about that. [20:03:15] hashar: It seems to sometimes fail karma for oojs-ui. See https://integration.wikimedia.org/ci/job/npm/59959/console [20:03:34] It says cannot start chromium too. [20:10:11] paladox: I have no clue how Karma drives Chromium really :( [20:10:41] hashar: ive managed to fix the ooui js timing too. [20:10:46] Down to 13 mins [20:12:39] I had to fork the repo https://github.com/paladox/phantomjs and updated to use the github link which would not hit rate limit [20:12:43] hashar ^^^ [20:13:06] paladox: poke the folks maintaining the repositories depending on PhantomJs [20:13:13] not much I can do I am afraid [20:13:18] ok [20:30:59] Luke081515: maybe, should propose it somewhere (like qa@lists), right now I just create a new task for each wmf.XX branch to collect the blockers, but I haven't announced it widely. We used to have a single "next deployment blocker" tracking task in bugzilla, but it waxed and waned in use. [20:31:07] Luke081515: /me is just rambling now [20:37:38] Ok :) [20:44:23] 6Release-Engineering-Team, 15User-greg: Update [[Requests_for_comment/Migrate_code_review_and_management_to_Phabricator_from_Gerrit]] - https://phabricator.wikimedia.org/T130664#2142446 (10greg) [20:47:11] 10Continuous-Integration-Infrastructure, 6Operations, 6Services: Package npm 2.14 - https://phabricator.wikimedia.org/T124474#2142472 (10Krinkle) [20:50:49] 10Deployment-Systems, 6Release-Engineering-Team: Take heat off day before the weekly branch-cut? - https://phabricator.wikimedia.org/T118212#2142481 (10greg) >>! In T118212#2142087, @Krinkle wrote: > Like with prod, we could use multiversion in beta too. Requests for `*.beta.wmflabs.org` and `*.staging.wmflabs... [20:53:56] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #962: 04FAILURE in 27 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/962/ [21:14:06] hashar: It says this [21:14:06] Cannot write: No space left on device [21:14:12] https://integration.wikimedia.org/ci/job/npm/59969/console [21:23:07] paladox: yeah it downloads in the temp directory which is a 256MBytes tmpfs disk [21:23:28] hashar: Oh, sorry. [21:27:55] paladox: I believe the phantomjs node module should store the tarball under the npm cache ( npm config get cache ) [21:28:01] which would be ~/.npm [21:28:20] but that solely hold the actual module [21:28:56] hashar: Oh [21:29:18] So do i do something like npm cache add phantomjs-prebuilt@2.1.6 && npm config get cach [21:29:25] and apparently the node module downloads the tarball from a CDN under /tmp [21:29:35] so if you get to install it twice on different projects, you would download the whole tarball again [21:29:48] imho it should cache the tarball [21:30:16] hashar: Ok, ive been testing using the binary i added in github for improved uses such as no more rate limits [21:35:14] Hi all, I'm playing with integration/config to add a job/template to automate some of the maven stuff we do in analytics repos. I imagine it would involve changes to zuul and jjb config - is there a way to test all this locally? [21:36:33] paladox: so in short, phantomjs-prebuilt distribution strategy is broken ;D [21:36:43] madhuvishy: not much :-} [21:37:12] madhuvishy: I usually hack a new job as a YAML definition in some of the jjb/*.yaml file [21:37:15] then deploy the job on Jenkins [21:37:34] hashar: ah what is the best way to test it then? I can push gerrit patches - but hopefully not need to get them merged before playing with them [21:37:51] hashar: Yes [21:38:17] madhuvishy: with https://www.mediawiki.org/wiki/CI/JJB to be used as an installation setup guide for JJB [21:38:33] madhuvishy: but yeah in short, most of us deploy the Jenkins job first [21:39:05] madhuvishy: then head to the Web interface http://integration.wikimedia.org/ci/ , login with the labs LDAP account, search for the job then run a build of it [21:39:25] madhuvishy: most jobs have parameters, such as the Gerrit project name , branch to build etc [21:39:39] once happy with the job, I push it for review [21:40:14] hashar: aah I see [21:40:59] hashar: okay I think I understand - they can be deployed directly without merging. cool thanks :) [21:42:16] madhuvishy: there are some maven jobs floating around [21:42:48] hashar: yeah I saw the ones in integration/config - we are hoping to automate our jar releases using jenkins [21:43:00] ohhh [21:43:24] and may be committing update to changelog with it [21:43:31] with something like mvn release ? :D [21:43:34] yeah [21:43:40] maven is great [21:43:55] I like the pre defined targets it has [21:44:15] ha ha - mvn release is a little bit of a pain though - it has 2 steps - and they are not idempotent [21:45:18] a worry point is CI is pretty much freestyle , might cause issues for signing the jar if there is such a thing [21:45:45] hashar: ah I'll keep that in mind - we don't do any signing as far as I know [21:46:08] Jenkins as a credential store though, and a specific credential can be injected on a specific job [21:46:23] but anyone in wmf / nda / wmde LDAP group would get access to it [21:46:33] hashar: Like this https://gerrit.wikimedia.org/r/#/c/278973/ for chaching [21:47:05] for mediawiki release, at one point we thought about a two step process. Jenkins to do the grunt work that provides the tarballs then a manual / human step to verify the work, sign and publish to releases.wikimedia.org [21:47:25] madhuvishy: ideally we would have a private / internal jenkins to do release signing [21:48:02] paladox: I have no idea :( I am definitely not going to work on that one though [21:48:10] ok [21:48:33] paladox: the only idea that comes to mind would be to set up a shared web proxies and have the CI jobs uses that ( by injecting http_proxy and https_proxy to the jobs) [21:48:44] hashar: Oh ok [21:49:02] paladox: this way in theory we would have commands honoring http_proxy to hit a shared cache on our infra [21:49:08] hashar: im thinking for https://phabricator.wikimedia.org/T124474 we can use one of the ubuntu packages that have the latest npm 3 packaged. [21:49:13] ok [21:49:38] paladox: maybe wmflabs as such a cache already :) might be a good thing that would benefit all of wmflabs.org [21:49:44] hashar: hmmm - I'm not super familiar with the details of signed releases - in our case we publish to archiva - and yeah we'd probably have to inject archiva creds using jenkins [21:49:56] ok [21:50:13] paladox: there is a task to get a more recent npm to be packaged / backported. But Debian packaging scares me really. Would be best handled by ops / services [21:50:24] hashar: Ok [21:52:13] madhuvishy: you can at least get a maven job to generate the material, signing can be figured out later [21:52:41] madhuvishy: I am usually on European business hours, but you can reach out to folks having +voice in this channel , or just ask :D [21:53:10] madhuvishy: alternatively there is the QA mailing list that has a lot of Jenkins advanced users for help and that list also deals with releasing [21:53:44] hashar: okay :) thanks! will do. We plan to also automate our deployments to the analytics cluster next - so i'll be asking a lot of things in the near future. [21:53:55] cool! [21:54:07] i'll sign up for the list too [21:54:10] madhuvishy: so you have reach the right team :-)) [21:54:19] feel free to spam new tasks in Phabricator ;} [21:54:30] if you dont know which specific project #releng will do and poke all of us [21:54:38] awesome, thanks :D [21:54:46] we can then reroute the task to the appropriate sub project we champions [21:54:55] same for deployment to analytics cluster I guess [21:54:57] hashar: DO you think it is a good idea to use https://www.npmjs.com/package/npm this for now. Adding it in dependance field. [21:55:19] madhuvishy: the scap3 deployment system will hopefully help ;-} https://doc.wikimedia.org/mw-tools-scap/scap3/index.html [21:55:43] paladox: what is the idea? [21:56:08] hashar: sure, i'll do most of the work - will need advice/CRs. Yeah the plan is look into using scap2 for the deployments [21:56:12] To use that to update npm it wont stick but it will allow the user to use npm 2.x or 3.x [21:56:16] scap3 [21:56:29] This making the update to node 4.3 an upgrade instead of down grade for npm. [21:57:18] Yes its a work around and some might say whats the point, the point is that 2.x is still supported 1.x isent. I think its going to be a while before npm 2.x or 3.x is packaged for jessie for wikimedia. [21:57:50] madhuvishy: it is kind of a goal to have most things migrated to scap3 , there are a few columns on the scap3 workboard at https://phabricator.wikimedia.org/tag/scap3/ [21:58:09] madhuvishy: no clue whether analytics/jar thing will fit in scap3 [21:59:45] hashar: Looks like improved testing at https://gerrit.wikimedia.org/r/#/c/278973/ [22:00:06] Not perfect and posibly we can up the karma time to reduce chances of failures. [22:00:07] hashar: ya at this point I have no clue - i'll look into it after the release thing is done. But I think so - we deploy stuff from tin - and probably have to do something to put the released jars in the right place. [22:00:19] right now its all manual [22:00:36] (git deploy but we do it all) [22:01:03] James_F: Hi i still have to update the commit msg. But do you like how it is set here https://gerrit.wikimedia.org/r/#/c/278973/ [22:01:31] It decresed the chances of failures and increase performance brining testing down to 11 mins [22:02:24] madhuvishy: maybe there is already a task covering your soft so :-} [22:03:02] hashar: indeed it is https://phabricator.wikimedia.org/T129151 [22:03:18] (also a team goal for us next quarter) [22:04:20] madhuvishy: nice! Andrew Otto pairs with thcipriani on some other scap3 adoption task. So I guess Andrew will eventually reach that analytics-refinery [22:04:44] madhuvishy: paladox gotta get to bed / sleep etc! [22:04:57] Ok [22:05:53] * thcipriani reads scrollback [22:06:11] we have git-fat support in scap3 merged but not deployed out just yet, FWIW. [22:07:23] hashar: night! thanks for all the help [22:10:18] 10Continuous-Integration-Infrastructure, 6Operations, 6Services: Package npm 2.14 - https://phabricator.wikimedia.org/T124474#2142877 (10hashar) I have looked at Debian source package from https://anonscm.debian.org/git/collab-maint/nodejs.git branch `master-lts` and it pass the config flag `--without-npm` .... [22:26:15] 10Continuous-Integration-Infrastructure: Broken pep8 violations report - https://phabricator.wikimedia.org/T130681#2142945 (10Krenair) [22:27:51] (03CR) 10Hashar: "legoktm : mind looking over my shoulders for this patch? It is basically rewriting the way we find unsafe jobs. Previously each iteration" [integration/config] - 10https://gerrit.wikimedia.org/r/278914 (owner: 10Hashar) [22:31:04] 10Browser-Tests-Infrastructure, 10Reading-Web, 13Patch-For-Review, 5WMF-deploy-2016-03-22_(1.27.0-wmf.18): Fix MobileFrontend scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily - https://phabricator.wikimedia.org/T94156#2142964 (10bmansurov) [22:34:56] 10Continuous-Integration-Infrastructure: Broken pep8 violations report - https://phabricator.wikimedia.org/T130681#2142945 (10hashar) What is messed? The result of pep8 runs are appended to a pep8.txt file. That file is then processed by the Jenkins violations pug to forge the human friendly report. [22:59:04] 6Release-Engineering-Team, 15User-greg: Outline roles and responsibilities for SWAT members - https://phabricator.wikimedia.org/T129905#2119500 (10greg) https://wikitech.wikimedia.org/w/index.php?title=SWAT_deploys&type=revision&diff=383402&oldid=383363 [22:59:20] is there an issue with qunit tests currently? [22:59:47] e.g. https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/36023/consoleFull - completely minor patch unrelated to qunit produces qunit fails [23:00:14] Notice: Cannot find site mywiki in sites table [23:01:20] SMalyshev: Hi nope that is not causing the failure. That is caused by wikidata and is know but isent causing any problems [23:02:01] paladox: ok. so then something else is the problem? [23:02:38] maybe this: 2:48:52 npm ERR! Linux 3.13.0-76-generic [23:02:38] 22:48:52 npm ERR! argv "node" "/usr/local/bin/npm" "install" [23:02:38] 22:48:52 npm ERR! node v0.10.25 [23:02:38] 22:48:52 npm ERR! npm v2.14.12 [23:02:38] 22:48:52 [23:02:39] 22:48:52 npm ERR! version not found: left-pad@0.0.3 [23:02:43] SMalyshev: Yes someone unpbulished the package [23:02:51] https://github.com/azer/left-pad/issues/4 [23:02:59] Smalyshev ^^ [23:05:26] paladox: thanks [23:05:55] SMalyshev: I think the problem may be fixed now. Ive rechecked your patch and we will see if it is fixed. [23:06:02] It broke alot of repos [23:10:41] paladox: 23:07:31 Error: your composer.lock file is not up to date. Run "composer update" to install newer dependencies [23:10:50] something new [23:11:01] 23:07:31 MediaWiki 1.27.0-alpha Updater [23:11:01] 23:07:31 [23:11:02] 23:07:31 oojs/oojs-ui: 0.16.4 installed, 0.16.3 required. [23:11:02] 23:07:31 Error: your composer.lock file is not up to date. Run "composer update" to install newer dependencies [23:11:02] 23:07:31 Build step 'Execute shell' marked build as failure [23:11:37] SMalyshev thats because in mediawiki/vendor it was updated to oojs/oojs-ui 0.16.4 and mediawiki core was c+2ed but because of the error we had it didnt merge the patch [23:11:43] See https://gerrit.wikimedia.org/r/#/c/279068/1 [23:12:10] ouch... gotta love dependencies. OK, I'll wait until the storm subsides [23:12:46] SMalyshev: Ok, its merging now https://integration.wikimedia.org/zuul/ [23:18:25] SMalyshev: https://twitter.com/seldo/status/712414588281552900 [23:18:48] paladox: yeah seen it, thanks [23:20:04] Project beta-update-databases-eqiad build #7318: 04FAILURE in 3.2 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/7318/