[03:12:37] Yippee, build fixed! [03:12:38] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce build #942: 09FIXED in 22 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/942/ [04:21:17] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce build #781: 04FAILURE in 29 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-9-sauce/781/ [04:23:05] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce build #784: 04FAILURE in 16 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_8.1-internet_explorer-11-sauce/784/ [05:26:15] Project browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce build #757: 04FAILURE in 24 min: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-11-sauce/757/ [07:39:04] (03PS4) 10Aashaka: Add sniff to check if boolean operator on same line inside 'if condition' [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/279615 (https://phabricator.wikimedia.org/T116561) [07:39:06] (03PS1) 10Aashaka: Stop reference of string $content as an array [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/283384 (https://phabricator.wikimedia.org/T127572) [08:24:25] 10releng-201516-q2, 10releng-201516-q3, 10scap, 10Scap3 (Scap3-Adoption-Phase1): [keyresult] Migrate all Service team owned services and MW to scap - https://phabricator.wikimedia.org/T109926#2206169 (10mobrovac) [08:24:27] 10scap, 10Citoid, 06Services, 10VisualEditor, 10Scap3 (Scap3-Adoption-Phase1): Deploy Citoid with scap3 - https://phabricator.wikimedia.org/T116337#2206165 (10mobrovac) 05Open>03Resolved Citoid has been deployed today with Scap3! \o/ [08:59:50] 07Browser-Tests, 10Browser-Tests-Infrastructure, 10Continuous-Integration-Config, 10Wikidata, and 2 others: [Task] Remove Wikidata performance-tests jobs - https://phabricator.wikimedia.org/T130017#2206244 (10adrianheine) https://github.com/wmde/WikidataBrowserTests/pull/110 [09:43:24] 07Browser-Tests, 10Browser-Tests-Infrastructure, 10Continuous-Integration-Config, 10Wikidata, and 2 others: [Task] Remove Wikidata performance-tests jobs - https://phabricator.wikimedia.org/T130017#2206275 (10adrianheine) 05Open>03Resolved a:03adrianheine [09:44:19] Project browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-monobook-sauce build #779: 04FAILURE in 23 min: https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-monobook-sauce/779/ [11:34:56] PROBLEM - Host integration-trusty-1026 is DOWN: CRITICAL - Host Unreachable (10.68.17.98) [13:10:12] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: mwext-testextension-hhvm-composer build timed out (after 30 minutes) - https://phabricator.wikimedia.org/T132681#2206677 (10adrianheine) [13:47:28] Hey! Could I please get some help with https://gerrit.wikimedia.org/r/#/c/282641/1? Will I have to setup composer in the ImageTweaks repo for this to work? [13:48:43] Looks like it, yeah [13:49:17] composer.json is just side config [13:51:01] prtksxna: The composer.json is very simple, you you can copypasta [13:51:20] In fact, I'd say jfdi [13:54:34] Reedy: Cool! Does https://phabricator.wikimedia.org/diffusion/EPOP/browse/master/composer.json look alright to copy? [13:54:48] prtksxna: Indeed [13:55:03] Thanks Reedy! :) [14:00:20] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2206203 (10hashar) Seems like one has to manually accept the remote ssh host key. On production the various host keys are collected via puppet but that is... [14:00:31] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2206862 (10hashar) p:05Triage>03Normal [14:03:44] 10Beta-Cluster-Infrastructure, 06Labs, 07Puppet: /etc/puppet/puppet.conf keeps getting double content - first for labs-wide puppetmaster, then for the correct puppetmaster - https://phabricator.wikimedia.org/T132689#2206880 (10Krenair) [14:07:24] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2206894 (10mobrovac) Actually, it turns out the user doesn't even exist there: ``` root@deployment-tin:~# groups deploy-service groups: deploy-service: no... [14:16:07] Reedy: Mind reviewing https://gerrit.wikimedia.org/r/#/c/283445/? [14:16:36] RECOVERY - Puppet staleness on deployment-cache-text04 is OK: OK: Less than 1.00% above the threshold [3600.0] [14:20:50] Reedy: Is it ok if I V+2? Jenkins wont do anything here. [14:20:57] lol, or I can [14:27:22] (03PS2) 10Prtksxna: [ImageTweaks] Add npm test and jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/282641 [14:29:46] 10Beta-Cluster-Infrastructure, 10scap, 10Analytics, 06Services, and 3 others: Set up AQS in Beta - https://phabricator.wikimedia.org/T116206#2206968 (10Krenair) [14:29:50] 10Beta-Cluster-Infrastructure, 03Scap3, 06Revision-Scoring-As-A-Service, 13Patch-For-Review, 07Puppet: Puppet on deployment-((sca|aqs)01|ores-web) fails due to scap3 errors - https://phabricator.wikimedia.org/T132267#2206969 (10Krenair) [14:30:54] 10Beta-Cluster-Infrastructure, 03Scap3, 06Revision-Scoring-As-A-Service, 07Puppet: Puppet on deployment-((sca|aqs)01|ores-web) fails due to scap3 errors - https://phabricator.wikimedia.org/T132267#2192991 (10Krenair) Yep, now AQS [14:31:44] (03PS3) 10Prtksxna: [ImageTweaks] Add npm test and jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/282641 [14:42:44] Reedy: Good to merge? [14:42:49] ? [14:43:02] Oh [14:43:09] I could, but I don't know about deploying it [14:46:40] It can wait. Thanks for all your help :) [14:55:34] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2206203 (10Krenair) >>! In T132666#2206856, @hashar wrote: > Seems like one has to manually accept the remote ssh host key. On production the various host... [14:57:32] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2207079 (10Krenair) >>! In T132666#2206894, @mobrovac wrote: > Actually, it turns out the user doesn't even exist there: > > ``` > root@deployment-tin:~#... [15:00:10] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2207090 (10thcipriani) The Group exists: ``` thcipriani@deployment-tin:~$ getent group deploy-service deploy-service:x:52946:thcipriani,ladsgroup,mobrovac... [15:28:31] Project browsertests-Math-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce build #884: 04FAILURE in 30 sec: https://integration.wikimedia.org/ci/job/browsertests-Math-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/884/ [16:27:28] 10Continuous-Integration-Infrastructure: Install php7 and the php-ast extension so etsy/phan can be run from jenkins - https://phabricator.wikimedia.org/T132636#2207388 (10EBernhardson) There are debs for trusty, but they are not official. For many years now [[ https://launchpad.net/~ondrej/+archive/ubuntu/php |... [16:34:53] Anyone mind if I test out a live hack on beta, on the security host? [16:36:30] !log does some mucking around on deployment-mediawiki03 [16:37:08] 10Beta-Cluster-Infrastructure, 05MW-1.27-release-notes, 13Patch-For-Review, 15User-bd808, 05WMF-deploy-2016-04-12_(1.27.0-wmf.21): Scap mwscript rebuildLocalisationCache.php fails - https://phabricator.wikimedia.org/T132370#2207403 (10daniel) Sorry for the oversight regarding MW_SERVICE_BOOTSTRAP_COMPLET... [16:38:04] 10Beta-Cluster-Infrastructure, 05MW-1.27-release-notes, 13Patch-For-Review, 15User-bd808, 05WMF-deploy-2016-04-12_(1.27.0-wmf.21): Scap mwscript rebuildLocalisationCache.php fails - https://phabricator.wikimedia.org/T132370#2207405 (10daniel) I re-submitted to offending patch and will work on it to fix t... [17:27:24] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2207604 (10mobrovac) Duh, thnx @thcipriani! For `deployment-sca01` it works, but I get asked for my password for `deployment-sca02`: ``` mobrovac@deployme... [17:30:22] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2207608 (10Krenair) ```root@deployment-sca02:/etc/ssh/userkeys# cat deploy-service ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCvbV8H7VzyH+NZuCMakT/YYIZH8qyzi1V... [17:37:44] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2207680 (10mobrovac) Hmmm, so I guess Puppet doesn't manage the keys? I'll just copy it from `sca01` [17:45:10] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2207702 (10thcipriani) >>! In T132666#2207680, @mobrovac wrote: > Hmmm, so I guess Puppet doesn't manage the keys? I'll just copy it from `sca01` I think... [17:47:00] 10Beta-Cluster-Infrastructure, 05MW-1.27-release-notes, 13Patch-For-Review, 15User-bd808, 05WMF-deploy-2016-04-12_(1.27.0-wmf.21): Scap mwscript rebuildLocalisationCache.php fails - https://phabricator.wikimedia.org/T132370#2207704 (10bd808) @daniel my statements about `rebuildLocalisationCache.php` may... [18:05:15] +1 [18:40:19] 10Beta-Cluster-Infrastructure, 05MW-1.27-release-notes, 13Patch-For-Review, 15User-bd808, 05WMF-deploy-2016-04-12_(1.27.0-wmf.21): Scap mwscript rebuildLocalisationCache.php fails - https://phabricator.wikimedia.org/T132370#2207865 (10daniel) @bd808 Ok. But doing a service reset isn't going to do any har... [18:43:34] hey uhh twentyafterfour [18:43:43] the default scap::source $repository is the title [18:43:46] so you can even just do [18:43:47] in [18:43:47] https://gerrit.wikimedia.org/r/#/c/283494/2/hieradata/common/scap/server.yaml,cm [18:43:55] phabricator/deployment: ~ [18:43:56] and that's it [18:44:08] right on.. [18:44:32] thcipriani: hey, I mentioned you here: https://gerrit.wikimedia.org/r/#/c/280403/45/modules/ores/manifests/scapdeploy.pp [18:44:42] It would be great if you take a look at this :) [18:44:44] thanks [18:58:46] 06Release-Engineering-Team, 06Team-Practices, 10Developer-Relations (Jul-Sep-2016): Developer Summit 2017: Work with TPG and RelEng on solution to event documenting - https://phabricator.wikimedia.org/T132400#2207899 (10Rfarrand) p:05Normal>03Low [19:04:40] 07Browser-Tests, 10Browser-Tests-Infrastructure: Unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055) (Selenium::WebDriver::Error::WebDriverError) - https://phabricator.wikimedia.org/T132713#2207944 (10Gilles) [19:04:53] 07Browser-Tests, 10Browser-Tests-Infrastructure: Unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055) (Selenium::WebDriver::Error::WebDriverError) - https://phabricator.wikimedia.org/T132713#2207956 (10Gilles) p:05Triage>03Unbreak! [19:20:52] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2208034 (10Krenair) So where is the key on sca01 coming from? [19:21:44] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2208037 (10Krenair) Oh, you mean ORES somehow forces the key to be correct on sca01 via some method we already configured in beta? [19:44:03] 07Browser-Tests, 10Browser-Tests-Infrastructure: Unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055) (Selenium::WebDriver::Error::WebDriverError) - https://phabricator.wikimedia.org/T132713#2208089 (10Gilles) [19:47:03] 07Browser-Tests, 10Browser-Tests-Infrastructure: Unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055) (Selenium::WebDriver::Error::WebDriverError) - https://phabricator.wikimedia.org/T132713#2208106 (10Gilles) Hmmm some subsequent runs are fine: https://integration.wikimedia.org/ci/job/mw... [19:48:21] twentyafterfour: We can use php explode to hide the changes branches from diffusion gui [19:48:55] paladox: why do we even need to import the changes if we are going to hide them in the gui? what purpose do they serve then? [19:49:24] just so that they will exist in git? If that's all we want then we should just adjust the refspec but leave the rest of phabricator code as-is [19:51:44] twentyafterfour: It is to allow us to when we click on a link in gerrit and its an open patch we should be able to view it in duffusion without needing to use git.wikimedia.org or github.com. Plus you have to do it this way for it to get recognised by diffusion otherwise it will fail. [19:51:56] But it will also not impact performance hopefully [19:53:57] 07Browser-Tests, 10Browser-Tests-Infrastructure: Unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055) (Selenium::WebDriver::Error::WebDriverError) - https://phabricator.wikimedia.org/T132713#2208140 (10Gilles) Duh, I forgot about Gemfile.lock. It's probably a Firefox update that made the o... [19:56:58] 07Browser-Tests, 10Browser-Tests-Infrastructure: Unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055) (Selenium::WebDriver::Error::WebDriverError) - https://phabricator.wikimedia.org/T132713#2208144 (10Gilles) 05Open>03Invalid [20:27:43] paladox: I think I'm willing to try it but I am still a bit hesitant to import so many old revisions and bog down phabricator with a lot of extra data to process [20:28:04] I would like to hear ostriches opinion on that before moving forward [20:29:04] twentyafterfour: Ok, we could do it until we migrate since we can remove the changes from refs in .git from the repos. Yes theres many but old unused repo should not contain tons of refs its the bigger ones such as mw core. [20:29:52] it's not so easy to remove stuff once it's imported [20:31:47] twentyafterfour: ok, with the explode thing i got it down to only show branch changes/ once instead of the manny refs in that branch which is good, so not hidden tottally and only shows a recent uploaded patch [20:32:35] But one good thing with this is when we switch to github as our mirror on phabricator instead of gerrit, github will get all our refs even if there not shown. [20:35:55] PROBLEM - Puppet run on deployment-eventlogging04 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [20:38:10] PROBLEM - Puppet run on integration-slave-trusty-1014 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [20:47:09] 10Beta-Cluster-Infrastructure, 10Monitoring, 13Patch-For-Review, 07Shinken: Monitor keyholder on deployment-prep deployment servers - https://phabricator.wikimedia.org/T111064#2208333 (10Krenair) It's not working, seems the script is not getting run [20:55:05] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2206203 (10Ladsgroup) [[https://gerrit.wikimedia.org/r/#/c/280403/45/modules/ores/manifests/scapdeploy.pp|Related discussion]]. Please correct me if I'm wr... [21:03:03] 06Release-Engineering-Team, 06Operations: reinstall/upgrade gerrit server (ytterbium) from precise to jessie - https://phabricator.wikimedia.org/T125018#2208382 (10Andrew) p:05Triage>03Normal a:03Dzahn [21:08:39] 06Release-Engineering-Team, 06Operations: reinstall/upgrade gerrit server (ytterbium) from precise to jessie - https://phabricator.wikimedia.org/T125018#2208423 (10Dzahn) a:05Dzahn>03None [21:13:05] RECOVERY - Puppet run on integration-slave-trusty-1014 is OK: OK: Less than 1.00% above the threshold [0.0] [21:20:47] twentyafterfour: I'm also interested in hearing what ostriches thinks about this [21:21:16] * ostriches has thoughts, will respond shortly. [21:21:55] what's interesting to me is that I know Gerrit's reason to live is because Shawn wanted to roll code review functionality into Git [21:22:13] * robla looks up Shawn's name [21:23:11] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config, 13Patch-For-Review: Send beta cluster Jenkins alerts to betacluster-alert list - https://phabricator.wikimedia.org/T1125#2208461 (10Krenair) 05Open>03Resolved [21:23:42] ah right: Shawn Pearce https://en.wikipedia.org/wiki/Gerrit_(software) [21:24:24] * robla was afraid he was spelling Sean/Shahn/Chiean incorrectly [21:25:35] Shawn has a fair amount of credibility to get things rolled upstream (from him) into Git given his background [21:26:03] ..and I think he's probably right; code review functionality *should* be part of Git [21:35:05] 10Beta-Cluster-Infrastructure, 03Scap3, 10Citoid, 06Services, 10VisualEditor: Can't deploy Citoid in Beta - https://phabricator.wikimedia.org/T132666#2208506 (10thcipriani) >>! In T132666#2208037, @Krenair wrote: > Oh, you mean ORES somehow forces the key to be correct on sca01 via some method we already... [21:43:18] 10Beta-Cluster-Infrastructure, 10Monitoring, 13Patch-For-Review, 07Shinken: Monitor keyholder on deployment-prep deployment servers - https://phabricator.wikimedia.org/T111064#2208538 (10Krenair) PS3 should work [21:45:54] PROBLEM - Puppet run on integration-slave-trusty-1015 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [21:46:52] PROBLEM - Puppet run on integration-slave-precise-1002 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [21:51:31] !log enabled oath on beta for Staff global group [21:55:55] 10Beta-Cluster-Infrastructure, 06Security-Team, 13Patch-For-Review: Install Ex:OATH to beta - https://phabricator.wikimedia.org/T131420#2208550 (10csteipp) 05Open>03Resolved [22:14:21] 10Beta-Cluster-Infrastructure, 06Labs, 10Labs-Infrastructure, 06Operations, and 2 others: Clean up labs graphite datapoints - https://phabricator.wikimedia.org/T111540#2208576 (10Krenair) [22:18:48] 10Beta-Cluster-Infrastructure, 06Labs, 10Labs-Infrastructure: deployment-sentry2 /var is full - https://phabricator.wikimedia.org/T132730#2208581 (10Krenair) [22:18:56] 10Beta-Cluster-Infrastructure: deployment-sentry2 /var is full - https://phabricator.wikimedia.org/T132730#2208595 (10Krenair) [22:20:53] RECOVERY - Puppet run on integration-slave-trusty-1015 is OK: OK: Less than 1.00% above the threshold [0.0] [22:21:57] RECOVERY - Puppet run on integration-slave-precise-1002 is OK: OK: Less than 1.00% above the threshold [0.0] [22:33:52] 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver: Shinken is warning about cxserver on deployment-cxserver03 returning 404s - https://phabricator.wikimedia.org/T132733#2208633 (10Krenair) [22:34:07] 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver: Shinken is warning about cxserver on deployment-cxserver03 returning 404s - https://phabricator.wikimedia.org/T132733#2208646 (10Krenair) [22:34:35] 10Beta-Cluster-Infrastructure, 10ContentTranslation-cxserver: Shinken is warning about cxserver on deployment-cxserver03 returning 404s - https://phabricator.wikimedia.org/T132733#2208633 (10Krenair) [22:59:13] 06Release-Engineering-Team, 05Release: MW-1.27.0-wmf.20 deployment blockers - https://phabricator.wikimedia.org/T130945#2208682 (10demon) 05Open>03Resolved [22:59:24] 06Release-Engineering-Team, 05Release: MW-1.27.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T131555#2208683 (10demon) 05Open>03Resolved [23:18:20] robla: I agree that it makes sense for code reviews to live in git [23:19:11] robla: https://github.com/google/git-appraise is one take on that concept, taking it to a minimalistic cli extreme [23:22:56] oooh, interesting link, thanks! [23:24:29] twentyafterfour: any idea if there's any connection between that and Gerrit? given the Google connection, I have to ask [23:24:59] Not as far as I know [23:25:35] And I agree that final code review approvals should be written to git but I disagree with storing the whole review discourse there [23:25:57] ostriches: why not store it all there? [23:26:04] Gerrit does the former with refs/notes/ and thankfully doesn't do the latter. [23:26:13] RECOVERY - Host integration-trusty-1026 is UP: PING OK - Packet loss = 0%, RTA = 0.67 ms [23:26:20] It won't diff well and it grows at a rate faster than your codebase. [23:27:30] well, ok, that aspect is reasonable, but it sure seems like there should be *some* standardized (in Git) way of cloning the review discourse [23:28:06] living solely in the database (for a "distributed" VC) is wrong [23:29:55] PROBLEM - Host integration-trusty-1026 is DOWN: CRITICAL - Host Unreachable (10.68.17.98) [23:30:08] At some point you have to have a centralized source or discussion will fragment :) [23:30:27] But I don't disagree there could be better cli tools so you don't have to leave the `git` workflow. [23:30:56] And "offline" could be a part of that, sure. [23:31:32] github seems to handle this by its pull request model, which basically puts it all in Git, no? [23:33:04] Does it? The diff is fetchable via git, but are the reviews too? [23:33:49] a "+2" is a pull request that gets completed by the upstream [23:34:17] the github model involves cheap forking and pull requests [23:35:41] Right right, but if we're talking about storing the review history in git, I don't see where GH solves that. [23:37:20] successfully merged code gets the review history of the pulled branch, doesn't it? [23:37:58] The commit history, but not the reviews. Where were those stored? [23:38:15] what's an example of an unstored review on Github? [23:40:48] Pulled at random from our github with PRs: https://github.com/wikimedia/restbase/pull/594 [23:40:56] Merged, but where were the reviews stored other than on Github? [23:42:01] yeah, I started looking through stuff there myself once I said that. interesting problem to mull [23:42:07] we could mirror them via the api, if we wanted [23:42:24] pretty sure there are backup tools already [23:42:41] It's not a matter of keeping GH and Phab in sync. It's a question of "where is the correct place to store review metadata" :) [23:43:28] that's a different topic [23:43:40] it's no longer about "we might lose the data" at that point [23:44:10] well...specifically, the metadata that Github stores centrally is the comments associated with a pull request. the patchset modifications are kept [23:44:48] first hit: https://github.com/joeyh/github-backup [23:44:50] Yeah each of the iterative patches are kept. But interestingly, they're not in gerrit. [23:46:10] GH PRs treat it as a branch to pull, vs Gerrit thinks of things as a patch you iterate on until its "perfect." So you end up with a (fairly) linear commit history. [23:46:38] in GH, you can squash if you like [23:47:16] https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit [23:47:22] Ah, #til [23:47:36] err, https://github.com/blog/2141-squash-your-commits [23:47:54] ostriches: isn't the iterative patch stuff what is in refs/changes in Gerrit? [23:49:37] Each of the patchsets is a ref there yes. [23:49:50] But none of the review is attached [23:50:32] * robla starts looking for what github's equivalent of a +1/-1 is [23:50:48] :+1 [23:52:26] hmm, yeah, I guess that's all considered part of the conversation [23:52:58] And really, gerrit's is too. The only place it's recorded is on the final commit into refs/notes/review [23:53:20] There you have your final set of +1/2's, but only from the final approved version. [23:54:01] refs/notes/ is cool, but fairly obscure actually. Fresh clones won't fetch them by default so they don't show up for people automagically. [23:54:03] in GH, the merge commit is clearly recorded [23:54:28] which is the +2 [23:54:37] With Gerrit, since it's one commit it'll be 1 of 2 things. Either a FF where the commit just lands as-is, or you'll see an explicit merge. [23:54:38] but +1 is part of the PR [23:54:43] I suppose you could set it to merge always. [23:54:51] btw, have you looked at https://about.gitlab.com/gitlab-ci/ ? [23:55:24] Not gitlab-ci. I was poking gitlab the other day. How much they cripple the community edition is :( [23:55:31] at first sight, their docker support looks pretty nice, even better than travis [23:56:28] http://doc.gitlab.com/ee/ci/yaml/README.html#gitlab-ci-yml [23:58:39] gwicke: I know your biggest concern with Differential is the CI support. what is it about Gitlab's CI support (and Docker support) that looks pretty nice [23:58:42] ?