[01:31:04] 06Release-Engineering-Team, 10MediaWiki-extensions-General-or-Unknown, 13Patch-For-Review, 05Release: Notice: Unable to unserialize: [-1]. Expected ':' but got '1'. in /srv/mediawiki/php-1.28.0-wmf.1/includes/objectcache/RedisBagOStuff.php on line 313 - https://phabricator.wikimedia.org/T134923#2287933 (10C... [02:32:50] RECOVERY - Puppet run on deployment-mediawiki02 is OK: OK: Less than 1.00% above the threshold [0.0] [02:41:49] Project selenium-CirrusSearch » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #19: 04FAILURE in 49 sec: https://integration.wikimedia.org/ci/job/selenium-CirrusSearch/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/19/ [03:52:13] 06Release-Engineering-Team, 10MediaWiki-extensions-General-or-Unknown, 13Patch-For-Review, 05Release: Notice: Unable to unserialize: [-1]. Expected ':' but got '1'. in /srv/mediawiki/php-1.28.0-wmf.1/includes/objectcache/RedisBagOStuff.php on line 313 - https://phabricator.wikimedia.org/T134923#2288165 (10C... [04:17:48] Project selenium-MultimediaViewer » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #9: 04FAILURE in 21 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/9/ [05:42:10] 06Release-Engineering-Team, 05Release: 1.28.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T134249#2288232 (10Catrope) [05:42:12] 06Release-Engineering-Team, 10MediaWiki-extensions-General-or-Unknown, 05MW-1.28-release-notes, 13Patch-For-Review, and 4 others: Notice: Unable to unserialize: [-1]. Expected ':' but got '1'. in /srv/mediawiki/php-1.28.0-wmf.1/includes/objectcache/RedisBag... - https://phabricator.wikimedia.org/T134923#2288229 [07:03:36] Yippee, build fixed! [07:03:37] Project selenium-CirrusSearch » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #20: 09FIXED in 42 sec: https://integration.wikimedia.org/ci/job/selenium-CirrusSearch/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/20/ [08:55:36] (03PS1) 10Hashar: dib: enable php5-xhprof [integration/config] - 10https://gerrit.wikimedia.org/r/288357 [08:56:30] (03CR) 10Hashar: [C: 032] dib: enable php5-xhprof [integration/config] - 10https://gerrit.wikimedia.org/r/288357 (owner: 10Hashar) [08:57:28] (03Merged) 10jenkins-bot: dib: enable php5-xhprof [integration/config] - 10https://gerrit.wikimedia.org/r/288357 (owner: 10Hashar) [09:00:07] gggg [09:00:09] for god sake [09:13:31] (03PS1) 10Hashar: dib: manually enable php5-xhprof [integration/config] - 10https://gerrit.wikimedia.org/r/288358 [09:13:43] (03CR) 10Hashar: [C: 032] dib: manually enable php5-xhprof [integration/config] - 10https://gerrit.wikimedia.org/r/288358 (owner: 10Hashar) [09:14:34] (03Merged) 10jenkins-bot: dib: manually enable php5-xhprof [integration/config] - 10https://gerrit.wikimedia.org/r/288358 (owner: 10Hashar) [09:37:47] 10Continuous-Integration-Config, 05Continuous-Integration-Scaling, 10releng-201516-q3, 03releng-201516-q4, and 2 others: Migrate PHPUnit MediaWiki core jobs to Nodepool - https://phabricator.wikimedia.org/T135001#2288477 (10hashar) xhprof module is enabled via https://gerrit.wikimedia.org/r/#/c/288357/ and... [10:36:01] PROBLEM - Puppet run on deployment-salt is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [10:59:44] 10MediaWiki-Codesniffer: Require spaces in short array syntax - https://phabricator.wikimedia.org/T134982#2288622 (10gabriel-wmde) 05Open>03Invalid I updated to 0.7.1 before testing, but it seems to be an issue with my updated version or some global/local thing. When I separately installed 0.7.1. and explici... [12:13:06] 10Continuous-Integration-Config, 05Continuous-Integration-Scaling, 10releng-201516-q3, 03releng-201516-q4, and 2 others: Migrate PHPUnit MediaWiki core jobs to Nodepool - https://phabricator.wikimedia.org/T135001#2288855 (10hashar) | [[ https://integration.wikimedia.org/ci/job/mediawiki-parsertests-hhvm-je... [12:15:39] (03PS5) 10Hashar: (WIP) Mediawiki PHPUnit to Nodepool (WIP) [integration/config] - 10https://gerrit.wikimedia.org/r/286497 (https://phabricator.wikimedia.org/T135001) [12:25:41] (03CR) 10Dereckson: Generate extension-list when making a new branch (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/287565 (https://phabricator.wikimedia.org/T125678) (owner: 1020after4) [13:33:38] PROBLEM - Puppet run on deployment-tmh01 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [13:37:09] (03PS6) 10Hashar: Mediawiki core PHPUnit jobs to Nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/286497 (https://phabricator.wikimedia.org/T135001) [13:45:36] (03PS7) 10Hashar: Mediawiki core/vendor PHPUnit jobs to Nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/286497 (https://phabricator.wikimedia.org/T135001) [13:55:27] (03PS8) 10Hashar: Mediawiki core/vendor PHPUnit jobs to Nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/286497 (https://phabricator.wikimedia.org/T135001) [14:10:48] 07Browser-Tests, 10Wikidata, 07Tracking: [tracking] make Wikidata browsertests non-flaky - https://phabricator.wikimedia.org/T92619#2289174 (10thiemowmde) [14:49:41] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 07Jenkins, 07WorkType-Maintenance: Upgrade Jenkins from 1.642.3 to 1.651.2 - https://phabricator.wikimedia.org/T133737#2289280 (10hashar) [14:53:09] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 07Jenkins, 07WorkType-Maintenance: Upgrade Jenkins from 1.642.3 to 1.651.2 - https://phabricator.wikimedia.org/T133737#2289285 (10hashar) 1.651.1 should be fine. The security release 1.651.2 have jobs to use a whitelisted set of paramete... [14:54:56] hashar: My patch got +1-ed here :) https://review.openstack.org/#/c/313196/ [14:55:12] not sure what happens after [14:55:57] (03CR) 10Hashar: [C: 032] "Tested against mediawiki/core and mediawiki/vendor for branches master, REL1_27 and wmf/1.28.0-wmf.1" [integration/config] - 10https://gerrit.wikimedia.org/r/286497 (https://phabricator.wikimedia.org/T135001) (owner: 10Hashar) [14:57:17] (03CR) 10jenkins-bot: [V: 04-1] Mediawiki core/vendor PHPUnit jobs to Nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/286497 (https://phabricator.wikimedia.org/T135001) (owner: 10Hashar) [14:59:47] (03PS9) 10Hashar: Mediawiki core/vendor PHPUnit jobs to Nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/286497 (https://phabricator.wikimedia.org/T135001) [14:59:50] 10Continuous-Integration-Config, 06Analytics-Kanban: Add a maven-release user to Gerrit {hawk} - https://phabricator.wikimedia.org/T132176#2289305 (10madhuvishy) [15:01:24] (03CR) 10Hashar: [C: 032] Mediawiki core/vendor PHPUnit jobs to Nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/286497 (https://phabricator.wikimedia.org/T135001) (owner: 10Hashar) [15:02:56] (03Merged) 10jenkins-bot: Mediawiki core/vendor PHPUnit jobs to Nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/286497 (https://phabricator.wikimedia.org/T135001) (owner: 10Hashar) [15:10:29] 10Continuous-Integration-Config, 05Continuous-Integration-Scaling, 10releng-201516-q3, 03releng-201516-q4, and 2 others: Migrate PHPUnit MediaWiki core jobs to Nodepool - https://phabricator.wikimedia.org/T135001#2289337 (10hashar) Bunch of changes got enqueued and they seem to pass just fine \O/ Next are... [15:40:36] Project selenium-MobileFrontend » chrome,beta,Linux,contintLabsSlave && UbuntuTrusty build #11: 04FAILURE in 18 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/11/ [16:12:20] 10Continuous-Integration-Config, 06Analytics-Kanban: Add a maven-release user to Gerrit {hawk} - https://phabricator.wikimedia.org/T132176#2289575 (10madhuvishy) maven-release-user (maven-release-user@wikimedia.org) has been created, credentials are available on jenkins, and the right gerrit permissions have b... [16:25:16] 03Scap3, 10scap, 13Patch-For-Review: scap::target shouldn't allow users to redefine the user's key - https://phabricator.wikimedia.org/T132747#2289617 (10mobrovac) Ping? I reported this problem over a month ago and it still hasn't been solved. As a direct consequence of this and the fact that https://gerrit.... [16:25:44] brion: Hi with https://secure.phabricator.com/D11513 we can manually add it to phabricator wikimedia as we have made some customisations of our own. [16:26:27] As a workaround you can go to phabricator.wikimedia.org/file/upload [16:26:43] Which has the upload button which would allow tablets and mobiles to upload. [16:42:49] Yippee, build fixed! [16:42:49] Project selenium-Echo » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #21: 09FIXED in 59 sec: https://integration.wikimedia.org/ci/job/selenium-Echo/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/21/ [16:46:25] 10Beta-Cluster-Infrastructure, 10Flow, 03Collab-Team-2016-Apr-Jun-Q4, 13Patch-For-Review: Set up Flow-specific External Store cluster on Beta (secondary to the main one) - https://phabricator.wikimedia.org/T128417#2289738 (10Mattflaschen) There was a minor problem with that patch, so I had to do {1317ae266... [16:53:53] Does anyone here happen to know why there are separate 'Ops' and 'operations' tabs in jenkins? [16:58:12] 03Scap3, 10scap, 13Patch-For-Review: scap::target shouldn't allow users to redefine the user's key - https://phabricator.wikimedia.org/T132747#2289809 (10thcipriani) >>! In T132747#2289617, @mobrovac wrote: > Ping? I reported this problem over a month ago and it still hasn't been solved. As a direct conseque... [17:00:25] Amir1: is it possible to move ORES to another server in Beta? Context: https://phabricator.wikimedia.org/T132747#2289809 [17:08:12] new to me mysql failures testing a REL1_25 patch -- https://integration.wikimedia.org/ci/job/mediawiki-phpunit-parsertests-php53/477/console [17:08:21] " ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)" [17:11:41] bd808: I noticed that on a different jenkins job runner this morning. Looks like mysql was stopped on integration-slave-precise-1012. I just started it. try a recheck/resubmit? [17:12:39] thcipriani: thanks. will do [17:22:40] 10Browser-Tests-Infrastructure: Links broken in UploadWizard-api-commons.wikimedia.beta.wmflabs.org job error report - https://phabricator.wikimedia.org/T66119#2289908 (10matmarex) [17:38:53] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Config, 07WorkType-Maintenance: Fix up the UploadWizard-api for beta cluster - https://phabricator.wikimedia.org/T134730#2290017 (10matmarex) [17:43:17] 10Beta-Cluster-Infrastructure, 10Flow, 03Collab-Team-2016-Apr-Jun-Q4: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2290062 (10Mattflaschen) @jcrespo said he would like to: 1. Take a backup. 2. Add more (non-Flow) pages to Beta Cluster (these will go... [18:01:47] (03CR) 1020after4: Generate extension-list when making a new branch (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/287565 (https://phabricator.wikimedia.org/T125678) (owner: 1020after4) [18:09:01] (03PS3) 1020after4: generate extension-list when making a new branch [tools/release] - 10https://gerrit.wikimedia.org/r/287565 [18:25:48] 10Beta-Cluster-Infrastructure, 10Flow, 03Collab-Team-2016-Apr-Jun-Q4: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2290252 (10greg) I'm working half-time right now (parental leave), so IRC is really laggy on my end :) What should I know about the scri... [18:39:20] (03PS1) 10BryanDavis: Add lint and checkstyle to automated tests [tools/release] - 10https://gerrit.wikimedia.org/r/288447 [18:48:13] 03Scap3, 10scap, 13Patch-For-Review: scap::target shouldn't allow users to redefine the user's key - https://phabricator.wikimedia.org/T132747#2290308 (10mmodell) I thought that userkeys should be working since I cherry picked rOPUP1b9c846dc69fecb113b6c91a4a9573d6e98636e8 on beta. Is that incorrect? Either... [18:49:47] (03CR) 10Legoktm: [C: 04-1] "\o/" (033 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/288447 (owner: 10BryanDavis) [18:53:18] (03CR) 10BryanDavis: [C: 04-1] generate extension-list when making a new branch (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/287565 (owner: 1020after4) [18:54:22] (03PS2) 10BryanDavis: Add lint and checkstyle to automated tests [tools/release] - 10https://gerrit.wikimedia.org/r/288447 [18:54:36] (03CR) 10Hashar: "Nit pick: mediawiki/mediawiki-codesniffer 0.6.0 -> 0.7.1 which is slightly faster and still pass." (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/288447 (owner: 10BryanDavis) [18:55:02] (03CR) 10BryanDavis: Add lint and checkstyle to automated tests (033 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/288447 (owner: 10BryanDavis) [18:55:51] (03PS3) 10BryanDavis: Add lint and checkstyle to automated tests [tools/release] - 10https://gerrit.wikimedia.org/r/288447 [18:56:03] (03CR) 10BryanDavis: Add lint and checkstyle to automated tests (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/288447 (owner: 10BryanDavis) [18:57:40] (03CR) 10Hashar: [C: 031] "Thanks for this styling patch!!!!!!!!!!" [tools/release] - 10https://gerrit.wikimedia.org/r/288447 (owner: 10BryanDavis) [19:03:46] (03CR) 10Legoktm: [C: 032] Add lint and checkstyle to automated tests [tools/release] - 10https://gerrit.wikimedia.org/r/288447 (owner: 10BryanDavis) [19:14:22] (03CR) 1020after4: "@bd808: any reason we can't just fix the weird extensions?" [tools/release] - 10https://gerrit.wikimedia.org/r/287565 (owner: 1020after4) [19:20:46] (03Merged) 10jenkins-bot: Add lint and checkstyle to automated tests [tools/release] - 10https://gerrit.wikimedia.org/r/288447 (owner: 10BryanDavis) [19:33:21] (03CR) 1020after4: "it seems to me that this should always use extension.json" [tools/release] - 10https://gerrit.wikimedia.org/r/287565 (owner: 1020after4) [19:34:08] twentyafterfour: converting everything to extension.json is the goal, yes. [19:34:19] it's not trivial for all extensions however [19:35:20] It shouldn't be too hard to fix the ones that use non-standard php entry points though [19:36:01] trivially it should be possible to just add a properly named file that requires the old entry point name [19:36:40] DonationInterface might be an exception to that. I haven't actually looked at the code [19:38:16] 10Beta-Cluster-Infrastructure, 10Flow, 03Collab-Team-2016-Apr-Jun-Q4: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2290447 (10Mattflaschen) >>! In T119567#2290252, @greg wrote: > I'm working half-time right now (parental leave), so IRC is really laggy... [19:40:46] bd808: for the ones that do have an extension.json, is there any reason not to use it? [19:40:59] because most of them have it but some are still listed with the php entry point in extension-list [19:41:17] that's a good question. legoktm might be able to answer it [19:41:39] Do it. The only reason I never pushed on converting it is because to test that it actually worked fine required doing a full scap and that takes a looong time -.- [19:42:49] so extension-list seems to be only used by the l10n stuff? How does mediawiki decide which extensions to load at runtime? [19:44:49] twentyafterfour: include() statements in CommonSettings [19:45:32] they are guarded with $wmg* vars that tell if the extension is enabled on that particular wiki or not [19:46:11] or some are just globally enabled there [19:59:18] ....wow [19:59:53] Code review office hours is starting now in #wikimedia-codereview [20:03:02] (03CR) 10Jdlrobson: "I'm having a cleanup of Gerrit and this patch is still open. Any value in keeping this 1 year old WIP around James F?" [integration/docroot] - 10https://gerrit.wikimedia.org/r/131324 (owner: 10Jforrester) [20:03:06] (03CR) 10Jdlrobson: "I'm having a cleanup of Gerrit and this patch is still open. Any value in keeping this 1 year old WIP around James F?" [integration/docroot] - 10https://gerrit.wikimedia.org/r/131323 (owner: 10Jforrester) [20:03:35] (03CR) 10Jforrester: "Yes. Still waiting on RelEng to be able to do this." [integration/docroot] - 10https://gerrit.wikimedia.org/r/131324 (owner: 10Jforrester) [20:03:42] (03CR) 10Jforrester: "Yes. Still waiting on RelEng to be able to do this." [integration/docroot] - 10https://gerrit.wikimedia.org/r/131323 (owner: 10Jforrester) [20:20:09] 10Continuous-Integration-Infrastructure, 05Gerrit-Migration, 06Release-Engineering-Team, 10Differential, and 3 others: Investigate migrating the Wikipedia Android App to Differential - https://phabricator.wikimedia.org/T134505#2290607 (10greg) [20:47:52] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 07Jenkins, 07WorkType-Maintenance: Upgrade Jenkins from 1.642.3 to 1.651.2 - https://phabricator.wikimedia.org/T133737#2290669 (10hashar) TL;DR: the Gearman plugin properly put the slave offline on Jenkins 1.651.2 even if OFFLINE_NODE_WHE... [20:50:23] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 07Jenkins, 07WorkType-Maintenance: Upgrade Jenkins from 1.642.3 to 1.651.2 - https://phabricator.wikimedia.org/T133737#2290677 (10hashar) Zuul pass a bunch of parameters and we would need them to be either added to all jobs or whitelisted... [21:08:13] (03PS1) 10Florianschmidtwelzow: Add MGChecker to test pipeline (Verified+2) group [integration/config] - 10https://gerrit.wikimedia.org/r/288514 [21:09:55] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 07Jenkins, 07WorkType-Maintenance: Upgrade Jenkins from 1.642.3 to 1.651.2 - https://phabricator.wikimedia.org/T133737#2290799 (10hashar) I have poked OpenStack infrastructure team (maintainers of Zuul/Nodepool/Gearman plugin) on http://l... [21:10:41] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 07Jenkins, 07WorkType-Maintenance: Upgrade Jenkins from 1.642.3 to 1.651.2 - https://phabricator.wikimedia.org/T133737#2290800 (10hashar) p:05Triage>03High [21:10:45] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 07Jenkins, 07WorkType-Maintenance: Upgrade Jenkins from 1.642.3 to 1.651.2 - https://phabricator.wikimedia.org/T133737#2241069 (10hashar) a:03hashar [21:11:52] (03CR) 10Luke081515: [C: 04-1] "formal stuff..." (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/288514 (owner: 10Florianschmidtwelzow) [21:21:45] 10Beta-Cluster-Infrastructure, 10Flow, 03Collab-Team-2016-Apr-Jun-Q4: Run Flow External Store migration in dry-run mode on Beta - https://phabricator.wikimedia.org/T119567#2290847 (10greg) go ahead from me [21:39:43] based on the graphs at https://integration.wikimedia.org/zuul/ I think that code-review office hours was a major success. [21:42:20] \o/ [21:51:48] 06Release-Engineering-Team, 10MediaWiki-extensions-General-or-Unknown, 05MW-1.28-release-notes, 13Patch-For-Review, and 4 others: Notice: Unable to unserialize: [-1]. Expected ':' but got '1'. in /srv/mediawiki/php-1.28.0-wmf.1/includes/objectcache/RedisBag... - https://phabricator.wikimedia.org/T134923#2290920 [21:58:36] RoanKattouw: other way around? https://phabricator.wikimedia.org/T134923#2290920 [21:59:22] Damn you Phabricator [21:59:22] Yes [21:59:24] Will fix [22:00:02] I'm very happy we can change columns from the task now [22:00:18] 06Release-Engineering-Team, 10MediaWiki-extensions-General-or-Unknown, 05MW-1.28-release-notes, 13Patch-For-Review, and 4 others: Notice: Unable to unserialize: [-1]. Expected ':' but got '1'. in /srv/mediawiki/php-1.28.0-wmf.1/includes/objectcache/RedisBag... - https://phabricator.wikimedia.org/T134923#2290932 [22:00:20] 06Release-Engineering-Team, 05Release: 1.28.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T134249#2290933 (10Catrope) [22:00:24] My only remaining "why can't I do action X from place Y" things are duplicates and blocks/blocked by [22:00:24] 06Release-Engineering-Team, 10MediaWiki-extensions-General-or-Unknown, 05MW-1.28-release-notes, 13Patch-For-Review, and 4 others: Notice: Unable to unserialize: [-1]. Expected ':' but got '1'. in /srv/mediawiki/php-1.28.0-wmf.1/includes/objectcache/RedisBag... - https://phabricator.wikimedia.org/T134923#2282493 [22:00:50] RoanKattouw: Now close this task again? :D [22:01:16] * Luke081515 can deal with merge, but often mixes up blocked by and blocks [22:01:36] Oh right, it should be closed [22:01:41] Because I fixed it [22:01:44] Yesterday [22:02:02] 06Release-Engineering-Team, 05Release: 1.28.0-wmf.1 deployment blockers - https://phabricator.wikimedia.org/T134249#2290949 (10Catrope) [22:02:04] 06Release-Engineering-Team, 10MediaWiki-extensions-General-or-Unknown, 05MW-1.28-release-notes, 13Patch-For-Review, and 4 others: Notice: Unable to unserialize: [-1]. Expected ':' but got '1'. in /srv/mediawiki/php-1.28.0-wmf.1/includes/objectcache/RedisBag... - https://phabricator.wikimedia.org/T134923#2290948 [22:02:25] :) [22:02:44] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/288522/ [22:02:54] that's now a dub too? :D [22:03:18] matt_flaschen: Guess you got kind of a "working conflict" with RoanKattouw [22:03:34] he already fixed the task you're working on [22:11:50] Luke081515: His patch is just a test case :) [22:12:05] oh, my fault^^ [22:12:05] Which I should have written but didn't because I wanted to fix the site and it was late [22:12:14] I didn't look at the code :D [22:12:21] (Matt did write a fix for the bug too, then removed that again before submitting) [22:16:30] 05Gerrit-Migration, 03releng-201516-q4, 10Differential: Cross-repository gating of changes pre-merge in Differential - https://phabricator.wikimedia.org/T131955#2291007 (10greg) [22:17:10] matt_flaschen: Hi could you review https://gerrit.wikimedia.org/r/#/c/288526/ please. [22:17:33] Not sure why we need to use a symbolic file, would be broken on windows without this patch. [22:19:11] matt_flaschen: Also would you be able to review https://gerrit.wikimedia.org/r/#/c/279957/ please ive fixed some issues that caused it to not work. Ive tested it and it all works now. :) [22:19:20] paladox, I think it's used with both names. [22:19:35] matt_flaschen: nope [22:19:49] Looking in Resources.php it is not listed with both only the symbolic one [22:21:01] paladox, we use Handlebars on the server too. [22:21:22] paladox, plus you deleted the one that *is* listed in Resources.php! [22:21:43] matt_flaschen: It is safe we can list both [22:21:52] Even though it would be duplicated. [22:22:01] paladox, sorry, I see you renamed that in Resources.php. [22:22:23] matt_flaschen: Yep, i just deleted the symbolic file we doint need anymore. [22:22:57] matt_flaschen: I can keep them both and list in Resources.php since it would be duplicated module but it works i think or i think it is safe. [22:27:03] ^^ if your unsure we should just list both in Resources.php. [22:27:29] matt_flaschen ^^ [22:31:36] paladox, I'm not just going to commit or merge code if I'm unsure, and neither should you. I was checking to see if your code works. [22:32:04] matt_flaschen: Oh. [22:32:07] paladox, which it does not, at all. [22:32:28] 05Gerrit-Migration, 10Differential: Use the arcanist installer for windows i created - https://phabricator.wikimedia.org/T131939#2291067 (10greg) So, I'm trying to figure out the next steps for this task and one of the questions that we need to answer is "What is this task actually asking to be done?" Options... [22:32:32] paladox, you clearly did not recompile the templates. If you're in a dev environment, $wgFlowServerCompileTemplates should be true, and you should recompile all templates before commiting. [22:32:33] 05Gerrit-Migration, 10Differential: Consider documenting the Arcanist installer for Windows that Paladox created - https://phabricator.wikimedia.org/T131939#2291068 (10greg) [22:33:02] paladox, more to the point, if you don't understand how something works (for example Handlebars templates) you should *ask*, instead of just committing. [22:33:03] matt_flaschen: Oh sorry i didn't know that you had to do that. [22:33:33] paladox: make compile-lightncandy [22:33:42] matt_flaschen: Thanks. [22:51:08] matt_flaschen: make is not working for me. Keeps Exception encountered, of type "Error"make: *** [compile-lightncandy] Error 1 [22:51:18] Im using ubuntu bash on windows. [22:51:55] paladox, post the full error at https://phabricator.wikimedia.org/paste/create/ . [22:52:13] matt_flaschen: That is the full error [22:52:25] Do you know how i can get additional information from it [22:52:26] please [22:53:37] paladox, I'm not going to spend a lot of time helping you with Ubuntu Bash, but if you just run: [22:53:39] make --version [22:53:43] !log Started dead mysql on integration-slave-precise-1011 [22:53:45] make compile-lightncandy [22:53:47] 05Gerrit-Migration, 10Differential: Consider documenting the Arcanist installer for Windows that Paladox created - https://phabricator.wikimedia.org/T131939#2291183 (10Paladox) >>! In T131939#2291067, @greg wrote: > So, I'm trying to figure out the next steps for this task and one of the questions that we need... [22:53:50] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [22:53:52] Ok [22:53:53] and post the full output (including the commands you ran) [22:53:54] thanks [22:53:55] I will take a look. [22:54:33] 06Release-Engineering-Team, 15User-greg: Make a table of access levels per service RelEng maintains per person - https://phabricator.wikimedia.org/T135187#2291186 (10greg) [22:55:32] matt_flaschen: https://phabricator.wikimedia.org/P3064 [22:56:46] 05Gerrit-Migration, 10Differential: Consider documenting the Arcanist installer for Windows that Paladox created - https://phabricator.wikimedia.org/T131939#2291218 (10Paladox) [22:57:52] paladox, OK, well, you're at least running GNU Make. I have 4.0 and you have 3.81, but not sure if that makes any difference. [22:57:56] paladox, what happens if you run: [22:57:58] php --version [22:58:07] Maybe PHP isn't in your path. [22:58:54] matt_flaschen: https://phabricator.wikimedia.org/P3065 [22:59:40] Running the script by doing php maintenance/compileLightncandy.php [22:59:41] results in Exception encountered, of type "Error" [23:00:46] paladox, OK, I don't know what it is. Vagrant is on 5.5.9-1ubuntu4.14. [23:00:54] Oh [23:01:41] matt_flaschen: It was because i didn't add flow to localsettings.php [23:03:53] 05Gerrit-Migration, 10Differential: Consider documenting the Arcanist installer for Windows that Paladox created - https://phabricator.wikimedia.org/T131939#2291272 (10greg) I want to be very clear about what "recommend" could mean in this context. A recommendation on the Differential wiki page would seem to i... [23:04:12] 03releng-201516-q4, 10Malu (Malu-Prototype), 07Surveys: Send out browser testing user satisfaction survey - https://phabricator.wikimedia.org/T131123#2291274 (10greg) a:03zeljkofilipin [23:04:43] 05Gerrit-Migration, 10Differential: Consider documenting the Arcanist installer for Windows that Paladox created - https://phabricator.wikimedia.org/T131939#2291278 (10Paladox) >>! In T131939#2291272, @greg wrote: > I want to be very clear about what "recommend" could mean in this context. A recommendation on... [23:16:56] 10Beta-Cluster-Infrastructure, 13Patch-For-Review: Output of wmf-beta-update-databases.py is not clear on errors - https://phabricator.wikimedia.org/T110407#2291336 (10Mattflaschen) 05Open>03Resolved [23:18:29] matt_flaschen: Ive renegerated it now at https://gerrit.wikimedia.org/r/#/c/288526/ [23:18:43] using make compile-lightncandy [23:21:27] 05Gerrit-Migration, 10Differential: Consider documenting the Arcanist installer for Windows that Paladox created - https://phabricator.wikimedia.org/T131939#2291374 (10Paladox) @greg @Luke081515 has been using the installer and found some bugs that I fixed in it that upstream refusing to think are bugs in arc... [23:25:06] paladox, I don't see how compile-lightncandy would cause that. It looks like you renamed it manually. [23:25:46] matt_flaschen: Oh, yep i updated the script but i removed that edit now. So running that should result in the compiled file being deleted. [23:26:10] Hi. [23:26:18] dereckson@mw1017:~$ sync-common [23:26:22] usage: sync-common [-h] ... [23:26:24] sync-common: error: too few arguments [23:26:46] PROBLEM - Puppet run on deployment-db2 is CRITICAL: CRITICAL: 25.00% of data above the critical threshold [0.0] [23:27:17] What's the new scap equivalent for sync-common ? [23:27:43] RoanKattouw: ^ [23:27:48] Dereckson: are you pushing or pulling? [23:28:00] Pulling I think [23:28:04] Putting something on mw1017 for testing [23:28:11] matt_flaschen: Ive updated https://gerrit.wikimedia.org/r/#/c/288526/ again running same script but wthout changes to script. [23:28:12] * RoanKattouw doesn't know anything about the new scap stuff [23:28:48] Dereckson: it should be `scap pull` [23:28:52] bd808: I've a proper staging on tin, and I would like to push from tin to mw1017 or pull on mw1017 from tin [23:29:06] scap pull on mw1017 [23:29:10] Speaking of which, it would be nice to update https://wikitech.wikimedia.org/wiki/How_to_deploy_code once the new scap settles down. [23:29:20] thanks bd808 [23:29:59] matt_flaschen: and https://wikitech.wikimedia.org/wiki/X-Wikimedia-Debug#Staging_changes [23:31:42] paladox, yeah, except now none of the posts show. [23:32:32] matt_flaschen: Oh, um not sure then, then it is broken since symbolic links do not work on windows. And on linux it shows. [23:32:53] Im wondering can you require other handlebars within a handlebar like php [23:33:24] Or can we just have two duplicate files under different names [23:33:35] matt_flaschen, Dereckson: I've documented your documentation suggestions on the mailing list thread about the new scap [23:33:42] paladox, the first one should work, actually. [23:33:44] * RoanKattouw would {{sofixit}}} but has to leave soon [23:34:11] That is what Handlebars partials do. [23:34:19] matt_flaschen: Oh [23:34:53] So require __DIR__ . 'flow_post.partial.handlebars'; [23:35:24] paladox, no. [23:35:55] Project beta-scap-eqiad build #102394: 04FAILURE in 1 min 13 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/102394/ [23:36:01] matt_flaschen: {{flow_post.partial.handlebars}} [23:36:12] with ! [23:37:00] Handlebars is not PHP. I'll implement this. If you want, you can go read up on Handlebars. [23:37:09] https://wikitech.wikimedia.org/w/index.php?title=How_to_deploy_code&diff=515359&oldid=513279 [23:37:54] paladox, no. Don't just guess: http://handlebarsjs.com/partials.html [23:38:47] RECOVERY - Puppet run on deployment-tmh01 is OK: OK: Less than 1.00% above the threshold [0.0] [23:39:06] matt_flaschen: Thanks i will read your link now. [23:41:29] PROBLEM - Puppet run on deployment-jobrunner01 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [23:41:33] Project beta-scap-eqiad build #102395: 04STILL FAILING in 1 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/102395/ [23:45:51] 05Gerrit-Migration, 10Differential, 07Documentation, 07Upstream: Document best practices to amend a change written by another contributor - https://phabricator.wikimedia.org/T121751#2291416 (10Dzahn) {meme, src=votecat} [23:46:05] Project beta-scap-eqiad build #102396: 04STILL FAILING in 1 min 19 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/102396/ [23:55:50] Project beta-scap-eqiad build #102397: 04STILL FAILING in 1 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/102397/