[00:01:44] (03PS3) 10Legoktm: SpaceyParenthesisSniff: Don't remove last argument or array element [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/288043 (https://phabricator.wikimedia.org/T134857) (owner: 10PleaseStand) [00:03:02] 10MediaWiki-Codesniffer: Adapt MW-CS test framework to support testing sniffs that support auto-fixing (phpcbf) - https://phabricator.wikimedia.org/T108458#2335818 (10Legoktm) a:03EBernhardson Fixed in {80210fe43e1defc01745871dff9bb1bf3b1c1a9a}. [00:03:17] 10MediaWiki-Codesniffer: Adapt MW-CS test framework to support testing sniffs that support auto-fixing (phpcbf) - https://phabricator.wikimedia.org/T108458#2335821 (10Legoktm) 05Open>03Resolved [00:06:11] (03CR) 10Legoktm: [C: 032] "PS3: Added and updated now-failing tests." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/288043 (https://phabricator.wikimedia.org/T134857) (owner: 10PleaseStand) [00:07:50] (03Merged) 10jenkins-bot: SpaceyParenthesisSniff: Don't remove last argument or array element [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/288043 (https://phabricator.wikimedia.org/T134857) (owner: 10PleaseStand) [00:41:50] legoktm: Worth doing a new release just for SpaceyParenthesisSniff? I'd lean towards yes. [00:42:14] Yes, but first I'm writing a script to identify repos that were potentially broken [01:06:42] 10MediaWiki-Codesniffer, 13Patch-For-Review: phpcbf: MediaWiki_Sniffs_WhiteSpace_SpaceyParenthesisSniff removes array elements - https://phabricator.wikimedia.org/T134857#2335903 (10Legoktm) I wrote a script to identify extensions that would have been affected by the SpaceyParenthesisSniff bug. The only extens... [01:07:01] 10MediaWiki-Codesniffer, 13Patch-For-Review: phpcbf: MediaWiki_Sniffs_WhiteSpace_SpaceyParenthesisSniff removes array elements - https://phabricator.wikimedia.org/T134857#2335904 (10Legoktm) 05Open>03Resolved a:03PleaseStand [01:08:11] Yippee, build fixed! [01:08:12] Project mediawiki-core-code-coverage build #2041: 09FIXED in 3 hr 25 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/2041/ [01:09:10] (03PS1) 10Legoktm: Release 0.7.2 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/291389 [01:11:15] (03CR) 10Legoktm: [C: 032] Release 0.7.2 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/291389 (owner: 10Legoktm) [01:12:19] (03Merged) 10jenkins-bot: Release 0.7.2 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/291389 (owner: 10Legoktm) [02:18:17] Yippee, build fixed! [02:18:18] Project selenium-QuickSurveys » chrome,beta,Linux,contintLabsSlave && UbuntuTrusty build #37: 09FIXED in 5 min 16 sec: https://integration.wikimedia.org/ci/job/selenium-QuickSurveys/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/37/ [02:20:06] Project beta-update-databases-eqiad build #8839: 04FAILURE in 6 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/8839/ [02:25:20] > Database is read-only: The database has been automatically locked while the slave database servers catch up to the master. [02:33:46] 10MediaWiki-Codesniffer, 05Google-Summer-of-Code-2016: Improving an static analysis tools for MediaWiki - Weekly reports - https://phabricator.wikimedia.org/T134225#2335932 (10Lethexie) [03:20:36] Yippee, build fixed! [03:20:37] Project beta-update-databases-eqiad build #8840: 09FIXED in 35 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/8840/ [04:05:27] Yippee, build fixed! [04:05:27] Project selenium-MultimediaViewer » safari,beta,OS X 10.9,contintLabsSlave && UbuntuTrusty build #28: 09FIXED in 9 min 26 sec: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=safari,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=OS%20X%2010.9,label=contintLabsSlave%20&&%20UbuntuTrusty/28/ [04:18:18] Yippee, build fixed! [04:18:19] Project selenium-MultimediaViewer » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #28: 09FIXED in 22 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/28/ [04:43:55] !log depooling integration-slave-trusty-1015 to profile phpunit runs [04:43:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL, Master [05:20:33] Project beta-update-databases-eqiad build #8842: 04FAILURE in 32 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/8842/ [06:20:27] 10MediaWiki-Codesniffer, 05Google-Summer-of-Code-2016: All new methods should document their parameters and return values - https://phabricator.wikimedia.org/T136464#2336015 (10Lethexie) [06:20:36] Yippee, build fixed! [06:20:37] Project beta-update-databases-eqiad build #8843: 09FIXED in 36 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/8843/ [06:30:12] 10MediaWiki-Codesniffer, 05Google-Summer-of-Code-2016: All new methods should document their parameters and return values - https://phabricator.wikimedia.org/T136464#2336033 (10Lethexie) [07:12:03] (03PS1) 10Lethexie: Add function commenting sniff. [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/291489 [08:59:13] 06Release-Engineering-Team, 10Wikimedia-General-or-Unknown: lrcwiki stats are wrong - https://phabricator.wikimedia.org/T109635#2336054 (10Mjbmr) I actually fixed that long time ago, when no one paid attention, by running null edits all over the wiki, thanks anyways for running that command after 10 months whe... [10:32:01] 10Beta-Cluster-Infrastructure, 10Tidy: HTML Tags are stripped from extension output - https://phabricator.wikimedia.org/T68516#2336172 (10Danny_B) [10:50:32] 10Beta-Cluster-Infrastructure, 10Tidy: HTML Tags are stripped from extension output - https://phabricator.wikimedia.org/T68516#2336291 (10Danny_B) [12:12:32] (03CR) 10Paladox: "recheck" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/291489 (owner: 10Lethexie) [12:15:41] (03CR) 10jenkins-bot: [V: 04-1] Add function commenting sniff. [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/291489 (owner: 10Lethexie) [12:27:20] legoktm: Hi [12:32:20] (03PS1) 10Paladox: Migrate mw-tools-codesniffer-mwcore-testrun to trusty nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/291501 [12:32:39] legoktm ^^ :) [12:33:42] (03CR) 10Paladox: "Theres a bit of duplicating which I will clean up if this test passes." [integration/config] - 10https://gerrit.wikimedia.org/r/291501 (owner: 10Paladox) [12:35:23] (03PS2) 10Paladox: Update phabricator/* tests [integration/config] - 10https://gerrit.wikimedia.org/r/291283 [12:35:50] (03CR) 10Paladox: "Needs re c+2 please since it needed a rebase." [integration/config] - 10https://gerrit.wikimedia.org/r/291283 (owner: 10Paladox) [13:25:39] From https://gerrit.wikimedia.org/r/integration/jenkins-job-builder + 816e1c1...cd63874 master -> origin/master (forced update) [13:26:20] *sigh* [13:30:26] jzerebecki: I think that project was deleted ^^ [13:30:58] mutante found a gerrit link and we were wondering why we were blocked from viewing it yesturday and found it was that and that project was deleted. [13:32:17] paladox: no it is still there, the above is a git url not consumable by a browser. For the later see https://gerrit.wikimedia.org/r/#/admin/projects/integration/jenkins-job-builder [13:35:10] jzerebecki: Sorry i got conffused wrong one [13:35:14] its https://phabricator.wikimedia.org/diffusion/CIJC/manage/basics/ [13:36:15] paladox: yes that was merged into integration/config.git [13:36:23] oh ok [13:47:51] (03CR) 10JanZerebecki: "See phabricator ticket for response." [integration/config] - 10https://gerrit.wikimedia.org/r/290822 (https://phabricator.wikimedia.org/T136176) (owner: 10Jdlrobson) [13:48:31] Yippee, build fixed! [13:48:32] Project selenium-VisualEditor » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #34: 09FIXED in 4 min 31 sec: https://integration.wikimedia.org/ci/job/selenium-VisualEditor/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/34/ [13:53:41] jzerebecki: Hi could you review https://gerrit.wikimedia.org/r/#/c/291501/ and https://gerrit.wikimedia.org/r/#/c/288819/ and https://gerrit.wikimedia.org/r/#/c/290791/ please [14:03:37] (03PS1) 10Paladox: Migrate composer-validate to trusty nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/291505 [14:06:11] (03PS2) 10Paladox: Migrate composer-validate to trusty nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/291505 [14:12:37] (03PS1) 10Paladox: Migrate composer-package-validate to trusty nodepool [integration/config] - 10https://gerrit.wikimedia.org/r/291506 [15:42:14] 06Release-Engineering-Team, 05MW-1.23-release: 1.23.14 is really 1.23.13 - https://phabricator.wikimedia.org/T136484#2336704 (10matmarex) Are the contents of the release really wrong, or is the version number wrong? [15:42:42] 06Release-Engineering-Team, 10MediaWiki-General-or-Unknown, 05MW-1.23-release: 1.23.14 is really 1.23.13 - https://phabricator.wikimedia.org/T136484#2336706 (10matmarex) [15:47:09] 06Release-Engineering-Team, 10MediaWiki-General-or-Unknown, 05MW-1.23-release: 1.23.14 is really 1.23.13 - https://phabricator.wikimedia.org/T136484#2336708 (10WayneSallee) I don't know if it is really wrong, but every single file that I saw that stated the version said 13 with no mention of 14. Wayne Salle... [16:08:10] 06Release-Engineering-Team, 10MediaWiki-General-or-Unknown, 05MW-1.23-release: 1.23.14 is really 1.23.13 - https://phabricator.wikimedia.org/T136484#2336722 (10Danny_B) p:05Triage>03High [21:43:00] 03Scap3, 06Revision-Scoring-As-A-Service: Scap3 checks should not be random - https://phabricator.wikimedia.org/T136253#2337078 (10Ladsgroup) @thcipriani: What do you think of [[http://stackoverflow.com/questions/5121931/in-python-how-can-you-load-yaml-mappings-as-ordereddicts/21912744#21912744 | this solution]]? [22:16:35] 06Release-Engineering-Team, 10MediaWiki-General-or-Unknown, 05MW-1.23-release: 1.23.14 is really 1.23.13 - https://phabricator.wikimedia.org/T136484#2336690 (10Legoktm) The version numbers are wrong per [23:08:23] 06Release-Engineering-Team, 10MediaWiki-General-or-Unknown, 05MW-1.23-release: 1.23.14 is really 1.23.13 - https://phabricator.wikimedia.org/T136484#2336690 (10Ciencia_Al_Poder) Looks like it happened also for 1.26 and fixed without releasing a new version: [[ https://www.mediawiki.org/wiki/Topic:T4i9jjg8asq... [23:27:35] 05Gerrit-Migration, 10Diffusion, 10GitHub-Mirrors, 06Repository-Admins: Have Phabricator take over replication to Github - https://phabricator.wikimedia.org/T115624#2337159 (10Paladox) @demon and @mmodell I contacted GitHub and they said yes they do have a limited they didn't say what the limit is only tha... [23:42:11] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 06Operations, 10Ops-Access-Requests: Allow RelEng access to labnet servers (was: Allow RelEng nova log access) - https://phabricator.wikimedia.org/T133992#2337167 (10Paladox) [23:50:12] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team: doc.wikimedia.org should be running PHP 5.5+, not 5.3 -> demos etc. don't work - https://phabricator.wikimedia.org/T127504#2337168 (10Paladox) >>! In T127504#2159391, @Aklapper wrote: > If that was a question (not sure as no question mark at...