[00:00:31] PROBLEM - Puppet run on deployment-cache-upload04 is CRITICAL: CRITICAL: 10.00% of data above the critical threshold [0.0] [00:05:30] RECOVERY - Puppet run on deployment-cache-upload04 is OK: OK: Less than 1.00% above the threshold [0.0] [00:29:17] (03CR) 10Krinkle: "It actually publishes both together in one build. Due to lack of nice interdoc linking for when many classes are involved, so far I've not" [integration/docroot] - 10https://gerrit.wikimedia.org/r/316202 (owner: 10Legoktm) [00:29:36] (03CR) 10Krinkle: [C: 031] doc: Move VisualEditor under MediaWiki extensions [integration/docroot] - 10https://gerrit.wikimedia.org/r/316202 (owner: 10Legoktm) [09:51:34] PROBLEM - Puppet run on deployment-apertium01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [09:55:49] 06Release-Engineering-Team, 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016), 07Documentation: Developer Summit 2017: Work with TPG and RelEng on solution to event documenting - https://phabricator.wikimedia.org/T132400#2817224 (10srishakatux) Sharing a key learning from Aspiration Tech t... [10:04:05] 06Release-Engineering-Team, 03Scap3: scap plugin to export prometheus metrics - https://phabricator.wikimedia.org/T151387#2817242 (10mmodell) a:03mmodell [10:12:19] tests seem to suddenly take more time than usually [10:12:37] https://integration.wikimedia.org/zuul/ [10:12:54] I guess it's just so many being done in parallel [10:22:21] Nikerabbit: yup [10:22:30] Nikerabbit: and we have a limited pool of instances since July 4th [10:22:40] should be bumped next time hopefully [10:23:10] Nikerabbit: https://grafana.wikimedia.org/dashboard/db/nodepool?panelId=1&fullscreen more or less gives an idea of the pool occupation [10:24:30] ok [10:41:29] hashar: https://integration.wikimedia.org/ci/job/mwext-testextension-php55/27582/console last update 15 minutes ago... that does not look correct [10:41:32] Nikerabbit: while you are around, yesterday I created a job for translatewiki.git that runs 'composer test' under HHVM [10:41:32] should do the linting for you [10:41:34] was long overdue [10:41:45] eek [10:42:11] hashar: yeah that's nice [10:42:33] that job is blocked running some Scribunto tests apparently [10:46:19] bunch of /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/Scribunto/engines/LuaStandalone/binaries/lua5_1_5_linux_64_generic/lua /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/Scribunto/engines/LuaStandalone/mw_main.lua /srv/jenkins-workspace/workspace/mwext-testextension-php55/src/extensions/Scribunto 37 [10:47:43] we will need one day to figure out how to stop running those tests [10:47:56] okay [10:48:34] killed it and ran 'recheck' again [10:51:30] okay [10:51:52] for the yesterday's bug... I found out that it is most likely some database table leaking information between tests [10:57:41] 10Beta-Cluster-Infrastructure, 07Puppet: deployment-apertium01 puppet failing due to missing packages on trusty - https://phabricator.wikimedia.org/T147210#2817406 (10hashar) Somehow the instance deployment-apertium01 is back! ``` $ uptime 10:52:58 up 21 days, 15:25, 1 user, load average: 0.00, 0.09, 0.10... [10:57:42] !log Terminating deployment-apertium01 again T147210 [10:57:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:59:54] PROBLEM - Host deployment-apertium01 is DOWN: CRITICAL - Host Unreachable (10.68.16.79) [11:02:06] 10Continuous-Integration-Infrastructure, 06Labs, 10Labs-Infrastructure, 07Beta-Cluster-reproducible, 07Puppet: New instance have broken puppet configuration when using puppetmaster standalone - https://phabricator.wikimedia.org/T148929#2817428 (10hashar) Puppet provisions the Puppet_Internal_CA.crt file... [11:13:24] RECOVERY - Puppet run on integration-slave-docker-1000 is OK: OK: Less than 1.00% above the threshold [0.0] [11:14:31] 10Beta-Cluster-Infrastructure, 07Puppet: deployment-apertium01 puppet failing due to missing packages on trusty - https://phabricator.wikimedia.org/T147210#2817446 (10akosiaris) With 21 days uptime ? I think it's just not deleted. otherwise this does not make sense. [11:21:20] 10Beta-Cluster-Infrastructure, 07Puppet: deployment-apertium01 puppet failing due to missing packages on trusty - https://phabricator.wikimedia.org/T147210#2817448 (10hashar) From https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-apertium01.deployment-prep.eqiad.wmflabs > Sorry, this page was rece... [13:06:16] 06Release-Engineering-Team, 03Scap3: scap plugin to export prometheus metrics - https://phabricator.wikimedia.org/T151387#2815775 (10mobrovac) For services, it would be better to have the commit SHA1 being deployed, since we git-version our deploy repos, so having that instead of the scap tag would make it eas... [13:09:27] 10Continuous-Integration-Config, 10MediaWiki-General-or-Unknown, 06translatewiki.net, 13Patch-For-Review: Banana-checker reports spurious error about supposedly undefined key feedback-error-title - https://phabricator.wikimedia.org/T147245#2817639 (10hashar) 05Open>03Resolved a:03hashar [13:09:41] 10Continuous-Integration-Config, 06Release-Engineering-Team, 13Patch-For-Review: Switch MediaWiki coverage job from Trusty/Zend PHP 5.5 to Jessie/Zend PHP 7.0 - https://phabricator.wikimedia.org/T147778#2817642 (10hashar) p:05Normal>03Low [13:46:48] Project selenium-VisualEditor » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #222: 04FAILURE in 2 min 47 sec: https://integration.wikimedia.org/ci/job/selenium-VisualEditor/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/222/ [13:58:04] 10Continuous-Integration-Config, 07Technical-Debt: Write unit tests for set_parameters() function in zuul config - https://phabricator.wikimedia.org/T126182#2007031 (10hashar) integration/config has a few tests in: `tests/test_zuul_parameters.py` `tests/test_zuul_ext_dependencies.py` [13:58:14] 10Continuous-Integration-Config, 07Technical-Debt: Write unit tests for set_parameters() function in zuul config - https://phabricator.wikimedia.org/T126182#2817736 (10hashar) p:05Triage>03Normal [13:59:53] 10Continuous-Integration-Config, 07TestMe: fix or mark as inactive extensions currently failing CI - https://phabricator.wikimedia.org/T134090#2817756 (10hashar) Repositories that are failing the ApiDocumentationTest should be fixed (not marked non-voting). Rest should be dealt with but I dont have a good id... [14:00:02] 10Continuous-Integration-Config, 07TestMe: fix or mark as inactive extensions currently failing CI - https://phabricator.wikimedia.org/T134090#2817757 (10hashar) p:05Triage>03Low [14:00:14] 10Continuous-Integration-Config, 07WorkType-NewFunctionality: Generate JJB jobs from the Zuul layout/templates definition - https://phabricator.wikimedia.org/T135059#2817758 (10hashar) p:05Triage>03Low [14:07:43] 10Browser-Tests-Infrastructure, 10MobileFrontend, 06Reading-Web-Backlog, 07Browser-Tests, 15User-zeljkofilipin: Add helper to mediawiki_selenium for detecting if ResourceLoader module (JavaScript) has loaded - https://phabricator.wikimedia.org/T132753#2817774 (10zeljkofilipin) [14:07:45] 10Browser-Tests-Infrastructure, 06Reading-Web-Backlog, 07Browser-Tests, 13Patch-For-Review, and 2 others: Add helper to Selenium that allows you to query whether JavaScript module has loaded - https://phabricator.wikimedia.org/T146292#2817776 (10zeljkofilipin) [14:08:41] 10Browser-Tests-Infrastructure, 15User-zeljkofilipin: Ensure chromedriver is installed (for Selenium) - https://phabricator.wikimedia.org/T117418#1773487 (10zeljkofilipin) a:03zeljkofilipin [14:45:47] PROBLEM - Puppet run on deployment-cache-text04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:07:16] PROBLEM - English Wikipedia Mobile Main page on beta-cluster is CRITICAL: HTTP CRITICAL: HTTP/1.1 502 Bad Gateway - string 'Wikipedia' not found on 'https://en.m.wikipedia.beta.wmflabs.org:443/wiki/Main_Page?debug=true' - 325 bytes in 0.025 second response time [15:08:42] that was me, only temporary [15:12:15] RECOVERY - English Wikipedia Mobile Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 17401 bytes in 1.575 second response time [15:20:48] RECOVERY - Puppet run on deployment-cache-text04 is OK: OK: Less than 1.00% above the threshold [0.0] [15:21:50] (03PS1) 10Hashar: Run MediaWiki 'skins' testsuite on all skins [integration/config] - 10https://gerrit.wikimedia.org/r/323161 (https://phabricator.wikimedia.org/T68926) [15:22:18] 10Continuous-Integration-Config, 13Patch-For-Review: Set up phpunit structure tests for MediaWiki skin repositories - https://phabricator.wikimedia.org/T68926#2817975 (10hashar) [15:23:28] hashar your patch is a duplicate of https://gerrit.wikimedia.org/r/#/c/228470/ [15:23:29] 10Continuous-Integration-Config, 10BlueSky, 13Patch-For-Review: Fix structure tests for all skins - https://phabricator.wikimedia.org/T113860#2817992 (10hashar) T68926 will get us a Jenkins job that runs the MediaWiki structure tests. Applies it on every skins we have configured in CI has non voting job. [15:23:30] (03CR) 10jenkins-bot: [V: 04-1] Run MediaWiki 'skins' testsuite on all skins [integration/config] - 10https://gerrit.wikimedia.org/r/323161 (https://phabricator.wikimedia.org/T68926) (owner: 10Hashar) [15:23:50] :) [15:25:13] 10Continuous-Integration-Config, 13Patch-For-Review: Set up phpunit structure tests for MediaWiki skin repositories - https://phabricator.wikimedia.org/T68926#2817996 (10Paladox) @hashar that's a duplicate of https://gerrit.wikimedia.org/r/#/c/228470/ :) [15:25:44] I am happy we have tests [15:26:07] (03CR) 10Paladox: "Why not support php55 and hhvm instead of just hhvm?" [integration/config] - 10https://gerrit.wikimedia.org/r/323161 (https://phabricator.wikimedia.org/T68926) (owner: 10Hashar) [15:26:13] :) [15:27:50] (03CR) 10Paladox: Run MediaWiki 'skins' testsuite on all skins (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/323161 (https://phabricator.wikimedia.org/T68926) (owner: 10Hashar) [15:28:27] (03PS2) 10Hashar: Run MediaWiki 'skins' testsuite on all skins [integration/config] - 10https://gerrit.wikimedia.org/r/323161 (https://phabricator.wikimedia.org/T68926) [15:28:44] paladox: was because some skins still had: check-voter: [ jshint ] [15:28:56] I am adding the new job to the 'test' pipeline [15:29:02] Ok [15:29:04] so check-voter should no more be used [15:29:09] :) [15:29:10] and all repos moved to check + test [15:29:27] yep, should help properly test skins now [15:29:29] gotta review the diff carefully [15:29:32] yeah [15:29:37] catch failures that would otherwise go un notticed [15:29:38] so original bug was https://phabricator.wikimedia.org/T68926 [15:29:43] Ok [15:29:52] and fixing all structure tests is https://phabricator.wikimedia.org/T113860 [15:30:04] :) [15:30:10] I dont know whether skins registers tests via the mediawiki hook UnitTestsList [15:30:16] hashar you could always use gerrit-test for the testing [15:30:43] import a mw repo into gerrit-test.wmflabs.org, then deploy your change on the test zuul. [15:31:10] oh [15:31:14] maybe yeah [15:31:21] well I already ran the job on a few repos [15:31:27] Oh [15:31:27] and it pass half the time :} [15:31:30] :) [15:31:38] guess we can mass trigger it on every skins [15:31:40] well there are not as many skin repos [15:31:45] then switch passing repo to the voting flavor [15:31:52] yeah should be easy [15:31:58] can even run the structure tests locally [15:31:58] so it should be quicker to veryfy that it works :). [15:32:02] oh [15:32:24] ssh -p 29418 hashar@gerrit.wikimedia.org 'gerrit ls-projects -p mediawiki/skins/'|wc -l [15:32:24] 43 [15:32:26] easy! [15:33:29] * hashar digs in the zuul diff https://integration.wikimedia.org/ci/job/integration-zuul-layoutdiff/11361/consoleFull [15:33:34] TIL -p/--prefix [15:33:46] Oh [15:33:52] one could use the rest api with curl [15:33:56] but I am feeling lazy ;D [15:34:01] lol [15:34:21] coffee and review [15:34:22] bbl [15:35:00] ok [15:38:33] (03CR) 10Hashar: [C: 032] Run MediaWiki 'skins' testsuite on all skins [integration/config] - 10https://gerrit.wikimedia.org/r/323161 (https://phabricator.wikimedia.org/T68926) (owner: 10Hashar) [15:39:48] PROBLEM - Puppet run on deployment-phab02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:39:53] (03Merged) 10jenkins-bot: Run MediaWiki 'skins' testsuite on all skins [integration/config] - 10https://gerrit.wikimedia.org/r/323161 (https://phabricator.wikimedia.org/T68926) (owner: 10Hashar) [15:43:09] hashar https://integration.wikimedia.org/ci/job/mw-testskin-non-voting/1/console [15:44:46] hashar it workled [15:44:47] worked [15:44:56] but failed on Stylesheets should not both specify "media" and contain @media which is supposed to [15:45:03] we should probaly disabled Stylesheets should not both specify "media" and contain @media for skins [15:51:05] PROBLEM - Puppet run on deployment-phab01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:52:00] Yippee, build fixed! [15:52:01] Project selenium-MobileFrontend » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #238: 09FIXED in 30 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/238/ [15:54:59] 10Continuous-Integration-Config, 13Patch-For-Review: Set up phpunit structure tests for MediaWiki skin repositories - https://phabricator.wikimedia.org/T68926#2818059 (10hashar) a:03hashar We now have https://integration.wikimedia.org/ci/job/mw-testskin/ and https://integration.wikimedia.org/ci/job/mw-testsk... [15:55:27] paladox: I have no idea what that test failure is about [15:55:41] hashar it is because i have @media in a less file [15:55:48] try to fix it :} [15:55:57] I doint know how to without breaking [16:09:41] 10Continuous-Integration-Config, 07WorkType-NewFunctionality: Generate JJB jobs from the Zuul layout/templates definition - https://phabricator.wikimedia.org/T135059#2818089 (10Paladox) We could follow how gerrit upstream do this on there ci. I noticed that they did it with jenkins job builder. [16:13:27] hashar, hey. do you know what runs wmf-beta-autoupdate.py? it doesn't appear to be puppetised? [16:14:25] (03PS1) 10Hashar: Configure a few skins [integration/config] - 10https://gerrit.wikimedia.org/r/323169 [16:14:39] is it somewhere in jenkins? [16:14:51] script is in puppet [16:14:58] and run by jenkins on deployment-tin every 10 minutes [16:15:10] so we get notifications when it fails [16:15:10] and a full log [16:15:38] where are the arguments passed to it defined? [16:15:50] phab admin here? [16:16:12] (03CR) 10Hashar: [C: 032] Configure a few skins [integration/config] - 10https://gerrit.wikimedia.org/r/323169 (owner: 10Hashar) [16:17:03] (03Merged) 10jenkins-bot: Configure a few skins [integration/config] - 10https://gerrit.wikimedia.org/r/323169 (owner: 10Hashar) [16:17:33] (03CR) 10Hashar: "https://gerrit.wikimedia.org/r/#/c/323169/ has added all the missing skins (hopefully)" [integration/config] - 10https://gerrit.wikimedia.org/r/198185 (owner: 10Legoktm) [16:17:37] (03CR) 10Hashar: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/198185 (owner: 10Legoktm) [16:20:55] Krenair: not sure which arguments are passed. The job definition in JJB is at https://github.com/wikimedia/integration-config/blob/master/jjb/beta.yaml#L33-L64 [16:21:25] ty [16:21:49] https://github.com/wikimedia/integration-config/blob/master/jjb/beta.yaml#L128 - just --verbose [16:21:54] thanks [16:22:19] hashar, the reason I ask is I'm trying to clean up all the beta stuff in puppet right now and this script is in there as a template [16:22:29] it's a template purely because it gets the staging dir from puppet [16:22:45] ahhh [16:22:54] so yeah can probably be moved to a file:// [16:26:37] don't know if it's worth the effort, needs to be coordinated across repos [16:50:18] I am off! [16:50:23] unlikely to show up this evening [16:50:42] mafk: what's the question? [16:50:56] greg-g: it's already handled by Andre [16:51:09] eh? [16:51:18] ah. [17:27:45] Hi all. Need a patch to be deployed today: https://gerrit.wikimedia.org/r/#/c/323160/ Nothing dangerous. Need this to keep the script running over the long weekend. [17:30:02] we'll have a flood of accounts to rename later ;) [17:30:18] :) [17:35:53] 10Beta-Cluster-Infrastructure, 06Performance-Team, 07Wikimedia-Multiple-active-datacenters: Install and use mcrouter in deployment-prep - https://phabricator.wikimedia.org/T151466#2818315 (10Krinkle) [17:36:56] Niharika: Ok. [17:37:50] Niharika: I'll backport & deploy right now for you [17:37:55] Already logged in and it's trivial [17:38:06] ostriches: Thank you! [17:38:15] That's service! [17:38:15] Question whether https://gerrit.wikimedia.org/r/323181 goes in too ;) [17:38:58] your patch is too complicated for my pre-coffee brain and you can self deploy anyway :p [17:39:09] That's self-service right there ;-) [17:39:20] ostriches: Love you too [17:39:31] *muah* [17:46:34] 03Scap3: Make scap plugins generally useful - https://phabricator.wikimedia.org/T151470#2818345 (10mmodell) [17:51:26] 06Release-Engineering-Team, 03Scap3: scap plugin to export prometheus metrics - https://phabricator.wikimedia.org/T151387#2818369 (10mmodell) [17:51:28] 06Release-Engineering-Team (Long-Lived-Branches), 03Scap3 (Scap3-MediaWiki-MVP), 13Patch-For-Review: Create `scap swat` command to automate patch merging & testing during a swat deployment - https://phabricator.wikimedia.org/T142880#2818370 (10mmodell) [17:51:30] 03Scap3 (Scap3-Adoption-Phase2), 10scap, 07WorkType-NewFunctionality: create a scap3 command to bootstrap a new deployment repo - https://phabricator.wikimedia.org/T118760#2818372 (10mmodell) [17:51:32] 10Deployment-Systems, 06Release-Engineering-Team (Long-Lived-Branches): create `scap merge` command (the successor to make-wmf-branch) - https://phabricator.wikimedia.org/T140918#2818371 (10mmodell) [17:51:35] 03Scap3 (Scap3-Adoption-Phase1), 10scap, 07WorkType-NewFunctionality: Need a way to see config diffs in Scap - https://phabricator.wikimedia.org/T118206#2818374 (10mmodell) [17:51:36] 03Scap3 (Scap3-MediaWiki-MVP), 10scap, 13Patch-For-Review, 07Security-General: Scap should apply security patches - https://phabricator.wikimedia.org/T118478#2818373 (10mmodell) [17:58:02] Niharika: You're backported to wmf.3 + deployed everywhere [17:58:16] Awesome, thanks! [18:00:01] ostriches we could do zero downtime gerrit upgrades using the Read Only plugin according to this thread https://groups.google.com/forum/#!topic/repo-discuss/BhD_GUNmnp0 [18:00:19] ostriches http://www.slideshare.net/lucamilanesio/zerodowntime-gerrit-code-review-upgrades [18:03:01] Meh, our downtime for a non-schema upgrade is minimal. Schema upgrades also don't take long for us. [18:03:13] Needless complexity for minimal gain in our situation [18:03:21] ok [18:03:23] (GerritForge is different since they're hosting a service for third parties) [18:03:31] oh [18:04:50] ostriches there now aware of gerrit going down, lol. They gave me this link https://gerrit-review.git.corp.google.com/ [18:05:16] which i carn't even use as i doint have a @google.com account [18:05:23] Meh, I'm too busy to care about upstream today :p [18:12:08] Its back now [18:12:32] (03PS1) 10Hashar: WMF: Show project in build description [integration/zuul] (patch-queue/debian/precise-wikimedia) - 10https://gerrit.wikimedia.org/r/323190 [18:14:35] hashar i thought we doint need to do it on precise any more ^^ ? [18:15:17] I mean hasharAway ^^ [18:24:45] 06Release-Engineering-Team, 10Wikimedia-Developer-Summit, 06Developer-Relations (Oct-Dec-2016), 07Documentation: Developer Summit 2017: Work with TPG and RelEng on solution to event documenting - https://phabricator.wikimedia.org/T132400#2818476 (10ksmith) @srishakatux : The Team Practices Group has long b... [18:29:42] 05Gerrit-Migration, 03releng-201617-q3, 05Goal: Phase 2 repository migrations to Differential (goal - end of March 2017) - https://phabricator.wikimedia.org/T130420#2818480 (10Aklapper) [18:29:44] 05Gerrit-Migration, 03releng-201617-q4, 05Goal: Phase 3 repository migrations to Differential (goal - end of June 2017) - https://phabricator.wikimedia.org/T130421#2818481 (10Aklapper) [18:37:18] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 10Reading-Web-Trending-Service, 06Services (watching): Move primary trending service development to github - https://phabricator.wikimedia.org/T151469#2818487 (10GWicke) [18:41:24] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 10Reading-Web-Trending-Service, 06Services (watching): Move primary trending service development to github - https://phabricator.wikimedia.org/T151469#2818282 (10GWicke) I agree that testing this service properly is a requirement. I cc'ed... [18:56:44] from a user on #gerrit for hasharAway [18:56:45] hashar: openstack is waiting for you guys to upgrade so we can follow your lead.. :) [19:15:16] hasharAway apprently though upstream openstack say zuul v3 will drop support for jenkins, jenkins support will still work as long as they doint drop gearmon. [19:32:25] 03Scap3: Make scap plugins generally useful - https://phabricator.wikimedia.org/T151470#2818664 (10mmodell) [19:32:27] 03Scap3 (Scap3-MediaWiki-MVP), 10scap, 13Patch-For-Review, 07Security-General: Scap should apply security patches - https://phabricator.wikimedia.org/T118478#2818663 (10mmodell) 05Open>03Resolved [19:40:51] paladox: neat. Zaro wrote the Jenkins Gearman plugin among others [19:41:00] oh [19:41:17] I am speaking to him /her on n #gerrit [19:41:22] on n = on [19:41:41] I have joined the channel [19:41:48] thanks :) [20:00:00] (03PS1) 10Paladox: Create a test that deploy's jjb changes without needing to ssh in and deploy your self [integration/config] - 10https://gerrit.wikimedia.org/r/323198 [20:00:06] ostriches hashar ^^ :) [20:01:39] hashar maybe we want a new whitelist for ^^ so that you can do jenkins jjb deploy and it will deploy [20:01:40] :) [20:05:46] yeah maybe [20:06:00] :) [20:06:03] but you need to inject credentials [20:06:15] andI am not sure whether we want to autodeploy on +2 [20:06:19] maybe or mabye not [20:06:25] meanwhile [20:06:26] hashar i mean create a custom keyword [20:06:34] for a special whitelisted group in zuul [20:06:42] I have sent a dummy Gerrit change for each of the skin to find out which have the structure tests passing :D [20:06:42] so like jenkins jjb deploy [20:06:47] :) [20:07:07] hashar we can do qunit now [20:08:05] I have no idea how the karma qunit works really [20:08:20] or how to get it to run against a specific skin or whether it makes sense at all [20:08:21] we could do a non voting test. [20:10:59] yeah they are going on https://integration.wikimedia.org/zuul/ [20:11:01] :D [20:11:29] hashar i thought hhvm is using php 5.6? [20:11:31] on ci jessie [20:11:49] i am going to submit a patch so we can use both trusty and jessie for php 55 and hhvm [20:11:55] 55 on trusty and hhvm on jessie? [20:13:03] why? [20:13:18] Because i thought the minimum supported php we use is php 55 [20:13:40] since there are changes in php 5.6 that could break php 5.5 support. [20:14:04] yeah theorically [20:14:11] not sure it is much needed really [20:14:19] Oh [20:15:03] hashar you forgot to add the test to nodepool_params [20:15:13] we should rename it to have -jessie prefix on it [20:16:11] slow down paladox! [20:16:18] Ok [20:16:23] you can shoot a new idea every 5 minutes and expect me to catch up with all of them :D [20:16:36] oh [20:16:50] the nodepool_params , it might well no more be needed [20:16:56] oh [20:17:14] there is a plugin that auto disconnect the Jenkins slaves whenever a build occured on the labels ci-jessie-wikimedia or ci-trusty-wikimedia [20:17:40] so that really does the same as the NODE_OFFLINE_WHEN_COMPLETE (or whatever that variable is named) [20:17:48] might as well just drop the function entirely [20:17:51] not sure :D [20:18:07] oh [20:21:13] 10Beta-Cluster-Infrastructure, 06Performance-Team, 07Wikimedia-Multiple-active-datacenters: Install and use mcrouter in deployment-prep - https://phabricator.wikimedia.org/T151466#2818204 (10aaron) p:05Triage>03Normal [20:24:30] hashar you should send an email saying skins are now tested with unit tests :) [20:33:49] https://gerrit.wikimedia.org/r/#/q/project:%255Emediawiki/skins/.*+topic:skintest [20:34:05] here are all the dummy changes I havent sent covering all skins [20:35:52] :) [20:41:01] hashar im wondering do we want to create a seperate test for skins unit tests for composer? [20:41:17] Since i see that the test you created runs composer. [20:41:38] should probaly create a seperate test otherwise some may fail that doint use composer [20:52:13] (03PS1) 10Hashar: Add MediaWiki testsuite to a few missed skins [integration/config] - 10https://gerrit.wikimedia.org/r/323243 (https://phabricator.wikimedia.org/T68926) [20:52:42] paladox: composer is run from the root of mediawiki core [20:52:58] yep i mean like composer as in dependacies [20:53:18] because it seems you used prepare-mediawiki-zuul-project-no-vendor [20:53:24] yeah [20:53:29] instead of prepare-mediawiki-zuul-project [20:53:31] should be fine :D [20:53:40] I am creating the patch now, oh [20:53:59] if a skin get a dependency defined, composer will get it installed [20:53:59] so we doint need to have a seperate test? [20:54:14] because what happends if there is no composer.json file? [20:54:17] and given most of those skins are 3rd party/ not wmf [20:54:25] their dependencies are most probably not going to be added to mediawiki/vendor [20:54:31] oh [20:54:33] yep [20:54:58] hashar i am going to create the test skin template in layout.yaml [20:55:03] and make vector voting [20:55:05] (03CR) 10Hashar: [C: 032] Add MediaWiki testsuite to a few missed skins [integration/config] - 10https://gerrit.wikimedia.org/r/323243 (https://phabricator.wikimedia.org/T68926) (owner: 10Hashar) [20:55:06] as it passes [20:55:07] :) [20:55:19] paladox: I got such a change already :D [20:55:25] oh [20:55:38] on your local machine or is it on gerrit? [20:55:53] (03Merged) 10jenkins-bot: Add MediaWiki testsuite to a few missed skins [integration/config] - 10https://gerrit.wikimedia.org/r/323243 (https://phabricator.wikimedia.org/T68926) (owner: 10Hashar) [20:59:58] (03PS1) 10Paladox: Make vector mw skin unti test voting [integration/config] - 10https://gerrit.wikimedia.org/r/323245 [21:00:02] hashar ^^ [21:00:03] :) [21:00:40] (03PS2) 10Paladox: Make vector mw skin unti test voting [integration/config] - 10https://gerrit.wikimedia.org/r/323245 [21:09:05] (03PS1) 10Hashar: Make skin tests to vote when they are passing [integration/config] - 10https://gerrit.wikimedia.org/r/323247 (https://phabricator.wikimedia.org/T68926) [21:09:19] paladox: https://gerrit.wikimedia.org/r/323247 make all passing skins voting :] [21:09:42] hashar it will fail metrolook [21:11:18] 10Continuous-Integration-Config, 10BlueSky, 13Patch-For-Review: Fix structure tests for all skins - https://phabricator.wikimedia.org/T113860#2818972 (10hashar) [21:11:22] paladox: and https://phabricator.wikimedia.org/T113860 has the list of failing skins [21:11:35] hashar oh thanks [21:11:36] (03PS1) 10Paladox: Remove mw-checks-test from all skins/* [integration/config] - 10https://gerrit.wikimedia.org/r/323248 [21:11:40] hashar ^^ [21:11:44] :) [21:11:58] why do you want to do that ? [21:12:07] (03PS2) 10Paladox: Remove mw-checks-test from all skins/* [integration/config] - 10https://gerrit.wikimedia.org/r/323248 [21:12:07] guess i should look at it :D [21:12:36] Oh because it wont be needed any more, since we will do it here https://gerrit.wikimedia.org/r/#/c/323245/ [21:13:11] (03CR) 10Hashar: [C: 032] "I have sent dummy changes on every single skins then waited for result of the job :] Any repo that had the job passing is now voting!" [integration/config] - 10https://gerrit.wikimedia.org/r/323247 (https://phabricator.wikimedia.org/T68926) (owner: 10Hashar) [21:13:38] paladox: then mw-checks-test has a bunch of other jobs [21:13:45] oh [21:13:58] (03Merged) 10jenkins-bot: Make skin tests to vote when they are passing [integration/config] - 10https://gerrit.wikimedia.org/r/323247 (https://phabricator.wikimedia.org/T68926) (owner: 10Hashar) [21:14:02] - php53lint [21:14:02] - php55lint [21:14:02] - jsonlint [21:14:02] - composer-validate [21:14:05] (03CR) 10jenkins-bot: [V: 04-1] Remove mw-checks-test from all skins/* [integration/config] - 10https://gerrit.wikimedia.org/r/323248 (owner: 10Paladox) [21:14:09] hashar only tests ^^ [21:14:17] ah https://gerrit.wikimedia.org/r/#/c/323245/2 [21:14:35] so in that change you claim to make the vector skin job passing [21:14:43] AND also change the template [21:14:49] that is rather confusing [21:15:04] oh sorry [21:15:08] I made it voting on Vector and all extensions that passed ( https://gerrit.wikimedia.org/r/323247 ) [21:15:10] will need to update the commit msg [21:15:13] and rebase it [21:15:26] yeah ;] [21:15:50] so your idea is to merge mw-checks-test template inside skin-test isnt it? [21:16:19] (03PS3) 10Paladox: Make vector mw skin unti test voting [integration/config] - 10https://gerrit.wikimedia.org/r/323245 [21:16:26] according to Yes [21:16:32] according to = nothing [21:16:59] 10Continuous-Integration-Config, 13Patch-For-Review: Set up phpunit structure tests for MediaWiki skin repositories - https://phabricator.wikimedia.org/T68926#2818986 (10hashar) 05Open>03Resolved The CI part is complete. Skins not passing the structure tests have the job triggered albeit it is non voting.... [21:17:13] But i guess that would just be a waste if we have a template that does it [21:17:20] 10Continuous-Integration-Config, 13Patch-For-Review: Set up phpunit structure tests for MediaWiki skin repositories - https://phabricator.wikimedia.org/T68926#2818992 (10hashar) @Legoktm sorry it took 2 years + to get that one addressed :( [21:17:47] paladox: I dont mind using several simple templates [21:17:54] oh [21:17:59] probablyl easier to understand than a few templates that have a lot of different jobs [21:18:06] Yep [21:18:13] but yeah probably make sense to merge mw-checks-test and skin-tests [21:18:21] Yep [21:18:33] then you get a variance which is that some skins have non voting structure tests ! [21:18:41] anyway [21:18:52] feel free to announce it on wikitech-l ;] [21:19:35] (03PS4) 10Paladox: Update skin-tests template [integration/config] - 10https://gerrit.wikimedia.org/r/323245 [21:19:36] quoting that one can reproduce using: cd tests/phpunit; php phpunit --testsuite skins [21:23:30] paladox: I am heading bed [21:23:35] will review your patches tomorrow :] [21:23:41] hashar i've sent the email [21:23:42] now [21:23:46] awesome! [21:23:53] just a simple one, with your name on it [21:23:54] :) [21:25:02] that would probably be easy to fix [21:25:08] hashar you may need to forward it again, since it will likly end up in peoples spam box. [21:25:11] the list of skins failling is on https://phabricator.wikimedia.org/T113860 [21:25:17] because gmail does not like yahoo. [21:25:21] so one can probaly just clone all of them [21:25:24] yep i listed that too :) [21:25:32] then run the suite locally and fix the repos one by one [21:25:38] oh [21:26:44] 10Continuous-Integration-Config, 13Patch-For-Review: Set up phpunit structure tests for MediaWiki skin repositories - https://phabricator.wikimedia.org/T68926#2819057 (10Paladox) email has been sent. [21:26:54] paladox: have you sent it to wikitech-l ? [21:27:00] Yep [21:27:00] ah yeah [21:27:01] here it is [21:27:17] but it seems gmail users complain to me that it keeps going into spam [21:27:23] looks good enough :] [21:27:23] when i send it from a yahoo address [21:27:27] :) [21:27:36] well [21:27:43] for gmail users either: [21:27:55] A) complain to gmail that they are too strict/pedantic [21:28:02] B) use another provider (:D [21:28:07] Yep [21:28:15] :) [21:28:21] C) add a rule to lower the spam core / stop flagging as spam whenever a mail is sent to a list [21:28:25] or from @yahoo [21:28:29] or even both [21:28:31] yep :) [21:42:02] hashar: it's a yahoo problem [21:42:23] and thank gmail for not discarding it as requested by yahoo's dmarc [21:42:44] I will have to report it to yahoo [21:42:52] yep [21:42:55] good luck, though [21:43:06] $ dig -t txt +short _dmarc.yahoo.com [21:43:06] "v=DMARC1; p=reject; pct=100; rua=mailto:dmarc_y_rua@yahoo.com;" [21:43:19] Oh [21:43:35] they have broken mailing lists since… 2013? [21:43:53] i belive mail list works now [21:43:59] In April 2014, Yahoo changed its DMARC policy to p=reject, thereby causing misbehavior in several mailing lists.[5] A few days later, AOL also changed its DMARC policy to p=reject.[6] Those moves resulted in a significant amount of disruption, and those mailbox providers have been accused of forcing the costs of their own security failures on third parties.[7] [21:49:10] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 10Reading-Web-Trending-Service, 06Services (watching): Move primary trending service development to github - https://phabricator.wikimedia.org/T151469#2818282 (10demon) It's unlikely we would be able to support Kafka on a short timeline.... [21:55:54] 06Release-Engineering-Team, 10Tool-Labs-tools-Other, 13Patch-For-Review: Jouncebot: Add functionality to change Nick from Jouncebot_ to Jouncebot automatically - https://phabricator.wikimedia.org/T150916#2819155 (10Zppix) @bd808 any news on this change (has it been deployed or not) [21:57:53] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 10Reading-Web-Trending-Service, 06Services (watching): Move primary trending service development to github - https://phabricator.wikimedia.org/T151469#2818282 (10hashar) > Our current jenkins infrastructure is not able to install kafka... [21:58:27] hashar i've reported the issue to yahoo [21:58:33] they doint make it easy to do so either [22:01:15] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 10Reading-Web-Trending-Service, 06Services (watching): Move primary trending service development to github - https://phabricator.wikimedia.org/T151469#2819165 (10Pchelolo) > But I guess having Kafka setup properly is a bit more challengin... [22:08:04] I am off! have a good time :] [22:11:41] Platonides https://help.yahoo.com/kb/SLN24050.html [22:16:26] yeah, what it doesn't say is "that means you won't be able to post to a mailing list using an email on one of these domains" [22:16:42] it makes sense for paypal.com [22:16:51] it's annoying, but understandable for google.com [22:17:15] but it's not something to set on a freemail provider [22:17:53] yep [22:18:11] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 10Reading-Web-Trending-Service, 06Services (watching): Move primary trending service development to github - https://phabricator.wikimedia.org/T151469#2818282 (10greg) I just want to say here: let's not make any hasty decisions on the day... [22:19:25] 06Release-Engineering-Team, 03releng-201617-q2, 05MW-1.28-release: Release MW 1.28 - https://phabricator.wikimedia.org/T148087#2819212 (10demon) a:03demon [23:55:54] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T150465#2819575 (10greg) a:03demon [23:56:09] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.5 deployment blockers - https://phabricator.wikimedia.org/T150972#2819578 (10greg) a:03demon [23:59:33] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Infrastructure, 10DBA, 10MediaWiki-Database, and 2 others: Enable MariaDB/MySQL's Strict Mode - https://phabricator.wikimedia.org/T108255#2819587 (10Ejegg)