[04:06:34] Yippee, build fixed! [04:06:35] Project selenium-MultimediaViewer » safari,beta,OS X 10.9,contintLabsSlave && UbuntuTrusty build #231: 09FIXED in 10 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=safari,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=OS%20X%2010.9,label=contintLabsSlave%20&&%20UbuntuTrusty/231/ [04:18:39] Project selenium-MultimediaViewer » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #231: 04FAILURE in 22 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/231/ [08:58:32] 10Continuous-Integration-Infrastructure, 13Patch-For-Review, 07Zuul: mediawiki-extensions jobs take 4 minutes to clone repositories (with zuul-cloner) - https://phabricator.wikimedia.org/T152604#2864235 (10hashar) Checked again, it is down to a minute on both jobs. [09:07:43] 10Gerrit, 13Patch-For-Review: Gerrit not updating submodules in mediawiki/extensions - https://phabricator.wikimedia.org/T152663#2864247 (10hashar) 05Open>03Resolved a:03Paladox @Paladox got it fixed by changing the git URLs: ``` lang=diff - https://gerrit.wikimedia.org/r/p/PROJECT.git + https://gerrit.w... [09:18:37] paladox: good morning. Thanks for all the submodules patches :} [09:33:59] 10Beta-Cluster-Infrastructure, 07Puppet: puppet failure on deployment-phab01 ... is not a Hash. It looks to be a Array at /etc/puppet/modules/phabricator/manifests/init.pp:68 - https://phabricator.wikimedia.org/T147818#2864262 (10hashar) [09:38:15] 10Beta-Cluster-Infrastructure, 13Patch-For-Review, 07Puppet: puppet failure on deployment-phab01 ... is not a Hash. It looks to be a Array at /etc/puppet/modules/phabricator/manifests/init.pp:68 - https://phabricator.wikimedia.org/T147818#2864279 (10hashar) a:03hashar [11:02:15] 10Gerrit, 07Upstream: Commenting on a merged patch does not send the notification to irc - https://phabricator.wikimedia.org/T152932#2864421 (10Aklapper) What is "it" in "It does not send any notifications to irc any more"? `gerrit-wm`? [11:04:28] 10Beta-Cluster-Infrastructure, 13Patch-For-Review, 07Puppet: puppet failure on deployment-phab01 ... is not a Hash. It looks to be a Array at /etc/puppet/modules/phabricator/manifests/init.pp:68 - https://phabricator.wikimedia.org/T147818#2704482 (10Paladox) Should probably switch these hosts to use the mai... [11:05:33] 10Gerrit, 07Upstream: Commenting on a merged patch does not send the notification to irc - https://phabricator.wikimedia.org/T152932#2864444 (10Paladox) It sends notifications as long as the patch is open, when you merge it and comment on the patch it dosent send that to irc any more (grrrit-wm) [11:30:36] (03CR) 10Hashar: "Failed due to:" [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/326140 (owner: 10Hashar) [11:30:41] (03CR) 10Hashar: "recheck" [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/326140 (owner: 10Hashar) [11:31:42] (03PS2) 10Hashar: Updating regex for the email so that we do org|de and not org and de seperatly [integration/config] - 10https://gerrit.wikimedia.org/r/325137 (owner: 10Paladox) [11:32:01] (03CR) 10Hashar: [C: 032] Updating regex for the email so that we do org|de and not org and de seperatly [integration/config] - 10https://gerrit.wikimedia.org/r/325137 (owner: 10Paladox) [11:33:25] (03Merged) 10jenkins-bot: Updating regex for the email so that we do org|de and not org and de seperatly [integration/config] - 10https://gerrit.wikimedia.org/r/325137 (owner: 10Paladox) [11:34:54] (03PS2) 10Hashar: (WIP) clone wmf branches for operations/mediawiki-config [integration/config] - 10https://gerrit.wikimedia.org/r/320792 (https://phabricator.wikimedia.org/T115713) [11:35:38] lunch && [12:31:41] (03CR) 10Hashar: [C: 04-1] "Some notes about the changes I am going to do." (033 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [12:50:56] (03PS16) 10Hashar: Support skin as dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [15:05:31] PROBLEM - Host deployment-elastic08 is DOWN: CRITICAL - Host Unreachable (10.68.21.29) [15:21:57] hashar hi, thanks for merging my patches today and your welcome :) [15:22:20] 10Browser-Tests-Infrastructure, 10Wikidata: Increase in failures caused by Saucelabs - https://phabricator.wikimedia.org/T152963#2864860 (10Tobi_WMDE_SW) [15:23:09] 10Browser-Tests-Infrastructure, 10Wikidata: Increase in failures caused by Saucelabs - https://phabricator.wikimedia.org/T152963#2864872 (10Tobi_WMDE_SW) [15:23:34] 10Browser-Tests-Infrastructure, 10Wikidata, 15User-Tobi_WMDE_SW: Increase in failures caused by Saucelabs - https://phabricator.wikimedia.org/T152963#2864860 (10Tobi_WMDE_SW) [15:24:40] 10Continuous-Integration-Config, 10Wikidata, 15User-Tobi_WMDE_SW, 03WMDE-QWERTY-Team-Board: E-Mail notification on failures of Wikidata-builds - https://phabricator.wikimedia.org/T152495#2864892 (10Tobi_WMDE_SW) [15:26:05] hashar we could use filebeat for gerrit as it would make it easyer to maintain and i could not get log4j to work for sending logs to logstash. [15:29:20] 10Beta-Cluster-Infrastructure, 07Puppet: deployment-eventlogging03 has puppet failure due to missing class - https://phabricator.wikimedia.org/T152842#2864920 (10Ottomata) Just asked this on the ticket, will re-ask here: Can I remove this role inclusion somehow? I'm looking in horizon, but I don't see the ro... [15:44:12] Yippee, build fixed! [15:44:13] Project selenium-MobileFrontend » chrome,beta,Linux,contintLabsSlave && UbuntuTrusty build #258: 09FIXED in 22 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/258/ [15:48:37] (03PS17) 10Hashar: Support skin as dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [15:48:54] paladox: large refactor of the skin dependency thing :} [15:49:03] Thanks :) :) [15:49:27] (03Abandoned) 10Hashar: Add a new Skin dependacies test [integration/config] - 10https://gerrit.wikimedia.org/r/323546 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [15:49:50] paladox: I think we have one or two skins that require some extensions to be injected [15:50:02] so most probably I will add a patch on top of that one [15:50:05] and check/write tests [15:50:08] Oh yep. [15:50:13] I forgot which one though. [15:50:18] pretty sure one of the skins requires the extension phptags [15:50:31] yep [15:50:44] that is why some skins have the zuul template skin-tests-non-voting [15:50:59] however, I thought I had added some comments about in the layout.yaml file :( [15:51:15] yep [15:52:46] On eknown skin is the BlueSpiceSkin which requires the BlueSpiceFoundation extension. [15:52:47] ;D [15:53:16] and I guess I want to follow up on https://phabricator.wikimedia.org/T113860 "Fix structure tests for all skins" [15:53:29] Yippee, build fixed! [15:53:30] Project selenium-MobileFrontend » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #258: 09FIXED in 31 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/258/ [15:55:41] and and CustomPage requires skins/CustomPage [15:57:14] Oh [15:57:17] yep [15:57:56] 10Continuous-Integration-Config, 13Patch-For-Review: Add support for skin and extension dependencies in new skin unit test - https://phabricator.wikimedia.org/T151593#2864988 (10hashar) [16:28:01] hashar ostriches it's strange that i am getting emails from gerrit about changes i merged yesturday saying that it submitted it to gate and submit at 15:39 pm today even though it merged it yesturday [16:28:08] im going to say thats a bug in gerrit. [16:31:43] specific test cases welcome [16:35:03] 10Gerrit, 06translatewiki.net, 13Patch-For-Review, 15User-Nikerabbit: fatal: Project not found: mediawiki/extensions/url - https://phabricator.wikimedia.org/T152727#2865119 (10Nikerabbit) I went with a simpler solution now. [16:36:16] (03PS18) 10Hashar: Support skin as dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [16:36:19] (03PS1) 10Hashar: Inject skin/ext dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/326469 (https://phabricator.wikimedia.org/T151593) [16:36:23] paladox: ^^^^:} [16:36:28] thanks [16:36:34] paladox: feel free to review / double check! [16:36:41] Ok [16:36:43] I am going to let the dust settle on those two changes [16:37:05] and tomorrow follow up on your comment if any / replay them and then deploy [16:37:17] going to add kunal to it. IIRC he has experience with that part of the code [16:37:46] Ok [16:37:57] thanks [16:39:00] andre__ here https://gerrit.wikimedia.org/r/326296 [16:39:01] https://phabricator.wikimedia.org/P4609 [16:40:13] (03CR) 10Hashar: "So that change is rather terrible but should work, a demo is the child change https://gerrit.wikimedia.org/r/#/c/326469/" [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [16:41:44] (03CR) 10Paladox: [C: 031] "Looks ok." [integration/config] - 10https://gerrit.wikimedia.org/r/326469 (https://phabricator.wikimedia.org/T151593) (owner: 10Hashar) [16:49:02] (03CR) 10Paladox: Support skin as dependencies (035 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [17:11:55] RECOVERY - Puppet run on deployment-phab01 is OK: OK: Less than 1.00% above the threshold [0.0] [17:57:20] 10Beta-Cluster-Infrastructure, 13Patch-For-Review, 07Puppet: puppet failure on deployment-phab01 ... is not a Hash. It looks to be a Array at /etc/puppet/modules/phabricator/manifests/init.pp:68 - https://phabricator.wikimedia.org/T147818#2865451 (10mmodell) `deployment-phab01` is [[ http://beta-phab.wmflab... [18:06:21] 10Beta-Cluster-Infrastructure, 07Puppet: deployment-eventlogging03 has puppet failure due to missing class - https://phabricator.wikimedia.org/T152842#2865484 (10Krenair) I think that has come up before in T152472 [18:23:13] 10Beta-Cluster-Infrastructure, 07Puppet: deployment-eventlogging03 has puppet failure due to missing class - https://phabricator.wikimedia.org/T152842#2861773 (10Andrew) In the horizon gui, when I click on the 'all' filter, I see the role right there. 'Remove Role' should do what you want. [18:25:59] 10Beta-Cluster-Infrastructure, 07Puppet: deployment-eventlogging03 has puppet failure due to missing class - https://phabricator.wikimedia.org/T152842#2865570 (10Krenair) I just changed to the 'all' tab (thanks @andrew) and found the old classes, then removed them. I think it broke things: Notice: /Stage[main]... [18:34:20] 10scap: Automatically clean up unused wmfXX versions - https://phabricator.wikimedia.org/T73313#771423 (10demon) This is easier now than before, eg: `scap clean 1.28.0-wmf.9` [18:36:19] RECOVERY - Puppet run on deployment-eventlogging03 is OK: OK: Less than 1.00% above the threshold [0.0] [18:40:06] 10Beta-Cluster-Infrastructure, 07Puppet: deployment-eventlogging03 has puppet failure due to missing class - https://phabricator.wikimedia.org/T152842#2865632 (10Ottomata) Ah, ALL filter, duh. Hm, ok, yeah we need to have the newly refactored eventlogging roles included. I don't see them in the list of class... [18:41:10] I forget, do translatewiki updates get pushed to production as part of the deployment train, or are they merged separately and daily somehow? [18:41:48] 10Beta-Cluster-Infrastructure, 07Puppet: deployment-eventlogging03 has puppet failure due to missing class - https://phabricator.wikimedia.org/T152842#2865636 (10Ottomata) Actually, I take it back! Other classes worked great. [18:44:47] quiddity, I think that process is l10nupdate which runs nightly at 2AM as a cron job [18:45:09] ah! I thought so, but wanted to confirm. Thanks Krenair. [18:45:15] quiddity, however [18:45:39] I don't see anything on SAL about it succeeding since the 26th of November, just over two weeks ago [18:46:16] quiddity, have you seen updates since then? [18:48:44] It attempted to run on the 29th but failed to sync [18:49:17] and every day since then in fact [18:49:21] 02:11:46 sync-l10n failed: 'Namespace' object has no attribute 'message' [18:49:28] ostriches, bd808 [18:49:40] see tin.eqiad.wmnet:/var/log/l10nupdatelog/l10nupdate.log-20161211.gz [18:49:49] you may need to sudo -u l10nupdate -i [18:50:08] blech. I though thcipriani fixed that [18:50:09] File "/usr/lib/python2.7/dist-packages/scap/main.py", line 38, in main [18:50:09] with utils.lock(self.config['lock_file'], self.arguments.message): [18:50:49] I hate l10nupdate-1 [18:50:58] fixed...but maybe not live yet [18:51:00] * thcipriani looks [18:51:07] ostriches, I didn't know [18:51:32] Krenair, idk, I was asking for a tangential reason, and just wanted to explain to some editors how it usually works. [18:51:38] blerg, no, not live yet. in scap's master branch. [18:51:50] well, turns out that right now, the answer is that it doesn't :) [18:52:02] ostriches: hurry up and write the new l10n cache layer that you, ori, and I talked about ... 3 years ago? [18:52:29] E_TOOMANYPROBLEMS [18:52:32] it has nothing to do with the caching format. [18:52:40] cdb vs php idk [18:52:40] I blame scap [18:52:45] the whole cdb mess though [18:52:45] it's that goddamn cron [18:53:10] Krenair: generally a fair bet [18:53:14] Krenair: yes it's scaps fault [18:53:25] that shouldn't be a bug tho [19:34:10] (03CR) 10Filippo Giunchedi: "I'm not sure why this is needed, uprightdiff will also get reviews for its own source code" [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/326140 (owner: 10Hashar) [19:39:15] 06Release-Engineering-Team, 06Project-Admins, 10ReleaseTaggerBot: Move all WMF-deploy-* projects to be milestones of ?? the "MW-1.XX-release-notes" projects? - https://phabricator.wikimedia.org/T152999#2865940 (10Jdforrester-WMF) [19:51:42] 06Release-Engineering-Team, 06Project-Admins, 10ReleaseTaggerBot: Move all WMF-deploy-* projects to be milestones of ?? the "MW-1.XX-release-notes" projects? - https://phabricator.wikimedia.org/T152999#2865940 (10greg) Sure? :) [19:52:23] 06Release-Engineering-Team, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2866005 (10bmansurov) A few observations: * Icons are present at Special:MobileMenu: https://en.m.wikipe... [19:52:47] 06Release-Engineering-Team, 06Project-Admins, 10ReleaseTaggerBot: Move all WMF-deploy-* projects to be milestones of ?? the "MW-1.XX-release-notes" projects? - https://phabricator.wikimedia.org/T152999#2866007 (10Aklapper) Yo! [20:39:14] Why is beta-scap-eqiad disabled? [20:43:04] Project selenium-Echo » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #239: 04FAILURE in 2 min 2 sec: https://integration.wikimedia.org/ci/job/selenium-Echo/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/239/ [20:44:19] (03PS1) 10Chad: Clean up branching logic to remove .git and /p/ [tools/release] - 10https://gerrit.wikimedia.org/r/326543 [20:46:48] (03CR) 10Thcipriani: [C: 032] Clean up branching logic to remove .git and /p/ [tools/release] - 10https://gerrit.wikimedia.org/r/326543 (owner: 10Chad) [20:49:57] (03Merged) 10jenkins-bot: Clean up branching logic to remove .git and /p/ [tools/release] - 10https://gerrit.wikimedia.org/r/326543 (owner: 10Chad) [21:03:51] Reedy: huh, no idea, any thing in the UI saying who did it? [21:10:06] (pending—Waiting for next available executor on deployment-tin.eqiad) [21:10:16] oh [21:10:16] It seems idle [21:10:26] that's a lockup bug probably? /me looks [21:11:13] ugh, we'll probably need to do https://www.mediawiki.org/wiki/Continuous_integration/Jenkins#Hung_beta_code.2Fdb_update [21:11:29] let's see [21:13:40] doesn't look to have fixed it [21:14:39] "Sometimes you have to do this whole dance several times before Jenkins realizes that the there are a bunch of executors that it can use." [21:15:01] Let's leave it offline for a little while [21:17:27] 06Release-Engineering-Team, 06Services, 10Phabricator (Upstream), 07Regression, 07Upstream: Phabricator upgrade broke milestone tag completion - https://phabricator.wikimedia.org/T152726#2866354 (10GWicke) Confirmed fixed. Thanks a lot! [21:21:01] Nope [21:21:56] bugger, thcipriani any other ideas ^ [21:22:08] looks like hte gearman comment beneath is wrong too [21:22:23] * thcipriani looks [21:22:59] wonder if it's easier to just restart tin [21:23:24] ugh. https://integration.wikimedia.org/zuul/ [21:23:34] ^ have to do the dance 4 more times [21:23:39] to clear out the queue of postmerge [21:23:45] aha [21:23:49] I'll carry on then :P [21:23:55] I did notice all those before [21:23:58] there were a load more [21:24:19] yeah, they get cleared out as you cancel jobs and do the attach/reattach dance [21:24:23] has been my experience [21:24:53] and once they all get cleared it works again. [21:25:10] I'll bet there is a more sane way to do this... [21:25:23] but I bet it involves some gearman digging [21:26:54] Project beta-scap-eqiad build #132919: 04FAILURE in 18 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/132919/ [21:27:19] oh hello wmf-insecte [21:27:28] I guess that means it's fixed [21:28:12] thanks thcipriani [21:28:36] 21:28:32 21:28:32 Unable to find remote tracking branch/tag for /srv/mediawiki-staging/php-master/extensions/BlueSpiceEditNotifyConnector [21:28:38] Loads of those [21:28:46] ostriches: ^ do we need to fixup the clones on beta? [21:28:57] Nope [21:28:59] Ignore that [21:29:00] Warning [21:29:10] (technically that's how it always behaved, warning is new though) [21:29:17] heh [21:29:19] fair enough [21:29:52] Yippee, build fixed! [21:29:53] Project beta-scap-eqiad build #132920: 09FIXED in 2 min 6 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/132920/ [21:29:56] whee [21:35:01] Project beta-code-update-eqiad build #134116: 04FAILURE in 2 min 0 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/134116/ [21:35:25] lol [21:35:39] heh [21:35:42] That I did break [21:39:16] Yippee, build fixed! [21:39:17] Project beta-code-update-eqiad build #134117: 09FIXED in 1 min 49 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/134117/ [21:48:38] (03CR) 10Hashar: "The .gitreview file in the master branch is left untouched:" [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/326140 (owner: 10Hashar) [21:50:56] (03PS1) 10Hashar: .gitreview: swap defaultbranch for track [integration/uprightdiff] - 10https://gerrit.wikimedia.org/r/326820 [21:51:51] (03PS1) 10Hashar: .gitreview: swap defaultbranch for track [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/326821 [21:52:06] (03CR) 10jenkins-bot: [V: 04-1] .gitreview: swap defaultbranch for track [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/326821 (owner: 10Hashar) [21:54:03] (03Abandoned) 10Hashar: Make .gitreview to point to debian branch [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/326140 (owner: 10Hashar) [21:54:08] 10Gerrit, 06translatewiki.net, 13Patch-For-Review, 15User-Nikerabbit: fatal: Project not found: mediawiki/extensions/url - https://phabricator.wikimedia.org/T152727#2866433 (10Raymond) 05Open>03Resolved a:03Raymond Thanks @Nikerabbit for the quick fix. Export runs well today :-) [21:55:30] (03CR) 10Hashar: "I guess debian-glue will fail until the change in master lands ( https://gerrit.wikimedia.org/r/#/c/326820/ )" [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/326821 (owner: 10Hashar) [22:01:25] 10Continuous-Integration-Config, 07Puppet: rake-jessie tests check .pp files but are not triggered by .pp file changes - https://phabricator.wikimedia.org/T153013#2866448 (10Tgr) [22:02:13] 06Release-Engineering-Team, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2866463 (10Jdlrobson) I couldn't replicate this on https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Pag... [22:25:19] (03CR) 10Legoktm: [V: 032 C: 032] .gitreview: swap defaultbranch for track [integration/uprightdiff] - 10https://gerrit.wikimedia.org/r/326820 (owner: 10Hashar) [22:33:02] (03CR) 10Legoktm: "It's going to fail until we tag a new upstream release on the master branch and bump the changelog to include it...probably best to just m" [integration/uprightdiff] (debian) - 10https://gerrit.wikimedia.org/r/326821 (owner: 10Hashar) [22:38:06] marxarelli: can I ask your help with a probably trivial rspec problem? [22:43:06] 06Release-Engineering-Team, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review, and 2 others: Menu icons are missing on Firefox 50.0.2, Mac OS 10.9.5 - https://phabricator.wikimedia.org/T152732#2866534 (10bmansurov) Good job, @jdlrobson. [23:02:44] 06Release-Engineering-Team (Long-Lived-Branches), 10scap, 06Operations: Make git 2.2.0+ (preferably 2.8.x) available - https://phabricator.wikimedia.org/T140927#2866564 (10hashar) [23:03:42] 06Release-Engineering-Team (Long-Lived-Branches), 10scap, 06Operations: Make git 2.2.0+ (preferably 2.8.x) available - https://phabricator.wikimedia.org/T140927#2481328 (10hashar) Mentions git-submodule got ported to C with 2.9.0. `git submodule update` also learns `--jobs` to fetch changes in parallel (de... [23:45:23] tgr: yeah, sure thing [23:46:39] marxarelli: thx! I added some custom puppet functions to a patch and wrote simple tests like https://gerrit.wikimedia.org/r/#/c/326394/4/puppet/modules/wmflib/spec/unit/puppet/parser/functions/shellescape_spec.rb [23:47:06] which 1) are not picked up by CI, 2) fail when run manually due to PuppetlabsSpec not being defined [23:47:58] the stdlib module uses that class so it must be somewhere in there but I couldn't figure out what that module does that I don't [23:48:34] (the patch does not contain the spec_helper file but I tried to put all sorts of require commands in it locally) [23:49:02] tgr: huh. i'm not super familiar with the puppet specs but i believe they may use some special rspec wrapper to execute. i'll take a look! [23:49:07] anything out of the order going on with gerrit, or it just loves to see me login every hour today? [23:50:12] thanks! don't feel bad about dropping it if it gets time-consuming, the tests aren't doing anything nontrivial, I could omit them [23:50:37] I just figured I'd dot the is and learn something in the process :) [23:51:07] tgr: no worries. you caught me right between tasks, so it's a good opportunity to consume time :) [23:58:46] tgr: ah, my mistake. i thought you were talking about ops/puppet. i see it's mw-vagrant. i don't believe we include puppet specs during `rake test`, only the spec directory for the plugin (lib/). iirc, puppet specs are a little strange and require extra setup/teardown [23:59:17] satisfied by this gem possibly https://github.com/puppetlabs/puppetlabs_spec_helper