[00:00:05] yeah, I think I am doing that part correctly, I just can't figure out how to actually load the gem [00:00:49] I assumed that happens for stdlib but then maybe that's not tested at all? [00:01:49] tgr: i don't think it is. it was likely copied in from ops/puppet, specs and all [00:03:38] uh, yeah, rspec dies for stdlib as well [00:03:51] sorry, I should have checked that [00:04:53] so if I want to fix that, I'll probably have to do something with the rakefile and gemfile in vagrant root? [00:05:27] that I can mostly copy from the ops puppet, probably? [00:06:10] tgr: yes, if you're interested in getting puppet specs running, you could try adding that helper gem to Gemfile or mediawiki_vagrant.gemspec [00:06:43] tgr: hmm, maybe? :) i don't think we ever got ops/puppet specs running correctly either. iirc, it was more trouble than it was worth [00:07:11] they test at a higher level than pure unit tests and were finicky as a result [00:08:46] tgr: i don't want to say "don't bother" but "beware of rabbit holes" :) [00:11:16] otoh, we could really use a handful of integration tests for mw-v that run provision for the most popular roles [01:45:41] (03PS2) 10Reedy: Finish removing MoodBar, including nl.wikipedia [tools/release] - 10https://gerrit.wikimedia.org/r/303575 (https://phabricator.wikimedia.org/T131340) (owner: 10Nemo bis) [01:54:37] (03PS3) 10Reedy: Stop branching MoodBar [tools/release] - 10https://gerrit.wikimedia.org/r/303575 (https://phabricator.wikimedia.org/T131340) (owner: 10Nemo bis) [01:54:42] (03CR) 10Reedy: [C: 032] Stop branching MoodBar [tools/release] - 10https://gerrit.wikimedia.org/r/303575 (https://phabricator.wikimedia.org/T131340) (owner: 10Nemo bis) [02:06:53] (03PS1) 10Legoktm: Make mediawiki-core-php70-phan-jessie voting [integration/config] - 10https://gerrit.wikimedia.org/r/326877 (https://phabricator.wikimedia.org/T132636) [02:06:55] (03PS1) 10MaxSem: Remove MoodBar [integration/config] - 10https://gerrit.wikimedia.org/r/326878 [02:07:17] Reedy, ^ [02:07:22] RIP [02:07:52] how does one remove it from TWN? [02:08:08] Nemo said it already was [02:08:26] (03CR) 10Legoktm: [C: 032] Make mediawiki-core-php70-phan-jessie voting [integration/config] - 10https://gerrit.wikimedia.org/r/326877 (https://phabricator.wikimedia.org/T132636) (owner: 10Legoktm) [02:08:39] huh? [02:09:17] Oh [02:09:24] maybe he means removd from priority stuff as the WMF list [02:09:26] https://github.com/wikimedia/translatewiki/blob/bac1524630241914ae1ad4397e5e908605269043/groups/MediaWiki/mediawiki-extensions.txt [02:09:28] still in there [02:10:01] oh hi [02:10:04] we're talking in here too [02:10:04] (03Merged) 10jenkins-bot: Make mediawiki-core-php70-phan-jessie voting [integration/config] - 10https://gerrit.wikimedia.org/r/326877 (https://phabricator.wikimedia.org/T132636) (owner: 10Legoktm) [02:10:13] Raymond will remove it from TWN after it gets archived [02:10:14] Legion is everywhere. [02:10:21] !log deploying https://gerrit.wikimedia.org/r/326877 [02:10:26] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:10:46] STATIC ANALYSIS FOR EVERYONE [02:11:10] aka ALL YOU CODE IS SHIT [02:11:15] LOLNOYOUCANTDOTHAT [02:11:20] (03Merged) 10jenkins-bot: Stop branching MoodBar [tools/release] - 10https://gerrit.wikimedia.org/r/303575 (https://phabricator.wikimedia.org/T131340) (owner: 10Nemo bis) [02:13:09] https://github.com/wikimedia/translatewiki/blob/master/groups/MediaWiki/mediawiki-extensions.txt#L1-L18 [02:13:10] Hmm [02:13:18] Can I remove Maps and Validator from Gerrit? [02:14:25] Oops, it's not actually voting. [02:15:12] (03PS1) 10Legoktm: Actually add 'mediawiki-core-php70-phan-jessie' to gate... [integration/config] - 10https://gerrit.wikimedia.org/r/326880 (https://phabricator.wikimedia.org/T132636) [02:15:31] (03CR) 10Legoktm: [C: 032] Actually add 'mediawiki-core-php70-phan-jessie' to gate... [integration/config] - 10https://gerrit.wikimedia.org/r/326880 (https://phabricator.wikimedia.org/T132636) (owner: 10Legoktm) [02:16:21] (03Merged) 10jenkins-bot: Actually add 'mediawiki-core-php70-phan-jessie' to gate... [integration/config] - 10https://gerrit.wikimedia.org/r/326880 (https://phabricator.wikimedia.org/T132636) (owner: 10Legoktm) [02:16:44] [02:15:20] (PS1) Reedy: Validator has gone to GitHub [extensions/Validator] - https://gerrit.wikimedia.org/r/326881 [02:16:44] [02:16:36] (PS1) Reedy: Maps has gone to GitHub [extensions/Maps] - https://gerrit.wikimedia.org/r/326882 [02:17:07] !log deploying https://gerrit.wikimedia.org/r/326880 [02:17:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:27:49] 10Continuous-Integration-Infrastructure, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Run etsy/phan from jenkins for MediaWiki core - https://phabricator.wikimedia.org/T132636#2867139 (10Legoktm) 05Open>03Resolved a:03Legoktm [02:42:12] 10Continuous-Integration-Infrastructure, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Run etsy/phan from jenkins for MediaWiki core - https://phabricator.wikimedia.org/T132636#2867143 (10Legoktm) Announced: https://lists.wikimedia.org/pipermail/wikitech-l/2016-Decemb... [02:43:50] 10Continuous-Integration-Config: Remove 3 extensions from CI - https://phabricator.wikimedia.org/T153035#2867144 (10Reedy) [03:01:35] 10Continuous-Integration-Config, 13Patch-For-Review: Combine composer-php55 and composer-hhvm jobs - https://phabricator.wikimedia.org/T142457#2867158 (10Legoktm) Wait, I'm confused. The composer-hhvm-trusty jobs are still on trusty, so it has HHVM installed...right? [04:18:40] Yippee, build fixed! [04:18:41] Project selenium-MultimediaViewer » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #232: 09FIXED in 22 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/232/ [05:48:08] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2867234 (10KartikMistry) p:05Triage>03High [05:55:05] 10Gerrit, 06translatewiki.net, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5: fatal: Project not found: mediawiki/extensions/url - https://phabricator.wikimedia.org/T152727#2867236 (10Nikerabbit) [06:16:09] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2867243 (10santhosh) Tests pass in our test instance cx2.wmflabs.org/index.php?title=Special:JavascriptTest too. [06:33:21] Project selenium-Wikibase » chrome,test,Linux,contintLabsSlave && UbuntuTrusty build #206: 04FAILURE in 1 hr 53 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=test,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/206/ [07:22:01] 10Continuous-Integration-Config: CI: Support running phan for extensions - https://phabricator.wikimedia.org/T153039#2867258 (10Legoktm) [07:23:01] 10Continuous-Integration-Config, 10CirrusSearch, 06Discovery, 06Discovery-Search: Migrate phan for CirrusSearch to jenkins - https://phabricator.wikimedia.org/T153040#2867270 (10Legoktm) [07:23:29] 10Continuous-Integration-Config: CI: Support running phan for extensions - https://phabricator.wikimedia.org/T153039#2867258 (10Legoktm) I filed T153040 as a subtask, and hopefully resolving that will also give us a framework we can copy for other extensions. [08:04:52] any changes to qunit tests that prevents them from connecting wikipedia? [08:05:00] from continous integration [08:14:05] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2867359 (10Nikerabbit) The ajax calls fail with code `http`and `{responseText: '', status: 0, statusText: 'error'}`. Googling on the internet... [08:14:58] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2867361 (10Nikerabbit) [08:38:12] (03CR) 10Hashar: Support skin as dependencies (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [08:46:25] (03PS19) 10Hashar: Support skin as dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [08:47:09] (03CR) 10Hashar: "I have added way more comments both in zuul/parameter_functions.py and near the JJB macro." [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [08:53:28] (03CR) 10Paladox: [C: 031] "Ah thanks." [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [09:30:27] zeljkof: so for the rspec/webdriver selenium jobs [09:30:41] I got a complicated patch that would let us inject skins/Vector in the job as a dependency [09:30:48] BEFORE MediaWiki install.php kicks in [09:30:58] the issue we have currently is that the skin is cloned after install.php runs [09:31:10] and hence the skin is not injected in LocalSettings.php with a wfLoadSkin( 'Vector' ); [09:31:16] https://gerrit.wikimedia.org/r/#/c/323540/ should enable that [09:31:28] nice [09:31:37] basically it does make Zuul to inject SKIN_DEPENDENCIES=mediawiki/skins/Vector [09:31:49] then we invoke zuul-cloner $EXT_DEPENDENCIES $SKIN_DEPENDENCIES [09:31:52] and after that install.php [09:31:57] so it should work ™ [09:32:04] paladox: ^^:} [09:32:17] I think I am going to deploy it right now [09:32:20] and see what happens [09:32:33] be **bold** [09:34:23] (03PS2) 10Hashar: Remove MoodBar [integration/config] - 10https://gerrit.wikimedia.org/r/326878 (owner: 10MaxSem) [09:34:39] (03CR) 10Hashar: [C: 032] "Thanks! And it is already marked read-only in Gerrit \O/" [integration/config] - 10https://gerrit.wikimedia.org/r/326878 (owner: 10MaxSem) [09:35:28] (03Merged) 10jenkins-bot: Remove MoodBar [integration/config] - 10https://gerrit.wikimedia.org/r/326878 (owner: 10MaxSem) [09:36:27] Thank God that is gone [09:36:30] So long [09:38:50] (03PS20) 10Hashar: Support skin as dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [09:39:24] (03PS2) 10Hashar: Inject skin/ext dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/326469 (https://phabricator.wikimedia.org/T151593) [09:39:30] (03CR) 10Hashar: [C: 032] Inject skin/ext dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/326469 (https://phabricator.wikimedia.org/T151593) (owner: 10Hashar) [09:39:34] (03CR) 10Hashar: [C: 032] Support skin as dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [09:42:00] * hashar !log Updating MediaWiki Jenkins jobs to support injecting skin dependencies T151593 [09:42:02] !log Updating MediaWiki Jenkins jobs to support injecting skin dependencies T151593 [09:42:04] spammm [09:42:16] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:42:18] (03Merged) 10jenkins-bot: Support skin as dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [09:42:20] (03Merged) 10jenkins-bot: Inject skin/ext dependencies [integration/config] - 10https://gerrit.wikimedia.org/r/326469 (https://phabricator.wikimedia.org/T151593) (owner: 10Hashar) [09:46:28] oh [09:46:30] that pass [09:47:22] paladox: so the tests for the skin BlueSpiceSkin pass now!!! https://gerrit.wikimedia.org/r/#/c/323201/1 [09:53:57] Fatal error: Uncaught exception 'Exception' with message 'It was attempted to load CustomPage twice, from /home/jenkins/workspace/mwext-testextension-hhvm-jessie-non-voting/src/skins/CustomPage/skin.json and /home/jenkins/workspace/mwext-testextension-hhvm-jessie-non-voting/src/extensions/CustomPage/extension.json. [09:54:02] aorhgghghg [10:07:38] (03PS1) 10Hashar: [BlueSpiceSkin] make tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/326914 (https://phabricator.wikimedia.org/T151593) [10:07:46] paladox: ^^^^:} [10:11:33] (03PS1) 10Hashar: [CustomPage] give reasons for non-voting jobs [integration/config] - 10https://gerrit.wikimedia.org/r/326916 (https://phabricator.wikimedia.org/T151593) [10:12:04] (03CR) 10Hashar: [C: 032] [BlueSpiceSkin] make tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/326914 (https://phabricator.wikimedia.org/T151593) (owner: 10Hashar) [10:12:21] (03CR) 10Hashar: [C: 032] [CustomPage] give reasons for non-voting jobs [integration/config] - 10https://gerrit.wikimedia.org/r/326916 (https://phabricator.wikimedia.org/T151593) (owner: 10Hashar) [10:13:13] 10Continuous-Integration-Config, 13Patch-For-Review: Add support for skin and extension dependencies in new skin unit test - https://phabricator.wikimedia.org/T151593#2867621 (10hashar) 05Open>03Resolved a:03hashar mediawiki/skins/BlueSpiceSkin pass and the job is now voting. mediawiki/extensions/Custom... [10:13:23] (03Merged) 10jenkins-bot: [BlueSpiceSkin] make tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/326914 (https://phabricator.wikimedia.org/T151593) (owner: 10Hashar) [10:13:25] (03Merged) 10jenkins-bot: [CustomPage] give reasons for non-voting jobs [integration/config] - 10https://gerrit.wikimedia.org/r/326916 (https://phabricator.wikimedia.org/T151593) (owner: 10Hashar) [10:17:28] 10Continuous-Integration-Config, 10BlueSky, 13Patch-For-Review: Fix structure tests for all skins - https://phabricator.wikimedia.org/T113860#2867802 (10hashar) CI now supports injecting skins as dependencies to an extension or extension as a dependency to a skin (was T151593). That will help fix a few cases... [10:23:48] zeljkof: on which job/Change did you need skins/Vector to be added? [10:23:52] I got lost [10:24:16] hashar: all of them! 😜 [10:24:16] let me check [10:25:06] mediawiki-core-selenium-jessie [10:55:29] ahh [10:56:17] but [10:56:21] it has vector! [10:57:10] ah no [10:57:21] I guess I wanted us to reuse the macro prepare-mediawiki-zuul-project [11:15:58] (03PS1) 10Hashar: Reuse macro in mediawiki-core-selenium-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/326922 (https://phabricator.wikimedia.org/T139740) [11:17:29] zeljkof: https://gerrit.wikimedia.org/r/#/c/326922/ :} [11:18:08] there is another similar job but I can't remember which [11:18:17] maybe that is the Echo + rspec one [11:18:27] I think it failed due to a missing Vector skin [11:18:33] (03CR) 10Zfilipin: [C: 031] Reuse macro in mediawiki-core-selenium-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/326922 (https://phabricator.wikimedia.org/T139740) (owner: 10Hashar) [11:18:49] hashar: nice! [11:18:56] no rspec one does not need skin [11:18:57] it is a bit hacky [11:19:03] the SKIN_DEPENDENCY is passed directly int he job [11:19:07] too lazy to refactor more [11:19:09] should work [11:19:19] can't remember, there are probably a few more jobs that need it [11:19:21] you might want to deploy and check whether that works [11:19:34] will do, just a second, in a middle of something else [11:19:42] yeah no worries [11:19:47] will head to lunch soonish eventually [11:20:43] OH [11:20:45] yeah I remember [11:21:00] I have hit that wall months ago when trying to port mwext-mw-selenium to Nodepool [11:21:12] since they have a fresh workspace, the Vector skin is not present when install.php is run [11:21:23] but on permanent slaves it is around from the previous build [11:21:42] lunch lunch [11:22:05] bon apetit hasharLunch [11:48:07] (03CR) 10Zfilipin: "I have deployed the job and ran it, but it fails:" [integration/config] - 10https://gerrit.wikimedia.org/r/326922 (https://phabricator.wikimedia.org/T139740) (owner: 10Hashar) [11:52:54] (03CR) 10Zfilipin: "Nevermind, worked the second time. The problem was a timeout." [integration/config] - 10https://gerrit.wikimedia.org/r/326922 (https://phabricator.wikimedia.org/T139740) (owner: 10Hashar) [11:53:59] (03CR) 10Zfilipin: "All green: https://integration.wikimedia.org/ci/job/mediawiki-core-selenium-jessie/12/console" [integration/config] - 10https://gerrit.wikimedia.org/r/326922 (https://phabricator.wikimedia.org/T139740) (owner: 10Hashar) [11:54:01] (03CR) 10Zfilipin: [C: 032] Reuse macro in mediawiki-core-selenium-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/326922 (https://phabricator.wikimedia.org/T139740) (owner: 10Hashar) [11:54:49] what is happening with wikibase? a lot of ci jobs are running https://integration.wikimedia.org/zuul/ [11:55:11] (03Merged) 10jenkins-bot: Reuse macro in mediawiki-core-selenium-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/326922 (https://phabricator.wikimedia.org/T139740) (owner: 10Hashar) [12:05:26] hasharLunch: I have remembered, I needed Vector for this patch :) https://gerrit.wikimedia.org/r/#/c/326117/ [12:33:14] * zeljkof is out of lunch [12:39:36] zeljkof: 6 Wikibase changes have been sent simultaneously .. so that is a few jobs to run :} [12:39:43] will look at "Set up Selenium tests" https://gerrit.wikimedia.org/r/#/c/326117/ [13:01:16] hashar: I'm working on Kartographer+core tests [13:02:10] I can run them separately on my machine, but can not run Kartographer tests via npm from core :| 😦 [13:17:01] got a patch for core ? [13:17:53] ah https://gerrit.wikimedia.org/r/#/c/323401/ maybe [13:22:18] Error: Could not locate Firefox on the current system [13:22:19] :D [13:26:01] :D [13:26:07] you can switch to chrome [13:30:40] yeah doing so [13:30:47] had to fix up my mediawiki setup first [13:31:44] SessionNotCreatedError: session not created exception [13:31:44] from unknown error: bad inspector message: {"method":"Page.loadEventFired","params":{"timestamp":305230,869372}} [13:31:44] (Session info: chrome=54.0.2840.98) [13:31:44] (Driver info: chromedriver=2.24.417412 (ac882d3ce7c0d99292439bf3405780058fcca0a6),platform=Mac OS X 10.11.4 x86_64) [13:31:46] :D [13:32:13] argh [13:32:19] it is not even the chromedriver version I have installed :D [13:32:52] so, running mocha directly from core works fine, running grunt (that calls mocha) works fine, but running npm (that calls grunt, that calls mocha) fails [13:33:14] hashar: you probably understand scap3 better than I do... I'm having trouble with a "reference is not a tree: 2d627..." when trying to deploy tilerator... any idea? [13:33:22] Error: ECONNREFUSED connect ECONNREFUSED 127.0.0.1:57632 [13:33:27] the commit id does exist on tin and on mira... [13:33:52] maybe some tags points to commit that is not locally available? [13:33:58] what is the repo and where do you have that ? [13:34:34] tin.eqid.wmnet:/srv/deployment/tilerator/deploy same issue on all maps* servers [13:36:18] hmm [13:36:33] assuming 2d627 is a commit [13:36:41] that points to the one you did " tilerator - deplyo config with scap3" [13:36:48] $ git branch --contains 2d627 --all [13:36:48] remotes/origin/HEAD -> origin/master [13:36:50] remotes/origin/master [13:36:53] it is not checked out locally aparently [13:37:15] yep, I resetted the repo to keep things clean... [13:37:29] it is there again [13:39:38] also, when doing "scap deploy" from tin, the logs indicates the maps* servers are getting code from mira. I can't find a reference to mira in the scap config of that project [13:40:50] zeljkof: got some of them to pass . Had to change the baseUrl in each of the .js files [13:40:57] my mistake, I can't read, mira is referenced in scap.cfg [13:41:10] hashar: why did you have to change baseUrl? [13:41:18] you don't use vagrant? [13:41:30] so the local wiki was at different url? [13:41:34] gehel: I don't know how the scap.cfg works really. Would have to look at one of the other repos but I guess one wants to use the canonical URL deployment.eqiad.wmnet maybe [13:41:41] zeljkof: yeah [13:42:02] zeljkof: so I guess baseUrl should be settable from the Gruntfile.js [13:42:17] zeljkof: or maybe there is a way to pass it as an option/parameter when doing "npm run selenium" [13:42:27] I'm not sure how can I get a variable from gruntfile to another file :| [13:42:37] will figure it out [13:42:42] hashar: ok, I'll keep looking. Thanks! [13:43:29] gehel: don't you need to git pull on tin ? [13:43:35] oh [13:43:49] I did (and resetted) and did it on mira too [13:44:28] the scap files are a bit of a mess [13:44:39] some references tin.eqiad.wmnet , others deployment.eqiad.wmnet [13:44:58] and mathoid / tolerator reference mira [13:44:58] mathoid/deploy/scap/scap.cfg:git_server: mira.codfw.wmnet [13:45:00] tilerator/deploy/scap/scap.cfg:git_server: mira.codfw.wmnet [13:45:54] yeah, but in the end, they should all resolve to something that make sense... [13:46:10] and /etc/scap.cfg is supposed to give the config for everyone [13:46:12] [wmnet] [13:46:17] master_rsync: deployment.eqiad.wmnet [13:46:28] oh [13:46:30] but lacks a git_server bah [13:46:37] ah no it has it: [13:46:39] [global] [13:46:43] git_server: deployment.eqiad.wmnet [13:47:01] Project selenium-VisualEditor » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #242: 04FAILURE in 3 min 0 sec: https://integration.wikimedia.org/ci/job/selenium-VisualEditor/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/242/ [13:47:04] so take that with a grain of salt, but maybe you don't even need to specify git_server in the repo scap.cfg [13:47:43] I can at least try that. Thanks for the help! [13:47:52] * gehel almost never touches scap3... [13:56:14] hashar: looks like npm uses node_modules folder from Kartographer extension even when I run npm from mw/core folder :| [13:56:22] and somehow that messes things up [13:56:33] hashar: I'll keep digging... the thing is that this deployment worked not long ago, so the problem is probably on my side (damn keyboards and chairs) [13:58:47] hashar: ha, works fine when I delete node_modules folder from Kartographer extension... go figure [13:58:49] lesson learned [14:04:55] zeljkof: it looks like we are fighting a similar mess :) [14:04:57] 10Continuous-Integration-Config, 06Operations, 06Operations-Software-Development, 13Patch-For-Review: tox-jessie is failing on operations/software - https://phabricator.wikimedia.org/T152549#2868835 (10akosiaris) p:05Triage>03Normal [14:05:40] gehel: :D there is always something that goes wrong... [14:08:25] 10MediaWiki-Releasing, 10MediaWiki-Containers, 06Services, 15User-mobrovac: Ready-to-use Docker package for MediaWiki - https://phabricator.wikimedia.org/T92826#1121273 (10Addshore) I just took a look at https://github.com/wikimedia/mediawiki-containers and it seemed to install seemlessly! It seems like gr... [14:35:00] (03PS1) 10Zfilipin: Run mediawiki-core-selenium-jessie in experimental pipeline for Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/326949 (https://phabricator.wikimedia.org/T152683) [14:36:19] hashar: I'm assuming it's ok to self-merge ^ since it is just a job added to experimental pipeline [14:36:53] yeah [14:37:10] specially it just add an existing job to a pipeline [14:37:13] dosent affect jjb [14:37:17] so it is pretty isolated :} [14:37:33] even if it had an impact, you can still self merge [14:37:35] see what happens [14:37:41] (03CR) 10Zfilipin: [C: 032] Run mediawiki-core-selenium-jessie in experimental pipeline for Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/326949 (https://phabricator.wikimedia.org/T152683) (owner: 10Zfilipin) [14:37:44] as long as you babysit the aftermath, we should be fine :} [14:37:59] +2d, will test and revert if needed [14:38:57] (03Merged) 10jenkins-bot: Run mediawiki-core-selenium-jessie in experimental pipeline for Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/326949 (https://phabricator.wikimedia.org/T152683) (owner: 10Zfilipin) [14:48:22] hashar: the experiment is working :) but the test are failing :( https://integration.wikimedia.org/ci/job/mediawiki-core-selenium-jessie/16/testReport/ [14:49:11] zeljkof: so that is running "npm run selenium" from mediawiki/core and discover the tests via extensions/*/tests/selenium/**/*.js is it ? [14:49:33] any clue why the build has neither video nor screenshots on https://integration.wikimedia.org/ci/job/mediawiki-core-selenium-jessie/16/#showFailuresLink ? [14:49:37] I guess we don't record them yet? [14:50:09] or maybe it doesn't hit the proper URL [14:50:10] hashar: yes, npm run selenium from core [14:50:31] no screenshots or videos yet, since we do not capture anything [14:50:35] but it should be easy to add [14:50:52] rebuilding, sometimes it helps, to make sure [14:51:30] Start request GET /jenkins-mediawiki-core-selenium-jessie-16/load.php?.... [14:51:35] REFERER: http://localhost:9412/jenkins-mediawiki-core-selenium-jessie-16/index.php?title=Special:Preferences [14:51:40] so seems the proper site is hit [14:52:06] then [14:52:23] in the console log, after the install.php we do a curl to Special:BlankPage [14:52:31] and somewhere in the HTML: 00:00:23.466

Whoops! The default skin for your wiki, defined in $wgDefaultSkin as vector, is not available. [14:52:35] so Vector is not enabled :( [14:52:58] it is not cloned by zuul-cloner bah [14:53:09] wait, what? how come? since the most of the tests pass... [14:53:20] in rebuild, only one fails https://integration.wikimedia.org/ci/job/mediawiki-core-selenium-jessie/17/testReport/ [14:54:09] yeah build 17 has the dependency [14:54:37] have you triggered 17 by hitting "rebuild" ? [14:54:42] yes [14:54:59] so, rebuild works fine, but not the initial build?! [14:55:02] wat? [14:55:09] ah yeah [14:55:18] how is that possible, isn't it reusing all settings [14:55:23] so rebuild get SKIN_DEPENDENCIES applied by Jenkins [14:55:34] really? but not the original [14:55:34] but when the job is triggered by Zuul, it is not set [14:55:37] bhah [14:55:52] I guess what happens is Zuul trigger the job with a set of parameters [14:55:59] and the Gearman plugin on Jenkins run the build with those [14:56:06] and does not merge in the default parameter in the jenkins job [14:56:28] (the parameters: - string: SKIN_DEPENDENCY - default: mediawiki/extensions/Vector [14:56:31] so my patch is wrong [15:00:50] 10MediaWiki-Releasing, 10MediaWiki-Containers, 06Services, 15User-mobrovac: Ready-to-use Docker package for MediaWiki - https://phabricator.wikimedia.org/T92826#2868985 (10GWicke) Currently, the docker images themselves are not yet very flexible, and not really optimized for a stand-alone install. I create... [15:01:54] hashar: you lost me at gearman :D [15:07:38] ;D [15:07:56] zeljkof: Zuul trigger the job using something like: parameters: { 'ZUUL_PROJECT': 'mediawiki/core' } [15:08:11] it does not set the SKIN_DEPENDENCIES variable for that job/repo [15:08:20] thus the job is triggered without SKIN_DEPENDENCIES set [15:08:27] hm [15:08:31] whose content is passed to zuul-cloner [15:08:48] I thought that adding a parameter SKIN_DEPENDENCIES inside the Jenkins job would have it set [15:08:59] but Zuul/Gearman plugin does not merge the default parameters from the job [15:09:04] it just override the whole set of params [15:09:07] so my change was wrong [15:09:31] that part https://gerrit.wikimedia.org/r/#/c/326922/1/jjb/mediawiki.yaml [15:09:32] instead [15:09:41] please add to CI 2.0 proposal that it needs to be reproducible at local machine :) [15:09:49] we need a way to test these things locally [15:10:02] when the job name is mediawiki-core-selenium-jessie we want Zuul to inject SKIN_DEPENDENCIES=mediawiki/skins/Vector [15:10:15] yeah [15:10:45] * zeljkof is brb [15:11:54] hashar: any odd qunit stuff going on right now? [15:12:01] or any change with jenkins qunit in the past days? [15:13:15] addshore: I deployed some nasty change early this morning [15:13:23] zeljkof: will rethink it after a break [15:13:31] addshore: what is falling ? [15:13:35] hmm, okay, the failures started before then [15:13:42] https://gerrit.wikimedia.org/r/#/c/326533/ [15:13:48] happened on 2 other patches first [15:14:39] ext.RevisionSlider.RevisionListView tooltip is composed correctly with en lang FAILED [15:14:40] Test the page size. [15:14:40] 00:01:46.039 Expected: true [15:14:40] 00:01:46.039 Actual: null [15:14:44] who knows :( [15:15:00] that RevisionSlider just depends on core/BetaFeatures [15:15:05] maybe it is a regression in core [15:15:16] oh, tests pass lcoally ;) [15:15:25] 00:01:46.050 Expected: "+1,000" [15:15:26] 00:01:46.050 Actual: "+1.000" [15:15:28] eeeek [15:15:33] I have seen that at some point [15:15:33] hmm, but yeh, maybe not with updated core and BF [15:17:02] BetaFeatures just have l10n-bot changes https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/BetaFeatures [15:17:47] 10Gerrit, 10BlueSpice: Gerrit sumit error - https://phabricator.wikimedia.org/T153079#2869000 (10Osnard) [15:20:23] off for a few [15:24:42] 10Gerrit, 06translatewiki.net, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, 07Unplanned-Sprint-Work: fatal: Project not found: mediawiki/extensions/url - https://phabricator.wikimedia.org/T152727#2858236 (10Nikerabbit) a:05Raymond>03Nikerabbit [15:25:23] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 2 others: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2869041 (10Nikerabbit) [15:25:36] 10Gerrit, 10BlueSpice: Gerrit sumit error - https://phabricator.wikimedia.org/T153079#2869043 (10Aklapper) How did you try to merge and what are the steps to reproduce this? Can you post the entire commands + output involved here? [15:29:23] zeljkof: gotta fix the zuul parameter function [15:32:18] hashar: the patches for core and kartographer are ready for testing :) [15:34:42] neat [15:34:49] for SKIN_DEPENDENCIES [15:34:53] we need to fix zuul parameter function [15:35:08] so that for that specific job we need to add Vector as well [15:35:21] and catch the case where other dependencies have been added before or added before [15:35:25] not so hard to do [15:35:31] but will not have time to fix it up this evening sorry :/ [15:36:46] no rush [15:37:01] can wait until tomorrow morning ;) [15:37:25] yeah poke me tomorrow first thing [15:37:37] should not be too hard [15:37:46] and we can even have a test to assert it is working fine [15:39:49] PROBLEM - Puppet run on deployment-phab02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:46:33] hashar hi, thanks for merging my patches and sorry for late reply, been out all day though i have been on my phone just not on irc :) [15:47:51] 10Gerrit, 10BlueSpice: Gerrit sumit error - https://phabricator.wikimedia.org/T153079#2869121 (10Osnard) I was using the web interface of gerrit. I gave +2 in Code Review. After it got not merged automatically I tryied the "Submit" button manually. The a popup window with the error message shows up. [16:07:58] (03PS1) 10Hoo man: Update Wikidata to the wmf/1.29.0-wmf.6 branch [tools/release] - 10https://gerrit.wikimedia.org/r/326983 [16:15:38] hashar: so those qunit tests pass localy with old & new version of both BF and core :/ [16:15:44] any other ideass?? [16:33:25] 10Gerrit: Gerrit doesn't display committed images - https://phabricator.wikimedia.org/T153085#2869243 (10Niedzielski) [16:41:52] addshore: sorry not :((( [16:42:02] addshore: i sometime look at the history of builds via https://integration.wikimedia.org/ci/job/mwext-qunit-jessie/buildTimeTrend [16:42:10] try to find out when they started failling [16:42:17] or try to find whether the failures have something in common [16:42:46] Yeh, ill try digging into it a bit laterr! [16:43:18] eg the last two failures are for UploadWizard and RevisionSlider [16:43:46] but they have different errors apparently [16:43:49] so that doesn't help much [16:44:18] one sure thing, https://gerrit.wikimedia.org/r/#/c/326533/ is not at fault (: [16:44:41] 10Continuous-Integration-Config, 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint: CI tests on wikimedia/portals repo: cache node_modules to save time - https://phabricator.wikimedia.org/T152386#2869329 (10debt) [16:45:20] 10Continuous-Integration-Config, 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint: wikimedia/portals repo might be using outdated and or deprecated tests in jenkins - https://phabricator.wikimedia.org/T152351#2869330 (10debt) [16:46:03] addshore: maybe fill a task about your finding, stating you can't repro locally [16:46:18] maybe others had a related issue. I noticed a few failing qunit jobs yesterday [16:46:37] sorry that is not very helpful :( [16:46:47] :D [16:47:37] addshore: what would be nice is to find out whether karma can capture more logs like the console but maybe it does already [16:48:22] there are some i18n related errors [16:48:26] 00:02:30.308 Expected: "+1,000" [16:48:28] 00:02:30.308 Actual: "+1.000" [16:48:32] pretty sure I have seen that a few days ago [16:48:56] maybe it is an error related to Chrome 53 [16:49:06] lot of moving parts :( Anyway sorry I gotta rush [16:51:03] 10Gerrit, 10BlueSpice: Merge/Submit error on Gerrit: "org.eclipse.jgit.errors.MissingObjectException: Missing unknown" - https://phabricator.wikimedia.org/T153079#2869382 (10Aklapper) [17:21:10] 10Gerrit, 10BlueSpice: Merge/Submit error on Gerrit: "org.eclipse.jgit.errors.MissingObjectException: Missing unknown" - https://phabricator.wikimedia.org/T153079#2869496 (10Paladox) I'm wondering is this a bug in jgit or gerrit needing a reindex? [17:21:11] ostriches ^^ [17:27:33] 10Gerrit, 10BlueSpice: Merge/Submit error on Gerrit: "org.eclipse.jgit.errors.MissingObjectException: Missing unknown" - https://phabricator.wikimedia.org/T153079#2869000 (10demon) Neither, it's probably the gc issue still being around... [17:38:16] 10Gerrit: Gerrit doesn't display committed images - https://phabricator.wikimedia.org/T153085#2869243 (10Paladox) Hi see https://bugs.chromium.org/p/gerrit/issues/detail?id=3822 according to that the fix is released, but I haven't found a patch yet. [17:38:24] 10Gerrit, 07Upstream: Gerrit doesn't display committed images - https://phabricator.wikimedia.org/T153085#2869556 (10Paladox) [17:39:08] does anyone know what https://integration.wikimedia.org/ci/view/Mobile/job/mwext-MobileFrontend-npm-run-lint-modules/ is for? [17:49:19] 10Continuous-Integration-Config, 10MediaWiki-extensions-ContentTranslation, 05Language-Engineering October-December 2016, 03Language-Q2-2016-17 Sprint 5, and 2 others: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2869603 (10hashar) @addshore that is the quni... [17:52:03] 10Continuous-Integration-Infrastructure, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): Run etsy/phan from jenkins for MediaWiki core - https://phabricator.wikimedia.org/T132636#2869613 (10greg) \o/ [17:56:54] 10Beta-Cluster-Infrastructure, 10VisualEditor: Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869638 (10Ryasmeen) [18:22:17] 10Beta-Cluster-Infrastructure, 10RESTBase, 10VisualEditor: Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869746 (10AlexMonk-WMF) [18:23:27] 10Beta-Cluster-Infrastructure, 10RESTBase, 10VisualEditor: Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869638 (10AlexMonk-WMF) https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/User%3ARYasmeen_(... [18:24:29] 10Beta-Cluster-Infrastructure, 10Parsoid, 10VisualEditor, 06Services (watching): Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869755 (10Pchelolo) According to the logs it's a #parsoid problem: ``` Cannot... [18:26:01] Dec 13 18:06:54 deployment-restbase01 java[30846]: Error: Could not find or load main class org.wikimedia.cassandra.metrics.service.Service [18:26:01] Dec 13 18:06:54 deployment-restbase01 systemd[1]: cassandra-metrics-collector.service: main process exited, code=exited, status=1/FAILURE [18:26:04] just found this in syslog [18:26:12] 10Beta-Cluster-Infrastructure, 10Parsoid, 10VisualEditor, 06Services (watching): Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500" - https://phabricator.wikimedia.org/T153101#2869757 (10ssastry) p:05Triage>03Normal a:03Legoktm [18:26:44] while looking at the ticket above [18:27:04] same on 02 [18:27:15] it's triggered by Dec 13 18:26:21 deployment-restbase02 puppet-agent[5301]: (/Stage[main]/Cassandra::Metrics/Base::Service_unit[cassandra-metrics-collector]/Service[cassandra-metrics-collector]/ensure) ensure changed 'stopped' to 'running' [19:12:25] Hmm, it looks like the unit tests are broken on REL1_27? https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/1145/console [19:14:52] PROBLEM - Puppet run on integration-slave-jessie-1002 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [19:19:27] RoanKattouw: yes, TMH I think [19:19:31] PROBLEM - Puppet run on deployment-pdfrender02 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [19:19:35] PROBLEM - Puppet run on deployment-elastic06 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [19:22:13] PROBLEM - Puppet run on deployment-zotero01 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [19:25:52] heya, how do we get a repository mirroed to github again? [19:26:00] looking in puppet...but maybe itis not there [19:26:18] would like this mirrored: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/services/eventstreams [19:26:29] ottomata: Create a blank one [19:26:33] Do you have the rights? [19:26:37] i think so lemme try [19:26:59] if you create the right name on github, and give it a few mins usually [19:27:18] ookey dokey: will wait [19:27:18] https://github.com/wikimedia/mediawiki-services-eventstreams [19:27:38] I think you need to push a commit to gerrit and it'll update in github [19:28:04] or that [19:30:16] PROBLEM - Puppet run on deployment-sentry01 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [19:33:08] PROBLEM - Puppet run on deployment-ircd is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [19:33:26] PROBLEM - Puppet run on deployment-secureredirexperiment is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [19:34:13] PROBLEM - Puppet run on deployment-memc04 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [19:35:19] PROBLEM - Puppet run on deployment-tmh01 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [19:42:50] 10Gerrit, 07Regression, 07Upstream: Gerrit doesn't display committed images - https://phabricator.wikimedia.org/T153085#2870134 (10Aklapper) [19:48:04] 10Gerrit, 07Upstream: Commenting on a merged patch does not send the notification to irc - https://phabricator.wikimedia.org/T152932#2870154 (10Paladox) @demon I tested stream-events + a test bot with gerrit.git.wmflabs.org and commenting on a merged change works there. Strange that it dosent work on prod. Co... [19:49:09] 10Gerrit, 07Upstream: Commenting on a merged patch does not send the notification to irc - https://phabricator.wikimedia.org/T152932#2870160 (10Paladox) Pro stream-event {"author":{"name":"Paladox","email":"thomasmulhall410@yahoo.com","username":"paladox"},"comment":"Patch Set 20:\n\ntest","patchSet":{"number... [19:54:53] RECOVERY - Puppet run on integration-slave-jessie-1002 is OK: OK: Less than 1.00% above the threshold [0.0] [19:57:13] RECOVERY - Puppet run on deployment-zotero01 is OK: OK: Less than 1.00% above the threshold [0.0] [19:59:31] RECOVERY - Puppet run on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0] [19:59:35] RECOVERY - Puppet run on deployment-elastic06 is OK: OK: Less than 1.00% above the threshold [0.0] [20:08:09] RECOVERY - Puppet run on deployment-ircd is OK: OK: Less than 1.00% above the threshold [0.0] [20:08:25] RECOVERY - Puppet run on deployment-secureredirexperiment is OK: OK: Less than 1.00% above the threshold [0.0] [20:09:15] RECOVERY - Puppet run on deployment-memc04 is OK: OK: Less than 1.00% above the threshold [0.0] [20:10:17] RECOVERY - Puppet run on deployment-sentry01 is OK: OK: Less than 1.00% above the threshold [0.0] [20:10:21] RECOVERY - Puppet run on deployment-tmh01 is OK: OK: Less than 1.00% above the threshold [0.0] [20:11:17] 10Gerrit, 07Upstream: Commenting on a merged patch does not send the notification to irc - https://phabricator.wikimedia.org/T152932#2870305 (10Paladox) Never mind, tested this change https://phabricator.wikimedia.org/R1982:b34fc5c35c133cf1298ef2c5b9f54c22e86fd206 and that broke it. [20:11:53] Krenair hi, this https://phabricator.wikimedia.org/R1982:b34fc5c35c133cf1298ef2c5b9f54c22e86fd206 change broke commits that are merged what i mean is when you comment on a change that is merge it no longer sends a notifications to irc. [20:12:04] i've tested with a test bot with and without the change [20:14:09] with the change, i doint receive any notifications on merged changes on irc without the change i do [20:15:19] paladox, do you get any errors on the console? [20:15:25] Nope [20:15:42] from looking at the commit I see a potential issue where ret.approvals doesn't get set but we try to put it through Object.keys anyway [20:16:02] I don't really have time to debug this right now [20:16:05] Oh [20:16:06] ok [20:16:10] If you don't either, feel free to revert the patch [20:16:36] Ok, i will try some changes first and if they doint work i will revert. [20:16:37] :) [20:16:42] ok [20:34:52] 10Continuous-Integration-Config, 10Revision-Slider, 06TCB-Team, 15User-Addshore: Apparent random failing of RevisionSlider qunit tests - https://phabricator.wikimedia.org/T153121#2870404 (10Addshore) [20:35:08] 10Continuous-Integration-Config, 10Revision-Slider, 06TCB-Team, 15User-Addshore, 03WMDE-QWERTY-Team-Board: Apparent random failing of RevisionSlider qunit tests - https://phabricator.wikimedia.org/T153121#2870417 (10Addshore) [20:42:34] 10Continuous-Integration-Config, 10Revision-Slider, 06TCB-Team, 15User-Addshore, 03WMDE-QWERTY-Team-Board: Apparent random failing of RevisionSlider qunit tests - https://phabricator.wikimedia.org/T153121#2870443 (10Addshore) [20:56:10] (03PS1) 10Yurik: Added Scribunto as a Kartographer dep [integration/config] - 10https://gerrit.wikimedia.org/r/327048 [20:56:38] hi, could someone plz update ^ [20:56:49] trying to build a patch for SWAT today [20:57:31] (03CR) 10Paladox: [C: 031] Added Scribunto as a Kartographer dep [integration/config] - 10https://gerrit.wikimedia.org/r/327048 (owner: 10Yurik) [20:57:35] (03CR) 10jenkins-bot: [V: 04-1] Added Scribunto as a Kartographer dep [integration/config] - 10https://gerrit.wikimedia.org/r/327048 (owner: 10Yurik) [20:59:42] (03PS2) 10Yurik: Added Scribunto as a Kartographer dep [integration/config] - 10https://gerrit.wikimedia.org/r/327048 [21:00:14] broke the line into two. Krenair, I forgot if you are the one pushing those, or if its paladox ? [21:00:31] CI changes? [21:00:36] I don't do those [21:00:39] I probably could, but [21:00:40] Hi, i doint have access to those. [21:00:44] there are only so many hours in the day [21:01:27] I can only +1, releng could but i doint know which ones can do it except from hashar. ostriches twentyafterfour thcipriani? [21:01:47] I dunno how. [21:02:42] ostriches https://www.mediawiki.org/wiki/Continuous_integration/Zuul [21:03:15] I don't know how to read documentation either [21:03:32] ostriches zuul-server -c /etc/zuul/zuul.conf -l /etc/zuul/wikimedia/zuul/layout.yaml -t [21:03:51] you have to merge the change, then you git pull, then you run ^^ [21:04:14] Pasting documentation here doesn't teach me how to read it ;-) [21:05:53] * thcipriani updates zuul [21:06:52] yurik: I think you may be missing a comma [21:08:10] (03CR) 10Paladox: Added Scribunto as a Kartographer dep (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/327048 (owner: 10Yurik) [21:09:04] (03PS3) 10Yurik: Added Scribunto as a Kartographer dep [integration/config] - 10https://gerrit.wikimedia.org/r/327048 [21:09:53] yup, looks good now [21:10:19] dependency would have been 'VisualEditorWikimediaMessages' :) [21:10:39] thcipriani, you want me to alter it, or you want to do it? [21:11:01] (03CR) 10Thcipriani: [C: 032] Added Scribunto as a Kartographer dep (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/327048 (owner: 10Yurik) [21:11:05] looked fine to me now [21:11:52] (03Merged) 10jenkins-bot: Added Scribunto as a Kartographer dep [integration/config] - 10https://gerrit.wikimedia.org/r/327048 (owner: 10Yurik) [21:13:28] thx [21:15:52] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/327048 [21:15:56] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:16:38] yurik: should be deployed now ^ [21:26:14] Krenair the v 0 and c 0 were intentional https://gerrit-review.googlesource.com/#/c/71051/ [21:26:27] im wondering weather we should use oldValue [21:38:05] Krenair ive found a fix [21:41:31] 10Gerrit: Some "(Diffusion)" links missing or broken after upgrade - https://phabricator.wikimedia.org/T153130#2870706 (10greg) [21:42:13] https://gerrit.wikimedia.org/r/#/c/327072/ [21:43:46] 10Gerrit: Some "(Diffusion)" links missing or broken after upgrade - https://phabricator.wikimedia.org/T153130#2870706 (10Paladox) @greg could you paste the link (diffusion) link that is broken please? I think I fixed it in https://gerrit.wikimedia.org/r/#/c/326163/ [21:45:47] 10Gerrit: Some "(Diffusion)" links missing or broken after upgrade - https://phabricator.wikimedia.org/T153130#2870727 (10greg) @Paladox Did you try the two at the top of the linked reference I gave in my original report? https://gerrit.wikimedia.org/r/#/c/326543/1/make-wmf-branch/MakeWmfBranch.php [21:46:15] 10Gerrit: Some "(Diffusion)" links missing or broken after upgrade - https://phabricator.wikimedia.org/T153130#2870730 (10Paladox) oh yep that's fixed by https://gerrit.wikimedia.org/r/#/c/326163/ [21:49:29] 10Gerrit, 13Patch-For-Review: Some "(Diffusion)" links missing or broken after upgrade - https://phabricator.wikimedia.org/T153130#2870737 (10Paladox) @greg ^^ that fixes the link on the right but the link on the left is a bug in gerrit as it seems that it is encoding it. https://phabricator.wikimedia.org/r/p... [22:05:53] (03CR) 10Paladox: "test" [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [22:06:05] Yay it works now. [22:06:19] 10Gerrit, 13Patch-For-Review, 07Upstream: Commenting on a merged patch does not send the notification to irc - https://phabricator.wikimedia.org/T152932#2870818 (10Paladox) 05Open>03Resolved a:03Paladox [22:11:06] ^ ive never thought about that before [22:11:10] Good work paladox [22:11:41] :) [22:33:47] thcipriani, something's not working right - https://gerrit.wikimedia.org/r/#/c/326906 [22:35:29] yurik: Did it before? [22:35:33] Does it depend on Scribunto? [22:35:34] Reedy, nopeee [22:35:36] yep [22:35:44] which is weird, because it passed the tests before [22:36:22] i just added scribunto to the list of deps [22:36:27] oooh, wait [22:36:34] i'm an idiot, i added dep to the kartographer [22:36:35] It's not in https://github.com/wikimedia/integration-config/blob/53d88f506fdd2440e31c5eb5ef092010c6848afc/zuul/parameter_functions.py [22:37:01] After line 103... [22:37:02] 'Capiunto': ['Scribunto'], [22:37:04] You need one of those [22:37:20] I see things depend on JsonConfig, but JsonConfig doesn't depend on anything else [22:37:56] (03PS1) 10Yurik: Added Scribunto to JsonConfig instead of Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/327119 [22:38:03] Reedy, ^ [22:38:09] weird why it passed before [22:38:17] lol [22:39:32] Reedy, did we get a ticket for the l10nupdate issue? [22:39:40] (03CR) 10jenkins-bot: [V: 04] Added Scribunto to JsonConfig instead of Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/327119 (owner: 10Yurik) [22:39:41] Krenair: What l10nupate issue? [22:39:45] Did my widgets change break it? [22:39:49] If so, it's easy to fix [22:39:57] no there was some scap bug [22:39:59] thcipriani? [22:40:20] there is a bug [22:40:22] * thcipriani looks [22:41:08] https://phabricator.wikimedia.org/T152390 [22:41:18] auto-closed with merging of commit [22:41:39] right, and that wasn't deployed to prod yet? [22:41:58] 10Gerrit, 13Patch-For-Review: Some "(Diffusion)" links missing or broken after upgrade - https://phabricator.wikimedia.org/T153130#2870994 (10Paladox) Actually that patch fixes both sides so ignore ^^ that comment. [22:42:29] nope, not deployed yet. Feel free to reopen for tracking. [22:42:55] 03Scap3: scap sync-l10n AttributeError: 'Namespace' object has no attribute 'message' - https://phabricator.wikimedia.org/T152390#2870996 (10Krenair) 05Resolved>03Open not deployed yet, l10nupdate is still broken [22:42:59] done [22:47:35] thcipriani, could you do the https://gerrit.wikimedia.org/r/#/c/327119/ [22:47:43] i added it to the wrong project :( [22:47:58] sure [22:50:08] (03CR) 10Thcipriani: [C: 032] Added Scribunto to JsonConfig instead of Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/327119 (owner: 10Yurik) [22:50:13] (03CR) 10jenkins-bot: [] Added Scribunto to JsonConfig instead of Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/327119 (owner: 10Yurik) [22:50:55] (03CR) 10jenkins-bot: [V: 04] Added Scribunto to JsonConfig instead of Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/327119 (owner: 10Yurik) [22:50:57] (03Merged) 10jenkins-bot: Added Scribunto to JsonConfig instead of Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/327119 (owner: 10Yurik) [22:52:14] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/327119 [22:52:17] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:52:39] yurik: should be live now [22:53:14] thanks thcipriani ! [22:56:21] What the hell did my grrrit-wm change go thru? [22:57:07] You did to click publish if you do it through gerrit's inline edit. [22:58:52] thcipriani, nope :( https://gerrit.wikimedia.org/r/#/c/326906/ [22:59:19] zed iz borked [22:59:47] hrm [23:00:57] Its ok now [23:01:12] It didnt get the request to publish for some reason [23:01:15] Anway brb [23:02:26] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [23:13:32] thcipriani, any thoughts? [23:13:45] yurik: looking at the job, got the dependency right: https://integration.wikimedia.org/ci/job/mwext-testextension-php55/29674/parameters/ [23:13:55] checkout ext_dependencies there [23:15:05] thcipriani, yeah, its there, but its failing to run in prod, even though it works :D [23:18:33] hrm, looks like there are two failing tests: JsonConfig\Tests\JCTabularContentTest::testLuaTabDataReindexing and JsonConfig\Tests\JCTabularContentTest::testLuaTabDataReindexing [23:21:50] (03CR) 10Paladox: "test" [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [23:22:13] thcipriani, i was looking at https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/1185/console -- it still claims the base class is missing [23:22:41] i didn't look at the tests because i thought it was still broken [23:23:47] ah [23:28:23] so it looks like, mediawiki-extensions jobs use gatedextensions as dependencies [23:28:28] https://github.com/wikimedia/integration-config/blob/master/zuul/parameter_functions.py#L291 [23:28:34] vs https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/1185/parameters/ [23:28:39] ext_dependencies [23:29:53] I have no idea why :( [23:42:01] I doint see the repo scribunto cloned in [23:42:05] https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/1185/consoleFull [23:42:13] 'mediawiki/extensions/AbuseFilter\nmediawiki/extensions/Babel\nmediawiki/extensions/Cards\nmediawiki/extensions/CheckUser\nmediawiki/extensions/CirrusSearch\nmediawiki/extensions/Cite\nmediawiki/extensions/ConfirmEdit\nmediawiki/extensions/Echo\nmediawiki/extensions/Elastica\nmediawiki/extensions/EventLogging\nmediawiki/extensions/Flow\nmediawiki/extensions/GeoData\nmediawiki/extensions/GlobalCssJs\nmediawiki/extensions/GuidedTour\nmediawiki/ [23:42:13] extensions/JsonConfig\nmediawiki/extensions/MobileApp\nmediawiki/extensions/MobileFrontend\nmediawiki/extensions/MwEmbedSupport\nmediawiki/extensions/ParserFunctions\nmediawiki/extensions/PdfHandler\nmediawiki/extensions/SandboxLink\nmediawiki/extensions/SiteMatrix\nmediawiki/extensions/SpamBlacklist\nmediawiki/extensions/Thanks\nmediawiki/extensions/TimedMediaHandler\nmediawiki/extensions/Translate\nmediawiki/extensions/UniversalLanguageSele [23:42:14] ctor\nmediawiki/extensions/VisualEditor\nmediawiki/extensions/Wikidata\nmediawiki/extensions/ZeroBanner\nmediawiki/extensions/ZeroPortal\nmediawiki/extensions/cldr' [23:42:17] Woops [23:42:37] yeah, that's just the gatedextension list [23:43:06] oh [23:43:27] i doint see it in the clone [23:43:28] either [23:43:31] goes https://github.com/wikimedia/integration-config/blob/master/zuul/parameter_functions.py#L62-L63 -> https://github.com/wikimedia/integration-config/blob/master/zuul/parameter_functions.py#L327-L343 [23:44:05] and since scribunto is not in that list (https://github.com/wikimedia/integration-config/blob/master/zuul/parameter_functions.py#L291-L324) [23:44:08] doesn't get cloned [23:44:31] oh [23:44:59] I'm not clear on what that list is exactly... [23:45:50] gatedextension list is for the gate and submit test, this mediawiki-extensions-hhvm-jessie one [23:46:08] Ah [23:46:38] thcipriani we removed scribuntu from gate and submit due to performance reasons. [23:46:48] hrm [23:47:23] paladox: is there a task or a commit that shows that? [23:48:49] I think there is [23:52:22] thcipriani https://phabricator.wikimedia.org/rCICF5fabd9fcefe5796e2c9d2ce4e28a8440acfc4eaf [23:52:29] https://phabricator.wikimedia.org/T126274 [23:53:06] thcipriani, still fails - now i got all tests fixed - https://gerrit.wikimedia.org/r/#/c/326906/ [23:54:13] yurik: yeah paladox seems to have found the core of the issue [23:54:21] https://phabricator.wikimedia.org/T126274 [23:54:23] thcipriani we could re try [23:54:25] woot \o/ [23:54:25] as we can cache [23:54:26] now [23:55:33] using https://phabricator.wikimedia.org/diffusion/CICF/browse/master/jjb/castor.yaml [23:56:01] https://phabricator.wikimedia.org/rCICF5c13ecccb868c993df3fdf13c0125158c5d59a0c [23:57:05] (03CR) 10Paladox: "@hashar you will probably want to add skin deps support in gated extensions." [integration/config] - 10https://gerrit.wikimedia.org/r/323540 (https://phabricator.wikimedia.org/T151593) (owner: 10Paladox) [23:59:54] hrm. it looks like castor caches dependencies, but the actual slowdown is caused by Scribunto tests