[00:00:27] 10Gerrit, 10SyntaxHighlight: Rename git repo to "SyntaxHighlight" - https://phabricator.wikimedia.org/T103614#2970905 (10Krinkle) 05declined>03Open >>! In T103614#2922464, @demon wrote: > We don't rename repositories, plus this already happened as a second repo entirely. No, it didn't. We very briefly ha... [00:18:10] Project beta-scap-eqiad build #139351: 04FAILURE in 19 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/139351/ [00:20:59] Project beta-update-databases-eqiad build #14515: 04FAILURE in 0.56 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/14515/ [00:28:12] Yippee, build fixed! [00:28:13] Project beta-scap-eqiad build #139352: 09FIXED in 2 min 34 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/139352/ [00:39:22] 10Beta-Cluster-Infrastructure, 06Commons, 10MediaWiki-File-management, 06Multimedia, 07Tracking: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#2971038 (10Krenair) I've also finally got around to deploying... [01:00:05] 10Gerrit: jenkins-bot ran gate-and-submit and voted V+2, but did not submit (merge) the change - https://phabricator.wikimedia.org/T155558#2971188 (10Volker_E) @Paladox It seemed to be something else, patch above being dependent on older patch set elsewhere. [01:22:08] Yippee, build fixed! [01:22:08] Project beta-update-databases-eqiad build #14516: 09FIXED in 1 min 9 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/14516/ [01:44:57] PROBLEM - Puppet run on repository is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [01:54:45] phab down o/ [01:55:38] JustBerry hi, please sse -operations. Phab is being updated. [02:19:55] RECOVERY - Puppet run on repository is OK: OK: Less than 1.00% above the threshold [0.0] [04:16:34] Project selenium-MultimediaViewer » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #277: 04FAILURE in 19 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/277/ [06:44:16] 10Beta-Cluster-Infrastructure, 06Commons, 10MediaWiki-File-management, 06Multimedia: Thumbnail 404s get cached - https://phabricator.wikimedia.org/T69056#2971564 (10Tgr) [06:51:20] Project selenium-Wikibase » chrome,beta,Linux,contintLabsSlave && UbuntuTrusty build #250: 04FAILURE in 2 hr 10 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/250/ [09:03:48] 10Beta-Cluster-Infrastructure, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-01-31_(1.29.0-wmf.10): beta cluster: Warning: failed to mkdir "/srv/mediawiki/php-master/images/thumb/... - https://phabricator.wikimedia.org/T145496#2971716 (10hashar) Hurra @tgr thank you very much. [10:43:09] 10MediaWiki-Releasing, 06Release-Engineering-Team, 06Operations: Pages with an &stable=1 in their URL could not be viewed or edited - https://phabricator.wikimedia.org/T156356#2972021 (10Joe) [10:43:21] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T154683#2972023 (10jcrespo) [10:43:24] 10MediaWiki-Releasing, 06Release-Engineering-Team, 06Operations: Pages with an &stable=1 in their URL could not be viewed or edited - https://phabricator.wikimedia.org/T156356#2972022 (10jcrespo) [11:03:03] 10Continuous-Integration-Config: operations-mw-config-composer-hhvm-jessie job lacks composer cache - https://phabricator.wikimedia.org/T156359#2972076 (10hashar) [11:13:39] 10MediaWiki-Releasing, 06Release-Engineering-Team, 06Operations, 13Patch-For-Review: Pages with an &stable=1 in their URL could not be viewed or edited - https://phabricator.wikimedia.org/T156356#2972123 (10Joe) @hashar rolled back to wmf.8 and I can confirm the pages I was looking at now render correctly. [11:14:12] 10MediaWiki-Releasing, 06Release-Engineering-Team, 06Operations, 13Patch-For-Review: Pages with an &stable=1 in their URL could not be viewed or edited - https://phabricator.wikimedia.org/T156356#2972125 (10hashar) From a quick talk on IRC, @Joe recommended to rollback immediately to restore production imm... [11:14:26] 10MediaWiki-Releasing, 06Release-Engineering-Team, 06Operations, 13Patch-For-Review: Pages with an &stable=1 in their URL could not be viewed or edited - https://phabricator.wikimedia.org/T156356#2972130 (10hashar) [11:26:51] 06Release-Engineering-Team, 10Phabricator, 10Wikimedia-Blog: Write a blog post on 2017-01-25 phabricator update on wmf - https://phabricator.wikimedia.org/T155896#2972142 (10Aklapper) [11:26:58] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [11:27:29] Project beta-scap-eqiad build #139421: 04FAILURE in 1 min 45 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/139421/ [11:31:00] Yippee, build fixed! [11:31:00] Project beta-scap-eqiad build #139422: 09FIXED in 2 min 20 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/139422/ [11:36:58] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [11:41:50] addshore: about phan and the PHP5 stubs you sent. I was wondering whether we could publish the stubs as composer package and just depends on them [11:41:56] so potentially others could reuse the stubs :D [11:42:03] and that is less cruft in mediawiki/core [11:42:09] .. random thought ... [11:51:45] hashar: yeh, I was thiking that too [11:51:48] either a lib we controll [11:51:49] OR [11:52:19] wrap the intelij repo containing the stubs it uses in a repo of our own? [11:52:20] or something [11:53:53] all of the wmde extensions (except wikibase) are already running phan ;) [12:11:48] neat!! [12:12:12] there are bunch of folks creating such stubs apparently [12:12:19] https://github.com/schmittjoh/php-stubs hehe [12:12:22] from 4 years ago [12:14:00] https://packagist.org/packages/divi/pthreads-stub etc [12:35:56] (03CR) 10Addshore: [C: 031] prepare-mediawiki-zuul-project-no-sql: Use composer to install deps [integration/config] - 10https://gerrit.wikimedia.org/r/333686 (owner: 10WMDE-leszek) [12:36:13] hashar: ^^ that is needed for phan for wikibase [12:36:24] and yeh, I have a quick look on packigist for stubs hashar but i didnt see any :O [12:36:45] but yeh, Perhaps we just make our own repo / package for the mw stubs? [12:46:34] addshore: lets make wikimedia/php-stubs the new standard!!! :D [12:46:44] lets do it :p [12:46:47] though [12:46:56] one must have already created a script that generate the stubs on the fly [12:47:18] I think that is what https://github.com/schmittjoh/php-stubs is doing [12:47:30] intellijea / phpstorm might already have a stub repo as well [12:47:44] so maybe it is just about having them to publish it to packagist and we can consume their [12:48:33] hashar: there is this for this https://github.com/etsy/phan/issues/55 [12:48:39] and https://github.com/JetBrains/phpstorm-stubs [12:49:24] Apache 2 [12:50:02] ahhh [12:50:11] so that is a manually maintained list of stubs I guess [12:51:07] addshore: do you think https://github.com/JetBrains/phpstorm-stubs can be enhanced to be pushed to packagist ? [12:52:25] so, after a quick look at it it includes everything we need except for https://gerrit.wikimedia.org/r/#/c/333695/2/tests/phan/stubs/tideways.php [12:53:01] looks promosing [12:53:05] hashar: https://github.com/JetBrains/phpstorm-stubs/pull/149 [12:53:10] and I guess we can send a PR to add tideways [12:53:19] I might be overthinking [12:53:33] but I would rather contribute to upstream and consume the stubs from packagist [12:53:39] well, for tideways we could just ignore the 1 file that uses it or have our own tiny stub for it [12:53:54] on the basis that then we no more have to handle it and that is one less phpstub repo/fork in the wild [12:54:22] ohhh there is a PR for composer that is nice [12:57:00] I just added a comment to https://github.com/etsy/phan/issues/55#issuecomment-275382036 to give it a poke (noone has commented on it since jan 2016! [12:57:25] and I referenced the phpstorm stub repo PR in it [12:58:29] and I see you commented on the jetbrains PR :D [13:01:45] addshore: yeah :] [13:01:51] trying to be a good downstream hehe [13:02:04] maybe reedy has contact with them [13:04:19] hashar: so I abandoned my phan stub patches, except https://gerrit.wikimedia.org/r/#/c/333695/3 [13:06:42] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T154683#2972355 (10hashar) [13:13:31] addshore: what I think we can do, is fork the jetbrain repo [13:13:39] add the PR that adds composer.json with a different name [13:13:51] then once they have released it to packagist, we can switch to use their [13:13:54] and close our fork [13:13:58] yeh wikimedia/jetbrains-php-stubs or something [13:14:06] +2 to that idea hashar! [13:14:08] (but please dismiss my crazy ideas) [13:14:08] want to do it? :) [13:14:11] ;D [13:14:15] I support you ;) [13:14:24] I dont think I still have my packagist credentials around hehe [13:15:29] * hashar tries with github [13:15:31] blam worked [13:16:19] there are also wikimedia and mediawiki users [13:16:34] mhhhm [13:16:40] mediawiki would make more sense imo [13:17:17] sure [13:19:17] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T154683#2972363 (10hashar) [13:19:39] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T154683#2920077 (10hashar) Reusing T66603 as a blocker for: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 [13:24:41] phan phan phan!!!: [13:24:43] :P [13:27:21] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T154683#2972405 (10hashar) [13:29:15] 06Release-Engineering-Team (Deployment-Blockers), 05Release: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 - https://phabricator.wikimedia.org/T156364#2972411 (10hashar) [13:33:47] 06Release-Engineering-Team (Deployment-Blockers), 05Release: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 - https://phabricator.wikimedia.org/T156364#2972443 (10hashar) https://gerrit.wikimedia.org/r/#/c/332702 did some changes to DateFormat... [13:36:08] addshore: and the 10 $ question. [13:36:29] should we fork under github.org/wikimedia/ or in a new Gerrit repo [13:36:41] no clue about a name for the Gerrit repo [13:44:31] mediawiki/libs ! [13:45:08] addshore: does mediawiki/libs/phpstorm-stubs.git sounds about right? [13:45:27] sure, i mean, maybe not even libs, maybe utils or something [13:45:34] but i guess there arent any doing that yet! [13:45:37] libs should be good! [13:46:04] yup [13:46:33] addshore: got a task I can refer to ? [13:47:30] Yippee, build fixed! [13:47:30] Project selenium-VisualEditor » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #286: 09FIXED in 2 min 30 sec: https://integration.wikimedia.org/ci/job/selenium-VisualEditor/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/286/ [13:49:10] picking https://phabricator.wikimedia.org/T153252 Fix PHP issues in MediaWiki core found by Phan (static code analysis) [13:49:38] !log Gerrit creating mediawiki/libs/phpstorm-stubs to fork https://github.com/JetBrains/phpstorm-stubs for T153252 [13:49:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:49:43] T153252: Fix PHP issues in MediaWiki core found by Phan (static code analysis) - https://phabricator.wikimedia.org/T153252 [14:10:55] addshore: https://gerrit.wikimedia.org/r/334345 wmf: add composer.json [14:11:07] their master branch is our upstream branch [14:14:38] added default reviewers https://www.mediawiki.org/wiki/Git/Reviewers#mediawiki.2Flibs.2Fphpstorm-stubs [14:17:39] addshore: then I guess in composer we can add Gerrit as the git repo and point at dev-master [14:17:50] or we can push to packagist [14:18:37] lets try adding gerrit as the git repo and poiting to dev-mast i guess? [14:18:43] yeah [14:18:54] [= [14:19:02] should I merge the patch? [14:21:15] (03PS1) 10Hashar: composer validate mediawiki/libs/phpstorm-stubs [integration/config] - 10https://gerrit.wikimedia.org/r/334347 (https://phabricator.wikimedia.org/T153252) [14:21:21] addshore: lack CI ^^^ :] [14:21:35] (03CR) 10Addshore: [C: 031] composer validate mediawiki/libs/phpstorm-stubs [integration/config] - 10https://gerrit.wikimedia.org/r/334347 (https://phabricator.wikimedia.org/T153252) (owner: 10Hashar) [14:21:39] ;D [14:21:44] (03CR) 10Hashar: [C: 032] composer validate mediawiki/libs/phpstorm-stubs [integration/config] - 10https://gerrit.wikimedia.org/r/334347 (https://phabricator.wikimedia.org/T153252) (owner: 10Hashar) [14:22:18] addshore: so yeah on https://packagist.org/packages/submit they recommend to use a VCS Repository [14:22:23] for forks [14:22:48] (03Merged) 10jenkins-bot: composer validate mediawiki/libs/phpstorm-stubs [integration/config] - 10https://gerrit.wikimedia.org/r/334347 (https://phabricator.wikimedia.org/T153252) (owner: 10Hashar) [14:23:12] magic [14:25:12] !log Created Github repo for Gerrit replication https://github.com/wikimedia/mediawiki-libs-phpstorm-stubs T153252 [14:25:16] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:25:16] T153252: Fix PHP issues in MediaWiki core found by Phan (static code analysis) - https://phabricator.wikimedia.org/T153252 [14:34:06] woop! [14:34:10] :D [14:34:23] where is the patch adding it to composer.json for core? :P [14:37:35] I was hoping for CI to run composer-validate [14:37:49] but all Trusty nodes are consumed by the Wikibase changes being +2ed [14:38:09] for core honestly I have no clue [14:38:37] I have no idea what kind of composer / PHP magic will be needed to refer to the stub [14:42:49] :D [14:42:56] so, we just need to install it in composer [14:43:04] so I guess it lands in require-dev for core [14:43:17] and then, it will end up on jenkins etc and my installation etc :p [14:45:56] yeah I guess so [14:46:04] maybe as a require-dev of mediawiki/core? [14:46:24] and I guess then add phan on all wmf deployed ext / skins [14:46:33] filling tasks as bugs are found [14:46:38] danting maintenance epic work [14:46:52] but if that catch bugs and fatals it is well worth it [14:46:59] maybe as a require-dev of mediawiki/core? >>> yes [14:47:15] and on ci [14:47:20] it ends up being cached [14:47:33] In theroy it should, but only if no things are skipped / ignored :p [14:49:12] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2972713 (10jcrespo) [14:50:10] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2972739 (10jcrespo) p:05Triage>03High [14:51:08] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2972713 (10jcrespo) I will backup current dataset and recover the last backup into db1048. [14:55:37] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2972746 (10Marostegui) From looking at db2012 (uses GTID). When starting slave it always tries to start at the sa... [15:05:06] (03Abandoned) 10Zfilipin: Let node-config know it should use Jenkins configuration file for running Selenium tests. [integration/config] - 10https://gerrit.wikimedia.org/r/333896 (https://phabricator.wikimedia.org/T139740) (owner: 10Zfilipin) [15:09:06] (03PS1) 10Addshore: Add MoveToCommons extension and Client [integration/config] - 10https://gerrit.wikimedia.org/r/334359 [15:09:07] hashar: ^^ :D [15:09:27] zeljkof: awesome :] [15:09:39] addshore: no unit tests ? :] [15:09:43] no code yet [15:09:57] (03CR) 10Hashar: [C: 032] Add MoveToCommons extension and Client [integration/config] - 10https://gerrit.wikimedia.org/r/334359 (owner: 10Addshore) [15:10:02] zeljkof: turns out, it was easy to do :) [15:10:03] [= [15:10:18] zeljkof: \o/ [15:10:27] zeljkof: thanks for keeping the jenkins jobs as dumb as possible! [15:10:59] I am heading out, will be back later tonight [15:11:33] (waiting for the ci conf to land though) [15:12:14] (03Merged) 10jenkins-bot: Add MoveToCommons extension and Client [integration/config] - 10https://gerrit.wikimedia.org/r/334359 (owner: 10Addshore) [15:12:27] done! [15:12:55] ty [15:15:53] bbl [15:19:09] bah, might be an issue with the stub plan :/ [15:19:26] well... or not.. mhhhm [15:27:51] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2972833 (10Marostegui) This is the original crash: ``` 2017-01-26 02:00:22 7fa9cebf6700 InnoDB: FTS Optimize Rem... [15:29:18] hasharAway: it actually looks like using that repo would be pretty hard :/ [15:29:36] wel... [15:29:37] meh [15:53:35] Project selenium-MobileFrontend » firefox,beta,Linux,contintLabsSlave && UbuntuTrusty build #304: 04FAILURE in 30 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=contintLabsSlave%20&&%20UbuntuTrusty/304/ [16:03:41] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2972979 (10Paladox) Looking at the above ^^, upstream have created a new phabricator_search table. So we no longe... [16:03:47] 06Release-Engineering-Team (Deployment-Blockers), 05Release: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 - https://phabricator.wikimedia.org/T156364#2972980 (10Anomie) >>! In T156364#2972443, @hashar wrote: > https://gerrit.wikimedia.org/r/... [16:16:42] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973018 (10Marostegui) >>! In T156373#2972979, @Paladox wrote: > Looking at the above ^^, upstream have created a... [16:20:34] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973027 (10Paladox) >>! In T156373#2973018, @Marostegui wrote: >>>! In T156373#2972979, @Paladox wrote: >> Lookin... [16:26:20] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973052 (10Paladox) I found this bug report https://jira.mariadb.org/browse/MDEV-11233 that looks very similar to... [16:34:50] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973070 (10Marostegui) >>! In T156373#2973052, @Paladox wrote: > I found this bug report https://jira.mariadb.org... [16:39:10] 06Release-Engineering-Team (Deployment-Blockers), 05Release: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 - https://phabricator.wikimedia.org/T156364#2973081 (10Anomie) If we don't have any way to reproduce it, it seems from looking at HHVM'... [16:40:54] Krenair: I saw this yesterday https://phabricator.wikimedia.org/P4810 have you deployed since/can you recreate? I tried to recreate the error but failed. One of 3 things could be failing: removing git tags from /srv/mediawiki (as mwdeploy), writing /srv/mediawiki/.git/DEPLOY_HEAD (as mwdeploy), or getting the list of deploy masters from /etc/dsh/group/scap-masters. The first 2 seem more likely than [16:40:56] the last. I'm suspicious that there may be an error in logic for removing git tags in deploy directories. Let me know if/when you're around and could try a beta deploy. [16:43:28] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [16:52:31] 10Gerrit, 07artificial-intelligence: Patch-wrangler -- suggests the best reviewers for a patch - https://phabricator.wikimedia.org/T155851#2973161 (10Halfak) @Aklapper, could you link to some of this existing research. It's not exactly my field ;) [16:54:08] 10Gerrit, 07artificial-intelligence: Patch-wrangler -- suggests the best reviewers for a patch - https://phabricator.wikimedia.org/T155851#2973162 (10Halfak) @KartikMistry & @Nikerabbit, does the https://tools.wmflabs.org/reviewers/ tool solve for this AI proposal? [16:58:42] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973202 (10Marostegui) The alter table worked on 10.1.21. So to recap: 10.0.23 -> works 10.0.28 -> crashes 10.0... [17:00:34] addshore: add me as reviewer of anything you got. If the composer install is not fitting our needs, we can find another system [17:00:46] I hve already [17:00:52] but yeh, its just the jenkins issue we are having [17:00:59] phan runs find for me with those stubs! :D [17:01:47] (03CR) 10Hashar: "If I remember properly that was to test Wikibase with mediawiki/vendor. But since that macro is only used for the phan job that is all fi" [integration/config] - 10https://gerrit.wikimedia.org/r/333686 (owner: 10WMDE-leszek) [17:02:04] addshore: is that that one ^ [17:02:14] aka bunch of deps missing? [17:03:09] well, thats the one for getting phan with wikibase, as wikibase repo will require a composer install to work to have all the deps [17:03:25] as for core loading the stubs for phan from the new lib, see https://gerrit.wikimedia.org/r/#/c/334363/ [17:03:45] amusingly the phan run actually succeedes... [17:03:49] but https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-jessie/2586/console [17:04:21] 10Deployment-Systems, 03Scap3, 13Patch-For-Review, 07Wikimedia-Incident: Include fatal log rate check in scap canary test - https://phabricator.wikimedia.org/T154646#2918734 (10greg) >>! In T154646#2965895, @gerritbot wrote: > Change 304327 merged by Filippo Giunchedi: > Include hhvm fatals and exceptions... [17:04:50] (03PS3) 10Hashar: prepare-mediawiki-zuul-project-no-sql: Use composer to install deps [integration/config] - 10https://gerrit.wikimedia.org/r/333686 (owner: 10WMDE-leszek) [17:05:03] (03CR) 10Hashar: "renamed the macro" [integration/config] - 10https://gerrit.wikimedia.org/r/333686 (owner: 10WMDE-leszek) [17:05:13] (03PS4) 10Hashar: prepare-mediawiki-zuul-project-no-sql: Use composer to install deps [integration/config] - 10https://gerrit.wikimedia.org/r/333686 (owner: 10WMDE-leszek) [17:06:03] (03CR) 10Hashar: [C: 032] "Deployed!" [integration/config] - 10https://gerrit.wikimedia.org/r/333686 (owner: 10WMDE-leszek) [17:06:19] addshore: done for wikibase [17:06:27] =] [17:07:05] oh [17:07:12] maybe that is the composer merge plugin [17:07:36] (03Merged) 10jenkins-bot: prepare-mediawiki-zuul-project-no-sql: Use composer to install deps [integration/config] - 10https://gerrit.wikimedia.org/r/333686 (owner: 10WMDE-leszek) [17:07:58] addshore: maybe due to minimum-stability [17:08:03] oooh [17:08:19] The package is not available in a stable-enough version according to your minimum-stability setting [17:12:23] ah [17:12:27] so from mediawiki/core [17:12:29] cd vendor [17:12:30] composer require --dev -v mediawiki/phpstorm-stubs=dev-master [17:12:33] that reproduce the issue [17:14:51] 06Release-Engineering-Team, 06Operations, 13Patch-For-Review: Pages with an &stable=1 in their URL could not be viewed or edited - https://phabricator.wikimedia.org/T156356#2973299 (10greg) [17:16:40] from root of mediawiki [17:16:46] composer info mediawiki/phpstorm-stubs ===> Package mediawiki/phpstorm-stubs not found [17:16:52] then I do a composer update [17:16:59] it clones the repo from cache and find it [17:17:34] (03CR) 10WMDE-leszek: "Thanks for renaming! Much more clear now." [integration/config] - 10https://gerrit.wikimedia.org/r/333686 (owner: 10WMDE-leszek) [17:20:13] so maybe we need to update before doing the require dev [17:28:47] :O [17:28:53] seems odd [17:29:06] at least I reproduce it [17:29:13] yup :p [17:29:33] cd projects/mediawiki/vendor [17:29:38] ~/projects/integration/jenkins/tools/composer-dev-args.js "/home/hashar/projects/mediawiki/core/composer.json"|xargs composer require --dev -vvv [17:30:10] :( [17:30:26] gotta prepare dinner. Maybe legoktm/krinkle would know [17:30:32] guess somehow it fails to find the vcs repo :( [17:39:21] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2972713 (10greg) From the description, have the phab statistics crons been disabled? [17:44:46] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973390 (10Paladox) >>! In T156373#2973202, @Marostegui wrote: > The alter table worked on 10.1.21. > > So to re... [17:47:39] 10Deployment-Systems, 03Scap3, 13Patch-For-Review, 07Wikimedia-Incident: Include fatal log rate check in scap canary test - https://phabricator.wikimedia.org/T154646#2973395 (10thcipriani) >>! In T154646#2973234, @greg wrote: >>>! In T154646#2965895, @gerritbot wrote: >> Change 304327 merged by Filippo Giu... [17:57:15] hasharAway: did they run on different machines / have different netowkr access? [17:57:17] :P [18:26:40] 10Continuous-Integration-Config, 06Reading-Web-Backlog: Proof of concept to generate coverage report of some Wikimedia mediawiki extensions - https://phabricator.wikimedia.org/T151333#2814578 (10pmiazga) @hashar any updates on this task? It would be awesome to see it live. [18:29:35] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973525 (10Marostegui) >>! In T156373#2973370, @greg wrote: > From the description, have the phab statistics cron... [18:33:51] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973539 (10greg) I don't have the rights, I believe @jcrespo did it (with verification from @mmodell) last time w... [18:35:11] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973540 (10Marostegui) >>! In T156373#2973390, @Paladox wrote: > > Maybe we should find the patch that fixed it... [18:49:43] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973641 (10Paladox) @Marostegui hi, i was talking about doing it upstream. [19:19:33] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2972713 (10epriestley) Not sure this is helpful, but the `phabricator_search.search_documentfield` table is just... [19:23:19] 06Release-Engineering-Team, 10Elasticsearch, 10Phabricator: Add support for elasticsearch 5 - https://phabricator.wikimedia.org/T155299#2973763 (10Paladox) Actually, I'm getting this warnning 2017-01-26T19:16:11,892][WARN ][o.e.d.i.m.StringFieldMapper$TypeParser] The [string] field is deprecated, please use... [19:23:28] 06Release-Engineering-Team, 10Elasticsearch, 10Phabricator: Add support for elasticsearch 5 - https://phabricator.wikimedia.org/T155299#2973764 (10Paladox) 05Resolved>03Open [19:24:56] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973770 (10jcrespo) @epriestley we are already doing that in parallel. But if it happens to be the... [19:27:30] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973783 (10Paladox) @jcrespo and @Marostegui i found the patch https://github.com/MariaDB/server/co... [19:29:29] 10Gerrit, 07artificial-intelligence: Patch-wrangler -- suggests the best reviewers for a patch - https://phabricator.wikimedia.org/T155851#2973792 (10Nikerabbit) Not sure it works well for `mediawiki/core`. For some other extensions (Translate, Babel) it seems to have me as top suggestion even though I'm alrea... [19:30:36] 10Gerrit, 07artificial-intelligence: Patch-wrangler -- suggests the best reviewers for a patch - https://phabricator.wikimedia.org/T155851#2956819 (10Paladox) There's a gerrit reviewer plugin. [19:33:57] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973802 (10Paladox) I got some merge conflicts when cherry picking to the 10.0 branch ~/server$ gi... [19:37:42] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973806 (10epriestley) @jcrespo Ah, sorry, I hadn't actually read the linked bug. As another possi... [19:39:29] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973808 (10Paladox) Actually, it's very easy to fix merge conflicts. [19:40:25] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973809 (10Paladox) remove this ``` -<<<<<<< HEAD - /* One variable length column, word... [19:52:38] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973904 (10jcrespo) As usual, @epriestley, I thank you a lot for the support (thank you so much!),... [20:03:42] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973962 (10jcrespo) https://jira.mariadb.org/browse/MDEV-11918 [20:04:36] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973965 (10Paladox) @jcrespo and @marostegui I've back ported the fix here https://github.com/Maria... [20:11:27] addshore: so I got it. We get the list of dev depeendencies from mediawiki/core but run 'composer require' inside mediawiki/vendor [20:11:50] addshore: and mediawiki/vendor does not have the vcs repository, hence does not clone it and cant find the phpstub package [20:12:41] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973994 (10jcrespo) >>! In T156373#2973965, @Paladox wrote: > @jcrespo and @marostegui I've back po... [20:13:07] 06Release-Engineering-Team, 10DBA, 06Operations, 10Phabricator, 07Upstream: During Phabricator upgrade on 2017-01-26, all m3 replica dbs crashed at the same time - https://phabricator.wikimedia.org/T156373#2973995 (10Paladox) Ok, your welcome :) [20:43:57] hashar: oooohh [20:44:22] so hashar I need to add it to https://github.com/wikimedia/mediawiki-vendor/blob/master/composer.json too? [20:44:31] seems a bit ewwy [20:48:54] nop [20:49:12] addshore: I am crafting a short script that would read the mediawiki/core composer.json repositories [20:49:40] then use: composer repositories.0 'the json blob here' [21:07:39] Executing command (/home/hashar/.cache/composer/vcs/https---gerrit.wikimedia.org-r-mediawiki-libs-phpstorm-stubs/): git show 'ff0d59efcf751d858e2b0fb854abb3c72bd57647':composer.json [21:07:39] Skipped branch upstream, no composer file [21:07:41] better [21:08:33] Reading composer.json of mediawiki/phpstorm-stubs (master) [21:08:33] Importing branch master (dev-master) [21:11:52] addshore: SOLVED !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! [21:28:21] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T154683#2974229 (10mmodell) [21:30:23] (03PS1) 10Hashar: mw-fetch-composer-dev: configure composer repositories [integration/jenkins] - 10https://gerrit.wikimedia.org/r/334429 [21:30:30] addshore: ^^ [21:30:40] 06Release-Engineering-Team (Deployment-Blockers), 05Release: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 - https://phabricator.wikimedia.org/T156364#2974231 (10mmodell) >>! In T156364#2973081, @Anomie wrote: > If we don't have any way to re... [21:31:22] (03PS2) 10Hashar: mw-fetch-composer-dev: configure composer repositories [integration/jenkins] - 10https://gerrit.wikimedia.org/r/334429 [21:35:25] (03CR) 10Hashar: "Some magic to make mw-fetch-composer-dev.sh so it injects mediawiki composer repositories into the vendor composer.json. Lets then 'compo" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/334429 (owner: 10Hashar) [21:36:12] hashar i wish it was that simple lol [21:38:11] Zppix: define "it" ?? :] [21:38:18] are you refering to the magic above? [21:51:36] (03CR) 10Addshore: mw-fetch-composer-dev: configure composer repositories (034 comments) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/334429 (owner: 10Hashar) [21:51:38] hashar: ^^ [22:01:39] hohohoh [22:01:44] to s or not to s [22:07:20] (03PS3) 10Hashar: mw-fetch-composer-dev: configure composer repositories [integration/jenkins] - 10https://gerrit.wikimedia.org/r/334429 [22:07:47] addshore: thanks for the review. Timo once wrote a very friendly and nice emails about the s and not s :/ [22:07:59] but I guess I need more training [22:16:24] hashar: or I am too tired D: [22:21:03] addshore: ditto heading to bed [22:21:08] :D [22:21:09] night! [22:21:12] addshore: nooo [22:21:15] don't leave us! [22:21:16] lets catch up tomorrow or monday to deploy that ! :] [22:21:20] yup! :D [22:21:27] JustBerry: but its night time! [22:21:35] addshore: UK? [22:21:37] tis late for us JustBerry! [22:21:41] o/ [22:21:47] JustBerry: not currently [22:21:50] 23:21 CET here [22:24:13] hashar: o/ [22:31:48] 06Release-Engineering-Team, 10Phabricator, 10Wikimedia-Blog: Write a blog post on 2017-01-25 phabricator update on wmf - https://phabricator.wikimedia.org/T155896#2974375 (10EdErhart-WMF) @Zppix that would be great! I can either send you that Google Doc I mentioned before, or you can start a draft here: http... [23:15:36] 06Release-Engineering-Team (Deployment-Blockers), 05Release: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 - https://phabricator.wikimedia.org/T156364#2974525 (10greg) So, blocker status? :) [23:20:20] 10Gerrit, 07artificial-intelligence: Patch-wrangler -- suggests the best reviewers for a patch - https://phabricator.wikimedia.org/T155851#2974541 (10Legoktm) >>! In T155851#2973792, @Nikerabbit wrote: > Not sure it works well for `mediawiki/core`. For some other extensions (Translate, Babel) it seems to have... [23:21:45] greg-g: can I get a deployment window on Monday to put a new extension (Linter) on testwiki? I need to scap for it [23:22:14] * greg-g opens https://phabricator.wikimedia.org/T148609 [23:22:25] looks good to me [23:22:30] legoktm: +1 [23:26:34] 06Release-Engineering-Team (Deployment-Blockers), 05Release: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 - https://phabricator.wikimedia.org/T156364#2974575 (10mmodell) This doesn't appear to be happening anymore. I'm removing blocking status. [23:27:32] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T154683#2974602 (10mmodell) [23:48:14] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.9 deployment blockers - https://phabricator.wikimedia.org/T154683#2974705 (10mmodell) [23:48:17] 06Release-Engineering-Team (Deployment-Blockers), 05Release: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 - https://phabricator.wikimedia.org/T156364#2974704 (10mmodell) [23:49:17] 06Release-Engineering-Team (Deployment-Blockers), 05Release: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 - https://phabricator.wikimedia.org/T156364#2972411 (10mmodell) After deploying wmf.9 to all wikis, the error came back: {F5366206} [23:49:35] 06Release-Engineering-Team (Deployment-Blockers), 05Release: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200 - https://phabricator.wikimedia.org/T156364#2974715 (10mmodell) p:05Normal>03High