[00:06:35] 10Gerrit, 06Release-Engineering-Team, 06Operations: Decide weather to disable drafts in gerrit - https://phabricator.wikimedia.org/T158656#3045107 (10Dzahn) I have never used a draft and would not miss them. [00:09:43] 10Gerrit, 06Release-Engineering-Team, 06Operations: Decide weather to disable drafts in gerrit - https://phabricator.wikimedia.org/T158656#3045110 (10Paladox) >>! In T158656#3045107, @Dzahn wrote: > I have never used a draft and would not miss them. There being replaced with private edits :) [01:16:53] Project beta-scap-eqiad build #143394: 04FAILURE in 1 min 58 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/143394/ [01:19:48] Canaries not happy [01:26:52] 10Deployment-Systems, 10MediaWiki-Debug-Logger, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-21_(1.29.0-wmf.13): Capture PHP warnings with stacktraces in MediaWiki and save to logstash - https://phabricator.wikimedia.org/T45086#3045289 (10Tgr) [[https://logstash.wikimedia.org/app/kib... [01:27:15] Yippee, build fixed! [01:27:15] Project beta-scap-eqiad build #143395: 09FIXED in 2 min 26 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/143395/ [01:27:56] 10Beta-Cluster-Infrastructure, 13Patch-For-Review: "Undefined index: wmgExtraLanguageNames" on beta - https://phabricator.wikimedia.org/T157656#3045291 (10Tgr) 05Open>03Resolved a:03Tgr [01:38:00] (03PS1) 10Chad: make-wmf-branch: Don't make old version (-o) required [tools/release] - 10https://gerrit.wikimedia.org/r/339101 [01:38:16] twentyafterfour: Minor thing for you ^ :) [01:38:21] Saves a few keystrokes [02:02:47] (03CR) 10Krinkle: make-wmf-branch: Don't make old version (-o) required (031 comment) [tools/release] - 10https://gerrit.wikimedia.org/r/339101 (owner: 10Chad) [02:04:16] (03PS2) 10Chad: make-wmf-branch: Don't make old version (-o) required [tools/release] - 10https://gerrit.wikimedia.org/r/339101 [02:10:52] Sorry, was just exploring random Chad patches. Didn't realise it was a brand new one that you already asked to review :) [02:13:12] No worries, easy enough for anyone to review really :) [02:13:20] (plus, I'm the one using it this week and next, not him :)) [02:24:59] PROBLEM - Puppet run on deployment-mira is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [02:31:59] 10Scap: [scap] New command to sync all of the files touched in a given commit - https://phabricator.wikimedia.org/T108132#1512954 (10demon) Isn't this what we should do in `scap sync` by default? As well as deciding if rebuilding CDBs is necessary or not. Ideally, we want to move closer to a **single** sync com... [02:36:48] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: mediawiki/tools/scap is lacking a license - https://phabricator.wikimedia.org/T94239#1158049 (10demon) Maybe we make a [[/vote/|poll]] and add everyone to it? [02:36:55] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3045419 (10demon) [02:40:39] 10Deployment-Systems, 10Scap: Considering adding a --no-touch flag to scap that stops automatic touch of InitialiseSettings.php - https://phabricator.wikimedia.org/T149872#2767271 (10demon) So we have `--no-touch` in `scap pull` already. `scap sync-file` already supports this via `--beta-only-change`. We shoul... [03:35:00] RECOVERY - Puppet run on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [03:38:53] 10Deployment-Systems, 10MediaWiki-Debug-Logger, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-21_(1.29.0-wmf.13): Capture PHP warnings with stacktraces in MediaWiki and save to logstash - https://phabricator.wikimedia.org/T45086#3045472 (10Tgr) The `error` channel (with severity=ERROR... [03:46:33] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<11.11%) [03:51:52] 06Release-Engineering-Team, 10MediaWiki-Configuration, 06Services: Automate WMF wiki creation - https://phabricator.wikimedia.org/T158730#3045487 (10tstarling) [03:58:13] Yippee, build fixed! [03:58:14] Project selenium-MultimediaViewer » firefox,mediawiki,Linux,BrowserTests build #309: 09FIXED in 2 min 13 sec: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=mediawiki,PLATFORM=Linux,label=BrowserTests/309/ [04:08:01] Project selenium-MultimediaViewer » safari,beta,OS X 10.9,BrowserTests build #309: 04FAILURE in 12 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=safari,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=OS%20X%2010.9,label=BrowserTests/309/ [04:17:23] (03CR) 1020after4: [C: 031] make-wmf-branch: Don't make old version (-o) required [tools/release] - 10https://gerrit.wikimedia.org/r/339101 (owner: 10Chad) [04:18:09] (03CR) 1020after4: [C: 032] "actually, might as well merge this." [tools/release] - 10https://gerrit.wikimedia.org/r/339101 (owner: 10Chad) [04:22:41] (03Merged) 10jenkins-bot: make-wmf-branch: Don't make old version (-o) required [tools/release] - 10https://gerrit.wikimedia.org/r/339101 (owner: 10Chad) [04:33:52] 10Deployment-Systems, 10Scap: Considering adding a --no-touch flag to scap that stops automatic touch of InitialiseSettings.php - https://phabricator.wikimedia.org/T149872#3045513 (10bd808) >>! In T149872#3045421, @demon wrote: > So we have `--no-touch` in `scap pull` already. `scap sync-file` already supports... [04:37:12] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3045515 (10bd808) >>! In T94239#3045417, @demon wrote: > Maybe we make a [[/vote/|poll]] and add everyone to it? I'm fine with that, or we could just slap and Apache2 license on... [04:39:42] 10Scap: [scap] New command to sync all of the files touched in a given commit - https://phabricator.wikimedia.org/T108132#3045516 (10bd808) /me travels back in time to stop self from filing this bug. Me in the current timeline says we should press forward to using git as the transport mechanism and syncing all... [05:20:55] 10Deployment-Systems, 10Scap: Considering adding a --no-touch flag to scap that stops automatic touch of InitialiseSettings.php - https://phabricator.wikimedia.org/T149872#3045522 (10demon) It's definitely in prod, but I think I want to rename and clean it up a tad per my comment above. [05:21:40] 10Scap: [scap] New command to sync all of the files touched in a given commit - https://phabricator.wikimedia.org/T108132#3045523 (10demon) 05Open>03declined >>! In T108132#3045516, @bd808 wrote: > /me travels back in time to stop self from filing this bug. [05:21:48] bd808: declined just quoting you :p [05:22:00] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Differential, 10Developer-Wishlist (2017), 07Jenkins: Add support for a wmf-ci.yaml type file for wikimedia jenkins - https://phabricator.wikimedia.org/T145669#3045525 (10mmodell) ^ I think that might be too simplistic to actuall... [05:22:29] RainbowSprinkles: :) [05:23:11] Less commands make me happier :) [05:23:41] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3045526 (10mmodell) >>! In T94239#3045515, @bd808 wrote: > or we could just slap and Apache2 license on it and be done. :) +1 [05:24:24] PROBLEM - Puppet run on integration-slave-jessie-android is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [05:39:15] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3045532 (10mmodell) {V14} [05:44:24] RECOVERY - Puppet run on integration-slave-jessie-android is OK: OK: Less than 1.00% above the threshold [0.0] [06:04:03] 10Continuous-Integration-Config, 06Release-Engineering-Team, 06Operations, 06Wikipedia-Android-App-Backlog, and 2 others: Investigate how to improve Android CI performance and stability - https://phabricator.wikimedia.org/T158014#3045538 (10Niedzielski) Hmm... I've been trying to debug this further but aft... [06:48:42] PROBLEM - Puppet run on deployment-redis02 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [06:52:13] PROBLEM - Puppet run on deployment-zotero01 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [06:56:34] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [06:57:48] PROBLEM - Puppet run on deployment-mx is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [06:58:45] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#1158049 (10Joe) My preference for standalone tools is always the GPL v3, because there is no reason for people to use it in different contexts But I'm ok with any choice between... [07:23:42] RECOVERY - Puppet run on deployment-redis02 is OK: OK: Less than 1.00% above the threshold [0.0] [07:32:15] RECOVERY - Puppet run on deployment-zotero01 is OK: OK: Less than 1.00% above the threshold [0.0] [07:32:47] RECOVERY - Puppet run on deployment-mx is OK: OK: Less than 1.00% above the threshold [0.0] [08:15:23] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3045702 (10hashar) @Legoktm wrote: > How exactly is this vote supposed to work? If I say my contributions are GPL v2 or later (my preferred license), but the majority pick someth... [09:00:54] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 13Patch-For-Review: Depool precise jenkins instances - https://phabricator.wikimedia.org/T158652#3045824 (10hashar) [09:02:42] 10Continuous-Integration-Infrastructure, 06Release-Engineering-Team, 13Patch-For-Review: Depool precise jenkins instances - https://phabricator.wikimedia.org/T158652#3042963 (10hashar) There are still a bunch of changes made to REL1_23 branch, specially for the BlueSpice extensions ( https://gerrit.wikimedia... [12:12:13] (03PS1) 10Aude: Update composer to 1.3.2 [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 [12:45:19] (03CR) 10Reedy: "I do note we're using 1.0.3 because of autoloader issues the newer versions cause for MW... I don't know if it makes much difference on th" [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 (owner: 10Aude) [12:50:41] 06Release-Engineering-Team, 07Wikimedia-log-errors: Error: Couldn't find trailer dictionary - https://phabricator.wikimedia.org/T145772#3046446 (10Aklapper) Wild guessing: Maybe `texvc` triggering, via the #Math extension? (Or OCG?) Is there any way to get binary names or file names involved in Logstash? [12:50:49] (03CR) 10Reedy: "Ah, T135161 "Composer v1.1.0 generated vendor dirs will fail lint by PHP <5.6"" [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 (owner: 10Aude) [13:23:15] (03CR) 10Aude: [C: 04-1] Update composer to 1.3.2 [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 (owner: 10Aude) [13:25:07] (03CR) 10Aude: [C: 04-1] "see T135161" [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 (owner: 10Aude) [13:49:09] PROBLEM - Puppet run on buildlog is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [14:04:17] (03CR) 10Paladox: "We are trying to find a way to get phplint to ignore the autoload-static file." [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 (owner: 10Aude) [14:15:35] Yippee, build fixed! [14:15:35] Project selenium-MobileFrontend » chrome,beta,Linux,BrowserTests build #336: 09FIXED in 23 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/336/ [14:30:58] 06Release-Engineering-Team, 10MediaWiki-General-or-Unknown, 07Wikimedia-log-errors: Failed connecting to redis server at rdbXXX.eqiad.wmnet: Bad file descriptor in /srv/mediawiki/php-1.29.0-wmf.12/includes/libs/redis/RedisConnectionPool.php on line 235 - https://phabricator.wikimedia.org/T158770#3046733 (10ha... [14:36:23] 06Release-Engineering-Team, 10MediaWiki-General-or-Unknown, 07Wikimedia-log-errors: Failed connecting to redis server at rdbXXX.eqiad.wmnet: Bad file descriptor in /srv/mediawiki/php-1.29.0-wmf.12/includes/libs/redis/RedisConnectionPool.php on line 235 - https://phabricator.wikimedia.org/T158770#3046740 (10ha... [14:37:43] 10Deployment-Systems, 10MediaWiki-Debug-Logger, 05MW-1.29-release-notes, 13Patch-For-Review, 05WMF-deploy-2017-02-21_(1.29.0-wmf.13): Capture PHP warnings with stacktraces in MediaWiki and save to logstash - https://phabricator.wikimedia.org/T45086#479093 (10hashar) Since 9eafbebdd882a562171fd0e46dcd5a9e... [14:38:07] 06Release-Engineering-Team, 10MediaWiki-General-or-Unknown, 07Wikimedia-log-errors: Failed connecting to redis server at rdbXXX.eqiad.wmnet: Bad file descriptor in /srv/mediawiki/php-1.29.0-wmf.12/includes/libs/redis/RedisConnectionPool.php on line 235 - https://phabricator.wikimedia.org/T158770#3046720 (10ha... [14:39:32] 10Continuous-Integration-Config, 10Wikidata, 13Patch-For-Review: Fatal error: Call to undefined function Wikibase\Client\Tests\RecentChanges\both() - on jenkins - https://phabricator.wikimedia.org/T158674#3046757 (10aude) think the issue is just that the script https://github.com/wikimedia/integration-jenkin... [14:45:10] 06Release-Engineering-Team, 10MediaWiki-Configuration, 13Patch-For-Review, 06Services (watching): Automate WMF wiki creation - https://phabricator.wikimedia.org/T158730#3046764 (10mobrovac) [15:10:27] PROBLEM - App Server Main HTTP Response on deployment-mediawiki05 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [15:15:19] RECOVERY - App Server Main HTTP Response on deployment-mediawiki05 is OK: HTTP OK: HTTP/1.1 200 OK - 45860 bytes in 0.990 second response time [15:23:11] (03CR) 10Reedy: "Didn't we find we had a way to do it? Has anyone actually tried it?" [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 (owner: 10Aude) [15:43:05] PROBLEM - Puppet run on integration-slave-precise-1002 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [15:49:34] (03CR) 10Paladox: "> Didn't we find we had a way to do it? Has anyone actually tried it?" [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 (owner: 10Aude) [16:18:33] (03PS1) 10Aude: Add script to copy composer require-dev and autoload-dev to mw vendor [integration/jenkins] - 10https://gerrit.wikimedia.org/r/339202 (https://phabricator.wikimedia.org/T158674) [16:20:19] (03CR) 10Aude: "then we would need to use this in https://github.com/wikimedia/integration-jenkins/blob/master/bin/mw-fetch-composer-dev.sh" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/339202 (https://phabricator.wikimedia.org/T158674) (owner: 10Aude) [16:21:18] (03CR) 10Aude: [C: 04-1] "updating composer doesn't solve my issue, so I don't have huge preference to do this, but still would be nice to update it" [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 (owner: 10Aude) [16:23:04] RECOVERY - Puppet run on integration-slave-precise-1002 is OK: OK: Less than 1.00% above the threshold [0.0] [16:43:54] (03CR) 10Hashar: [C: 04-2] "Please see the task about upgrading composer T125343" [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 (owner: 10Aude) [16:45:48] (03Abandoned) 10Aude: Update composer to 1.3.2 [integration/composer] - 10https://gerrit.wikimedia.org/r/339165 (owner: 10Aude) [16:46:11] hashar: think i figured out the issue we had [16:47:03] aude: yeah nice :} [16:47:08] apparently it is missing autoload-dev ? [16:47:16] https://github.com/wikimedia/integration-jenkins/blob/master/tools/composer-dev-args.js doesn't copy that over [16:47:57] i propose to introduce a new script that handles both (eventually to replace the current one) [16:48:16] not to modify the existing one, as that might cause soemthing to break [16:51:10] time to go home .... [16:51:15] ditto [16:51:23] will try to test it tonight [16:52:43] (03PS1) 10Umherirrender: [Gamepress] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/339212 [16:54:58] 10Gerrit, 06Release-Engineering-Team, 06Operations: Decide weather to disable drafts in gerrit - https://phabricator.wikimedia.org/T158656#3047097 (10Dzahn) >>! In T158656#3045110, @Paladox wrote: > There being replaced with private edits :) I don't anticipate ever needing a private edit. Really private th... [16:56:33] 10Gerrit, 06Release-Engineering-Team, 06Operations: Decide weather to disable drafts in gerrit - https://phabricator.wikimedia.org/T158656#3047103 (10Paladox) @Dzahn private edit's would normally be used for creating your first inline edit change i presume. https://gerrit-review.googlesource.com/#/c/98134/ [16:57:36] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3047104 (10Dzahn) >>! In T94239#3045702, @hashar wrote: > We circle back in an endless loop until 100% of authors having code worth a copyright agree on a license. Let's list th... [17:01:35] 10Gerrit, 06Release-Engineering-Team, 06Operations: Decide weather to disable drafts in gerrit - https://phabricator.wikimedia.org/T158656#3047107 (10Dzahn) >>! In T158656#3047103, @Paladox wrote: > @Dzahn private edit's would normally be used for creating your first inline edit change i presume. That's ok,... [17:02:21] 10Gerrit, 06Release-Engineering-Team, 06Operations: Decide weather to disable drafts in gerrit - https://phabricator.wikimedia.org/T158656#3047110 (10Paladox) @Dzahn refresh, it sometimes fails to load. But you need javascript enabled to view the site. [17:40:33] RainbowSprinkles hi, mediawiki broke wikipedia's main page according to https://phabricator.wikimedia.org/T158782#3047254 [17:41:36] jan_drewniak: ^ [17:54:52] paladox: It's not MediaWiki's fault, it's that portal code [17:55:10] oh [17:55:11] ok [18:04:53] paladox: https://phabricator.wikimedia.org/T128546 [18:05:16] mutante yep. [18:10:34] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3047381 (10mmodell) @dzahn: I included the exact list in the poll but here it is from git log: ``` project : scap repo age : 3 years, 1 month active : 278 days commits :... [18:13:08] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3047390 (10mmodell) So if we can get everyone with > 1% of commits to agree on a license I think that would be conclusive? [18:15:11] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3047398 (10Dzahn) Alright, I wish we could say "ignore contributions under 10 lines" and then the remaining 7 human users agree on one. [18:19:45] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3047418 (10mmodell) btw those numbers are commits not lines of code. [18:20:12] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3047419 (10Slaporte) @mmodell: Which of these contributions were made by Wikimedia Foundation staff as part of their work? We can help reach out to people to get their agreement... [18:23:05] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3047429 (10mmodell) | name | loc | commits | files | distribution (%) | | Mukunda Modell | 3,207 | 50 | 54 | 25.4 / 10.5 / 54.0 | | Tyler Cipriani... [18:26:01] PROBLEM - Puppet run on deployment-mira is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [18:30:30] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3047494 (10greg) >>! In T94239#3047419, @Slaporte wrote: > @mmodell: Which of these contributions were made by Wikimedia Foundation staff as part of their work? We can help reach... [18:35:58] greg-g: https://phabricator.wikimedia.org/T94239#3047494 is wrong [18:36:38] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3047515 (10Slaporte) >>! In T94239#3047494, @greg wrote: >>>! In T94239#3047419, @Slaporte wrote: >> @mmodell: Which of these contributions were made by Wikimedia Foundation staf... [18:36:39] Krenair: tell me which parts so I can edit? Or do you want to comment in reply? I knew I was going to mess up when I hit submit... [18:36:58] At least, I think it was [18:37:03] But now looking at the commit I'm not so sure [18:37:08] :) [18:37:19] let me know :) I'll be afk for much of the day today [18:37:20] I uploaded it to Differential as @Krenair [18:38:01] But Diffusion shows the author as @AlexMonk-WMF [18:38:08] email? [18:38:15] possibly because of the alex@ email [18:38:19] I mean, was the email you used for the commit, yeah [18:38:29] that's how it figures that out [18:39:17] ugh [18:39:37] either way it's likely not copyrightable, so np [18:39:42] * greg-g nods [18:48:32] twentyafterfour im going to close down phab-01 as it's unused now and we want the private ip for phabricator for ssh :) [18:50:21] actually just shuting it down so no new instances can take the ip [19:00:58] RECOVERY - Puppet run on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [19:01:27] 10Continuous-Integration-Config, 10ContentTranslation, 03Language-2017 Sprint 2, 03Language-2017 Sprint 3, and 4 others: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2867222 (10Tgr) Are those write requests, to production? Could be caused by T154698 then. [19:10:19] 10Continuous-Integration-Config, 10ContentTranslation, 03Language-2017 Sprint 2, 03Language-2017 Sprint 3, and 4 others: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#3047644 (10Tgr) I see this is an old problem, nevermind then (soft blocks were deployed Tues... [19:30:25] 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Builds from mwext-testextension jobs sometimes pick up tests from unrelated skins - https://phabricator.wikimedia.org/T117710#3047699 (10Krinkle) 05Resolved>03Open * https://gerrit.wikimedia.org/r/#/c/339082/ (mediawiki/extensions/PerformanceInsp... [19:50:33] (03CR) 10Hashar: [C: 032] [Gamepress] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/339212 (owner: 10Umherirrender) [19:51:25] (03Merged) 10jenkins-bot: [Gamepress] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/339212 (owner: 10Umherirrender) [20:20:58] 10Continuous-Integration-Infrastructure, 13Patch-For-Review: Builds from mwext-testextension jobs sometimes pick up tests from unrelated skins - https://phabricator.wikimedia.org/T117710#3047899 (10hashar) Indeed, that is because some skins have the zuul template `mw-checks-test` which has the testextension jo... [20:38:54] twentyafterfour hi, how did you manage to get two ips working on git-ssh on port 22? [20:39:07] we are getting errors like error: Bind to port 22 on 10.68.20.25 failed: Address already in use. [20:43:34] 10Continuous-Integration-Config, 13Patch-For-Review: Phase out jobs puppet-validate jobs - https://phabricator.wikimedia.org/T158544#3047988 (10hashar) For mediawiki/vagrant there is also changes made for T154894: https://gerrit.wikimedia.org/r/#/c/337858/ https://gerrit.wikimedia.org/r/#/c/338415/ [20:46:17] (03PS1) 10Anomie: Add tests for css-sanitizer, and update TemplateStyles [integration/config] - 10https://gerrit.wikimedia.org/r/339248 [20:47:29] (03PS1) 10Hashar: mediawiki/vagrant: remove erblint-HEAD [integration/config] - 10https://gerrit.wikimedia.org/r/339249 (https://phabricator.wikimedia.org/T154894) [20:47:31] (03PS1) 10Hashar: Remove erblint-HEAD job [integration/config] - 10https://gerrit.wikimedia.org/r/339250 (https://phabricator.wikimedia.org/T154894) [20:48:32] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3048015 (10mmodell) WTFPL is only on the list because: humor. [20:51:19] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3048034 (10mmodell) [20:51:28] (03CR) 10Hashar: [C: 032] mediawiki/vagrant: remove erblint-HEAD [integration/config] - 10https://gerrit.wikimedia.org/r/339249 (https://phabricator.wikimedia.org/T154894) (owner: 10Hashar) [20:52:13] (03Merged) 10jenkins-bot: mediawiki/vagrant: remove erblint-HEAD [integration/config] - 10https://gerrit.wikimedia.org/r/339249 (https://phabricator.wikimedia.org/T154894) (owner: 10Hashar) [20:52:18] (03CR) 10Hashar: [C: 032] "Noop in Zuul :]" [integration/config] - 10https://gerrit.wikimedia.org/r/339250 (https://phabricator.wikimedia.org/T154894) (owner: 10Hashar) [20:53:38] (03Merged) 10jenkins-bot: Remove erblint-HEAD job [integration/config] - 10https://gerrit.wikimedia.org/r/339250 (https://phabricator.wikimedia.org/T154894) (owner: 10Hashar) [20:54:18] !log Deleted jenkins job erblint-HEAD. Fully replaced by rake / puppet-syntax gem - T154894 [20:54:23] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:54:23] T154894: Phase out jobs "pplint-HEAD" and "erblint-HEAD" - https://phabricator.wikimedia.org/T154894 [20:56:30] (03PS1) 10Hashar: Remove pplint-HEAD [integration/config] - 10https://gerrit.wikimedia.org/r/339255 (https://phabricator.wikimedia.org/T154894) [20:58:13] (03Abandoned) 10Hashar: [mediawiki/vagrant] drop erblint-HEAD [integration/config] - 10https://gerrit.wikimedia.org/r/338724 (https://phabricator.wikimedia.org/T154894) (owner: 10Hashar) [20:58:19] (03Abandoned) 10Hashar: Remove erblint-HEAD and pplint-HEAD [integration/config] - 10https://gerrit.wikimedia.org/r/338725 (https://phabricator.wikimedia.org/T154894) (owner: 10Hashar) [20:58:37] (03CR) 10Hashar: [C: 032] Remove pplint-HEAD [integration/config] - 10https://gerrit.wikimedia.org/r/339255 (https://phabricator.wikimedia.org/T154894) (owner: 10Hashar) [20:58:57] !log Deleted jenkins job pplint-HEAD. Fully replaced by rake / puppet-syntax gem - T154894 [20:59:02] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:59:45] (03Merged) 10jenkins-bot: Remove pplint-HEAD [integration/config] - 10https://gerrit.wikimedia.org/r/339255 (https://phabricator.wikimedia.org/T154894) (owner: 10Hashar) [21:00:35] 10Continuous-Integration-Config, 13Patch-For-Review: Phase out jobs "pplint-HEAD" and "erblint-HEAD" - https://phabricator.wikimedia.org/T154894#3048098 (10hashar) 05Open>03Resolved a:03hashar All repositories have been migrated to use puppetlabs_spec_helper / puppet-syntax. [21:06:52] (03PS1) 10Hashar: Clean out puppet-validate leftover [integration/config] - 10https://gerrit.wikimedia.org/r/339257 (https://phabricator.wikimedia.org/T158544) [21:09:54] (03CR) 10Hashar: [C: 032] Clean out puppet-validate leftover [integration/config] - 10https://gerrit.wikimedia.org/r/339257 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [21:11:15] (03Merged) 10jenkins-bot: Clean out puppet-validate leftover [integration/config] - 10https://gerrit.wikimedia.org/r/339257 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [21:12:18] 10Continuous-Integration-Config, 13Patch-For-Review: Phase out jobs puppet-validate jobs - https://phabricator.wikimedia.org/T158544#3048118 (10hashar) What is left to migrate is the translatewiki repo which has the puppet stuff in a sub directory. [21:37:44] twentyafterfour fixed it [21:37:59] it now has two private ips. with the help from mutante who helped me do it :) [21:44:11] 06Release-Engineering-Team, 06Operations, 10Phabricator: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3048219 (10Dzahn) puppet run LOOKS like it works, but ssh-phab service not started for real: ``` @phab2001:~# puppet age... [21:46:13] twentyafterfour ^^ [21:46:23] that error looks like the one i reported to you the other day [21:47:37] 06Release-Engineering-Team, 06Operations, 10Phabricator: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3048230 (10Dzahn) 13:46 Process: 34620 ExecStart=/usr/sbin/sshd -D -f<%= @sshd_config %> (code=exited, status... [21:48:28] (03PS1) 10Hashar: Experimental job translatewiki-rake-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/339299 (https://phabricator.wikimedia.org/T158544) [21:51:02] (03CR) 10Hashar: [C: 032] Experimental job translatewiki-rake-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/339299 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [21:53:44] (03Merged) 10jenkins-bot: Experimental job translatewiki-rake-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/339299 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [22:01:42] (03CR) 10Hashar: [C: 032] Add tests for css-sanitizer, and update TemplateStyles [integration/config] - 10https://gerrit.wikimedia.org/r/339248 (owner: 10Anomie) [22:01:45] (03PS2) 10Hashar: Add tests for css-sanitizer, and update TemplateStyles [integration/config] - 10https://gerrit.wikimedia.org/r/339248 (owner: 10Anomie) [22:01:58] (03CR) 10Hashar: [C: 032] "\O/" [integration/config] - 10https://gerrit.wikimedia.org/r/339248 (owner: 10Anomie) [22:02:38] hashar: sheesh calm down there we know you love cr+2 but geez xD jk [22:02:48] :] [22:03:14] hashar: one day... i will master the art of CI and jenkins [22:03:28] sure! [22:03:43] (03Merged) 10jenkins-bot: Add tests for css-sanitizer, and update TemplateStyles [integration/config] - 10https://gerrit.wikimedia.org/r/339248 (owner: 10Anomie) [22:03:49] Zppix: and feel free to send me an email with questions [22:04:01] since we might not be present on irc at the sametime [22:04:17] or maybe we can bring it on the public mailing list QA [22:04:43] hashar: who uses email anymore if i want something i just throw a rock through my monitor and hope comcrap (comcast) internet connection can handle it [22:04:54] ahah [22:05:04] we are still using IRC :D [22:05:17] https://xkcd.com/1782/ [22:05:23] hashar: better yet i'll just knock on the front door := [22:05:29] :P* [22:06:10] sure but make sure to give me a call first so the guardian can let you in ;] [22:07:00] I let myself in i already have a key [22:07:20] we are still using TCP/IP, omg [22:07:23] Anyway wheres the jobs configs for jenkins for repos stored? [22:07:32] I forget [22:08:10] "Who still uses e-mail" -- I wish no one sometimes [22:08:20] * RainbowSprinkles glances at his inbox, shudders at the pile of crap [22:08:41] RainbowSprinkles i use emails sometimes. But i havent even viewed my emails in at least a week [22:08:52] because i doint really like viewing my yahoo emails [22:09:03] RainbowSprinkles: im sitting at 27k unread emails strong (thats not including junk mail) [22:09:38] hashar: wheres the jenkins job config files stored isnt it integration-config? [22:09:44] Oh, I've only got about 10 unread ones right now, but they're all *hard* [22:09:52] Zppix: yeah integration/config.git [22:09:58] Ok thanka [22:10:01] people here can walk you through it :] [22:10:01] Thanks* [22:10:04] I'm a very firm believer in the church of inbox zero [22:10:08] paladox: with Yahoo somebody else can do i for you :) [22:10:22] hashar: no need i was just gonna edit a config for a repo of mine to setup email [22:10:37] i also hate email. the entire protocol :) [22:10:40] mutante really? [22:10:50] mutante: And running an MTA is the worst [22:10:54] Literally the worst [22:11:06] yes, 10 services [22:11:10] and if one breaks it all breaks [22:11:16] like spamd [22:11:18] RainbowSprinkles luckly my private email is migrating to BT email servers instead of yahoo [22:11:26] im so glad. [22:11:31] blame sendmail configuration language for being turing complete [22:11:36] No more russian ips trying to break into my email. [22:11:53] for the few I had to setup, I went with postfix. Way easier to gasp [22:12:12] mutante: My solution to spamd? I just have postfix mass-forward my domain to my gmail account and let gmail handle the spam for me :P [22:12:14] paladox: http://bgr.com/2017/02/16/yahoo-says-hackers-breached-your-account-in-new-attack-without-stealing-your-password/ [22:13:08] mutante: there is some puppet patch of mine you +2ed and rebased but apparently forgot to merge :] [22:13:09] RainbowSprinkles: in that case you could also just change the MX to google ? [22:13:13] that's what i did [22:13:15] Yeh im am laughing at how much yahoo cared for users privacy [22:13:16] mutante: https://gerrit.wikimedia.org/r/#/c/339174/ to fix a message in a fail() :] [22:13:17] but i want to switch again [22:13:23] 10Continuous-Integration-Config, 10Tool-Labs-tools-Zppixbot: Email on failed test (JJB) - https://phabricator.wikimedia.org/T158821#3048386 (10Zppix) [22:13:29] hashar: i tried 4 times and gave up [22:14:19] mutante: You can do that for a non-Gapps domain? [22:14:59] RainbowSprinkles: oh.. eh.. guess not . i considered that to be the same thing [22:15:03] mutante they sent another round of emails. Now i wonder how many users who use BT will sue yahoo. Maybe even bt. [22:15:16] paladox: now you are a Verizon customer [22:15:30] lol no im not. Im a three (uk) customer [22:15:41] but with there deals [22:15:53] How do i make it only email on failure i forget the syntax [22:16:03] i may one day when i go holiday there. Though they doint do prepaid (pay as you go) [22:16:06] Is it just recipents? [22:16:20] paladox: Verizon does prepaid [22:16:30] oh, does it do unlimited? [22:16:57] unlimited text and call in the US? yes [22:17:29] They have unlimited here. [22:17:38] it always is [22:17:58] three uk is the only provider that does unlimited [22:18:02] i havent even heard of a plan that let's you pay for each individual text or minute anymore [22:18:05] not here [22:18:07] mutante: too many traffic on puppet.git repo I guess. That is understandable :] [22:18:08] all the other ones are too big to care about unlimited [22:18:49] mutante: One of my mom's sisters has an ancient feature phone with a plan where she definitely pays per text [22:18:51] paladox: too big? wouldnt that be "too small"? [22:19:34] hashar: merged now :) [22:19:37] He plan/phone are also terrible: she's never been able to send me a text. Thinks I ignore her but I'm pretty sure it's on her end [22:19:41] *Her [22:19:50] mutante: awesome. And if you dont mind there is some noop change to tweak a rubocop rule https://gerrit.wikimedia.org/r/#/c/339175/ [22:20:02] mutante three (uk) is the smallest. But was buying out o2 which would have made it the biggest. But the eu rejected it on price grounds (higher prices) Well the prices are rising any ways [22:20:02] hashar: to email on job failure is -recipents: emailgoeshere right? [22:20:16] mutante: so it stop complaining on syntaxes like %r!/srv/foo! (rubocop asks us for curly braces: %r{/srv/foo} [22:20:30] Zppix: depends on the job [22:20:40] Its php55lint hashar [22:20:48] Zppix: but most of the jobs are triggered by multiple repositories. So you would end up receiving emails from unrelated patches [22:21:09] hashar: but if i put that inside of the project and job for my repo? [22:21:11] Zppix: then Zuul reports to Gerrit and Gerrit emails the change owner and reviewers [22:21:49] Like withhing tools.zppixbot in jjb/labs.yaml [22:21:54] Would that work? [22:22:02] Within* [22:22:13] we would need a job such as tools-zppixbot-php55lint [22:22:40] isn't it enough to get the email from Gerrit? [22:23:30] hashar: that exists [22:23:35] You created that [22:23:37] For me [22:23:41] ohh [22:23:56] So would putting recipents there work? [22:24:33] so in jjb/labs.yaml [22:24:58] the - project is a way to groups templates all sharing a common set of variables [22:25:04] Zppix: o/ [22:25:10] did you get the license done? [22:25:10] in this case the variable name = 'labs-tools-ZppixBot' [22:25:20] and the job template: '{name}-php55lint' [22:25:21] JustBerry: yes [22:25:27] Zppix: great [22:25:31] which ends up generating the job labs-tools-ZppixBot-php55lint [22:25:32] hey antoine [22:25:37] hey :) [22:25:45] hashar: but how do iget it to email upon failure [22:25:48] the thing is that the job template does not support emailing [22:25:59] Other projects i thought had that [22:26:06] Am i making that up [22:26:09] so either we make the job template to optinally support email (maybe there is a way to do it, I am not sure) [22:26:12] or we create another job [22:26:17] Ok nvm [22:26:45] then I am not sure it serves much purposes to be honest [22:26:52] 10Continuous-Integration-Config, 10Tool-Labs-tools-Zppixbot: Email on failed test (JJB) - https://phabricator.wikimedia.org/T158821#3048434 (10Zppix) 05Open>03declined Misunderstood information [22:27:45] Yeah i looked at jenkins documentation i misunderstood it [22:27:49] * Zppix trouts self [22:28:15] again when you send a patch to Gerrit, Zuul/Jenkins will report back the jobs results [22:28:27] which would spam your inbox with the success/failures [22:28:47] I know but i was wanting to have an email sent to all maintainers not just gerrit cc'd people [22:28:53] Nvm [22:28:57] ahhh [22:28:59] It was a good idea [22:29:06] yeah it is [22:29:18] another clumpsy way is to add all the maintainers using https://www.mediawiki.org/wiki/Git/Reviewers [22:29:24] Didnt wikidata or something want something similar [22:29:54] basically it is a list of repos and for each a list of people to add as areviewers [22:30:07] maybe you can add a Gerrit group instead of a user name [22:30:19] T152495 [22:30:20] T152495: E-Mail notification on failures of Wikidata-builds - https://phabricator.wikimedia.org/T152495 [22:30:22] eg makes member of the Gerrit group "labs-tools-ZppixBot" to be added as reviewers to each changes [22:30:27] I dunno if the reviewers bot handles groups, but gerrit does group expansion yes [22:30:34] (if you add a group as a reviewer) [22:30:40] hashar: see the task above [22:30:51] hashar: thats basically what my idea was [22:31:23] Zppix: added on my backlog for tomorrow [22:31:36] will look at it and offer some guidances [22:32:14] hashar: meh honestly if my idea will take to long dont worry about it i was just wanting to do it to get a feel for the code of jenkins [22:33:01] it just that is almost midnight here :] [22:33:13] i will reply and ask some questions to tobias [22:33:18] and offers a few guidances about jjb [22:33:31] and we can iterate from there until you get a patch that does what is requested. [22:33:36] that is a good training exercise :] [22:34:00] you can look at https://www.mediawiki.org/wiki/CI/JJB [22:34:05] I have [22:34:07] you would not be able to deploy jobs [22:34:14] but you can at least generate them locally [22:34:31] 06Release-Engineering-Team, 06Operations, 10Phabricator, 13Patch-For-Review: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3048444 (10Dzahn) works now on phab2001 > > > Notice: /Stage[main]/Phabricator::Vcs/Service[ssh-... [22:34:35] I tried that lets just say im still cleaninng up the mess xD [22:34:38] so typically what I do is I generate the jobs for the master branch in a reference directory like "output-prev" [22:34:51] then I hack the .yaml files, and generates jobs to a new dir like "output" [22:35:01] then I can just diff -r output-prev output [22:35:11] and watch the xml changes and see whether it would work or not [22:35:28] heck, you could even deploy the job on a local jenkins machine :] [22:35:56] maybe one day one will add a Dockerfile to easily reproduce part of the environment [22:36:34] Uh huh... xD [22:37:59] should be doable :] [22:39:20] Zppix: bed time for me. Have fun :] [22:58:54] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3048485 (10Paladox) I vote for apache2.