[00:12:30] 10MediaWiki-Codesniffer: Add rule for spaces inside short array notation braces - https://phabricator.wikimedia.org/T159097#3056692 (10Tgr) [00:53:42] 06Release-Engineering-Team, 06Operations, 10Phabricator, 07Technical-Debt: Replace deprecated phabricator conduit api calls in phab_epipe.py file - https://phabricator.wikimedia.org/T159043#3056743 (10Paladox) [06:36:45] 10MediaWiki-Codesniffer: Add rule for spaces inside short array notation braces - https://phabricator.wikimedia.org/T159097#3056860 (10Tgr) 05Open>03Invalid Don't mind me, `MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis` does this already. (I was looking at the review comments for h... [08:53:03] 10Gerrit: jenkins-bot ran gate-and-submit and voted V+2, but did not submit (merge) the change - https://phabricator.wikimedia.org/T155558#3057039 (10Paladox) Upstream have merged the backported commits I did. They may not fix the problem but it will throw a RestApiException instead of UpdateException. Also thi... [09:12:19] 06Release-Engineering-Team, 10Page-Previews: Generate compiled assets from continuous integration - https://phabricator.wikimedia.org/T158980#3053519 (10zeljkofilipin) >>! In T158980#3053533, @Jhernandez wrote: > @hashar Obviously I've forgotten which tag I needed to add for release-engineering :( Was it #rele... [09:22:05] (03PS1) 10Hashar: translatewiki: use rake as an entry point [integration/config] - 10https://gerrit.wikimedia.org/r/340089 (https://phabricator.wikimedia.org/T158544) [09:23:40] (03PS2) 10Hashar: translatewiki: use rake as an entry point [integration/config] - 10https://gerrit.wikimedia.org/r/340089 (https://phabricator.wikimedia.org/T158544) [09:25:08] 10Continuous-Integration-Config, 13Patch-For-Review: Phase out jobs puppet-validate and puppetlint-strict jobs - https://phabricator.wikimedia.org/T158544#3057207 (10hashar) [09:26:17] (03CR) 10jerkins-bot: [V: 04-1] translatewiki: use rake as an entry point [integration/config] - 10https://gerrit.wikimedia.org/r/340089 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [09:28:20] (03PS3) 10Hashar: translatewiki: use rake as an entry point [integration/config] - 10https://gerrit.wikimedia.org/r/340089 (https://phabricator.wikimedia.org/T158544) [09:28:22] (03PS1) 10Hashar: Remove '{name}-puppetlint-strict' [integration/config] - 10https://gerrit.wikimedia.org/r/340090 (https://phabricator.wikimedia.org/T158544) [09:28:36] final cleanup of the various ruby based jobs :-} [09:28:44] most everything is using 'rake test' now!!! [09:32:39] (03CR) 10Hashar: [C: 032] translatewiki: use rake as an entry point [integration/config] - 10https://gerrit.wikimedia.org/r/340089 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [09:32:45] (03CR) 10Hashar: [C: 032] Remove '{name}-puppetlint-strict' [integration/config] - 10https://gerrit.wikimedia.org/r/340090 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [09:34:21] (03Merged) 10jenkins-bot: translatewiki: use rake as an entry point [integration/config] - 10https://gerrit.wikimedia.org/r/340089 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [09:34:53] (03Merged) 10jenkins-bot: Remove '{name}-puppetlint-strict' [integration/config] - 10https://gerrit.wikimedia.org/r/340090 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [09:35:28] 10Continuous-Integration-Config, 13Patch-For-Review: Phase out jobs puppet-validate and puppetlint-strict jobs - https://phabricator.wikimedia.org/T158544#3057228 (10hashar) 05Open>03Resolved a:03hashar All migrated :} [09:41:17] (03PS1) 10Hashar: Tweak Zuul files filter for translatewiki-rake-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/340092 (https://phabricator.wikimedia.org/T158544) [09:47:40] (03CR) 10Hashar: [C: 032] Tweak Zuul files filter for translatewiki-rake-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/340092 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [09:48:43] (03Merged) 10jenkins-bot: Tweak Zuul files filter for translatewiki-rake-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/340092 (https://phabricator.wikimedia.org/T158544) (owner: 10Hashar) [09:53:20] (03PS2) 10Hashar: [WPtouch] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/339617 (owner: 10Umherirrender) [09:53:30] (03CR) 10Hashar: [C: 032] [WPtouch] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/339617 (owner: 10Umherirrender) [09:54:20] (03Merged) 10jenkins-bot: [WPtouch] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/339617 (owner: 10Umherirrender) [09:55:53] (03PS2) 10Hashar: labs/toollabs: Make debian-glue voting [integration/config] - 10https://gerrit.wikimedia.org/r/339914 (https://phabricator.wikimedia.org/T95098) (owner: 10Tim Landscheidt) [09:56:47] (03CR) 10Hashar: [C: 032] "\O/" [integration/config] - 10https://gerrit.wikimedia.org/r/339914 (https://phabricator.wikimedia.org/T95098) (owner: 10Tim Landscheidt) [09:57:48] (03Merged) 10jenkins-bot: labs/toollabs: Make debian-glue voting [integration/config] - 10https://gerrit.wikimedia.org/r/339914 (https://phabricator.wikimedia.org/T95098) (owner: 10Tim Landscheidt) [10:53:27] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3057453 (10hashar) >>! In T94239#3055319, @mmodell wrote: > Hmm, those who didn't vote for GPLv3: > @hashar, @halfak, @yuvipanda, @Dereckson > > Still attached to apache 2.0? s... [12:47:08] (03PS1) 10Zfilipin: WIP Release minor version 1.8.0 [selenium] - 10https://gerrit.wikimedia.org/r/340112 (https://phabricator.wikimedia.org/T158074) [12:50:02] (03CR) 10jerkins-bot: [V: 04-1] WIP Release minor version 1.8.0 [selenium] - 10https://gerrit.wikimedia.org/r/340112 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [13:00:11] (03PS2) 10Zfilipin: Release minor version 1.8.0 [selenium] - 10https://gerrit.wikimedia.org/r/340112 (https://phabricator.wikimedia.org/T158074) [13:00:45] 06Release-Engineering-Team, 10Icinga, 10Monitoring, 06Operations, 10Ops-Access-Requests: Rename Icinga contact 'amusso' to 'hashar' - https://phabricator.wikimedia.org/T158167#3057709 (10ema) p:05Triage>03Normal [13:01:10] (03PS3) 10Zfilipin: Release minor version 1.8.0 [selenium] - 10https://gerrit.wikimedia.org/r/340112 (https://phabricator.wikimedia.org/T158074) [13:06:20] (03CR) 10Zfilipin: "Too much release notes?" [selenium] - 10https://gerrit.wikimedia.org/r/340112 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [13:16:23] PROBLEM - Puppet run on jenkinstest is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [13:26:22] RECOVERY - Puppet run on jenkinstest is OK: OK: Less than 1.00% above the threshold [0.0] [13:39:04] 10Browser-Tests-Infrastructure, 10MediaWiki-General-or-Unknown, 07JavaScript, 13Patch-For-Review, and 2 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3057829 (10zeljkofilipin) [13:41:26] 06Release-Engineering-Team, 10Page-Previews: Generate compiled assets from continuous integration - https://phabricator.wikimedia.org/T158980#3057842 (10Jhernandez) Nice alias 😄 [13:43:29] 06Release-Engineering-Team, 10Page-Previews, 06Reading-Web-Backlog: Generate compiled assets from continuous integration - https://phabricator.wikimedia.org/T158980#3057845 (10Jhernandez) [13:50:58] 10Gerrit, 06Release-Engineering-Team, 10DBA, 06Operations, 13Patch-For-Review: Gerrit: Schedule downtime to migrate db to utf8mb4 - https://phabricator.wikimedia.org/T155764#3057861 (10ema) p:05Triage>03Normal [14:03:31] (03CR) 10Hashar: [C: 031] ":-} Lets wait for Dan?" [selenium] - 10https://gerrit.wikimedia.org/r/340112 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [14:06:06] (03CR) 10Zfilipin: [C: 032] Release minor version 1.8.0 [selenium] - 10https://gerrit.wikimedia.org/r/340112 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [14:07:28] (03Merged) 10jenkins-bot: Release minor version 1.8.0 [selenium] - 10https://gerrit.wikimedia.org/r/340112 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [14:08:07] (03CR) 10jenkins-bot: Release minor version 1.8.0 [selenium] - 10https://gerrit.wikimedia.org/r/340112 (https://phabricator.wikimedia.org/T158074) (owner: 10Zfilipin) [14:26:34] hashar: how did the auto-loader-dev thing or whatever that patch in integration/jenkins repo was go [15:39:40] hashar hi [15:39:49] i managed to get my test working for phpcs [15:40:22] https://gerrit.wikimedia.org/r/#/c/339666/ [15:40:33] i tested that on gerrit-test and gerrit-jenkins :) [15:40:35] works too [15:44:04] FlorianSW thankyou for all your reviews on gerrit-review (googlesource) for its-phabricator :) [15:59:17] 10Gerrit, 06Release-Engineering-Team, 06Operations: Make sure replying to emails in gerrit 2.14 works - https://phabricator.wikimedia.org/T158915#3058208 (10Paladox) This requires us to set this config https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#receiveemail [16:23:08] 10Gerrit, 06Release-Engineering-Team: Update gerrit to 2.14 - https://phabricator.wikimedia.org/T156120#3058360 (10Paladox) They are planning on branching gerrit 2.14 in the next few weeks. [16:25:59] 10Gerrit, 07Upstream: Gerrit should allow a published patch to be set to "draft" again. - https://phabricator.wikimedia.org/T63124#3058375 (10Paladox) @demon I'm proposing this task as declined as upstream are discontinuing the support for drafts and replacing it with private edits, which gerrit will migrate e... [16:27:52] 10Gerrit, 10Developer-Wishlist (2017), 07Documentation: Enable and document "WIP" workflow status in Gerrit - https://phabricator.wikimedia.org/T135245#3058396 (10Paladox) Upstream have started implementing hip status in gerrit now, no more proposal but actually implementing it :) [16:28:16] 10Gerrit, 10Developer-Wishlist (2017), 07Documentation, 07Upstream: Enable and document "WIP" workflow status in Gerrit - https://phabricator.wikimedia.org/T135245#3058397 (10Paladox) p:05Normal>03Lowest [16:29:45] 10Gerrit, 10Developer-Wishlist (2017), 07Documentation, 07Upstream: Enable and document "WIP" workflow status in Gerrit - https://phabricator.wikimedia.org/T135245#2292962 (10Paladox) See https://gerrit-review.googlesource.com/#/q/topic:wip-workflow+(status:open+OR+status:merged) [16:31:10] RainbowSprinkles upstream have this https://gerrit-review.googlesource.com/#/c/96323/ patch for dealing with spam (A whitelist and blacklist for emails) :) [16:32:48] oh i see thats for the new receiveemail config. [16:35:20] 10Deployment-Systems, 10Scap, 10scap2: scap wikiversions compile happening too late in scap sync - https://phabricator.wikimedia.org/T156851#3058409 (10thcipriani) 05Open>03Resolved [16:42:33] (03PS1) 10Umherirrender: [WikiShare] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/340141 [17:09:59] 10Gerrit, 07Upstream: Gerrit should allow a published patch to be set to "draft" again. - https://phabricator.wikimedia.org/T63124#3058526 (10demon) 05Open>03declined [17:11:37] 10Continuous-Integration-Config, 10ContentTranslation, 03Language-2017 Sprint 2, 03Language-2017 Sprint 3, and 4 others: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#3058531 (10hashar) Just to clarify, beside my comment from Feb 14th: I am not investigating... [17:14:05] 10MediaWiki-Releasing, 06Release-Engineering-Team (Long-Lived-Branches), 10MediaWiki-General-or-Unknown: Remove EOL MediaWiki release branches - https://phabricator.wikimedia.org/T92503#3058544 (10demon) 05Open>03declined I think we've spent more time discussing this than the problems we'll solve. //put... [17:29:01] 10Continuous-Integration-Config, 06Labs, 10Tool-Labs, 13Patch-For-Review: Make lintian warnings voting errors in labs/toollabs repository - https://phabricator.wikimedia.org/T95098#3058596 (10scfc) 05Open>03Resolved [17:50:06] (03CR) 10Hashar: [C: 032] [WikiShare] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/340141 (owner: 10Umherirrender) [17:52:33] (03Merged) 10jenkins-bot: [WikiShare] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/340141 (owner: 10Umherirrender) [18:15:56] Wow, phab-01 db is growing in size. [18:16:12] had to migrate mysql to /srv as / was getting out of storage. [18:20:59] sigh dropped off the meeting, I guess it ended? [18:24:21] thcipriani: ^ [18:24:40] godog: :) [18:25:09] yeah, we talked about lockfiles a bit at the end of the meeting and that was all I had and nobody had anything else :) [18:25:21] godog: tl;dr: you didn't miss much [18:26:06] hehe ok thanks [18:26:07] 10Beta-Cluster-Infrastructure, 06Labs, 10Wikimedia-General-or-Unknown, 13Patch-For-Review: rename -labs.php to -beta.php - https://phabricator.wikimedia.org/T150268#2780096 (10demon) Why? I'm not seeing any real benefit and a ton of potential breakage. [18:31:07] squid-labs.php -> varnish-cloud.php [18:32:31] twentyafterfour: FYI I see some keyholder changes slipped in after the migration to diffusion, e.g. https://gerrit.wikimedia.org/r/#/q/keyholder [19:00:59] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3058893 (10Ricordisamoa) Please also consider differences between GPLv3 only and GPLv3 or later. I'm not saying you should prefer one over the other but you should definitely mak... [19:02:27] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:04:43] 10Deployment-Systems, 10Scap, 13Patch-For-Review: Update Debian Package for Scap3 - https://phabricator.wikimedia.org/T127762#3058897 (10thcipriani) 05Resolved>03Open Hiya @fgiunchedi I just tagged a new Scap version (3.5.3-1) this morning {rMSCA7a2395a559eee2a564854e1778309a971b534399} — could I get you... [19:06:58] I'm having a hard time understanding the mw-log setup. I can cause php to crash on wikitech, but heck if I know where to look to see the error message. Can anyone advise? [19:07:13] I assume it's in a/mw-log on fluorine someplace... [19:07:52] Depends on the log you're looking for :) [19:08:08] So I have to know what's crashing before I can find what's crashing? [19:08:52] andrewbogott: Well, sorta. Is it HHVM? Or MW? [19:09:00] mw I think [19:09:05] Or is it not a "crash" and just some sort of bucketed fatal [19:09:22] You probably want error.log then [19:09:28] Or hhvm.log [19:09:35] fatal.log [19:09:37] My browser draws a nice, blank screen after the page loads [19:09:38] Likely sources [19:11:55] ok, there's this… 2017-02-27 19:11:42 [e30b5e656de4b7a83ef04a43] silver labswiki 1.29.0-wmf.13 fatal ERROR: [80440546] PHP Fatal Error: Maximum execution time of 30 seconds exceeded {"fatal_exception":{"class":"ErrorException","message":"PHP Fatal Error: Maximum execution time of 30 seconds [19:11:55] exceeded","code":1,"file":"/srv/mediawiki/php-1.29.0-wmf.13/includes/Message.php","line":1133,"trace":[{"function":"handleFatalError","class":"MWExceptionHandler","type":"::","args":[]}]},"exception_id":"80440546","caught_by":"mwe_handler"} [19:12:16] So we kill any page load that takes more than 30 seconds to render? [19:13:28] Yep [19:13:36] php's max_execution_time [19:13:53] can I override that in commonsettings, just to make sure that's the issue? [19:14:15] Nope, that's a PHP-level config [19:15:41] You could override in hiera [19:15:51] hhvm::extra::fcgi:max_execution_time [19:15:55] Couple of examples of that [19:16:16] hhvm::extra::fcgi::max_execution_time, actually [19:16:19] missed a second : [19:16:39] hm, yep, if I up it to 120 then the page renders [19:16:42] not that that's a great solution [19:18:00] s/great// [19:18:23] As I've been saying recently in a few other contexts: raising execution times isn't a solution to slow code. Making code *faster* is the solution :) [19:18:28] Curious what's causing it for you [19:19:03] RainbowSprinkles: It's because the page is fucking enormous [19:19:14] It's a corner case, showing the 'sudo' policies on the 'tools' project [19:19:25] which means doing fancy stuff per tool [19:19:29] which is… too much. [19:19:41] * RainbowSprinkles mutters something about using wikitech for openstack [19:19:42] :P [19:19:53] this doesn't have anything to do with openstack [19:19:58] but, striker is going to replace this functionality [19:20:03] so I don't much care to rewrite the code with paging [19:20:32] those hiera settings seem to mostly only act on hhvm boxes though… still looking [19:23:40] Yeah, it's not even puppetized on Silver [19:24:39] :( [20:06:17] 10Scap: Add blacklist support to scap.tasks.check_valid_syntax linter - https://phabricator.wikimedia.org/T136009#3059051 (10Legoktm) 05Open>03Resolved a:03Paladox [20:13:45] (03PS1) 10Umherirrender: [Poll] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/340172 [20:34:05] 10MediaWiki-Releasing, 10MediaWiki-Containers, 06Services, 15User-mobrovac: Ready-to-use Docker package for MediaWiki - https://phabricator.wikimedia.org/T92826#1121278 (10Ryan.lewkowicz) I've done a lot of work with this. I've even done rudimentary swarm deployments and some work with restbase: https://g... [20:40:38] (03CR) 10Hashar: [C: 032] [Poll] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/340172 (owner: 10Umherirrender) [20:41:29] (03Merged) 10jenkins-bot: [Poll] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/340172 (owner: 10Umherirrender) [20:57:26] (03PS1) 10Legoktm: Port git-changed-in-head to Python [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340181 [20:57:28] (03PS1) 10Legoktm: Don't lint composer/autoload_static.php [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340182 (https://phabricator.wikimedia.org/T136021) [21:04:17] 06Release-Engineering-Team, 10Icinga, 10Monitoring, 06Operations, and 2 others: Rename Icinga contact 'amusso' to 'hashar' - https://phabricator.wikimedia.org/T158167#3059206 (10RobH) 05Open>03Resolved done and tested successfully, resolving. [21:04:32] 06Release-Engineering-Team, 10Icinga, 10Monitoring, 06Operations, and 2 others: Rename Icinga contact 'amusso' to 'hashar' - https://phabricator.wikimedia.org/T158167#3059208 (10hashar) icinga yields => "Your command requests were successfully submitted to Icinga for processing." I have managed to leave a... [21:05:02] (03CR) 10Legoktm: "I did testing of this locally and it matched the bash version in all cases. And I assume Python 3 is installed on all CI nodes." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340181 (owner: 10Legoktm) [21:36:57] !log Update mobileapps to c924126 [21:37:00] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:41:33] legoktm: eventually I would love a babel version of git-changed-in-head :} [21:41:46] with binding for python/ruby/bash/php :-} [21:41:59] heh :) [21:42:17] I have already ported it to ruby for operations/puppet.git (somewhere in the Rakefile ) [21:42:25] and got one for PHP somewhere [21:42:49] draft/ wip : https://gerrit.wikimedia.org/r/#/c/339675/1/tests/phpcs/bootstrap-ci.php [21:43:39] bleh [21:44:04] is the python version okay then? [21:48:42] hashar: I mostly just want to unblock the newer composer vendor issue [21:49:24] legoktm i have a patch for mw core to allow us to move from phplint to phplint in composer for mw core. [21:49:45] legoktm https://gerrit.wikimedia.org/r/#/c/339666/ [21:49:55] (03CR) 10Hashar: "Lets pythonize the world. Python 3 should be fine, even Precise has python 3.2 \O/" (034 comments) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340181 (owner: 10Legoktm) [21:49:58] and i've tested it too. [21:50:12] Should hopefully unblock us going with a newer composer version. [21:50:30] legoktm: yeah python3 is fine. The code looks fine at first glance. But Iam not sure how the output is generated in bash [21:50:43] you know, newlines separated or space separated [21:50:55] but I think it is newlines [21:54:07] (03CR) 10Hashar: Port git-changed-in-head to Python (031 comment) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340181 (owner: 10Legoktm) [21:54:25] legoktm: also the bash version had '--' [21:54:34] to separate git options from its arguments (the file extensions) [21:54:57] probably does not matter but maybe I did add '--' on purpose because of some corner case [21:59:41] 10Gerrit, 10Developer-Wishlist (2017), 07Documentation, 07Upstream: Enable and document "WIP" workflow status in Gerrit - https://phabricator.wikimedia.org/T135245#3059403 (10hashar) There is a proposal at https://gerrit-review.googlesource.com/#/c/97245/ by David Ostrovsky. And he proposes patches to drop... [22:00:17] legoktm: for mediawiki/vendor, I would like to drop php55lint and switch to composer and parallel-lint [22:01:03] 10Gerrit, 10Developer-Wishlist (2017), 07Documentation, 07Upstream: Enable and document "WIP" workflow status in Gerrit - https://phabricator.wikimedia.org/T135245#3059412 (10Paladox) >>! In T135245#3059403, @hashar wrote: > There is a proposal at https://gerrit-review.googlesource.com/#/c/97245/ by David... [22:02:36] legoktm: and also we don't commit composer/autoload_static.php which maybe would benefit hhvm [22:03:23] ah no [22:03:25] !defined('HHVM_VERSION') [22:03:27] :D [22:12:57] (03PS1) 10Hashar: Experimental composer tests for mediawiki/vendor [integration/config] - 10https://gerrit.wikimedia.org/r/340241 (https://phabricator.wikimedia.org/T135161) [22:13:35] (03CR) 10Paladox: [C: 031] Experimental composer tests for mediawiki/vendor [integration/config] - 10https://gerrit.wikimedia.org/r/340241 (https://phabricator.wikimedia.org/T135161) (owner: 10Hashar) [22:27:57] (03CR) 10Hashar: [C: 031] "legoktm I say go for it and I would eventually follow up with the few nitpick I mentioned." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340181 (owner: 10Legoktm) [22:28:02] legoktm: go for it :} [22:28:25] I thought git-changed-in-head was used in a lot more patches [22:28:25] err [22:28:27] in a lot more jobs [22:30:01] I am off / sleep etc [23:03:09] 05Gerrit-Migration, 10Differential, 15User-greg: Uploading a new Differential Revision does not reset “Accept” states in commit messages - https://phabricator.wikimedia.org/T164#3059606 (10scfc) @mmodell: When you review code, you can do so informally: "Yeah, looks alright, bro." +1/+2 are formalized statem... [23:12:14] 05Gerrit-Migration, 10Differential, 15User-greg: Uploading a new Differential Revision does not reset “Accept” states in commit messages - https://phabricator.wikimedia.org/T164#2200 (10demon) +1 proves nothing beyond your ability to click something with a mouse. I take almost no stock in seeing +1s on a pat... [23:29:36] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#3059734 (10mmodell) [23:30:09] 10Scap, 06WMF-Legal, 07Documentation, 07Software-Licensing: Scap is lacking a license - https://phabricator.wikimedia.org/T94239#1158049 (10mmodell) [23:44:16] 05Gerrit-Migration, 10Differential, 15User-greg: Uploading a new Differential Revision does not reset “Accept” states in commit messages - https://phabricator.wikimedia.org/T164#2200 (10ksmith) >>! In T164#3059644, @demon wrote: > +1 proves nothing beyond your ability to click something with a mouse. I take... [23:52:31] 05Gerrit-Migration, 10Differential, 15User-greg: Uploading a new Differential Revision does not reset “Accept” states in commit messages - https://phabricator.wikimedia.org/T164#3059781 (10scfc) IMHO yes: Words are ambiguous and sometimes hard to parse, "+1"s are "binary". [23:55:15] 05Gerrit-Migration, 10Differential, 15User-greg: Uploading a new Differential Revision does not reset “Accept” states in commit messages - https://phabricator.wikimedia.org/T164#3059793 (10demon) Yes, +1/-1 **with** a comment is useful because it lets me know (before reading) if the comments will be mostly p...