[00:21:16] Project beta-update-databases-eqiad build #15329: 04STILL FAILING in 1 min 15 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/15329/ [00:35:00] PROBLEM - puppet last run on contint2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [00:41:00] RECOVERY - puppet last run on contint2001 is OK: OK: Puppet is currently enabled, last run 11 seconds ago with 0 failures [00:56:08] Project beta-scap-eqiad build #144430: 04FAILURE in 1 min 22 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144430/ [00:58:48] that'll be fixed now [00:59:28] Project beta-scap-eqiad build #144431: 04STILL FAILING in 1 min 14 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144431/ [00:59:47] oh sod off [01:01:20] Project beta-scap-eqiad build #144432: 04STILL FAILING in 1 min 14 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144432/ [01:02:18] Different error [01:02:18] 01:01:00 01:01:00 ['/usr/bin/scap', 'pull-master', 'deployment-tin.deployment-prep.eqiad.wmflabs'] on deployment-mira.deployment-prep.eqiad.wmflabs returned [255]: Host key verification failed. [01:03:28] !log beta-scap-eqiad giving Host key verification failed [01:03:31] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:06:09] Project beta-scap-eqiad build #144433: 04STILL FAILING in 1 min 20 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144433/ [01:16:15] Project beta-scap-eqiad build #144434: 04STILL FAILING in 1 min 27 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144434/ [01:21:22] Yippee, build fixed! [01:21:22] Project beta-update-databases-eqiad build #15330: 09FIXED in 1 min 21 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/15330/ [01:27:02] Yippee, build fixed! [01:27:02] Project beta-scap-eqiad build #144435: 09FIXED in 2 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144435/ [04:14:14] (03PS1) 10Catrope: Add TheWikipediaLibrary extension [integration/config] - 10https://gerrit.wikimedia.org/r/340465 [04:16:06] (03CR) 10jerkins-bot: [V: 04-1] Add TheWikipediaLibrary extension [integration/config] - 10https://gerrit.wikimedia.org/r/340465 (owner: 10Catrope) [04:17:18] (03CR) 10Catrope: [C: 04-1] "It's already in there, I missed it" [integration/config] - 10https://gerrit.wikimedia.org/r/340465 (owner: 10Catrope) [04:18:03] (03PS2) 10Catrope: Make TheWikipediaLibrary depend on Echo [integration/config] - 10https://gerrit.wikimedia.org/r/340465 [04:27:28] (03CR) 10Krinkle: [C: 032] Make TheWikipediaLibrary depend on Echo [integration/config] - 10https://gerrit.wikimedia.org/r/340465 (owner: 10Catrope) [04:28:11] RoanKattouw: Will roll out in a minute [04:28:16] Cool thanks [04:28:20] (03Merged) 10jenkins-bot: Make TheWikipediaLibrary depend on Echo [integration/config] - 10https://gerrit.wikimedia.org/r/340465 (owner: 10Catrope) [04:28:40] !log Reloading Zuul to deploy https://gerrit.wikimedia.org/r/340465 [04:28:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:56:11] Project beta-scap-eqiad build #144456: 04FAILURE in 1 min 23 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144456/ [05:00:36] 04:56:11 04:56:11 sudo -u mwdeploy -n -- /usr/bin/rsync -l deployment-tin.deployment-prep.eqiad.wmflabs::common/wikiversions*.{json,php} /srv/mediawiki on deployment-tmh01.deployment-prep.eqiad.wmflabs returned [255]: Host key verification failed. [05:00:53] oh, that's already logged [05:03:42] (03CR) 10Krinkle: [C: 031] "Untested." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340280 (owner: 10Legoktm) [05:06:19] Project beta-scap-eqiad build #144457: 04STILL FAILING in 1 min 24 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144457/ [05:16:15] Project beta-scap-eqiad build #144458: 04STILL FAILING in 1 min 23 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144458/ [05:27:59] Yippee, build fixed! [05:27:59] Project beta-scap-eqiad build #144459: 09FIXED in 3 min 3 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144459/ [06:28:32] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<30.00%) [07:08:33] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [08:56:14] Project beta-scap-eqiad build #144481: 04FAILURE in 1 min 23 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144481/ [09:06:14] Project beta-scap-eqiad build #144482: 04STILL FAILING in 1 min 21 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144482/ [09:09:15] Project beta-scap-eqiad build #144483: 04STILL FAILING in 1 min 15 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144483/ [09:16:11] Project beta-scap-eqiad build #144484: 04STILL FAILING in 1 min 24 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144484/ [09:27:14] Yippee, build fixed! [09:27:15] Project beta-scap-eqiad build #144485: 09FIXED in 2 min 23 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144485/ [09:30:12] 10Browser-Tests-Infrastructure, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Browser-Tests, 03Wikidata-Sprint: [Bug] Special:SetLabel browser tests failing, but unable to run tests locally - https://phabricator.wikimedia.org/T159317#3063909 (10thiemowmde) [09:30:36] 10Browser-Tests-Infrastructure, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Browser-Tests, 03Wikidata-Sprint: [Bug] Special:SetLabel browser tests failing, but unable to run tests locally - https://phabricator.wikimedia.org/T159317#3063924 (10thiemowmde) p:05Triage>03Unbreak! [09:38:01] (03PS1) 10Legoktm: Fix flake8 issues [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/340482 [09:38:03] (03PS1) 10Legoktm: build: Test against py36 if available [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/340483 [09:39:18] (03CR) 10Legoktm: Refactor git-changed-in-head to use a class (031 comment) [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340280 (owner: 10Legoktm) [09:41:23] (03PS3) 10Legoktm: Refactor git-changed-in-head to use a class [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340280 [09:43:37] (03CR) 10Legoktm: [C: 032] Refactor git-changed-in-head to use a class [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340280 (owner: 10Legoktm) [09:59:44] (03Merged) 10jenkins-bot: Refactor git-changed-in-head to use a class [integration/jenkins] - 10https://gerrit.wikimedia.org/r/340280 (owner: 10Legoktm) [10:00:29] !log deployed https://gerrit.wikimedia.org/r/340280 to slaves [10:00:32] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:08:44] hashar hi, im wondering is the git-daemon problems only happening after a reboot? [11:09:02] paladox: no only on the first provisionning [11:09:09] Oh [11:09:23] does it use a pid? or /var/run? [11:09:41] systemd [11:09:59] but the issue is in puppet I think [11:10:42] Oh, i had a problem with phd (phabricator) Where it woulden't work after reboot. Now works. Dzahn said it may have been the same problem. [11:11:08] was it on labs? [11:11:18] you might want to look at the puppet.log [11:27:43] Yep [11:28:01] hashar it only affected debian though since we were using systemd. [11:28:12] I have found a fix for it though :) [11:29:07] paladox: there is a task about it somewhere [11:29:13] Oh [11:29:23] it was because /var/run/phd was not being created [11:29:26] related to zuul-merger / git-daemon let me find it [11:29:28] ahh [11:29:43] is that using systemd? [11:29:56] you probably need to have the systemd service to create the dir [11:30:00] though that depends what is stored in there [11:30:12] if it is only a pid file to keep the process pid, that should not be necessary [11:30:13] Yeh, heres my fix https://gerrit.wikimedia.org/r/#/c/340242/ [11:30:25] systemd is able to track the PID all by itself, so the .pid file is not needed [11:30:31] and hence /var/run/phd would not be needed either [11:30:46] yep [11:31:13] https://phabricator.wikimedia.org/T157785 "zuul-merger git-daemon process is not started properly by systemd ?" [11:31:22] yep [11:31:26] which is a different issue probably [11:31:26] coud that be related? [11:31:38] it is just puppet being confused iirc [11:31:52] that uses init it seems. I found a systemd one [11:33:00] looked at your patch for phd, they are different issue [11:33:07] your is just /var/run/phd missing [11:33:20] oh [11:33:21] yep [11:33:26] git-daemon is an issue with puppet itself being confused between the systemd service and the sysvinit script [11:33:40] Oh [11:33:50] We could possibly add the systemd version? [11:33:53] I found two versions [11:34:02] http://pkgs.fedoraproject.org/cgit/rpms/git.git/commit/?id=906d8479f79ee89ec399fa5988b11fa037f18d38 and https://gist.github.com/zinovyev/5828aa70db3ba96169ddabd5d8bdd9ed [11:34:36] there is one already [11:34:40] err I mean [11:34:48] we install gitdaemon-sysvinit packages [11:34:56] Oh [11:34:58] that provides sysvinit scripts like /etc/init.d/git-daemon [11:35:02] yep [11:35:06] and systemd somehow is able to manage services using those scripts [11:35:28] oh [11:35:29] but puppet somehow get confused [11:35:49] I guess we could introduce a systemd script to keep puppet happy [11:35:57] even if we call the init version from systemd [11:36:37] Debug: Executing '/usr/sbin/service git-daemon status' [11:36:38] Debug: Executing '/bin/systemctl show -pSourcePath git-daemon' [11:37:43] Soemthing lik https://phabricator.wikimedia.org/P5005 [11:37:53] lik = like [11:38:33] apparently, hashar doing systemctl status git-daemon [11:39:04] shows the status of git-daemon so it's not a puppet issue. Wather it's systemd using the init version [11:39:15] root@gerrit-test:/home/paladox# systemctl status git-daemon [11:39:16] ● git-daemon.service - LSB: git-daemon service [11:39:16] Loaded: loaded (/etc/init.d/git-daemon) [11:39:16] Active: active (running) since Sun 2017-02-12 14:23:12 UTC; 2 weeks 2 days ago [11:41:47] there is a bug in puppet that is shipped with ubuntu trusty that it does not know how to use systemctl status over /bin/status unless you tell explicitly to use systemd [11:41:59] sorry, ubuntu 16.04, xenial [11:42:07] yeah probably related [11:42:10] though that one is on Jessie [11:42:15] but it is probably very similar [11:43:40] Oh [11:45:04] hashar http://unix.stackexchange.com/questions/233468/how-does-systemd-use-etc-init-d-scripts [11:47:13] It's backword compat with sysvinit [11:48:41] hashar most likly this https://phabricator.wikimedia.org/P5005 will work as we can enable it on boot [11:49:21] "This is a commented section which is ignored by SysV. On the other hand, systemd reads that dependency information and runs those scripts depending on that." [11:49:27] that's probaly why it dosen' [11:49:40] dosen't start on boot [11:49:47] Fetched 142 MB in 7s (18.8 MB/s) [11:49:47] lovely [11:49:51] or when you were doing a new instance. [11:50:01] lol, what were you downloading for it to be that quick [11:50:15] I downloaded 7 times the size of my first hard drive (20MB) in just 7 seconds .... [11:50:21] oh [11:50:28] apt update on my home machine [11:50:36] oh [11:55:40] hashar i just installed git-daemon-sysvinit on phabricator and it says exited too [11:56:15] :D [11:56:31] Project beta-scap-eqiad build #144500: 04FAILURE in 1 min 36 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144500/ [12:06:18] Project beta-scap-eqiad build #144501: 04STILL FAILING in 1 min 23 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144501/ [12:09:08] (03CR) 10Hashar: [3D] Add CI (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/340436 (https://phabricator.wikimedia.org/T159243) (owner: 10Jforrester) [12:09:11] (03PS2) 10Hashar: [3D] Add CI [integration/config] - 10https://gerrit.wikimedia.org/r/340436 (https://phabricator.wikimedia.org/T159243) (owner: 10Jforrester) [12:12:20] hashar /me wonders weather adding the systemd version i created will work in starting automatically. [12:12:30] for https://docs.puppet.com/puppet/latest/types/service.html#service-attribute-provider [12:12:35] we could put systemd [12:13:24] (03CR) 10Hashar: [C: 032] [3D] Add CI [integration/config] - 10https://gerrit.wikimedia.org/r/340436 (https://phabricator.wikimedia.org/T159243) (owner: 10Jforrester) [12:14:13] (03Merged) 10jenkins-bot: [3D] Add CI [integration/config] - 10https://gerrit.wikimedia.org/r/340436 (https://phabricator.wikimedia.org/T159243) (owner: 10Jforrester) [12:16:30] Project beta-scap-eqiad build #144502: 04STILL FAILING in 1 min 33 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144502/ [12:20:10] hashar https://gerrit.wikimedia.org/r/#/c/340495/ [12:20:29] that adds quotes around running. I doint think you can have it without quotes. [12:21:05] !log deployment-prep cleaning out git repos on deployment-tin [12:21:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:27:11] Yippee, build fixed! [12:27:11] Project beta-scap-eqiad build #144503: 09FIXED in 2 min 17 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144503/ [12:27:18] hashar i think that https://gerrit.wikimedia.org/r/#/c/340496/ may fix it [12:28:46] :) [12:50:01] (03PS1) 10Hashar: 3D depends on MultimediaViewer [integration/config] - 10https://gerrit.wikimedia.org/r/340499 (https://phabricator.wikimedia.org/T159243) [12:50:45] paladox: would want to actually reproduce the issue [12:50:50] and verify it DOES fix it :} [12:51:12] (03CR) 10Hashar: [C: 032] 3D depends on MultimediaViewer [integration/config] - 10https://gerrit.wikimedia.org/r/340499 (https://phabricator.wikimedia.org/T159243) (owner: 10Hashar) [12:51:58] (03Merged) 10jenkins-bot: 3D depends on MultimediaViewer [integration/config] - 10https://gerrit.wikimedia.org/r/340499 (https://phabricator.wikimedia.org/T159243) (owner: 10Hashar) [12:52:57] 10Continuous-Integration-Config, 103d, 06Editing-Department, 06Multimedia, 13Patch-For-Review: Set up CI for the 3D extension - https://phabricator.wikimedia.org/T159243#3064290 (10hashar) It is almost done :} I took the liberty to hijack the patch that fix PHP CodeSniffer https://gerrit.wikimedia.org/... [13:24:46] ok [13:32:35] 10MediaWiki-Codesniffer, 13Patch-For-Review: phplint doesn't run on .inc files - https://phabricator.wikimedia.org/T116524#3064337 (10Aklapper) 05Open>03declined Declining as per T116524#1914090 - please reopen if I misunderstood :) [13:45:01] (03CR) 10Hashar: [C: 032] Fix flake8 issues [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/340482 (owner: 10Legoktm) [13:45:30] (03CR) 10Hashar: [C: 032] build: Test against py36 if available [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/340483 (owner: 10Legoktm) [13:45:40] (03Merged) 10jenkins-bot: Fix flake8 issues [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/340482 (owner: 10Legoktm) [13:46:11] (03Merged) 10jenkins-bot: build: Test against py36 if available [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/340483 (owner: 10Legoktm) [13:46:59] hashar: I end up sometimes just making the commit again ontop of master and reusing the change-id [13:47:00] for ease [13:47:14] hashar it shows that it changes it from stopped to running. [13:47:21] but it seems it still shows exited [13:47:34] paladox: I am not going to look at it anytime soon :} [13:47:39] got too many things to handle already [13:47:41] ok [13:47:46] Reedy: for the mediawiki/vendor change? [13:47:51] yeah [13:47:58] I notice yours still has two types of hash... Which it shouldn't [13:48:05] "hash": "b86de96f7202dfed817a9fa8dff87fe5", [13:48:05] "content-hash": "f7f00cd1aac5b9df4ee111e7493ea4a9", [13:48:16] yeah that is from whatever composer version I have used [13:48:21] probably the one form integration/composer [13:54:04] Reedy: honestly, I am tempted to just get rid of mediawiki/vendor [13:55:09] I +1 to that as why do we need it when we have composer.json in mediawiki/core? [13:55:36] for wikimedia deployments [13:55:48] we don't run composer or any other package manager on the wikimedia infra [13:56:21] Project beta-scap-eqiad build #144512: 04FAILURE in 1 min 27 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144512/ [14:00:24] 10Continuous-Integration-Config, 103d, 06Editing-Department, 06Multimedia, 13Patch-For-Review: Set up CI for the 3D extension - https://phabricator.wikimedia.org/T159243#3064391 (10Gilles) Speaking of what state it was when I left it, the dependency on MediaViewer is a soft one. If it's present, the 3D e... [14:06:28] Project beta-scap-eqiad build #144513: 04STILL FAILING in 1 min 26 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144513/ [14:07:50] Project beta-scap-eqiad build #144514: 04STILL FAILING in 1 min 20 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144514/ [14:09:09] F*** puppet [14:12:14] 10Beta-Cluster-Infrastructure, 06Release-Engineering-Team: Beta cluster scap job ( beta-scap-eqiad ) fails due to puppet erasing /etc/ssh/ssh_known_hosts - https://phabricator.wikimedia.org/T159332#3064414 (10hashar) [14:13:03] !log deployment-prep : on deployment-tin removed empty dir /etc/ssh/userkeys/root.d . Causes puppet noise [14:13:06] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:17:35] Yippee, build fixed! [14:17:36] Project beta-scap-eqiad build #144515: 09FIXED in 2 min 31 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144515/ [14:23:27] PROBLEM - Puppet run on deployment-tin is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [14:56:26] Project beta-scap-eqiad build #144518: 04FAILURE in 1 min 31 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144518/ [15:06:28] Project beta-scap-eqiad build #144519: 04STILL FAILING in 1 min 33 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144519/ [15:08:28] RECOVERY - Puppet run on deployment-tin is OK: OK: Less than 1.00% above the threshold [0.0] [15:08:43] 10Continuous-Integration-Config, 06Release-Engineering-Team, 06Discovery, 06Discovery-Analysis: Add CI to all wikimedia/discovery repositories that are active - https://phabricator.wikimedia.org/T153856#3064571 (10Aklapper) @debt: Any reply to the last comment / reconsidering? :) [15:16:25] Project beta-scap-eqiad build #144520: 04STILL FAILING in 1 min 31 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144520/ [15:17:25] 06Release-Engineering-Team, 10DBA: Missing / Dropped databases? - https://phabricator.wikimedia.org/T132838#2211904 (10Marostegui) We had this same issue with the dbstore servers while working on: T155605 [15:27:23] Yippee, build fixed! [15:27:23] Project beta-scap-eqiad build #144521: 09FIXED in 2 min 25 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144521/ [15:31:01] 10Browser-Tests-Infrastructure, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Browser-Tests, 03Wikidata-Sprint: [Bug] Special:SetLabel browser tests failing, but unable to run tests locally - https://phabricator.wikimedia.org/T159317#3064614 (10zeljkofilipin) @thiemowmde There were some major... [15:32:37] 10Browser-Tests-Infrastructure, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 07Browser-Tests, 03Wikidata-Sprint: [Bug] Special:SetLabel browser tests failing, but unable to run tests locally - https://phabricator.wikimedia.org/T159317#3064615 (10zeljkofilipin) Also, I have recently updated Sele... [15:32:41] hashar it's most likly because when it starts git-daemon it returns a 0 [15:32:43] for success [15:33:18] even though 0 is not success but in the script it is [15:58:17] hashar: I'm a little confused, https://integration.wikimedia.org/ci/job/composer-php55-trusty/14756/console says there's a #-comment somewhere, but we've removed them all as far as I can tell [15:58:23] Going to try running it again but I dunno [15:58:48] marktraceur: Ignore that [15:58:49] 12:20:42 PHP Deprecated: Comments starting with '#' are deprecated in /etc/php5/cli/conf.d/20-xhprof.ini on line 2 in Unknown on line 0 [15:58:51] marktraceur: the command being run is "phpcs -p -s" [15:58:56] Literally, it's in that xhprof file [15:59:01] Oh, pff. [15:59:04] 12:20:42 ERROR: You must supply at least one file or directory to process. [15:59:04] * marktraceur ignores [15:59:07] That's what you want to fix [15:59:10] marktraceur: but phpcs requires a path to be given to it. That can be done either in a phpcs.xml file or by adding an argument [15:59:11] Oh. [15:59:15] we use a phpcs.xml [15:59:25] that would gives the default path to act on (eg: . ) [15:59:42] oh that is for 3D isn't it ? [16:00:06] marktraceur: you want to first land https://gerrit.wikimedia.org/r/#/c/340342/ [16:00:19] that should fix phpcs [16:00:36] I have slightly rewrote James patch (basically removed the version bumps in composer.json ) [16:01:03] the MediaWiki structure tests fails due to some oddity with resourceloader [16:01:26] OK. [16:01:47] marktraceur: https://phabricator.wikimedia.org/T159243#3064290 I gave some diagnostics [16:02:12] MultimediaViewer could be an optional dependency but extension.json does not have support for that [16:02:34] so one has to move the resource loaders from extension.json to some RL hook which would register the mmv modules only when MultimediaViewer is available [16:02:54] but most probably you can just ignore that and assume that mmv is always there (I have setup CI to inject mmv already) [16:02:58] Well, fair enough [16:03:05] but [16:03:09] Problem is when someone wants 3D files but not MMV [16:03:15] if one installs 3D without mmv, there might be some issue in resource loader [16:03:24] But that's not currently a problem, since we're hoping to push to WMF. [16:03:41] I had that issue when testing the mediawiki tarball :/ [16:04:06] Matt Flaschen found a trick : https://gerrit.wikimedia.org/r/#/c/305691/ :} [16:04:30] Well, that means I can add back the hooks file I suppose. [16:04:34] But it can be done later [16:04:48] yup [16:05:07] and there is some task filled to have extension registration to have RL to support conditional registration [16:08:02] hashar: Force-merge that phpcs.xml patch, you said? [16:08:08] yup [16:08:19] because the mediawiki PHPUnit structure tests fail [16:08:30] Mmkay. [16:08:35] {{done}} [16:08:37] shit happens :} [16:09:11] then 3D has a /composer.lock file committed in the git repo [16:09:16] which afaik we usually don't do [16:09:31] preferring to set versions in composer.json [16:09:59] I would drop the composer.lock entirely and add it to .gitignore but maybe there is a reason it has been added [16:10:10] CI should not be impacted since it runs "composer update" [16:10:32] but that means whenever one change some dependencies in composer.json he/she has to remember to also add the composer.lock [16:10:57] hashar: I'll add another commit to remove it. [16:12:40] poke the task as needed, I am subscribed to it [16:13:56] hashar: Are you CRing anything here, or should I bother James? [16:14:15] if you add me as a reviewer I will :} [16:15:36] Done [16:22:25] bah [16:22:33] we can't beat James_F :} [16:22:45] * James_F coughs. :-) [16:23:16] James_F: now you can easily bump versions in composer.json for the 3D ext [16:23:27] I lamely hijacked your patch to get the composer job to pass [16:23:39] hashar: I noticed. And totally broke the chain of patches underneath it. ;-P [16:23:46] yeah :( [16:23:55] Ah well, marktraceur's problem now. [16:23:58] God damn it [16:24:01] ;-D [16:24:31] Wait, which patch was this? [16:24:47] Oh, the phpcs.xml one? [16:25:00] I rebased it [16:25:39] marktraceur: Theoretically with https://gerrit.wikimedia.org/r/#/c/340519/ the repo should now pass CI. [16:25:53] Also I should add stylelint; one moment. [16:25:54] OK [16:26:18] * marktraceur waits [16:27:54] James_F: marktraceur : https://gerrit.wikimedia.org/r/340520 build: Update composer-installed tools to latest [16:28:03] that is the composer version bump james did previously [16:28:11] now pretty simple since composer.lock is gone [16:29:52] James_F: So, not to criticize, but it doesn't look like anything exists with the name "ext.3d" [16:30:07] There's mmv.3d.js and mmv.3d.less, but nothing for ext.3d [16:31:30] Psh. Details. [16:31:50] I don't know what that module is even meant to do [16:31:54] Let's move this to -multimedia and save RelEng's screens. [16:31:59] OK! [16:48:20] 10Continuous-Integration-Infrastructure, 07Technical-Debt: Jenkins: Figure out a long term solution to maintaining Jenkins configuration - https://phabricator.wikimedia.org/T69027#3064884 (10hashar) Been playing it a bit with this today. On jenkintest.integration.eqiad.wmflabs I have installed a basic jenkins... [16:52:01] 10Continuous-Integration-Config, 06Release-Engineering-Team, 06Discovery, 06Discovery-Analysis: Add CI to all wikimedia/discovery repositories that are active - https://phabricator.wikimedia.org/T153856#3064894 (10mpopov) @Aklapper @debt: I'm OK with re-opening this ticket if @greg or someone can help us s... [16:53:21] RainbowSprinkles hi, im wondering could you answer https://gerrit-review.googlesource.com/#/c/98775/16//COMMIT_MSG@11 please? [16:53:31] Im unsure how scap works. [16:57:57] 10Continuous-Integration-Config, 06Release-Engineering-Team, 06Discovery, 06Discovery-Analysis: Add CI to all wikimedia/discovery repositories that are active - https://phabricator.wikimedia.org/T153856#3064905 (10greg) We will :) [17:07:20] RainbowSprinkles woulden't we be able to switch plugins to scap3 without needing a config upstream? [17:11:30] !log cleaned out Jenkins security matrix to drop users that are no more used/inexistent -- T69027 [17:11:34] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:11:34] T69027: Jenkins: Figure out a long term solution to maintaining Jenkins configuration - https://phabricator.wikimedia.org/T69027 [17:22:39] hashar im starting to think that patches that use Depends-On use the nodepool instances without doing anything on them. see [17:22:40] https://integration.wikimedia.org/zuul/ [17:23:53] paladox: they dont [17:23:59] it is just a representation of the dependency chain [17:24:21] so if you have patch C depending on A and B [17:24:27] in the zuul status page you will see A -> B -> C [17:24:32] but only jobs for C are triggered [17:24:36] oh, [17:30:44] 10Gerrit, 06Release-Engineering-Team: Update gerrit to 2.13.6 - https://phabricator.wikimedia.org/T158946#3064994 (10Paladox) We will not want to do "Allow HTTP password when using LDAP and basic authentication." as in gerrit 2.13 passwords are not hashed for git cloning over http. But is now hashed in gerrit... [17:35:08] 10Continuous-Integration-Config, 06Release-Engineering-Team, 06Operations, 06Wikipedia-Android-App-Backlog, and 2 others: Investigate how to improve Android CI performance and stability - https://phabricator.wikimedia.org/T158014#3064996 (10Niedzielski) @hashar, sorry to bring up the GPU question again wit... [17:43:46] 10Continuous-Integration-Config, 06Release-Engineering-Team, 06Operations, 06Wikipedia-Android-App-Backlog, and 2 others: Investigate how to improve Android CI performance and stability - https://phabricator.wikimedia.org/T158014#3023430 (10Legoktm) I guess {T159165} could be related? [17:45:42] paladox: Probably, could just use a symlink [17:45:48] like you mentioned yesterday [17:45:51] Yep [17:45:53] :) [17:46:01] Should i abandon the commit? [17:56:29] Project beta-scap-eqiad build #144536: 04FAILURE in 1 min 24 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144536/ [17:57:01] 10Continuous-Integration-Config, 06Release-Engineering-Team, 06Operations, 06Wikipedia-Android-App-Backlog, and 2 others: Investigate how to improve Android CI performance and stability - https://phabricator.wikimedia.org/T158014#3065122 (10hashar) I can see how a GPU would accelerate UI drawing etc, reque... [18:06:23] Project beta-scap-eqiad build #144537: 04STILL FAILING in 1 min 23 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144537/ [18:16:21] Project beta-scap-eqiad build #144538: 04STILL FAILING in 1 min 25 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144538/ [18:27:09] Yippee, build fixed! [18:27:09] Project beta-scap-eqiad build #144539: 09FIXED in 2 min 11 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/144539/ [18:38:00] 10Gerrit, 06Release-Engineering-Team: Update gerrit to 2.13.6 - https://phabricator.wikimedia.org/T158946#3065311 (10demon) >>! In T158946#3064994, @Paladox wrote: > We will not want to do "Allow HTTP password when using LDAP and basic authentication." as in gerrit 2.13 passwords are not hashed for git cloning... [18:40:13] 10Gerrit, 06Release-Engineering-Team: Update gerrit to 2.13.6 - https://phabricator.wikimedia.org/T158946#3065317 (10Paladox) Oh it's hashed so it isn't shown as plain text in the git repo. [18:41:06] 10Gerrit, 06Release-Engineering-Team: Update gerrit to 2.13.6 - https://phabricator.wikimedia.org/T158946#3065318 (10demon) That still doesn't make sense. How is it shown in the UI if it's hashed? [18:46:35] 10Gerrit, 06Release-Engineering-Team: Update gerrit to 2.13.6 - https://phabricator.wikimedia.org/T158946#3065333 (10Paladox) >>! In T158946#3065318, @demon wrote: > That still doesn't make sense. How is it shown in the UI if it's hashed? It seems to show for me. But according to https://gerrit-review.googles... [18:51:11] 10Continuous-Integration-Config, 10ContentTranslation, 03Language-2017 Sprint 2, 03Language-2017 Sprint 3, and 3 others: mwext-qunit-jessie test fails on unrelated change - https://phabricator.wikimedia.org/T153038#2867222 (10mmodell) I got the impression that this test had been disabled to prevent blockin... [18:59:30] 10Gerrit, 06Release-Engineering-Team: Update gerrit to 2.13.6 - https://phabricator.wikimedia.org/T158946#3065359 (10demon) >>! In T158946#3065333, @Paladox wrote: >>>! In T158946#3065318, @demon wrote: >> That still doesn't make sense. How is it shown in the UI if it's hashed? > > It seems to show for me. Bu... [19:00:26] paladox: That hashing change is crazy [19:00:27] 10Beta-Cluster-Infrastructure, 10Cognate, 10MediaWiki-extensions-InterwikiSorting, 15User-Addshore: Create beta hewiktionary for testing InterwikiSorting & Cognate - https://phabricator.wikimedia.org/T158628#3065361 (10Addshore) Step 1 of the checklist has been done https://wikitech.wikimedia.org/w/index.p... [19:00:37] Oh [19:00:58] I sorta follow what's going on.... [19:01:02] But it's freaking weird [19:01:06] RainbowSprinkles lol [19:01:47] I think they should implement a fully advanced login and creating account system [19:01:49] like phab does. [19:02:14] instead of having a non advanced one and having us to randomly generate passwords. [19:02:27] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:02:44] paladox: Eh, their login system is fine (LDAP/OAuth/OpenID) [19:02:55] Yep but not for using the in built one [19:03:09] The HTTP passwords stuff is identical to how Phab does it... [19:03:19] oh [19:03:25] You *cant* hash those though. Well, you can according to that change ;-) [19:03:33] lol [19:03:34] I'm still not sure how it proposes to de-hash something :p [19:03:44] It has a decode() [19:03:49] But that...is weird [19:03:51] yep, most likly it does ^^ [19:04:00] as it now stores your password in a repo [19:04:27] It looks like it's using account_external_ids [19:04:37] From the Schema_142 change [19:04:58] Well those are being migrated too. But only for notedb for now. ReviewDB will be done later [19:05:09] ReviewDB change would affect us the notedb one wont. [19:06:40] 10Continuous-Integration-Config, 06Release-Engineering-Team, 06Operations, 06Wikipedia-Android-App-Backlog, and 2 others: Investigate how to improve Android CI performance and stability - https://phabricator.wikimedia.org/T158014#3065377 (10Fjalapeno) @hashar aside from the the question of if it will help... [19:08:36] RainbowSprinkles i found the bug report for polygerrit not working on prefixed urls https://bugs.chromium.org/p/gerrit/issues/detail?id=3795 seems i creating the repo twice. Just i forgot about it when i did it a second time. [19:08:58] creating = created [19:11:49] RainbowSprinkles oh yeh bazel has cache which means it remebers where it is and what needs changing if you make changes to a file after building [19:57:47] 10Continuous-Integration-Config, 06Release-Engineering-Team, 06Discovery, 06Discovery-Analysis: Add CI to all wikimedia/discovery repositories that are active - https://phabricator.wikimedia.org/T153856#3065584 (10greg) 05declined>03Open >>! In T153856#3064894, @mpopov wrote: > @Aklapper @debt: I'm OK... [20:27:32] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.14 deployment blockers - https://phabricator.wikimedia.org/T157639#3065762 (10demon) [21:48:59] 10Continuous-Integration-Config, 06Release-Engineering-Team, 06Operations, 06Wikipedia-Android-App-Backlog, and 2 others: Investigate how to improve Android CI performance and stability - https://phabricator.wikimedia.org/T158014#3065994 (10hashar) I have absolutely no idea :-/ People with actual knowledg... [22:27:24] 10Continuous-Integration-Config, 05Goal, 07I18n, 13Patch-For-Review: Configure banana checker for i18n files to run on all MediaWiki extensions and skins - https://phabricator.wikimedia.org/T94547#3066083 (10Legoktm) As of v0.6.0 of banana-checker, we can now whitelist keys that don't currently have docume... [22:38:51] 10Scap, 10Parsoid: Check 'depool' exceeded 30.0s timeout - https://phabricator.wikimedia.org/T159387#3066098 (10Arlolra) [23:47:21] 10Gerrit, 06Developer-Relations, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497#3066189 (10srishakatux) Anyone interested in mentoring this task for [[ https://www.mediawiki.org/wiki/Google_Summer_of_Code_2017 | Google Summer... [23:59:52] 10Continuous-Integration-Config, 103d, 06Editing-Department, 06Multimedia, 13Patch-For-Review: Set up CI for the 3D extension - https://phabricator.wikimedia.org/T159243#3066219 (10Jdforrester-WMF) 05Open>03Resolved a:03Jdforrester-WMF All fixed, thanks!