[00:07:32] apparently that previous scap I did was a no-op [00:08:43] whats the difference? [00:08:54] the second wasn't? [00:10:37] the second worked [00:12:43] I used scap sync-file on a directory, because apparently sync-dir is deprecated and sync-file can take a directory as its argument [00:13:17] but nothing happened [00:13:50] I think some other people were complaining about that [00:14:00] I keep using commands that work until they are forcefully broken [00:14:16] TimStarling: welcome to wmf development where we deprecate things and never give an alt [00:15:02] the second time, there were errors, apparently related to directory cleanup, I think I read an email from Chad about it [00:15:07] http://paste.tstarling.com/p/bAkPMz.html [00:16:06] once upon time i had my own site then it got expensive [00:41:09] I don't think the problem is limited to sync-file [00:48:46] 10Scap: [scap] sync-file/sync-dir on a directory has no effect - https://phabricator.wikimedia.org/T162220#3155953 (10tstarling) [00:49:23] anyone want to claim responsibility for that, or should I just do git blame? [00:50:48] I wonder who came up with that grey on slightly lighter grey colour scheme [00:54:27] git blame says chad, four months ago [00:56:40] TimStarling: what are you on about? [00:57:40] the bug I just filed, are you ignoring wikibugs or something? [00:59:23] TimStarling: what about it? [00:59:37] that is what I am on about [00:59:44] would you like to clarify your question? [00:59:48] TimStarling: hmmm... I think I've seen other complaints about this. I wonder if something got messed up when RainbowSprinkles merged the sync-file and sync-dir logic into one command [01:00:13] that terminal color scheme is horrid [01:00:14] yay its finally me that didnt break something [01:00:23] That's been live for quite some time [01:00:27] And the complaints sporadic [01:00:27] oh the terminal ewww [01:01:02] Hmmm, when running on a directory. That's more specific [01:01:13] yeah, I guess people don't notice every time when scap doesn't work at all [01:01:26] the exclude=* at the end ... [01:01:30] yes, if you specify a file then the --include matches [01:01:35] That final --exclude [01:01:36] Yep [01:01:40] I wonder if this explains why portals stuff is broken [01:01:52] That would explain it [01:03:25] so you have all been putting up with this for months? [01:03:30] this is why you need me personally syncing things every once in a while [01:03:36] I only do full scaps :) [01:03:38] if include: [01:03:38] for path in include: [01:03:38] rsync.append('--include=/%s' % path) [01:03:38] # Exclude everything not explicitly included [01:03:38] rsync.append('--exclude=*') [01:23:49] hmmm... so why doesn't this -- https://github.com/wikimedia/scap/blob/master/scap/main.py#L571-L574 -- match and add a '--include=/php-1.29.0-wmf.18/extensions/ParserMigration/includes/***' to the sync? [01:24:56] os.path.isdir() on a relative path? Shouldn't that use abspath? [01:25:16] ah, so if your current directory is /srv/mediawiki-deployment, maybe it will work [01:25:29] I mean mediawiki-staging [01:26:32] the second arg makes it relative to staging [01:26:42] but I'm not sure why that's needed [01:27:04] second argument to relpath? [01:27:08] https://phabricator.wikimedia.org/D344 - line 594 is where I tweaked that logic when combining them [01:27:17] yeah I am right [01:27:34] "Return a relative filepath to path either from the current directory or from an optional start directory." [01:28:01] yeah so relpath contains php-1.29.0-wmf.18/extensions/ParserMigration/includes [01:28:08] it is relative [01:28:14] then you feed that into isdir() [01:28:17] doh. yeah [01:28:52] I tested a sync-file with the current directory being /srv/mediawiki-staging, it worked [01:29:00] the relpath should only happen when adding to the rsync command [01:29:26] so line 550 should be f os.path.isdir(abspath): [01:29:37] yes [01:30:20] Ah ok, I see what I did wrong [01:31:02] Tricky [01:31:37] that also explains all the 'works for me' attempts at recreating the bug [01:32:01] Soooo, scap2/mw should probably enforce being in the deploy directory like scap3 does [01:32:11] my cwd is almost always the staging dir when I'm scapping stuff [01:32:12] But we should also fix this [01:35:19] RainbowSprinkles: you mean just do os.chdir() at the start? [01:36:20] Well scap2 and 3 behaviors are converging. In an ideal future, `scap deploy` and `scap sync` are the same thing which means you need to know what you're deploying. [01:36:37] Right now, that implies being in a git repo that contains a ./scap/scap.cfg [01:37:41] 10Scap: [scap] sync-file/sync-dir on a directory has no effect - https://phabricator.wikimedia.org/T162220#3155996 (10demon) [01:38:07] Just uploaded https://phabricator.wikimedia.org/D615 for the issue ^ [01:38:16] the normal definition of "being in a git repo" is being in any descendant subdirectory [01:38:39] Fair enough [01:42:20] there is "git rev-parse --show-toplevel" for this [01:42:58] Yes, I get that. The point being though you have to be somewhere within the git repo at all (as scap3 understands it), it doesn't have to be toplevel [01:43:07] It also doesn't make any assumptions about relative/absolute paths [01:43:16] Remember: the ideal universe also is moving towards a "deploy everything" model. Sync-file & friends are kind of on their way out [01:49:32] We're actually part way there. In the masters, the staging repo with all the core sub-repos and their submodules are being flattened into a single git repo [01:51:07] bd808: Fun fact on `scap clean --keep-static`? An initial branch prep on tuesdays is about 5-10m shorter with the *thousands* fewer files we have to look at [01:51:23] (like, tens of thousands) [01:52:11] The savings during a full scap outweighs the weight of a new branch ;-) [01:53:19] bye all [01:53:27] TimStarling: Landed my fix for the paths in sync-dir. It'll be on beta soon. I'll do some testing tomorrow, and we can get a bugfix release out shortly after [01:53:38] 10Scap: [scap] sync-file/sync-dir on a directory has no effect - https://phabricator.wikimedia.org/T162220#3155999 (10demon) 05Open>03Resolved [01:53:47] excellent, thanks RainbowSprinkles [01:54:10] yw. Thanks for helping to run this down--I hadn't been able to replicate yet [03:54:36] 10Deployment-Systems, 10Revision-Scoring-As-A-Service-Backlog, 10Wikilabels, 07Chinese-Sites, 07I18n: Deploy latest zh-hans/hant translations for Wikilabels on wmflabs - https://phabricator.wikimedia.org/T162108#3156050 (10Ladsgroup) I checked OAuth again (if it's broken, it would be a serious problem) a... [03:59:22] 10Deployment-Systems, 10Revision-Scoring-As-A-Service-Backlog, 10Wikilabels, 07Chinese-Sites, 07I18n: Deploy latest zh-hans/hant translations for Wikilabels on wmflabs - https://phabricator.wikimedia.org/T162108#3156051 (10Ladsgroup) The changes are deployed now, please check and tell me. [04:04:31] (03CR) 10Krinkle: [C: 04-1] Cache node_modules (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/346152 (https://phabricator.wikimedia.org/T159591) (owner: 10Hashar) [04:37:53] 10Deployment-Systems, 10Revision-Scoring-As-A-Service-Backlog, 10Wikilabels, 07Chinese-Sites, 07I18n: Deploy latest zh-hans/hant translations for Wikilabels on wmflabs - https://phabricator.wikimedia.org/T162108#3156077 (10Arthur2e5) 05Open>03Resolved Looks like plain old bad luck as it is working no... [05:51:25] 10Continuous-Integration-Config, 10BlueSpice, 13Patch-For-Review: Enable unit tests on BlueSpice* repos - https://phabricator.wikimedia.org/T130811#3156224 (10Osnard) @Paladox and @Reedy: Awesome, thanks! [06:43:33] Yippee, build fixed! [06:43:34] Project selenium-Wikibase ยป chrome,beta,Linux,BrowserTests build #321: 09FIXED in 2 hr 3 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/321/ [08:07:30] 10Continuous-Integration-Config, 10Deployment-Systems, 06Release-Engineering-Team: Skip running `test` pipeline for wmf branches (gate-and-submit is enough) - https://phabricator.wikimedia.org/T129719#3156467 (10hashar) 05Open>03declined Thank you Timo for the feedback. I am declining this crazy idea of... [08:33:56] PROBLEM - puppet last run on contint1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [08:40:56] RECOVERY - puppet last run on contint1001 is OK: OK: Puppet is currently enabled, last run 57 seconds ago with 0 failures [09:13:27] 10Beta-Cluster-Infrastructure, 10media-storage: Migrate beta cluster Swift cluster from Trusty to Jessie - https://phabricator.wikimedia.org/T162247#3156650 (10hashar) [09:15:30] 10Beta-Cluster-Infrastructure, 10Continuous-Integration-Infrastructure (Little Steps Sprint), 10media-storage, 13Patch-For-Review: deployment-ms-be01.deployment-prep and deployment-ms-be02.deployment-prep have high load / system CPU - https://phabricator.wikimedia.org/T160990#3156682 (10hashar) The summary... [09:23:46] 10Continuous-Integration-Config, 10BlueSpice, 13Patch-For-Review: Enable unit tests on BlueSpice* repos - https://phabricator.wikimedia.org/T130811#3156696 (10Paladox) Your welcome :) [09:25:46] 10Beta-Cluster-Infrastructure, 10media-storage: Migrate beta cluster Swift cluster from Trusty to Jessie - https://phabricator.wikimedia.org/T162247#3156702 (10hashar) [09:40:02] (03PS1) 10WMDE-Fisch: Revert "Add BetaFeatures as a RevisionSlider dep" [integration/config] - 10https://gerrit.wikimedia.org/r/346515 [09:43:51] 10Continuous-Integration-Config, 10BlueSpice, 13Patch-For-Review: Enable unit tests on BlueSpice* repos - https://phabricator.wikimedia.org/T130811#3156736 (10Paladox) @Osnard hi, the tests now get these P5209 failures. [09:48:26] (03CR) 10Addshore: [C: 031] Revert "Add BetaFeatures as a RevisionSlider dep" [integration/config] - 10https://gerrit.wikimedia.org/r/346515 (owner: 10WMDE-Fisch) [09:53:35] (03CR) 10Tobias Gritschacher: [C: 032] Revert "Add BetaFeatures as a RevisionSlider dep" [integration/config] - 10https://gerrit.wikimedia.org/r/346515 (owner: 10WMDE-Fisch) [09:55:29] (03PS2) 10Tobias Gritschacher: Revert "Add BetaFeatures as a RevisionSlider dep" [integration/config] - 10https://gerrit.wikimedia.org/r/346515 (owner: 10WMDE-Fisch) [09:56:47] (03CR) 10Tobias Gritschacher: Revert "Add BetaFeatures as a RevisionSlider dep" [integration/config] - 10https://gerrit.wikimedia.org/r/346515 (owner: 10WMDE-Fisch) [09:56:53] (03CR) 10Tobias Gritschacher: [C: 032] Revert "Add BetaFeatures as a RevisionSlider dep" [integration/config] - 10https://gerrit.wikimedia.org/r/346515 (owner: 10WMDE-Fisch) [09:58:18] (03Merged) 10jenkins-bot: Revert "Add BetaFeatures as a RevisionSlider dep" [integration/config] - 10https://gerrit.wikimedia.org/r/346515 (owner: 10WMDE-Fisch) [10:11:31] 10Beta-Cluster-Infrastructure: Request for static config file on the beta cluster returns a 403 - https://phabricator.wikimedia.org/T162164#3154252 (10hashar) That is defined in `operations/mediawiki-config`. `static/current/extensions` is a symbolic link to `/srv/mediawiki/php/extensions` `/srv/mediawiki/php`... [10:24:56] hashar it seems java 1.8 also needs to be installed on all the slaves too (just letting you know). It may affect android tests if we were to ever do that. [10:25:45] Heads-up: There is a 404 error for the pretty common "Lock_icon_blue.gif" icon (used in CSS for external links) in https://phabricator.wikimedia.org/T162235 - not sure if that's releng or already ops. [10:26:01] ^ greg-g [10:26:36] (bringing up here as scap had some 'old stuff cleanup' changes recently, though likely unrelated?) [10:45:14] 10Continuous-Integration-Infrastructure: Jobs with Node 6 should also have npm 3 - https://phabricator.wikimedia.org/T161861#3156911 (10hashar) Digging in the Jenkins build logs: ``` $ grep -Z -l peerDependencies /srv/jenkins/builds/*npm*/*/log|xargs -0 -n1 grep 'Cloning repository'|cut -d\/ -f4-|sort|uniq -c... [10:53:17] andre__: that is probably related to the thumbnailing / Swift file storage [10:54:23] andre__: ah no. The file does not exist on enwiki [11:08:00] andre__: found the issue :-} bunch of css files have to be updated, a bot can probably deal with that [11:08:05] PROBLEM - Puppet run on integration-c1 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [11:08:54] hashar: Uh! Thanks a lot! [11:10:22] basically css get copy pasted from sites to sites :D [11:13:44] going to ask en wiki sysops [11:13:57] andre__: I could restore the file right away but I will ask enwiki sysops to do it [11:14:46] (shouldn't Commons be used as the canonical source for such files? Meh) [11:14:48] in any case thanks [11:15:24] * andre__ unpings greg-g - sorry man! [11:53:20] PROBLEM - Puppet run on deployment-elastic05 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [12:13:20] RECOVERY - Puppet run on deployment-elastic05 is OK: OK: Less than 1.00% above the threshold [0.0] [12:31:41] 10Continuous-Integration-Config: some jjb inline bash snippets might miss set -eu - https://phabricator.wikimedia.org/T106384#3157099 (10hashar) All scripts under `config/dib` have the following boilerplate: ``` if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then set -x fi set -eu set -o pipefail ``` It is enforced b... [12:43:13] (03CR) 10Hashar: Cache node_modules (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/346152 (https://phabricator.wikimedia.org/T159591) (owner: 10Hashar) [12:46:07] (03PS10) 10Hashar: (WIP) test Zuul gate configuration (WIP) [integration/config] - 10https://gerrit.wikimedia.org/r/173831 [12:48:40] (03CR) 10jerkins-bot: [V: 04-1] (WIP) test Zuul gate configuration (WIP) [integration/config] - 10https://gerrit.wikimedia.org/r/173831 (owner: 10Hashar) [13:02:13] 10Continuous-Integration-Config, 10BlueSpice, 13Patch-For-Review: Enable unit tests on BlueSpice* repos - https://phabricator.wikimedia.org/T130811#3157146 (10Osnard) Okay... too sad. But at least tests are running. So now it is our turn to find out why they pass in our environment but fail in yours... [13:04:42] 10Continuous-Integration-Config, 10BlueSpice, 13Patch-For-Review: Enable unit tests on BlueSpice* repos - https://phabricator.wikimedia.org/T130811#3157151 (10Paladox) Osnard do you test with mw 1.27 and master or just 1.27? I think in 1.28 they added ApiPermissionManagerTest in the tests so that may explain... [13:09:47] (03PS11) 10Hashar: test gate-and-submit only has voting jobs [integration/config] - 10https://gerrit.wikimedia.org/r/173831 [13:11:36] (03CR) 10jerkins-bot: [V: 04-1] test gate-and-submit only has voting jobs [integration/config] - 10https://gerrit.wikimedia.org/r/173831 (owner: 10Hashar) [13:23:15] I am working on jobrunner02 atm, just trying one thing.. need to stop hhvm [13:29:31] (03PS12) 10Hashar: Remove non-voting jobs from gate-and-submit [integration/config] - 10https://gerrit.wikimedia.org/r/173831 [13:34:39] !log testing possible fix for T162035 on deployment-ms-fe01 [13:34:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:34:42] T162035: Some PNG thumbnails and JPEG originals delivered as [text/html] content-type and hence not rendered in browser - https://phabricator.wikimedia.org/T162035 [13:40:38] (03CR) 10Hashar: [C: 032] "All the original attempt eventually led to a real test suite. What was left to do is to ensure that non-voting jobs are not in gate-and-s" [integration/config] - 10https://gerrit.wikimedia.org/r/173831 (owner: 10Hashar) [13:41:36] (03Merged) 10jenkins-bot: Remove non-voting jobs from gate-and-submit [integration/config] - 10https://gerrit.wikimedia.org/r/173831 (owner: 10Hashar) [13:49:08] PROBLEM - Puppet run on buildlog is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [14:11:50] 10Browser-Tests-Infrastructure, 10MediaWiki-General-or-Unknown, 07JavaScript, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), and 4 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3157335 (10zeljkofilipin) [14:11:52] 10Browser-Tests-Infrastructure, 07JavaScript, 13Patch-For-Review, 15User-zeljkofilipin: Run WebdriverIO tests using Firefox - https://phabricator.wikimedia.org/T161697#3157334 (10zeljkofilipin) 05Open>03stalled [14:12:40] (03PS3) 10Hashar: test: mw ext/skins have test templates in Zuul [integration/config] - 10https://gerrit.wikimedia.org/r/332890 [14:14:03] (03CR) 10jerkins-bot: [V: 04-1] test: mw ext/skins have test templates in Zuul [integration/config] - 10https://gerrit.wikimedia.org/r/332890 (owner: 10Hashar) [14:14:36] 10Beta-Cluster-Infrastructure, 06Collaboration-Team-Triage, 10Flow, 07Chinese-Sites, 15User-Luke081515: Request for "Flow"ing pages on zhwp Beta-cluster - https://phabricator.wikimedia.org/T162131#3157337 (10Trizek-WMF) >>! In T162131#3155052, @hashar wrote: > @Trizek-WMF @Danny_B Chinese projects seems... [14:24:37] (03PS4) 10Hashar: test: mw ext/skins have test templates in Zuul [integration/config] - 10https://gerrit.wikimedia.org/r/332890 [14:24:39] (03PS1) 10Hashar: [ArticleFeedback] repo has been archived [integration/config] - 10https://gerrit.wikimedia.org/r/346551 [14:24:41] (03PS1) 10Hashar: Switch mw-checks-test to extension-unittests-non-voting [integration/config] - 10https://gerrit.wikimedia.org/r/346552 [14:26:08] (03CR) 10jerkins-bot: [V: 04-1] test: mw ext/skins have test templates in Zuul [integration/config] - 10https://gerrit.wikimedia.org/r/332890 (owner: 10Hashar) [14:26:52] (03CR) 10Hashar: [C: 031] "They are probably easily fixable :-}" [integration/config] - 10https://gerrit.wikimedia.org/r/346552 (owner: 10Hashar) [14:27:10] 10Beta-Cluster-Infrastructure, 06Collaboration-Team-Triage, 10Flow, 07Chinese-Sites, 15User-Luke081515: Request for "Flow"ing pages on zhwp Beta-cluster - https://phabricator.wikimedia.org/T162131#3157389 (10vjudge404) Flow are used by more than 1500 users now so bot owners and gadget creators can't igno... [14:27:20] (03CR) 10Hashar: [C: 032] [ArticleFeedback] repo has been archived [integration/config] - 10https://gerrit.wikimedia.org/r/346551 (owner: 10Hashar) [14:28:14] (03Merged) 10jenkins-bot: [ArticleFeedback] repo has been archived [integration/config] - 10https://gerrit.wikimedia.org/r/346551 (owner: 10Hashar) [14:33:42] 10Beta-Cluster-Infrastructure: Request for static config file on the beta cluster returns a 403 - https://phabricator.wikimedia.org/T162164#3157421 (10Mholloway) 05Open>03Invalid Thank you, @hashar! I've updated our [[ https://www.mediawiki.org/wiki/Wikimedia_Apps/Team/Wikipedia_Android_app_hacking | team w... [14:41:00] hashar looks like all three new mac's will be added to trilead :) instead of one. [15:08:35] hashar he will merge the change in 24 hours if no review :) [16:10:46] PROBLEM - jenkins_service_running on contint2001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args ^/usr/bin/java .*-jar /usr/share/jenkins/jenkins.war [16:13:15] ACKNOWLEDGEMENT - jenkins_service_running on contint2001 is CRITICAL: PROCS CRITICAL: 0 processes with regex args ^/usr/bin/java .*-jar /usr/share/jenkins/jenkins.war amusso Jenkins is not active on contint2001 yet. [17:54:17] 10Deployment-Systems, 10Scap, 13Patch-For-Review: Update Debian Package for Scap3 - https://phabricator.wikimedia.org/T127762#3158160 (10thcipriani) 05Resolved>03Open Just tagged scap debian/3.5.4-1: {rMSCAf78caf877875bfc38f9dbb4a8ac67ddb969b3c78} @fgiunchedi could you update the package on carbon, please? [18:12:16] I'm having some Lua fails on CI - anybody knows what can it be? https://integration.wikimedia.org/ci/job/mwext-testextension-php55-composer-trusty/309/console [18:12:39] regular tests are fine but merging fails [18:17:28] twentyafterfour checkout http://phabricator-random-wikisaur.ml :) [18:18:48] (03CR) 10Jforrester: "Can we put commit-message-validator back in as voting?" [integration/config] - 10https://gerrit.wikimedia.org/r/173831 (owner: 10Hashar) [18:22:45] greg-g, Reedy, twentyafterfour: any ideas about Lua OOM fails above? ^ [18:23:09] Chances are if you recheck it, it'll pass [18:24:50] from our team meeting notes this morning: [18:24:51] * CI instances out of RAM when running Wikibase [18:24:53] ** TLDR: https://phabricator.wikimedia.org/T125050#3153282 PHPUnit uses ~2GB ram and fork() fails due to not enough memory (instance only has 1.5G free and linux refuses to fork) [18:26:10] Reedy: recheck works, but merge does not :( [18:26:47] ah, nice, now recheck doesn't work either.... [18:27:00] see https://gerrit.wikimedia.org/r/#/c/334194/ [18:31:59] https://gerrit.wikimedia.org/r/#/c/336838/ [18:32:05] Why is jenkins running seemingly master tests? [18:32:11] There's no MessagesTests in 1.23 [18:42:17] 10Continuous-Integration-Config, 06Labs, 10MediaWiki-extensions-Scribunto, 10Wikidata: For contintcloud either add RAM or Swap to the instances - https://phabricator.wikimedia.org/T162166#3154301 (10chasemp) Using swap seems like a non-starter unless we are totally devoid of RAM capacity in which case we h... [18:47:07] 10Gerrit, 06Release-Engineering-Team, 13Patch-For-Review: Update gerrit to 2.14 - https://phabricator.wikimedia.org/T156120#3158369 (10Paladox) The rc0 will be released on monday so getting close to a release :) [18:48:00] 10Continuous-Integration-Infrastructure, 07Jenkins, 07Upstream, 07WorkType-NewFunctionality: Jenkins trilead-ssh2 doesn't support our MAC/KEX algorithms - https://phabricator.wikimedia.org/T103351#3158370 (10Paladox) Upstream will merge https://github.com/jenkinsci/trilead-ssh2/pull/14 that in less then 24... [19:19:36] 10Scap (Scap3-Adoption-Phase1), 10RESTBase, 13Patch-For-Review, 06Services (doing), 15User-mobrovac: Deploy RESTBase with scap3 - https://phabricator.wikimedia.org/T116335#3158458 (10mobrovac) The first round of patches scheduled for PuppetSWAT on [Thursday, 2017-04-06](https://wikitech.wikimedia.org/wik... [19:37:29] 10Beta-Cluster-Infrastructure, 06Performance-Team, 07Wikimedia-Multiple-active-datacenters: Install and use mcrouter in deployment-prep - https://phabricator.wikimedia.org/T151466#3158549 (10Krinkle) p:05Normal>03Low a:05aaron>03None Lowering priority pending outcome of {T156938}. [19:49:49] hashar blueocean is now stable [19:50:15] it also seemed to cause jenkins website to get slower. As lots of users have been downloading it. [19:51:07] Thats what someone said in #jenkins-infra [19:56:29] https://jenkins.io/projects/blueocean/ [19:59:08] (03PS1) 10Chad: Fix up "make-release: remove offline mode, it's weird" [tools/release] - 10https://gerrit.wikimedia.org/r/346600 [19:59:55] 10Continuous-Integration-Config, 06Labs, 10MediaWiki-extensions-Scribunto, 10Wikidata: For contintcloud either add RAM or Swap to the instances - https://phabricator.wikimedia.org/T162166#3158650 (10hashar) >>! In T162166#3158359, @chasemp wrote: > Using swap seems like a non-starter unless we are totally... [20:05:56] (03CR) 10Chad: [C: 032] Fix up "make-release: remove offline mode, it's weird" [tools/release] - 10https://gerrit.wikimedia.org/r/346600 (owner: 10Chad) [20:06:35] (03Merged) 10jenkins-bot: Fix up "make-release: remove offline mode, it's weird" [tools/release] - 10https://gerrit.wikimedia.org/r/346600 (owner: 10Chad) [20:22:47] PROBLEM - Puppet run on deployment-mx is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [20:24:17] PROBLEM - Puppet run on deployment-trending01 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [20:25:17] PROBLEM - Puppet run on deployment-eventlogging03 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [20:25:25] PROBLEM - Puppet run on deployment-puppetmaster02 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [20:26:05] PROBLEM - Puppet run on deployment-kafka05 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [20:26:40] hashar: if you have minute mind doing me a favor involving puppet? [20:27:07] PROBLEM - Puppet run on deployment-aqs01 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [20:29:12] 10Continuous-Integration-Config, 06Labs, 10MediaWiki-extensions-Scribunto, 10Wikidata: For contintcloud either add RAM or Swap to the instances - https://phabricator.wikimedia.org/T162166#3154301 (10Platonides) Given that the problem seems to be just the algorithm memory check rather than actually needing... [20:42:24] 10Continuous-Integration-Config, 06Labs, 10MediaWiki-extensions-Scribunto, 10Wikidata: For contintcloud either add RAM or Swap to the instances - https://phabricator.wikimedia.org/T162166#3158827 (10hashar) Oops I forgot about overcommit_memory which I mentioned on the parent task. From T125050#3153574 :... [20:43:33] paladox: the old web browser support drop whats its phab ticket? [20:43:51] What do you mean old web browser support drop? [20:43:53] ie9 ? [20:44:10] Some older web browsers will not be able to use JavaScript on Wikimedia wikis from this week. If you have an old web browser on your computer you can upgrade to a newer version. [2] paladox [20:44:22] Oh, that would be ie9 [20:44:36] any browser that doesnt support es5 i think [20:44:38] so ie9 [20:45:42] Zppix https://phabricator.wikimedia.org/T128115 [20:45:49] thanks [20:45:58] your welcome [20:47:45] paladox: your new offical title is Phabricator Search Bot [20:47:59] Actuallt i used gerrit [20:48:02] to find the task [20:48:18] so much easier as i remebered seeing patches being removed dropping ie9 support [21:00:17] RECOVERY - Puppet run on deployment-eventlogging03 is OK: OK: Less than 1.00% above the threshold [0.0] [21:00:25] RECOVERY - Puppet run on deployment-puppetmaster02 is OK: OK: Less than 1.00% above the threshold [0.0] [21:01:04] RECOVERY - Puppet run on deployment-kafka05 is OK: OK: Less than 1.00% above the threshold [0.0] [21:02:06] RECOVERY - Puppet run on deployment-aqs01 is OK: OK: Less than 1.00% above the threshold [0.0] [21:02:48] RECOVERY - Puppet run on deployment-mx is OK: OK: Less than 1.00% above the threshold [0.0] [21:04:18] RECOVERY - Puppet run on deployment-trending01 is OK: OK: Less than 1.00% above the threshold [0.0] [21:05:06] (03PS1) 10Hashar: dib: allow Linux memory overcommit on Trusty [integration/config] - 10https://gerrit.wikimedia.org/r/346634 (https://phabricator.wikimedia.org/T125050) [21:40:01] 10Continuous-Integration-Config, 13Patch-For-Review: 'recheck' on a CR+2 patch should trigger gate-and-submit, not test - https://phabricator.wikimedia.org/T105474#1444510 (10Zppix) @hashar was this ever implemented? [21:50:35] i wish i could find an easy task on ci config [22:01:46] 10Continuous-Integration-Config, 06Release-Engineering-Team: Priortize gerrit changesets that contain the comment of "SWAT" - https://phabricator.wikimedia.org/T162316#3158988 (10Zppix) [22:11:45] 10Continuous-Integration-Config, 06Release-Engineering-Team: Priortize gerrit changesets that contain the comment of "SWAT" - https://phabricator.wikimedia.org/T162316#3158988 (10demon) I disagree, we should do this via branches & repos: wmf/* branches should be prioritized, wmf-config and puppet should be pri... [22:31:13] 10Continuous-Integration-Config, 06Release-Engineering-Team: Priortize gerrit changesets that contain the comment of "SWAT" - https://phabricator.wikimedia.org/T162316#3159031 (10Zppix) @demon I will do that but i will still keep this idea floating about and see what others say [22:43:01] RainbowSprinkles: are you here still [22:43:29] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [22:54:00] so, RainbowSprinkles, I mistakenly thought Extension:Dashiki would be deployed at the same time as mediawiki-config, and dependent changes were merged for both [22:54:28] RainbowSprinkles: or anyone else: any idea when Extension:Dashiki will be deployed? Should I deploy it myself (I have rights now) [22:54:50] not right now, no, it's 7 minutes until SWAT, and then it's end of day [22:54:57] The code has been live for...weeks? [22:55:01] We started branching awhile ago [22:57:10] demon@tin /srv/mediawiki-staging/php-1.29.0-wmf.19/extensions/Dashiki ((5176684...))$ [22:57:12] What's missing? [22:57:56] RainbowSprinkles: I'm not sure but all Config:Dashiki: pages show up as missing now: https://meta.wikimedia.org/wiki/Config:Dashiki:SimpleRequestBreakdowns [22:58:01] but I see them in the database [22:58:10] I'll check the last sha [22:58:27] I'm willing to bet it's a namespace issue, one sec [22:58:54] Hmm, or not [22:58:58] RainbowSprinkles: 6ff5c65 is the last I have [22:59:13] so I think I'm missing some manual step to update a pointer to that [22:59:26] (03Draft2) 10Zppix: Add more jobs to test-prio [integration/config] - 10https://gerrit.wikimedia.org/r/346656 [22:59:27] the 517... one is a few revisions behind [22:59:47] this is my fault, I merged another change for SpamBlacklist and that got deployed automatically [22:59:50] Ah, well the change 6ff5c655abe8ed203fdf28b929e251463fa06c98 was merged after the branch cut :) [22:59:52] so I assumed they all work like that [22:59:54] milimetric: 517 is what was branched for wmf.19 on tues [23:00:09] So we need to cherry-pick that forward [23:00:09] Doing [23:00:15] right, I definitely need to understand this branching strategy better [23:00:28] * milimetric reads docs [23:00:36] milimetric: simple: we branch from master weekly on tuesday, that's it :) [23:00:37] milimetric: Branch every tuesday! [23:00:44] jinx [23:00:53] from master of all extensions? [23:00:54] Somewhere between 10am and noon Pacific time, depending on when someone gets on it :) [23:01:00] milimetric: Yep, from master [23:01:01] milimetric: the ones we deploy [23:01:02] oh, got it [23:01:21] (There's a few weird ones that don't branch from master, but you don't need to worry about those) [23:01:29] details for us to worry about :) [23:01:40] (btw, swat is right now ;) ) [23:01:42] milimetric: wmf-config, on the other hand, is deployed as soon as someone merges it and pushes it out [23:01:47] (or at least that's how it's supposed to work) [23:02:11] yep, that was my mistake: I merged a change for wmf-config and assumed that went out every tuesday too [23:02:20] Nope! [23:02:22] :) [23:02:37] not a mistake in your docs, just probably a common thing lazy people like me do [23:04:04] Anyway, I'm porting that change from master to wmf.19, it'll be live shortly [23:04:08] milimetric: heck im in operations chan almost daily and still dont understand how things work :P [23:04:13] thanks very much RainbowSprinkles [23:05:11] I'm super lucky you all are around, all the dashboards would've been out till next Tuesday otherwise [23:05:30] 10Continuous-Integration-Config, 06Release-Engineering-Team: Priortize gerrit changesets that contain the comment of "SWAT" - https://phabricator.wikimedia.org/T162316#3159171 (10demon) What if I put SWAT in a lot of my comments just to prioritize my commits? ;-) Again: this is a bad idea. [23:05:56] milimetric: I'm always around (except when I'm not) [23:06:02] :) [23:07:44] 10Continuous-Integration-Config, 06Release-Engineering-Team: Priortize gerrit changesets that contain the comment of "SWAT" - https://phabricator.wikimedia.org/T162316#3159183 (10Zppix) @demon it would also look only in repos that are supposed to be swatted and only allow people with production access to trigg... [23:13:11] milimetric: Um, that made it worse.... [23:13:13] MWUnknownContentModelException [23:14:01] ok, so there must be some mistake [23:14:06] The content model 'JsonConfig.Dashiki' is not registered on this wiki. [23:14:22] Reedy said I could move that into extension.json, which is the change he merged last night, one sec I'll link [23:14:35] https://gerrit.wikimedia.org/r/#/c/344007/ [23:14:39] That's what I backported to wmf.19 [23:15:12] right, and so with that I was supposed to be able to get rid of that config out of wmf-config [23:15:17] Hmmm [23:15:27] apparently not :) [23:15:27] I think let's revert the config removal for now [23:15:30] Until we figure it out [23:15:36] I'll do that now [23:15:38] but some wikis are still on .18? [23:16:11] meta is .19 [23:16:15] need chargr [23:16:16] Ahhh, I see it [23:16:25] Should be JsonConfig.Dashiki [23:16:32] Not JsonConfig[Dashiki] [23:16:36] You nested it [23:16:55] aha, I see [23:17:06] I have the revert change here: https://gerrit.wikimedia.org/r/#/c/346661/ [23:17:11] Either way, reverting config is safest choice for now [23:17:16] :) [23:17:42] ok, then I'll send another patch to fix the extension config [23:17:56] the syntax for that seems like dark magic, is it detailed anywhere? [23:18:10] No idea! JsonConfig is kind of a black box to me [23:18:20] (other than the fact that it's always yelling at me in the error logs!) [23:18:31] "JsonConfigModels": { [23:18:31] "Dashiki": { "Dashiki": { [23:18:35] That didn't work [23:19:01] Should both line 20 and 25 be JsonConfig.Dashiki? [23:19:46] milimetric: You should've seen the problems with JsonConfig, Zero(Portal|Banner)... And that was with the author of the lot involved [23:20:15] I think so [23:20:23] milimetric: Ok we're back nowhttps://meta.wikimedia.org/wiki/Config:Dashiki:SimpleRequestBreakdowns [23:20:30] oh, I don't know anything about Zero(Portal|Banner), this is my first attempt at this [23:20:34] nowhttps is not a protocol, keyboards are hard [23:20:51] cool [23:21:21] I'm not exactly clear on the proper syntax here, is it "JsonConfigModels": { "JsonConfig.Dashiki": ? [23:21:31] FWIW. If I hadn't borked adding it to extension.json, and also reviewing your change (which you followed mine)... [23:21:32] I think so, based on what you had configured before [23:21:46] The wmf-config one could've just stayed around till the updated version was on the active branch [23:21:51] then be removed at a later date [23:22:00] ok, I'll throw up a patch [23:22:00] $wgJsonConfigs['JsonConfig.Dashiki'] [23:22:32] So yeah, we need to use 'JsonConfigs': 'JsonConfig.Dashiki' in the json [23:22:54] I have officially exceeded my quota of talking about JsonConfig today [23:23:10] ok, so [ means nest and . means . and $wg means root [23:23:22] No one actually understands it. Questionably even it's author [23:23:23] thanks much RainbowSprinkles, that /sort of/ makes sense [23:23:43] Ehhhh, foo[bar] is an array where bar is a key in foo [23:23:54] foo[bar.baz] is an array foo where the key is bar.baz [23:24:03] Technically, that dot is just part of the key [23:24:11] k, that change is here: https://gerrit.wikimedia.org/r/#/c/346663/1/extension.json [23:24:16] (unless it's being handled magically, which is ugly/not-intuitive) [23:24:34] That /looks/ correct, but I don't want to deploy again today :) [23:24:38] nono [23:24:57] never again, I'll just do it very slowly next time using my merge rights [23:25:34] As I said above... Just merge that into master [23:25:37] It'll ride the train [23:25:50] Sometime after that's life, merge cleanup wmf-config [23:25:53] *live [23:25:55] yep [23:26:02] and revert wmf-config if it goes bad again [23:26:05] that was my plan [23:54:38] 10Scap, 06Discovery, 10Wikimedia-Portals, 03Discovery-Portal-Sprint: Portals deployment failed - https://phabricator.wikimedia.org/T161832#3159323 (10MaxSem) @demon fixed this: ``` I think we solved the portal sync issue yesterday. Issue in scap that had crept in (and why not everyone co...