[03:28:06] 05Gitblit-Deprecate, 13Patch-For-Review: Fix references to git.wikimedia.org in all repos - https://phabricator.wikimedia.org/T139089#3185680 (10TerraCodes) [03:28:22] 05Gitblit-Deprecate, 13Patch-For-Review: Fix references to git.wikimedia.org in all repos - https://phabricator.wikimedia.org/T139089#2419069 (10TerraCodes) [03:28:40] 05Gitblit-Deprecate, 13Patch-For-Review: Fix references to git.wikimedia.org in all repos - https://phabricator.wikimedia.org/T139089#2419069 (10TerraCodes) [06:19:02] Yippee, build fixed! [06:19:02] Project selenium-Wikibase » chrome,test,Linux,BrowserTests build #333: 09FIXED in 1 hr 39 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=test,PLATFORM=Linux,label=BrowserTests/333/ [06:40:09] Yippee, build fixed! [06:40:10] Project selenium-Wikibase » chrome,beta,Linux,BrowserTests build #333: 09FIXED in 2 hr 0 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/333/ [08:15:53] 05Gitblit-Deprecate, 13Patch-For-Review: Fix references to git.wikimedia.org in all repos - https://phabricator.wikimedia.org/T139089#3185851 (10TerraCodes) [12:09:12] 05Gitblit-Deprecate, 13Patch-For-Review: Fix references to git.wikimedia.org in all repos - https://phabricator.wikimedia.org/T139089#3186136 (10TerraCodes) [12:26:04] 05Gitblit-Deprecate, 13Patch-For-Review: Fix references to git.wikimedia.org in all repos - https://phabricator.wikimedia.org/T139089#3186174 (10TerraCodes) [13:46:12] Project selenium-VisualEditor » firefox,beta,Linux,BrowserTests build #370: 04FAILURE in 2 min 11 sec: https://integration.wikimedia.org/ci/job/selenium-VisualEditor/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/370/ [13:49:09] PROBLEM - Puppet run on buildlog is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [14:00:48] 10Continuous-Integration-Infrastructure, 10WikimediaUI Style Guide: stylelint-config-wikimedia: Add rule to check for one space between selector and open brace - https://phabricator.wikimedia.org/T163111#3186248 (10Umherirrender) [15:37:50] RECOVERY - Host integration-c1 is UP: PING OK - Packet loss = 0%, RTA = 1.76 ms [15:56:29] PROBLEM - Host integration-c1 is DOWN: CRITICAL - Host Unreachable (10.68.21.131) [17:47:35] (03PS3) 10MaxSem: Enable Phan tests for GeoData [integration/config] - 10https://gerrit.wikimedia.org/r/345880 [17:54:52] 10Continuous-Integration-Config: Remove jshint from V+1 as well as V+2 pipes for repos that use eslint now - https://phabricator.wikimedia.org/T154924#3186927 (10Jdforrester-WMF) >>! In T154924#3184686, @Paladox wrote: > If we do this. Non whitelisted users will not have any js test run. Indeed. [18:20:02] can someone review https://gerrit.wikimedia.org/r/#/c/345880/ please? :) [18:21:01] (03CR) 10Paladox: [C: 031] Enable Phan tests for GeoData [integration/config] - 10https://gerrit.wikimedia.org/r/345880 (owner: 10MaxSem) [18:27:12] 10Continuous-Integration-Config, 10VisualEditor: Intermittent failures of mwext-qunit-jessie - https://phabricator.wikimedia.org/T163123#3187122 (10Jdforrester-WMF) [18:27:32] 10Continuous-Integration-Config, 10VisualEditor: Intermittent failures of mwext-qunit-jessie - https://phabricator.wikimedia.org/T163123#3186782 (10Jdforrester-WMF) [18:28:54] 10Continuous-Integration-Config, 10VisualEditor: Intermittent failures of mwext-qunit-jessie - https://phabricator.wikimedia.org/T163123#3186782 (10Jdforrester-WMF) [18:29:15] 10Continuous-Integration-Config, 10VisualEditor: Intermittent failures of mwext-qunit-jessie - https://phabricator.wikimedia.org/T163123#3187136 (10Jdforrester-WMF) p:05Triage>03High [18:50:28] PROBLEM - Puppet run on swift-storage-01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:52:37] PROBLEM - Puppet run on swift is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:02:11] 10Continuous-Integration-Infrastructure, 10WikimediaUI Style Guide: stylelint-config-wikimedia: Add rule for two or more newline before eof - https://phabricator.wikimedia.org/T163136#3187286 (10Umherirrender) [20:48:37] 10Continuous-Integration-Config, 06Reading-Web-Backlog, 10VisualEditor: Intermittent failures of mwext-qunit-jessie - https://phabricator.wikimedia.org/T163123#3187817 (10Jdlrobson) [20:51:05] PROBLEM - Puppet run on integration-slave-trusty-1003 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:09:19] anyone know how I can query the db behind the beta cluster? Was hoping to find info here https://www.mediawiki.org/wiki/Beta_Cluster#Testing_changes_on_Beta_Cluster [21:09:48] specifically: where is it, how do I log in? [21:14:02] milimetric: machine list, see the -dbXX ones [21:14:04] er: https://tools.wmflabs.org/openstack-browser/project/deployment-prep [21:14:16] cool, thx [21:15:46] (added it to the docs) [21:17:35] oh, greg-g and what credentials should I use? [21:17:43] greg-g: Happy first day of the deployment moratorium. Are you the person to ask what qualifies as an emergency deployment? [21:17:44] * RoanKattouw hides [21:18:07] milimetric: ssh deployment-tin.eqiad.wmflabs and run "sql wikiname", I think that might be enough? [21:18:34] * milimetric checks [21:19:25] greg-g: Specifically, T163152 and https://phabricator.wikimedia.org/T158458#3161869 have people upset about a JS change that we made that breaks patrolling tools/workflows. The workaround is commenting out three lines of JS: https://gerrit.wikimedia.org/r/348504 [21:19:26] T163152: ERI Metrics fromrc=1 URL-extension breaks heavily used admin script - https://phabricator.wikimedia.org/T163152 [21:20:21] RoanKattouw: and what's the wikiname, can't find that either [21:20:33] milimetric: e.g. enwiki [21:20:39] I meant db name, sorry [21:20:58] oh it replicates all the prod ones? [21:21:04] RECOVERY - Puppet run on integration-slave-trusty-1003 is OK: OK: Less than 1.00% above the threshold [0.0] [21:21:04] Not all [21:21:07] And does not replicate [21:21:21] But the setup is structured in the same way, yes [21:21:37] It just isn't the same data, and not all the same wikis exist (we don't run ~800 wikis in beta labs) [21:21:44] But the ones that do exist have the same names [21:22:05] hm, right now I'm trying to find the one behind https://deployment.wikimedia.beta.wmflabs.org/ [21:22:20] and wondering if you just know this by heart or it's written somewhere [21:22:27] deploymentwiki [21:23:37] thx Reedy, that's the one. Updating docs [21:24:22] RoanKattouw: those look like just metrics? I don't know the context of ERI [21:24:38] greg-g: It's a bit of JS that collects metrics through EventLogging, yes [21:24:55] The code that's being commented out is code that dynamically modifies link targets to append ?userc=1 to them in certain cases [21:25:19] It turns out that screws with browser's concept of visited links, as well as with some (IMO buggy) tools on dewiki [21:26:23] interesting, so from my reading of https://phabricator.wikimedia.org/T158458#3161869 you're asking for a disabling of a recently turned on code path, right? [21:26:30] Exactly [21:26:56] should be fine, no dc switch work has really happened, I don't believe (most EU ops are off today) [21:27:07] has +not+ really happened? [21:27:14] Right, Easter Monday [21:27:48] right right [21:27:49] typing [21:28:04] Apparently In 'n Out closes all its locations for Easter, or so I learned in the parking lot of a very much deserted In 'n Out off Highway 99 in Modesto last night around dinnertime [21:28:08] er, well, I was right "no dc switch work" ;) [21:28:15] Oh, I see :) [21:28:18] My bad [21:28:28] sucks re not getting your burger :( [21:28:34] was there a 5 Guys at least? [21:28:38] :) [21:28:42] It led to me finding a good taqueria in Manteca [21:28:56] In a strip mall near where the In 'n Out (different one) is [21:28:57] sounds better [21:29:22] Anyway -- I'll go ahead and deploy that patch then [21:30:05] :) [21:32:40] This was just a way of admitting that I only realized it was Easter yesterday because I couldn't eat fast food [22:07:53] (03PS1) 10Jforrester: [CodeMirror] Express dependency on VisualEditor and WikiEditor [integration/config] - 10https://gerrit.wikimedia.org/r/348640 [22:08:19] (03CR) 10Jforrester: "To fix I16598fcdb." [integration/config] - 10https://gerrit.wikimedia.org/r/348640 (owner: 10Jforrester) [22:21:17] 05Gitblit-Deprecate, 13Patch-For-Review: Fix references to git.wikimedia.org in all repos - https://phabricator.wikimedia.org/T139089#3188062 (10TerraCodes) [22:43:29] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [23:15:17] greg-g: Another deployment request :/ jdlrobson wants to deploy a fix for T163059 [23:15:17] T163059: MobileFrontend hamburger menu broken in RTL in Wikimedia in production for anonymous users - https://phabricator.wikimedia.org/T163059 [23:15:35] The fix is CSS-only and I've just +2ed it in master, and I'd be happy to deploy it for him if you approve [23:17:23] RoanKattouw: oookaaaay [23:17:57] Is that a "yes you can do that" kind of OK or an "I... see..." kind of OK? [23:19:12] RoanKattouw: greg-g lol [23:19:25] RoanKattouw: first option [23:19:34] OK [23:19:37] thanks guys [23:19:47] the exasperated dad "OK" [23:19:54] :) [23:19:58] haha [23:20:30] Alright. The master patch is still Jenkins-ing, once that's done I'll cherry-pick and deploy [23:25:31] milimetric: Re https://gerrit.wikimedia.org/r/#/c/348625/ , thanks for taking the time to clean up the config files, but 1) you are not supposed to merge changes to mediawiki-config without immediately deploying them, and 2) you are definitely not supposed to do that during a deployment freeze week [23:25:53] So I'm reverting that change, but you are very welcome to reinstate it during a scheduled SWAT window [23:26:24] Also the fact that the last "cleanup" patch (not by you) caused thousands of "undefined variable" error per minute last week is feeding my paranoia a bit [23:28:10] greg-g: Not urgent or anything, but is there a wiki page that clearly lays out the "you merge it, you deploy it, right now" policy for the mediawiki-config repo? A number of people with deploy access seem to not realize that we have this rule, or what it means in practice [23:30:09] hmmm [23:32:00] no, but it should be somewhere near https://wikitech.wikimedia.org/wiki/How_to_deploy_code [23:58:30] 10Continuous-Integration-Config, 06Reading-Web-Backlog, 10VisualEditor: Intermittent failures of mwext-qunit-jessie - https://phabricator.wikimedia.org/T163123#3188446 (10Krinkle) [23:58:58] greg-g, RoanKattouw: it's sort of documented here, but not in a very clear way -- https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Problem:_undeployed_code [23:59:34] I'm amused at the "Roan commented in October 2012:" part