[03:33:10] 10Gerrit, 06Release-Engineering-Team, 10Scap: Deploy gerrit with scap3 - https://phabricator.wikimedia.org/T157414#3204724 (10demon) p:05Normal>03Lowest >>! In T157414#3204530, @Paladox wrote: > @demon does this need a new repo for scap to clone from? > Yes > Also how will this work as doesn't scap on... [07:56:25] (03PS2) 10Hashar: Clean out jsonlint/jshint [integration/config] - 10https://gerrit.wikimedia.org/r/349439 (https://phabricator.wikimedia.org/T119973) [08:27:13] (03PS3) 10Hashar: Clean out jsonlint/jshint [integration/config] - 10https://gerrit.wikimedia.org/r/349439 (https://phabricator.wikimedia.org/T119973) [08:27:52] (03PS1) 10Hashar: [Score] remove jshint, has been moved to eslint [integration/config] - 10https://gerrit.wikimedia.org/r/349883 (https://phabricator.wikimedia.org/T154924) [08:28:47] (03PS1) 10Hashar: [TemplateSandbox] remove jshint, has been moved to eslint [integration/config] - 10https://gerrit.wikimedia.org/r/349884 (https://phabricator.wikimedia.org/T154924) [08:29:11] hashar: o/ - nice code change https://gerrit.wikimedia.org/r/#/c/349722/1/includes/libs/redis/RedisConnectionPool.php [08:29:47] (03CR) 10jerkins-bot: [V: 04-1] Clean out jsonlint/jshint [integration/config] - 10https://gerrit.wikimedia.org/r/349439 (https://phabricator.wikimedia.org/T119973) (owner: 10Hashar) [08:31:50] (03CR) 10Hashar: [C: 032] [TemplateSandbox] remove jshint, has been moved to eslint [integration/config] - 10https://gerrit.wikimedia.org/r/349884 (https://phabricator.wikimedia.org/T154924) (owner: 10Hashar) [08:32:01] (03CR) 10Hashar: [C: 032] [Score] remove jshint, has been moved to eslint [integration/config] - 10https://gerrit.wikimedia.org/r/349883 (https://phabricator.wikimedia.org/T154924) (owner: 10Hashar) [08:34:41] (03Merged) 10jenkins-bot: [Score] remove jshint, has been moved to eslint [integration/config] - 10https://gerrit.wikimedia.org/r/349883 (https://phabricator.wikimedia.org/T154924) (owner: 10Hashar) [08:34:47] (03Merged) 10jenkins-bot: [TemplateSandbox] remove jshint, has been moved to eslint [integration/config] - 10https://gerrit.wikimedia.org/r/349884 (https://phabricator.wikimedia.org/T154924) (owner: 10Hashar) [08:43:10] (03PS4) 10Hashar: Clean out jsonlint/jshint [integration/config] - 10https://gerrit.wikimedia.org/r/349439 (https://phabricator.wikimedia.org/T119973) [08:50:16] (03CR) 10Hashar: [C: 032] "Huge cleanup, I have sent a huge amount of patches to make sure jsonlint/jshint are in all the extensions." [integration/config] - 10https://gerrit.wikimedia.org/r/349439 (https://phabricator.wikimedia.org/T119973) (owner: 10Hashar) [08:51:41] (03Merged) 10jenkins-bot: Clean out jsonlint/jshint [integration/config] - 10https://gerrit.wikimedia.org/r/349439 (https://phabricator.wikimedia.org/T119973) (owner: 10Hashar) [09:19:37] (03PS1) 10Hashar: [Bouquet] jshint is now in npm test [integration/config] - 10https://gerrit.wikimedia.org/r/349891 [09:22:41] (03CR) 10Hashar: [C: 032] [Bouquet] jshint is now in npm test [integration/config] - 10https://gerrit.wikimedia.org/r/349891 (owner: 10Hashar) [09:23:38] (03Merged) 10jenkins-bot: [Bouquet] jshint is now in npm test [integration/config] - 10https://gerrit.wikimedia.org/r/349891 (owner: 10Hashar) [09:30:24] 10Deployment-Systems: LocalisationUpdate not working since 2017-04-11 - https://phabricator.wikimedia.org/T163671#3205239 (10Pikne) [09:42:57] (03PS1) 10Hashar: Archive some legacy extensions [integration/config] - 10https://gerrit.wikimedia.org/r/349896 [09:45:00] (03CR) 10Hashar: [C: 032] Archive some legacy extensions [integration/config] - 10https://gerrit.wikimedia.org/r/349896 (owner: 10Hashar) [09:46:54] (03Merged) 10jenkins-bot: Archive some legacy extensions [integration/config] - 10https://gerrit.wikimedia.org/r/349896 (owner: 10Hashar) [10:02:23] (03PS1) 10Hashar: [PictureGames] switch to npm job [integration/config] - 10https://gerrit.wikimedia.org/r/349899 [10:08:48] (03PS1) 10Hashar: [WikiTwidget] switch to npm job [integration/config] - 10https://gerrit.wikimedia.org/r/349902 [10:13:43] (03PS1) 10Hashar: [UserStatus] switch to npm job [integration/config] - 10https://gerrit.wikimedia.org/r/349905 [10:20:10] (03PS1) 10Hashar: [UploadLogo] Switch to npm job [integration/config] - 10https://gerrit.wikimedia.org/r/349910 [10:22:06] (03PS1) 10Hashar: [SwarmExport] remove jshint/jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/349911 [10:22:19] (03CR) 10Hashar: [C: 032] [SwarmExport] remove jshint/jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/349911 (owner: 10Hashar) [10:23:03] (03PS1) 10Hashar: [StringFunctionsEscaped] remove jshint/jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/349912 [10:23:14] (03CR) 10Hashar: [C: 032] [StringFunctionsEscaped] remove jshint/jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/349912 (owner: 10Hashar) [10:24:17] (03Merged) 10jenkins-bot: [SwarmExport] remove jshint/jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/349911 (owner: 10Hashar) [10:26:43] (03PS1) 10Hashar: [ScanSet] remove jshint/jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/349914 [10:28:20] (03Merged) 10jenkins-bot: [StringFunctionsEscaped] remove jshint/jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/349912 (owner: 10Hashar) [10:29:24] 10:25:49 Fatal error: Class undefined: Wikimedia\TestingAccessWrapper in /home/jenkins/workspace/mediawiki-extensions-hhvm-jessie/src/extensions/Wikidata/extensions/Wikibase/client/tests/phpunit/includes/Hooks/ChangesListSpecialPageHookHandlersTest.php on line 35 [10:29:59] (on several mediawiki-extensions-hhvm-jessie jobs, e.g. https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/11528/console) [10:30:48] (03PS2) 10Hashar: [ScanSet] remove jshint/jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/349914 [10:32:40] (03PS1) 10Hashar: [RandomFeaturedUser] remove jshint/jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/349916 [10:39:06] (03PS1) 10Hashar: [OfflineImportLexicon] remove jshint/jsonlint [integration/config] - 10https://gerrit.wikimedia.org/r/349918 [10:41:10] (03PS2) 10Hashar: [OfflineImportLexicon] switch to npm job [integration/config] - 10https://gerrit.wikimedia.org/r/349918 [10:41:33] (03PS2) 10Hashar: [RandomFeaturedUser] switch to npm job [integration/config] - 10https://gerrit.wikimedia.org/r/349916 [10:41:55] (03PS3) 10Hashar: [ScanSet] switch to npm job [integration/config] - 10https://gerrit.wikimedia.org/r/349914 [10:42:17] (03PS2) 10Hashar: [UploadLogo] switch to npm job [integration/config] - 10https://gerrit.wikimedia.org/r/349910 [11:54:55] greg-g: ping me when around :) [12:06:58] 10Browser-Tests-Infrastructure, 06Multimedia, 10UploadWizard: Firefogg browser test - https://phabricator.wikimedia.org/T93174#3205638 (10zhuyifei1999) 05Open>03declined Firefogg is no longer supported, see T157201 [12:37:43] 10releng-201516-q4: Meta: Prototype new JS framework (malu) - https://phabricator.wikimedia.org/T131121#3205755 (10hashar) 05Open>03declined We are using Webdriver.io with the middlewar being directly into mediawiki/core, see https://www.mediawiki.org/wiki/Selenium/Node.js . Hence MALU tasks are all obsolete... [14:22:39] 06Release-Engineering-Team, 06Labs: Get labtestwikitech/californium on the deployment train - https://phabricator.wikimedia.org/T163694#3206154 (10Andrew) [14:34:42] 06Release-Engineering-Team, 06Labs: Get labtestwikitech/labtestweb2001 on the deployment train - https://phabricator.wikimedia.org/T163694#3206179 (10Andrew) [16:14:27] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [16:39:11] kart_: hey, sorry, I presume you're asleep, just getting caught up on email/stuff after a 9am meeting [16:40:26] kart_: I don't see a mention of the CX deploy here: https://tools.wmflabs.org/sal/production it didn't happen then I presume? If not, feel free to do it when it works for you. [16:41:03] kart_: I actually thought it was going to get done, I saw TimStarling mention it last night (my time) on FB and possibly doing it during EU morning [16:48:17] greg-g: We need ack from Jaime/DBA which we haven't got yet :/ [16:48:40] So, probably amir will look at it or it goes to tomorrow. [16:48:52] kart_: ah, ok, cool [17:05:39] PROBLEM - Puppet errors on buildlog is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:05:45] PROBLEM - Puppet errors on swift is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:06:45] PROBLEM - Puppet errors on deployment-urldownloader is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:07:17] PROBLEM - Puppet errors on swift-storage-01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:07:23] PROBLEM - Puppet errors on deployment-ircd is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:08:45] PROBLEM - Puppet errors on deployment-phab01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:09:54] Something merge that breaking labs ^? [17:11:09] Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Failed to parse inline template: address family must be specified at /etc/puppet/modules/interface/manifests/add_ip6_mapped.pp:24 on node deployment-ircd.deployment-prep.eqiad.wmflabs [17:14:32] Yep, same result on a couple of those machines [17:35:47] seems like that would be https://gerrit.wikimedia.org/r/#/c/345564/ [17:45:34] RainbowSprinkles i finally managed to get scap working (or at least it passes) So i could test scap for gerrit. [17:46:12] I told you not to worry about it. It's low-priority for me, probably won't get to it for *months* [17:46:20] ok [17:52:50] 06Release-Engineering-Team, 06Labs, 15User-bd808: Get labtestwikitech/labtestweb2001 on the deployment train - https://phabricator.wikimedia.org/T163694#3207222 (10bd808) 05Open>03Resolved a:03bd808 It was already on the train, but now it is in `group0` so it will get new MediaWiki changes before wikit... [18:43:19] 10MediaWiki-Releasing, 05MW-1.28-release: Patch file for 1.28.1 - https://phabricator.wikimedia.org/T162536#3207425 (10BruceDawson) Just an FYI... I'm not a Windows user, but a Linux user. That file was in the distributed .patch file. [19:24:24] 06Release-Engineering-Team (Deployment-Blockers), 05Release: MW-1.29.0-wmf.23 deployment blockers - https://phabricator.wikimedia.org/T163512#3207550 (10greg) Actually, I went too far. Chad will be branching 1.30 this week. I'll rename these after his announce email. [19:25:07] twentyafterfour: still around ? [19:25:20] hashar: yeah [19:25:23] I am tempted to hotfix https://gerrit.wikimedia.org/r/349144 [mediawiki/core@master] Fix bogus field reference in Category::getCountMessage() callback [19:25:33] got fixed in master but we missed a backport to wmf.20 [19:26:02] yeah [19:26:24] will try to sneak it in the swat slot :] [19:26:25] thx! [19:27:43] ok if it doesn't make it through I'll backport tomorrow during the train [19:29:36] twentyafterfour: nothing in scap would have changed to make the nightly l10n update no log the same, right? Apparently the nightly l10n hasn't run since 4/11: https://tools.wmflabs.org/sal/production?p=0&q=%22sync-l10n%22&d= [19:29:40] see also: https://phabricator.wikimedia.org/T163671 [19:29:49] cc RainbowSprinkles because he cares about l10nupdate :P [19:30:03] s/no log the same/not log the same/ [19:36:36] well. FWIW, scap 3.5.5 was put on the servers on the 11th [19:37:15] which is https://github.com/wikimedia/scap/blob/release/debian/changelog#L1-L41 [19:37:31] hrmmm [19:38:41] thcipriani: there's no line that says "break l10nupdate" so I'm not sure :P [19:39:45] yeah, makes it tricky to guess, but there are some things that touch stuff that I believe l10nupdate uses, so it's possible that the scap update broke it. [19:40:03] "things that touch stuff" -- my technical explanation of new releases [19:40:17] 10Continuous-Integration-Config, 10MobileFrontend, 06Reading-Web-Backlog: Add disabling comment syntax to resource-modules linter and setup Jenkins job - https://phabricator.wikimedia.org/T160056#3207622 (10greg) [19:40:53] thcipriani: word [19:47:09] 10Deployment-Systems: LocalisationUpdate not working since 2017-04-11 - https://phabricator.wikimedia.org/T163671#3205239 (10thcipriani) So with the new version of scap `cache_git_info` now runs on every `sync` (i.e., `sync-file`, `sync-dir` etc.) command rather than how it previously worked where it was only up... [19:57:34] (03CR) 10Hashar: Make failing unit tests non-voting (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/349729 (owner: 10Umherirrender) [20:12:27] (03PS4) 10Hashar: Make failing unit tests non-voting [integration/config] - 10https://gerrit.wikimedia.org/r/349729 (owner: 10Umherirrender) [20:13:34] (03CR) 10Hashar: [C: 032] "Rebased. It keeps the PhpTags* repositories voting since I eventually figured out a workaround for it :]" [integration/config] - 10https://gerrit.wikimedia.org/r/349729 (owner: 10Umherirrender) [20:14:31] (03Merged) 10jenkins-bot: Make failing unit tests non-voting [integration/config] - 10https://gerrit.wikimedia.org/r/349729 (owner: 10Umherirrender) [20:20:11] 10Continuous-Integration-Config, 10Deployment-Systems, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Validator, and 2 others: [Task] make core wmf branches only use submodule branches that run with it in CI - https://phabricator.wikimedia.org/T113731#3207790 (10hashar) I got another case. m... [20:23:29] hashar: random idea about T113731. Could do something like having make-wmf-branch live on images, update it at the start of the prepare-mediawiki-zuul-project builder and then pass a bunch of --project-branch arguments to zuul-cloner... has that been tried? [20:23:29] T113731: [Task] make core wmf branches only use submodule branches that run with it in CI - https://phabricator.wikimedia.org/T113731 [20:25:08] that is we could just use the make-wmf-branch map of code...except that wouldn't work between the time it's updated and branched. Really I guess we need to look at the the wmf/ branches .gitmodules I suppose. That's the only source of truth. [20:34:40] thcipriani: I havent tried [20:34:51] but yeah we need something more robust for the wmf/* branches [20:35:04] werd [20:35:04] probably start again from scratch [20:35:12] oh boy [20:35:24] I guess the key point is we should use mediawiki/core submodules system [20:35:47] OHHH [20:36:07] you mean cloning the make-wmf-branch so we know the branches to fallback to! [20:36:24] which would work for the wmf branches I guess [20:36:52] that was my initial idea, but that sort of overloads the use of that file and I think we'll get into trouble [20:37:03] potentially [20:37:14] the submodule system seems like the right thing to use to me [20:37:20] another bug we have is that for REL branches we clone the same set of repositories [20:37:50] so you end up testing REL1_23 with extensions that were probably not existing at that point and thus zuul cloner fallback to master [20:37:53] which makes no sense [20:38:07] so I guess mediawiki-extensions-* jobs should disappear / be overhauled entirely [20:39:08] I don't know, seems like they work for 95% of cases. [20:39:21] rebuilding would just give us a different 5% of cases probably :P [20:41:25] ;]] [20:41:43] I hope to hold some session about that for the offsite [20:42:34] I don't know. I've voting for greg-g 's "I don't know, sit around and, like, talk about stuff, man" session. [20:44:25] yeah sounds right :] [20:58:48] hashar: re: submodules and branches for REL1_xx, T137564 might be interesting [20:58:49] T137564: Include release extensions/skins as submodules of core (maybe vendor too?) - https://phabricator.wikimedia.org/T137564 [20:59:32] RainbowSprinkles: yup that is similar [20:59:34] Which would work, until someone comes along and marks repos as hidden :\ [20:59:40] :] [21:00:02] actually [21:00:15] I ahve an experimental job that clones repos based on the branch and make-release/make-release.yaml [21:00:27] never went to finish it though because tests fail :( [21:00:36] https://integration.wikimedia.org/ci/job/mediawiki-releases/ [21:00:38] If I just added them as submodules, wouldn't need said job :) [21:01:33] one is running https://integration.wikimedia.org/ci/job/mediawiki-releases/PHP_BIN=php5,ZUUL_BRANCH=master,label=UbuntuTrusty/39/console :D [21:01:48] but yeah if we had everything in a mediawiki/core REL branch [21:01:56] I guess it is all about doing a git clone + submodule [21:01:58] and we are set [21:02:01] Yep! [21:02:26] `git clone --recurse-submodules ...` [21:02:29] which also simplify make-release since we just have to register the repos in .gitmodules ? [21:02:40] Yep, the branch-making script will do the *hard* part [21:02:49] Then the make-release just has to clone w/ recursion [21:04:18] Also means that CI for REL* branches can just do the same, and don't have to have any logic w.r.t. extensions/skins/vendor [21:13:02] RainbowSprinkles: yup sounds good :) [21:14:01] twentyafterfour hi, how does phabricator cache on iridium as i only realised over weekend that the apc php package wont work with php 5.5+ [21:16:16] 06Release-Engineering-Team, 06Operations, 10vm-requests, 07Security-General: New ganeti VM for MW release pipeline work - https://phabricator.wikimedia.org/T163743#3207976 (10demon) [21:27:51] 06Release-Engineering-Team, 06Operations, 10vm-requests, 07Security-General: New ganeti VM for MW release pipeline work - https://phabricator.wikimedia.org/T163743#3207976 (10Dzahn) Should this exist in both DCs? one in eqiad one in codfw per default nowadays? [21:50:21] 06Release-Engineering-Team, 06Operations, 10vm-requests, 07Security-General: New ganeti VM for MW release pipeline work - https://phabricator.wikimedia.org/T163743#3208120 (10demon) >>! In T163743#3208114, @demon wrote: >>>! In T163743#3208018, @Dzahn wrote: >> Should this exist in both DCs? one in eqiad o... [22:07:08] paladox: I think newer php versions have APC built in. I have had phabricator working with php 5.6 and php 7.1 [22:07:51] twentyafterfour oh yep. theres the new apcu for php 5.5+ [22:08:00] that adds user caching [23:34:06] 10Deployment-Systems, 10Scap, 13Patch-For-Review: Update Debian Package for Scap3 - https://phabricator.wikimedia.org/T127762#3208342 (10thcipriani) 05Resolved>03Open @fgiunchedi I tagged and pushed debian/3.5.6-1. Could you update to 3.5.6-1 on carbon? Puppet patch Soon™. Thanks!