[05:35:43] 10Beta-Cluster-Infrastructure: Request for adminship on Beta Cluster's Chinese Wikipedia - https://phabricator.wikimedia.org/T164447#3234028 (10Dargasea) [05:35:51] 10Beta-Cluster-Infrastructure: Request for adminship on Beta Cluster's Chinese Wikipedia - https://phabricator.wikimedia.org/T164447#3234040 (10Dargasea) p:05Triage>03Normal [05:36:24] 10Beta-Cluster-Infrastructure: Request for adminship on Beta Cluster's Chinese Wikipedia - https://phabricator.wikimedia.org/T164447#3234028 (10Dargasea) [06:24:21] Yippee, build fixed! [06:24:22] Project selenium-Wikibase » chrome,test,Linux,BrowserTests build #350: 09FIXED in 1 hr 44 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=test,PLATFORM=Linux,label=BrowserTests/350/ [06:47:51] Project selenium-Wikibase » chrome,beta,Linux,BrowserTests build #350: 04FAILURE in 2 hr 7 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/350/ [07:26:48] 10Beta-Cluster-Infrastructure: Request for adminship on Beta Cluster's Chinese Wikipedia - https://phabricator.wikimedia.org/T164447#3234105 (10hashar) 05Open>03Resolved a:03hashar 你好 , the account `Dargasea` is now an administrator https://zh.wikipedia.beta.wmflabs.org/wiki/Special:%E7%94%A8%E6%88%B7%E6%9... [07:30:27] !log deployment-prep: adding TTO (This, that and the other) as a project member to grant shell access - T163887 [07:30:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:30:30] T163887: Request for shell access on beta cluster - https://phabricator.wikimedia.org/T163887 [07:32:22] 10Beta-Cluster-Infrastructure: Request for shell access on beta cluster - https://phabricator.wikimedia.org/T163887#3234124 (10hashar) 05stalled>03Resolved a:03hashar I am fine with that given all the activity you are conducting, you will probably need shell access at one point anyway. Please try to at le... [07:35:08] 10Beta-Cluster-Infrastructure, 10ContentTranslation, 10ContentTranslation-CXserver: Move apertium to deployment-sca* hosts in Beta Cluster - https://phabricator.wikimedia.org/T142152#3234140 (10hashar) @akosiaris , @KartikMistry Looks like apertium is still running on deployment-apertium02 . Can we move it... [07:40:44] 10Beta-Cluster-Infrastructure, 05Goal, 13Patch-For-Review, 07Puppet: Remove all ::beta roles in puppet - https://phabricator.wikimedia.org/T86644#3234168 (10hashar) [07:44:28] 10Beta-Cluster-Infrastructure: Set 'cluster' salt grain appropriately for all instances in beta cluster - https://phabricator.wikimedia.org/T87199#3234185 (10hashar) [07:46:17] 10Beta-Cluster-Infrastructure: Set 'cluster' salt grain appropriately for all instances in beta cluster - https://phabricator.wikimedia.org/T87199#985792 (10hashar) I am tempted to just close this. Doesn't seem we rely on the `cluster` grain on beta? [07:47:32] 10Deployment-Systems, 10Scap, 07I18n: LocalisationUpdate not working since 2017-04-11 - https://phabricator.wikimedia.org/T163671#3234187 (10Pikne) 05Open>03Resolved Seems to work again. Thank you! [07:54:13] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3034940 (10Pikne) >>! In T158360#3216287, @greg wrote: > As you can see from the title, l10nupdate wasn't working since 2017-04-11. That task was reported on 2017-04-2... [07:57:19] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3234214 (10Amire80) I did notice that messages aren't updated, and assumed that it's related to the reduction of deployments related to the dc switch, and there weren'... [08:08:39] 10Beta-Cluster-Infrastructure: Request for importer on zhwp beta - https://phabricator.wikimedia.org/T163784#3234240 (10hashar) 05Open>03Resolved a:03hashar The [[ https://zh.wikipedia.beta.wmflabs.org/wiki/Special:%E7%94%A8%E6%88%B7%E6%9D%83%E9%99%90/%E9%80%86%E8%A5%B2%E7%9A%84%E5%A4%A9%E9%82%AA%E9%AC%BC... [08:34:21] 10Beta-Cluster-Infrastructure, 06Release-Engineering-Team, 10DBA, 06Operations, 13Patch-For-Review: Better mysql command prompt info for Beta - https://phabricator.wikimedia.org/T157714#3234285 (10hashar) On deployment-tin I created: ``` lang=ini,name=/etc/mysql/conf.d/prompt.cnf [mysql] prompt = "\u@\h[... [08:34:48] PROBLEM - Apertium APY on deployment-sca02 is CRITICAL: Connection refused [08:39:17] PROBLEM - Apertium APY on deployment-sca01 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [08:48:39] 10Beta-Cluster-Infrastructure: Request for shell access on beta cluster - https://phabricator.wikimedia.org/T163887#3234327 (10TTO) Thanks @hashar. I'll be sure to follow that advice! [08:59:48] RECOVERY - Apertium APY on deployment-sca02 is OK: HTTP OK: HTTP/1.1 200 OK - 5632 bytes in 0.021 second response time [10:16:05] !log Unbroke puppet on deployment-phab01 - T153319 [10:16:09] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:16:09] T153319: Investigate non-puppetmaster instances configured to be puppetmasters - https://phabricator.wikimedia.org/T153319 [10:22:37] 10Beta-Cluster-Infrastructure: Investigate non-puppetmaster instances configured to be puppetmasters - https://phabricator.wikimedia.org/T153319#3234669 (10hashar) deployment-phab01.deployment-prep.eqiad.wmflabs ------------------ A standalone puppet master. I dont even know why there is a Phabricator instance... [10:27:31] PROBLEM - Puppet errors on deployment-tin is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [10:29:14] !log Unbroke puppet on deployment-imagescaler01 and removing role::puppetmaster::self - T153319 [10:29:17] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:29:18] T153319: Investigate non-puppetmaster instances configured to be puppetmasters - https://phabricator.wikimedia.org/T153319 [10:29:55] PROBLEM - Puppet errors on deployment-imagescaler01 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [10:30:33] 10Beta-Cluster-Infrastructure, 10Thumbor: Investigate non-puppetmaster instances configured to be puppetmasters - https://phabricator.wikimedia.org/T153319#3234678 (10hashar) deployment-imagescaler01.deployment-prep.eqiad.wmflabs --------------- The puppet conf is a bit messy: ``` [agent] server = puppetmaste... [10:31:54] !log deployment-phab01 / deployment-imagescaler01 rm /etc/puppet/puppet.conf.d/10-self.conf - T153319 [10:31:57] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:33:47] RECOVERY - Puppet errors on deployment-phab01 is OK: OK: Less than 1.00% above the threshold [0.0] [10:37:28] !log deployment-prep: force recompilation of puppet.conf : salt -v '*' cmd.run 'echo >> /etc/puppet/puppet.conf.d/10-main.conf' [10:37:31] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:37:39] !log deployment-prep: force recompilation of puppet.conf : salt -v '*' cmd.run 'echo >> /etc/puppet/puppet.conf.d/10-main.conf' - T153319 [10:37:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:37:42] T153319: Investigate non-puppetmaster instances configured to be puppetmasters - https://phabricator.wikimedia.org/T153319 [10:38:27] 10Beta-Cluster-Infrastructure, 10Thumbor: Investigate non-puppetmaster instances configured to be puppetmasters - https://phabricator.wikimedia.org/T153319#3234699 (10hashar) I also dropped /etc/puppet/puppet.conf.d/10-self.conf from all instances + deployment-fluorine02 [10:39:42] !log Removing puppetmaster: puppetmaster.thumbor.eqiad.wmflabs from deployment-imagescaler01 - T153319 [10:39:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:39:55] RECOVERY - Puppet errors on deployment-imagescaler01 is OK: OK: Less than 1.00% above the threshold [0.0] [10:43:53] 10Beta-Cluster-Infrastructure, 10Thumbor: Investigate non-puppetmaster instances configured to be puppetmasters - https://phabricator.wikimedia.org/T153319#3234737 (10hashar) 05Open>03Resolved a:03hashar # salt '*' cmd.run --out=yaml 'grep "\[master\]" /etc/puppet/puppet.conf -c' | grep -v "'0'" deployme... [10:44:07] 10Continuous-Integration-Infrastructure, 06Labs, 10Labs-Infrastructure, 07Beta-Cluster-reproducible, 07Puppet: New instance have broken puppet configuration when using puppetmaster standalone - https://phabricator.wikimedia.org/T148929#3234740 (10hashar) [10:45:54] PROBLEM - Puppet errors on deployment-imagescaler01 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [10:46:05] !log puppet ca sign deployment-ores-redis-02.deployment-prep.eqiad.wmflabs [10:46:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:46:59] !log puppet ca destroy deployment-ores-redis-02.deployment-prep.eqiad.wmflabs (no such instance) [10:47:02] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:47:21] !log puppet ca destroy deployment-zookeeper01.eqiad.wmflabs [10:47:24] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:56:36] 10Beta-Cluster-Infrastructure, 10media-storage, 13Patch-For-Review, 15User-fgiunchedi: Migrate beta cluster Swift cluster from Trusty to Jessie - https://phabricator.wikimedia.org/T162247#3234799 (10hashar) Well done @fgiunchedi :] [10:59:32] PROBLEM - Puppet errors on deployment-pdf01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [11:19:26] hashar: I have something I would really like to backport to enable us to re-enable the Cognate extension so wiktionaries still havce interwiki links [11:19:37] I guess you are the best person to get an A-OK from? :D [11:20:01] I will just press buttons so I guess cherry pick it to wmf branch ? [11:20:04] not sure who else from relang is awake [11:20:05] and we can swat it this afternoon [11:20:30] well, this is a no deploy week so no swat, I'm fine to do the deploy myself, but wanted an OK from someone :) [11:28:48] I'll be back after some food [12:02:00] 10Continuous-Integration-Infrastructure (Little Steps Sprint): For MediaWiki extensions, merge rubocop inside mwext-mw-selenium-jessie - https://phabricator.wikimedia.org/T164479#3234955 (10hashar) [12:02:43] 10Beta-Cluster-Infrastructure, 10ContentTranslation, 10ContentTranslation-CXserver: Move apertium to deployment-sca* hosts in Beta Cluster - https://phabricator.wikimedia.org/T142152#3234970 (10KartikMistry) @hashar We've Apertium service in sca01 already. So, just need to delete deployment-apertium02. ```... [12:23:45] addshore: ops is switching services to eqiad in 7 minutes ... so that is going to conflict [12:25:50] ahh okay, thats fine, I can do it later! This is why I was checking ;) [12:26:09] but at some point today would be great! :D [12:29:06] RECOVERY - Apertium APY on deployment-sca01 is OK: HTTP OK: HTTP/1.1 200 OK - 5632 bytes in 0.006 second response time [12:30:50] 10Beta-Cluster-Infrastructure, 10ContentTranslation, 10ContentTranslation-CXserver: Move apertium to deployment-sca* hosts in Beta Cluster - https://phabricator.wikimedia.org/T142152#3235035 (10akosiaris) I 've applied the roles on deployment-sca01 and deployment-sca02 and moved http://apertium-beta.wmflabs.... [12:52:54] PROBLEM - Host deployment-ms-be02 is DOWN: CRITICAL - Host Unreachable (10.68.21.135) [12:53:26] PROBLEM - Host deployment-ms-fe01 is DOWN: CRITICAL - Host Unreachable (10.68.16.96) [12:53:28] PROBLEM - Host deployment-ms-be01 is DOWN: CRITICAL - Host Unreachable (10.68.16.24) [13:26:40] 10Continuous-Integration-Infrastructure, 06Wikipedia-Android-App-Backlog: Grand sudo right for Michael Holloway (mobile team) on Android CI slave - https://phabricator.wikimedia.org/T164388#3235229 (10Mholloway) 05Open>03Resolved a:03Mholloway Thank you, @hashar! [13:32:39] (03PS7) 10Rammanojpotla: mediawiki_selenium should document SauceLabs usage [selenium] - 10https://gerrit.wikimedia.org/r/348935 [13:34:09] (03PS8) 10Rammanojpotla: mediawiki_selenium should document SauceLabs usage [selenium] - 10https://gerrit.wikimedia.org/r/348935 [13:46:10] 06Release-Engineering-Team, 06Operations, 05DC-Switchover-Prep-Q3-2016-17: Provide cross-dc redundancy (active-active or active-passive) to all important misc services - https://phabricator.wikimedia.org/T156937#3235268 (10jcrespo) [13:46:26] 06Release-Engineering-Team, 06Operations, 05DC-Switchover-Prep-Q3-2016-17: Provide cross-dc redundancy (active-active or active-passive) to all important misc services - https://phabricator.wikimedia.org/T156937#2990470 (10jcrespo) p:05High>03Normal [13:48:27] 06Release-Engineering-Team, 06Operations: Provide cross-dc redundancy (active-active or active-passive) to all important misc services - https://phabricator.wikimedia.org/T156937#3235275 (10jcrespo) Removing tag due to change in scope of the ticket. [13:52:30] 06Release-Engineering-Team, 10DBA, 10Datasets-General-or-Unknown, 13Patch-For-Review, and 2 others: Automatize the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459#3235305 (10jcrespo) [13:52:53] 06Release-Engineering-Team, 10DBA, 10Datasets-General-or-Unknown, 13Patch-For-Review, and 2 others: Automatize the check and fix of object, schema and data drifts between mediawiki HEAD, production masters and slaves - https://phabricator.wikimedia.org/T104459#1417808 (10jcrespo) [14:09:42] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-GettingStarted, 06Reading-Web-Backlog, and 2 others: Missing XML files cause "Publish Performance test result report" - https://phabricator.wikimedia.org/T164296#3235366 (10hashar) [14:10:14] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-GettingStarted, 06Reading-Web-Backlog, and 2 others: Missing XML files cause "Publish Performance test result report" - https://phabricator.wikimedia.org/T164296#3228948 (10hashar) My Jenkins issue was a duplica... [14:17:19] 10Beta-Cluster-Infrastructure, 10ContentTranslation, 10ContentTranslation-CXserver: Move apertium to deployment-sca* hosts in Beta Cluster - https://phabricator.wikimedia.org/T142152#3235405 (10hashar) >@akosiaris wrote: > Quick q why are there 4 `sca` hosts ? Not only that, but sca is actually almost deprec... [14:20:51] 10Continuous-Integration-Infrastructure, 06Labs, 10Labs-Infrastructure, 07Beta-Cluster-reproducible, 07Puppet: New instance have broken puppet configuration when using puppetmaster standalone - https://phabricator.wikimedia.org/T148929#2736876 (10madhuvishy) @hashar This seems like a known and documented... [14:35:00] 10Beta-Cluster-Infrastructure, 10Mathoid: Move mathoid to deployment-sca* hosts in Beta Cluster - https://phabricator.wikimedia.org/T142255#3235449 (10mobrovac) Time, @hashar :) Honestly and seriously, right now defining stuff for beta is too confusing, we have pieces in ops/puppet, wikitech hiera and horizon,... [14:39:38] hashar hi, i wonder does deployment-phab01 that use the old phabricator labs puppet class? [14:46:50] 10Beta-Cluster-Infrastructure: deployment-mx has old puppetmaster stuff - https://phabricator.wikimedia.org/T152353#3235525 (10hashar) 05Open>03Resolved a:03hashar I have cleaned up a bit and the conf looks good now. I have removed the cron entry for the git update and delete /var/lib/git/* [14:47:54] paladox: I cant tell which class it has :( [14:48:01] oh [14:49:13] 10Beta-Cluster-Infrastructure, 10Wikimedia-Extension-setup, 07Category, 10FileAnnotations (Beta Cluster Release): Release FileAnnotations on the Beta Cluster - https://phabricator.wikimedia.org/T144302#2595485 (10hashar) Is FileAnnotations still something we want to deploy on beta cluster? Or is that just... [14:50:09] paladox: role::phabricator::main [14:50:11] apparently [14:50:15] thanks. [14:50:31] it uses prods role :) [14:53:01] 10Continuous-Integration-Infrastructure, 06Operations, 07Upstream, 07Zuul: Let us customize Zuul metrics reported to statsd - https://phabricator.wikimedia.org/T1369#3235556 (10hashar) 05Open>03declined Seems statsd is strong enough to handle the metrics. Notably nowadays we have ~ 300 jobs instead of... [14:56:01] 10Beta-Cluster-Infrastructure, 10media-storage, 13Patch-For-Review: deployment-ms-be01.deployment-prep and deployment-ms-be02.deployment-prep have high load / system CPU - https://phabricator.wikimedia.org/T160990#3235563 (10hashar) [14:57:12] (03PS2) 10Hashar: Create SWAT gate and submit pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/351131 (https://phabricator.wikimedia.org/T160668) (owner: 10Thcipriani) [14:57:31] 10Continuous-Integration-Infrastructure (Little Steps Sprint), 13Patch-For-Review: Create "High Priority" gate-and-submit pipeline - https://phabricator.wikimedia.org/T160668#3235573 (10hashar) a:03thcipriani [15:03:35] (03CR) 10Hashar: [C: 031] "That looks good overall. I guess we wanna try deploy it and see what happens!? I might write a few more tests as follow up." [integration/config] - 10https://gerrit.wikimedia.org/r/351131 (https://phabricator.wikimedia.org/T160668) (owner: 10Thcipriani) [15:03:43] finally [15:03:52] thcipriani|afk: reviewed your swat gate stuff for zuul [15:03:58] I think it would do [15:04:06] nice :) [15:04:13] most probably I will add some more tests as a follow up [15:04:15] but later! [15:04:27] if you feel adventurous to baby sit it today and watch the zuul status page, please be bold! [15:04:33] it is not friday yet ! [15:04:36] :D [15:05:14] I'll give that a shot later today. [15:05:20] and kudos on https://gerrit.wikimedia.org/r/#/c/351131/2/tests/test_zuul_scheduler.py :] [15:05:48] I would keep little steps sprint around [15:05:57] heh, it did catch an error in my regex [15:06:02] but I think we got all the low hanging fruit dealt with already [15:06:18] or rather, I guess, it caught an error in my assumption about how branch regexes were combined [15:06:24] ah yeah [15:06:26] that is a mess [15:07:00] I should double check the 19MBytes zuul layout diff [15:08:11] the idea is the pipeline branch filter would allow/accept the CHANGE to enter the pipeline [15:08:27] then jobs get triggered and their branch filters will prevent the JOB from being triggered [15:08:41] luckily there is only two levels to dig in :] [15:10:34] yeah, it certainly seems like working against the design of zuul to have it pay much attention to branches, which is...weird. [15:16:38] (03PS1) 10Mholloway: Whitelist Jcasariego [integration/config] - 10https://gerrit.wikimedia.org/r/351863 [15:21:48] hey hey thcipriani|afk are you really afk? or? ;) [15:22:01] heh, I guess not [15:22:27] http://www.theonion.com/article/man-invisible-on-gchat-observes-world-from-impregn-32701 [15:22:56] So, regarding Cognate being disabled yesterday after the DC switchover https://phabricator.wikimedia.org/T164407 it would be great to backport https://gerrit.wikimedia.org/r/#/c/351801/ and deploy it today (and turn Cognate back on in readonly mode) [15:23:53] 10Beta-Cluster-Infrastructure, 10Wikimedia-Extension-setup, 07Category, 10FileAnnotations (Beta Cluster Release): Release FileAnnotations on the Beta Cluster - https://phabricator.wikimedia.org/T144302#3235647 (10MarkTraceur) It's currently stalled awaiting some form of Wikibase on Commons, we decided it w... [15:30:20] so specifically https://gerrit.wikimedia.org/r/#/c/351867/ thcipriani as well as a config patch turning readme mode ON and the extension ON [15:31:13] addshore: yeap, just catching up on the task [15:33:44] config patch @ https://gerrit.wikimedia.org/r/#/c/351868/ [15:33:56] If you spot anything we might have missed to do with the issue that would be great! [15:37:26] It would probably be useful to also backport https://gerrit.wikimedia.org/r/#/c/351845/ for some extra monitoring [15:42:02] addshore: so in looking at the task you say the selects are killing the db, but making cognate readonly, won't it still be running stuff like selectLinkDetailsForPage? [15:43:52] So, we dont think the selects themselves killed the db, but the number of backed up selects using connections exhausting to server [15:44:05] and the number of selects backing up, caused by the table levels locks [15:44:27] the table level locks caused by apparently long running write queries and the query killer kicking in (which apparently caused the locks) [15:44:59] It might be worth me pasting some of the discussion I have had with jynus in the ticket to be fair [15:45:38] gotcha, ok, looks like there is some swift stuff happening in -operations, currently, lemme poke jynus about this... [15:45:47] okay! [15:57:07] addshore: I'm figuring out when an ok time is to do this for ops in the midst of the datacenter switch work now [15:59:29] thcipriani: ack! :) [16:00:21] addshore: they're switching deployment servers right now, so it'll be a few, FYI [16:01:28] Project mediawiki-core-code-coverage build #2739: 04FAILURE in 1 hr 1 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/2739/ [16:17:14] addshore: we're clear, you around? [16:23:33] thcipriani: yup [16:32:35] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3235860 (10demon) >>! In T158360#3234214, @Amire80 wrote: > I did notice that messages aren't updated, and assumed that it's related to the reduction of deployments re... [17:05:39] PROBLEM - Puppet errors on buildlog is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:05:43] PROBLEM - Puppet errors on swift is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:06:43] PROBLEM - Puppet errors on deployment-urldownloader is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:07:17] PROBLEM - Puppet errors on swift-storage-01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:07:23] PROBLEM - Puppet errors on deployment-ircd is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:14:08] 10Continuous-Integration-Config, 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Kanban-Board: Migrate experimental CI job mwext-MobileFrontend-npm-run-lint-modules to stable - https://phabricator.wikimedia.org/T163882#3236081 (10Jdlrobson) [17:14:53] 10Continuous-Integration-Config, 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Kanban-Board: Migrate experimental CI job mwext-MobileFrontend-npm-run-lint-modules to stable - https://phabricator.wikimedia.org/T163882#3236085 (10phuedx) [17:57:10] 10Beta-Cluster-Infrastructure, 10Wikimedia-Extension-setup, 07Category, 10FileAnnotations (Beta Cluster Release): Release FileAnnotations on the Beta Cluster - https://phabricator.wikimedia.org/T144302#3236320 (10hashar) That makes sense. Thank you! [17:58:36] 10Beta-Cluster-Infrastructure, 10Wikimedia-Extension-setup, 07Category, 10FileAnnotations (Beta Cluster Release): Release FileAnnotations on the Beta Cluster - https://phabricator.wikimedia.org/T144302#3236331 (10Prtksxna) 05Open>03stalled [18:14:06] (03PS1) 10Umherirrender: Add some composer jobs [integration/config] - 10https://gerrit.wikimedia.org/r/351912 [18:38:07] greg-g: Hey, Can I get two slots tomorrow for two things: 1- running a two-hour long main. script for T159753 2- merging and deploying https://gerrit.wikimedia.org/r/#/c/347395/ (ops namely _joe_ gave their okay but it should be done after the switchover) [18:38:07] T159753: Concerns about ores_classification table size on enwiki - https://phabricator.wikimedia.org/T159753 [18:38:38] If you think one or both of them should be done in Monday, it's still okay [18:38:50] none of them are urgent [18:39:06] I think you answered your question :) [18:39:46] greg-g: :D Okay, Can I add those windows in Monday? [18:40:38] I want to run the "1" on 02:00 UTC because the load on the database is the lowest at that time [18:40:38] doit [18:40:59] the second one should be done when ops are around [18:41:07] Thanks! [19:11:05] 10Gerrit, 06Release-Engineering-Team, 06Operations, 10hardware-requests, 13Patch-For-Review: Requesting 1 spare misc box for Gerrit in codfw - https://phabricator.wikimedia.org/T148187#3236674 (10demon) [19:11:06] 10Gerrit, 06Release-Engineering-Team, 06Operations, 13Patch-For-Review: setup/install gerrit2001/WMF6408 - https://phabricator.wikimedia.org/T152525#3236671 (10demon) 05Open>03Resolved Gerrit running on `gerrit2001.wikimedia.org` in codfw. Git data is being replicated just fine. [19:12:52] 10Gerrit, 06Release-Engineering-Team, 06Operations, 13Patch-For-Review: Build warm slave for Gerrit in Dallas - https://phabricator.wikimedia.org/T148186#3236675 (10demon) 05Open>03Resolved a:03demon Spare is running in Dallas, data is being replicated in real time so I think we're warm. Only improv... [19:15:07] (03PS3) 10Legoktm: Update PHP CodeSniffer to 2.9.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/351532 (owner: 10Paladox) [19:15:09] (03PS3) 10Legoktm: Release 0.8.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/351528 (https://phabricator.wikimedia.org/T154715) [19:16:24] heh 3.0.0 is now released [19:16:24] https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.0.0 [19:16:39] yeah just saw that [19:16:49] https://github.com/squizlabs/PHP_CodeSniffer/wiki/Version-3.0-Upgrade-Guide doesn't look too bad [19:17:25] 10MediaWiki-Codesniffer: Update squizlabs/PHP_CodeSniffer to 3.x - https://phabricator.wikimedia.org/T142474#3236705 (10Paladox) 3.0 stable has now been released https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.0.0 :) [19:17:59] yeyep [19:18:02] woops, i meant yep [19:19:31] it looks like CI is going to take an hour? ugh [19:20:11] oh [19:20:55] 2.0 is in maint mode now. No more releases except for security fixes [19:21:05] legoktm: For `check experimental` it's very backlogged, but test and gate are going as normal. [19:21:24] 20 min is normal now? :( [19:21:34] Yes. [19:24:21] legoktm: Partly my fault for +2ing a bunch of repos' composer.json improvements by Umherirrender (who's also responsible for all the experimental jobs). [19:24:27] ah [19:24:28] no worries [19:25:16] legoktm see https://gerrit.wikimedia.org/r/#/c/351701/ for fixing https://integration.wikimedia.org/ci/job/mw-tools-codesniffer-mwcore-testrun/269/ [19:26:10] 10Gerrit, 06Release-Engineering-Team, 06Operations, 13Patch-For-Review: setup/install gerrit2001/WMF6408 - https://phabricator.wikimedia.org/T152525#3236823 (10Dzahn) [19:33:30] (03CR) 10Legoktm: [C: 032] Update PHP CodeSniffer to 2.9.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/351532 (owner: 10Paladox) [19:33:36] thanks ^^ [19:33:55] (03CR) 10Legoktm: [C: 032] Release 0.8.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/351528 (https://phabricator.wikimedia.org/T154715) (owner: 10Legoktm) [19:34:59] (03Merged) 10jenkins-bot: Update PHP CodeSniffer to 2.9.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/351532 (owner: 10Paladox) [19:35:02] (03Merged) 10jenkins-bot: Release 0.8.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/351528 (https://phabricator.wikimedia.org/T154715) (owner: 10Legoktm) [19:37:28] https://packagist.org/packages/mediawiki/mediawiki-codesniffer [19:38:06] legoktm https://gerrit.wikimedia.org/r/#/c/351931/ :) [19:38:21] it's going to terribly fail [19:38:48] oh [19:39:49] need to add exclusion rules to skip the new rules [19:39:59] yep [19:41:30] well that's going to be a big log file full of errors https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-trusty/14448/console [19:44:02] MediaWiki.Commenting.FunctionComment.MissingParamComment needs disabling [19:56:56] hmm is this a bug [19:56:57] Function name "pg_array_parse" should use lower camel [19:56:57] 19:49:18 | | case. [19:57:10] legoktm ^^ [19:57:32] it's a php function [19:57:37] So it probably needs adding to an exclusion [19:57:54] file a bug? [19:57:58] ok thanks. [20:00:42] yep [20:00:43] 10MediaWiki-Codesniffer: MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName is incorrectly saying "pg_array_parse" should use lower camel - https://phabricator.wikimedia.org/T164533#3236927 (10Paladox) [20:00:44] done ^^ [20:03:48] paladox: can you also include the relevant lines of code that it is tripping on and the full sniff report? [20:03:58] yep [20:05:19] 10MediaWiki-Codesniffer: MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName is incorrectly saying "pg_array_parse" should use lower camel - https://phabricator.wikimedia.org/T164533#3236943 (10Paladox) [20:05:24] done [20:11:08] paladox: no I mean like copy a few lines of code that is triggering it and specify what file in which repo [20:11:18] oh [20:13:45] 10MediaWiki-Codesniffer: MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName is incorrectly saying "pg_array_parse" should use lower camel - https://phabricator.wikimedia.org/T164533#3236957 (10Paladox) that function is in file includes/libs/rdbms/database/DatabasePostgres.php on line 867 https://g... [20:13:58] done [20:17:33] that lower function name seems to have been introduced in https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/aad5b5c139ac9a91e808dd0f04410ecba6db8814 [20:23:58] legoktm should i remove /**#@-*/ under public static function stripComment( $text ) {} ? [20:23:59] 20:16:19 183 | WARNING | [x] Invalid start of a single line comment [20:24:00] 20:16:19 | | (MediaWiki.Commenting.IllegalSingleLineComment.IllegalSingleLineCommentStart) [20:27:25] the sniff is correct [20:27:33] that one just needs a ignore thingy [20:31:37] ok [20:32:57] legoktm getting better now https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-trusty/14457/console not so many errors [21:01:08] nodepool seems to have just become very slow [21:01:08] https://integration.wikimedia.org/zuul/ [21:01:18] i see only three tests being one with some using nodepool [21:01:39] thcipriani ^^ [21:02:09] https://grafana.wikimedia.org/dashboard/db/nodepool?orgId=1 [21:02:28] most instances are used + delete + building stage [21:02:45] oh [21:14:40] (03PS1) 10Legoktm: Fix typo in HISTORY [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/352032 [21:14:55] (03CR) 10Legoktm: [C: 032] "shh" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/352032 (owner: 10Legoktm) [21:15:31] PROBLEM - Work requests waiting in Zuul Gearman server https://grafana.wikimedia.org/dashboard/db/zuul-gearman on contint1001 is CRITICAL: CRITICAL: 42.86% of data above the critical threshold [140.0] [21:15:41] 10MediaWiki-Codesniffer, 13Patch-For-Review: Release Codesniffer v0.8.0 - https://phabricator.wikimedia.org/T154715#3237095 (10Legoktm) 05Open>03Resolved a:03Legoktm https://lists.wikimedia.org/pipermail/wikitech-l/2017-May/088122.html Sorry about the delay :( I'm hoping to get back to a more regular sc... [21:17:28] legoktm i was just thinking on documenetation there's going to be a heep ton of patches to fix all those new rules that were added in codesniffer :) [21:17:55] :D [21:18:29] but i fixed a few when i was at it [21:18:34] but the log crashed safari [21:19:32] legoktm: Meh. Being demanded to document __construct() methods is a bit sucky. [21:19:38] (03Merged) 10jenkins-bot: Fix typo in HISTORY [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/352032 (owner: 10Legoktm) [21:20:06] Oh [21:20:12] Did that not get fixed? [21:20:36] Well, I just installed 0.8.0 in VE and it complained about the first method in class ApiVisualEditor extends ApiBase :-( [21:20:41] Oops [21:20:53] Hmmm [21:21:02] Some constructors do need docs though [21:21:13] must be the new documenetation changes :) [21:21:28] I wouldn't want to blanket exclude it [21:21:43] Oh, sure, but how do I tell it where to go read ApiBase so it's happy? I added just an @inheritDoc (though https://www.phpdoc.org/docs/latest/guides/inheritance.html says you shouldn't) but now it wants the documentation for each parameter. [21:22:18] I don't think inheritDoc works [21:22:27] We should support it though [21:22:30] That'd do it. [21:22:39] Sorry. [21:35:19] * paladox is watching the uk local elections [21:35:58] legoktm https://gerrit.wikimedia.org/r/#/c/351931/ passes now :) [21:52:40] I not sure it makes sense to make style changes in the same patch [21:52:59] Oh. [21:53:00] Usually, it's disable all, then re-enable them and fix them in subsequent patches [21:53:12] should i revert the code changes? [21:53:43] Reedy ^^ [21:54:26] You can put them into a dependent patch [21:54:32] ok [21:57:51] Yup. [21:58:07] Reedy https://gerrit.wikimedia.org/r/352046 :) [22:03:39] legoktm: Also the `onRecentChange_save` hook doesn't work very well with MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName :-) [22:03:51] (We really should fix that hook's name.) [22:03:58] James_F is it already lower case? [22:04:00] I noticed it too [22:04:17] James_F see https://phabricator.wikimedia.org/T164533 [22:04:22] * James_F is mostly just here to complain, clearly. [22:31:04] RECOVERY - Work requests waiting in Zuul Gearman server https://grafana.wikimedia.org/dashboard/db/zuul-gearman on contint1001 is OK: OK: Less than 30.00% above the threshold [90.0]