[03:58:33] Project mediawiki-core-code-coverage build #2740: 04STILL FAILING in 58 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/2740/ [06:43:43] Yippee, build fixed! [06:43:43] Project selenium-Wikibase » chrome,beta,Linux,BrowserTests build #351: 09FIXED in 2 hr 3 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/351/ [07:05:18] Project beta-scap-eqiad build #153967: 04FAILURE in 1 min 34 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/153967/ [07:15:44] Yippee, build fixed! [07:15:44] Project beta-scap-eqiad build #153968: 09FIXED in 2 min 2 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/153968/ [08:30:11] !log cherry-pick https://gerrit.wikimedia.org/r/#/c/350220/ on deployment-puppetmaster02 [08:30:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:04:54] hashar: is it possible to check a change out on the beta cluster (for an extension) to test it before merging? or not? [09:05:41] addshore: via a terrible hack yeah [09:05:53] oooooh, is the terrible hack documented or? :P [09:06:01] but realisticly your change should already be covered by a full set of tests and behind a $wg feature flag :]]]] [09:06:37] so the repositories are on deployment-tin.deployment-prep.eqiad.wmflabs [09:06:58] in /srv/mediawiki-staging/php-master/extensions which happens to be a clone of mediawiki/extensions.git [09:07:18] that one is auto magically updated by Jenkins jobs every x minutes. List of jobs being on the view: http://integration.wikimedia.org/ci/view/Beta/ [09:07:26] https://integration.wikimedia.org/ci/view/Beta/job/beta-code-update-eqiad/ [09:07:44] which really is: [09:07:55] while true; do git pull; sleep 600; done; [09:08:00] so [09:08:28] you wanna disable that job [09:08:45] https://integration.wikimedia.org/ci/view/Beta/job/beta-code-update-eqiad/ >>> on the right side the blue button [Disable Project] [09:08:57] then head to depoyment-tin, do your local hack / cherry pick what not [09:09:17] then either run scap from the commandline , or just trigger a build of https://integration.wikimedia.org/ci/view/Beta/job/beta-scap-eqiad/ [09:09:48] It's a maint script so I only need it on the deployment server to test [09:09:50] addshore: the magic doc ^^^ ¥€$ [09:09:58] thanks for the magic doc :D [09:10:02] even better [09:10:06] then get rid of my Cherrypick and turn the job back on :) [09:10:30] note that if you use mwscript, I am not sure whether it runs the script from /srv/mediawiki-staging or from /srv/mediawiki [09:10:46] I checked and I think it decides based on where you are, but I will check again [09:11:07] I did try and just pull the script into my home dir, but there is no way to pass such a path into mwscript [09:11:37] And yeh, it was a switch on staging "if [ -d "$MEDIAWIKI_STAGING_DIR" ]; then" [09:12:18] !log temporarily disabled beta-code-update-eqiad [09:12:21] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:12:44] ahh that is a switch based on directory existence. neat [09:12:56] hashar: which user should I be cherrypciking as etc? [09:13:11] that is left as an exercise ? : ] [09:13:16] addshore: jenkins-deploy [09:13:23] perhaps I don't have the correct permissions there? or is this more different to prod than I though [09:13:24] ahhhaah, okay! [09:13:27] that is the unix user Jenkins uses to connect to deployment-tin [09:13:44] and that user has the proper sudo rights to become mwdeploy / www-data / l10nupdate etc [09:13:50] ack [09:13:53] sudo su - jenkins-deploy [09:13:57] jenkins-deploy$ sudo -l [09:14:03] (that might show all the perms) [09:18:00] !log temporarily enabled beta-code-update-eqiad [09:18:02] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:18:27] thanks hashar! :D (I'll probably do it again a bit later) [09:18:35] sure thing [09:18:48] addshore: and make sure beta-code-update-eqiad works properly :] [09:18:51] well [09:18:54] yup! [09:18:57] really it will trigger in the next 10 minutes or so [09:19:03] and complain here if something goes wrong [09:19:06] *hits build now* [09:20:04] !log cherry-pick https://gerrit.wikimedia.org/r/#/c/350817 on deployment-puppetmaster02 [09:20:06] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:24:05] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3237951 (10Nikerabbit) Since it is hard to detect when LU is or isn't working, we could add one dummy message key to MediaWiki core which contains the timestamp of las... [09:55:29] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [10:12:15] hashar: if you have time today can we retry to test https://gerrit.wikimedia.org/r/#/c/351854/1/wmf-config/jobqueue.php ? [11:01:00] 10MediaWiki-Releasing, 05MW-1.27-release: Patch for 1.27.3 missing - https://phabricator.wikimedia.org/T164470#3238254 (10Aklapper) (unrelated to #Wikimedia-General-or-Unknown) [11:14:57] 10Continuous-Integration-Infrastructure (Little Steps Sprint), 15User-zeljkofilipin: For MediaWiki extensions, merge rubocop inside mwext-mw-selenium-jessie - https://phabricator.wikimedia.org/T164479#3238260 (10zeljkofilipin) p:05Triage>03Normal [12:25:22] elukey: yeah i am around [12:25:29] sorry was lunching / dealing with mails etc [12:29:15] elukey: should we try it on the beta cluster first ? [12:31:13] oh yes! I meant on deployment-prep, not in prod :) [12:33:50] elukey: i would be happy to +2 a change to wmf-config/jobqueue-labs.php :] [12:40:18] I still don't get which one is picked up in deployment-prep [12:41:34] phab tasks about quint tests that would be ci-config project tag correct? [12:46:13] elukey: the -labs.php one [12:46:45] Zppix: what is "quint tests"? [12:47:02] qunit* [12:47:17] hashar: sure but IIRC you told me that for some reason it wasn't used for the jobrunners in deployment-prep :D [12:50:56] Zppix: oh my.. sorry. So qunit tests, 99% of the time the issue is in the developers / source code, not in CI configuration or infrastructure [12:51:22] hashar: i see okay thanks, and no worries [12:59:45] (03CR) 10Hashar: [C: 032] Add some composer jobs [integration/config] - 10https://gerrit.wikimedia.org/r/351912 (owner: 10Umherirrender) [13:01:01] (03Merged) 10jenkins-bot: Add some composer jobs [integration/config] - 10https://gerrit.wikimedia.org/r/351912 (owner: 10Umherirrender) [13:23:45] 10Continuous-Integration-Infrastructure (Little Steps Sprint): For MediaWiki extensions, merge composer test into mwext-textextension / mediawiki-extensions jobs - https://phabricator.wikimedia.org/T161895#3146533 (10hashar) p:05Triage>03Normal a:03hashar [13:24:36] (03PS1) 10Hashar: Allow composer-test to run in different directory [integration/config] - 10https://gerrit.wikimedia.org/r/352128 (https://phabricator.wikimedia.org/T161895) [13:25:11] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I believe there is nothing to "recheck" here since this is only a .md file. ;-)" [ruby/api] - 10https://gerrit.wikimedia.org/r/348225 (owner: 10Rammanojpotla) [13:35:28] (03CR) 10EddieGP: [C: 031] "Well that doesn't change anything - if that repository has a jenkins job, it should run when anything is changed, regarless if it's only a" [ruby/api] - 10https://gerrit.wikimedia.org/r/348225 (owner: 10Rammanojpotla) [13:36:31] (03CR) 10Hashar: "I have +2ed all the related changes :]" [integration/config] - 10https://gerrit.wikimedia.org/r/351912 (owner: 10Umherirrender) [13:40:50] (03CR) 10Zfilipin: [C: 031] Allow composer-test to run in different directory [integration/config] - 10https://gerrit.wikimedia.org/r/352128 (https://phabricator.wikimedia.org/T161895) (owner: 10Hashar) [13:45:54] 10Scap (Scap3-Adoption-Phase1), 10releng-201516-q4: [keyresult] Migrate remaining trebuchet deployed services - https://phabricator.wikimedia.org/T129290#3238721 (10akosiaris) [13:45:58] 10Scap (Scap3-Adoption-Phase1), 10Monitoring, 06Operations, 10netops, 13Patch-For-Review: Deploy libreNMS with scap3 - https://phabricator.wikimedia.org/T129136#3238719 (10akosiaris) 05Open>03Resolved After a year and 2 months, I can finally happily resolve this. scap3 is now used to deploy librenms,... [13:54:19] (03CR) 10Zfilipin: [C: 032] "Looks good to me! Thanks! :)" [ruby/api] - 10https://gerrit.wikimedia.org/r/348225 (owner: 10Rammanojpotla) [13:54:32] 10Browser-Tests-Infrastructure, 07Documentation, 07Easy, 13Patch-For-Review: audit/update headers in files - https://phabricator.wikimedia.org/T69141#3238747 (10Rammanojpotla) @zeljkofilipin updatd the commit message in the patches of Pdfhandler and PageTriage directories can you review it please? [13:57:06] hashar: do you have a minute for a quick zuul question? [13:57:29] I have +2d this, but I do not see it in zuul https://gerrit.wikimedia.org/r/#/c/348225/ [13:58:35] (03CR) 10Zfilipin: Ruby gem documentation should state license [ruby/api] - 10https://gerrit.wikimedia.org/r/348225 (owner: 10Rammanojpotla) [13:58:42] (03CR) 10Zfilipin: [C: 032] Ruby gem documentation should state license [ruby/api] - 10https://gerrit.wikimedia.org/r/348225 (owner: 10Rammanojpotla) [13:59:27] I have tried removing my vote and voting again [13:59:32] did not help [14:02:38] (03CR) 10Zfilipin: [C: 032] "I am not sure why zuul is not picking this up." [ruby/api] - 10https://gerrit.wikimedia.org/r/348225 (owner: 10Rammanojpotla) [14:02:54] (03CR) 10EddieGP: [C: 031] "As said before, just like I noticed on commenting "recheck" two times: There seem to be no jobs on this repo, so you'll likely need to V+2" [ruby/api] - 10https://gerrit.wikimedia.org/r/348225 (owner: 10Rammanojpotla) [14:04:50] 10Browser-Tests-Infrastructure, 07Documentation, 07Easy, 13Patch-For-Review, 07Software-Licensing: Ruby gem documentation should state license - https://phabricator.wikimedia.org/T94001#3238800 (10zeljkofilipin) I have reviewed the commit. I am not sure why it is not getting merged. [14:06:45] (03CR) 10Umherirrender: "Have about 60 other repositories to have composer for all wmf deployed extensions" [integration/config] - 10https://gerrit.wikimedia.org/r/351912 (owner: 10Umherirrender) [14:09:37] 10Browser-Tests-Infrastructure, 07Documentation, 07Easy, 13Patch-For-Review: audit/update headers in files - https://phabricator.wikimedia.org/T69141#3238812 (10zeljkofilipin) I get e-mail notification from Gerrit. Thanks for the reminder, but it is not necessary. [14:11:41] (03CR) 10Zfilipin: [C: 032] "That is strange. There used to be a couple of jobs for this repo. Take a look at this commit, for example:" [ruby/api] - 10https://gerrit.wikimedia.org/r/348225 (owner: 10Rammanojpotla) [14:12:06] zeljkof: I've looked it up in the layout.yaml of integration-config, there is only one job on this repo (that is "rake-jessie") which does not trigger if only a .md file was changed. See the regex here: https://phabricator.wikimedia.org/diffusion/CICF/browse/master/zuul/layout.yaml;4fc223932cdd1a389580218ff881635720605dd0$653 [14:12:31] eddiegp: oh, that might be the case [14:12:58] anyway, it's strange [14:13:24] shouldn't zuul merge a commit after +2? [14:13:38] Only if there is a V+2 too. [14:13:45] hm, it might be waiting for somebody to give verified:+1 [14:13:45] And there isn't if no jobs a triggered. [14:13:48] I guess. [14:14:30] (03CR) 10Zfilipin: [V: 032 C: 032] Ruby gem documentation should state license [ruby/api] - 10https://gerrit.wikimedia.org/r/348225 (owner: 10Rammanojpotla) [14:15:21] I gave verified+2, but looks like I have to manually submit too [14:15:33] Yeah, you have. [14:15:39] ok, done [14:15:53] strange [14:16:08] If a job in the gate-and-submit pipeline is triggered AND all jobs in that pipeline report success THEN zuul will post V+2 and merge. See https://phabricator.wikimedia.org/diffusion/CICF/browse/master/zuul/layout.yaml;4fc223932cdd1a389580218ff881635720605dd0$582 [14:16:52] (03PS1) 10Umherirrender: Add some composer jobs [integration/config] - 10https://gerrit.wikimedia.org/r/352154 [14:17:20] If no jobs are triggered in the first place the condition "jobs report success" is just never met. [14:24:07] (03CR) 10jenkins-bot: Ruby gem documentation should state license [ruby/api] - 10https://gerrit.wikimedia.org/r/348225 (owner: 10Rammanojpotla) [14:29:37] PROBLEM - Host deployment-phab02 is DOWN: CRITICAL - Host Unreachable (10.68.19.232) [14:40:32] 10Browser-Tests-Infrastructure, 07Documentation, 07Easy, 07Software-Licensing, 15User-zeljkofilipin: Ruby gem documentation should state license - https://phabricator.wikimedia.org/T94001#3238914 (10zeljkofilipin) [14:43:55] !sal [14:43:55] https://tools.wmflabs.org/sal/releng [14:44:10] (03PS1) 10Hashar: mwext-testextension now runs composer test [integration/config] - 10https://gerrit.wikimedia.org/r/352160 (https://phabricator.wikimedia.org/T161895) [14:47:03] (03CR) 10Zfilipin: [C: 04-1] "The commit now looks good! Before merging, the commit message should be fixed." (032 comments) [selenium] - 10https://gerrit.wikimedia.org/r/348935 (owner: 10Rammanojpotla) [14:47:37] 10Browser-Tests-Infrastructure, 07Documentation, 07Easy, 13Patch-For-Review: mediawiki_selenium should document SauceLabs usage - https://phabricator.wikimedia.org/T98331#3238954 (10zeljkofilipin) I have left my comments in Gerrit. [14:48:20] 10Beta-Cluster-Infrastructure, 10Phabricator, 13Patch-For-Review, 07Puppet: puppet failure on deployment-phab01 ... is not a Hash. It looks to be a Array at /etc/puppet/modules/phabricator/manifests/init.pp:68 - https://phabricator.wikimedia.org/T147818#3238955 (10hashar) I have unbroke deployment-phab01... [14:49:11] 10Beta-Cluster-Infrastructure, 10Phabricator, 13Patch-For-Review, 07Puppet: puppet failure on deployment-phab01: Service[ssh-phab] refuses to start - https://phabricator.wikimedia.org/T147818#3238957 (10hashar) [14:50:35] (03CR) 10Zfilipin: [C: 031] mwext-testextension now runs composer test [integration/config] - 10https://gerrit.wikimedia.org/r/352160 (https://phabricator.wikimedia.org/T161895) (owner: 10Hashar) [14:51:09] 10Beta-Cluster-Infrastructure, 10Phabricator, 13Patch-For-Review, 07Puppet: puppet failure on deployment-phab01: Service[ssh-phab] refuses to start - https://phabricator.wikimedia.org/T147818#2704482 (10hashar) [14:52:49] 10Browser-Tests-Infrastructure, 07JavaScript, 15User-zeljkofilipin: WebdriverIO CREDIT showcase - https://phabricator.wikimedia.org/T164070#3238973 (10zeljkofilipin) Done! https://www.mediawiki.org/wiki/CREDIT_showcase/2017-05-03 [14:57:17] 10Browser-Tests-Infrastructure, 07JavaScript, 15User-zeljkofilipin: WebdriverIO CREDIT showcase - https://phabricator.wikimedia.org/T164070#3238986 (10zeljkofilipin) 05Open>03Resolved Updated relevant page: https://www.mediawiki.org/w/index.php?diff=2461946&oldid=2460155&title=Selenium%2FNode.js%2FWrite&... [14:57:20] 10Browser-Tests-Infrastructure, 10MediaWiki-General-or-Unknown, 07JavaScript, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), and 4 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3238988 (10zeljkofilipin) [14:59:57] (03PS9) 10Rammanojpotla: mediawiki_selenium should document SauceLabs usage [selenium] - 10https://gerrit.wikimedia.org/r/348935 (https://phabricator.wikimedia.org/T98331) [15:06:15] 10Beta-Cluster-Infrastructure, 10Phabricator, 13Patch-For-Review, 07Puppet: puppet failure on deployment-phab01: Service[ssh-phab] refuses to start - https://phabricator.wikimedia.org/T147818#3239033 (10Paladox) Probably because it needs a different ip as it can't bound to the same port 22 on the same ip. [15:12:47] (03CR) 10Zfilipin: [C: 032] mediawiki_selenium should document SauceLabs usage [selenium] - 10https://gerrit.wikimedia.org/r/348935 (https://phabricator.wikimedia.org/T98331) (owner: 10Rammanojpotla) [15:14:46] (03Merged) 10jenkins-bot: mediawiki_selenium should document SauceLabs usage [selenium] - 10https://gerrit.wikimedia.org/r/348935 (https://phabricator.wikimedia.org/T98331) (owner: 10Rammanojpotla) [15:16:50] (03CR) 10jenkins-bot: mediawiki_selenium should document SauceLabs usage [selenium] - 10https://gerrit.wikimedia.org/r/348935 (https://phabricator.wikimedia.org/T98331) (owner: 10Rammanojpotla) [15:19:57] (03PS1) 10Hashar: Jobs for mediawiki/skins/Athena [integration/config] - 10https://gerrit.wikimedia.org/r/352166 [15:20:38] (03CR) 10Hashar: [C: 04-1] "mmediawiki/skins/Athena is a new repo and lacks composer/npm standard commands." [integration/config] - 10https://gerrit.wikimedia.org/r/352166 (owner: 10Hashar) [15:33:40] 10Gerrit, 10Analytics-Tech-community-metrics: Numerous Gerrit (draft) patchsets cannot be accessed: "Cannot display change because it has no revisions." - https://phabricator.wikimedia.org/T161207#3239157 (10Paladox) @hashar or @Aklapper did it produce an error in the logs? I've back ported this https://gerrit... [15:44:07] Project language-screenshots-VisualEditor-350857 » chrome,Windows 10,ci-jessie-wikimedia build #1: 09SUCCESS in 20 min: https://integration.wikimedia.org/ci/job/language-screenshots-VisualEditor-350857/BROWSER=chrome,PLATFORM=Windows%2010,label=ci-jessie-wikimedia/1/ [16:03:17] Project mediawiki-core-code-coverage build #2741: 04STILL FAILING in 1 hr 3 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/2741/ [16:12:24] 06Release-Engineering-Team, 06Operations, 10Phabricator, 13Patch-For-Review: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3239287 (10Paladox) This is currently working in labs. But we will see if it actually works when ph... [16:12:36] 06Release-Engineering-Team, 06Operations, 10Phabricator: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3239304 (10Paladox) [16:42:35] 06Release-Engineering-Team, 06Operations, 10Phabricator: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3239429 (10Dzahn) @Paladox By "this" you mean that you can currently take a jessie labs instance, apply the same puppet r... [16:42:53] 10MediaWiki-Releasing, 05MW-1.27-release: Patch for 1.27.3 missing - https://phabricator.wikimedia.org/T164470#3239432 (10demon) So there seems to have been an issue in the build script--patches are not generated against extensions (1.27.3 and 1.28.2 were just for SyntaxHighlight). The patch itself is just [[... [16:43:45] 06Release-Engineering-Team, 06Operations, 10Phabricator: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3239433 (10Paladox) Ok. I haven't tested by making a new instance. But everything looks in working order. I can run syste... [16:43:53] 06Release-Engineering-Team, 06Operations, 10Phabricator: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3239434 (10Paladox) 05Open>03Resolved a:03Paladox [16:45:38] 06Release-Engineering-Team, 06Operations, 10Phabricator: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3239436 (10Dzahn) Well, if you **haven't tested**, then please don't claim it works, reopen and test it. [16:45:48] 06Release-Engineering-Team, 06Operations, 10Phabricator: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3239437 (10Dzahn) 05Resolved>03Open [16:49:50] 06Release-Engineering-Team, 06Operations, 10Phabricator: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3239443 (10Paladox) >>! In T158434#3239436, @Dzahn wrote: > Well, if you **haven't tested**, then please don't claim it w... [16:59:30] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3239476 (10greg) It's not hard at all: it logs success/failure in the SAL after each run. [17:02:38] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3239492 (10Kghbln) >>! In T158360#3239476, @greg wrote: > It's not hard at all: it logs success/failure in the SAL after each run. It takes two weeks to check the log... [17:05:57] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3239494 (10greg) Exactly my point: the information is there for those who care to see it. Because we've had multiple occasions where it was multiple weeks for people t... [17:18:45] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3239587 (10Kghbln) >>! In T158360#3239494, @greg wrote: > Exactly my point: the information is there for those who care to see it. Because we've had multiple occasions... [17:26:22] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3239616 (10greg) >>! In T158360#3239587, @Kghbln wrote: >>>! In T158360#3239494, @greg wrote: >> Exactly my point: the information is there for those who care to see i... [17:27:55] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3239618 (10Reedy) Surely it has some purview of the language team to make sure things are running correctly? I'm not saying they should necessarily be the ones to fix... [17:30:03] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3239631 (10Reedy) >>! In T158360#3239587, @Kghbln wrote: > How can they be supported to get their translations? I guess this is what task is all about. And no one has... [17:30:07] 10Gerrit, 10Analytics-Tech-community-metrics: Numerous Gerrit (draft) patchsets cannot be accessed: "Cannot display change because it has no revisions." - https://phabricator.wikimedia.org/T161207#3239632 (10Aklapper) @Paladox: What is "it"? Which "logs"? And what's the underlying reason to ask that question?... [17:44:48] 06Release-Engineering-Team, 06Operations, 10Phabricator: Phabricator: Make sure phabricator works properly including our puppet roles on jessie - https://phabricator.wikimedia.org/T158434#3239693 (10mmodell) I still don't think it works 100% without a little manual intervention. It's damn close though. [17:58:51] 10Gerrit, 10Analytics-Tech-community-metrics: Numerous Gerrit (draft) patchsets cannot be accessed: "Cannot display change because it has no revisions." - https://phabricator.wikimedia.org/T161207#3239744 (10Paladox) >>! In T161207#3239632, @Aklapper wrote: > @Paladox: What is "it"? Which "logs"? And what's th... [18:33:26] PROBLEM - Puppet errors on deployment-aqs01 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [18:35:23] PROBLEM - Puppet errors on deployment-restbase02 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [18:36:03] PROBLEM - Puppet errors on deployment-eventlogging04 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [18:43:36] 10Gerrit, 10Analytics-Tech-community-metrics: Numerous Gerrit (draft) patchsets cannot be accessed: "Cannot display change because it has no revisions." - https://phabricator.wikimedia.org/T161207#3239846 (10Aklapper) I have no idea how checking whether an issue gets logged or not would actually bring us close... [18:43:42] Project beta-scap-eqiad build #154039: 04FAILURE in 0.4 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/154039/ [18:44:36] oh good. ^ this is me "fixing" stuff [18:52:31] RECOVERY - Puppet errors on deployment-tin is OK: OK: Less than 1.00% above the threshold [0.0] [18:53:44] Project beta-scap-eqiad build #154040: 04STILL FAILING in 0.42 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/154040/ [18:54:50] should work next go 'round, hopefully [19:08:00] Yippee, build fixed! [19:08:01] Project beta-scap-eqiad build #154041: 09FIXED in 4 min 9 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/154041/ [19:10:25] RECOVERY - Puppet errors on deployment-restbase02 is OK: OK: Less than 1.00% above the threshold [0.0] [19:11:03] RECOVERY - Puppet errors on deployment-eventlogging04 is OK: OK: Less than 1.00% above the threshold [0.0] [19:13:27] RECOVERY - Puppet errors on deployment-aqs01 is OK: OK: Less than 1.00% above the threshold [0.0] [19:36:54] (03CR) 10Hashar: "I have proposed a patch that would make mw-testextension-* jobs to run composer automatically when the extension has a composer file :] h" [integration/config] - 10https://gerrit.wikimedia.org/r/351912 (owner: 10Umherirrender) [20:11:46] !log Mass pushing addition of jakub-onderka/php-console-highlighter to all mediawiki extensions having php-parallel-lint ( example: https://gerrit.wikimedia.org/r/#/c/352215/ ) [20:11:49] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:20:04] paladox: the changes adding jakub-onderka/php-console-highlighter [20:20:10] paladox: I am going to mass push them :] [20:20:20] Oh, should i removed my +2? [20:20:22] hashar ^^ [20:20:23] just waiting for https://gerrit.wikimedia.org/r/#/q/topic:php-console-highlighter+(status:open+OR+status:merged) [20:20:29] to be filled with +2 from jenkins :] [20:20:31] na it is ok [20:20:34] ok :) [20:20:40] paladox: just dont +2 the others hehe [20:20:46] lol ok [20:33:57] Project beta-scap-eqiad build #154051: 04FAILURE in 0.42 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/154051/ [20:40:27] 10Deployment-Systems, 10ArchCom-RfC, 07I18n: RFC: Reevaluate LocalisationUpdate extension for WMF - https://phabricator.wikimedia.org/T158360#3240078 (10Pikne) >>! In T158360#3239494, @greg wrote: > Exactly my point: the information is there for those who care to see it. Because we've had multiple occasions... [20:41:04] Bah, gotta manually pull that to beta, cuz new scap is busted [20:41:08] Without it [20:42:38] oh, just un-cherry-picked a hack that fixed that because I saw it merge :P [20:43:03] Oh [20:43:05] Hm [20:43:11] Plus running scap as me fails [20:43:42] probably that flappy host key thing [20:43:52] Nah, permissions on files [20:44:02] Project beta-scap-eqiad build #154052: 04STILL FAILING in 0.51 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/154052/ [20:44:06] Oh shut up [20:45:19] paladox: all merged https://gerrit.wikimedia.org/r/#/q/topic:php-console-highlighter+(status:open+OR+status:merged) :] [20:45:26] :) [20:45:43] RainbowSprinkles: just occurred to me that this probably won't work for beta since it doesn't run scap sync from /srv/mediawiki-staging [20:45:45] nice https://integration.wikimedia.org/ci/job/mwgate-composer-hhvm-jessie/1935/console [20:46:00] shows colour now [20:46:01] :) [20:46:19] thcipriani: Why wouldn't it work? [20:46:28] Wait...we use cwd() to get scap/scap.cfg? [20:46:53] it looks for the scap directory in the current working directory [20:47:11] Bleh, scap3 assumes cwd == deployment directory [20:47:14] That keeps biting us [20:47:27] Er, rather the fact that scap2 doesn't assume that [20:47:37] We should enforce it. [20:49:27] in the interim, I'll re-cherry pick the puppet change [20:50:17] I'm almost done with my scap [20:51:48] this'll probably pop up again for l10nupdate :\ [20:52:21] Hmm. Maybe needs better fallback behavior? I assumed git_repo would be accessible everywhere. [20:52:32] scap2 thinks it's the only scap and scap3 is confused. [20:52:59] Scap3? I don't know her. [20:53:13] it's a safe assumption that if git_repo is not set it's a scap2 deploy otherwise it would fail before it tries to lock anything [20:53:59] Project beta-scap-eqiad build #154053: 04STILL FAILING in 0.4 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/154053/ [20:54:01] So I guess correct fix is a kludgy hack to avoid the key access. Until we get MW to the "assume cwd is deploy dir" [20:54:14] That's a harder fix [20:56:54] the beta-scap-eqiad should fix itself next time, cherry-pick on puppetmaster for the time being [20:57:25] Patch incoming to scap [20:57:59] overloading the meaning of config['git_repo'] seems like it may cause problems, going back to config['lock_file'] would mean that if a repo didn't define their own lockfile they could lock scap2 deploys [20:58:38] I went with git_repo because it was something I assumed would be unique per project [20:58:46] And I want to avoid *having* to define lock_file everywhere [20:58:51] https://phabricator.wikimedia.org/D634 [21:00:32] /var/lock/scap.unknown-but-probably-mediawiki.lock [21:00:34] Hehe :p [21:00:57] oh I saw :) [21:13:27] Yippee, build fixed! [21:13:28] Project beta-scap-eqiad build #154054: 09FIXED in 9 min 32 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/154054/ [21:16:02] 10Gerrit, 10Analytics-Tech-community-metrics: Numerous Gerrit (draft) patchsets cannot be accessed: "Cannot display change because it has no revisions." - https://phabricator.wikimedia.org/T161207#3240119 (10hashar) The Gerrit drafts seems to be working all fine now. In T157898#3124564 @Albertinisg mentioned... [21:21:27] 10Browser-Tests-Infrastructure, 07JavaScript, 15User-zeljkofilipin: WebdriverIO CREDIT showcase - https://phabricator.wikimedia.org/T164070#3220651 (10hashar) Well done @zeljkofilipin ! [21:34:56] 10Deployment-Systems, 10Scap, 06Operations: setup automatic deletion of old l10nupdate - https://phabricator.wikimedia.org/T130317#3240155 (10demon) 05Open>03Resolved a:03demon This is fixed via T119747 (a dupe really) [22:18:34] (03PS1) 10MaxSem: Test JsonConfig with Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/352279 [22:20:42] (03PS2) 10MaxSem: Test JsonConfig with Kartographer [integration/config] - 10https://gerrit.wikimedia.org/r/352279 [22:21:10] Project selenium-CentralAuth » firefox,beta,Linux,BrowserTests build #386: 04FAILURE in 1 min 10 sec: https://integration.wikimedia.org/ci/job/selenium-CentralAuth/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/386/ [22:36:40] (03CR) 10Hashar: "I would rather do it the other way around." [integration/config] - 10https://gerrit.wikimedia.org/r/352279 (owner: 10MaxSem) [22:39:15] (03CR) 10MaxSem: "That is being discussed at T163274, however there are still existing security-sensitive areas that need tests, and they can't be tested wi" [integration/config] - 10https://gerrit.wikimedia.org/r/352279 (owner: 10MaxSem) [22:56:50] Yippee, build fixed! [22:56:51] Project mediawiki-core-code-coverage build #2742: 09FIXED in 2 hr 23 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/2742/