[00:14:24] Did CI move back to the broken HHVM run? [00:14:43] https://gerrit.wikimedia.org/r/#/c/353033/ just failed a recheck with [hphp] [1994:7f60f65316c0:0:000002] [] Lost parent, LightProcess exiting [00:16:09] Don't think so [00:16:36] Odd. [00:16:53] 00:00:03 HipHop VM 3.12.14 (rel) [00:16:53] 00:00:03 Compiler: 3.12.14+dfsg-1+wmf1 [00:16:54] Nope [00:17:06] Yeah, even more odd. [00:17:11] I think we get those lost parents now and again [00:19:58] There's a few fatals on that patch anyway... And a composer issue too [00:28:34] Yeah, I'll ignore it for now. [00:28:54] I just rechecked and merged the other 5 Wikibase-related changes that were stick in C+2V-1. [00:28:58] Err. Stuck. [00:29:19] Living in American is clearly infecting me with the inability to conjugate correctly. [00:31:58] Reedy: Also should T165093 be a blocker to further HHVM stuff? [00:31:58] T165093: Attempted to serialize unserializable builtin class Closure - https://phabricator.wikimedia.org/T165093 [00:52:13] 06Release-Engineering-Team, 10Phabricator, 06Project-Admins, 05Release: Decide whether to continue using deployment blocker tasks or combine them with the release milestones - https://phabricator.wikimedia.org/T164978#3257392 (10mmodell) In order to automate the creation of a series of blocker tasks I need... [00:57:31] PROBLEM - Puppet staleness on deployment-logstash2 is CRITICAL: CRITICAL: 10.00% of data above the critical threshold [43200.0] [00:59:30] 10Scap (Scap3-Adoption-Phase1): Make scap3 config deployment awesome - https://phabricator.wikimedia.org/T138452#3257421 (10mmodell) p:05High>03Normal [01:00:51] 05Gerrit-Migration, 10Differential, 10Phabricator, 10Wikibugs, 07WorkType-NewFunctionality: Create conduit method to query the feed and return records with relevant details populated instead of just a bunch of phids - https://phabricator.wikimedia.org/T123417#3257424 (10mmodell) [01:01:06] 05Gerrit-Migration, 10Differential, 10Phabricator, 10Wikibugs, 07WorkType-NewFunctionality: Create conduit method to query the feed and return records with relevant details populated instead of just a bunch of phids - https://phabricator.wikimedia.org/T123417#1929298 (10mmodell) 05Open>03stalled [01:01:11] 05Gerrit-Migration, 10Differential, 10Phabricator: Phabricator does not provide an API to get Differential transaction data, similar to maniphest.gettasktransactions - https://phabricator.wikimedia.org/T123416#3257428 (10mmodell) [01:02:26] RECOVERY - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is OK: OK: Less than 100.00% above the threshold [0.0] [06:26:50] Project selenium-Wikibase » chrome,test,Linux,BrowserTests build #358: 04FAILURE in 1 hr 46 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=test,PLATFORM=Linux,label=BrowserTests/358/ [06:41:12] 10Browser-Tests-Infrastructure, 07Documentation, 07Easy, 07Software-Licensing, 15User-zeljkofilipin: Ruby gem documentation should state license - https://phabricator.wikimedia.org/T94001#3257617 (10Rammanojpotla) I think the LICENSE file had to be kept in Rubygems directory in the docs page because when... [06:50:25] Yippee, build fixed! [06:50:26] Project selenium-Wikibase » chrome,beta,Linux,BrowserTests build #358: 09FIXED in 2 hr 10 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/358/ [06:55:39] 10Beta-Cluster-Infrastructure, 06Operations: Mails through deployment-mx SPF & DKIM fails - https://phabricator.wikimedia.org/T87338#3257661 (10Nemo_bis) Is this still current? [08:56:35] James_F: I don't think so. It doesn't seem to affect anything, but the fact it was a warning that came up every time on default vagrant install suggested it wwas worth filing to look at later [09:09:00] Reedy: [09:09:05] i need an emergency swat :/ [09:09:12] section collapsing is broken across all mobile pages [09:09:13] What's up? [09:09:46] lemme get you the right tickets [09:09:57] https://phabricator.wikimedia.org/T164733 [09:10:44] So this was reported on Monday and the patch that introduced it was supposed to be reverted from wmf01 by anomie [09:10:51] but it looks like it hasnt [09:11:20] So it looks like i have no other choice but to swat https://gerrit.wikimedia.org/r/352737 since the caches are all messed up [09:12:12] I don't see a sign of a revert [09:12:12] https://github.com/wikimedia/mediawiki/commits/wmf/1.30.0-wmf.1 [09:12:21] there was an offlist thread - ill forward it to you [09:12:34] but anomie didnt want to revert it [09:12:58] TimStarling: are you around? [09:13:43] It's probably around his kids bedtime at this point [09:14:06] and im guessing greg-g is asleep :) [09:14:08] well i hope he is [09:14:44] this is pretty bad [09:15:32] If stuff is pretty broken, it's fine to deploy to fix stuff [09:15:38] Reedy: jdlrobson: I am around if needed [09:15:52] Reedy: hashar im not sure what the best fix is here [09:16:01] we need a cache purge [09:16:03] One that's tested and fixes the issue? :P [09:16:07] or to leave all mobile pages broken [09:16:09] that is on the mobile web en.m.wiki ? [09:16:17] Do Ops still purge all the mobile cache? [09:16:17] yup [09:16:19] and the apps as well? [09:16:21] not possible to edit [09:16:23] I don't think I've seen them do that recently [09:16:25] not possible to collapse sections [09:16:46] So https://gerrit.wikimedia.org/r/352737 or https://gerrit.wikimedia.org/r/#/c/352577/ will fix it [09:16:59] but then we have to deal with cached HTML [09:17:17] As long as ops are happy doing the cache purges [09:17:49] ill have to explore that separately [09:18:02] I've just asked in another channel [09:18:44] im guessing https://gerrit.wikimedia.org/r/#/c/352737/ is the way forward as i have no idea about the change that introduced the problem and that might have side effects im not aware of [09:19:06] there is a patch for mobilefrontend isn't there? [09:19:11] yeah that one [09:19:19] makes me a little nervous though as i was hoping for some testing on hebrew wiki time [09:19:54] well it is on beta already [09:20:03] and maybe aharoni can help on that front [09:20:28] hashar: can you confirm is https://gerrit.wikimedia.org/r/#/c/350634/in production? [09:20:29] https://he.m.wikipedia.beta.wmflabs.org/wiki/%D7%A2%D7%9E%D7%95%D7%93_%D7%A8%D7%90%D7%A9%D7%99 ? [09:20:50] hashar: not quite what i meant. can jump into hangout and chat if that's easier? [09:21:23] https://gerrit.wikimedia.org/r/#/c/350634/ is in wmf 1.30 branch so it is most probably in prod [09:21:28] yeah we can hang outs if you want [09:21:38] Reedy: wanna join? [09:21:40] yep so that's the problem [09:21:54] I'm currently in bed... xD [09:22:05] ;D [09:22:13] https://hangouts.google.com/hangouts/_/wikimedia.org/londonbridgeisfallingdown?authuser=0 [09:22:16] if anyone wants to join [09:23:18] fwiw, I don't mind deploying something if you decide what to deploy [09:24:32] (03CR) 10Reedy: [C: 032] Branch LoginNotify [tools/release] - 10https://gerrit.wikimedia.org/r/353348 (owner: 10Reedy) [09:26:08] (03Merged) 10jenkins-bot: Branch LoginNotify [tools/release] - 10https://gerrit.wikimedia.org/r/353348 (owner: 10Reedy) [09:33:40] Reedy: I am going to cherry pick / deploy the mobilefrontend hot fix [09:40:29] ema: good morning! do we have an easy way to purge/ban the HTML cache ? [09:40:53] mediawiki/core changed its HTML output which caused issue on MobileFrontend [09:41:00] and we gotta invalidate the faulty cache [09:54:53] hashar: not particularly easy but we can do that yeah [09:54:58] I'm currently in bed... xD hashar: what needs to be purged? Any specific header/URL we can filter on? [09:55:52] ema: not sure yet. jdlrobson and I are deploying a hotfix right now [10:02:13] ema: hey. I'm thinking we might be able to get away with not doing a cache purge [10:02:31] p858snake: we have a pants rule for meetings... [10:03:22] jdlrobson: ok :) [10:03:37] ema: i'm going to ask James_F [10:03:37] Reedy: Duvet, or depending on where you have your laptop positioned [10:03:49] since the main problem is editing is unavailable on mobile web for anonymous users [10:04:00] but i think the time to live for cached HTML is up to 7 days? [10:07:55] jdlrobson: it depends on a bunch of things but we've lowered the ttl cap to 1d recently [10:18:11] ema: in that case we're probably fine :) [10:18:16] \O/ [10:24:16] hashar: o/ - whenever you are not in emergency mode let me know, the jobrunner patch is deployed in deployment-prep but no changes in TIME-WAITs :( [10:29:00] elukey: :( [10:30:17] hashar: I am wondering if that setting is picked up or not [10:31:43] jdlrobson: note however that the ttl cap applies to a single varnish instance so to say, it's not global (and we have multiple varnish layers) [10:32:52] so basically 1d isn't the maximum lifetime of an object overall, but rather on a specific varnish layer [10:38:49] elukey: maybe the defined constant is not defined ... :( [10:39:35] at least the patch is on deployment-jobrunner02 and the jobqueue-labs.php has 'persistent' => defined( 'MEDIAWIKI_JOB_RUNNER' ), [10:40:09] hashar: might be but it would be strange no? [10:40:17] note that is solely for the /rpc/runJobs.php entry point [10:40:22] not for the actuall jobrunner service [10:45:14] hashar: ah interesting! [10:45:26] this might explain why [10:45:55] PROBLEM - Puppet errors on deployment-imagescaler01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [10:46:26] elukey: and I think the mediawiki/services/jobrunner config file is handled in puppet [10:48:52] it does not seem to have support for persistent connections though :D [10:49:05] I gotta prepare lunch / eat etc [10:51:42] okok :) [10:59:32] PROBLEM - Puppet errors on deployment-pdf01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [11:30:14] hashar: now I got what you were saying, basically https://github.com/wikimedia/mediawiki-services-jobrunner/blob/master/src/RedisJobService.php#L252 has no notion of persistent connection [11:30:32] yup [11:30:35] too many moving parts :] [11:32:02] elukey: regardless, the connection errors come from the rpc [11:33:50] hashar: does the rpc get called by the jobrunner daemon or by mw hosts? [11:34:01] jobrunner daemon [11:35:38] ok so IIUC the change that I've made should reflect on the mediawiki hosts submitting events to Redis [11:35:58] possibly yes [11:36:32] but really I think we should push that persistent config to prod [11:36:40] maybe on a single host / wiki [11:36:50] then roll it to rest of fleet progressively [11:37:14] yes but we'd need to figure out what we are targeting [11:37:22] the majority of the connect timeouts are for jobrunners [11:38:01] so if this change indeed targets mw hosts we'd need to make sure that on redis and mw hosts the number of established conns are lower [11:38:11] otherwise it is not working as expected [11:39:54] then you get a graph of tcp socket states dont you ? [11:41:08] I am poking the prometheus labs interface :) [11:42:44] there is also https://phabricator.wikimedia.org/T158770 Bad file descriptor in RedisConnectionPool.php [11:43:04] which is probably closely related [11:44:46] hashar: http://beta-prometheus.wmflabs.org/beta/graph?g0.range_input=1w&g0.expr=node_sockstat_sockets_used%7Binstance%3D%22deployment-mediawiki04%3A9100%22%2Cjob%3D%22node%22%7D&g0.tab=0 [11:45:04] the main issue is that the deployment went out yesterday, not on the 10th [11:48:19] weird [11:51:43] bah [11:55:20] elukey: there is a nutcracker change on that host at 13:41 [11:55:28] -DAEMON_OPTS="--stats-addr=127.0.0.1 --verbose=4 --mbuf-size=65536" [11:55:31] +DAEMON_OPTS="--verbose=4 --mbuf-size=65536" [11:55:36] but that is just for stats apparently [11:57:23] the the baseline before April 27 was at 180 connections [11:57:28] so yeah hmm. who knows really :] [11:58:45] hashar: I added https://phabricator.wikimedia.org/T125735#3258338, let me know if it makes sense [12:03:53] elukey: I dont quite understand prometheus :D [12:04:09] can you link / or copy pste the graphs for the three instances ? [12:07:23] sure! [12:07:36] but it is quite easy [12:08:00] your largely over estimate my capacity to catch up with a new web interface :D [12:08:42] you add the string that you need (like node_tcp_connection_states{instance="deployment-redis01:9100",job="node",state="established"}) in the main bar, then click "Execute" [12:08:46] and then graph [12:08:48] that's it [12:08:49] :) [12:11:15] ah ok [12:11:25] then the thing is that beta has not so many jobs [12:11:27] just updated it [12:11:32] so that is probably not changing anything [12:11:45] neat graphs. thx! [12:13:23] ah snap now I realized one thing [12:13:56] 'persistent' => defined( 'MEDIAWIKI_JOB_RUNNER' ) prevents persistent conns on mw host [12:14:00] /o\ [12:14:52] gah? [12:16:59] I am live hacking mediawiki05 [12:20:24] hashar: http://beta-prometheus.wmflabs.org/beta/graph?g0.range_input=1h&g0.expr=node_tcp_connection_states%7Binstance%3D%22deployment-mediawiki05%3A9100%22%2Cjob%3D%22node%22%2Cstate%3D%22time_wait%22%7D&g0.tab=0 [12:20:59] ah no it went back up, nevermind [12:25:34] \o/ [12:25:47] so the persistent settings work doesn't it ? :] [12:27:20] nope.. [12:27:55] hashar: btw, did you see https://phabricator.wikimedia.org/T165075 ? [12:28:14] Reedy: mutante filled a task about it iirc [12:28:41] yup, i'll dupe mine [12:28:43] Reedy: dupe fo https://phabricator.wikimedia.org/T164543 [12:29:09] I checked that out last week with moritz [12:29:14] the few low hanging fruits are solved [12:29:32] there some other remaining actions, but that depends on upstream code :/ [13:12:05] !log Trying to refresh Nodepool Jessie image. Should get HHVM pinned to 'experimental' component => 3.12.x [13:12:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:24:41] PROBLEM - Puppet errors on integration-slave-trusty-1006 is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [13:38:32] (03PS1) 10Umherirrender: Use composer unittests for BlueSpice extensions [integration/config] - 10https://gerrit.wikimedia.org/r/353541 [13:38:52] PROBLEM - Puppet errors on integration-slave-trusty-1004 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [13:40:11] PROBLEM - Puppet errors on integration-slave-trusty-1001 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [13:44:51] PROBLEM - Puppet errors on integration-slave-trusty-1003 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [13:45:16] Project selenium-VisualEditor » firefox,beta,Linux,BrowserTests build #395: 04FAILURE in 1 min 16 sec: https://integration.wikimedia.org/ci/job/selenium-VisualEditor/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/395/ [14:04:20] 10Continuous-Integration-Infrastructure, 06Operations, 10Wikidata, 07HHVM, and 2 others: CI tests failing with segfault - https://phabricator.wikimedia.org/T165074#3258616 (10hashar) 05Open>03Resolved @MoritzMuehlenhoff has pushed HHVM 3.12 to 'experimental' and I wrote a few rules to pin that version.... [14:17:56] shopping time [14:57:30] Reedy they traced it back to https://github.com/facebook/hhvm/commit/9d2be6c30b5b6dadf414692d0e7fbab5f9105b5f#diff-c554635b4553d87db39c55e401ac3153L92 :) a one liner broke it. [15:03:29] 10Continuous-Integration-Config, 10MobileFrontend, 06Reading-Web-Backlog, 03Reading-Web-Kanban-Board: Migrate experimental CI job mwext-MobileFrontend-npm-run-lint-modules to stable - https://phabricator.wikimedia.org/T163882#3213309 (10Jdlrobson) ^ See email: Friday sprint review [15:21:15] 10Gerrit, 10Developer-Wishlist (2017), 07Documentation, 07Upstream: Enable and document "WIP" workflow status in Gerrit - https://phabricator.wikimedia.org/T135245#3258795 (10Paladox) Proposing to decline this task as upstream support wip now which can be tested at http://gerrit-new.wmflabs.org/ will be in... [17:05:45] PROBLEM - Puppet errors on swift is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:07:18] PROBLEM - Puppet errors on swift-storage-01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:08:57] (03PS1) 10Umherirrender: Add npm jobs [integration/config] - 10https://gerrit.wikimedia.org/r/353583 [17:11:00] PROBLEM - Puppet errors on buildlog is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:14:13] jdlrobson: if I deploy https://gerrit.wikimedia.org/r/#/c/353584/ will I also need to revert https://gerrit.wikimedia.org/r/#/c/353514/ ? [17:18:31] jdlrobson: going ahead with https://gerrit.wikimedia.org/r/#/c/353584/ your change looks compatible [18:30:10] 10Continuous-Integration-Infrastructure (Little Steps Sprint), 13Patch-For-Review: For MediaWiki extensions, merge composer test into mwext-textextension / mediawiki-extensions jobs - https://phabricator.wikimedia.org/T161895#3259325 (10Umherirrender) 05Open>03Resolved [20:09:16] (03PS1) 10Legoktm: Expand list of standard methods that don't need documentation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353602 (https://phabricator.wikimedia.org/T164657) [20:29:38] (03PS1) 10Legoktm: Don't require documentation for constructors without parameters [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353618 (https://phabricator.wikimedia.org/T164657) [20:49:15] (03PS1) 10Legoktm: Don't require return/throws/param for doc blocks with @inheritDoc [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353623 (https://phabricator.wikimedia.org/T164649) [20:52:07] 10MediaWiki-Codesniffer, 13Patch-For-Review: Ignore blocks with @inheritDoc - https://phabricator.wikimedia.org/T164649#3259708 (10Legoktm) >>! In T164649#3241041, @Anomie wrote: > Also consider whether requiring `/** @inheritDoc */` is even necessary on inherited methods. I read through https://www.phpdoc.or... [20:52:22] 10MediaWiki-Codesniffer, 13Patch-For-Review: Don't require documentation for standard methods - https://phabricator.wikimedia.org/T164657#3259709 (10Legoktm) a:03Legoktm [20:52:28] 10MediaWiki-Codesniffer, 13Patch-For-Review: Ignore blocks with @inheritDoc - https://phabricator.wikimedia.org/T164649#3259710 (10Legoktm) a:03Legoktm [21:00:51] (03PS1) 10Legoktm: Use upstream CharacterBeforePHPOpeningTag sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353653 [21:06:19] (03PS1) 10Legoktm: Make sure all files end with a newline [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353666 [21:07:15] 10MediaWiki-Codesniffer: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS - https://phabricator.wikimedia.org/T164653#3259759 (10Legoktm) [14:00:46] (PS1) Legoktm: Use upstream CharacterBeforePHPOpeningTag sniff [tools/codesniffer] - https://gerrit.wikimedia.org/r/... [21:08:12] (03PS2) 10Legoktm: Don't require documentation for constructors without parameters [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353618 (https://phabricator.wikimedia.org/T164657) [21:08:14] (03PS2) 10Legoktm: Don't require return/throws/param for doc blocks with @inheritDoc [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353623 (https://phabricator.wikimedia.org/T164649) [21:08:16] (03PS2) 10Legoktm: Use upstream CharacterBeforePHPOpeningTag sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353653 [21:08:18] (03PS2) 10Legoktm: Make sure all files end with a newline [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353666 [21:09:00] 10MediaWiki-Codesniffer, 13Patch-For-Review: Should we require documentation for constructors? - https://phabricator.wikimedia.org/T146388#2659448 (10Legoktm) a:03Legoktm [21:17:11] (03CR) 10Chad: [C: 032] Expand list of standard methods that don't need documentation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353602 (https://phabricator.wikimedia.org/T164657) (owner: 10Legoktm) [21:17:49] (03Merged) 10jenkins-bot: Expand list of standard methods that don't need documentation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353602 (https://phabricator.wikimedia.org/T164657) (owner: 10Legoktm) [21:18:16] (03CR) 10Chad: [C: 032] Don't require documentation for constructors without parameters [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353618 (https://phabricator.wikimedia.org/T164657) (owner: 10Legoktm) [21:18:47] (03Merged) 10jenkins-bot: Don't require documentation for constructors without parameters [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353618 (https://phabricator.wikimedia.org/T164657) (owner: 10Legoktm) [21:19:39] (03PS3) 10Chad: Make sure all files end with a newline [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353666 (owner: 10Legoktm) [21:21:34] (03CR) 10Chad: [C: 032] Make sure all files end with a newline [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353666 (owner: 10Legoktm) [21:22:55] (03Merged) 10jenkins-bot: Make sure all files end with a newline [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353666 (owner: 10Legoktm) [21:23:14] (03PS3) 10Chad: Use upstream CharacterBeforePHPOpeningTag sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353653 (owner: 10Legoktm) [21:24:07] (03CR) 10Chad: [C: 032] Use upstream CharacterBeforePHPOpeningTag sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353653 (owner: 10Legoktm) [21:27:15] (03Merged) 10jenkins-bot: Use upstream CharacterBeforePHPOpeningTag sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353653 (owner: 10Legoktm) [21:28:23] RainbowSprinkles apparently offline reindexing is now considered unsafe. [21:28:42] 10Gerrit, 06Operations, 13Patch-For-Review: Investigate seemingly random Gerrit slow-downs - https://phabricator.wikimedia.org/T148478#3259797 (10demon) 05Open>03Resolved a:03demon This hasn't been a problem since I readjusted internal caches (less churn) and we lowered the heap (don't need it so high)... [21:28:51] Great. [21:28:56] Thanks upstream They are also finally implementating a ui for blocking users :). [21:32:49] 10Gerrit, 06Repository-Admins, 10Wikidata: Deactivate/archive WikibaseQueryEngine - https://phabricator.wikimedia.org/T141858#3259808 (10demon) [21:33:12] RainbowSprinkles i like the fact that you make a change private, merge it but carn't open it. [21:33:46] open it as in make it public [21:37:35] 10Gerrit, 06Repository-Admins, 10Wikidata: Deactivate/archive WikibaseQueryEngine - https://phabricator.wikimedia.org/T141858#3259826 (10demon) @Lydia_Pintscher Is there anything left to be done here on WMDE's Github? If not, let's close this. [21:38:28] RainbowSprinkles can we close this https://phabricator.wikimedia.org/T135245 as decline? [21:40:13] 10Gerrit, 10Developer-Wishlist (2017), 07Documentation, 07Upstream: Enable and document "WIP" workflow status in Gerrit - https://phabricator.wikimedia.org/T135245#3259833 (10demon) 05Open>03declined Declining because upstream is already working on this. [21:41:16] Thanks RainbowSrinkl*es:) [21:43:15] i know next week theres no swat due to releng is running off to do outside things, but it resumes to normal the next week correct... [21:44:27] swat is continuing, just no train [21:45:09] oh my bad i misread the message [21:45:33] 10Gerrit, 13Patch-For-Review: Gerrit: Covert Velocity templates to Closure Templates - https://phabricator.wikimedia.org/T158008#3259869 (10demon) We should knock out the ITS templates so we can resolve this. [21:48:03] 10Gerrit, 13Patch-For-Review: Gerrit: Covert Velocity templates to Closure Templates - https://phabricator.wikimedia.org/T158008#3259874 (10Paladox) Yep, the its-base ones will have to stay as its-base doesn't support closure yet. I've been testing gerrit 2.14 for about 1+ weeks now. I will tested removing th... [21:59:14] RainbowSprinkles the closure template works [21:59:20] I get this in an email [21:59:47] https://phabricator.wikimedia.org/P5440 [22:00:35] Note it is html format now [22:01:43] Since core gerrit swapped closure -> velocity...did they drop velocity from the dependencies list? [22:02:08] Ie: do we need to continue bundling it in ITS or move forward with closure there? [22:02:19] (er, backwards on the swap, but otherwise same ?) [22:02:35] RainbowSprinkles they haven't drop support for vm yet [22:02:47] Ok good, so we're not in a rush to fix it in ITS [22:02:47] its-base still needs vm as it does not yet support closure. [22:02:50] Nope [22:03:17] Though they plan to remove it in the next release. I hope i can get them to fix its-base first before removing it from core :) [22:03:27] They are planning a majour version bump - 3.0 [22:04:20] RainbowSprinkles i've tested its-phabricator from stable-2.14 and it works :). No breakages. Though it does have one change in the conduit call i did. Replaced a deprecated call. [22:07:19] there's been so many bug fixes for the 2.14.1 release. RainbowSprinkles theres been 51 changes since 2.14.0 was release lol [22:07:20] https://github.com/GerritCodeReview/gerrit/compare/v2.14...stable-2.14 [22:07:36] Seeeeeeeeee, this is why you never ever use the first release of anything! [22:07:44] Yep [22:08:00] I fixed an ldap bug too in polygerrit :). You can now set your status. [22:08:29] No amount of testing can replace having your software get real world usage from third parties :) [22:08:39] Which is why .0 releases of *anything* are scary [22:09:06] Yep [22:09:37] PolyGerrit is better at handling broken rest api calls then gwtui [22:09:58] polygerrit can brake sometimes like gwtui but sometimes it can just ignore parts and lets the other parts works :) [22:11:23] RainbowSprinkles When i added the new ssh keys support, i forgot to do these changes which are now in gerrit 2.14.1 https://github.com/GerritCodeReview/gerrit/commit/c3319bf15ef02ce5f0a0aef41af90bb38f3bfaf1 and https://github.com/GerritCodeReview/gerrit/commit/acf39dacf53f4cd483efd8979eacf2c1bc251153 and https://github.com/GerritCodeReview/gerrit/commit/99550098d4ad3125c527597894272bee027e04c4 [22:11:47] also gave me time to clean it up too :). So ssh-rsa keys can now be regenerated even if ssh-dsa existed. [22:12:12] Ah, acf39da and 9955009 looks necessary :) [22:12:23] c3319bf not so much, since we have an existing host key already [22:12:31] (and swapping it causes people pain :)) [22:12:48] Oh [22:12:57] Dosen't it generate the keys under etc/? [22:13:05] for the c3319bf change. [22:19:18] RainbowSprinkles we may one day be able to customise our favicon. https://gerrit-review.googlesource.com/#/c/106476/ brings us one step closer :) [22:20:02] It doesn't regenerate them if we have them already 😊 [22:20:45] oh [22:21:30] We could possibly generate a new key though, just needs to be properly announced cuz people will get confused [22:22:17] yep [22:22:21] gerrit init will generate one though [22:22:30] so it will use rsa, dsa and the new keys :) [22:22:37] It only uses one for the host key [22:22:43] Or, only should :) [22:58:25] 10Gerrit, 06Release-Engineering-Team, 10Phabricator, 07Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3259948 (10Framawiki) @Paladox I don't know if your patch already does it, but Phab now allows bots to add a... [22:58:48] 10Gerrit, 06Release-Engineering-Team, 10Phabricator, 07Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3259950 (10Framawiki) a:03Paladox [22:59:51] 10Gerrit, 06Release-Engineering-Team, 10Phabricator, 07Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3259952 (10Paladox) Oh i thought it will send two notifications even if we did it the once? And nope i wasn... [23:01:17] 10Gerrit, 06Release-Engineering-Team, 10Phabricator, 07Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3259958 (10Paladox) What api do i use for this? Does this use the new maniphest.edit api? (i may have got th... [23:06:54] (03CR) 10Krinkle: [C: 031] Don't require return/throws/param for doc blocks with @inheritDoc [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/353623 (https://phabricator.wikimedia.org/T164649) (owner: 10Legoktm)