[00:11:07] 10Continuous-Integration-Infrastructure, 10Operations, 10Patch-For-Review: CI for operations/puppet is taking too long - https://phabricator.wikimedia.org/T166888#3310890 (10thcipriani) >>! In T166888#3322963, @faidon wrote: > These are all conjectures of mine, just by looking at the log, so correct me when... [02:42:24] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: "Unhandled Exception ("Exception"): Rejecting ambiguous URI" when trying to access certain tasks / conpherence rooms / etc - https://phabricator.wikimedia.org/T166870#3331075 (10mmodell) 05Open>03Resolved a:03mmodell [02:43:42] Project beta-scap-eqiad build #158788: 04FAILURE in 0.36 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/158788/ [02:44:16] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: "Unhandled Exception ("Exception"): Rejecting ambiguous URI" when trying to access certain tasks / conpherence rooms / etc - https://phabricator.wikimedia.org/T166870#3331081 (10mmodell) [02:55:42] Yippee, build fixed! [02:55:42] Project beta-scap-eqiad build #158789: 09FIXED in 2 min 0 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/158789/ [04:08:31] Yippee, build fixed! [04:08:31] Project selenium-MultimediaViewer » safari,beta,OS X 10.9,BrowserTests build #416: 09FIXED in 12 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=safari,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=OS%20X%2010.9,label=BrowserTests/416/ [04:23:11] PROBLEM - Free space - all mounts on integration-slave-jessie-1002 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1002.diskspace._mnt.byte_percentfree (No valid datapoints found)integration.integration-slave-jessie-1002.diskspace.root.byte_percentfree (<11.11%) [04:25:24] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: MW-1.30.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T166829#3331189 (10mmodell) [05:47:16] Project beta-scap-eqiad build #158807: 04FAILURE in 1 min 39 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/158807/ [05:54:15] Yippee, build fixed! [05:54:16] Project beta-scap-eqiad build #158808: 09FIXED in 2 min 1 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/158808/ [05:56:33] Project beta-scap-eqiad build #158809: 04FAILURE in 1 min 36 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/158809/ [06:05:47] Yippee, build fixed! [06:05:47] Project beta-scap-eqiad build #158810: 09FIXED in 2 min 4 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/158810/ [07:44:58] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3322553 (10Nikerabbit) I noticed that the addition of CODE_OF_CONDUCT.md was reverted in some repositories. Is it allowed to do... [07:46:34] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3331373 (10Ladsgroup) I didn't got any notice of revert of my patch. Can you point out to them? [08:10:21] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3331392 (10Ladsgroup) nvm. [[ https://gerrit.wikimedia.org/r/#/q/owner:yaron57%2540gmail.com+status:merged | Found it]] [08:14:05] What should we do about https://gerrit.wikimedia.org/r/#/q/owner:yaron57%2540gmail.com+status:merged ? [08:17:02] (03CR) 10Hashar: [C: 032] Add selenium tests to gate and submit [integration/config] - 10https://gerrit.wikimedia.org/r/357582 (owner: 10Jonas Kress (WMDE)) [08:18:05] (03Merged) 10jenkins-bot: Add selenium tests to gate and submit [integration/config] - 10https://gerrit.wikimedia.org/r/357582 (owner: 10Jonas Kress (WMDE)) [08:37:37] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: "Unhandled Exception ("Exception"): Rejecting ambiguous URI" when trying to access certain tasks / conpherence rooms / etc - https://phabricator.wikimedia.org/T166870#3331417 (10Mvolz) Thanks, we are now able to access the room :). [08:37:55] Amir1: report it back to whatever task asked to add the code of conduct file to every single repo? :} [08:38:38] Already done. That was the way that I found it Nikerabbit mentioned it there [08:38:55] Amir1: with the link https://gerrit.wikimedia.org/r/#/q/owner:%22Yaron+Koren%22+status:merged+topic:%22No+thanks%22 [08:39:12] (which adds to the search query: topic:"No thanks" ) [08:39:14] that's way better [08:39:19] thanks [08:39:22] hmm [08:39:27] s/way better/slight enhancement/ :-} [08:41:38] :D [08:45:09] hi Amir1 [08:45:30] Hey [09:22:58] PROBLEM - Puppet errors on deployment-mira is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [09:47:21] (03PS1) 10Gergő Tisza: Branch TemplateStyles [tools/release] - 10https://gerrit.wikimedia.org/r/357780 (https://phabricator.wikimedia.org/T133410) [10:03:01] RECOVERY - Puppet errors on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [10:43:21] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3331719 (10Peachey88) >>! In T165540#3331368, @Nikerabbit wrote: > I noticed that the addition of CODE_OF_CONDUCT.md was reverte... [10:49:59] 10Continuous-Integration-Infrastructure, 10Operations, 10Patch-For-Review: CI for operations/puppet is taking too long - https://phabricator.wikimedia.org/T166888#3310890 (10hashar) Thank you @catrope @demon for the description of how patches are prepared to be tested and the gate system. I endorse your desc... [11:19:58] 10Continuous-Integration-Infrastructure, 10Operations, 10Patch-For-Review: CI for operations/puppet is taking too long - https://phabricator.wikimedia.org/T166888#3331797 (10hashar) >>! In T166888#3316057, @greg wrote: > Looking at the data we have it seems that the tests themselves take about [[ https://int... [11:53:37] 10Continuous-Integration-Infrastructure, 10Operations, 10Patch-For-Review: CI for operations/puppet is taking too long - https://phabricator.wikimedia.org/T166888#3331924 (10hashar) And my final reply, following up on T166888#3322963 that does a breakdown of the job build steps. > 1. It clones the repositor... [12:22:16] PROBLEM - App Server Main HTTP Response on deployment-mediawiki04 is CRITICAL: HTTP CRITICAL: HTTP/1.1 503 Service Unavailable - string 'Wikipedia' not found on 'http://en.wikipedia.beta.wmflabs.org:80/wiki/Main_Page?debug=true' - 1343 bytes in 0.004 second response time [12:22:20] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: HTTP CRITICAL: HTTP/1.1 503 Service Unavailable - string 'Wikipedia' not found on 'https://en.wikipedia.beta.wmflabs.org:443/wiki/Main_Page?debug=true' - 1992 bytes in 0.050 second response time [12:22:43] Project selenium-GettingStarted » firefox,beta,Linux,BrowserTests build #426: 04FAILURE in 42 sec: https://integration.wikimedia.org/ci/job/selenium-GettingStarted/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/426/ [12:27:21] RECOVERY - App Server Main HTTP Response on deployment-mediawiki04 is OK: HTTP OK: HTTP/1.1 200 OK - 46561 bytes in 1.256 second response time [12:27:21] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 47123 bytes in 1.071 second response time [13:03:40] 10Release-Engineering-Team (Kanban), 10VisualEditor, 10User-Ryasmeen, 10User-zeljkofilipin: LanguageScreenshotBot trying to edit a non-existent page without signing in - https://phabricator.wikimedia.org/T162454#3332085 (10Jeff_G) Now I need help defending at https://en.wikipedia.org/wiki/Wikipedia:Article... [13:43:12] PROBLEM - Puppet errors on deployment-aqs03 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [13:43:25] this one is me --^ [13:46:45] elukey@deployment-aqs03:~$ dig -x 10.68.17.125 +short [13:46:45] ci-jessie-wikimedia-505374.contintcloud.eqiad.wmflabs. [13:46:46] deployment-aqs03.deployment-prep.eqiad.wmflabs. [13:47:01] is it normal? :D [13:50:52] elukey: ugh, well normal as in we ahve seen it before [13:51:12] DNS is leaking records again I guess [13:51:36] there is a big cleanup task elukey I'll try to find it, andrewbogott ^ more hosts with crufty ci A records [13:53:11] RECOVERY - Puppet errors on deployment-aqs03 is OK: OK: Less than 1.00% above the threshold [0.0] [13:53:47] chasemp: thanks! [13:55:25] https://phabricator.wikimedia.org/T115194 [13:57:55] chasemp, elukey, I'll have a look. [13:58:19] andrewbogott: someting up in tools with puppet, can you help me look there first? [13:58:26] unsure wtf is going on [13:58:31] ok [14:17:03] tx andrewbogott [14:17:10] I was well and truly confused for a bit [14:19:00] * andrewbogott only now figuring out what actually happened [14:51:03] (03CR) 10Jforrester: [C: 032] Branch TemplateStyles [tools/release] - 10https://gerrit.wikimedia.org/r/357780 (https://phabricator.wikimedia.org/T133410) (owner: 10Gergő Tisza) [14:51:41] (03Merged) 10jenkins-bot: Branch TemplateStyles [tools/release] - 10https://gerrit.wikimedia.org/r/357780 (https://phabricator.wikimedia.org/T133410) (owner: 10Gergő Tisza) [15:04:03] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3322623 (10Huji) I have mixed feelings. In my head, MW and WMF are related by separate. CoC is a WMF policy, and of course it ap... [15:59:33] 10Release-Engineering-Team: Mediawiki.org seemingly stuck on wmf.2 - https://phabricator.wikimedia.org/T167428#3332729 (10Gilles) [15:59:39] 10Release-Engineering-Team: Mediawiki.org seemingly stuck on wmf.2 - https://phabricator.wikimedia.org/T167428#3332743 (10Gilles) p:05Triage>03High [16:35:20] 10Release-Engineering-Team: Mediawiki.org seemingly stuck on wmf.2 - https://phabricator.wikimedia.org/T167428#3332964 (10Gilles) Confirmed by doing the following: ``` > gilles@terbium:/srv/mediawiki/dblists$ mwscript eval.php mediawikiwiki > echo __DIR__ /srv/mediawiki/php-1.30.0-wmf.2/maintenance ``` [16:35:32] 10Release-Engineering-Team: Mediawiki.org stuck on wmf.2 - https://phabricator.wikimedia.org/T167428#3332967 (10Gilles) [16:40:01] 10Release-Engineering-Team: Mediawiki.org stuck on wmf.2 - https://phabricator.wikimedia.org/T167428#3332729 (10Gilles) [16:51:03] 10Continuous-Integration-Infrastructure, 10Operations, 10Patch-For-Review: CI for operations/puppet is taking too long - https://phabricator.wikimedia.org/T166888#3333018 (10faidon) Thanks for all the detailed responses from all of you, it's really appreciated. It's also great to see Docker patches proposed... [17:08:47] 10Release-Engineering-Team: Mediawiki.org stuck on wmf.2 - https://phabricator.wikimedia.org/T167428#3333069 (10greg) 05Open>03Invalid On purpose: https://phabricator.wikimedia.org/rOMWC208b185b0c52d7d091a1bcd9c7b880a02ed48666 https://phabricator.wikimedia.org/source/mediawiki-config/browse/master/wikiversi... [17:36:31] 10Beta-Cluster-Infrastructure, 10VisualEditor: Getting error HTTP 500 while loading VE in beta cluster - https://phabricator.wikimedia.org/T167341#3333330 (10Deskana) 05Open>03stalled Well, I can't reproduce this anymore. [17:38:49] 10Release-Engineering-Team: Mediawiki.org stuck on wmf.2 - https://phabricator.wikimedia.org/T167428#3333337 (10greg) But, just in case, ping @mmodell to make sure it moves along accordingly :) [17:41:38] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3333341 (10greg) It is applicable to all repos hosted in Gerrit, per the code of conduct. Also, it is a "Wikimedia" thing, not a... [17:57:59] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3333476 (10Huji) >>! In T165540#3333341, @greg wrote: > Also, it is a "Wikimedia" thing, not a "WMF" or "MW" thing. Isn't WMF =... [17:58:10] PROBLEM - Free space - all mounts on integration-slave-jessie-1002 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1002.diskspace._mnt.byte_percentfree (No valid datapoints found)integration.integration-slave-jessie-1002.diskspace.root.byte_percentfree (<11.11%) [18:03:25] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3333503 (10greg) https://www.mediawiki.org/wiki/Differences_between_Wikipedia,_Wikimedia,_MediaWiki,_and_wiki [18:07:15] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3333506 (10Huji) Okay, so you mean it is not a "Foundation"-specific issue, but more general to the whole Wikimedia movement (a... [18:17:46] 10Gerrit: mirror search/MjoLniR repository to github - https://phabricator.wikimedia.org/T167315#3333535 (10demon) Nope, renaming is not possible :( [18:29:12] 10Release-Engineering-Team: Mediawiki.org stuck on wmf.2 - https://phabricator.wikimedia.org/T167428#3333558 (10greg) er, @demon :) [18:29:48] RainbowSprinkles: just fyi, mw.org is set to wmf.2, while the rest of group0 is on wmf.4, not sure if the promote script is smart enough to move mw.org to wmf.4 later today [18:30:15] I'll do mw.org first anyway [18:30:34] word [18:31:56] 10Gerrit: mirror search/MjoLniR repository to github - https://phabricator.wikimedia.org/T167315#3333562 (10EBernhardson) Hmm, how about deleting? At this point it's not a big deal to create a new repository with the new name and re-upload the current patch sets. [18:33:57] 10Gerrit: mirror search/MjoLniR repository to github - https://phabricator.wikimedia.org/T167315#3333564 (10demon) Kind of a pain if there's already patch sets :\ [18:34:00] thcipriani: can I pick your brain about https://phabricator.wikimedia.org/T166335? [18:34:36] 10Gerrit: mirror search/MjoLniR repository to github - https://phabricator.wikimedia.org/T167315#3333567 (10EBernhardson) The patch sets are all from me, i'm actually the only person to submit any code to this repo so far. [18:35:47] milimetric: sure, not sure how much help I'll be, but my brain is free for picking :) [18:36:09] 10Gerrit: mirror search/MjoLniR repository to github - https://phabricator.wikimedia.org/T167315#3333568 (10demon) Doesn't matter if it's one person or 300, cleaning up old patch sets is a pretty big pain in the ass :( [18:36:48] thcipriani: is there any way for me to know what wiki that happened on? It doesn't make a lot of sense because the code seems fine and the feature seems to be working perfectly fine in production [18:37:16] lemme see if I can dig in logstash for that...one second [18:37:37] oh, cool, these go to logstash /me heads there too [18:39:52] milimetric: I found some helpful backtrace here: https://logstash.wikimedia.org/goto/906372f94ec22573613acdddaadb003c [18:40:04] cool [18:40:14] first one is metawiki [18:41:46] yeah, this makes no sense... how would it work if it's erroring... thcipriani are there different versions of the code serving on different servers or something? [18:42:19] 10Gerrit: mirror search/MjoLniR repository to github - https://phabricator.wikimedia.org/T167315#3333611 (10EBernhardson) hmm, ok. Well lets just mirror it to github as is then. [18:43:35] milimetric: the code is the same on all servers, different wikis do point to different wikiversions. So metawiki is on wmf.2 while testwiki is on wmf.4 already. All versions share mediawiki/config repo [18:44:46] oh, ok, thcipriani so this version of the Dashiki extension should be live on metawiki, right? https://github.com/wikimedia/mediawiki-extensions-Dashiki/blob/wmf/1.30.0-wmf.2/extension.json [18:45:30] yup that's correct [18:46:19] Nemo_bis: you could have simply added your question on the flow board to make it not empty, instead of reverting it to a non-flow talk page and immediately (within 4 minutes) adding your question. I'll gladly answer your question if you undo that revert of the flow board. [18:46:29] (we branch all extensions listed https://github.com/wikimedia/mediawiki-tools-release/blob/master/make-wmf-branch/config.json#L3-L162 weekly with the train) [18:47:08] Nemo_bis: or I can and you can ask again in the flow board [18:47:40] * greg-g does that [18:48:32] 10Gerrit, 10Release-Engineering-Team (Kanban): mirror search/MjoLniR repository to github - https://phabricator.wikimedia.org/T167315#3333628 (10demon) 05Open>03Resolved a:03demon [[ https://github.com/wikimedia/search-MjoLniR | Done ]] [18:50:48] (03PS2) 10Thcipriani: Docker for operations-puppet-tests [integration/config] - 10https://gerrit.wikimedia.org/r/357741 (https://phabricator.wikimedia.org/T166888) [18:52:31] thcipriani: thanks for your help, it looks like the error is happening exclusively on API requests and has some sort of safe fallback so it doesn't affect the actual API response. But of course it's annoying for you all to see the errors, I'll work on it. [18:53:10] milimetric: happy to be of some help, thanks for digging into it! [19:05:44] greg-g: http://meatballwiki.org/wiki/WikiNow [19:05:53] The "archived" thread was still relevant. [19:06:52] lmfao meatball. [19:20:34] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3322675 (10bd808) >>! In T165540#3333506, @Huji wrote: > MW is not a Wikimedia-only product, and we all know it. I will gladly... [20:09:02] 10Release-Engineering-Team (Kanban), 10Discovery-Search, 10MW-1.30-release-notes, 10Patch-For-Review, 10Wikimedia-log-errors: Call to a member function hasInterwikiResults() on a non-object (null) - https://phabricator.wikimedia.org/T165091#3333916 (10EBernhardson) [20:13:59] [gerrit2001:~] $ sudo apt-get -s install gerrit [20:14:10] 1 upgraded, 0 newly installed, 0 to remove and 1 not upgraded. [20:14:10] Inst gerrit [2.13.8+git1-wmf.4] (2.13.8+git1-wmf.5 Wikimedia:8/jessie-wikimedia [all]) [20:14:13] Conf gerrit (2.13.8+git1-wmf.5 Wikimedia:8/jessie-wikimedia [all]) [20:14:28] RainbowSprinkles: paladox ^ the "s" is for simulated [20:14:36] so it can be installed but i didn't [20:14:37] Ok thanks :) [20:14:50] i'll be back soon, have to step out to get water [20:15:02] ok :) [20:17:38] mutante: I'll go ahead and bump gerrit2001 right now [20:18:11] RainbowSprinkles our test earlier proves something is going wrong in the cache / index for external id. [20:19:44] paladox: So, still needing Luca's fallback patch for now then... :\ [20:19:55] Yep [20:20:12] So 2.13.8-1-g7c438d37a2 will be good then [20:20:16] Sucks, but ok [20:20:21] yep, think so :) [20:21:04] will need to ping tim when you upgrade to test also when ever you do the upgrade. [20:32:21] lol your now namely RainbowSprinkles :) [20:33:52] paladox: No, it was a lame joke in another channel [20:34:00] oh ok [20:45:50] * paladox watching uk elections :) [21:45:49] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Update gerrit to 2.13.8 - https://phabricator.wikimedia.org/T158946#3052390 (10Dzahn) The .5 version can now be installed. I simulated install on gerrit2001 and cobalt to confirm it's available but did not actually do it. ``` Inst gerrit [... [21:47:20] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Update gerrit to 2.13.8 - https://phabricator.wikimedia.org/T158946#3334201 (10Paladox) @Dzahn thanks, @demon did the upgrade on gerrit2001 pending to do it on cobalt :) [21:55:37] paladox: :) [21:55:58] jdlrobson ? :) [21:56:04] paladox: elections :) [21:56:10] ah thanks :) [21:56:15] RainbowSprinkles: hey.. so that wikidata diff error is fixed. want me to get it swatted in an hour? [21:56:25] paladox: im also interested in how they turn out. I voted! [21:56:34] jdlrobson you voted? [21:56:43] theres an #wikimedia-offtopic :) [21:56:48] jdlrobson: Lets do it now ;-) [21:57:25] RainbowSprinkles: lemme double check it fixes bc [21:57:35] https://m.wikidata.beta.wmflabs.org/wiki/Special:MobileDiff/414955 [21:57:37] hurray! [21:57:43] I went ahead and made the cherry-pick, +2 at will :) [21:57:44] no longer fataling [21:58:10] PROBLEM - Free space - all mounts on integration-slave-jessie-1002 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1002.diskspace._mnt.byte_percentfree (No valid datapoints found)integration.integration-slave-jessie-1002.diskspace.root.byte_percentfree (<11.11%) [21:58:25] RainbowSprinkles: merge away! [22:17:43] jdlrobson: Fix is live everywhere [22:17:51] (Sorry for delay, I got distracted) [22:19:02] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: MW-1.30.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T166829#3334244 (10demon) [22:19:04] 10Release-Engineering-Team (Kanban), 10MobileFrontend, 10Reading-Web-Backlog, 10MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), and 4 others: SpecialMobileDiff: Call to member function getDiffBody() on non-object - https://phabricator.wikimedia.org/T167461#3334241 (10demon) 05Open>03Resolv... [22:19:24] Everything looks great now [22:19:30] Thanks jdlrobson for getting a fix so quickly [22:19:45] np. you can thank raynor as well :) [22:19:53] was a joint effort [22:20:03] cookies for everybody! [22:20:04] :) [22:57:35] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: MW-1.30.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T166829#3334306 (10demon) [22:57:39] 10Release-Engineering-Team (Kanban), 10Revision-Slider, 10TCB-Team, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 2 others: Catchable fatal error: Argument 2 passed to RevisionSliderHooks::onDiffViewHeader() must be an instance of Revi... - https://phabricator.wikimedia.org/T167359#3334303 [23:32:22] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: MW-1.30.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T166829#3334391 (10demon) [23:58:31] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: MW-1.30.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T166829#3334407 (10demon) 05Open>03Resolved