[01:13:11] 10Gerrit: Review membership of "mediawiki" Gerrit group - https://phabricator.wikimedia.org/T168216#3358777 (10MZMcBride) [01:34:34] PROBLEM - Puppet staleness on deployment-aqs01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0] [04:28:39] 10Continuous-Integration-Config, 10Wikimedia-Site-requests, 10Patch-For-Review: Enforce our PHP coding standards on operations/mediawiki-config via composer? - https://phabricator.wikimedia.org/T162835#3358819 (10Reedy) Ok, so I've poked at the patch further, everything is showing as warnings now... But it'... [04:43:22] 10Continuous-Integration-Config, 10Wikimedia-Site-requests, 10Patch-For-Review: Enforce our PHP coding standards on operations/mediawiki-config via composer? - https://phabricator.wikimedia.org/T162835#3358825 (10Reedy) >>! In T112159#1627639, @hashar wrote: > Ah we can remove the lame footer message by pass... [04:49:33] 10Continuous-Integration-Config, 10Wikimedia-Site-requests, 10Patch-For-Review: Enforce our PHP coding standards on operations/mediawiki-config via composer? - https://phabricator.wikimedia.org/T162835#3358829 (10Reedy) p:05Triage>03Low [05:45:29] Project beta-scap-eqiad build #160386: 04FAILURE in 1 min 48 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/160386/ [05:55:51] Yippee, build fixed! [05:55:51] Project beta-scap-eqiad build #160387: 09FIXED in 2 min 10 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/160387/ [06:22:27] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3358929 (10Legoktm) >>! In T165540#3350021, @matmarex wrote: > * Clarification on whether it is required for all repositories ho... [06:45:43] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix indentation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/359507 (owner: 10Umherirrender) [06:46:34] (03Merged) 10jenkins-bot: Fix indentation [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/359507 (owner: 10Umherirrender) [07:20:34] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [08:29:33] !log Gerrit: added Ladsgroup to 'mediawiki' group - T165860 [08:29:36] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:29:37] T165860: Request for +2 rights on mediawiki/* for Ladsgroup - https://phabricator.wikimedia.org/T165860 [08:30:11] hashar, did you want to read it before doing that? [08:31:12] 10Release-Engineering-Team (Kanban), 10Repository-Ownership-Requests: Request for +2 rights on mediawiki/* for Ladsgroup - https://phabricator.wikimedia.org/T165860#3359198 (10hashar) 05Open>03Resolved a:03hashar >>! In T165860#3358591, @Krenair wrote: > Since I've been asked to clarify, my previous comm... [08:31:55] 10Release-Engineering-Team (Kanban), 10Repository-Ownership-Requests: Request for +2 rights on mediawiki/* for Ladsgroup - https://phabricator.wikimedia.org/T165860#3359205 (10Krenair) 05Resolved>03Open It still needs to be addressed before this can be completed. [08:32:20] Krenair: define "it" ? [08:32:58] Krenair: and please stop reopening this task thank you [08:33:05] hashar, it cannot be closed yet [08:33:32] lets please not start an edit war on phabricator [08:33:38] you know you are not going to win that one ? [08:33:45] the ticket is about adding +2 [08:33:48] Yes. [08:33:50] And I had a concern [08:33:51] it is done. Period [08:33:53] Therefore no +2 [08:34:11] the addition of the code of conduct file is really a different issue [08:34:16] It doesn't matter [08:34:20] and amir has just been the messenger / implementaor of the solution [08:34:35] It happened under his account [08:34:37] rest is bike shedding / opinion biases and better tracked on the other task [08:34:59] I have every right to object to this [08:35:00] we could have done it via an other account like autobot@wikimedia.org [08:35:04] that does not change much [08:35:07] Yes it doeszs [08:35:22] When an existing member has an objection, a +2 membership addition cannot be done [08:36:50] I am done with that topic. [08:36:54] I'm not [08:36:58] You have to revert what you just did [08:37:04] And apologise [08:37:11] I am not going to engage in any discussion about the code of conduct [08:37:16] that is all. [08:37:16] You don't need to [08:37:39] You do however have to revert the addition that was carried out despite the objection of an existing member [08:38:32] 10Release-Engineering-Team (Kanban), 10Repository-Ownership-Requests: Request for +2 rights on mediawiki/* for Ladsgroup - https://phabricator.wikimedia.org/T165860#3359241 (10Ladsgroup) Hey, I thought my answer in T165540#3336658 would suffice. It seems it's not. I explain in more depth now: - The ticket to... [08:43:39] When my first core +2 nomination went up, a bunch of people supported me too [08:43:45] But then an existing member had a problem [08:43:48] So it didn't go through [08:44:08] and so there was a second nomination a while later [08:44:48] are you suggesting this practice applied in mine but not here? [08:47:03] I wasn't even going to push for the whole thing to be re-done, I was fully prepared to wait for a satisfactory answer from Amir [08:47:39] And yet you decided to ignore me, and you're ignoring me now [08:48:07] 10Continuous-Integration-Infrastructure, 10Electron-PDFs, 10MediaWiki-Internationalization, 10Reading-Web-Backlog, and 2 others: Phan throws false positive when checking SpecialElectronPDF file - https://phabricator.wikimedia.org/T167995#3359256 (10hashar) a:03EBernhardson Thank you @EBernhardson 8-] [08:55:01] I'm going to go afk for a few hours, but you should know that this feels alienating (my opinion does not count where others' would) and very much reduces the chances of me spending much more time contributing to main wikimedia tech projects in the future (I hadn't done much recently and was thinking of doing some more) [08:55:49] and I'm disappointed in you hashar [08:56:10] bye [08:57:16] 10Continuous-Integration-Config, 10Wikimedia-Site-requests, 10Patch-For-Review: Enforce our PHP coding standards on operations/mediawiki-config via composer? - https://phabricator.wikimedia.org/T162835#3359279 (10hashar) ` --quiet` would be passed to composer itself. So that would be in the Jenkins job defin... [09:32:10] 10Release-Engineering-Team (Kanban), 10Repository-Ownership-Requests: Request for +2 rights on mediawiki/* for Ladsgroup - https://phabricator.wikimedia.org/T165860#3359384 (10Krenair) 05Open>03Resolved From my phone, realised I forgot to re-close this. I am very unhappy with @hashar for ignoring me, but t... [09:47:34] 10Release-Engineering-Team (Kanban), 10Phabricator: "Security" field is invisible, but still exists, and the value can't be changed, causing Herald problems - https://phabricator.wikimedia.org/T153742#3359454 (10Aklapper) @mmodell: Thanks a lot! :) [10:22:27] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [10:23:59] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3359681 (10Tgr) >>! In T165540#3336712, @faidon wrote: > On the matter at hand, while I'm generally a proponent of the CoC, I fi... [10:44:36] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3359804 (10Tgr) This discussion has become hard to follow, so I'll try to summarize: * there was lots of debate over whether add... [10:59:33] PROBLEM - Puppet errors on deployment-pdf01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [11:58:06] 10Continuous-Integration-Config, 10Gerrit, 10Release-Engineering-Team (Kanban), 10Fundraising-Backlog: Fully retire MediaWiki "Donate" skin - https://phabricator.wikimedia.org/T124519#3360276 (10hashar) 05Open>03Resolved [12:01:23] 10Release-Engineering-Team (Kanban), 10MediaWiki-JobRunner, 10Operations, 10Beta-Cluster-reproducible, 10Patch-For-Review: jobrunner / jobchron systemd services are in error state after a stop - https://phabricator.wikimedia.org/T168044#3360277 (10hashar) [12:09:21] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3360307 (10Bawolff) >>! In T165540#3359804, @Tgr wrote: > This discussion has become hard to follow, so I'll try to summarize: >... [12:17:56] 10Release-Engineering-Team (Kanban), 10MediaWiki-JobRunner, 10Operations, 10Beta-Cluster-reproducible, 10Patch-For-Review: jobrunner / jobchron systemd services are in error state after a stop - https://phabricator.wikimedia.org/T168044#3360325 (10hashar) a:03hashar [12:45:59] 10Release-Engineering-Team (Kanban), 10MediaWiki-JobRunner, 10Operations, 10Beta-Cluster-reproducible, 10Patch-For-Review: jobrunner / jobchron systemd services are in error state after a stop - https://phabricator.wikimedia.org/T168044#3360375 (10hashar) p:05Normal>03Low [12:46:02] 10Release-Engineering-Team (Kanban), 10MediaWiki-JobRunner, 10Patch-For-Review: jobrunner loops every 100ms against a result cached for 1 second - https://phabricator.wikimedia.org/T162697#3171612 (10hashar) p:05Normal>03Low [12:50:30] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3360407 (10Tgr) @Bawolff do you think that has been resolved now that a notification was sent to wikitech-l or should there be m... [12:51:03] 10Release-Engineering-Team (Kanban), 10Phabricator: "Security" field is invisible, but still exists, and the value can't be changed, causing Herald problems - https://phabricator.wikimedia.org/T153742#3360409 (10Poyekhali) [13:04:47] PROBLEM - Puppet errors on deployment-conf03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:14:29] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3360468 (10Bawolff) >>! In T165540#3360407, @Tgr wrote: > @Bawolff do you think that has been resolved now that a notification w... [13:37:39] 10Continuous-Integration-Infrastructure, 10Electron-PDFs, 10MediaWiki-Internationalization, 10Reading-Web-Backlog, and 2 others: Phan throws false positive when checking SpecialElectronPDF file - https://phabricator.wikimedia.org/T167995#3360527 (10pmiazga) Thanks @EBernhardson. To me the `tests` directory... [14:08:10] 10Release-Engineering-Team (Watching / External), 10Developer-Relations, 10MW-1.30-release-notes, 10MediaWiki-General-or-Unknown, and 3 others: Remove @author lines from code - https://phabricator.wikimedia.org/T139301#3360670 (10Qgil) p:05Triage>03Normal (Reflecting reality) [14:39:41] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3360741 (10Yaron_Koren) @Tgr: > As a thought experiment, imagane a contributor who is very misogynist but also very respectful... [15:31:45] 10Continuous-Integration-Infrastructure, 10Operations, 10Patch-For-Review: CI for operations/puppet is taking too long - https://phabricator.wikimedia.org/T166888#3360863 (10hashar) >>! In T166888#3333018, @faidon wrote: > Thanks for all the detailed responses from all of you, it's really appreciated. It'... [15:32:43] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review: CI for operations/puppet is taking too long - https://phabricator.wikimedia.org/T166888#3360869 (10hashar) [15:33:01] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review: CI for operations/puppet is taking too long - https://phabricator.wikimedia.org/T166888#3310890 (10hashar) a:03hashar [15:33:33] 10Gerrit, 10Release-Engineering-Team, 10Upstream: Internal server error when accessing change - https://phabricator.wikimedia.org/T168012#3360873 (10cicalese) Is it possible for an admin to delete my draft change https://gerrit.wikimedia.org/r/359241 from the backend? I still cannot access that change, and I... [17:05:44] PROBLEM - Puppet errors on swift is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:07:18] PROBLEM - Puppet errors on swift-storage-01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [17:22:42] PROBLEM - Puppet errors on jenkinstest is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [17:24:37] hi my build is failing because mysql isn't running on integration-slave-trusty-1003 [17:42:37] nevermind, we were able to get mysql started [17:45:19] 10Release-Engineering-Team, 10Wikimedia-General-or-Unknown: Work out how to (mass) deploy trivial mediawiki-config changes - https://phabricator.wikimedia.org/T168326#3361227 (10Reedy) [17:50:22] 10Continuous-Integration-Config, 10Wikimedia-Site-requests, 10Patch-For-Review: Enforce our PHP coding standards on operations/mediawiki-config via composer? - https://phabricator.wikimedia.org/T162835#3361255 (10Reedy) >>! In T162835#3359279, @hashar wrote: > ` --quiet` would be passed to composer itself. S... [18:02:35] RECOVERY - Puppet errors on jenkinstest is OK: OK: Less than 1.00% above the threshold [0.0] [19:08:03] 10Continuous-Integration-Config, 10Wikimedia-Site-requests, 10Patch-For-Review: Enforce our PHP coding standards on operations/mediawiki-config via composer? - https://phabricator.wikimedia.org/T162835#3361433 (10hashar) The task has been declined, so I guess it has not been fixed or there is nothing to fix? [19:31:57] PROBLEM - Puppet errors on deployment-imagescaler01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:39:57] 10Gerrit, 10Developer-Relations, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Add CODE_OF_CONDUCT.md to Wikimedia repositories - https://phabricator.wikimedia.org/T165540#3361479 (10Smalyshev) > So there was consensus to add the files, although not an overwhelming one. I don't think this conclusi... [21:45:33] (03PS4) 10Thcipriani: Docker for operations-puppet-tests [integration/config] - 10https://gerrit.wikimedia.org/r/357741 (https://phabricator.wikimedia.org/T166888) [21:46:15] (03CR) 10Thcipriani: [C: 032] Docker for operations-puppet-tests [integration/config] - 10https://gerrit.wikimedia.org/r/357741 (https://phabricator.wikimedia.org/T166888) (owner: 10Thcipriani) [21:48:15] (03Merged) 10jenkins-bot: Docker for operations-puppet-tests [integration/config] - 10https://gerrit.wikimedia.org/r/357741 (https://phabricator.wikimedia.org/T166888) (owner: 10Thcipriani) [21:57:21] (03PS1) 10Thcipriani: Add non-voting puppet docker job [integration/config] - 10https://gerrit.wikimedia.org/r/360091 (https://phabricator.wikimedia.org/T166888) [22:03:34] (03CR) 10Thcipriani: [C: 032] Add non-voting puppet docker job [integration/config] - 10https://gerrit.wikimedia.org/r/360091 (https://phabricator.wikimedia.org/T166888) (owner: 10Thcipriani) [22:04:34] (03Merged) 10jenkins-bot: Add non-voting puppet docker job [integration/config] - 10https://gerrit.wikimedia.org/r/360091 (https://phabricator.wikimedia.org/T166888) (owner: 10Thcipriani) [22:08:03] !log reloading zuul to deploy https://gerrit.wikimedia.org/r/#/c/360091/ [22:08:07] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:25:48] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review: CI for operations/puppet is taking too long - https://phabricator.wikimedia.org/T166888#3361707 (10thcipriani) >>! In T166888#3361686, @Stashbot wrote: > {nav icon=file, name=Mentioned in SAL (#w... [22:28:22] hi thcipriani|afk [22:28:29] is the docker stuff ready for additional testing? [22:29:47] legoktm: I think so, I talked this over with hashar last week, we discussed a few things (number of executers, etc) but for the operations/puppet job I just deployed a non-voting job for some additional tire-kicking [22:30:54] there are certainly refinements to be made all over the place, but I'd like to try what I've got so far and see if there are benefits or problems before taking it any further [22:31:03] ok :) [22:31:55] I know you suggested something along these lines a while ago, so if you have any input about the mess I've made so far, please feel free to chime in :) [22:33:08] either on patches directly, on that (very text-filled) task, or open a new task if you please