[01:25:26] !log deployment-tin stuck on post-merge queue for the past 13 hours, unstuck now [01:25:30] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:45:29] (03PS1) 10Legoktm: Fix FunctionComment.Missing sniff code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360092 [01:47:06] legoktm: Any idea about why this is failing at the end? 7Tqa5MkubEYe1zPLC1yl [01:47:15] well, that's fail [01:47:19] https://gerrit.wikimedia.org/r/#/c/271936/ [01:52:08] I'm not sure [01:52:21] 0.8 hasn't really been used [01:52:30] you might be better off sticking with 0.7.2 [01:52:35] until I get 0.9 out later tonight [01:52:55] Reedy: ^ [01:53:09] Is that actually a 0.8 bug though? [01:53:12] I'm guessing it's not [01:53:44] maybe not [01:54:22] (03CR) 10Legoktm: [C: 032] Fix FunctionComment.Missing sniff code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360092 (owner: 10Legoktm) [01:54:32] I'm not fussed about waiting till 0.9 etc [01:54:38] But obviously can't merge it if the test is failing :D [01:54:42] heh [01:54:50] I'm nearly done with my new magical auto-upgrade script [01:56:04] (03PS2) 10Legoktm: Fix FunctionComment.Missing sniff code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360092 [01:56:28] (03CR) 10Legoktm: [C: 032] Fix FunctionComment.Missing sniff code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360092 (owner: 10Legoktm) [01:57:07] Could do with fixing a load of that crap on the repo though [01:57:11] (03Merged) 10jenkins-bot: Fix FunctionComment.Missing sniff code [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360092 (owner: 10Legoktm) [02:01:00] legoktm: Have you seen squizlabs/PHP_CodeSniffer 3.0.1? [02:01:03] It's got some security updates [02:01:10] Might want to include that in your 0.9.0 release [02:01:14] https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.0.1 [02:02:06] * Reedy makes a patch [02:03:27] (03Draft2) 10Reedy: Update squizlabs/PHP_CodeSniffer to 3.0.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360093 [02:03:38] ^ [02:04:16] (03CR) 10Reedy: "Security Advisory" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360093 (owner: 10Reedy) [02:07:24] oh wow [02:07:41] (03CR) 10Legoktm: [C: 032] Update squizlabs/PHP_CodeSniffer to 3.0.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360093 (owner: 10Reedy) [02:07:47] thanks for noticing [02:08:02] np :) [02:08:20] (03Merged) 10jenkins-bot: Update squizlabs/PHP_CodeSniffer to 3.0.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360093 (owner: 10Reedy) [02:09:07] ok, I think we're all ready for a release now [02:10:50] (03PS1) 10Legoktm: Release 0.9.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360094 [02:10:59] Reedy: wanna +2? ^ [02:11:25] (03CR) 10Reedy: [C: 032] Release 0.9.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360094 (owner: 10Legoktm) [02:12:12] (03Merged) 10jenkins-bot: Release 0.9.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360094 (owner: 10Legoktm) [02:12:48] To https://gerrit.wikimedia.org/r/mediawiki/tools/codesniffer.git [02:12:48] * [new tag] v0.9.0 -> v0.9.0 [02:13:44] :) [02:18:23] Time to spam all the things? [02:19:42] how does https://gerrit.wikimedia.org/r/#/c/360096/ look? [02:20:19] That's all automated? :o [02:20:45] yep [02:21:40] it runs phpcs, then figures out which are fixable, does that, then excludes all the failing sniffs [02:22:08] I'm sure some more of those should be autofixable [02:22:17] But that's a different task :P [02:22:40] Are you gonna upload the rest already CR+2'd? [02:23:17] I haven't in the past [02:23:43] I'm wondering if there's any reason we couldn't [02:23:50] there have been bugs in autofix in the past [02:23:54] heh [02:24:11] I think we have much stronger testing infra on the phpcs side now, but I'd still like a human to look over it [02:24:25] Ok [02:24:31] also my XML parsing/writing script is uh... hacky. [02:24:39] I guess if you were *just* bumping composer dependancies... upload with CR+2 [02:25:07] I think if it was something php-parallel-lint or something that would be fine [02:25:23] yeah [02:31:16] https://gerrit.wikimedia.org/r/#/c/360119/1/phpcs.xml,unified [02:33:11] indenting fail [02:34:27] new = ET.tostring(root).decode() [02:34:27] new = new.replace('>\n\t\t new = new.replace(' />', ' />\n\t') [02:34:27] f.write('\n' + new + '\n') [02:34:29] that's my code [02:35:04] 10MediaWiki-Codesniffer, 10Patch-For-Review: Detect "and" and "or" tokens used in PHP code - https://phabricator.wikimedia.org/T143888#3361854 (10Legoktm) 05Open>03Resolved [02:35:08] 10MediaWiki-Codesniffer, 10Patch-For-Review: No sniff for "function (" versus "function(" - https://phabricator.wikimedia.org/T149623#3361855 (10Legoktm) 05Open>03Resolved [02:43:35] 10MediaWiki-Codesniffer, 10Patch-For-Review: Ignore blocks with @inheritDoc - https://phabricator.wikimedia.org/T164649#3361871 (10Legoktm) 05Open>03Resolved [02:47:35] oh crap [02:47:39] I think there are duplicate patches [02:49:07] I killed it for now [02:57:21] Yeah, you've created some dupes :P [02:59:11] boom! a bug: https://gerrit.wikimedia.org/r/#/c/360147/1/maintenance/removeOrphanedEvents.php [03:00:18] bracket matching is hard [03:01:48] ooooh. are you going to get rid of the nasty require/include calls that look like function calls? [03:03:29] yes, it's supposed to [03:06:56] I found the bug [03:07:57] while ( $tokens[$stackPtr + $i]['code'] !== T_CLOSE_PARENTHESIS ) { [03:07:57] $i++; [03:07:57] } [03:07:59] that's wrong [03:16:22] 10MediaWiki-Codesniffer: ParenthesesAroundKeywordSniff doesn't handle nested parenthesis correctly - https://phabricator.wikimedia.org/T168352#3361879 (10Legoktm) [03:16:41] legoktm: Just deleting the php i18n shims would probably be better [03:16:46] They're really not needed now [03:20:58] (03PS1) 10Legoktm: Fix handling of nested parenthesis in ParenthesesAroundKeywordSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360164 (https://phabricator.wikimedia.org/T168352) [03:21:07] yes [03:21:27] oh I didn't even pay attention [03:21:36] heh [03:21:42] you're too busy being useful [03:23:54] anything higher than phpcs 0.6 I think has short array syntax and not compatible with 1.23 anymore [03:27:46] 10MediaWiki-Codesniffer, 10Patch-For-Review: Release Codesniffer v0.8.0 - https://phabricator.wikimedia.org/T154715#3361920 (10Legoktm) [03:27:48] 10MediaWiki-Codesniffer, 10Community-Tech, 10Patch-For-Review: Undefined index: scope_opener in MediaWiki/Sniffs/Usage/ExtendClassUsageSniff.php - https://phabricator.wikimedia.org/T154731#3361918 (10Legoktm) 05Open>03Resolved Marking as resolved for now, @brion could you file a new ticket if you're stil... [03:28:01] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer: Add cache support to PHPCode_Sniffer jobs - https://phabricator.wikimedia.org/T146644#3361922 (10Legoktm) [03:28:03] 10MediaWiki-Codesniffer, 10Patch-For-Review: Update squizlabs/PHP_CodeSniffer to 3.x - https://phabricator.wikimedia.org/T142474#3361921 (10Legoktm) 05Open>03Resolved [03:29:57] 10MediaWiki-Codesniffer: Codesniffer allows missing space before opening brace - https://phabricator.wikimedia.org/T126976#3361924 (10Legoktm) 05Open>03Resolved a:03Legoktm This is caught by the `MediaWiki.WhiteSpace.SpaceBeforeControlStructureBrace.SpaceBeforeControl` sniff now. [03:30:43] 10MediaWiki-Codesniffer: Add $IP to a global blacklist in MW codesniffer - https://phabricator.wikimedia.org/T122739#3361929 (10Legoktm) 05Open>03declined Most repos generally shouldn't need to use `$IP`. Those that do can manually whitelist it. [03:31:21] * legoktm afk for dinner [03:58:34] Yippee, build fixed! [03:58:35] Project selenium-MultimediaViewer » firefox,mediawiki,Linux,BrowserTests build #428: 09FIXED in 2 min 33 sec: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=mediawiki,PLATFORM=Linux,label=BrowserTests/428/ [03:59:05] Project selenium-MultimediaViewer » safari,beta,OS X 10.9,BrowserTests build #428: 04FAILURE in 3 min 4 sec: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=safari,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=OS%20X%2010.9,label=BrowserTests/428/ [05:48:20] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [06:23:21] RECOVERY - Puppet errors on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0] [06:33:28] PROBLEM - Puppet errors on deployment-redis02 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [06:33:43] 10MediaWiki-Codesniffer: MediaWiki.Commenting.FunctionComment.SpacingAfterParamType false positive - https://phabricator.wikimedia.org/T168355#3362022 (10Legoktm) [07:08:27] RECOVERY - Puppet errors on deployment-redis02 is OK: OK: Less than 1.00% above the threshold [0.0] [07:14:32] 10Gerrit: mediawiki/extensions/MoveToCommons repository is read only but not archived - https://phabricator.wikimedia.org/T168358#3362120 (10Legoktm) [07:15:11] 10Gerrit: mediawiki/extensions/MoveToCommons repository is read only but not archived - https://phabricator.wikimedia.org/T168358#3362132 (10Legoktm) Same with MoveToCommonsClient apparently. [07:29:21] PROBLEM - Work requests waiting in Zuul Gearman server https://grafana.wikimedia.org/dashboard/db/zuul-gearman on contint1001 is CRITICAL: CRITICAL: 53.33% of data above the critical threshold [140.0] [07:42:28] poor CI [07:55:37] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: rebuildTermSqlIndex.php causing beta-update-databases-eqiad to timeout and abort - https://phabricator.wikimedia.org/T168036#3353770 (10WMDE-leszek) > I'm guessing it's pretty much related to https://github.com/wikimedia/me... [08:25:09] gerrit is throwing a lot of HTTP 500 errors [08:28:27] 10Gerrit, 10Operations: Gerrit is now constently throwing 500 for me when reviewing patches - https://phabricator.wikimedia.org/T168360#3362285 (10Paladox) [08:28:47] 10Gerrit, 10Operations: Gerrit is now constently throwing 500 for me when reviewing patches - https://phabricator.wikimedia.org/T168360#3362299 (10Paladox) p:05Triage>03Unbreak! Setting unbreak as I carnt seem to do anything now. [08:29:26] 10Gerrit, 10Operations: Gerrit is now constently throwing 500 for me when reviewing patches - https://phabricator.wikimedia.org/T168360#3362303 (10Joe) a:03Joe [08:30:13] 10Gerrit, 10Operations: Gerrit is now constently throwing 500 for me when reviewing patches - https://phabricator.wikimedia.org/T168360#3362285 (10Joe) ``` Caused by: java.nio.file.FileSystemException: .../_1ut5m.nvm: Too many open files ``` I'm fixing by hand the systemd unit and restarting gerrit. [08:33:06] PROBLEM - Puppet errors on deployment-eventlogging04 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [08:33:45] PROBLEM - Puppet errors on saucelabs-03 is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [08:35:20] 10Gerrit, 10Operations: Gerrit is now constently throwing 500 for me when reviewing patches - https://phabricator.wikimedia.org/T168360#3362314 (10Joe) So what I did: - raised the LimitNOFile to 60000 manually - didn't bother with all the other ulimits that the shell script tries to set - restarted gerrit -di... [08:35:45] 10Gerrit, 10Operations: Gerrit is now constently throwing 500 for me when reviewing patches - https://phabricator.wikimedia.org/T168360#3362315 (10Joe) p:05Unbreak!>03High a:05Joe>03None [08:43:23] 10Release-Engineering-Team, 10Page-Previews, 10Reading-Web-Backlog, 10Reading-Web-Kanban-Board: Create bot that automatically rebases and rebuilds patches to master - https://phabricator.wikimedia.org/T167181#3362321 (10Jhernandez) @jdlrobson Nice, great job with the docs! A couple of comments: * It would... [09:13:02] RECOVERY - Puppet errors on deployment-eventlogging04 is OK: OK: Less than 1.00% above the threshold [0.0] [09:13:46] RECOVERY - Puppet errors on saucelabs-03 is OK: OK: Less than 1.00% above the threshold [0.0] [09:21:10] 10Gerrit, 10Operations: Gerrit constantly throws HTTP 500 error when reviewing patches (due to "Too many open files") - https://phabricator.wikimedia.org/T168360#3362470 (10Aklapper) [09:58:53] 10Gerrit, 10Operations: Gerrit constantly throws HTTP 500 error when reviewing patches (due to "Too many open files") - https://phabricator.wikimedia.org/T168360#3362599 (10Paladox) Ah, systemd caused this? Oh I thought gerrit was started by the init script as we had problems with systemd before. Also it was... [10:24:59] PROBLEM - Puppet errors on deployment-mira is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [11:04:59] RECOVERY - Puppet errors on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [11:53:12] 10Gerrit, 10Operations, 10Patch-For-Review: Gerrit constantly throws HTTP 500 error when reviewing patches (due to "Too many open files") - https://phabricator.wikimedia.org/T168360#3362936 (10Paladox) @joe thanks for fixing this :) [13:37:40] Project beta-scap-eqiad build #160504: 15ABORTED in 1 min 37 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/160504/ [13:40:08] Project beta-scap-eqiad build #160505: 04FAILURE in 0.54 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/160505/ [13:42:55] Yippee, build fixed! [13:42:56] Project beta-scap-eqiad build #160506: 09FIXED in 2 min 16 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/160506/ [14:00:46] (03PS1) 10Aude: Update Wikidata to wmf/1.30.0-wmf.6 [tools/release] - 10https://gerrit.wikimedia.org/r/360351 [14:41:13] (03CR) 10Jforrester: [C: 032] Fix handling of nested parenthesis in ParenthesesAroundKeywordSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360164 (https://phabricator.wikimedia.org/T168352) (owner: 10Legoktm) [14:42:16] 10MediaWiki-Codesniffer, 10Patch-For-Review: ParenthesesAroundKeywordSniff doesn't handle nested parenthesis correctly - https://phabricator.wikimedia.org/T168352#3363566 (10Jdforrester-WMF) 05Open>03Resolved [14:47:35] (03Merged) 10jenkins-bot: Fix handling of nested parenthesis in ParenthesesAroundKeywordSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/360164 (https://phabricator.wikimedia.org/T168352) (owner: 10Legoktm) [14:49:18] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [14:56:49] (03PS1) 10Hashar: puppet docker: add missing wrappers [integration/config] - 10https://gerrit.wikimedia.org/r/360363 (https://phabricator.wikimedia.org/T166888) [15:02:02] (03CR) 10Thcipriani: [C: 031] "Nice! I'll merge and deploy later today if you don't beat me to it :)" [integration/config] - 10https://gerrit.wikimedia.org/r/360363 (https://phabricator.wikimedia.org/T166888) (owner: 10Hashar) [15:24:19] RECOVERY - Puppet errors on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0] [15:29:35] PROBLEM - Free space - all mounts on deployment-kafka01 is CRITICAL: CRITICAL: deployment-prep.deployment-kafka01.diskspace.root.byte_percentfree (<100.00%) [15:53:51] 10Release-Engineering-Team, 10Page-Previews, 10Reading-Web-Backlog, 10Reading-Web-Kanban-Board: Create bot that automatically rebases and rebuilds patches to master - https://phabricator.wikimedia.org/T167181#3363861 (10Jdlrobson) > It would be good to run npm install before npm run build in case something... [16:52:39] 10Continuous-Integration-Infrastructure, 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, and 2 others: php-compile-hhvm jenkins job failing with "command not found" error - https://phabricator.wikimedia.org/T168410#3363775 (10Tobi_WMDE_SW) [16:53:17] 10Continuous-Integration-Infrastructure, 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, and 2 others: php-compile-hhvm jenkins job failing with "command not found" error - https://phabricator.wikimedia.org/T168410#3363775 (10Tobi_WMDE_SW) @hashar any idea? [17:06:51] 10Continuous-Integration-Infrastructure, 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, and 2 others: php-compile-hhvm jenkins job failing with "command not found" error - https://phabricator.wikimedia.org/T168410#3363775 (10Paladox) Ah, it needs to be moved to jessie (it's currently on trusty whic... [17:09:33] (03Draft1) 10Paladox: Migrate php-compile-hhvm test to jessie [integration/config] - 10https://gerrit.wikimedia.org/r/360382 (https://phabricator.wikimedia.org/T168410) [17:09:35] (03PS2) 10Paladox: Migrate php-compile-hhvm test to jessie [integration/config] - 10https://gerrit.wikimedia.org/r/360382 (https://phabricator.wikimedia.org/T168410) [17:10:59] (03CR) 10Paladox: Migrate php-compile-hhvm test to jessie (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/360382 (https://phabricator.wikimedia.org/T168410) (owner: 10Paladox) [17:12:39] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Support environment variables in configuration - https://phabricator.wikimedia.org/T168425#3364221 (10dduvall) [17:13:38] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Support environment variables in configuration - https://phabricator.wikimedia.org/T168425#3364238 (10dduvall) p:05Triage>03Normal [17:13:58] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Improve Blubber unit test coverage - https://phabricator.wikimedia.org/T168001#3364241 (10dduvall) p:05High>03Normal [17:25:44] Project beta-scap-eqiad build #160530: 04FAILURE in 1 min 58 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/160530/ [17:36:10] Yippee, build fixed! [17:36:11] Project beta-scap-eqiad build #160531: 09FIXED in 2 min 23 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/160531/ [17:59:35] 10Gerrit, 10Operations, 10Patch-For-Review: Gerrit constantly throws HTTP 500 error when reviewing patches (due to "Too many open files") - https://phabricator.wikimedia.org/T168360#3364632 (10Dzahn) Thanks joe! So.. that systemd unit file is installed from the .deb, not by puppet. I said we should remove i... [18:04:20] 10Gerrit, 10Operations, 10Patch-For-Review: Gerrit constantly throws HTTP 500 error when reviewing patches (due to "Too many open files") - https://phabricator.wikimedia.org/T168360#3364645 (10Dzahn) I would say let's delete the unit file that is installed now, remove it from package the next time we build a... [18:08:45] 10Gerrit, 10Operations, 10Patch-For-Review: Gerrit constantly throws HTTP 500 error when reviewing patches (due to "Too many open files") - https://phabricator.wikimedia.org/T168360#3364664 (10Paladox) Well i found the init script adds 1024 with core.packedGitOpenFiles so basically for us it's 1024 + 6000 bu... [18:42:12] https://gerrit.wikimedia.org/r/#/q/topic:bump-dev-deps+label:Code-Review-1 [19:14:03] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: MW-1.30.0-wmf.6 deployment blockers - https://phabricator.wikimedia.org/T167535#3365049 (10mmodell) p:05Normal>03High [19:15:50] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: MW-1.30.0-wmf.6 deployment blockers - https://phabricator.wikimedia.org/T167535#3335992 (10mmodell) [19:25:33] !log Nodepool rate being bumped from 1 query per 6 seconds to 1 query per 5 seconds ( https://gerrit.wikimedia.org/r/#/c/358601/ ) [19:25:36] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:43:16] RainbowSprinkles: can you abandon https://gerrit.wikimedia.org/r/359241 or does it cause an error for you too? [19:43:29] (author wants it to be abandoned) [19:43:58] personally i get "not found or no permissions" error [19:44:16] mutante it's a draft so needs an admin to do it :) [19:44:19] but not any "internal server error" as that ticket claimed [19:44:37] paladox: that's exactly what i was wondering, does the admin flag change that [19:44:41] ok [19:44:46] mutante yeh you wont get that because you carn't view the change and you didnt click the diff to start the big. [19:44:57] big = bug [19:45:04] alright [19:45:10] got it [19:45:22] ok :) [19:46:14] so if any gerrit admin is around and has a moment to just abandon that. thx https://phabricator.wikimedia.org/T168012#3360873 [19:54:31] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Labs, 10Labs-Infrastructure, and 2 others: Lower rate of Nodepool requests to OpenStack API - https://phabricator.wikimedia.org/T167803#3365191 (10hashar) Nodepool caught up with the new rate. That would reflect on the graphs:... [20:04:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review: CI for operations/puppet is taking too long - https://phabricator.wikimedia.org/T166888#3365211 (10hashar) I have rebased the serie of patches for operations/puppet.git that slightly enhance the... [20:05:46] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, and 2 others: Create a basic RSpec unit test for operations/puppet - https://phabricator.wikimedia.org/T78342#3365212 (10hashar) >>! In T166888#3360863, @hashar wrote: > >>>! In T166888#3333018, @faidon... [20:07:04] 10Continuous-Integration-Infrastructure, 10Electron-PDFs, 10MediaWiki-Internationalization, 10Reading-Web-Backlog, and 2 others: Phan throws false positive when checking SpecialElectronPDF file - https://phabricator.wikimedia.org/T167995#3365216 (10hashar) 05Open>03Resolved +2ed by @Tobi_WMDE_SW [20:12:14] 10MediaWiki-Codesniffer: add or create sniff to detect unreachable code after break in switch - https://phabricator.wikimedia.org/T168465#3365238 (10Umherirrender) [20:41:49] Project selenium-Echo » chrome,beta,Linux,BrowserTests build #431: 04FAILURE in 48 sec: https://integration.wikimedia.org/ci/job/selenium-Echo/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/431/ [20:41:50] Project selenium-Echo » firefox,beta,Linux,BrowserTests build #431: 04FAILURE in 49 sec: https://integration.wikimedia.org/ci/job/selenium-Echo/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/431/ [20:45:18] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [21:02:49] 10Continuous-Integration-Infrastructure, 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, and 3 others: php-compile-hhvm jenkins job failing with "command not found" error - https://phabricator.wikimedia.org/T168410#3365409 (10hashar) p:05Triage>03High a:03Paladox [21:04:07] 10Continuous-Integration-Infrastructure, 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, and 3 others: php-compile-hhvm jenkins job failing with "command not found" error - https://phabricator.wikimedia.org/T168410#3363775 (10hashar) I have deployed @Paladox change ``` INFO:jenkins_jobs.builder:Numb... [21:04:25] (03CR) 10Hashar: [C: 032] "Deployed and that fix the build. Indeed HHVM is no more on the trusty machines." [integration/config] - 10https://gerrit.wikimedia.org/r/360382 (https://phabricator.wikimedia.org/T168410) (owner: 10Paladox) [21:04:55] 10Continuous-Integration-Infrastructure, 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, and 3 others: php-compile-hhvm jenkins job failing with "command not found" error - https://phabricator.wikimedia.org/T168410#3365418 (10Paladox) @hashar i guess we can switch to nodepool now? Or do we stay with... [21:05:07] thanks :) [21:07:00] (03PS1) 10Thcipriani: Move operations/puppet log volume [integration/config] - 10https://gerrit.wikimedia.org/r/360544 [21:10:43] 10MediaWiki-Codesniffer: add or create sniff to detect unreachable code after break in switch - https://phabricator.wikimedia.org/T168465#3365238 (10Legoktm) https://github.com/squizlabs/PHP_CodeSniffer/blob/master/src/Standards/Squiz/Sniffs/PHP/NonExecutableCodeSniff.php could probably do it? [21:14:13] (03Merged) 10jenkins-bot: Migrate php-compile-hhvm test to jessie [integration/config] - 10https://gerrit.wikimedia.org/r/360382 (https://phabricator.wikimedia.org/T168410) (owner: 10Paladox) [21:25:18] RECOVERY - Puppet errors on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0] [21:43:10] 10Continuous-Integration-Infrastructure, 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, and 3 others: php-compile-hhvm jenkins job failing with "command not found" error - https://phabricator.wikimedia.org/T168410#3365536 (10hashar) >>! In T168410#3365418, @Paladox wrote: > @hashar i guess we can s... [21:43:56] 10Continuous-Integration-Infrastructure, 10MediaWiki-History-or-Diffs, 10TCB-Team, 10wikidiff2, and 3 others: php-compile-hhvm jenkins job failing with "command not found" error - https://phabricator.wikimedia.org/T168410#3365539 (10Paladox) Ah, thanks. [21:51:54] 10MediaWiki-Codesniffer: MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment is too strict - https://phabricator.wikimedia.org/T168476#3365542 (10MaxSem) [22:00:05] (03CR) 10Thcipriani: [C: 032] Move operations/puppet log volume [integration/config] - 10https://gerrit.wikimedia.org/r/360544 (owner: 10Thcipriani) [22:02:34] (03Merged) 10jenkins-bot: Move operations/puppet log volume [integration/config] - 10https://gerrit.wikimedia.org/r/360544 (owner: 10Thcipriani) [23:37:10] (03PS1) 10Thcipriani: Set -o pipefail for operations/puppet docker job [integration/config] - 10https://gerrit.wikimedia.org/r/360582 [23:39:48] (03CR) 10Thcipriani: [C: 032] Set -o pipefail for operations/puppet docker job [integration/config] - 10https://gerrit.wikimedia.org/r/360582 (owner: 10Thcipriani) [23:41:30] (03Merged) 10jenkins-bot: Set -o pipefail for operations/puppet docker job [integration/config] - 10https://gerrit.wikimedia.org/r/360582 (owner: 10Thcipriani)