[00:01:40] 10Release-Engineering-Team (Next), 10Wikimedia-Logstash, 10Wikimedia-log-errors: Fatalmonitor on logstash still includes deprecated channel:wfLogDBError - https://phabricator.wikimedia.org/T165675#3273440 (10demon) Dropping this from the saved dashboard should be easy (for someone who knows how to edit these... [01:00:44] 10Release-Engineering-Team (Kanban), 10releng-201617-q3, 10Release Pipeline: Gather requirements for new CI system - https://phabricator.wikimedia.org/T153270#3389348 (10Jrbranaa) Initial pass of requirements have been reviewed and updated. That being said, requirements for SSD are evolutionary by nature, s... [01:01:39] 10Release-Engineering-Team (Kanban), 10releng-201617-q3, 10Release Pipeline: Gather requirements for new CI system - https://phabricator.wikimedia.org/T153270#3389354 (10Jrbranaa) 05Open>03Resolved [01:20:20] 10MediaWiki-Codesniffer: Add a sniff to check for &$this (warnings on PHP 7.1+) - https://phabricator.wikimedia.org/T169168#3389380 (10Legoktm) [01:24:19] (03PS1) 10Legoktm: Sniff for `&$this` that causes warnings in PHP 7.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362116 (https://phabricator.wikimedia.org/T169168) [01:25:48] 10Release-Engineering-Team (Kanban), 10releng-201617-q3, 10Release Pipeline: Gather requirements for new CI system - https://phabricator.wikimedia.org/T153270#2874708 (10Legoktm) Where did this happen? [01:28:35] (03CR) 10Legoktm: [C: 032] Add some more test cases documenting IllegalSingleLineCommentSniff fixes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/361193 (owner: 10Legoktm) [01:29:24] (03Merged) 10jenkins-bot: Add some more test cases documenting IllegalSingleLineCommentSniff fixes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/361193 (owner: 10Legoktm) [01:49:25] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [02:24:25] RECOVERY - Puppet errors on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0] [04:17:53] Project selenium-MultimediaViewer » firefox,beta,Linux,BrowserTests build #437: 04FAILURE in 21 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/437/ [04:23:24] 10Release-Engineering-Team (Kanban), 10Scap, 10Services (watching): Scap3 considers service restarts to be deploys - https://phabricator.wikimedia.org/T169141#3389483 (10thcipriani) [04:26:17] 10Release-Engineering-Team (Kanban), 10Scap, 10Services (watching): Scap3 considers service restarts to be deploys - https://phabricator.wikimedia.org/T169141#3389486 (10thcipriani) a:03thcipriani [06:39:10] PROBLEM - Puppet errors on deployment-sentry01 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [06:51:31] 10Release-Engineering-Team (Next), 10Wikimedia-Logstash, 10Wikimedia-log-errors: Fatalmonitor on logstash still includes deprecated channel:wfLogDBError - https://phabricator.wikimedia.org/T165675#3389588 (10jcrespo) I have no idea- you should ask whoever did the change on mediawiki. Also do you really want... [07:19:10] RECOVERY - Puppet errors on deployment-sentry01 is OK: OK: Less than 1.00% above the threshold [0.0] [07:53:46] (03Abandoned) 10Hashar: Update slave-scripts/bin/php wrapper script to support php 7.0 [integration/jenkins] - 10https://gerrit.wikimedia.org/r/361700 (owner: 10Paladox) [07:59:38] (03CR) 10Legoktm: "paladox and I briefly discussed this on IRC - he said the script was breaking on stretch since it defaults to /usr/bin/php5 which doesn't " [integration/jenkins] - 10https://gerrit.wikimedia.org/r/361700 (owner: 10Paladox) [07:59:50] 10Beta-Cluster-Infrastructure: Set 'cluster' salt grain appropriately for all instances in beta cluster - https://phabricator.wikimedia.org/T87199#3389705 (10hashar) 05Open>03declined [07:59:53] 10Beta-Cluster-Infrastructure, 10Operations, 10Puppet, 10Technical-Debt, 10Tracking: Minimize differences between beta and production (Tracking) - https://phabricator.wikimedia.org/T87220#3389706 (10hashar) [08:14:54] (03PS4) 10Hashar: Migrate analytics tests from java 7 to java 8 [integration/config] - 10https://gerrit.wikimedia.org/r/361482 (owner: 10Paladox) [08:15:00] (03PS5) 10Hashar: Migrate analytics tests from java 7 to java 8 [integration/config] - 10https://gerrit.wikimedia.org/r/361482 (owner: 10Paladox) [08:43:17] (03PS1) 10Legoktm: Make DisallowEmptyLineFunctionsSniff apply to closures too [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362153 (https://phabricator.wikimedia.org/T168801) [08:44:00] 10MediaWiki-Codesniffer, 10Patch-For-Review: Detect empty line at begin of closure in codesniffer - https://phabricator.wikimedia.org/T168801#3389809 (10Legoktm) a:03Legoktm [08:47:45] (03PS6) 10Hashar: Migrate analytics tests from java 7 to java 8 [integration/config] - 10https://gerrit.wikimedia.org/r/361482 (owner: 10Paladox) [08:48:09] (03CR) 10Hashar: [C: 032] "I have updated the jobs:" [integration/config] - 10https://gerrit.wikimedia.org/r/361482 (owner: 10Paladox) [08:49:52] (03Merged) 10jenkins-bot: Migrate analytics tests from java 7 to java 8 [integration/config] - 10https://gerrit.wikimedia.org/r/361482 (owner: 10Paladox) [09:42:22] 10MediaWiki-Releasing, 10MediaWiki-Containers, 10Services, 10User-mobrovac, 10Wikimedia-Hackathon-2015: Ready-to-use Docker package for MediaWiki - https://phabricator.wikimedia.org/T92826#3389970 (10Addshore) @GWicke I'm keen to push forward with this effort, as my development environment is now run by... [09:45:42] (03PS1) 10Legoktm: Improve handling of multi-line class declarations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362163 (https://phabricator.wikimedia.org/T168961) [09:46:57] (03CR) 10Addshore: [C: 032] IllegalSingleLineCommentSniff: Check return value of strrpos strictly [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/361194 (owner: 10Legoktm) [09:47:01] 10MediaWiki-Codesniffer, 10Patch-For-Review: Adjust MediaWiki.WhiteSpace.SpaceBeforeClassBrace.NoSpaceBeforeBrace for use with multiline class statements - https://phabricator.wikimedia.org/T168961#3389993 (10Legoktm) a:03Legoktm [09:47:37] (03CR) 10Addshore: [C: 032] Sniff for `&$this` that causes warnings in PHP 7.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362116 (https://phabricator.wikimedia.org/T169168) (owner: 10Legoktm) [09:47:52] (03CR) 10Addshore: [C: 032] Make DisallowEmptyLineFunctionsSniff apply to closures too [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362153 (https://phabricator.wikimedia.org/T168801) (owner: 10Legoktm) [09:47:59] (03Merged) 10jenkins-bot: IllegalSingleLineCommentSniff: Check return value of strrpos strictly [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/361194 (owner: 10Legoktm) [09:48:19] (03Merged) 10jenkins-bot: Sniff for `&$this` that causes warnings in PHP 7.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362116 (https://phabricator.wikimedia.org/T169168) (owner: 10Legoktm) [09:48:28] (03CR) 10Addshore: [C: 032] Improve handling of multi-line class declarations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362163 (https://phabricator.wikimedia.org/T168961) (owner: 10Legoktm) [09:48:43] (03Merged) 10jenkins-bot: Make DisallowEmptyLineFunctionsSniff apply to closures too [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362153 (https://phabricator.wikimedia.org/T168801) (owner: 10Legoktm) [09:49:19] (03Merged) 10jenkins-bot: Improve handling of multi-line class declarations [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362163 (https://phabricator.wikimedia.org/T168961) (owner: 10Legoktm) [10:00:03] 10MediaWiki-Codesniffer: Take advantage of PHPCS's parallel feature - https://phabricator.wikimedia.org/T169189#3390028 (10Legoktm) [10:06:40] hmmmmm [10:06:40] Error: your composer.lock file is not up to date. Run "composer update" to install newer dependencies [10:06:45] bad CI [10:07:13] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add a sniff to check for &$this (warnings on PHP 7.1+) - https://phabricator.wikimedia.org/T169168#3390079 (10Legoktm) 05Open>03Resolved [10:07:24] 10MediaWiki-Codesniffer, 10Patch-For-Review: Detect empty line at begin of closure in codesniffer - https://phabricator.wikimedia.org/T168801#3377106 (10Legoktm) 05Open>03Resolved [10:07:44] 10MediaWiki-Codesniffer, 10Patch-For-Review: Adjust MediaWiki.WhiteSpace.SpaceBeforeClassBrace.NoSpaceBeforeBrace for use with multiline class statements - https://phabricator.wikimedia.org/T168961#3390081 (10Legoktm) 05Open>03Resolved [10:07:55] hashar: any idea why thats happening? [10:08:24] addshore: it's because James_F is in the middle of the OOjs UI version bump [10:08:29] vendor and core are out of sync [10:08:30] bah [10:12:47] legoktm: you probably know, whats the timescale on moving review to diffusion rather than gerrit? [10:12:50] I'm getting bored :P [10:13:18] Meh. [10:13:22] no idea [10:13:26] Has someone merged one but not the other? [10:13:28] * James_F sighs. [10:14:28] legoktm: When are we going to scrap /vendor so we don't have this circular dependency issue? ;-) [10:15:48] Probably never? [10:16:30] At some point we need to resolve this circular dependency issue in a better way. [10:16:49] I thought we fixed the circular part? [10:16:59] Or maybe not [10:20:02] Project beta-update-databases-eqiad build #18090: 04FAILURE in 1.7 sec: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/18090/ [10:21:51] James_F: looks like https://gerrit.wikimedia.org/r/#/c/362142 is broken [10:22:25] legoktm: No, we just adjusted CI to be blind to the circular dependency. If we'd actually fixed it, we wouldn't have addshore's issue. [10:23:01] addshore: Yes, I've already fixed it, someone needs to merge. [10:23:05] ack! [10:23:12] a less strick composer.json would solve this issue [10:23:21] *strict [10:23:53] At the cost of breaking for real. [10:24:31] Not having the vendor rpeo would solve this issue ;) [10:24:38] *repo, god I need a cup of tea.... [10:24:41] Indeed, which is my preferred fix. [10:25:05] also mine [10:25:27] 10MediaWiki-Codesniffer: Provide a Codesniffer rule to enforce "short" type definitions: int and bool, not integer and boolean - https://phabricator.wikimedia.org/T145162#3390135 (10Legoktm) So I believe there are two places this needs to be done: type casts and documentation blocks. Anywhere else? [10:26:02] legoktm: does the phpcs stuff fall under your mw platform team work now? :P [10:26:34] yes ish [10:26:45] thats nice ish [10:26:50] :P [10:27:00] it's not my main project atm [10:27:20] but it's 3:30am so it's really the only thing I'm awake for [10:27:29] whats your main project currently? [10:28:27] addshore: Clearly it's "sleep deprivation". :-) [10:41:17] (03PS1) 10Legoktm: Add sniff to verify type-casts use the short form (bool, int) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362171 (https://phabricator.wikimedia.org/T145162) [10:41:30] legoktm: these new phpcs test things too ar every nice [10:41:38] much nicer than the ones I manage to hack together :D [10:42:00] James_F: today was my last day of school - I'm enjoying my newfound freedom :P [10:43:07] * James_F grins. [10:45:08] addshore: as of the next quarter my projects are going to be "de-globalizing EditPage.php" and "Narrow AbuseFilter Interface" aka making all the spam filtering stuff not depend upon EditPage and other icky global state [10:45:18] "de-globalizing EditPage.php" WOOO [10:45:52] I'm going to be half working on some mcr stuff with daniel and half of another wmde person [10:46:40] yeah I picked the projects as something that indirectly helps the MCR effort [10:47:51] but yay :D [10:51:10] 10MediaWiki-Codesniffer: Question about sniff about Visibility must be declared on property - https://phabricator.wikimedia.org/T166381#3390311 (10Legoktm) 05Open>03declined The discussion on-wiki pointed to https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#.40var:_documenting_class_members which... [10:59:32] PROBLEM - Puppet errors on deployment-pdf01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [11:04:43] 10Release-Engineering-Team, 10Page-Previews, 10Reading-Web-Backlog, 10Epic: [EPIC] Generate compiled assets from continuous integration - https://phabricator.wikimedia.org/T158980#3390332 (10Jhernandez) [11:04:45] 10Release-Engineering-Team, 10Page-Previews, 10Reading-Web-Backlog, 10Reading-Web-Kanban-Board: Create bot that automatically rebases and rebuilds patches to master - https://phabricator.wikimedia.org/T167181#3390330 (10Jhernandez) 05Open>03Resolved Tested it on a patch, seems to work well and fast. Le... [11:19:32] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Regression, 10Upstream: Cannot log into Gerrit as of recent upgrade - https://phabricator.wikimedia.org/T152640#3390383 (10MarcoAurelio) @demon and @Paladox -- It'd be strange if only me were affected by this. Maybe you should scan the database and see how m... [11:35:18] Yippee, build fixed! [11:35:19] Project beta-update-databases-eqiad build #18091: 09FIXED in 15 min: https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/18091/ [12:35:41] 10MediaWiki-Codesniffer, 10Upstream: PHP_CodeSniffer 3.x breaks when prepend-autoloader: false is set (like it is in MediaWiki core) - https://phabricator.wikimedia.org/T167168#3390548 (10Legoktm) Submitted a PR upstream: https://github.com/squizlabs/PHP_CodeSniffer/pull/1536 [12:44:44] PROBLEM - Puppet errors on deployment-etcd-01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:04:47] PROBLEM - Puppet errors on deployment-conf03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:46:57] Yippee, build fixed! [13:46:57] Project selenium-VisualEditor » firefox,beta,Linux,BrowserTests build #443: 09FIXED in 2 min 56 sec: https://integration.wikimedia.org/ci/job/selenium-VisualEditor/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/443/ [14:08:35] legoktm: related, I want a hackathon session on refactoring editpage [14:26:53] 10MediaWiki-Releasing, 10MediaWiki-Containers, 10Services, 10User-mobrovac, 10Wikimedia-Hackathon-2015: Ready-to-use Docker package for MediaWiki - https://phabricator.wikimedia.org/T92826#3390918 (10mobrovac) Hello @Addshore ! We are working on getting a basic development environment set up using [Minik... [14:40:17] PROBLEM - Puppet errors on integration-r-lang-01 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [14:45:16] RECOVERY - Puppet errors on integration-r-lang-01 is OK: OK: Less than 1.00% above the threshold [0.0] [15:12:58] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: MW-1.30.0-wmf.7 deployment blockers - https://phabricator.wikimedia.org/T167536#3391209 (10mmodell) [15:24:47] 10Release-Engineering-Team, 10Page-Previews, 10Reading-Web-Backlog, 10Reading-Web-Kanban-Board: Create bot that automatically rebases and rebuilds patches to master - https://phabricator.wikimedia.org/T167181#3391290 (10Jdlrobson) Git review was configured with the other bot's username by accident. It amus... [15:26:30] PROBLEM - puppet last run on contint1001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [15:29:06] RECOVERY - Free space - all mounts on deployment-tin is OK: OK: deployment-prep.deployment-tin.diskspace.root.byte_percentfree (More than half of the datapoints are undefined) deployment-prep.deployment-tin.diskspace._srv.byte_percentfree (More than half of the datapoints are undefined) deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found) [15:41:00] hmmm [15:41:03] everything is a bit locked up [15:42:00] PROBLEM - puppet last run on contint2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [15:49:51] PROBLEM - Check for valid instance states on labnodepool1001 is CRITICAL: CHECK_NRPE: Socket timeout after 10 seconds. [15:51:41] RECOVERY - Check for valid instance states on labnodepool1001 is OK: nodepool state management is OK [15:52:39] PROBLEM - Puppet errors on deployment-mira is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:55:41] Well, this is inconvenient [15:56:19] Ooooh, looks like things are moving again though [15:56:37] addshore see -cloud [15:56:46] it was due to ldap [15:58:30] 10Release-Engineering-Team, 10Page-Previews, 10Reading-Web-Backlog, 10Epic: [EPIC] Generate compiled assets from continuous integration - https://phabricator.wikimedia.org/T158980#3391443 (10Jdlrobson) Now we have a bot that helps merging how do people feel about compiling assets in other larger extensions..? [16:02:40] RECOVERY - Puppet errors on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [16:04:36] (03CR) 10Nuria: "I run tests agains java 8 on my machine for refinery w/o issues. I run Mac OS no Ubuntu so I cannot check the Ubuntu run but I'd say let's" [integration/config] - 10https://gerrit.wikimedia.org/r/361482 (owner: 10Paladox) [16:06:10] RECOVERY - puppet last run on contint2001 is OK: OK: Puppet is currently enabled, last run 31 seconds ago with 0 failures [17:11:31] (03PS1) 10Mholloway: Whitelist yashasvi [integration/config] - 10https://gerrit.wikimedia.org/r/362238 [17:19:38] (03CR) 10Niedzielski: [C: 031] Whitelist yashasvi [integration/config] - 10https://gerrit.wikimedia.org/r/362238 (owner: 10Mholloway) [17:33:27] 10Release-Engineering-Team (Next), 10Wikimedia-Logstash, 10Wikimedia-log-errors: Fatalmonitor on logstash still includes deprecated channel:wfLogDBError - https://phabricator.wikimedia.org/T165675#3391867 (10demon) If they have their own channels & dashboards, not necessarily...the slow queries & such are mo... [17:39:30] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Regression, 10Upstream: Cannot log into Gerrit as of recent upgrade - https://phabricator.wikimedia.org/T152640#3391880 (10demon) >>! In T152640#3390383, @MarcoAurelio wrote: > @demon and @Paladox -- It'd be strange if only me were affected by this. Maybe yo... [17:40:56] okay RainbowSprinkles @ ^ [17:41:15] I'm looking at it now [17:41:25] no worries [17:41:28] (This bug has been the bane of my existence for the last ~9months) [17:43:01] Try logging in [17:44:00] okay [17:44:01] on it [17:44:40] RainbowSprinkles: it works now [17:44:46] Figures [17:45:37] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Regression, 10Upstream: Cannot log into Gerrit as of recent upgrade - https://phabricator.wikimedia.org/T152640#3391885 (10demon) Ok, got @MarcoAurelio logging in again (yay). Hopefully that's the last busted entry until we upgrade to the 2.14.x series and t... [17:46:43] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Regression, 10Upstream: Cannot log into Gerrit as of recent upgrade - https://phabricator.wikimedia.org/T152640#3391886 (10demon) p:05High>03Normal Not going to close just yet because it might easily happen again until we upgrade to 2.14.2+, but lowering... [17:47:06] * TabbyCat says away with Gerrit :P [17:48:01] I miss 2.8.x [17:48:08] Such a stable release [17:48:18] ALL THE PROBLEMS CAME WHEN WE WENT TO 2.13.x! [18:09:53] RainbowSprinkles heh. I like the inline editing :). They should have kept external id's in the db. In 2.15 they have migrated accounts to a git repo now. [18:10:38] DB or git repo, I don't care. Just stop treating lucene as a source of truth! [18:10:43] It's an indexxxxxxxxx [18:11:03] yes. [18:12:22] 10MediaWiki-Codesniffer: Take advantage of PHPCS's parallel feature - https://phabricator.wikimedia.org/T169189#3392036 (10Umherirrender) It is possible to set args in the ruleset.xml as in phpcs.xml? Would be nice when the args are used on each repo, than the parallel could be set and overridden in each phpcs.... [18:16:56] RainbowSprinkles i think our external id problems are gone with 2.14.2 (hopefully they did not break accounts when they merged a change today that migrates to the git repo). [18:23:12] if you break my account again you'll receive a not-so-friendly visit from me ;) [18:27:44] 10MediaWiki-Codesniffer: Take advantage of PHPCS's parallel feature - https://phabricator.wikimedia.org/T169189#3392123 (10thiemowmde) What is written on https://github.com/squizlabs/PHP_CodeSniffer/wiki/Annotated-ruleset.xml creates the impression that `` is possible. Just put t... [18:28:35] TabbyCat: Will I get a bad Yelp review? :( [18:28:37] :p [18:29:13] lol [18:29:24] you have yelp reviews? [18:32:27] Release engineering should totally have a yelp profile for us to be reviewed on [18:32:35] :p [18:33:14] Are you sure there isen't one yet? [18:36:28] Project beta-scap-eqiad build #161806: 04FAILURE in 2 min 33 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/161806/ [18:38:50] (03Abandoned) 10Umherirrender: Add ability for IfElseStructureSniff to detect multiple white spaces after else [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/277557 (https://phabricator.wikimedia.org/T129840) (owner: 10Billm) [18:40:28] (03Draft2) 10MarcoAurelio: Whitelisting MarcoAurelio's new email address [integration/config] - 10https://gerrit.wikimedia.org/r/362261 [18:40:33] (03Draft1) 10MarcoAurelio: Whitelisting MarcoAurelio's new email address [integration/config] - 10https://gerrit.wikimedia.org/r/362261 [18:41:14] hashar: could you https://gerrit.wikimedia.org/r/#/c/362261/ ;) :? [18:45:20] (03CR) 10Paladox: [C: 031] Whitelisting MarcoAurelio's new email address [integration/config] - 10https://gerrit.wikimedia.org/r/362261 (owner: 10MarcoAurelio) [18:46:16] Yippee, build fixed! [18:46:16] Project beta-scap-eqiad build #161807: 09FIXED in 2 min 35 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/161807/ [18:54:45] (03PS1) 10Umherirrender: Exclude common folder [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362266 (https://phabricator.wikimedia.org/T122738) [19:03:55] (03CR) 10jerkins-bot: [V: 04-1] Exclude common folder [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362266 (https://phabricator.wikimedia.org/T122738) (owner: 10Umherirrender) [19:03:57] (03PS2) 10Umherirrender: Exclude common folder [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362266 (https://phabricator.wikimedia.org/T122738) [19:13:03] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: MW-1.30.0-wmf.7 deployment blockers - https://phabricator.wikimedia.org/T167536#3392276 (10mmodell) [19:13:07] 10Release-Engineering-Team (Kanban), 10Revision-Slider, 10TCB-Team, 10VisualEditor, and 4 others: Argument 2 passed to VisualEditorHooks::onDiffViewHeader() must be an instance of Revision, null given - https://phabricator.wikimedia.org/T169132#3392275 (10mmodell) 05Open>03Resolved [19:13:33] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: MW-1.30.0-wmf.7 deployment blockers - https://phabricator.wikimedia.org/T167536#3336016 (10mmodell) [19:22:21] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: MW-1.30.0-wmf.7 deployment blockers - https://phabricator.wikimedia.org/T167536#3392295 (10mmodell) [19:23:41] PROBLEM - Puppet errors on deployment-mira is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [19:40:04] PROBLEM - Free space - all mounts on deployment-tin is CRITICAL: CRITICAL: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found)deployment-prep.deployment-tin.diskspace._srv.byte_percentfree (<55.56%) [20:03:42] RECOVERY - Puppet errors on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [20:11:51] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog), 10MediaWiki-extensions-GettingStarted, and 3 others: Missing XML files cause "Publish Performance test result report" - https://phabricator.wikimedia.org/T164296#3392395 (10Jdlrobson) [20:12:33] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Backlog), 10MediaWiki-extensions-GettingStarted, and 2 others: Missing XML files cause "Publish Performance test result report" - https://phabricator.wikimedia.org/T164296#3228948 (10Jdlrobson) [20:13:39] 10Continuous-Integration-Config, 10Reading-Web-Backlog (Tracking): Proof of concept to generate coverage report of some Wikimedia mediawiki extensions - https://phabricator.wikimedia.org/T151333#3392428 (10Jdlrobson) [20:14:21] 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Backlog), 10Jenkins, 10Reading-Web-Backlog (Tracking), and 3 others: MEDIAWIKI_URL may be set to incorrect value in mwext-mw-selenium job - https://phabricator.wikimedia.org/T144912#3392442 (10Jdlrobson) [20:29:56] (03CR) 10Krinkle: [C: 032] Add sniff to verify type-casts use the short form (bool, int) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362171 (https://phabricator.wikimedia.org/T145162) (owner: 10Legoktm) [20:32:04] (03Merged) 10jenkins-bot: Add sniff to verify type-casts use the short form (bool, int) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/362171 (https://phabricator.wikimedia.org/T145162) (owner: 10Legoktm) [20:51:26] 10Release-Engineering-Team (Kanban), 10releng-201617-q3, 10Release Pipeline: Gather requirements for new CI system - https://phabricator.wikimedia.org/T153270#3392755 (10thcipriani) >>! In T153270#3389414, @Legoktm wrote: > Where did this happen? To clarify, since the task title is ambiguous, this is the in... [20:51:26] 10Release-Engineering-Team (Kanban), 10releng-201617-q3, 10Release Pipeline: Gather requirements for new CI system - https://phabricator.wikimedia.org/T153270#3392755 (10thcipriani) >>! In T153270#3389414, @Legoktm wrote: > Where did this happen? To clarify, since the task title is ambiguous, this is the in... [21:08:54] 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Backlog), 10Reading-Web-Backlog (Tracking), 10Ruby, and 2 others: Run subset of MobileFrontend browser tests on merges in core - https://phabricator.wikimedia.org/T165940#3392805 (10Jdlrobson) [21:08:56] 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Backlog), 10Reading-Web-Backlog (Tracking), 10Ruby, and 2 others: Run subset of MobileFrontend browser tests on merges in core - https://phabricator.wikimedia.org/T165940#3392805 (10Jdlrobson) [21:12:32] 10Release-Engineering-Team, 10Contributors-Team, 10Epic, 10Reading-Web-Backlog (Tracking), and 2 others: [EPIC] Wikimedia should use a standard set of tools for managing code quality - https://phabricator.wikimedia.org/T111396#3392869 (10Jdlrobson) [21:12:35] 10Release-Engineering-Team, 10Contributors-Team, 10Epic, 10Reading-Web-Backlog (Tracking), and 2 others: [EPIC] Wikimedia should use a standard set of tools for managing code quality - https://phabricator.wikimedia.org/T111396#3392869 (10Jdlrobson) [21:13:02] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: MW-1.30.0-wmf.7 deployment blockers - https://phabricator.wikimedia.org/T167536#3392876 (10MacFan4000) 05Open>03Resolved wmf.7 sucessfully deployed [21:58:50] Yippee, build fixed! [21:58:50] Project selenium-PageTriage » chrome,beta,Linux,BrowserTests build #437: 09FIXED in 50 sec: https://integration.wikimedia.org/ci/job/selenium-PageTriage/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/437/ [22:00:22] 10Release-Engineering-Team, 10Contributors-Team, 10Epic, 10Reading-Web-Backlog (Tracking), and 2 others: [EPIC] Wikimedia should use a standard set of tools for managing code quality - https://phabricator.wikimedia.org/T111396#1603051 (10Legoktm) PHP * PHPUnit for tests * PHPCS for code style and basic sta... [22:00:39] 10Release-Engineering-Team, 10Contributors-Team, 10Epic, 10Reading-Web-Backlog (Tracking), and 2 others: [EPIC] Wikimedia should use a standard set of tools for managing code quality - https://phabricator.wikimedia.org/T111396#1603051 (10Legoktm) PHP * PHPUnit for tests * PHPCS for code style and basic sta... [22:19:50] (03PS1) 10Hashar: (DO NOT SUBMIT) experimental R based job [integration/config] - 10https://gerrit.wikimedia.org/r/362309 (https://phabricator.wikimedia.org/T153856) [22:23:02] 10Continuous-Integration-Config, 10Release-Engineering-Team (Watching / External), 10Discovery, 10Discovery-Analysis (Current work), 10Patch-For-Review: Add lint/CI to all wikimedia/discovery analytics repositories - https://phabricator.wikimedia.org/T153856#3393181 (10hashar) I have played with R most o... [22:39:57] 10Release-Engineering-Team, 10Contributors-Team, 10Epic, 10Reading-Web-Backlog (Tracking), and 2 others: [EPIC] Wikimedia should use a standard set of tools for managing code quality - https://phabricator.wikimedia.org/T111396#3393250 (10Legoktm) How does https://www.mediawiki.org/w/index.php?diff=2504224&... [22:50:32] 10Release-Engineering-Team, 10Contributors-Team, 10Epic, 10Reading-Web-Backlog (Tracking), and 2 others: [EPIC] Wikimedia should use a standard set of tools for managing code quality - https://phabricator.wikimedia.org/T111396#3393267 (10Jdlrobson) It looks great. I made a few edits, let me know what you t... [22:50:40] 3 [22:50:44] 4 [22:51:41] 5! [22:53:47] 6. [22:55:52] (03PS1) 10Legoktm: Add PHP 7.0 tests for wikidiff2 and luasandbox [integration/config] - 10https://gerrit.wikimedia.org/r/362314 [22:56:18] (03CR) 10Paladox: [C: 031] Add PHP 7.0 tests for wikidiff2 and luasandbox [integration/config] - 10https://gerrit.wikimedia.org/r/362314 (owner: 10Legoktm) [22:59:03] 10Release-Engineering-Team, 10Epic, 10WMF-deploy-2015-06-30_(1.26wmf12): [EPIC] Encourage developers to increase code coverage - https://phabricator.wikimedia.org/T100294#3393278 (10Legoktm) [22:59:05] 10Release-Engineering-Team, 10Contributors-Team, 10Epic, 10Reading-Web-Backlog (Tracking), and 2 others: [EPIC] Wikimedia should use a standard set of tools for managing code quality - https://phabricator.wikimedia.org/T111396#3393275 (10Legoktm) 05Open>03Resolved a:03Legoktm >>! In T111396#3393267,... [23:00:58] 10Gerrit, 10MediaWiki-Extensions-Pickle, 10Repository-Admins: Archive Pickle repo at Gerrit - https://phabricator.wikimedia.org/T167610#3393282 (10jeblad) 05Open>03Resolved [23:04:23] Is there a way to perform mass operations on phab tickets? e.g. if I wanted to remove certain tag from all closed tickets [23:04:42] SMalyshev: https://phabricator.wikimedia.org/project/view/13/ [23:05:01] (03CR) 10Legoktm: [C: 032] Add PHP 7.0 tests for wikidiff2 and luasandbox [integration/config] - 10https://gerrit.wikimedia.org/r/362314 (owner: 10Legoktm) [23:05:46] legoktm: ah, cool, thanks [23:08:13] 10Continuous-Integration-Infrastructure: Add mediawiki-config to the gate-and-submit-swat pipeline - https://phabricator.wikimedia.org/T169279#3393294 (10Catrope) [23:08:40] The new gate-and-submit-swat pipeline is making my SWAT less efficient today, see --^^ for bug report [23:12:25] (03Draft1) 10Paladox: Add mw-config to gate-and-submit-swat pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/362316 (https://phabricator.wikimedia.org/T169279) [23:12:27] (03PS2) 10Paladox: Add mw-config to gate-and-submit-swat pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/362316 (https://phabricator.wikimedia.org/T169279) [23:12:47] RoanKattouw ^^ [23:13:05] (03Merged) 10jenkins-bot: Add PHP 7.0 tests for wikidiff2 and luasandbox [integration/config] - 10https://gerrit.wikimedia.org/r/362314 (owner: 10Legoktm) [23:13:30] (03PS3) 10Paladox: Add mw-config to gate-and-submit-swat pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/362316 (https://phabricator.wikimedia.org/T169279) [23:13:30] Thanks! [23:13:41] (I have no clue if that patch is right, all that stuff is magic to me) [23:14:00] i followed how they did it for https://github.com/wikimedia/integration-config/blob/6305ced12cd7fa4068dd6317579a3b64412131d7/zuul/layout.yaml#L932 [23:15:44] hmm that wont work branch needs to use master to [23:15:46] too [23:17:11] !log deploying https://gerrit.wikimedia.org/r/362314 [23:17:14] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [23:17:36] (03PS4) 10Paladox: Add mw-config to gate-and-submit-swat pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/362316 (https://phabricator.wikimedia.org/T169279) [23:20:12] (03CR) 10jerkins-bot: [V: 04-1] Add mw-config to gate-and-submit-swat pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/362316 (https://phabricator.wikimedia.org/T169279) (owner: 10Paladox) [23:27:51] (03PS5) 10Paladox: Add mw-config to gate-and-submit-swat pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/362316 (https://phabricator.wikimedia.org/T169279) [23:33:05] (03CR) 10jerkins-bot: [V: 04-1] Add mw-config to gate-and-submit-swat pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/362316 (https://phabricator.wikimedia.org/T169279) (owner: 10Paladox)