[00:00:42] RECOVERY - Puppet errors on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [01:26:44] PROBLEM - Puppet errors on deployment-mira is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [01:30:56] RECOVERY - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is OK: OK: Less than 100.00% above the threshold [0.0] [02:01:44] RECOVERY - Puppet errors on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [03:45:32] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [04:02:03] Yippee, build fixed! [04:02:04] Project selenium-MultimediaViewer » firefox,mediawiki,Linux,BrowserTests build #443: 09FIXED in 6 min 3 sec: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=mediawiki,PLATFORM=Linux,label=BrowserTests/443/ [04:20:15] Project selenium-MultimediaViewer » firefox,beta,Linux,BrowserTests build #443: 04FAILURE in 24 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/443/ [04:25:33] RECOVERY - Puppet errors on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0] [06:06:07] PROBLEM - Puppet errors on integration-slave-docker-1000 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [06:29:11] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<44.44%) [06:30:33] Project selenium-Wikibase » chrome,test,Linux,BrowserTests build #412: 04FAILURE in 1 hr 50 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=test,PLATFORM=Linux,label=BrowserTests/412/ [06:41:01] RECOVERY - Puppet errors on integration-slave-docker-1000 is OK: OK: Less than 1.00% above the threshold [0.0] [07:04:10] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [08:15:42] PROBLEM - Puppet errors on deployment-mathoid is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [08:50:41] RECOVERY - Puppet errors on deployment-mathoid is OK: OK: Less than 1.00% above the threshold [0.0] [08:52:04] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-Nonlinear, 10Project-Admins, 10Patch-For-Review: Archive the NonLinear extension - https://phabricator.wikimedia.org/T169519#3406229 (10MarcoAurelio) [08:53:43] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-Nonlinear, 10Project-Admins, 10Patch-For-Review: Archive the NonLinear extension - https://phabricator.wikimedia.org/T169519#3400422 (10MarcoAurelio) [09:26:26] !sal [09:26:27] https://tools.wmflabs.org/sal/releng [09:28:03] (03PS1) 10Hashar: operations/debs/nginx is no more [integration/config] - 10https://gerrit.wikimedia.org/r/363301 [09:28:27] godog: good morning. Can you confirm me that operations/debs/nginx is no more and operations/software/nginx replaces it ? :) [09:28:42] CI is still configured for the first, and I guess I can drop it entirely [09:32:40] hashar: yeah I can confirm! thanks for looking at it [09:37:00] hashar! If I wanted to try and switch a job to docker ;) where do I need to do stuff? [09:37:13] godog: thank you :) [09:37:21] addshore: we dont do that yet. There is no infrastructure to support it yet [09:37:26] mhhhmph [09:38:20] addshore: we have an experiment for operations/puppet.git . The idea would be to run the job on a subset of instances that have Docker installed ( https://integration.wikimedia.org/ci/label/DebianJessieDocker/ ) [09:38:55] but iirc we havent finished the puppetization work, there is no jjb template yet, and we need some garbage collection of docker images of some sort [09:39:14] okay, is there a ticket i should follow regarding all that? [09:39:54] * addshore wants to make a docker image for phan & wmf, so I can run it exactly as CI does [09:40:16] :-) [09:40:31] oh, also https://gerrit.wikimedia.org/r/#/c/363222/ [09:40:43] it probably shouldn't break anything, but it might. But it does also fix things ;) [09:40:50] addshore: yeah do fill a task please. I guess against continuos-integration-infrastructure + CC thcipriani :-} [09:41:15] addshore: and you can send your docker related stuff to integration/config under directory /dockerfiles/ [09:41:32] does that automatically get built to anywhere yet? [09:41:56] the original patch was https://gerrit.wikimedia.org/r/#/c/357741/ [09:42:12] na the images are build manually and then pushed to the CI docker registry [09:43:12] but surely one can start with FROM debian:jessie-slim :) [09:43:42] and most probably we would want to build a base image for CI purposes [09:43:48] is debian:jessie-slim the wmf flavour jessie? or not? [09:44:06] or is that base image i spotted somewhere only really for production? [09:44:09] (03CR) 10Hashar: [C: 032] "Confirmed by Filippo" [integration/config] - 10https://gerrit.wikimedia.org/r/363301 (owner: 10Hashar) [09:45:37] Also, once we have all this docker stuff working, and finally a docker image for vanilla mediawiki, I can finally try and do something I have always wanted to do!!!! You can type "testsite up" in a gerrit comment, and it will run a docker image, give you a url & port and the mediawiki core patch you commented on will be running there ;) mwhahahahaaaa. [09:45:38] (03Merged) 10jenkins-bot: operations/debs/nginx is no more [integration/config] - 10https://gerrit.wikimedia.org/r/363301 (owner: 10Hashar) [10:00:54] addshore: during the hackathon I have created a tiny tool that potentially would lets one do that [10:01:00] ooooooh :D [10:01:03] name is quibble, I can't remember what the git repo is though [10:01:12] but the intent is to do something like: [10:01:15] git clone mediawiki/core [10:01:18] cd core [10:01:18] quibble [10:01:54] and that would boot a container, mount mediawiki into it then run composer test / npm test / qunit / phpunit [10:02:36] addshore: https://gerrit.wikimedia.org/r/#/q/project:integration/quibble [10:02:54] WIP / DRAFT / E_NOT_USABLE [10:03:12] iirc you want https://gerrit.wikimedia.org/r/#/c/354997/ [10:03:24] ill have a look! [10:03:53] there is a README file more or less explaining the commands to copy paste [10:04:11] the intent is to have the Jenkins job to rely on that and thus port all the CI logic to that project [10:04:19] instead of being hardcoded in shell scripts / jenkins jobs etc [10:04:30] think about it like the mediawiki/vagrant for CI :} [10:37:27] (03PS1) 10Hashar: Add debian-glue-nonvoting on operations/debs/* repos [integration/config] - 10https://gerrit.wikimedia.org/r/363317 [10:43:43] (03CR) 10Hashar: [C: 032] Add debian-glue-nonvoting on operations/debs/* repos [integration/config] - 10https://gerrit.wikimedia.org/r/363317 (owner: 10Hashar) [10:45:37] (03Merged) 10jenkins-bot: Add debian-glue-nonvoting on operations/debs/* repos [integration/config] - 10https://gerrit.wikimedia.org/r/363317 (owner: 10Hashar) [10:47:33] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [10:57:13] Project selenium-MobileFrontend » firefox,beta,Linux,BrowserTests build #477: 15ABORTED in 22 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/477/ [10:57:13] Project selenium-MobileFrontend » chrome,beta,Linux,BrowserTests build #477: 15ABORTED in 22 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/477/ [10:58:42] ^^^ that is me restarting Jenkins [10:59:33] PROBLEM - Puppet errors on deployment-pdf01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [11:16:42] PROBLEM - Puppet errors on deployment-mathoid is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [11:22:33] RECOVERY - Puppet errors on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0] [11:23:28] Project selenium-MobileFrontend » chrome,beta,Linux,BrowserTests build #478: 09SUCCESS in 25 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/478/ [11:32:28] Yippee, build fixed! [11:32:28] Project selenium-MobileFrontend » firefox,beta,Linux,BrowserTests build #478: 09FIXED in 34 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/478/ [11:51:42] RECOVERY - Puppet errors on deployment-mathoid is OK: OK: Less than 1.00% above the threshold [0.0] [11:58:22] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-Nonlinear, 10Project-Admins, 10Patch-For-Review: Archive the NonLinear extension - https://phabricator.wikimedia.org/T169519#3406946 (10MarcoAurelio) https://gerrit.wikimedia.org/r/#/c/363325/ removed it from #translatewiki.net [11:59:44] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-Nonlinear, 10Project-Admins, 10Patch-For-Review: Archive the NonLinear extension - https://phabricator.wikimedia.org/T169519#3406963 (10MarcoAurelio) [12:00:16] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-Nonlinear, 10Project-Admins, 10Patch-For-Review: Archive the NonLinear extension - https://phabricator.wikimedia.org/T169519#3400422 (10MarcoAurelio) [12:04:49] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-Nonlinear, 10Project-Admins, 10Patch-For-Review: Archive the NonLinear extension - https://phabricator.wikimedia.org/T169519#3406985 (10MarcoAurelio) [12:06:05] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-Nonlinear, 10Project-Admins, 10Patch-For-Review: Archive the NonLinear extension - https://phabricator.wikimedia.org/T169519#3400422 (10MarcoAurelio) Everything from the checklist above is done. Once https://gerrit.wikimedia.org/r/#/c/1950... [12:44:44] PROBLEM - Puppet errors on deployment-etcd-01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:04:43] Project selenium-Math » chrome,beta,Linux,BrowserTests build #443: 04FAILURE in 42 sec: https://integration.wikimedia.org/ci/job/selenium-Math/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/443/ [13:04:48] PROBLEM - Puppet errors on deployment-conf03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:07:36] 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Update gerrit to 2.14.1 - https://phabricator.wikimedia.org/T156120#3407229 (10Paladox) ed25519 key is now fixed in 1.6.0 which has just been released. I will see if i can get this back ported to 2.14.2. if not it will be in 2.15. [13:26:37] 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Update gerrit to 2.14.1 - https://phabricator.wikimedia.org/T156120#3407243 (10Paladox) authenticating the key will actually work with 2.14.1 but Verification of this host key leads to the issue which i doint think will be user impacting. [13:26:54] PROBLEM - Puppet staleness on deployment-prometheus01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0] [14:17:44] Has anyone in here had a chance to look at thumbnails on the beta cluster? [14:33:10] 10Continuous-Integration-Config, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, and 7 others: Add buildkit/bin to path on jenkins CI environment - https://phabricator.wikimedia.org/T169593#3407548 (10hashar) [14:36:39] (03CR) 10Hashar: "I have updated the job and did a recheck on https://gerrit.wikimedia.org/r/#/c/363141/ . The job still fails when doing amp create" [integration/config] - 10https://gerrit.wikimedia.org/r/363229 (https://phabricator.wikimedia.org/T169593) (owner: 10Ejegg) [14:44:39] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-Nonlinear, 10Project-Admins, 10Patch-For-Review: Archive the NonLinear extension - https://phabricator.wikimedia.org/T169519#3407570 (10hashar) MarcoAurelio wrote: > Everything from the checklist above is done. Once > https://gerrit.wikime... [14:48:42] PROBLEM - Puppet errors on deployment-sca04 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [14:50:31] RECOVERY - Puppet staleness on deployment-prometheus01 is OK: OK: Less than 1.00% above the threshold [3600.0] [14:55:12] PROBLEM - Puppet errors on deployment-sca02 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [14:57:46] PROBLEM - Puppet errors on deployment-prometheus01 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [15:00:41] PROBLEM - Puppet errors on deployment-trending01 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [15:09:09] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-Nonlinear, 10Project-Admins, 10Patch-For-Review: Archive the NonLinear extension - https://phabricator.wikimedia.org/T169519#3407613 (10MarcoAurelio) @hashar Thanks. Anything left to do here (mentioned or not in this task?) [15:10:17] PROBLEM - Puppet errors on deployment-changeprop is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [15:10:28] 10Continuous-Integration-Config, 10Gerrit, 10MediaWiki-extensions-Nonlinear, 10Project-Admins, 10Patch-For-Review: Archive the NonLinear extension - https://phabricator.wikimedia.org/T169519#3407617 (10hashar) 05Open>03Resolved a:05awight>03MarcoAurelio All covered! Thank you @MarcoAurelio [15:11:11] hashar: thanks ^^ [15:11:31] I guess that's not included in release-notes, right? [15:11:39] since extensions ain't part of core [15:12:27] TabbyCat: correct :) [15:12:31] release notes is just for core [15:12:41] PROBLEM - Puppet errors on deployment-mathoid is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [15:13:22] PROBLEM - Puppet errors on deployment-mcs01 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [15:13:38] PROBLEM - Puppet errors on deployment-sca01 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [15:15:48] PROBLEM - Puppet errors on deployment-sca03 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [15:25:49] gilles: I saw you got tagged in https://phabricator.wikimedia.org/T169114 - any idea what might be going on there? [15:27:30] PROBLEM - Puppet errors on deployment-eventlogging03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:49:35] Project selenium-MobileFrontend » chrome,beta,Linux,BrowserTests build #479: 04FAILURE in 27 min: https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/479/ [15:52:23] (03CR) 10Chad: "I mean it's not really a trouble, but I suppose I could." [tools/release] - 10https://gerrit.wikimedia.org/r/356430 (owner: 10Chad) [15:53:47] 10Gerrit, 10Operations: rename user gerrit2 to gerrit - https://phabricator.wikimedia.org/T169634#3407836 (10demon) 05Open>03declined I don't see any reason to bother. We could name the user "mrawesome" if we wanted. [15:57:04] 10Gerrit, 10Release-Engineering-Team, 10Operations: Reimage gerrit2001 as stretch - https://phabricator.wikimedia.org/T168562#3407851 (10demon) I've got about 6 other priorities before we do this. Yes, systemd first, also finishing logstash, scap deploy.... [16:02:49] 10Beta-Cluster-Infrastructure: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3407874 (10Gilles) I added swift::proxy::shard_container_list to the hieradata config on horizon, it was missing. This allowed to run, however the puppet run nuked the SWIFT_KEY value in the thumbor config. I ma... [16:03:40] There's no place to set a full name in gerrit, is there? [16:03:46] In case someone was vain enough to want their UI rebases to include that [16:03:51] (Or just wanted to make them consistent with command-line rebases) [16:06:55] ejegg there is but as we use ldap, it takes the name from there. [16:10:45] oh huh, how does that work if I'm just using my wikitech username (which is tied to a non-wmf email account) ? [16:11:15] is there another ldap directory I can update? [16:12:35] 10Beta-Cluster-Infrastructure: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3407905 (10Gilles) Restarting the swift proxy (on deployment-ms-fe02) made it pick up the new configuration and the traffic started flowing to deployment-imagescaler01 again. However, the thumbor config on that... [16:12:57] 10Beta-Cluster-Infrastructure, 10Operations, 10Performance-Team, 10Thumbor: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3407908 (10Gilles) p:05Triage>03High [16:13:35] https://gerrit.wikimedia.org/r/Documentation/cmd-set-account.html [16:14:36] aha [16:14:43] ejegg we can fix that by doing [16:14:44] [ldap] [16:14:44] accountFullName = [16:14:52] https://groups.google.com/forum/#!topic/repo-discuss/qm9z3VihSrg [16:15:29] 10Beta-Cluster-Infrastructure, 10Operations, 10Performance-Team, 10Thumbor: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3407945 (10Gilles) Verified that indeed, attempting to connect to poolcounter1002 just hangs: ``` gilles@deployment-imagescaler01:/srv/log/thumbor$ telnet pool... [16:15:49] paladox: awesome find! I'll try that out right now [16:16:02] ejegg it's a gerrit side thing [16:16:05] a gerrit config [16:16:12] you wont be able to do that your side. [16:16:17] needs to be done gerrit's side. [16:17:44] even if I can do other things with the gerrit ssh command line?? [16:18:07] hmm, seems to be taking its time [16:18:30] accountFullName is set to cn so it's getting the data from ldap [16:18:35] which is from wikitech [16:18:47] but i doint see any where in wikitechs ui for setting a full name. [16:18:48] ahhh [16:19:03] ejegg https://gerrit.wikimedia.org/r/#/c/363364/ [16:20:09] 10Beta-Cluster-Infrastructure, 10Operations, 10Performance-Team, 10Thumbor: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3407979 (10Gilles) I commented out the poolcounter server config line in /etc/thumbor.d/60-thumbor-server.conf on deployment-imagescaler01. Restarted thumbor. n... [16:22:57] 10Beta-Cluster-Infrastructure, 10Operations, 10Performance-Team, 10Thumbor: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3407999 (10Gilles) I bet it's something to do with that hiera value being for the swift::proxy class? I'll attempt re-creating the same list manually in horizon... [16:26:57] thanks paladox [16:27:04] your welcome :) [16:31:20] 10Beta-Cluster-Infrastructure, 10Operations, 10Performance-Team, 10Thumbor: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3408065 (10Gilles) Puppet runs are still nuking the SWIFT_KEY config value... I'm not sure that anything I try to do now will last, as any future puppet run on... [16:31:33] ejegg see https://wikitech.wikimedia.org/wiki/Renaming_users [16:31:38] per chad [16:33:56] 10Beta-Cluster-Infrastructure, 10Operations, 10Performance-Team, 10Thumbor: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3408079 (10Gilles) Alright, that fixed it. I'll let the permanent fixes to @fgiunchedi as I don't know how to fix the hiera issues. I'll try putting my overrid... [16:34:06] 10Beta-Cluster-Infrastructure, 10Operations, 10Performance-Team, 10Thumbor: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3408080 (10Gilles) a:03fgiunchedi [16:36:26] oh cool [16:37:20] seems like that is mostly for the actual login name, though, not the full name [16:37:31] but I bet the same ldapmodify command is the key [16:37:58] 10Beta-Cluster-Infrastructure, 10Operations, 10Performance-Team, 10Thumbor: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3408130 (10Gilles) The hotfixes are in /etc/thumbor.d/99-T169114.conf [16:38:26] ejegg: Oh, you can't self rename :) [16:38:35] File a task in #LDAP :) [16:38:55] k, thanks! [16:39:36] 10Release-Engineering-Team (Kanban), 10Scap (Scap3-MediaWiki-MVP), 10MediaWiki-Configuration: SCAP should not rely on extension-list, instead pass --extension-dir to mergeMessageFileList.php - https://phabricator.wikimedia.org/T125678#3408133 (10mmodell) a:05mmodell>03None [16:40:24] 10Release-Engineering-Team (Next), 10Scap: When "scap pull" does a (slow) CDB rebuild, it should tell me that that's what it's doing - https://phabricator.wikimedia.org/T162207#3408136 (10thcipriani) [16:41:04] 10Deployment-Systems, 10Release-Engineering-Team (Backlog), 10Scap, 10WorkType-NewFunctionality: Scap3 submodule space issues - https://phabricator.wikimedia.org/T137124#3408144 (10thcipriani) [16:42:20] 10Scap: scap-purge-l10n-cache hanging - https://phabricator.wikimedia.org/T122008#3408148 (10demon) 05Open>03Invalid I killed l10n-purge in rMSCA537f2ab [16:43:39] 10Beta-Cluster-Infrastructure, 10Operations, 10Performance-Team, 10Thumbor: Beta thumbnails are broken - https://phabricator.wikimedia.org/T169114#3408151 (10Gilles) Upgraded all packages to the latest, as I noticed python-thumbor-wikimedia was the previous version. [16:44:55] 10Release-Engineering-Team (Next), 10Scap: When "scap pull" does a (slow) CDB rebuild, it should tell me that that's what it's doing - https://phabricator.wikimedia.org/T162207#3155641 (10demon) Basically this problem goes away with T99740. [16:45:44] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Kanban), 10Language-Team, 10I18n: Beta cluster l10nupdate key not set up properly - https://phabricator.wikimedia.org/T114971#3408165 (10demon) 05Open>03Resolved a:03demon This hasn't been an issue in ages. [16:47:27] 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Kanban), 10JavaScript, 10Patch-For-Review, 10User-zeljkofilipin: Refactor webdriverio tests for mediawiki core so users and pages are created via the api - https://phabricator.wikimedia.org/T167502#3408169 (10zeljkofilipin) Waiting for review(s)... [16:47:33] 10Release-Engineering-Team (Kanban), 10Operations, 10Phabricator, 10Traffic: Verify that the codfw lvs is configured correctly for Phabricator - https://phabricator.wikimedia.org/T168699#3408170 (10mmodell) [16:47:51] 10Release-Engineering-Team (Kanban), 10Operations, 10Phabricator, 10Traffic: Verify that the codfw lvs is configured correctly for Phabricator - https://phabricator.wikimedia.org/T168699#3373930 (10mmodell) Need to merge https://gerrit.wikimedia.org/r/#/c/355869/ [16:52:08] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban), 10MW-1.29-release-notes, 10Patch-For-Review: Include release extensions/skins/vendor as submodules of core - https://phabricator.wikimedia.org/T137564#3408191 (10demon) [16:52:23] 10Release-Engineering-Team (Kanban), 10Scap: scap: Investigate scaps handling of InitialiseSettings.php - https://phabricator.wikimedia.org/T166384#3408192 (10thcipriani) 05Open>03Resolved a:05thcipriani>03demon Now that D654 is landed all of the `sync-*` commands should always touch `InitialiseSetting... [17:00:30] (03CR) 10Hashar: "I have not checked how fast PHPCS runs with like 64 forks. Though one sure thing, this patch will dramatically reduce the list of files " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/358554 (https://phabricator.wikimedia.org/T158974) (owner: 10Hashar) [17:30:20] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban): Improve the Jenkins output to the QA-Alerts mail list - https://phabricator.wikimedia.org/T169779#3408323 (10Jrbranaa) [17:32:03] PROBLEM - Puppet errors on integration-slave-docker-1000 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [17:32:51] hey, is there an extension deployment checklist somewhere? [17:33:10] MaxSem: https://www.mediawiki.org/wiki/Review_queue#Checklist.2FProcess [17:34:07] thanks [17:56:10] are there docs anywhere for adding new repo's to be deployed with scap3? Otherwise i can poke around and find some patches that added something previously [17:59:25] ebernhardson: this looks like it has most of the things documented -- https://wikitech.wikimedia.org/wiki/Scap3/Migration_Guide [17:59:41] bd808: excellent, thanks! [18:01:06] ebernhardson: and here's a sample puppet patch for a brand new thing -- https://gerrit.wikimedia.org/r/#/c/301505/ [18:07:27] hey... I need to run updateArticleCount.php to update the count in Special:Statistics and {{NUMBEROFARTICLES}} for commons [18:07:35] is that something i can get done in a swat or i need to ask about in ops? [18:07:40] Ummm... [18:07:41] context: https://www.mediawiki.org/wiki/Manual:$wgContentNamespaces [18:11:50] 10MediaWiki-Codesniffer: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php - https://phabricator.wikimedia.org/T169783#3408475 (10brion) [18:12:04] RECOVERY - Puppet errors on integration-slave-docker-1000 is OK: OK: Less than 1.00% above the threshold [0.0] [18:13:28] 10MediaWiki-Codesniffer: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php - https://phabricator.wikimedia.org/T169783#3408475 (10Paladox) Your composer is 0.8.0? that is really old. try composer self-update. [18:17:36] jdlrobson: I think we can run that for commonswiki. Default behavior is to use the vslow replica, so it shouldn't impact performance (and the query is reasonably well planned, afaict) [18:18:25] how can i schedule that RainbowSprinkles ? [18:19:01] We can just find some time when things are quiet, maybe after swat [18:21:44] thanks RainbowSprinkles ill check back in in about an hour? [18:21:52] Okie dokie [18:29:55] 10MediaWiki-Codesniffer: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php - https://phabricator.wikimedia.org/T169783#3408559 (10brion) mediawiki-codesniffer is 0.8.0. composer is 1.3.2. [18:30:48] 10MediaWiki-Codesniffer: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php - https://phabricator.wikimedia.org/T169783#3408574 (10Paladox) Oh i see. mediawiki-codesniffer 0.10.0 was released. [18:56:59] 10MediaWiki-Codesniffer: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php - https://phabricator.wikimedia.org/T169783#3408475 (10Reedy) >>! In T169783#3408574, @Paladox wrote: > Oh i see. mediawiki-codesniffer 0.10.0 was released. Doesn't mean it's fixed in 0.10.0, but it'... [19:02:58] 10MediaWiki-Codesniffer: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php - https://phabricator.wikimedia.org/T169783#3408743 (10brion) If I update to 0.10.0 (via setting ver in `composer.json` & running `composer update`) I get: ``` linter-registry.js [sm]:137 [Linter] Er... [19:06:35] 10MediaWiki-Codesniffer: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php - https://phabricator.wikimedia.org/T169783#3408774 (10Reedy) >>! In T169783#3408743, @brion wrote: > If I update to 0.10.0 (via setting ver in `composer.json` & running `composer update`) I get: > >... [19:07:23] (03CR) 10Bearloga: "> Then the installation fails to download/install dependencies:" (034 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/362309 (https://phabricator.wikimedia.org/T153856) (owner: 10Hashar) [19:10:55] (03Draft2) 10Reedy: Fix "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363385 (https://phabricator.wikimedia.org/T169783) [19:11:43] 10MediaWiki-Codesniffer, 10Patch-For-Review: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php - https://phabricator.wikimedia.org/T169783#3408808 (10Reedy) https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/v0.8.0/MediaWiki/Sniffs/WhiteSpace/SpaceBeforeClassBra... [19:14:05] (03CR) 10Reedy: Fix "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363385 (https://phabricator.wikimedia.org/T169783) (owner: 10Reedy) [19:14:34] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Cloud-Services, 10Cloud-VPS, and 2 others: Lower rate of Nodepool requests to OpenStack API - https://phabricator.wikimedia.org/T167803#3408840 (10chasemp) 05Open>03Resolved >>! In T167803#3378947, @hashar wrote: > Keeping... [19:15:00] (03Draft2) 10Reedy: Swap isset() === false to !isset() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363387 [19:17:59] 10MediaWiki-Codesniffer, 10Patch-For-Review: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php - https://phabricator.wikimedia.org/T169783#3408859 (10Reedy) >>! In T169783#3408804, @gerritbot wrote: > Change 363385 had a related patch set (by Reedy) published: > [mediawiki... [19:19:29] (03PS3) 10Reedy: Swap isset() === false to !isset() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363387 [19:31:56] PROBLEM - Puppet errors on deployment-imagescaler01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:35:23] twentyafterfour: i had to reboot phab2001 for kernel upgrade, fyi. it came back with systemd state issue though :( looking why [19:35:45] RainbowSprinkles: i am supposed to do the same with gerrit2001 [19:35:54] but havent touched it yet, one by one [19:43:08] Process: 882 ExecStartPre=/bin/chown -R phd:phd /var/run/phd/ (code=exited, status=1/FAILURE) [19:43:11] Process: 819 ExecStartPre=/bin/mkdir /var/run/phd (code=exited, status=1/FAILURE) [19:43:14] paladox: ^ [19:43:30] that doesnt work on reboots [19:43:51] i guess it doesnt clean up when it's shutdown [19:47:13] gerrit2001? I'm pretty sure we already did the restart for kernel? [19:47:17] Or was that a prior update? [19:47:18] * RainbowSprinkles looks [19:50:17] Ah, not yet. [19:51:18] RainbowSprinkles: it should be from 4.4 to 4.9 i think [19:52:04] mutante hmm [19:52:10] does it tell us why it failed? [19:52:11] paladox: you know what i just noticed: [19:52:15] logfile on server: [19:52:20] Process: 8796 ExecStartPre=/bin/mkdir /var/run/phd (code=exited, status=1/FAILURE) [19:52:27] me thinks: "should add -p" [19:52:38] but in repo: "phd.systemd.erb:ExecStartPre=-/bin/mkdir -p /var/run/phd/ [19:52:41] ah [19:52:42] it's already there [19:52:44] hmm [19:52:45] puppet enabled though [19:52:48] is puppet disabled? [19:52:52] not anymore [19:53:00] mutante: Rebooting gerrit2001 right now [19:53:08] RainbowSprinkles: ah :) thanks [19:54:45] ok [19:54:48] did puppet run? [19:54:49] ah [19:54:51] i know why [19:56:05] mutante: gerrit2001 back up, services running [19:58:14] RainbowSprinkles: :) great, thanks [19:58:28] paladox: now it did, it probably just had to apply the change first, yes [19:58:48] paladox: yes, it is resolved now (on Icinga too) [19:59:40] except i still see the old mkdir command in "status" [19:59:54] but it's not "degraded" anymore [20:01:21] paladox: actually, no, something is still wrong. /etc/systemd/system/phd.service does NOT have the current command [20:02:03] my guess is now that it moved to base::service_unit and that doesn't use /etc/systemd anymore (dislike, personally) [20:02:12] and nothing removed the old unit file of course [20:03:46] yes, that's it. conflicting unit files with different content.. sigh [20:04:41] imho, /etc/ is for config files. and not /lib/ but that wasn't our decision..hrmmm [20:05:54] ok, cleaned up manually. better now. it's just getting stopped but no errors [20:19:14] 10Continuous-Integration-Config, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, and 7 others: Get CI working on Omnimail - https://phabricator.wikimedia.org/T169593#3409143 (10Eileenmcnaughton) [20:20:31] (03PS3) 10Ejegg: Add civicrm-buildkit/bin to path for CRM builds [integration/config] - 10https://gerrit.wikimedia.org/r/363229 (https://phabricator.wikimedia.org/T169593) [20:20:42] Hi releng! [20:20:58] Anyone mind approving that little CiviCRM build patch? ^^^ [20:21:12] 10Continuous-Integration-Config, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, and 6 others: Get CRM CI php version the same as live - https://phabricator.wikimedia.org/T169806#3409147 (10Eileenmcnaughton) [20:22:02] 10Continuous-Integration-Config, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, and 6 others: Get CRM CI php version the same as live - https://phabricator.wikimedia.org/T169806#3409164 (10Eileenmcnaughton) @Ejegg ticket for php ver [20:22:11] oops, looks like Hashar found a problem with it? [20:22:23] I think that problem is unrelated, though [20:23:50] 10Continuous-Integration-Config, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, and 8 others: Get CI working on Omnimail - https://phabricator.wikimedia.org/T169593#3409169 (10DStrine) [20:23:54] 10Continuous-Integration-Config, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, and 7 others: Excluded vendor directory from lint tests when it is in an included extension - https://phabricator.wikimedia.org/T168597#3409172 (10DStrine) [20:25:35] releng: so, that path addition is something we need, even if we haven't fixed all the rest of the stuff for the patches currently in review [20:25:49] here's an example of it getting past the point hashar saw a problem: [20:25:51] https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/4512/console [20:26:50] 10Continuous-Integration-Config, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email, and 7 others: Get CRM CI php version the same as live - https://phabricator.wikimedia.org/T169806#3409199 (10DStrine) [20:27:29] (03CR) 10Hashar: (DO NOT SUBMIT) experimental R based job (034 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/362309 (https://phabricator.wikimedia.org/T153856) (owner: 10Hashar) [20:28:06] ejegg: good morning [20:28:19] (03CR) 10Legoktm: [C: 032] Fix "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363385 (https://phabricator.wikimedia.org/T169783) (owner: 10Reedy) [20:28:31] ejegg: yeah I have refreshed the jenkins job with the PATH tweak though I havent merged the gerrit change [20:29:06] (03Merged) 10jenkins-bot: Fix "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363385 (https://phabricator.wikimedia.org/T169783) (owner: 10Reedy) [20:29:10] (03CR) 10Hashar: [C: 032] Add civicrm-buildkit/bin to path for CRM builds [integration/config] - 10https://gerrit.wikimedia.org/r/363229 (https://phabricator.wikimedia.org/T169593) (owner: 10Ejegg) [20:29:30] ejegg: and I have zero clue as to why the job suddenly started to fail :( [20:29:40] (03CR) 10Ejegg: "Thanks for checking this out Hashar! We need this to add tests for our (redistributable!) proper CiviCRM extensions: I2663137377ffc . That" [integration/config] - 10https://gerrit.wikimedia.org/r/363229 (https://phabricator.wikimedia.org/T169593) (owner: 10Ejegg) [20:29:41] thanks mutante [20:30:11] (03CR) 10Ejegg: "oops, crossed wires. Thanks again hashar!" [integration/config] - 10https://gerrit.wikimedia.org/r/363229 (https://phabricator.wikimedia.org/T169593) (owner: 10Ejegg) [20:30:22] (03Merged) 10jenkins-bot: Add civicrm-buildkit/bin to path for CRM builds [integration/config] - 10https://gerrit.wikimedia.org/r/363229 (https://phabricator.wikimedia.org/T169593) (owner: 10Ejegg) [20:30:27] thanks hashar! [20:30:28] ejegg: also dont you have a JJB install to update the job ? [20:30:51] Ah, I do [20:31:07] so potentially you can update that job directly :] [20:31:09] sorry, I guess messing with the job via the Jenkins UI causes problems? [20:31:23] and eventually when happy with the changes, send the patch to Gerrit and whine at thcipriani until he +2 it :) [20:31:38] or yeah you can prototype directly in the Jenkins UI [20:31:38] heh, right [20:31:49] :) [20:32:06] cool, so editing via UI isn't going to blow things up for anyone? [20:32:13] then from time to time the job get regenerated so your hacks would be lost/overwritten [20:32:22] for that specific job, no that should be fine [20:32:31] it is only triggered for the fundraising civicrm repo something [20:32:43] so at worth it is just your team that suffers from it :] [20:32:55] right on, I'll limit my tinkering to fr-only jobs [20:33:25] also what you can do is to duplicate the job and play on the copy [20:33:42] zeljkof (who is way more careful than me) does that often for selenium jobs [20:34:06] https://integration.wikimedia.org/ci/ -> New Item > [20:34:34] at the bottom Copy from: wikimedia-fundraising-civicrm [20:34:38] and you get a copy to play with [20:34:41] oh cool - how exactly do you trigger that for a particular patch? [20:35:11] what I then do is that I go to the job that is triggered eg https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/ [20:35:21] pick whatever build match a gerrit change I am interested in [20:35:29] for example https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm/4519/ [20:35:42] in the left side bar is a "Parameters" link that shows all the parameters used for that build [20:36:00] so when building the copy / test job, it is asking for parameters to be filled [20:36:02] one can copy paste [20:36:08] or fill values manually [20:36:14] ah, right on! [20:36:18] you dont need all of them [20:36:22] I think you can just try: [20:36:57] ZUUL_BRANCH=master ZUUL_REF=master ZUUL_COMMIT=master ZUUL_URL=https://gerrit.wikimedia.org/r/p ZUUL_PROJECT=wikimedia/fundraising/crm [20:37:07] and that would download that repo from gerrit then checkout the "master" branch [20:37:14] (03PS4) 10Legoktm: Swap isset() === false to !isset() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363387 (owner: 10Reedy) [20:37:28] (03CR) 10Legoktm: [C: 032] Swap isset() === false to !isset() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363387 (owner: 10Reedy) [20:37:30] if you look at the gerrit change, you can find the ref to fill for ZUUL_REF (something like: refs/change/45/12345) [20:37:37] and the ZUUL_COMMIT would be the commit of the patchset [20:37:50] super-useful info hashar, thanks again! this log is definitely going in my notes. [20:37:55] (03PS3) 10Legoktm: PHP CodeSniffer on CI should only lint HEAD [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/358554 (https://phabricator.wikimedia.org/T158974) (owner: 10Hashar) [20:38:01] Yep, I think I see where to get 'em all [20:38:04] I think I wrote that somewher eon the wiki at some point :) [20:38:09] (03Merged) 10jenkins-bot: Swap isset() === false to !isset() [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363387 (owner: 10Reedy) [20:38:25] ejegg: https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Trigger_a_job_manually !!! [20:38:29] the lore is somewhere in the collective unconscious [20:38:34] tis probably obsolete though [20:38:52] potentially what we could do is craft a job that ask for the infos [20:38:56] and trigger the job for you :] [20:39:05] (03PS4) 10Legoktm: PHP CodeSniffer on CI should only lint HEAD [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/358554 (https://phabricator.wikimedia.org/T158974) (owner: 10Hashar) [20:39:15] (03CR) 10Legoktm: [C: 032] PHP CodeSniffer on CI should only lint HEAD [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/358554 (https://phabricator.wikimedia.org/T158974) (owner: 10Hashar) [20:39:27] so you would go to the BUILD-MY-STUFF job , fill the Gerrit change and the job would sort things out for ya [20:39:37] legoktm: you are the most magic man in the world :] [20:40:01] legoktm: that code is terrible really :/ But it looks like it should be just fine for Jenkis purposes [20:40:13] (03Merged) 10jenkins-bot: PHP CodeSniffer on CI should only lint HEAD [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/358554 (https://phabricator.wikimedia.org/T158974) (owner: 10Hashar) [20:40:14] hashar: it's good enough :P [20:40:30] legoktm: dont rush a codesniffer version though [20:40:43] hashar: we're going to make a 0.8.1 release that will work with MW core and I'll include that one in [20:40:45] (03PS1) 10Reedy: Update .gitreview for 0.8.x branch [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363455 [20:40:55] legoktm: I mean, I am eager to see that land specially for mediawiki/core but not at the expense of releasing a new version that has issues/is not well tested [20:40:59] (03PS1) 10Reedy: Fix "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363456 (https://phabricator.wikimedia.org/T169783) [20:41:09] legoktm: BARNSTAR! [20:41:12] (03CR) 10Legoktm: [C: 032] Update .gitreview for 0.8.x branch [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363455 (owner: 10Reedy) [20:41:15] hah, that's pretty meta [20:41:31] (03CR) 10Legoktm: [C: 032] Fix "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363456 (https://phabricator.wikimedia.org/T169783) (owner: 10Reedy) [20:42:01] legoktm: Protip: get rid of defaultbranch [20:42:04] and use track=1 [20:42:15] fuck .gitreview [20:42:23] That too ^ [20:42:30] Let's do it, do it on master [20:43:11] (03PS1) 10Reedy: track=1 rather than defaultbranch [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363459 [20:43:40] "fuck it, we'll do it live!" [20:43:46] harej: enwiki or gtfo [20:43:48] (03Merged) 10jenkins-bot: Update .gitreview for 0.8.x branch [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363455 (owner: 10Reedy) [20:43:50] (03Merged) 10jenkins-bot: Fix "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363456 (https://phabricator.wikimedia.org/T169783) (owner: 10Reedy) [20:43:59] (03CR) 10Legoktm: [C: 032] track=1 rather than defaultbranch [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363459 (owner: 10Reedy) [20:44:36] Reedy: my ask for an enwiki deploy will come after I have people test on testwiki, which will come after I have some patches merged because I don't want to present two different UIs to my testers [20:44:41] (03PS1) 10Legoktm: PHP CodeSniffer on CI should only lint HEAD [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363461 (https://phabricator.wikimedia.org/T158974) [20:45:03] (03CR) 10Legoktm: [C: 032] PHP CodeSniffer on CI should only lint HEAD [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363461 (https://phabricator.wikimedia.org/T158974) (owner: 10Legoktm) [20:46:51] (03Merged) 10jenkins-bot: track=1 rather than defaultbranch [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363459 (owner: 10Reedy) [20:47:44] (03Merged) 10jenkins-bot: PHP CodeSniffer on CI should only lint HEAD [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363461 (https://phabricator.wikimedia.org/T158974) (owner: 10Legoktm) [20:48:33] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [20:53:15] (03PS1) 10Legoktm: Release 0.8.1 [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363475 [20:53:57] Reedy: ^ +2 ? [20:56:34] (03CR) 10Reedy: [C: 032] Release 0.8.1 [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363475 (owner: 10Legoktm) [20:57:10] (03Merged) 10jenkins-bot: Release 0.8.1 [tools/codesniffer] (0.8.x) - 10https://gerrit.wikimedia.org/r/363475 (owner: 10Legoktm) [20:57:51] To https://gerrit.wikimedia.org/r/mediawiki/tools/codesniffer.git [20:57:51] * [new tag] v0.8.1 -> v0.8.1 [20:58:15] https://gerrit.wikimedia.org/r/363476 [20:58:38] heh, it's on packagist already [21:02:17] Reedy: add the line from https://gerrit.wikimedia.org/r/#/c/363461/1/README.md to phpcs.xml? [21:02:28] ewww [21:02:30] trailing whitespace :P [21:03:35] 20:58:57 - The requested package mediawiki/mediawiki-codesniffer 0.8.1 exists as mediawiki/mediawiki-codesniffer[0.1.0, 0.8.x-dev, dev-master, v0.10.0, v0.2.0, v0.3.0, v0.4.0, v0.5.0, v0.5.1, v0.6.0, v0.7.0, v0.7.1, v0.7.2, v0.8.0, v0.8.0-alpha.1, v0.9.0] but these are rejected by your constraint. [21:03:37] I guess I was too quick [21:09:32] 10MediaWiki-Codesniffer, 10Patch-For-Review: "Undefined index: scope_opener" in SpaceBeforeClassBraceSniff when linting Revision.php - https://phabricator.wikimedia.org/T169783#3409373 (10Legoktm) 05Open>03Resolved a:03Reedy This is fixed in master, and we released a 0.8.1 for MediaWiki core to get the b... [21:12:10] oh hey, I see php56 in a case statement [21:12:20] does that mean we can run unit tests under 5.6? [21:13:31] ejegg: for mediawiki we use PHP5.5 on Trusty, and HHVM on Jessie [21:13:38] ejegg: but Jessie has php 5.6 so yeah :) [21:14:14] rockin! [21:14:53] ejegg: most probably you want CI to match whatever the production box uses [21:14:59] which I guess is jessie/PHP 5.6 right? [21:15:40] (03PS3) 10Hashar: (DO NOT SUBMIT) experimental R based job [integration/config] - 10https://gerrit.wikimedia.org/r/362309 (https://phabricator.wikimedia.org/T153856) [21:15:52] hashar: yep, that's the impetus! [21:16:03] also so we can use fun new versions of phpunit etc [21:19:22] (03CR) 10Hashar: "Did most of the suggestion:" [integration/config] - 10https://gerrit.wikimedia.org/r/362309 (https://phabricator.wikimedia.org/T153856) (owner: 10Hashar) [21:19:48] ejegg: we can even have a job with php5.5 and anoter one with 5.6 [21:20:49] node: contintLabsSlave && UbuntuTrusty [21:20:53] that is what cause it to use trusty [21:20:57] (03PS1) 10Ejegg: Switch all fundraising tests to PHP5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/363478 (https://phabricator.wikimedia.org/T169806) [21:21:06] and the default for "php" is php5 which happens to be Zend 5.5 on Trusty [21:21:38] legoktm: That's better, jerkins V+2 [21:22:51] (03CR) 10Eileen: [C: 031] "I can't approve - but I can say 'yay'" [integration/config] - 10https://gerrit.wikimedia.org/r/363478 (https://phabricator.wikimedia.org/T169806) (owner: 10Ejegg) [21:23:22] (03CR) 10jerkins-bot: [V: 04-1] Switch all fundraising tests to PHP5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/363478 (https://phabricator.wikimedia.org/T169806) (owner: 10Ejegg) [21:23:33] RECOVERY - Puppet errors on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0] [21:24:21] ouch [21:24:25] stupid debug log level [21:24:59] 00:01:30.244 FAILURE: Job mwext-donationinterfacecore-REL1_27-zend55-trusty not defined [21:24:59] 00:01:30.244 FAILURE: Job mwext-donationinterfacecore-REL1_28-zend55-trusty not defined [21:24:59] 00:01:30.244 FAILURE: Job wikimedia-fundraising-crm-composer-php55-trusty not defined [21:25:12] oops, just saw your note hashar. updating the node: [21:25:18] ejegg: gotta update the zuul/layout.yaml file [21:25:22] which should be quite easy :] [21:25:27] ah, thanks! [21:31:20] ejegg: I am heading to bed will deploy it tomorrow though thcipriani should be able to handle it :] [21:31:21] have fun! [21:31:53] (03PS2) 10Ejegg: Switch all fundraising tests to PHP5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/363478 (https://phabricator.wikimedia.org/T169806) [21:32:01] thanks again hashar [21:36:17] (03CR) 10jerkins-bot: [V: 04-1] Switch all fundraising tests to PHP5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/363478 (https://phabricator.wikimedia.org/T169806) (owner: 10Ejegg) [21:38:58] hashar: https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-jessie/1395/console [21:39:19] Took 1 min 7 sec [21:41:51] legoktm: \o: [21:42:29] legoktm: I am probably going to merge phpcs in the mediawiki-phpunit-hhvm-jessie job [21:42:47] sounds good [21:42:54] can jenkins handle multiple checkstyle files? [21:43:01] like from phpunit and phpcs? [21:43:02] and if the patch is good enough, maybe backport it to the REL branches [21:43:07] RainbowSprinkles is the doc for blocking user from gerrit still correct on wikitech? [21:43:23] legoktm: multiple checkstyle files? what do you mean? [21:43:31] the ssh part will not work. But gerrit includes a rest api now to do the other part setting users inactive. [21:44:10] hashar: for the "test result" option? phpunit generates a .xml file with the test results, and phpcs does that too [21:44:21] ejegg: 0:01:35.526 FAILURE: Job mwgate-php56lint not defined 00:01:35.527 FAILURE: Job php56lint not defined :( [21:44:38] ejegg: those are defined somehwere else :/ [21:44:52] ejegg: I can surely sort that out tomorrow morning [21:45:17] https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-jessie/1392/console at the bottom [21:45:22] 19:56:18 [CHECKSTYLE] Searching for all files in /home/jenkins/workspace/mediawiki-core-phpcs-jessie that match the pattern log/checkstyle.xml [21:45:22] 19:56:18 [CHECKSTYLE] Parsing 1 file in /home/jenkins/workspace/mediawiki-core-phpcs-jessie [21:45:23] 19:56:18 [CHECKSTYLE] Successfully parsed file /home/jenkins/workspace/mediawiki-core-phpcs-jessie/log/checkstyle.xml with 0 unique warnings and 0 duplicates. [21:45:52] paladox: Why wouldn't the set-account ssh endpoint work? [21:46:04] you could use that [21:46:13] but there's a rest api to do it now :) [21:46:17] legoktm: https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-jessie/configure browse to bottom. The helps seems to suggest wildcards/multiple files are accepted [21:46:29] That's way more work, lol [21:46:54] ssh gerrit.wikimedia.org gerrit set-account --inactive -- paladox [21:47:00] i only noticed that since upstream tryed adding a block user ui to polygerrit but truned out it did the complete oposite. It allowed the user to log in [21:47:03] and lol [21:47:10] hmm [21:47:30] legoktm: so maybe log/checkstyle*.xml or use the default of "**/checkstyle-result.xml" and have phpcs generate stuff like log/foo/checkstyle-result.xml log/bar/checkstyle-result.xml [21:47:53] RainbowSprinkles even quicker https://gerrit-review.googlesource.com/?polygerrit=0#/c/106713/ [21:48:07] it has auto popup too [21:48:35] except from if the user is inactive that's when you have to type the detail correctly to be able to re activate them again. [21:49:07] hashar: ah, awesome [21:49:09] That's all way more effort than just typing a few keystrokes in the command line [21:49:17] I mean, it's a rare, admin-only event :) [21:49:33] hashar: for backporting, we can just copy your PHP file into MW core directly [21:49:38] ok [21:50:25] legoktm: yeah i have sent the files to mediawiki/core originally there is a gerrit change we can thus cherry pick. Good point :] [21:50:41] legoktm: be bold with the checkstyle, and thanks for the phpcs speed up !: ] [21:50:50] I am off! [21:56:29] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: Improve Phabricator Print function so I can print a ticket out and read it - https://phabricator.wikimedia.org/T169788#3409538 (10mmodell) 05Open>03Resolved a:03mmodell [21:56:43] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: Improve Phabricator Print function so I can print a ticket out and read it - https://phabricator.wikimedia.org/T169788#3409544 (10mmodell) a:05mmodell>03None [21:58:03] RainbowSprinkles i think i know why T161206 fails. And my fix is https://gerrit-review.googlesource.com/?polygerrit=0#/c/110970/ though upstream wont merge it until i can reproduce. [21:58:03] T161206: Gerrit patchset 99101 cannot be accessed: "500 Internal server error" - https://phabricator.wikimedia.org/T161206 [21:59:12] which will be never as one of the gerrit releases fixes that so you doint get ^^. but as that change is old it will reproduce that. [22:04:32] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: Improve Phabricator Print function so I can print a ticket out and read it - https://phabricator.wikimedia.org/T169788#3409584 (10matmarex) I'm glad this helps you, but I'm not really sure if this issue can be considered resolved. Ups... [22:09:09] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: Improve Phabricator Print function so I can print a ticket out and read it - https://phabricator.wikimedia.org/T169788#3409597 (10demon) 05Resolved>03Open I don't think it would be that hard to fix. It's just about adding a few CS... [22:10:00] 10Release-Engineering-Team, 10Page-Previews, 10Reading-Web-Backlog, 10Reading-Web-Kanban-Board: Create bot that automatically rebases and rebuilds patches to master - https://phabricator.wikimedia.org/T167181#3409600 (10Jdlrobson) Fixed! [22:15:01] (03PS1) 10Ejegg: Templatize phplint jobs [integration/config] - 10https://gerrit.wikimedia.org/r/363493 [22:16:14] * ejegg wonders if jjb can base a template on another template without <<: ^^^^ [22:20:26] (03CR) 10jerkins-bot: [V: 04-1] Templatize phplint jobs [integration/config] - 10https://gerrit.wikimedia.org/r/363493 (owner: 10Ejegg) [22:24:39] guh, gotta get off metered connection if it's 25MB to see the problem every time [22:26:22] your on a "metered connection" [22:26:24] (03PS3) 10Ejegg: Switch all fundraising tests to PHP5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/363478 (https://phabricator.wikimedia.org/T169806) [22:26:37] aka cell phone data plan [22:28:13] (03CR) 10jerkins-bot: [V: 04-1] Switch all fundraising tests to PHP5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/363478 (https://phabricator.wikimedia.org/T169806) (owner: 10Ejegg) [22:28:48] oh. i always thought metered was when your on a limited data plan. [22:28:53] * paladox has unlimited 4g. [22:29:38] heh, they won't let me sign up for the nice data plans 'cause I'm only in the country for a couple months [22:30:02] so I'm burning through the 2GB 'month' packet pretty quick [22:30:07] oh doint they have pay as you go. [22:32:54] (03CR) 10Hashar: "I found a promising gem in devtools which seems to install all the dependencies:" [integration/config] - 10https://gerrit.wikimedia.org/r/362309 (https://phabricator.wikimedia.org/T153856) (owner: 10Hashar) [22:33:39] ejegg i burned through 60-70gb in one month. [22:34:03] (03CR) 10Hashar: "need as well:" [integration/config] - 10https://gerrit.wikimedia.org/r/362309 (https://phabricator.wikimedia.org/T153856) (owner: 10Hashar) [22:34:49] if it weren't for Juan Valdez cafes and their free wi-fi i'd probably be in that neighborhood [22:39:03] ejegg not sure what you mean by in that neighbourhood. [22:39:30] data usage near yrs [22:40:13] (03PS4) 10Ejegg: Switch all fundraising tests to PHP5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/363478 (https://phabricator.wikimedia.org/T169806) [22:41:12] is yrs = years? [22:41:19] yours [22:41:46] thanks. [22:41:52] yours [22:41:55] heh [22:41:58] (03PS1) 10Niharika29: Add codemirror to release/tools [tools/release] - 10https://gerrit.wikimedia.org/r/363496 [22:43:26] (03CR) 10MaxSem: [C: 032] Add codemirror to release/tools [tools/release] - 10https://gerrit.wikimedia.org/r/363496 (owner: 10Niharika29) [22:43:34] RainbowSprinkles: whoops.. i forgot to check in again :) [22:44:05] (03Merged) 10jenkins-bot: Add codemirror to release/tools [tools/release] - 10https://gerrit.wikimedia.org/r/363496 (owner: 10Niharika29) [22:45:28] 10Release-Engineering-Team, 10Operations, 10Wikimedia-Site-requests: Run updateArticleCount.php on Wikimedia Commons - https://phabricator.wikimedia.org/T169822#3409698 (10Jdlrobson) [22:46:02] 10Release-Engineering-Team, 10Operations, 10Wikimedia-Site-requests: Run updateArticleCount.php on Wikimedia Commons - https://phabricator.wikimedia.org/T169822#3409698 (10Reedy) Just run it in a screen on terbium and wait? :) [22:46:48] 10Release-Engineering-Team, 10Operations, 10Wikimedia-Site-requests: Run updateArticleCount.php on Wikimedia Commons - https://phabricator.wikimedia.org/T169822#3409717 (10Jdlrobson) @Reedy I don't have the ability to do that.. so I guess I need somebody to help me! :) [22:46:57] 10Release-Engineering-Team, 10Operations, 10Wikimedia-Site-requests: Run updateArticleCount.php on Wikimedia Commons - https://phabricator.wikimedia.org/T169822#3409718 (10Jdlrobson) [22:47:40] (03PS2) 10Ejegg: Templatize phplint jobs [integration/config] - 10https://gerrit.wikimedia.org/r/363493 [22:48:40] (03CR) 10jerkins-bot: [V: 04-1] Templatize phplint jobs [integration/config] - 10https://gerrit.wikimedia.org/r/363493 (owner: 10Ejegg) [22:53:22] thanks a ton Reedy :) [22:53:49] 10Release-Engineering-Team, 10Operations, 10Wikimedia-Site-requests: Run updateArticleCount.php on Wikimedia Commons - https://phabricator.wikimedia.org/T169822#3409751 (10Reedy) 05Open>03Resolved a:03Reedy ``` reedy@terbium:~$ mwscript updateArticleCount.php --wiki=commonswiki --update Counting articl... [22:56:26] (03CR) 10Bearloga: "> From hours of reading about R, it seems the "R CMD check" command is intended to run standalone. Ie just to verify low level / basic fac" [integration/config] - 10https://gerrit.wikimedia.org/r/362309 (https://phabricator.wikimedia.org/T153856) (owner: 10Hashar) [22:57:03] (03PS3) 10Ejegg: Templatize phplint jobs [integration/config] - 10https://gerrit.wikimedia.org/r/363493 [22:59:47] that... didn't fail! [23:00:14] quick, ship it! [23:00:18] any jjb template wizards about to review ? [23:00:46] Antoine is likely long asleep [23:01:13] I can't quite understand why the mwgate project needed me to add phpflavor parameters for the lint part [23:01:32] when it was already using {phpflavor} in a different job [23:02:41] thcipriani: would you be interested in looking at a patch templatizing the phplint jobs? https://gerrit.wikimedia.org/r/363493 [23:02:59] oh boy [23:03:06] :) [23:03:15] it's not actually very big [23:04:15] I can add a follow-on patch to change the naming style so the templated var is offset by dashes as with the other templates [23:04:49] oh, derp, now I see where the phpflavor_images get the phpflavors from [23:04:57] lemme just fix that last bit [23:08:24] oh right, needs images swapped in the template too [23:08:41] sorry, not ready for review! [23:08:47] hrm, well we have phpflavor-php55 nodes, but not phpflavor-php56 nodes, I think this is mostly because php55 nodes are mostly permanent compute nodes whereas other phpflavors are nodepool instances https://integration.wikimedia.org/ci/label/phpflavor-php56/ [23:08:52] ah, ok :) [23:09:15] ejegg uses DebianJessie for node. jessie has php 5.6. [23:11:17] eh, I just saw node label in jjb/job-templates: contintLabsSlave && phpflavor-{phpflavor} [23:11:18] jdlrobson: I tried running it but it was slow as crap so I aborted [23:12:43] thcipriani: so to get a php56 node I have to specify contintLabsSlave && {image} [23:12:50] or... no, those aren't the same [23:12:51] jdlrobson: https://phabricator.wikimedia.org/P5685 [23:13:03] It's got like 27mil rows to count :( [23:13:05] it would be DebianJessie there, not just jessie [23:13:53] right [23:14:45] uhhh.. case statement? [23:15:07] no, sorry [23:15:34] sure would be nice to have phpflavor-php56 tags! [23:16:35] unlesssomething about the impermanance would make that useless [23:18:00] can I just add those tags to integration-slave-jessie-100[12] ? [23:18:05] yeah, I'm digging a bit to see where nodepool adds those tags [23:18:09] I mean, any reason I shouldn't [23:18:12] ? [23:18:55] hmm, they've already got phpflavor-php70 [23:19:39] there's a setting here to add them manually: https://integration.wikimedia.org/ci/computer/integration-slave-jessie-1002/configure [23:19:46] well, that'd mean we have those 2 machines to run lint rather than the entire pool of nodepool machines. [23:20:00] ah, right [23:22:13] there has to be some config in nodepool for this... [23:25:47] welllll, if only the fr-tech jobs are actually running php56lint, maybe we can start with those 2? [23:29:21] I suppose that's fine ¯\_(ツ)_/¯ [23:29:38] cool! [23:30:24] (03PS4) 10Ejegg: Templatize phplint jobs [integration/config] - 10https://gerrit.wikimedia.org/r/363493 [23:31:00] ok, this version only applies phpflavor: to the lint template for the bigger projects, rather than setting it on the project level [23:31:03] ^^ [23:31:54] * thcipriani looks [23:35:56] let's see if that makes the fr-job-switch work [23:36:09] (03PS5) 10Ejegg: Switch all fundraising tests to PHP5.6 [integration/config] - 10https://gerrit.wikimedia.org/r/363478 (https://phabricator.wikimedia.org/T169806) [23:38:34] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: Improve Phabricator Print function so I can print a ticket out and read it - https://phabricator.wikimedia.org/T169788#3410036 (10mmodell) The workaround seems completely valid to me. If someone wants to write the css rules I'll be ha... [23:42:46] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: Improve Phabricator Print function so I can print a ticket out and read it - https://phabricator.wikimedia.org/T169788#3410044 (10demon) I don't think Greasemonkey is an acceptable answer to usability problems :) [23:42:55] hmm, maybe that mediawiki-core-hhvmlint is wrong? https://integration.wikimedia.org/ci/job/integration-jjb-config-diff/7064/consoleFull [23:43:24] the diff looks OK otherwise - it doesn't mess with any of the php55 jobs [23:43:37] and I /think/ the php56 ones are ok [23:44:05] Project beta-scap-eqiad build #162732: 04FAILURE in 27 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/162732/ [23:46:48] 10Release-Engineering-Team (Kanban), 10Diffusion, 10Phabricator (2017-07-05), 10Regression: Unable to browse refs/meta/config in Diffusion - https://phabricator.wikimedia.org/T137354#3410052 (10Paladox) [23:47:25] 10Release-Engineering-Team (Kanban), 10Phabricator: Form 33 should be modified to have the archiving of the git repository in the checklist - https://phabricator.wikimedia.org/T169673#3410053 (10mmodell) 05Open>03Resolved a:03mmodell Done [23:47:31] 10Release-Engineering-Team (Kanban), 10Diffusion, 10Phabricator (2017-07-05), 10Regression: Unable to browse refs/meta/config in Diffusion - https://phabricator.wikimedia.org/T137354#2365912 (10Paladox) tested on https://phab-01.wmflabs.org/r/branch/mediawiki/core;refs/meta/config [23:47:34] gotta relocate, but I think those patches are OK! [23:49:07] 10Release-Engineering-Team (Kanban), 10Diffusion, 10Phabricator (2017-07-05), 10Regression: Unable to browse refs/meta/config in Diffusion - https://phabricator.wikimedia.org/T137354#3410061 (10mmodell) a:05mmodell>03Paladox Awesome, thanks @paladox [23:49:10] RainbowSprinkles when trying to resolve T137354 i was trying to fix it gerrit's side instead of phab sides. lol it woud have been fixed months ago if i released i could do it phabs side :) [23:49:10] T137354: Unable to browse refs/meta/config in Diffusion - https://phabricator.wikimedia.org/T137354 [23:49:23] 10Release-Engineering-Team (Kanban), 10Diffusion, 10Phabricator (2017-07-05), 10Regression: Unable to browse refs/meta/config in Diffusion - https://phabricator.wikimedia.org/T137354#3410064 (10Paladox) Your welcome :) [23:50:29] (03CR) 10Thcipriani: "One nit inline" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/363493 (owner: 10Ejegg) [23:51:34] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: Improve Phabricator Print function so I can print a ticket out and read it - https://phabricator.wikimedia.org/T169788#3410069 (10mmodell) >>! In T169788#3410044, @demon wrote: > I don't think Greasemonkey is an acceptable answer to u... [23:52:55] 10Deployment-Systems, 10Release-Engineering-Team (Kanban): Automate the recurring management of wikitech:Deployments and phab:#train_deployments - https://phabricator.wikimedia.org/T114488#3410073 (10mmodell) p:05Normal>03High [23:55:57] Yippee, build fixed! [23:55:57] Project beta-scap-eqiad build #162733: 09FIXED in 2 min 17 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/162733/ [23:59:01] 10Release-Engineering-Team (Kanban), 10Phabricator (2017-07-05), 10Upstream: Unhandled Exception ("InvalidArgumentException") error when clicking on search link in "Activity Feed" panel - https://phabricator.wikimedia.org/T168108#3410081 (10mmodell)