[02:31:57] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: MW 1.30.0-wmf.10 deployment blockers - https://phabricator.wikimedia.org/T168050#3462602 (10Krinkle) [03:15:33] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [03:55:32] RECOVERY - Puppet errors on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0] [04:21:49] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.30.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T168051#3462662 (10greg) [04:46:33] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [05:56:33] RECOVERY - Puppet errors on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0] [13:46:46] Yippee, build fixed! [13:46:46] Project selenium-VisualEditor » firefox,beta,Linux,BrowserTests build #467: 09FIXED in 2 min 45 sec: https://integration.wikimedia.org/ci/job/selenium-VisualEditor/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/467/ [16:30:07] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Wikipedia-Android-App-Backlog, 10Jenkins, and 2 others: Upgrade CI emulator to API 25 - https://phabricator.wikimedia.org/T150623#3463071 (10Niedzielski) {icon thumbs-up} Fix for screenshot differences (some legit, some questio... [19:10:18] Project selenium-MinervaNeue » chrome,beta,Linux,BrowserTests build #19: 04FAILURE in 21 min: https://integration.wikimedia.org/ci/job/selenium-MinervaNeue/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/19/ [19:53:10] (03Draft2) 10MacFan4000: rm DeepSea [integration/config] - 10https://gerrit.wikimedia.org/r/367041 (https://phabricator.wikimedia.org/T171385) [20:44:38] PROBLEM - Puppet errors on deployment-sca01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [23:45:42] (03PS1) 10Legoktm: Ignore returns in closures for MissingReturn sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367114 (https://phabricator.wikimedia.org/T170765) [23:46:20] 10MediaWiki-Codesniffer, 10Patch-For-Review: MediaWiki.Commenting.FunctionComment.MissingReturn should ignore return in closure - https://phabricator.wikimedia.org/T170765#3463396 (10Legoktm) a:03Legoktm [23:47:52] 10MediaWiki-Codesniffer, 10Patch-For-Review: MediaWiki.Usage.ReferenceThis to strict - https://phabricator.wikimedia.org/T170316#3427037 (10Legoktm) a:03Legoktm [23:54:09] 10MediaWiki-Codesniffer: phpcbf doesn't remove space before ; after removing () from require call - https://phabricator.wikimedia.org/T171125#3454841 (10Legoktm) I can't reproduce this on master, but that would mean d83c7005d652d3a6aedd10be90e2251de28b929b somehow fixed it, which I find doubtful? [23:54:29] (03PS1) 10Legoktm: Add test case to demonstrate T171125 is fixed [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367115 (https://phabricator.wikimedia.org/T171125) [23:59:39] 10MediaWiki-Codesniffer, 10Patch-For-Review: phpcbf doesn't remove space before ; after removing () from require call - https://phabricator.wikimedia.org/T171125#3463417 (10Reedy) Possible related with changes to php_codesniffer too? I was just going to ask if we had a test case for this <3