[00:00:47] Reedy: if you wanna review my open PHPCS patches I wanted to do a new bugfix release today :) [00:05:08] (03CR) 10Reedy: [C: 032] Add test case to demonstrate T171125 is fixed [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367115 (https://phabricator.wikimedia.org/T171125) (owner: 10Legoktm) [00:07:27] legoktm: Have upstream fixed the bugs we've got outstanding? [00:07:54] Dear jerkins, why aren't you gate and submit? [00:07:55] yep :) [00:08:02] they all have dependencies [00:08:24] ahh [00:08:36] (03CR) 10Reedy: [C: 032] Ignore returns in closures for MissingReturn sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367114 (https://phabricator.wikimedia.org/T170765) (owner: 10Legoktm) [00:09:51] (03Merged) 10jenkins-bot: Ignore returns in closures for MissingReturn sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367114 (https://phabricator.wikimedia.org/T170765) (owner: 10Legoktm) [00:09:53] (03Merged) 10jenkins-bot: Add test case to demonstrate T171125 is fixed [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367115 (https://phabricator.wikimedia.org/T171125) (owner: 10Legoktm) [00:10:48] (03PS2) 10Legoktm: Reduce false positives in ReferenceThisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/366504 (https://phabricator.wikimedia.org/T170316) [00:10:54] Reedy: that one too ^ [00:11:10] Yeah, I was just looking at the parallel patches [00:11:59] uh, skip those for now [00:12:26] it needs a little more testing I think [00:18:39] (03CR) 10Reedy: Reduce false positives in ReferenceThisSniff (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/366504 (https://phabricator.wikimedia.org/T170316) (owner: 10Legoktm) [00:18:48] $stackPtr+2 [00:18:53] Should be $stackPtr + 2 surely? [00:19:13] you'd have thought phpcs would have caught that? [00:19:31] I did just go and look if we actually ran phpcs on the phpcs repo :) [00:20:23] Shall I file another bug? :P [00:20:27] (03PS3) 10Legoktm: Reduce false positives in ReferenceThisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/366504 (https://phabricator.wikimedia.org/T170316) [00:21:42] I guess we don't have a sniff for spaces around + [00:22:17] (03CR) 10Reedy: [C: 032] Reduce false positives in ReferenceThisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/366504 (https://phabricator.wikimedia.org/T170316) (owner: 10Legoktm) [00:22:53] (03Merged) 10jenkins-bot: Reduce false positives in ReferenceThisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/366504 (https://phabricator.wikimedia.org/T170316) (owner: 10Legoktm) [00:23:27] 10MediaWiki-Codesniffer: Spacing around + - https://phabricator.wikimedia.org/T171393#3463430 (10Reedy) [00:23:46] (03PS3) 10Reedy: Add Squiz.Classes.SelfMemberReference to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363525 (owner: 10Legoktm) [00:23:59] (03PS1) 10Legoktm: Don't ignore files or paths with "git" in them, only .git [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367117 (https://phabricator.wikimedia.org/T129664) [00:24:25] heh :D [00:24:38] (03CR) 10Reedy: [C: 032] Add Squiz.Classes.SelfMemberReference to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363525 (owner: 10Legoktm) [00:25:15] (03CR) 10jerkins-bot: [V: 04-1] Add Squiz.Classes.SelfMemberReference to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363525 (owner: 10Legoktm) [00:26:09] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 10Patch-For-Review: phpcs not running on all files - https://phabricator.wikimedia.org/T129664#3463446 (10Legoktm) a:03Legoktm @Reedy ran into this last week as well. Our pattern for ignoring .git directories was just `.git`, where the period matched... [00:26:13] (03CR) 10Reedy: [C: 032] Don't ignore files or paths with "git" in them, only .git [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367117 (https://phabricator.wikimedia.org/T129664) (owner: 10Legoktm) [00:26:56] (03Merged) 10jenkins-bot: Don't ignore files or paths with "git" in them, only .git [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367117 (https://phabricator.wikimedia.org/T129664) (owner: 10Legoktm) [00:26:58] (03CR) 10jerkins-bot: [V: 04-1] Add Squiz.Classes.SelfMemberReference to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363525 (owner: 10Legoktm) [00:27:08] heh [00:27:10] I'll go fix that now [00:27:31] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 10Patch-For-Review: phpcs not running on all files - https://phabricator.wikimedia.org/T129664#3463449 (10Reedy) We should probably fix repos (mw core included) with this problem where they have the same/similar exclude ```lang=xml .... [00:28:06] (03PS4) 10Legoktm: Add Squiz.Classes.SelfMemberReference to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363525 [00:28:53] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown, 10Patch-For-Review: phpcs not running on all files - https://phabricator.wikimedia.org/T129664#3463464 (10Legoktm) Once repositories update to the latest version, we can remove the per-repository rules since they'll inherit from the c... [00:29:16] I just made a fix for core :P [00:29:17] https://gerrit.wikimedia.org/r/367119 [00:29:30] The .php ones should be \. too though obvs [00:34:32] re +2 https://gerrit.wikimedia.org/r/363525 ? and then I think we should be good to go... [00:34:35] (03CR) 10Reedy: [C: 032] Add Squiz.Classes.SelfMemberReference to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363525 (owner: 10Legoktm) [00:35:53] Should we be good to bump core up then? [00:36:16] (03Merged) 10jenkins-bot: Add Squiz.Classes.SelfMemberReference to ruleset [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/363525 (owner: 10Legoktm) [00:38:08] Testing it now [00:39:25] (03PS1) 10Legoktm: Don't exclude utils/bootstrap-ci.php in .gitattributes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367121 [00:39:30] legoktm: rofl [00:39:31] 00:34:04 FILE: ...iki-core-phpcs-jessie/src/tests/phpunit/includes/GitInfoTest.php [00:39:31] found a bug >.< [00:39:33] Failed now :D [00:39:37] :D [00:40:12] Might aswell fix it in the same patch [00:40:48] Reedy: also https://gerrit.wikimedia.org/r/367121 [00:45:52] https://gerrit.wikimedia.org/r/#/c/367119/ needs re +2 [00:46:07] (03CR) 10Reedy: [C: 032] Don't exclude utils/bootstrap-ci.php in .gitattributes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367121 (owner: 10Legoktm) [00:48:06] (03Merged) 10jenkins-bot: Don't exclude utils/bootstrap-ci.php in .gitattributes [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367121 (owner: 10Legoktm) [00:48:43] 10MediaWiki-Codesniffer, 10Patch-For-Review: phpcbf doesn't remove space before ; after removing () from require call - https://phabricator.wikimedia.org/T171125#3463473 (10Legoktm) 05Open>03Resolved a:03Legoktm [00:48:46] 10MediaWiki-Codesniffer, 10Patch-For-Review: MediaWiki.Commenting.FunctionComment.MissingReturn should ignore return in closure - https://phabricator.wikimedia.org/T170765#3463475 (10Legoktm) 05Open>03Resolved [00:48:49] 10MediaWiki-Codesniffer, 10Patch-For-Review: MediaWiki.Usage.ReferenceThis to strict - https://phabricator.wikimedia.org/T170316#3463476 (10Legoktm) 05Open>03Resolved [00:56:00] Squiz.Classes.SelfMemberReference.NotUsed is really prevelant in core [00:59:26] (03PS1) 10Legoktm: Release 0.10.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367123 [01:08:51] (03CR) 10Legoktm: [C: 032] Release 0.10.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367123 (owner: 10Legoktm) [01:09:27] (03Merged) 10jenkins-bot: Release 0.10.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/367123 (owner: 10Legoktm) [01:10:11] * [new tag] v0.10.1 -> v0.10.1 [01:45:34] What's SelfMemberReference.NotUsed? [01:48:43] People using class name rather than self::? [01:49:59] I'll have to get those mw-config patches merged. Then see about bumping that repos version up [02:26:08] Reedy: yep [04:33:20] Project selenium-MultimediaViewer » firefox,beta,Linux,BrowserTests build #461: 04FAILURE in 37 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/461/ [06:00:12] 10Continuous-Integration-Config, 10uprightdiff: Add tests for integration/uprightdiff repository - https://phabricator.wikimedia.org/T152578#3463553 (10Legoktm) >>! In T152578#2853896, @hashar wrote: > There are a few dependencies mentioned in the README file: build-essential g++ libopencv-highgui-dev libboost... [07:37:02] PROBLEM - Work requests waiting in Zuul Gearman server https://grafana.wikimedia.org/dashboard/db/zuul-gearman on contint1001 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [140.0] [07:38:27] ^ that's me [09:17:04] legoktm: fortunately it's weekend :) [10:51:58] mmmmmm [10:52:11] the queue at https://integration.wikimedia.org/zuul/ appears to be longer than usual. [11:06:51] aharoni: known [11:07:18] aharoni: codesniffer got upgraded by legoktm earlier [11:08:44] p858snake: thanks [11:28:48] Somebody noticed after all, despite weekend :) [12:09:12] is it me or does there look like there are no tests running on https://integration.wikimedia.org/zuul/ [12:09:13] ? [12:11:21] paladox: there is just too many patches that got sent [12:11:31] oh ok [12:11:32] paladox: apparently 900 extensions patches + 900 related CR+2 [12:11:35] lol [12:11:43] that is alot [12:11:48] so that is like maybe 6000 jobs? [12:11:58] yeh [12:12:38] I will check again in an hour [12:12:44] but it looks all fine from the check I did [12:13:04] ok thanks :) [12:19:46] ACKNOWLEDGEMENT - Work requests waiting in Zuul Gearman server https://grafana.wikimedia.org/dashboard/db/zuul-gearman on contint1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [140.0] amusso Mass changes being made to mediawiki extensions [13:13:31] RECOVERY - Work requests waiting in Zuul Gearman server https://grafana.wikimedia.org/dashboard/db/zuul-gearman on contint1001 is OK: OK: Less than 30.00% above the threshold [90.0] [13:46:02] Project selenium-VisualEditor » firefox,beta,Linux,BrowserTests build #468: 04FAILURE in 2 min 1 sec: https://integration.wikimedia.org/ci/job/selenium-VisualEditor/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/468/ [18:05:18] (03Abandoned) 10XZise: [IMPROV] Support Python 3 in commit message validator [integration/jenkins] - 10https://gerrit.wikimedia.org/r/243131 (owner: 10XZise) [19:18:07] Project selenium-MinervaNeue » firefox,beta,Linux,BrowserTests build #20: 04FAILURE in 29 min: https://integration.wikimedia.org/ci/job/selenium-MinervaNeue/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/20/ [21:22:22] 10Release-Engineering-Team (Kanban): Create code health mailing list - https://phabricator.wikimedia.org/T170963#3449127 (10hashar) Potentially you could reuse the QA list, it is very low traffic nowadays https://lists.wikimedia.org/pipermail/qa/ :] [21:32:42] PROBLEM - Puppet errors on deployment-mathoid is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:33:22] PROBLEM - Puppet errors on deployment-mcs01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:33:56] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:34:04] PROBLEM - Puppet errors on deployment-kafka01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:34:16] PROBLEM - Puppet errors on deployment-ms-be04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:35:12] PROBLEM - Puppet errors on deployment-sca02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:35:16] PROBLEM - Puppet errors on deployment-changeprop is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:35:25] PROBLEM - Puppet errors on deployment-conf03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:35:41] PROBLEM - Puppet errors on deployment-trending01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:35:47] PROBLEM - Puppet errors on deployment-etcd-01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:35:49] PROBLEM - Puppet errors on deployment-sca03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:36:46] PROBLEM - Puppet errors on deployment-pdf01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:37:22] PROBLEM - Puppet errors on deployment-ms-be03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:54:18] PROBLEM - Puppet errors on deployment-urldownloader is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [22:29:15] RECOVERY - Puppet errors on deployment-urldownloader is OK: OK: Less than 1.00% above the threshold [0.0] [22:29:40] 10MediaWiki-Codesniffer: Add rule for unused variables - https://phabricator.wikimedia.org/T114846#3464217 (10Legoktm) This could have caught {T171405}. [22:32:40] 10MediaWiki-Codesniffer: Add rule for unused variables - https://phabricator.wikimedia.org/T114846#3464220 (10Legoktm) [23:17:34] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [23:52:32] RECOVERY - Puppet errors on deployment-pdfrender02 is OK: OK: Less than 1.00% above the threshold [0.0]