[01:24:09] PROBLEM - Puppet staleness on deployment-jobrunner02 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [43200.0] [02:37:33] 10Release-Engineering-Team, 10Operations, 10Ops-Access-Requests, 10User-Addshore: Make @daniel a MediaWiki deployer - https://phabricator.wikimedia.org/T173230#3521809 (10Addshore) [02:58:24] 10Continuous-Integration-Infrastructure, 10Operations, 10Ops-Access-Requests, 10User-Addshore: Requesting access to contint-admins for addshore - https://phabricator.wikimedia.org/T173233#3521821 (10Legoktm) Yes please. I made addshore download and install jenkins-job-builder assuming he could deploy chang... [03:30:36] 10Continuous-Integration-Infrastructure, 10Operations, 10Ops-Access-Requests, 10Patch-For-Review, 10User-Addshore: Requesting access to contint-admins for addshore - https://phabricator.wikimedia.org/T173233#3521846 (10greg) (obvious +1 from me) [03:30:55] addgoat: https://gerrit.wikimedia.org/r/#/q/topic:goatshore+(status:open+OR+status:merged) [03:31:11] I used the wrong name, whatever :) [03:31:44] :D [03:59:01] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<50.00%) [04:46:49] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [05:06:52] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [05:36:49] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [07:19:02] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [08:56:49] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [11:21:14] PROBLEM - Puppet errors on deployment-sca02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:34:31] PROBLEM - Puppet errors on deployment-eventlogging04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [14:08:58] 10Continuous-Integration-Config, 10Scoring-platform-team-Backlog: Have CI merge research/ores/wheels changes - https://phabricator.wikimedia.org/T173251#3522157 (10awight) [14:09:15] (03PS1) 10Addshore: WIP DNM contint-mediawiki-extensions-phan [integration/config] - 10https://gerrit.wikimedia.org/r/371708 [14:47:09] 10Continuous-Integration-Config, 10MinervaNeue: MinervaNeue mwext-doxygen-publish fails - https://phabricator.wikimedia.org/T173255#3522244 (10Reedy) [15:34:09] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [16:12:14] (03PS2) 10Addshore: WIP contint-mediawiki-extensions-phan [integration/config] - 10https://gerrit.wikimedia.org/r/371708 [16:22:20] (03PS3) 10Addshore: contint-mediawiki-extensions-phan [integration/config] - 10https://gerrit.wikimedia.org/r/371708 [17:29:32] (03PS1) 10Legoktm: Run global-set-env for npm-run-{script} so CHROME_BIN is set. [integration/config] - 10https://gerrit.wikimedia.org/r/371731 [17:31:21] James_F: do you have permissions to add people to the github wikimedia org? [17:31:33] goat-g: legoatm does [17:31:43] goat-g: Yes. [17:32:01] greggrossmeier :) [17:43:09] (03PS1) 10Legoktm: Add GoatSniffer ASCII art [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371732 [17:47:00] (03CR) 10Legoktm: [C: 032] Run global-set-env for npm-run-{script} so CHROME_BIN is set. [integration/config] - 10https://gerrit.wikimedia.org/r/371731 (owner: 10Legoktm) [17:48:01] (03Merged) 10jenkins-bot: Run global-set-env for npm-run-{script} so CHROME_BIN is set. [integration/config] - 10https://gerrit.wikimedia.org/r/371731 (owner: 10Legoktm) [17:48:05] (03PS2) 10Legoktm: Add GoatSniffer ASCII art [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371732 [17:51:33] 10Release-Engineering-Team (Kanban), 10Goatification, 10User-greg: Goat ASCII Art - https://phabricator.wikimedia.org/T173234#3522630 (10greg) 05Open>03Resolved a:03greg Patch proposed in goatsniffer, calling this closed. Feel free to open a new task if you have further design considerations or proposals. [17:52:36] (03CR) 10Reedy: [C: 032] Add GoatSniffer ASCII art [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371732 (owner: 10Legoktm) [17:55:59] (03Merged) 10jenkins-bot: Add GoatSniffer ASCII art [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371732 (owner: 10Legoktm) [17:59:28] 10Release-Engineering-Team (Kanban), 10Goatification, 10User-greg: Goat ASCII Art - https://phabricator.wikimedia.org/T173234#3522645 (10greg) 17:57 < paroneaye> |,-__,| 17:57 < paroneaye> "" "" bottom bits ^ [18:00:42] 10Release-Engineering-Team (Kanban), 10Goatification, 10User-greg: Goat ASCII Art - https://phabricator.wikimedia.org/T173234#3522660 (10Reedy) 05Resolved>03Open [18:17:21] (03PS1) 10Legoktm: Add some legs to the goat [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371733 [18:17:30] (03CR) 10Legoktm: [C: 032] Add some legs to the goat [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371733 (owner: 10Legoktm) [18:17:42] 10Release-Engineering-Team (Kanban), 10Goatification, 10User-greg: Goat ASCII Art - https://phabricator.wikimedia.org/T173234#3522694 (10greg) paste update [18:17:53] 10Release-Engineering-Team (Kanban), 10Goatification, 10User-greg: Goat ASCII Art - https://phabricator.wikimedia.org/T173234#3522695 (10greg) 05Open>03Resolved [18:18:08] (03Merged) 10jenkins-bot: Add some legs to the goat [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371733 (owner: 10Legoktm) [18:20:05] (03PS1) 10Legoktm: Release 0.11.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371734 [18:20:25] (03CR) 10Legoktm: [C: 032] Release 0.11.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371734 (owner: 10Legoktm) [18:21:04] (03Merged) 10jenkins-bot: Release 0.11.1 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371734 (owner: 10Legoktm) [18:21:49] (03PS1) 10Greg Grossmeier: Goat: More proportional body [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371736 [18:23:02] (03PS2) 10Legoktm: Goat: More proportional body [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371736 (owner: 10Greg Grossmeier) [18:23:05] (03CR) 10Legoktm: [C: 032] Goat: More proportional body [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371736 (owner: 10Greg Grossmeier) [18:25:16] (03Merged) 10jenkins-bot: Goat: More proportional body [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371736 (owner: 10Greg Grossmeier) [19:18:39] Project selenium-MinervaNeue ยป firefox,beta,Linux,BrowserTests build #74: 04FAILURE in 29 min: https://integration.wikimedia.org/ci/job/selenium-MinervaNeue/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/74/ [19:26:18] 10MediaWiki-Codesniffer: OpeningKeywordBraceSniff false positive? - https://phabricator.wikimedia.org/T173273#3522864 (10Reedy) [19:28:02] 10MediaWiki-Codesniffer: phpcs incorrectly sniffing mediawiki-config docroot - https://phabricator.wikimedia.org/T171510#3522890 (10Reedy) All of the ignores seem to be screwed up... ```lang=xml wmf-config/interwiki.php 10MediaWiki-Codesniffer: phpcs incorrectly sniffing mediawiki-config docroot - https://phabricator.wikimedia.org/T171510#3522891 (10Reedy) p:05Triage>03High [19:33:08] PROBLEM - Free space - all mounts on integration-slave-jessie-android is CRITICAL: CRITICAL: integration.integration-slave-jessie-android.diskspace._mnt.byte_percentfree (No valid datapoints found)integration.integration-slave-jessie-android.diskspace.root.byte_percentfree (<100.00%) [19:34:15] 10MediaWiki-Codesniffer: OpeningKeywordBraceSniff false positive? - https://phabricator.wikimedia.org/T173273#3522903 (10Reedy) New sniff in 0.11.0 https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/5cfb2e97d8e69be3da1114b107fef0d45c06e4eb [20:36:17] (03PS1) 10Catrope: Allow Johanna Mayr (JoHammer) to run the test pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/371757 [21:06:26] 10MediaWiki-Codesniffer: OpeningKeywordBraceSniff false positive? - https://phabricator.wikimedia.org/T173273#3523007 (10Umherirrender) It is about the space after "isset" and before "(" [21:20:10] 10MediaWiki-Codesniffer: OpeningKeywordBraceSniff false positive? - https://phabricator.wikimedia.org/T173273#3523017 (10Reedy) 05Open>03Invalid Oh, duh. I completely couldn't see that [21:20:54] 10MediaWiki-Codesniffer: OpeningKeywordBraceSniff false positive? - https://phabricator.wikimedia.org/T173273#3523020 (10Reedy) Shouldn't `brace` really be `bracket`? I think of brace to be `{` rather than `(` [21:25:39] 10MediaWiki-Codesniffer: OpeningKeywordBraceSniff false positive? - https://phabricator.wikimedia.org/T173273#3523027 (10Umherirrender) brace = {, bracket = [ and parenthesis = ( ? I am not sure, feel free to adjust the message. You can also include the token content to make it clearer. [21:28:03] 10MediaWiki-Codesniffer: OpeningKeywordBraceSniff false positive? - https://phabricator.wikimedia.org/T173273#3523030 (10Reedy) I would say bracket could be `[` or `(` [21:31:38] (03Draft2) 10Reedy: Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) [21:33:21] (03PS3) 10Krinkle: Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) (owner: 10Reedy) [21:33:44] (03CR) 10Krinkle: [C: 032] Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) (owner: 10Reedy) [21:34:19] (03CR) 10jerkins-bot: [V: 04-1] Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) (owner: 10Reedy) [21:36:37] (03PS4) 10Reedy: Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) [21:37:30] (03CR) 10Krinkle: [C: 032] Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) (owner: 10Reedy) [21:38:06] (03CR) 10jerkins-bot: [V: 04-1] Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) (owner: 10Reedy) [21:38:08] 10MediaWiki-Codesniffer, 10Patch-For-Review: MediaWiki.WhiteSpace.OpeningKeywordBrace.WrongWhitespaceBeforeParenthesis unclear messages - https://phabricator.wikimedia.org/T173273#3523065 (10Reedy) 05Invalid>03Open [21:39:14] (03PS5) 10Reedy: Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) [21:41:54] (03PS6) 10Reedy: Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) [21:48:02] (03CR) 10Legoktm: "Can you rename the test files that say "brace" too?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) (owner: 10Reedy) [21:49:17] (03PS7) 10Reedy: Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) [22:02:37] (03CR) 10Umherirrender: [C: 031] Rename OpeningKeywordBracketSniff to OpeningKeywordParenthesisSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/371759 (https://phabricator.wikimedia.org/T173273) (owner: 10Reedy) [22:40:24] (03CR) 10Paladox: [C: 031] Allow Johanna Mayr (JoHammer) to run the test pipeline [integration/config] - 10https://gerrit.wikimedia.org/r/371757 (owner: 10Catrope)