[00:05:27] 10Release-Engineering-Team (Next), 10Scap, 10Phabricator, 10Patch-For-Review: Improve phabricator's deployment process - https://phabricator.wikimedia.org/T172847#3557383 (10mmodell) >>! In T172847#3556355, @Luke081515 wrote: >> immediately reload apache to pick up the new code > IIRC the DB migration scri... [00:17:27] Yippee, build fixed! [00:17:27] Project selenium-Flow » chrome,beta,Linux,BrowserTests build #496: 09FIXED in 1 min 26 sec: https://integration.wikimedia.org/ci/job/selenium-Flow/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/496/ [02:07:37] (03CR) 10Legoktm: "I'm not sure how this handles anonymous classes, but right now we shouldn't have any code that uses that yet. Matching filenames to class " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374026 (https://phabricator.wikimedia.org/T173798) (owner: 10Legoktm) [02:23:20] (03CR) 10Legoktm: "anonymous classes work fine and are not caught caught by this sniff since PHPCS tokenizes them to T_ANON_CLASS." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374026 (https://phabricator.wikimedia.org/T173798) (owner: 10Legoktm) [06:09:52] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [06:33:14] moin hashar! [06:35:34] PROBLEM - Puppet errors on integration-r-lang-01 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [06:52:31] (03CR) 10Legoktm: [C: 04-1] "See inline comments, otherwise looks good as a first implementation." (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/373433 (owner: 10MaxSem) [06:57:19] PROBLEM - Puppet errors on deployment-kafka01 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [07:01:53] addshore: good morning [07:04:48] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [07:10:35] RECOVERY - Puppet errors on integration-r-lang-01 is OK: OK: Less than 1.00% above the threshold [0.0] [07:12:25] 10Release-Engineering-Team (Kanban), 10Operations, 10Phabricator, 10Patch-For-Review: setup/install phab1001.eqiad.wmnet - https://phabricator.wikimedia.org/T163938#3557575 (10mmodell) [07:12:29] 10Release-Engineering-Team (Kanban), 10Phabricator, 10Availability, 10Patch-For-Review, 10WorkType-NewFunctionality: Deploy phabricator to phab2001.codfw.wmnet - https://phabricator.wikimedia.org/T137928#3557576 (10mmodell) [07:12:33] 10Release-Engineering-Team (Kanban), 10Phabricator, 10Patch-For-Review: Switch phabricator production to codfw - https://phabricator.wikimedia.org/T164810#3557574 (10mmodell) 05Open>03stalled [07:13:27] 10Release-Engineering-Team (Kanban), 10Phabricator, 10Availability, 10Patch-For-Review, 10WorkType-NewFunctionality: Deploy phabricator to phab2001.codfw.wmnet - https://phabricator.wikimedia.org/T137928#2566269 (10mmodell) p:05High>03Normal [07:15:47] 10Deployment-Systems, 10Release-Engineering-Team (Kanban): Automate the recurring management of wikitech:Deployments and phab:#train_deployments - https://phabricator.wikimedia.org/T114488#3557578 (10mmodell) @greg ^ how do you feel about doing a trial to evaluate whether Phabricator events will work well for... [07:20:21] hashar: how was your vacation? :) [07:23:24] 10Scap, 10Phabricator: scap should provide a way to skip symlink-swapping in promote - https://phabricator.wikimedia.org/T172486#3557590 (10mmodell) p:05Normal>03Lowest [07:23:54] 10Release-Engineering-Team (Kanban), 10Scap, 10Phabricator: scap should provide a way to skip symlink-swapping in promote - https://phabricator.wikimedia.org/T172486#3557593 (10mmodell) a:03mmodell [07:24:02] 10Release-Engineering-Team (Next), 10Scap, 10Phabricator, 10Patch-For-Review: Improve phabricator's deployment process - https://phabricator.wikimedia.org/T172847#3557595 (10mmodell) [07:24:06] 10Release-Engineering-Team (Kanban), 10Scap, 10Phabricator: scap should provide a way to skip symlink-swapping in promote - https://phabricator.wikimedia.org/T172486#3557594 (10mmodell) 05Open>03stalled [07:24:49] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [07:25:31] 10Release-Engineering-Team (Kanban), 10Scap, 10Phabricator, 10Patch-For-Review: Improve phabricator's deployment process - https://phabricator.wikimedia.org/T172847#3511170 (10mmodell) [07:26:15] 10Deployment-Systems, 10Release-Engineering-Team (Kanban): Automate the recurring management of wikitech:Deployments and phab:#train_deployments - https://phabricator.wikimedia.org/T114488#3557601 (10mmodell) p:05Normal>03High [07:31:36] PROBLEM - Puppet errors on integration-r-lang-01 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [07:32:59] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Performance-Team, 10WebPageTest: Where to trigger WebPageTest jobs? - https://phabricator.wikimedia.org/T166756#3557604 (10hashar) Looks good @Peter and I guess later we can add another instance in the loop and run the various... [07:40:06] Project selenium-Wikibase » chrome,test,Linux,BrowserTests build #466: 15ABORTED in 3 hr 0 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=test,PLATFORM=Linux,label=BrowserTests/466/ [07:40:07] Project selenium-Wikibase » chrome,beta,Linux,BrowserTests build #466: 15ABORTED in 3 hr 0 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/466/ [07:52:33] addshore: vacations went fine, though exhausting. I have relocated to a new city :D [07:53:01] Ooooh, which city hashar ? I'm currently in greece (and here for 1.5 more weeks) [07:53:26] addshore: https://en.wikipedia.org/wiki/Saint-Nazaire home of one of the biggest shipyard in Europe [07:53:42] addshore: have you managed to update / change jobs in Jenkins ? [07:53:43] https://phabricator.wikimedia.org/T173233 [07:59:36] I was going to yesterday, but there was an error with JJB, but apparently that error might be fine? [07:59:39] * addshore will do it today! [08:00:01] looks nice, coastal :D [08:00:35] This is all normal as far as legoktm told me https://www.irccloud.com/pastebin/6PgEI66Q/ [08:01:07] But then I get these 2 exceptions too https://www.irccloud.com/pastebin/cqvP0m5C/ [08:01:30] The fact it says http://localhost:8080/ at the bottom there lead me to think that something was indeed up with the config [08:04:35] but afaik my jenkins_jobs.ini is in the right place and looks fine [08:05:27] addshore: checking [08:05:58] ah yeah you need to craft a config file for jjb [08:06:06] * addshore has O_o [08:06:20] that points to url=https://integration.wikimedia.org/ci [08:06:25] and has the username + API token [08:06:38] /etc/jenkins_jobs/jenkins_jobs.ini, not found. Using default config values. [08:06:47] https://usercontent.irccloud-cdn.com/file/grauExel/image.png [08:06:57] yup [08:06:57] I dont have a /etc .. [08:07:08] jenkins-jobs --conf foobar.ini [08:07:20] its in ./jenkins-job-builder/etc like the docs say :D [08:07:24] I cant remember off hand which paths it is trying to look in [08:07:30] aaaah, okay, I have to add the conf location? [08:07:37] * addshore tries that [08:08:00] yeh, that looks better [08:08:08] user_conf = os.path.join(os.path.expanduser('~'), '.config', [08:08:08] 'jenkins_jobs', 'jenkins_jobs.ini') [08:08:13] so potentially you can add a: [08:08:23] ~/.config/jenkins_jobs/jenkins_jobs.ini [08:08:50] (side note: the ci-admins group in puppet grant you shell access / sudo rights on the contint1001 machine to reload zuul among other things) [08:09:36] yeh, I already re\d through a bunch of the docs and managed to ssh into a nodepool instance etc :D [08:10:21] sweet, so jenkins-jobs --conf ./etc/jenkins_jobs.ini test config/ -o output/ worked [08:11:21] \O/ [08:11:34] RECOVERY - Puppet errors on integration-r-lang-01 is OK: OK: Less than 1.00% above the threshold [0.0] [08:11:42] for nodepool instances, ideally we should add LDAP to them [08:13:25] then we are willing to swap some jobs to Docker :D [08:14:52] :D [08:15:03] right, let me just try and redeploy what is already deployed then :) [08:15:26] "jenkins-jobs --conf etc/jenkins_jobs.ini update config/" ??? right? [08:16:42] or do you generally just do it job by job? [08:16:57] job by job usually [08:17:14] okay, in that case let me try the job I actually want to deploy :D [08:17:24] else it hits jenkins ask for the XML config of all jobs [08:17:27] (03PS4) 10Addshore: Get phan version from composer.json [integration/config] - 10https://gerrit.wikimedia.org/r/371097 [08:17:38] keep a cache of their md5sum [08:17:45] and then only update jobs that have been changed [08:18:01] so in theory you can run the command you ran, and it magically only updates what needs to be updated [08:18:08] aaaah [08:18:09] but I often just pass the list of jobs I wanna update [08:18:19] and you can use wild card (based on fnmatch) [08:18:30] eg *-jessie [08:22:55] quick afk / nature's call etc [08:35:08] okay, so this time [08:35:08] jenkins-jobs --conf etc/jenkins_jobs.ini update config/ 'mwext-php70-phan-jessie' [08:35:13] urllib.error.HTTPError: HTTP Error 403: Forbidden [08:35:18] jenkins.JenkinsException: Error in request. Possibly authentication failed [403]: Forbidden [08:35:22] let me make sure my key is correct [08:35:56] hmm, yep defo correct [08:39:09] I don't need to add a public key to jenkins or anything do I? (I see there is a place to add one) [08:40:04] back [08:40:22] addshore: that is not your password, but an http API key [08:40:46] Yup, I got the api key from https://integration.wikimedia.org/ci/user/addshore/configure as is in the docs [08:40:51] https://integration.wikimedia.org/ci/user/addshore/configure [08:40:52] ok [08:41:05] so maybe there is something useful in jenkins logs [08:41:13] contint1001.wikimedia.org /var/log/jenkins/jenkins.log [08:41:31] ack [08:41:49] also you might want to try upper case vs lowercase [08:41:52] Addshore vs addshore [08:41:56] oooooh [08:41:56] it might be confused [08:42:28] upeprcase also 403 [08:42:32] :( [08:42:50] and you got url=https://integration.wikimedia.org/ci/ [08:42:54] ? [08:43:17] yup [08:43:30] contint1001.eqiad.wmnet? [08:43:36] cant ssh there [08:43:37] While serving https://integration.wikimedia.org/ci/job/mwext-php70-phan-jessie/config.xml: hudson.security.AccessDeniedException2: addshore is missing the Job/Configure permission [08:43:44] found that in https://integration.wikimedia.org/ci/log/all :D [08:43:45] oooh [08:44:15] is there some other set of groups on jenkins itself? [08:44:46] ah I have seen that in the spam of mail this morning [08:44:59] so we used to grant job configuration rights to anyone in lda [08:44:59] p [08:45:09] https://phabricator.wikimedia.org/T169557 changed that to restrict it solely to CI admins [08:45:26] haha, so another group I need to be in? xD [08:45:27] via a "ciadmin" group in LDAP [08:45:41] which obviously is not the same as the ci-admins group in the admin data.yaml [08:45:50] haha, yeh, I cant see https://integration.wikimedia.org/ci/log/all either [08:47:59] so we gotta add you to the ldap group [08:49:33] can you do that? :D [08:49:37] Or should I file a ticket? :( [08:49:51] 10Continuous-Integration-Infrastructure, 10Operations, 10Ops-Access-Requests, 10Patch-For-Review, 10User-Addshore: Requesting access to contint-admins for addshore - https://phabricator.wikimedia.org/T173233#3557706 (10hashar) The modules/admin `contint-admins` grants shell access to the contint machine... [08:50:01] so, to do CI admin stuff, you need 1, the gerrit group, 2, the ldap group, 3 the modules/admin group [08:50:03] xD [08:50:11] I guess we can reopen https://phabricator.wikimedia.org/T173233 and assk for you to be added to cn=ciadmin [08:50:16] I dont think I can write to LDAP [08:50:31] yeah correct [08:50:38] though now that we have a ciadmin group in LDAP [08:50:50] reopened [08:50:52] 10Continuous-Integration-Infrastructure, 10Operations, 10Ops-Access-Requests, 10Patch-For-Review, 10User-Addshore: Requesting access to contint-admins for addshore - https://phabricator.wikimedia.org/T173233#3557712 (10Addshore) 05Resolved>03Open [08:50:52] we can have Gerrit 'integration' group to auto include ldap/ciadmin [08:51:10] addshore: moritzm would be able to add you to the ldap group [08:51:16] (03Abandoned) 10Paladox: Begin the migration for all nodepool jobs to be run by all users [integration/config] - 10https://gerrit.wikimedia.org/r/328054 (owner: 10Paladox) [08:51:18] seems he did the change on T169557 previously [08:52:29] (03PS8) 10Paladox: Create a test that deploy's jjb changes without needing to ssh in and deploy your self [integration/config] - 10https://gerrit.wikimedia.org/r/323198 [08:52:33] !log gerrit: added ldap/ciadmin to the 'integration' group. T169557 T173233 [08:52:34] (03PS16) 10Paladox: Create operations-puppet-catalog-compiler job in jjb [integration/config] - 10https://gerrit.wikimedia.org/r/325064 (https://phabricator.wikimedia.org/T97513) [08:52:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:52:38] T173233: Requesting access to contint-admins for addshore - https://phabricator.wikimedia.org/T173233 [08:57:35] (03PS7) 10Paladox: [operations-puppet-catalog-compiler] Adding it to jenkins job builder [integration/config] - 10https://gerrit.wikimedia.org/r/315994 (https://phabricator.wikimedia.org/T97513) [08:57:40] (03PS4) 10Paladox: Install postgresql on ci-image-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/316475 (https://phabricator.wikimedia.org/T39602) [08:58:30] (03CR) 10jerkins-bot: [V: 04-1] [operations-puppet-catalog-compiler] Adding it to jenkins job builder [integration/config] - 10https://gerrit.wikimedia.org/r/315994 (https://phabricator.wikimedia.org/T97513) (owner: 10Paladox) [08:58:45] (03PS5) 10Paladox: Install postgresql on ci-image-jessie [integration/config] - 10https://gerrit.wikimedia.org/r/316475 (https://phabricator.wikimedia.org/T39602) [08:59:17] hashar hi, there seems to be a git failurer on https://integration.wikimedia.org/ci/job/integration-jjb-config-diff/7187/console [08:59:24] 08:57:45 stderr: remote: fatal: Not a git repository: '.' [08:59:25] 08:57:45 remote: aborting due to possible repository corruption on the remote side. [08:59:25] 08:57:45 fatal: protocol error: bad pack header [08:59:55] (03CR) 10Paladox: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/315994 (https://phabricator.wikimedia.org/T97513) (owner: 10Paladox) [09:00:34] (03PS4) 10Paladox: Add php7 pipeline for zuul [integration/config] - 10https://gerrit.wikimedia.org/r/313213 (https://phabricator.wikimedia.org/T144872) [09:00:56] (03Abandoned) 10Paladox: [DonationInterface] Switch jenkins tests to extension-unittests-composer [integration/config] - 10https://gerrit.wikimedia.org/r/307543 (owner: 10Paladox) [09:01:08] (03Abandoned) 10Paladox: [DonationInterface] Adding composer-test test [integration/config] - 10https://gerrit.wikimedia.org/r/309456 (owner: 10Paladox) [09:01:46] paladox: hello. who knows what might have happenend. Retry ? :D [09:01:50] I am in a conf call [09:02:00] Ok, yep retrying. [09:03:34] works [09:04:09] 10Continuous-Integration-Infrastructure, 10Operations, 10Ops-Access-Requests, 10Patch-For-Review, 10User-Addshore: Requesting access to contint-admins for addshore - https://phabricator.wikimedia.org/T173233#3557721 (10Addshore) Per IRC perhaps @greg needs to sign off on this. > <•moritzm> addshore: su... [09:04:47] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [09:05:42] (03Abandoned) 10Paladox: In node-4.3 clone under src [integration/config] - 10https://gerrit.wikimedia.org/r/290702 (https://phabricator.wikimedia.org/T130208) (owner: 10Paladox) [09:05:55] (03Abandoned) 10Paladox: Add script that publishes VisualEditors demos [integration/config] - 10https://gerrit.wikimedia.org/r/279738 (owner: 10Paladox) [09:06:07] (03Abandoned) 10Paladox: [FundraisingEmailUnsubscribe] Add npm test and composer-test [integration/config] - 10https://gerrit.wikimedia.org/r/280139 (owner: 10Paladox) [09:19:20] 10Release-Engineering-Team (Kanban), 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 2 others: Undefined index: rc_logid in includes/changes/RecentChange.php on line 338 - https://phabricator.wikimedia.org/T172433#3557784 (10mmodell) 05Open>03Resolved a:... [10:32:35] addshore: I dont think greg will be around today [10:32:36] PROBLEM - Puppet errors on integration-r-lang-01 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [10:32:42] oh :( [10:33:52] and ops require a manager to approve access rights :D [10:35:19] bah [10:35:48] so right now I can turn off jenkins and probably change the config on the server, but not actually dpeloy it using the lovely jjb ;) [10:37:11] 10Continuous-Integration-Infrastructure, 10Operations, 10Ops-Access-Requests, 10Patch-For-Review, 10User-Addshore: Requesting access to contint-admins for addshore - https://phabricator.wikimedia.org/T173233#3557926 (10hashar) @MoritzMuehlenhoff this task is to grant @addshore access to the CI machines.... [10:37:17] yeah i have add moritz to the task and wrote a summary [10:37:21] ;D [10:37:31] (03CR) 10Giuseppe Lavagetto: [C: 04-1] "The current settings of the job are different from the ones set up here. please check what's live right now." [integration/config] - 10https://gerrit.wikimedia.org/r/325064 (https://phabricator.wikimedia.org/T97513) (owner: 10Paladox) [10:37:45] and surely having to deal with permissions in both LDAP and modules/admin is going to cause a bunch of headhaches :d [10:38:21] familly is back home. Time for lunch etc & [10:45:50] 10Release-Engineering-Team, 10Phabricator-Bot-Requests: Avatar for jenkins-bot to ease recognition - https://phabricator.wikimedia.org/T173877#3557958 (10hashar) In CI, that is Zuul submitting the changes in Gerrit with the `jenkins-bot` user. Gerrit crafts the merge message with: commit f315c650f62097b80fd0... [11:00:36] 10Continuous-Integration-Infrastructure, 10Operations, 10Ops-Access-Requests, 10Patch-For-Review, 10User-Addshore: Requesting access to contint-admins for addshore - https://phabricator.wikimedia.org/T173233#3558082 (10MoritzMuehlenhoff) Ok, makes sense. I've added @addhore to cn=ciadmin. [11:07:56] hasharLunch: yay! [11:08:04] I'll give this jjb thing another go! [11:12:34] RECOVERY - Puppet errors on integration-r-lang-01 is OK: OK: Less than 1.00% above the threshold [0.0] [11:19:37] It worked :D [11:22:29] 10Continuous-Integration-Infrastructure, 10Operations, 10Ops-Access-Requests, 10Patch-For-Review, 10User-Addshore: Requesting access to contint-admins for addshore - https://phabricator.wikimedia.org/T173233#3558273 (10Addshore) 05Open>03Resolved Looks like everything is now working! [11:23:39] (03CR) 10Addshore: [C: 04-1] "-1 per https://integration.wikimedia.org/ci/job/mwext-php70-phan-jessie/3960/console" [integration/config] - 10https://gerrit.wikimedia.org/r/371097 (owner: 10Addshore) [11:35:47] (03PS5) 10Addshore: Get phan version from composer.json [integration/config] - 10https://gerrit.wikimedia.org/r/371097 [11:39:22] (03CR) 10Addshore: "So, as far as I can tell this change works..." [integration/config] - 10https://gerrit.wikimedia.org/r/371097 (owner: 10Addshore) [11:40:40] etsy/phan 0.8.5 requires ext-ast ^0.1.4 -> the requested PHP extension ast has the wrong version (0.1.2) installed. [11:41:01] So I guess the image for nodepool needs to be rebuild with the newer version of ext-ast to be able to use phan 0.8.5! [11:41:07] * addshore reads more docs [11:53:19] (03PS4) 10Addshore: contint-mediawiki-extensions-phan [integration/config] - 10https://gerrit.wikimedia.org/r/371708 [12:11:05] (03CR) 10Addshore: [C: 04-1] "So I took another look at this and ended up having more questions than answers to previous questions...." [integration/config] - 10https://gerrit.wikimedia.org/r/371708 (owner: 10Addshore) [12:12:16] (03PS5) 10Addshore: WIP Docker: contint-mediawiki-extensions-phan [integration/config] - 10https://gerrit.wikimedia.org/r/371708 [12:14:31] meh [12:15:04] castor isnt the 'right' solution there :/ [12:17:06] (03PS1) 10Addshore: Fix typo in jjb/mediawiki-extensions.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/374313 [12:17:23] (03PS2) 10Addshore: Fix typo in jjb/mediawiki-extensions.yaml comment [integration/config] - 10https://gerrit.wikimedia.org/r/374313 [12:17:40] (03CR) 10Addshore: [C: 032] Fix typo in jjb/mediawiki-extensions.yaml comment [integration/config] - 10https://gerrit.wikimedia.org/r/374313 (owner: 10Addshore) [12:18:41] (03Merged) 10jenkins-bot: Fix typo in jjb/mediawiki-extensions.yaml comment [integration/config] - 10https://gerrit.wikimedia.org/r/374313 (owner: 10Addshore) [12:26:30] 10Continuous-Integration-Infrastructure, 10User-Addshore: Upgrade php-ast for CI nodepool image to ^0.1.4 (currently 0.1.2) - https://phabricator.wikimedia.org/T174338#3558351 (10Addshore) [12:30:22] 10Continuous-Integration-Infrastructure, 10User-Addshore: Upgrade php-ast for CI nodepool image to ^0.1.4 (currently 0.1.2) - https://phabricator.wikimedia.org/T174338#3558366 (10Addshore) 05Open>03stalled It looks like only 0.1.2 is available on surry currently :( https://packages.sury.org/php/pool/main/p... [12:31:53] 10Continuous-Integration-Config, 10User-Addshore: Allow use of phan 0.8.5 in wikimedia CI - https://phabricator.wikimedia.org/T174339#3558368 (10Addshore) [12:32:24] 10Continuous-Integration-Config, 10User-Addshore: Allow use of phan 0.8.5 in wikimedia CI - https://phabricator.wikimedia.org/T174339#3558380 (10Addshore) [12:32:27] 10Continuous-Integration-Infrastructure, 10User-Addshore: Upgrade php-ast for CI nodepool image to ^0.1.4 (currently 0.1.2) - https://phabricator.wikimedia.org/T174338#3558379 (10Addshore) [12:35:11] 10Continuous-Integration-Config, 10User-Addshore: Allow use of phan 0.8.5 in wikimedia CI - https://phabricator.wikimedia.org/T174339#3558390 (10Addshore) 05Open>03stalled A script to allow fetching a specified phan version was added in https://gerrit.wikimedia.org/r/#/c/371095/ This is used in https://ger... [12:35:24] (03PS6) 10Addshore: Get phan version from composer.json [integration/config] - 10https://gerrit.wikimedia.org/r/371097 (https://phabricator.wikimedia.org/T174339) [12:36:51] (03CR) 10Addshore: [C: 04-1] "It looks like in principle this works, but WMF CI needs a newer version of php-ast in order to make this useful..." [integration/config] - 10https://gerrit.wikimedia.org/r/371097 (https://phabricator.wikimedia.org/T174339) (owner: 10Addshore) [12:37:25] spm spm spm [12:38:10] /ignore addshore :P [12:40:24] yeh, something like that :P [12:40:58] welcome back hashar :D [12:41:34] I am too old to get work after vacations [12:41:39] I should retire :D [12:41:44] NOOOOOO [12:41:48] unless.... tomato farm.... [12:42:28] I can't figure out how to make docker images nice for this mediawiki stuff D: [12:42:49] hmm [12:43:58] addshore: you dont need that much for mw don't you? [12:44:24] during the hackathon I crafted a rough docker / python script to run tests [12:44:34] integration/quibble.git [12:44:45] I gotta come back to it [12:46:42] *looks* [12:47:17] I dont find it :P [12:47:38] oh, its just not mirrored to github [12:50:25] I havent used it since the hackathon though [12:51:09] so, what does it do exactly? I actually cant find a link to the source, cant find it in diffusion either! [12:51:44] git clone https://gerrit.wikimedia.org/r/p/integration/quibble.git [12:51:58] I didnt want to have to clone it :p [12:51:59] it has a very basic dockerfile image [12:52:02] but.... fine..... :P [12:52:20] the python wrapper then does magic to run the mediawiki tests :D [12:53:53] all in all [12:54:07] I am not fan of docker as a provisionning tool [12:56:00] hashar: is that for phpunit stuff only or? [12:56:30] yup [12:56:43] I tried the karma/qunit tests but was hitting a wall [12:57:22] I have been trying a totally different route with phan https://gerrit.wikimedia.org/r/#/c/371708/5/dockerfiles/contint-mediawiki-extensions-phan/Dockerfile & https://gerrit.wikimedia.org/r/#/c/371708/5/dockerfiles/contint-mediawiki-extensions-phan/run.sh [12:58:21] yeah so [12:58:31] that is what I meant: bunch of commands in DockerFile :D [12:58:48] the hardest bit I found was, at test run time, I want mediawiki & extensions to be up to date / at the correct depend-on versions [12:59:19] zuul-cloner supposedly has all the logic for that [12:59:32] it does more or less what you have in run.sh [12:59:34] yeh, I have a todo in there and a comment saying TODO use zuul-cloner [12:59:39] but I havn't used it before / dont know how :D [12:59:52] but really [12:59:56] we need a docker base image for mediawiki [13:00:06] that already provides bunch of what you defined in https://gerrit.wikimedia.org/r/#/c/371708/5/dockerfiles/contint-mediawiki-extensions-phan/Dockerfile [13:00:08] we do have a docker base image for mediawiki now ;) [13:00:25] but yeh, Once I got to creating a second docker test I was going to factor things out [13:00:35] but for now I guess it makes sense to just keep it all in there [13:00:40] yes !!! :) [13:00:41] *docker job [13:00:44] makes things easier [13:01:13] so, how do I use this zuul cloner stuff? and I'm guessing I can use it if I say, run the docker image locally? [13:01:20] also in integration/quibble we went with the route of using a git mirror/cache on the host running the image [13:01:23] it just talks to gerrit right? nothing internal to the cluster? [13:01:53] yup [13:02:03] "git mirror/cache on the host running the image" hehe, I was thinking that, see my comment on my patch "Is there a location on disk on the host machine for the docker jobs to get mediawiki from? Or is the ZUUL_URL location really the best place? [13:02:03] " [13:02:20] 10Gerrit: Create a repository for a tool called Checkers - https://phabricator.wikimedia.org/T174281#3558465 (10MarcoAurelio) I added it to the [[ https://www.mediawiki.org/w/index.php?title=Gerrit/New_repositories/Requests/Entries&diff=2544606&oldid=2541878 | mediawiki.org page ]]. Not sure if we're still using... [13:02:22] so the idea is that the host running the docker image would have something like [13:02:30] /srv/cache/git/mediawiki/core.git [13:02:40] then we can bind mount that READ ONLY from the host to the docker instance [13:02:41] yup [13:02:53] and inside the docker instance, zuul-cloner can be told to clone from that as a reference [13:02:58] (git clone --reference) [13:03:01] yup [13:03:13] it is going to do a full copy of the files, but that is local to the host/machine so that is fast enough [13:03:30] alternatively, have mediawiki git repo already shipped in the Docker image [13:03:54] there is a docker image for operations/puppet.git tests, I am not sure which route has been taken. Probably shipps the git repo directly in the docker image [13:03:56] yeh, so right now mine ships an oldish version of mediawiki.git inside the image [13:04:31] yep, it ships a copy of puppet in the image [13:07:55] so you can probably do the same :D [13:08:11] then once the instance boots, the git repos get to be refreshed from Gerrit [13:08:12] so hashar you may know the answer to this git foo question [13:08:15] (git fetch ) [13:08:23] in the image right now I clone from gerrit.wikimedia.org... [13:08:26] and checked out to whatever branch / patch is being targetted [13:08:49] in my entry point I want to change the remote to whatever remote is passed in and then just do a small git pull to pull it up to date, what exactly should I do [13:09:01] right now I set-url and the git pull, but that seems to pull far to many objects [13:09:13] maybe I should just look at this zuul-cloner thing instead of looking at thats though [13:09:26] you dont even need to change the remote [13:09:31] you can fetch directly: [13:09:31] ack [13:09:39] git fetch https://your/remote/ refs/foo/bar [13:09:48] git then do some magic [13:09:50] okay [13:09:58] and you can fetch specific ref to a specific place [13:10:30] git fetch https://your/remote/ +refs/heads/master:refs/origin/master [13:11:02] alternative is to use zuul-cloner directly [13:11:14] but it rquires a bunch of env variables or options to be set [13:11:36] hmm, but those env vars are already going to be passed in by jenkins right? [13:11:49] ahh, that git fetch thing worked awesomely and was super quick :D [13:12:05] !!! [13:12:19] yeah Jenkins would pass the var [13:12:30] ZUUL_PROJECT ZUUL_BRANCH ZUUL_URL etc [13:12:31] but i guess if people want to use the image themselves it is a pain in the arse [13:12:46] yeh so right now you can run this image with the following: [13:12:48] https://www.irccloud.com/pastebin/HSP5IyCe/ [13:13:35] Should I be running a composer update for core or using mediawiki-vendor repo? O_o [13:13:51] ;]]] [13:13:56] in theory [13:14:01] for master branch: both [13:14:09] for wmf/xxx branches vendor [13:14:13] bah [13:14:14] for REL branches composer [13:14:22] * addshore quickly times a run of his job so far [13:14:30] but that is all a bit messy [13:14:38] most probably you can use vendor [13:14:52] which provides the deps in a single git command and should be fast [13:15:08] (compared to having composer to fetch from packagist.org + lookup versions/depenendencies + cache stuff + install etc) [13:15:21] so yeah, just add mediawiki/vendor to the list [13:15:23] BUT then [13:15:31] you would miss the dependencies listed in require-dev [13:15:38] so you still have to lookup the dev dependencies :( [13:15:58] grabbing a coffee [13:16:03] so, the good thing is, in the image I can have most of the deps precached [13:16:09] If I want [13:16:23] yup! [13:16:37] brb* [13:16:47] :D [13:24:45] back [13:25:33] hashar: where are the docs for this zuul cloner thing then? [13:26:39] In the end I guess we will use templating for all of these docker images, for example you can have a step which is called install-zuul-cloner, and use that step in many different images etc. [13:28:04] (03CR) 10Hashar: [C: 032] [EmailDiff] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/371608 (owner: 10Umherirrender) [13:29:00] (03Merged) 10jenkins-bot: [EmailDiff] Add npm job [integration/config] - 10https://gerrit.wikimedia.org/r/371608 (owner: 10Umherirrender) [13:32:38] (03CR) 10Hashar: [C: 032] "Yup. I guess when one day we had support for PostgreSQL we would standardize on using postgresql, not postgre." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/316231 (owner: 10Paladox) [13:33:15] addshore: ahh templating sounds like a good thing [13:33:21] or you know [13:33:26] we could just use shell scripts :] [13:33:41] Where does slave-scripts/etc/zuul-clonemap.yaml live now? [13:33:46] hashar: yeh, can just use shell scripts! [13:34:05] so [13:34:43] something like: [13:34:48] pip install git+https://gerrit.wikimedia.org/r/p/integration/zuul.git@patch-queue/debian/precise-wikimedia#egg=zuul [13:35:09] and that installed the zuul-cloner command? [13:35:13] *installs [13:35:13] then zuul-cloner requires a bunch of parameters which are documented in the inline help -zuul-cloner --help [13:35:21] that installs the zuul server + merger + cloner [13:35:54] https://docs.openstack.org/infra/zuul/cloner.html [13:35:56] is the doc [13:36:09] the clone map thing, is to route the Gerrit project names to specific paths [13:36:15] so you get mediawiki/core under /srv [13:36:24] and mediawiki/extensions/Foo at /srv/extensions/Foo [13:36:33] the clone map is a yaml file in integration/jenkins [13:36:54] https://github.com/wikimedia/integration-jenkins/blob/master/etc/zuul-clonemap.yaml [13:37:10] ( integration/jenkins.git ) being a place where we put misc utilities / config files etc [13:37:16] since we dont have access to puppet [13:37:55] (03CR) 10Hashar: [C: 032] Whitelist second email of Kghbln [integration/config] - 10https://gerrit.wikimedia.org/r/372181 (owner: 10Umherirrender) [13:38:37] (03CR) 10Hashar: [C: 032] [Survey][PhpTagsSPARQL] Make unit tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/369968 (owner: 10Umherirrender) [13:39:30] (03PS4) 10Hashar: Drop script mw-install-postgre since it is a duplicate of mw-install-postgresql [integration/jenkins] - 10https://gerrit.wikimedia.org/r/316231 (owner: 10Paladox) [13:39:39] (03CR) 10Hashar: [C: 032] Drop script mw-install-postgre since it is a duplicate of mw-install-postgresql [integration/jenkins] - 10https://gerrit.wikimedia.org/r/316231 (owner: 10Paladox) [13:39:51] (03Merged) 10jenkins-bot: Whitelist second email of Kghbln [integration/config] - 10https://gerrit.wikimedia.org/r/372181 (owner: 10Umherirrender) [13:39:52] (03Merged) 10jenkins-bot: [Survey][PhpTagsSPARQL] Make unit tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/369968 (owner: 10Umherirrender) [13:40:36] (03Merged) 10jenkins-bot: Drop script mw-install-postgre since it is a duplicate of mw-install-postgresql [integration/jenkins] - 10https://gerrit.wikimedia.org/r/316231 (owner: 10Paladox) [13:43:11] okay, I might keep looking at the zuul-cloner stuff this eve [13:43:20] looks like it just got windy so I'm gonna head off :D [13:43:21] tata for now! [13:43:27] thanks as always for the help! [13:49:49] addshore: have a good ride :))) [13:50:02] :D [13:52:11] Project selenium-VisualEditor » firefox,beta,Linux,BrowserTests build #505: 04FAILURE in 8 min 10 sec: https://integration.wikimedia.org/ci/job/selenium-VisualEditor/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/505/ [14:09:58] (03PS1) 10Hashar: Remove wikimedia/fundraising/php-queue [integration/config] - 10https://gerrit.wikimedia.org/r/374323 (https://phabricator.wikimedia.org/T163962) [14:15:23] (03CR) 10Hashar: [C: 032] Remove wikimedia/fundraising/php-queue [integration/config] - 10https://gerrit.wikimedia.org/r/374323 (https://phabricator.wikimedia.org/T163962) (owner: 10Hashar) [14:15:52] (03Merged) 10jenkins-bot: Remove wikimedia/fundraising/php-queue [integration/config] - 10https://gerrit.wikimedia.org/r/374323 (https://phabricator.wikimedia.org/T163962) (owner: 10Hashar) [14:28:09] (03PS3) 10Hashar: Marvin: add NPM template [integration/config] - 10https://gerrit.wikimedia.org/r/370678 (https://phabricator.wikimedia.org/T172904) (owner: 10Niedzielski) [14:29:07] (03CR) 10Hashar: [C: 032] "Using the stock npm template was fine though a side effect is that the repo would end up in the same Zuul queue as other repositories shar" [integration/config] - 10https://gerrit.wikimedia.org/r/370678 (https://phabricator.wikimedia.org/T172904) (owner: 10Niedzielski) [14:30:56] (03Merged) 10jenkins-bot: Marvin: add NPM template [integration/config] - 10https://gerrit.wikimedia.org/r/370678 (https://phabricator.wikimedia.org/T172904) (owner: 10Niedzielski) [14:35:39] 10Continuous-Integration-Config, 10Marvin: Enable CI Jenkins job test voting - https://phabricator.wikimedia.org/T172904#3558729 (10hashar) [14:36:40] (03CR) 10Hashar: [C: 032] Add SendGrid extension to Jenkins test [integration/config] - 10https://gerrit.wikimedia.org/r/373408 (https://phabricator.wikimedia.org/T174247) (owner: 10D3r1ck01) [14:37:32] (03Merged) 10jenkins-bot: Add SendGrid extension to Jenkins test [integration/config] - 10https://gerrit.wikimedia.org/r/373408 (https://phabricator.wikimedia.org/T174247) (owner: 10D3r1ck01) [14:54:33] (03CR) 10Thcipriani: "> Defining an empty mw object won't suffice given it will still fail" [integration/docroot] - 10https://gerrit.wikimedia.org/r/373667 (https://phabricator.wikimedia.org/T174058) (owner: 10Thcipriani) [14:54:54] !log integration: rebase integration puppet master. Got a conflict due to r -> r_lang renaming ( https://gerrit.wikimedia.org/r/#/c/363337/ ) [14:54:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:05:56] 10Continuous-Integration-Config, 10Africa-Wikimedia-Developers, 10MediaWiki-extensions-SendGrid, 10Patch-For-Review: Integrating SendGrid MW extension in to Jenkins - https://phabricator.wikimedia.org/T174247#3558809 (10D3r1ck01) Thanks for merging @hashar. Welcome back Sir :) [15:06:12] 10Continuous-Integration-Config, 10Africa-Wikimedia-Developers, 10MediaWiki-extensions-SendGrid, 10Patch-For-Review: Integrating SendGrid MW extension in to Jenkins - https://phabricator.wikimedia.org/T174247#3558811 (10D3r1ck01) 05Open>03Resolved [15:12:00] 10Release-Engineering-Team (Kanban), 10Scap, 10Phabricator, 10Patch-For-Review: Improve phabricator's deployment process - https://phabricator.wikimedia.org/T172847#3558817 (10Luke081515) In case it's useful: There's a read-only mode too. [15:18:49] (03CR) 10Hashar: "Seems to me we should stop including the Jquery that comes from mediawiki.org and instead ship a minified jquery. That should not be too " [integration/docroot] - 10https://gerrit.wikimedia.org/r/373667 (https://phabricator.wikimedia.org/T174058) (owner: 10Thcipriani) [15:19:49] 10Deployment-Systems, 10Release-Engineering-Team (Kanban), 10Scap (Scap3-Adoption-Phase1), 10scap2, and 3 others: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner) - https://phabricator.wikimedia.org/T129148#3558837 (10Krinkle) [15:21:16] 10Deployment-Systems, 10Release-Engineering-Team (Kanban), 10Scap (Scap3-Adoption-Phase1), 10scap2, and 3 others: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner) - https://phabricator.wikimedia.org/T129148#2096570 (10Krinkle) [15:40:03] (03CR) 10Hashar: [C: 032] [SemanticGenealogy] Needs SemanticMediaWiki for unit tests [integration/config] - 10https://gerrit.wikimedia.org/r/371605 (owner: 10Umherirrender) [15:41:19] (03CR) 10Reedy: "This isn't going to work though, is it? The SemanticMediaWiki extension repo is blanked" [integration/config] - 10https://gerrit.wikimedia.org/r/371605 (owner: 10Umherirrender) [15:41:56] (03CR) 10Hashar: [C: 032] Enable jenkins (without any tests) on wheels repo of ORES [integration/config] - 10https://gerrit.wikimedia.org/r/372759 (https://phabricator.wikimedia.org/T173251) (owner: 10AnotherLadsgroup) [15:42:35] (03CR) 10Hashar: [C: 04-2] "Ah well I guess it got migrated to github meanwhile..." [integration/config] - 10https://gerrit.wikimedia.org/r/371605 (owner: 10Umherirrender) [15:43:49] (03CR) 10Reedy: "It's been on GitHub since December 2016 ;)" [integration/config] - 10https://gerrit.wikimedia.org/r/371605 (owner: 10Umherirrender) [15:43:56] 10Deployment-Systems, 10Release-Engineering-Team (Next), 10Scap (Scap3-Adoption-Phase1), 10JobRunner-Service, 10Operations: Figure out how to disable starting of jobrunner/jobchron in the non-active DC - https://phabricator.wikimedia.org/T167104#3558930 (10thcipriani) @fgiunchedi gave me feedback on my p... [15:44:35] (03CR) 10Hashar: [C: 04-2] "So indeed SemanticMediaWiki is no more on Gerrit. So I guess we should drop all the Semantic extensions or maybe they can get it installe" [integration/config] - 10https://gerrit.wikimedia.org/r/371605 (owner: 10Umherirrender) [15:44:40] Reedy: thank you :) [15:44:52] (03Merged) 10jenkins-bot: Enable jenkins (without any tests) on wheels repo of ORES [integration/config] - 10https://gerrit.wikimedia.org/r/372759 (https://phabricator.wikimedia.org/T173251) (owner: 10AnotherLadsgroup) [15:49:46] hashar: ride done, it was good, back to work now! [15:55:38] 10Continuous-Integration-Config, 10Scoring-platform-team, 10Easy, 10Patch-For-Review, 10User-Ladsgroup: Have CI merge research/ores/wheels changes - https://phabricator.wikimedia.org/T173251#3558986 (10hashar) 05Open>03Resolved Thanks :) [16:23:29] PROBLEM - Puppet errors on deployment-imagescaler02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [16:25:11] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [16:34:10] (03PS1) 10Umherirrender: Avoid match of underscore as punctuation in function comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374354 [16:34:33] (03CR) 10Umherirrender: "Whitelisted _ in Idbe4f96c11aa45a2a62c5e48f2998751cdd1fb01" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/373969 (owner: 10Umherirrender) [16:38:51] 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: WebdriverIO tech talk - https://phabricator.wikimedia.org/T171852#3478168 (10zeljkofilipin) 05Open>03stalled [16:39:05] 10Release-Engineering-Team (Kanban), 10Scap, 10Phabricator: scap should provide a way to skip symlink-swapping in promote - https://phabricator.wikimedia.org/T172486#3559145 (10mmodell) [16:39:54] (03PS2) 10Umherirrender: Avoid match of underscore as punctuation in function comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374354 [16:39:59] (03CR) 10Umherirrender: "Patch Set 2: Added test case" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374354 (owner: 10Umherirrender) [16:40:18] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.30.0-wmf.15 deployment blockers - https://phabricator.wikimedia.org/T170633#3437616 (10greg) 05Open>03Resolved [16:41:12] 10Scap, 10Phabricator: scap should provide a way to skip symlink-swapping in promote - https://phabricator.wikimedia.org/T172486#3499941 (10mmodell) a:05mmodell>03None [16:48:13] (03PS1) 10Umherirrender: Use DIRECTORY_SEPARATOR to split filenames [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374356 [16:48:37] 10Release-Engineering-Team (Kanban), 10Phabricator (Upstream), 10Upstream: Add support for task types - https://phabricator.wikimedia.org/T93499#3559213 (10mmodell) @Fjalapeno & @MBinder_WMF, @DStrine: Any input on this now that it's unblocked upstream? We can implement types and I have started to do so, h... [16:51:20] 10Deployment-Systems, 10Release-Engineering-Team (Next): Automate branch cutting, with period to test on Beta Cluster - https://phabricator.wikimedia.org/T167553#3559238 (10greg) 05Open>03Invalid Chad has other evil plans. [16:52:24] 10Release-Engineering-Team (Kanban), 10Phabricator: Add support for task types - https://phabricator.wikimedia.org/T93499#3559240 (10mmodell) [16:59:04] 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: WebdriverIO tech talk - https://phabricator.wikimedia.org/T171852#3559339 (10zeljkofilipin) Stalled until I hear back from @Rfarrand. @Qgil, @srishakatux: is Rachel on vacation/traveling? To make it clear, this is not... [17:14:41] 10Continuous-Integration-Config, 10Marvin: Enable CI Jenkins job test voting - https://phabricator.wikimedia.org/T172904#3559412 (10Jhernandez) Thanks @hashar ! We're aware of those warnings, the fsevents one is optional depending on OS, the eslint one is being fixed on eslint-config-node-services but it works... [17:27:06] hashar: icinga says "1 nodepool alien(s) present" — is that snapshot-ci-trusty-1503929640? [17:27:20] there's also ci-jessie-wikimedia-793795 which is way out of sequence [17:39:30] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Performance-Team, 10WebPageTest: Where to trigger WebPageTest jobs? - https://phabricator.wikimedia.org/T166756#3559474 (10Krinkle) >>! In T166756#3557604, @hashar wrote: > Looks good @Peter and I guess later we can add another... [17:47:53] (03CR) 10Legoktm: [C: 032] "Thanks :)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374354 (owner: 10Umherirrender) [17:48:06] (03CR) 10Legoktm: [C: 032] Use DIRECTORY_SEPARATOR to split filenames [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374356 (owner: 10Umherirrender) [17:48:37] (03Merged) 10jenkins-bot: Avoid match of underscore as punctuation in function comments [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374354 (owner: 10Umherirrender) [17:48:45] (03Merged) 10jenkins-bot: Use DIRECTORY_SEPARATOR to split filenames [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374356 (owner: 10Umherirrender) [17:59:34] (03PS1) 10Umherirrender: Cleanup SemanticMediaWiki test config [integration/config] - 10https://gerrit.wikimedia.org/r/374369 [18:01:04] (03PS2) 10Krinkle: Remove use of deprecated jQuery jqXHR `complete` method [integration/docroot] - 10https://gerrit.wikimedia.org/r/373667 (https://phabricator.wikimedia.org/T174058) (owner: 10Thcipriani) [18:01:06] (03CR) 10Krinkle: [C: 032] Remove use of deprecated jQuery jqXHR `complete` method [integration/docroot] - 10https://gerrit.wikimedia.org/r/373667 (https://phabricator.wikimedia.org/T174058) (owner: 10Thcipriani) [18:01:40] (03Merged) 10jenkins-bot: Remove use of deprecated jQuery jqXHR `complete` method [integration/docroot] - 10https://gerrit.wikimedia.org/r/373667 (https://phabricator.wikimedia.org/T174058) (owner: 10Thcipriani) [18:01:46] (03CR) 10jenkins-bot: Remove use of deprecated jQuery jqXHR `complete` method [integration/docroot] - 10https://gerrit.wikimedia.org/r/373667 (https://phabricator.wikimedia.org/T174058) (owner: 10Thcipriani) [18:09:48] (03PS1) 10Krinkle: Use local copy of jQuery (instead of loading from mediawiki.org) [integration/docroot] - 10https://gerrit.wikimedia.org/r/374371 [18:10:04] (03PS2) 10Krinkle: Use local copy of jQuery (instead of loading from mediawiki.org) [integration/docroot] - 10https://gerrit.wikimedia.org/r/374371 (https://phabricator.wikimedia.org/T174058) [18:11:30] (03CR) 10Krinkle: "Test plan: Check out the repo and open from a server that serves this repo. E.g. if you have Apache serving from your git root, try someth" [integration/docroot] - 10https://gerrit.wikimedia.org/r/374371 (https://phabricator.wikimedia.org/T174058) (owner: 10Krinkle) [18:12:02] thcipriani: hashar: ^ [18:15:22] Krinkle: awesome, thank you! [18:18:08] thcipriani: Would also love to have an answer on https://phabricator.wikimedia.org/T170032 - Personally I don't mind whether we either move (some) ci images to stretch or backport Chrome, but having a more recent Chrome version is becoming a more pressing problem as time goes on. Chrome is expected to be an "evergreen" browser, not tied to a specific version. In a few weeks this browser will effectively be EOL and unsupported by [18:18:08] Wikimedia as Grade A browser per the default policy of current & current-1. [18:18:20] It stopped being updated when Jessie went into maint mode. [18:23:30] Krinkle: hrm, ok, will take a look/talk with hashar about it (was just seeing if there was anything in backports [no, unfortunately])... [18:24:17] thcipriani: I don't know how straight-forward a backport from stretch is compared to a backport from jessie-backports. Afaik it has no dependencies, so might be possible to do that way. [18:24:45] Oh, nvm. It does have deps [18:24:49] yeah, I'm a bit worried about all the dependencies that are updated. [18:25:26] In theory shouldn't matter given its a binary app that actual users would just keep updating regardless and work fine. afaik Google hasn't stopped support for Jessie in any way,. [18:25:39] It's just that the packagers have expressed some deps that need to be present for explicitness [18:26:11] but yeah, a new nodepool image for stretch would also be nice :) [18:26:29] but I'd rather not wait for that if that takes more time, whatever works best for you :) [18:27:26] yeah, gets tricky with the number of nodpool instances per image nodepool tries to maintain. I think backporting might be easier depending on how hairy the dependency situation is. [18:31:01] 10Browser-Tests-Infrastructure, 10Continuous-Integration-Infrastructure, 10User-zeljkofilipin: Upgrade to Chromium 59 or newer on Debian Jessie in CI - https://phabricator.wikimedia.org/T170032#3417522 (10thcipriani) >>! In T170032#3541765, @Jdforrester-WMF wrote: > Would it be more natural to "just" switch... [18:31:14] * thcipriani writes everything that was just said in task [18:43:05] 10Scap: Scap sync and sync-file are too similar looking yet do very different things - https://phabricator.wikimedia.org/T174369#3559626 (10MaxSem) [18:44:24] (03CR) 10Umherirrender: "Does it need a default version, if there is no version found in composer.json? Just to avoid fatal and to keep it compatibel." [integration/config] - 10https://gerrit.wikimedia.org/r/371097 (https://phabricator.wikimedia.org/T174339) (owner: 10Addshore) [18:46:35] (03CR) 10Umherirrender: "It seems the (already merged) depending patch set handle this very careful, so it does not need a version. It is already in the python scr" [integration/config] - 10https://gerrit.wikimedia.org/r/371097 (https://phabricator.wikimedia.org/T174339) (owner: 10Addshore) [18:47:54] thcipriani: Aside from packaging, it may also be feasible to (similar to npm version) for the nodepool image builder to download Chromium from the canonical source directly. [18:48:00] e.g. not via a debian package [18:48:13] Just FYI :) [18:49:03] Krinkle: this is true, we already use some 3rd party things IIRC. [18:49:15] may be the path of least resistance. [19:05:05] 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Kanban), 10Developer-Relations (Jul-Sep 2017), 10User-zeljkofilipin: WebdriverIO tech talk - https://phabricator.wikimedia.org/T171852#3559697 (10Qgil) Rachel is currently on vacation, yes. Back on Friday. [19:09:06] PROBLEM - Puppet errors on deployment-cache-upload04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:10:23] Yippee, build fixed! [19:10:24] Project selenium-MinervaNeue » chrome,beta,Linux,BrowserTests build #97: 09FIXED in 21 min: https://integration.wikimedia.org/ci/job/selenium-MinervaNeue/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/97/ [19:12:21] PROBLEM - Puppet errors on deployment-ms-fe02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:17:31] PROBLEM - Puppet errors on deployment-ms-be03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:19:51] Yippee, build fixed! [19:19:52] Project selenium-MinervaNeue » firefox,beta,Linux,BrowserTests build #97: 09FIXED in 30 min: https://integration.wikimedia.org/ci/job/selenium-MinervaNeue/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/97/ [19:20:05] 10Beta-Cluster-Infrastructure, 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: "Loss of session data" on Beta Cluster - https://phabricator.wikimedia.org/T172560#3502076 (10jmatazzoni) C... [19:20:50] PROBLEM - Puppet errors on deployment-cache-text04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:20:54] PROBLEM - Puppet errors on deployment-ms-be04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:21:32] PROBLEM - Puppet staleness on deployment-kafka01 is CRITICAL: CRITICAL: 10.00% of data above the critical threshold [43200.0] [19:30:39] PROBLEM - Puppet errors on deployment-imagescaler01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:31:42] 10Gerrit: Create a repository for a tool called Checkers - https://phabricator.wikimedia.org/T174281#3559965 (10MarcoAurelio) [19:32:22] 10Gerrit, 10Repository-Admins: Create a repository for a tool called Checkers - https://phabricator.wikimedia.org/T174281#3556747 (10MarcoAurelio) Amended description and projects as per form 31 :) [19:35:43] thcipriani: Krinkle: afaik chrome is a pain to package/compile [19:35:49] so probably we want a stretch image [19:36:09] what about just grabbing latest build? [19:37:15] depends whether the dependencies match on jessie ( https://packages.debian.org/stretch/chromium ) [19:39:16] or maybe we can reuse a .deb from chromium [19:42:27] yeah maybe. My knee-jerk reaction to adding a stretch image was caution :) [19:42:34] https://www.google.com/chrome/browser/desktop/index.html?platform=linux :D [19:42:42] yeah I would rather not add a stretch image to nodepool [19:42:54] my hope is to eventually phase out trusty ones in favor of docker based images [19:43:00] which really is just php 5.5 [19:43:13] which we can eventaully package for jessie or stretch \o/ [19:48:06] 10Beta-Cluster-Infrastructure, 10Cloud-Services, 10Wikimedia-General-or-Unknown, 10Patch-For-Review: rename -labs.php to -beta.php - https://phabricator.wikimedia.org/T150268#3560052 (10Reedy) 05Open>03stalled [19:51:15] 10Beta-Cluster-Infrastructure, 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: "Loss of session data" on Beta Cluster - https://phabricator.wikimedia.org/T172560#3560057 (10Anomie) >>! I... [19:51:56] thcipriani: or we could use chrome from google itself :D [19:52:02] there seems to be an apt repo on http://dl.google.com/linux/chrome/deb/ stable main [19:55:11] we do use other trusted 3rd party repos in CI, right? That one for php? [19:55:49] Can we trust google? :P [19:56:47] evening / morning / afternoon all! [19:57:09] yeah we use sury.org [19:57:27] * thcipriani digs for paper on trusting trust [19:58:55] (03CR) 10Addshore: [C: 04-1] "Yep, the python script deals with that!" [integration/config] - 10https://gerrit.wikimedia.org/r/371097 (https://phabricator.wikimedia.org/T174339) (owner: 10Addshore) [20:03:01] thcipriani: https://phabricator.wikimedia.org/T174058 (zuul status page does not update), I can not reproduce locally ://// [20:04:12] hashar: hrm, my thing was merged, so that may have mitigated the issue. [20:04:31] hashar: https://gerrit.wikimedia.org/r/#/c/373667/ [20:04:55] ah yeah [20:05:18] yeah beter [20:05:21] better [20:07:10] TypeError: $.getJSON(...).done(...).fail(...).complete is not a function [20:07:11] :) [20:08:05] (03PS3) 10Hashar: Use local copy of jQuery (instead of loading from mediawiki.org) [integration/docroot] - 10https://gerrit.wikimedia.org/r/374371 (https://phabricator.wikimedia.org/T174058) (owner: 10Krinkle) [20:08:52] (03CR) 10Hashar: [C: 031] "Tried and rebased it on top of Tyler patch I4498e3b63d07d019db51b4f04a1dd20ebc7c1167" [integration/docroot] - 10https://gerrit.wikimedia.org/r/374371 (https://phabricator.wikimedia.org/T174058) (owner: 10Krinkle) [20:10:04] thcipriani: wanna test it yourself or should i just deploy it ? (works for me locally) [20:11:39] hashar: it looks good to me, if it works locally for you then go for it. [20:11:52] (03CR) 10Hashar: [C: 032] Use local copy of jQuery (instead of loading from mediawiki.org) [integration/docroot] - 10https://gerrit.wikimedia.org/r/374371 (https://phabricator.wikimedia.org/T174058) (owner: 10Krinkle) [20:12:28] (03Merged) 10jenkins-bot: Use local copy of jQuery (instead of loading from mediawiki.org) [integration/docroot] - 10https://gerrit.wikimedia.org/r/374371 (https://phabricator.wikimedia.org/T174058) (owner: 10Krinkle) [20:12:36] (03CR) 10jenkins-bot: Use local copy of jQuery (instead of loading from mediawiki.org) [integration/docroot] - 10https://gerrit.wikimedia.org/r/374371 (https://phabricator.wikimedia.org/T174058) (owner: 10Krinkle) [20:13:00] of course the deploy failed [20:13:46] hashar: I just un-did my local fix on contint1001, that'll probably fix the deploy [20:14:49] k [20:15:14] (03CR) 10jenkins-bot: Use local copy of jQuery (instead of loading from mediawiki.org) [integration/docroot] - 10https://gerrit.wikimedia.org/r/374371 (https://phabricator.wikimedia.org/T174058) (owner: 10Krinkle) [20:15:33] thcipriani: indeed :] [20:16:19] and this way we are untied from the jquery version running on mediawiki.org [20:16:23] + got jquery updated [20:16:26] \o/ [20:17:11] nice :) [20:18:04] 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10Zuul: Zuul status page not updating - https://phabricator.wikimedia.org/T174058#3560182 (10hashar) 05Open>03Resolved @thcipriani patch was to reach JQuery compatibility. @krinkle patch untied integration docroot from mediawiki.org jquery ver... [20:19:37] (03CR) 10Hashar: [C: 032] Cleanup SemanticMediaWiki test config [integration/config] - 10https://gerrit.wikimedia.org/r/374369 (owner: 10Umherirrender) [20:19:43] (03CR) 10Hashar: [C: 032] "Danke!" [integration/config] - 10https://gerrit.wikimedia.org/r/374369 (owner: 10Umherirrender) [20:21:17] Danke? Is that german for thanks or good or something? [20:21:51] Zppix: german [20:22:04] I knew it was german hashar lol [20:22:50] (03PS2) 10Hashar: Cleanup SemanticMediaWiki test config [integration/config] - 10https://gerrit.wikimedia.org/r/374369 (owner: 10Umherirrender) [20:23:15] (03Abandoned) 10Hashar: [SemanticGenealogy] Needs SemanticMediaWiki for unit tests [integration/config] - 10https://gerrit.wikimedia.org/r/371605 (owner: 10Umherirrender) [20:23:44] Zppix: so yeah that is german for thanks [20:23:53] or thank you [20:24:26] Ah i see, Danke [20:28:10] (03CR) 10Hashar: [C: 032] Cleanup SemanticMediaWiki test config [integration/config] - 10https://gerrit.wikimedia.org/r/374369 (owner: 10Umherirrender) [20:29:03] (03Merged) 10jenkins-bot: Cleanup SemanticMediaWiki test config [integration/config] - 10https://gerrit.wikimedia.org/r/374369 (owner: 10Umherirrender) [20:32:06] * hashar digests https://www.rabbitmq.com/tutorials/amqp-concepts.html [20:34:03] PROBLEM - Puppet errors on deployment-trending01 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [20:41:16] thcipriani: seen https://docs.docker.com/engine/userguide/eng-image/multistage-build/#use-multi-stage-builds ? [20:41:49] Yippee, build fixed! [20:41:50] Project selenium-Echo » chrome,beta,Linux,BrowserTests build #500: 09FIXED in 48 sec: https://integration.wikimedia.org/ci/job/selenium-Echo/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/500/ [20:41:51] Yippee, build fixed! [20:41:52] Project selenium-Echo » firefox,beta,Linux,BrowserTests build #500: 09FIXED in 50 sec: https://integration.wikimedia.org/ci/job/selenium-Echo/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/500/ [20:43:41] marxarelli: https://docs.docker.com/engine/userguide/eng-image/multistage-build/ via addshore [20:45:02] thcipriani: that looks like it would also solve the copy issue I had the other day [20:45:33] I might try and rewrite the puppe dockerfiles into 1 using that [20:49:26] addshore: yep, have seen that, I didn't do that initially since you need docker 17.05 to do it which is newer than the docker on the CI cluster. But really since we only need it for the initial provisioning, I think it should work fine :) [20:52:25] * addshore tries it out [20:52:58] Are we 'allowed' to use 'random' images from docker hub in these CI images or not? [20:53:03] hehe [20:53:36] :) [20:54:14] I can see addshore going crazy already... [20:54:23] would prefer using the pre-built base images and adding packages. Eventually (hopefully) will be able to add base CI images. Which 'random' image on docker hub were you looking at? [20:55:31] just random ones in general, more thinking about what the approach could be than any specific image itself [20:56:11] gotcha. [20:56:12] 10Beta-Cluster-Infrastructure, 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: "Loss of session data" on Beta Cluster - https://phabricator.wikimedia.org/T172560#3560341 (10Tgr) This see... [20:56:56] my hope would be that we could create base images for php-ci, python-ci, that kind of thing. Then if specific repos need something additional, they can build from those images. [20:58:21] thcipriani: that would be lot of images no? [21:01:03] Zppix: potentially, but I think this plays to the strengths of docker. If we have a base image that is used to build a php-ci base image. Then we use that image is used to build a different image with one additional package then that one additional package is the only layer that needs to change. Since what underlays docker is a layeredFS, it may be a number of images, but the space use should [21:01:05] (hopefully) still stay fairly small. [21:01:45] my hope would be to keep as much common as possible. Shift common packages/code up to base images, and standardize as we go. [21:07:19] dont think my wifi is going to allow me to play with any more of this tonight [21:09:03] RECOVERY - Puppet errors on deployment-trending01 is OK: OK: Less than 1.00% above the threshold [0.0] [21:20:47] (03PS1) 10Umherirrender: Use composer unittests for some Semantic* extensions [integration/config] - 10https://gerrit.wikimedia.org/r/374423 [21:24:06] wow, the chown take a while [21:24:21] or, I assume it is the chown and not the mkdirs or the mvs [21:37:03] (03CR) 10Hashar: [C: 032] Use composer unittests for some Semantic* extensions [integration/config] - 10https://gerrit.wikimedia.org/r/374423 (owner: 10Umherirrender) [21:38:28] (03Merged) 10jenkins-bot: Use composer unittests for some Semantic* extensions [integration/config] - 10https://gerrit.wikimedia.org/r/374423 (owner: 10Umherirrender) [22:07:56] Can we cherry pick MW config patches onto beta? [22:13:47] 22:12:13 sync-file failed: [Errno 13] Permission denied: u'/srv/mediawiki-staging/php-master/cache/gitinfo/info-extensions-Whoops.json' [22:13:48] o_0 [22:36:14] 10Beta-Cluster-Infrastructure, 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: "Loss of session data" on Beta Cluster - https://phabricator.wikimedia.org/T172560#3560644 (10jmatazzoni) T... [22:38:07] 10Deployment-Systems, 10Release-Engineering-Team (Kanban): Automate the recurring management of wikitech:Deployments and phab:#train_deployments - https://phabricator.wikimedia.org/T114488#3560645 (10greg) >>! In T114488#3557578, @mmodell wrote: > @greg ^ how do you feel about doing a trial to evaluate whether... [23:13:42] Project beta-scap-eqiad build #170695: 04FAILURE in 0.44 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/170695/ [23:19:48] my fault [23:22:55] Yippee, build fixed! [23:22:57] Project beta-scap-eqiad build #170696: 09FIXED in 2 min 43 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/170696/ [23:23:38] Project beta-code-update-eqiad build #170361: 04FAILURE in 36 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/170361/ [23:33:39] Project beta-code-update-eqiad build #170362: 04STILL FAILING in 38 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/170362/ [23:43:43] Yippee, build fixed! [23:43:44] Project beta-code-update-eqiad build #170363: 09FIXED in 42 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/170363/ [23:57:42] 10Scap (Scap3-Adoption-Phase1), 10Wikimedia-Wikimania-Scholarships, 10Patch-For-Review, 10User-bd808: Deploy scholarships with scap3 - https://phabricator.wikimedia.org/T129134#3560849 (10thcipriani) Code reviewed the patches that are outstanding for scholarships. One thing I noticed in my review is that k...