[02:18:39] <wikibugs_>	 10Gerrit, 10Release-Engineering-Team (Backlog), 10Scap, 10Patch-For-Review: Deploy gerrit with scap3 - https://phabricator.wikimedia.org/T157414#3564722 (10demon) It works! All we need to do is do some puppet cleanup so we symlink to the scap-deployed versions :)
[02:34:50] <wikibugs_>	 (03CR) 10MaxSem: Prohibit some globals (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/373433 (owner: 10MaxSem)
[02:35:09] <wikibugs_>	 (03PS3) 10MaxSem: Prohibit some globals [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/373433
[04:08:32] <wmf-insecte>	 Yippee, build fixed!
[04:08:33] <wmf-insecte>	 Project selenium-MultimediaViewer » safari,beta,OS X 10.9,BrowserTests build #501: 09FIXED in 12 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=safari,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=OS%20X%2010.9,label=BrowserTests/501/
[04:18:14] <wmf-insecte>	 Project selenium-MultimediaViewer » firefox,beta,Linux,BrowserTests build #501: 04FAILURE in 22 min: https://integration.wikimedia.org/ci/job/selenium-MultimediaViewer/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/501/
[05:18:20] <wikibugs_>	 (03CR) 10Reception123: [C: 031] "Thank you!" [integration/config] - 10https://gerrit.wikimedia.org/r/374621 (owner: 10MarcoAurelio)
[05:19:49] <shinken-wm>	 PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0]
[05:39:51] <shinken-wm>	 PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [10.0]
[05:59:39] <shinken-wm>	 PROBLEM - App Server Main HTTP Response on deployment-mediawiki04 is CRITICAL: CRITICAL - Socket timeout after 10 seconds
[06:01:59] <wikibugs_>	 (03PS1) 10Legoktm: Release 0.12.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374684
[06:04:28] <shinken-wm>	 RECOVERY - App Server Main HTTP Response on deployment-mediawiki04 is OK: HTTP OK: HTTP/1.1 200 OK - 50509 bytes in 1.197 second response time
[06:12:13] <wikibugs_>	 (03CR) 10Legoktm: [C: 032] Release 0.12.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374684 (owner: 10Legoktm)
[06:13:01] <wikibugs_>	 (03Merged) 10jenkins-bot: Release 0.12.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/374684 (owner: 10Legoktm)
[06:19:51] <shinken-wm>	 PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0]
[06:37:01] <shinken-wm>	 PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<20.00%)
[06:41:03] <Reception123>	 hashar: Hi. Did you mean to +2 https://gerrit.wikimedia.org/r/#/c/374621/?
[06:57:19] <shinken-wm>	 PROBLEM - Puppet errors on deployment-kafka01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]
[06:58:38] <hashar>	 Reception123: na just +1ed it because deploying at midnight is a bit risky :D
[06:58:42] <hashar>	 at least for my sleep schedule
[06:58:47] <hashar>	 9am is better
[06:58:51] <Reception123>	 ah, ok :) 
[06:58:57] <wikibugs_>	 (03CR) 10Hashar: [C: 032] Whitelist Reception123 on Zuul [integration/config] - 10https://gerrit.wikimedia.org/r/374621 (owner: 10MarcoAurelio)
[06:59:09] <Reception123>	 thanks!
[06:59:15] <wikibugs_>	 (03CR) 10Hashar: [C: 032] Whitelist Mainframe98 on Zuul [integration/config] - 10https://gerrit.wikimedia.org/r/374626 (owner: 10MarcoAurelio)
[06:59:31] <hashar>	 maybe they will merge as is :D
[06:59:56] <wikibugs_>	 (03Merged) 10jenkins-bot: Whitelist Reception123 on Zuul [integration/config] - 10https://gerrit.wikimedia.org/r/374621 (owner: 10MarcoAurelio)
[07:00:12] <wikibugs_>	 (03Merged) 10jenkins-bot: Whitelist Mainframe98 on Zuul [integration/config] - 10https://gerrit.wikimedia.org/r/374626 (owner: 10MarcoAurelio)
[07:01:57] <wikibugs_>	 (03CR) 10Hashar: [C: 032] Whitelist Framawiki on Zuul [integration/config] - 10https://gerrit.wikimedia.org/r/374642 (owner: 10MarcoAurelio)
[07:02:52] <wikibugs_>	 (03Merged) 10jenkins-bot: Whitelist Framawiki on Zuul [integration/config] - 10https://gerrit.wikimedia.org/r/374642 (owner: 10MarcoAurelio)
[07:04:00] <Reception123>	 hashar: would you also be able to merge a ConfirmEdit change by any chance? https://gerrit.wikimedia.org/r/#/c/371947/ There's two maintainers, one created the patch and one is inactive..
[07:04:05] <Reception123>	 it's a WMF-used extension
[07:04:54] <wikibugs_>	 (03CR) 10Hashar: [C: 032] "There are a bunch of:" [integration/config] - 10https://gerrit.wikimedia.org/r/374643 (https://phabricator.wikimedia.org/T121723) (owner: 10Ejegg)
[07:05:51] <wikibugs_>	 (03Merged) 10jenkins-bot: Run tox on fundraising/tools/DjangoBannerStats [integration/config] - 10https://gerrit.wikimedia.org/r/374643 (https://phabricator.wikimedia.org/T121723) (owner: 10Ejegg)
[07:12:01] <shinken-wm>	 RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK
[07:17:55] <hashar>	 Reception123: they will come to it eventually :]
[07:18:11] <Reception123>	 I saw legoktm reviewed :)
[07:19:44] <wikibugs_>	 (03CR) 10Hashar: [C: 032] "Yeahhhh!!!! Thank you for all those fixes!" [integration/config] - 10https://gerrit.wikimedia.org/r/374634 (owner: 10Umherirrender)
[07:20:46] <wikibugs_>	 (03Merged) 10jenkins-bot: Make some unit tests voting [integration/config] - 10https://gerrit.wikimedia.org/r/374634 (owner: 10Umherirrender)
[08:55:49] <shinken-wm>	 RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0]
[09:12:33] <wikibugs_>	 (03PS1) 10Hashar: debian glue for operations/debs/pkg-php/php-defaults [integration/config] - 10https://gerrit.wikimedia.org/r/374770
[09:13:57] <wikibugs_>	 (03CR) 10Hashar: [C: 032] debian glue for operations/debs/pkg-php/php-defaults [integration/config] - 10https://gerrit.wikimedia.org/r/374770 (owner: 10Hashar)
[09:14:52] <wikibugs_>	 (03Merged) 10jenkins-bot: debian glue for operations/debs/pkg-php/php-defaults [integration/config] - 10https://gerrit.wikimedia.org/r/374770 (owner: 10Hashar)
[10:55:12] <tabbycat>	 what "unstable" means on jenkins?
[11:35:00] <hashar_>	 tabbycat: build worked, but test results contains failures
[11:35:54] <tabbycat>	 thanks hashar_ -- also, should we keep phpcs.xml files when migrating to extension registration?
[11:36:07] <hashar_>	 most probably yes
[11:36:16] <hashar_>	 that lets one define different set of rules
[11:36:23] <hashar>	 and that is solely for PHP_CodeSniffer
[11:36:32] <hashar>	 which afaik doesn't read its configuration from extension.json
[11:36:45] <tabbycat>	 https://gerrit.wikimedia.org/r/#/c/374780/ only passed when deleted the file
[11:36:59] <tabbycat>	 otherwise I can restore it and remove lines 7-9
[11:37:06] <tabbycat>	 which disallowed short array syntax
[11:37:25] <hashar>	 yeah that would be the reason
[11:38:40] <tabbycat>	 Mainframe says that the rules contained there would be enforced via the extension.json file so I trusted him
[12:49:48] <hashar>	 !log gerrit: marked wikimedia/communications/WMBlog as read-only - T172372
[12:49:52] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[12:49:52] <stashbot>	 T172372: Archive wikimedia/communications/WMBlog.git ? - https://phabricator.wikimedia.org/T172372
[12:50:02] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Cleanup, 10WMF-Blog-Social-Team, 10WMF-Communications, 10Wikimedia-Blog: Archive wikimedia/communications/WMBlog.git ? - https://phabricator.wikimedia.org/T172372#3565532 (10hashar) 05Open>03Resolved a:03hashar Thank you!
[13:06:18] <shinken-wm>	 PROBLEM - Puppet errors on aptly is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]
[13:21:17] <shinken-wm>	 RECOVERY - Puppet errors on aptly is OK: OK: Less than 1.00% above the threshold [0.0]
[13:21:53] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Kanban): Automate the recurring management of wikitech:Deployments and phab:#train_deployments - https://phabricator.wikimedia.org/T114488#3565599 (10mmodell) Not finished yet but here's an example: {E705}
[13:23:12] <wikibugs_>	 10Gerrit: Data loss in gerrit review interface due to bad design - https://phabricator.wikimedia.org/T174551#3565615 (10Nikerabbit)
[13:26:05] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Kanban): Automate the recurring management of wikitech:Deployments and phab:#train_deployments - https://phabricator.wikimedia.org/T114488#3565632 (10mmodell) The way I'd imagine it is having a section at the top of the page which collects together any gerrit U...
[13:27:27] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Kanban): Automate the recurring management of wikitech:Deployments and phab:#train_deployments - https://phabricator.wikimedia.org/T114488#3565637 (10mmodell) E673 is actually a good example, just imagine having the table in the description update automatically.
[13:32:02] <wikibugs_>	 10Gerrit: Data loss in gerrit review interface due to bad design - https://phabricator.wikimedia.org/T174551#3565687 (10Nikerabbit)
[13:37:10] <wmf-insecte>	 Yippee, build fixed!
[13:37:11] <wmf-insecte>	 Project selenium-MinervaNeue » chrome,beta,Linux,BrowserTests build #99: 09FIXED in 18 min: https://integration.wikimedia.org/ci/job/selenium-MinervaNeue/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/99/
[13:46:50] <wmf-insecte>	 Yippee, build fixed!
[13:46:50] <wmf-insecte>	 Project selenium-MinervaNeue » firefox,beta,Linux,BrowserTests build #99: 09FIXED in 28 min: https://integration.wikimedia.org/ci/job/selenium-MinervaNeue/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/99/
[14:11:32] <wikibugs_>	 10Continuous-Integration-Infrastructure (phase-out-trusty), 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Migrate PHP5.5 jobs from Trusty to Jessie - https://phabricator.wikimedia.org/T161882#3565873 (10hashar) I have setup [[ https://wikitech.wikimedia.org/wiki/Aptly Aptly ]] on aptly.integration...
[14:45:09] <wikibugs_>	 10Gerrit: Data loss in gerrit review interface due to bad design - https://phabricator.wikimedia.org/T174551#3565615 (10Paladox) This is fixed in PolyGerrit (gerrit 2.14) it saves comments to your local storage (they call it local storage for the browser).
[14:47:01] <wikibugs_>	 10Gerrit: Data loss in gerrit review interface due to bad design - https://phabricator.wikimedia.org/T174551#3566057 (10Paladox) This also looks like it’s a duplicate of T48777
[14:50:12] <wikibugs_>	 10Gerrit, 10Release-Engineering-Team (Backlog), 10Patch-For-Review: Update gerrit to 2.14.3 - https://phabricator.wikimedia.org/T156120#3566065 (10Paladox)
[14:50:14] <wikibugs_>	 10Gerrit: Data loss in gerrit review interface due to bad design - https://phabricator.wikimedia.org/T174551#3566064 (10Paladox)
[14:53:45] <shinken-wm>	 PROBLEM - Puppet errors on integration-slave-jessie-plus-php55 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0]
[15:12:02] <shinken-wm>	 PROBLEM - Host integration-slave-jessie-plus-php55 is DOWN: CRITICAL - Host Unreachable (10.68.18.190)
[15:12:35] <hashar>	 ^^ I have deleted that instance
[15:14:02] <wikibugs_>	 10Release-Engineering-Team (Watching / External), 10MediaWiki-Platform-Team: Deploy refactored comment storage - https://phabricator.wikimedia.org/T166733#3305978 (10Anomie)
[15:48:34] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Next), 10Scap (Scap3-Adoption-Phase1), 10JobRunner-Service, and 2 others: Figure out how to disable starting of jobrunner/jobchron in the non-active DC - https://phabricator.wikimedia.org/T167104#3566417 (10thcipriani) >>! In T167104#3566055, @gerritbot wro...
[15:58:33] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Kanban), 10Scap (Scap3-Adoption-Phase1), 10scap2, and 3 others: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner) - https://phabricator.wikimedia.org/T129148#3566465 (10thcipriani)
[15:59:02] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Kanban), 10Scap (Scap3-Adoption-Phase1), 10scap2, and 3 others: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner) - https://phabricator.wikimedia.org/T129148#2096711 (10thcipriani)
[16:00:17] <wikibugs_>	 10Gerrit, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3566488 (10Ladsgroup)
[16:02:37] <Amir1>	 greg-g: Hey What do you think of https://gerrit.wikimedia.org/r/#/c/374838 ?
[16:03:20] <greg-g>	 Amir1: /me shrugs :)
[16:05:31] <Amir1>	 https://usercontent.irccloud-cdn.com/file/yNTjcPws/image.png
[16:05:37] <Amir1>	 I like this :D
[16:07:11] <wikibugs_>	 10Gerrit, 10Patch-For-Review, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3566488 (10Krinkle) @Ladsgroup Per <https://wikimediafoundation.org/wiki/Visual_identity_guidelines#toc-foundation>, "WIKIMEDIA" is meant to be in caps. Also, the spacing of the wordma...
[16:17:55] <Krinkle>	 Amir1: Will depend on the CSS used for its embedding, but if possible, would be nice to have a 2x version as well.
[16:18:12] <Krinkle>	 (or SVG, even)
[16:18:21] <wikibugs_>	 10Release-Engineering-Team (Next), 10Release Pipeline (Blubber): Build mathoid container via blubber - https://phabricator.wikimedia.org/T173127#3566578 (10thcipriani) p:05Triage>03Normal
[16:18:28] <Amir1>	 Krinkle: I will upload the SVG in commons 
[16:18:37] <Amir1>	 would that be okay?
[16:18:45] <Krinkle>	 Amir1: I mean, browsers can render it just fine.
[16:18:58] <Krinkle>	 So you can upload the 1x png and 2x png to Gerrit, or 1x png and SVG
[16:19:01] <Krinkle>	 latter seems easier
[16:19:17] <Krinkle>	 I don't midn whether it's also in Commons, I just want the logo not to be pixely anymore.
[16:19:39] <Amir1>	 I see it now, okay. let me try
[16:19:43] <Krinkle>	 https://github.com/wikimedia/puppet/blob/83b76dd0da2e1e576138bb12f446977ad21de42f/modules/gerrit/files/etc/GerritSite.css#L67
[16:20:09] <Krinkle>	 Can add a second background rule for the SVG, with background-size as needed.
[16:20:36] <Krinkle>	 Either in @media, or with a fake-gradient, as proxy for browser support for SVG, so that it falls back to the PNG
[16:20:56] <Amir1>	 Krinkle: is there some sort of example for me to check?
[16:22:30] <wikibugs_>	 10Release-Engineering-Team (Next), 10Release Pipeline: Find CI container build location - https://phabricator.wikimedia.org/T173128#3566588 (10thcipriani) p:05Triage>03Normal Now that we have locked down the security for Jenkins a bit, contint1001 seems like a logical place to store credentials and run bui...
[16:22:40] <Krinkle>	 Amir1: https://gist.github.com/Krinkle/59bd9d371a4971a3afb9e2ec21ef3ad3
[16:22:50] <Amir1>	 Thanks
[16:25:11] <shinken-wm>	 PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]
[16:33:53] <wikibugs_>	 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Next), 10Wikidata, 10Patch-For-Review, and 3 others: Increase in failures caused by Saucelabs - https://phabricator.wikimedia.org/T152963#2864860 (10Niedzielski) This appears to still be a failure from time to time: https://integration.wikimedia.o...
[16:48:47] <wikibugs_>	 (03PS2) 10Hashar: Add Chris Neuroth to the list of users triggering +2 voting checks [integration/config] - 10https://gerrit.wikimedia.org/r/373077 (https://phabricator.wikimedia.org/T173831) (owner: 10WMDE-leszek)
[16:49:05] <wikibugs_>	 (03CR) 10Hashar: [C: 032] "Amended to add the email in the second list." [integration/config] - 10https://gerrit.wikimedia.org/r/373077 (https://phabricator.wikimedia.org/T173831) (owner: 10WMDE-leszek)
[16:50:26] <wikibugs_>	 (03Merged) 10jenkins-bot: Add Chris Neuroth to the list of users triggering +2 voting checks [integration/config] - 10https://gerrit.wikimedia.org/r/373077 (https://phabricator.wikimedia.org/T173831) (owner: 10WMDE-leszek)
[16:55:32] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Next), 10Scap (Scap3-Adoption-Phase1), 10JobRunner-Service, and 2 others: Figure out how to disable starting of jobrunner/jobchron in the non-active DC - https://phabricator.wikimedia.org/T167104#3566767 (10akosiaris) \o/. Isn't there anything else left to...
[16:57:02] <wikibugs_>	 10Gerrit, 10utfnormal: php-normal unused? - https://phabricator.wikimedia.org/T174583#3566773 (10Krinkle)
[17:02:26] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Kanban), 10Scap (Scap3-Adoption-Phase1), 10scap2, and 3 others: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner) - https://phabricator.wikimedia.org/T129148#3566810 (10Krinkle)
[17:02:28] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Next), 10Scap (Scap3-Adoption-Phase1), 10JobRunner-Service, and 2 others: Figure out how to disable starting of jobrunner/jobchron in the non-active DC - https://phabricator.wikimedia.org/T167104#3566808 (10Krinkle) 05Open>03Resolved a:03Krinkle
[17:02:34] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Kanban), 10Scap (Scap3-Adoption-Phase1), 10JobRunner-Service, and 2 others: Figure out how to disable starting of jobrunner/jobchron in the non-active DC - https://phabricator.wikimedia.org/T167104#3566813 (10Krinkle) a:05Krinkle>03thcipriani
[17:04:22] <wikibugs_>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: On contint-operations-puppet apt-get yields about locale - https://phabricator.wikimedia.org/T174584#3566818 (10hashar)
[17:04:35] <wikibugs_>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team: On contint-operations-puppet apt-get yields about locale - https://phabricator.wikimedia.org/T174584#3566830 (10hashar) p:05Triage>03Lowest It works fine though :)
[17:05:15] <wikibugs_>	 (03CR) 10Umherirrender: "Thansks for merging, there are still some to look at" [integration/config] - 10https://gerrit.wikimedia.org/r/374634 (owner: 10Umherirrender)
[17:15:32] <Amir1>	 Krinkle: Can you take a look again? Thanks
[17:19:19] <wikibugs_>	 10Gerrit, 10Patch-For-Review, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3566866 (10Ladsgroup) Does this look okay? {F9227548}
[17:21:10] <Amir1>	 I'll go afk for dinner, be back soon
[17:25:40] <wikibugs_>	 10Gerrit, 10utfnormal: php-normal unused? - https://phabricator.wikimedia.org/T174583#3566773 (10Legoktm) Yes, it's entirely unused. Support for using it for MediaWiki was dropped in {13975fe76abd4d388beb097e76eb5053acb6da62} after discussing it with @brion.
[18:02:55] <wikibugs_>	 10Gerrit, 10Patch-For-Review, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3567103 (10Krinkle) >>! In T174576#3566866, @Ladsgroup wrote: > Does this look okay? > {F9227548}  Spacing capitalisation looks good. Thanks.  The second line ("Code Review") looks a b...
[18:12:06] <matt_flaschen>	 zeljkof, is there a tracking task for migrating Ruby to node.js?  I'm making tasks for my team.
[18:16:38] <greg-g>	 matt_flaschen: https://phabricator.wikimedia.org/T139740
[18:17:18] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber), 10Services (designing), 10User-Joe, 10User-mobrovac: Gather requirements for build manifest specification - https://phabricator.wikimedia.org/T158812#3567202 (10thcipriani) 05Open>03Resolved a:03dduvall Calling this one done, blubbe...
[18:21:31] <matt_flaschen>	 Thanks greg-g
[18:23:50] <zeljkof>	 matt_flaschen: what greg-g said :)
[18:30:31] <wikibugs_>	 10Gerrit, 10Patch-For-Review, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3567315 (10Ladsgroup) What about this: {F9228375}
[18:32:00] <Amir1>	 Krinkle: posted new image
[18:42:38] <wikibugs_>	 10Deployment-Systems, 10MW-1.30-release-notes, 10MediaWiki-extensions-CentralAuth, 10Performance-Team, 10Patch-For-Review: ChronologyProtector redirect optimization depends on inappropriate $wgLocalVirtualHosts setting - https://phabricator.wikimedia.org/T172357#3567344 (10Krinkle) 05Open>03Resolved
[18:42:45] <wikibugs_>	 10Deployment-Systems, 10MW-1.30-release-notes, 10MediaWiki-extensions-CentralAuth, 10Performance-Team: ChronologyProtector redirect optimization depends on inappropriate $wgLocalVirtualHosts setting - https://phabricator.wikimedia.org/T172357#3495988 (10Krinkle)
[18:42:51] <wikibugs_>	 10Deployment-Systems, 10MW-1.30-release-notes, 10MediaWiki-extensions-CentralAuth, 10Performance-Team: ChronologyProtector redirect optimization depends on inappropriate $wgLocalVirtualHosts setting - https://phabricator.wikimedia.org/T172357#3495988 (10Krinkle) a:05Krinkle>03aaron
[18:45:09] <Reception123>	 greg-g: could you please comment on https://phabricator.wikimedia.org/T225#3562008?
[18:59:14] <wikibugs_>	 10Release-Engineering-Team (Watching / External), 10JobRunner-Service, 10MediaWiki-Platform-Team, 10Operations, and 3 others: Collect error logs from jobchron/jobrunner services in Logstash - https://phabricator.wikimedia.org/T172479#3567427 (10Krinkle)
[19:09:06] <shinken-wm>	 PROBLEM - Puppet errors on deployment-cache-upload04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]
[19:12:20] <shinken-wm>	 PROBLEM - Puppet errors on deployment-ms-fe02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]
[19:17:33] <shinken-wm>	 PROBLEM - Puppet errors on deployment-ms-be03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]
[19:20:48] <shinken-wm>	 PROBLEM - Puppet errors on deployment-cache-text04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]
[19:20:54] <shinken-wm>	 PROBLEM - Puppet errors on deployment-ms-be04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]
[19:28:06] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Phabricator, 10User-greg: Update Phabricator login page with labs to wikitech - https://phabricator.wikimedia.org/T174224#3567564 (10mmodell) 05Open>03Resolved
[19:30:40] <shinken-wm>	 PROBLEM - Puppet errors on deployment-imagescaler01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]
[19:43:07] <wikibugs_>	 10Gerrit, 10Cloud-Services: Deactivate repository labs/invisible-unicorn - https://phabricator.wikimedia.org/T154099#3567645 (10Krenair)
[19:55:40] <greg-g>	 Reception123: mukunda beat me to it
[20:00:28] <wikibugs_>	 10Continuous-Integration-Config, 10Fundraising-Backlog, 10Fundraising Sprint Prank Seatbelt, 10Patch-For-Review: Continuous integration: wikimedia/fundraising/tools/DjangoBannerStats needs V+2 jobs - https://phabricator.wikimedia.org/T121723#1886309 (10Ejegg) 05Open>03Resolved
[20:10:17] <wikibugs_>	 10Gerrit, 10Patch-For-Review, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3567787 (10Krinkle) >>! In T174576#3567315, @Ladsgroup wrote: > What about this:  LGTM :)
[20:10:32] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Kanban), 10Scap (Scap3-Adoption-Phase1), 10JobRunner-Service, and 2 others: Figure out how to disable starting of jobrunner/jobchron in the non-active DC - https://phabricator.wikimedia.org/T167104#3567789 (10hashar) Awesome and well played!
[20:11:53] <Krinkle>	 RainbowSprinkles: So.. what's the situation around 'error' channel for mediawiki. Why no stacktraces? I thought the only reason was 1) the volume (which we fixed), and 2) Logstash config (error-json > error), which I thought was also done?
[20:12:08] <Krinkle>	 or are they included in error-json, but not in 'error'?
[20:12:15] <Krinkle>	 Afaik the stacktraces were working there.
[20:12:55] <Krinkle>	 https://phabricator.wikimedia.org/T45086
[20:13:03] <Krinkle>	 https://gerrit.wikimedia.org/r/#/q/message:T45086
[20:13:04] <stashbot>	 T45086: Capture PHP warnings with stacktraces in MediaWiki and save to logstash - https://phabricator.wikimedia.org/T45086
[20:13:32] <Reedy>	 doesn't the error channel just end up with a fucking huge log file still?
[20:18:15] <wikibugs_>	 10Deployment-Systems, 10Release-Engineering-Team (Kanban), 10Scap (Scap3-Adoption-Phase1), 10scap2, and 3 others: Deploy jobrunner with scap3 (Trebuchet jobrunner/jobrunner) - https://phabricator.wikimedia.org/T129148#3567828 (10hashar)
[20:18:17] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10JobRunner-Service, 10Operations, 10Beta-Cluster-reproducible, 10Patch-For-Review: jobrunner / jobchron systemd services are in error state after a stop - https://phabricator.wikimedia.org/T168044#3567827 (10hashar)
[20:19:19] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10JobRunner-Service, 10Operations, 10Beta-Cluster-reproducible, 10Patch-For-Review: jobrunner / jobchron systemd services are in error state after a stop - https://phabricator.wikimedia.org/T168044#3354078 (10hashar) 05Open>03stalled That one depends on T129148 co...
[20:20:54] <wikibugs_>	 (03CR) 10Framawiki: "Thanks :)" [integration/config] - 10https://gerrit.wikimedia.org/r/374642 (owner: 10MarcoAurelio)
[20:31:16] <wikibugs_>	 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Upgrade git package on zuul-merger instances contint1001 / contint2001 to benefit git-daemon - https://phabricator.wikimedia.org/T161086#3567896 (10hashar) a:03hashar Lets upgrade git on the zuul-merger in pro...
[20:47:55] <Krinkle>	 Reedy: https://gerrit.wikimedia.org/r/#/c/338901/3
[21:01:48] <Krinkle>	 Reedy: Well, it's enabled in prod
[21:01:53] <Krinkle>	 And has for a while
[21:05:44] <Reedy>	 heh
[21:08:36] <wikibugs_>	 10Gerrit, 10Patch-For-Review, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3568010 (10Paladox) What does it look like on the gerrit page please?
[21:09:55] <Krinkle>	 Reedy: I'm so confused. So exception-json is apparently still in use, not exception.
[21:11:41] <Reedy>	 ?
[21:12:27] <Krinkle>	 I thought we stopped using that in favour of 'exception'
[21:12:34] <Krinkle>	 but we're still using exception-json
[21:12:59] <Krinkle>	 And confusingly, the non-json 'error' channel that is logged to Logstash, *does* seem to have backtraces now?
[21:13:13] <Krinkle>	 exception.trace
[21:13:15] <Reedy>	 		'exception' => 'debug',
[21:13:15] <Reedy>	 		'exception-json' => [ 'logstash' => false ],
[21:13:17] <Krinkle>	 Ugh, will look later.
[21:13:31] <Krinkle>	 Reedy: Yeah, but at the same time, logstash config maps exception-json to exception
[21:13:34] <Krinkle>	 I guess that's unused now?
[21:13:48] <Reedy>	 :/
[21:13:51] <Krinkle>	 getStructuredExceptionData is only called by jsonSerialize though
[21:13:54] <Krinkle>	 in MWExceptionHandler
[21:13:59] <Krinkle>	 not by normal 'exception' or 'error'
[21:14:01] <Krinkle>	 will check back later, now -office
[21:14:05] <Reedy>	 I think there's a gap in my knowledge from when I wasn't around quite so much
[21:29:31] <wikibugs_>	 10Release-Engineering-Team (Next), 10Release Pipeline: Proof helm as a potential k8s deployment tool - https://phabricator.wikimedia.org/T173129#3568077 (10dduvall) p:05Triage>03Normal
[21:31:05] <wikibugs_>	 10Deployment-Systems, 10MediaWiki-Debug-Logger, 10Patch-For-Review, 10User-Tgr: Capture PHP warnings with stacktraces in MediaWiki and save to logstash - https://phabricator.wikimedia.org/T45086#3568088 (10Krinkle) It's been several months, let's look at the current state of affairs:  * MediaWiki core - <h...
[21:42:33] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber), 10Tracking: Complete Blubber's support for multi-stage Dockerfiles - https://phabricator.wikimedia.org/T174620#3568129 (10dduvall)
[21:42:34] <Krinkle>	 Reedy: ^
[21:54:39] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Shorthand for standard multi-stage artifact config - https://phabricator.wikimedia.org/T174622#3568211 (10dduvall)
[21:55:07] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.30.0-wmf.16 deployment blockers - https://phabricator.wikimedia.org/T170634#3568229 (10Krinkle)
[21:55:59] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber), 10Tracking: Complete Blubber's support for multi-stage Dockerfiles - https://phabricator.wikimedia.org/T174620#3568232 (10dduvall)
[21:56:01] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Shorthand for standard multi-stage artifact config - https://phabricator.wikimedia.org/T174622#3568231 (10dduvall)
[21:59:44] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber), 10Tracking: Ensure application files are not copied for final multi-stage images - https://phabricator.wikimedia.org/T174623#3568237 (10dduvall)
[22:09:23] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Optimized image builds for node applications - https://phabricator.wikimedia.org/T174626#3568307 (10dduvall)
[22:27:32] <wikibugs_>	 10MediaWiki-Codesniffer, 10MediaWiki-Core-Tests: Add a test of some kind to make sure *.php files are -x (not executable) - https://phabricator.wikimedia.org/T137938#3568395 (10Krinkle) @Legoktm Is this something we could do with codesniffer?
[22:29:45] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Support for Blubber defaults and/or policies - https://phabricator.wikimedia.org/T174631#3568403 (10dduvall)
[22:30:08] <wikibugs_>	 10MediaWiki-Codesniffer: phpcs wrongly validates any symlinks as PHP files - https://phabricator.wikimedia.org/T171510#3568417 (10Krinkle)
[22:36:02] <wikibugs_>	 10MediaWiki-Codesniffer: phpcs wrongly validates any symlinks as PHP files - https://phabricator.wikimedia.org/T171510#3467431 (10Krinkle) Generalising task. I've seen this error over and over and over again. It's related to symlinks. For some reason, Codesniffer is consistently acting the same way whenever it s...
[22:42:19] <wikibugs_>	 10MediaWiki-Codesniffer, 10Upstream: phpcs wrongly validates any symlinks as PHP files - https://phabricator.wikimedia.org/T171510#3568470 (10Reedy)
[22:43:48] <wikibugs_>	 10MediaWiki-Codesniffer, 10Upstream: phpcs wrongly validates any symlinks as PHP files - https://phabricator.wikimedia.org/T171510#3467431 (10Reedy) There doesn't seem to be an upstream issue for this.. I guess one should be filed against squizlabs/PHP_CodeSniffer
[23:00:03] <wikibugs_>	 10MediaWiki-Codesniffer, 10MediaWiki-Core-Tests: Add a test of some kind to make sure *.php files are -x (not executable) - https://phabricator.wikimedia.org/T137938#3568511 (10Legoktm)
[23:00:06] <wikibugs_>	 10Continuous-Integration-Config: Reject non-executable files with execute bits with a build check - https://phabricator.wikimedia.org/T168659#3568514 (10Legoktm)
[23:01:40] <wikibugs_>	 10Continuous-Integration-Config: Reject non-executable files with execute bits with a build check - https://phabricator.wikimedia.org/T168659#3371176 (10Legoktm) >>! In T137938#3568395, @Krinkle wrote: > @Legoktm Is this something we could do with codesniffer?  Theoretically yes, but this applies to *all* files,...
[23:11:30] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10MediaWiki-extensions-Newsletter, 10Patch-For-Review, 10Regression: HTTP Error 500 when trying to publish a Newsletter issue in test.wikipedia.org - https://phabricator.wikimedia.org/T174605#3568544 (10demon) 05Open>03Resolved a:03demon
[23:11:34] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10MediaWiki-extensions-Newsletter, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review, 10Wikimedia-log-errors: Call to undefined method Newsletter::getSubscriberCount() - https://phabricator.wikimedia.org/T174604#3568548 (10demon) 05O...
[23:16:02] <wikibugs_>	 10Gerrit, 10Patch-For-Review, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3566488 (10greg) >>! In T174576#3567315, @Ladsgroup wrote: > What about this: > {F9228375}  +1
[23:19:26] <wikibugs_>	 10Gerrit, 10Patch-For-Review, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3566488 (10demon) I wish I could decline this 😢
[23:20:14] <wikibugs_>	 10Gerrit, 10Patch-For-Review, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3568573 (10greg) :) what's a little rebranding between friends ;)
[23:20:58] <wikibugs_>	 10Gerrit, 10Patch-For-Review, 10User-Ladsgroup: Make gerrit use the new WMF logo - https://phabricator.wikimedia.org/T174576#3568576 (10demon) Sure, if my friend wants to present me with a logo that's not butt ugly ;)
[23:21:24] <greg-g>	 now now ;)
[23:21:52] <RainbowSprinkles>	 First they came for the WMF wiki but I didn't care because I don't edit WMF wiki
[23:21:59] <RainbowSprinkles>	 You know how the story goes....
[23:22:43] <RainbowSprinkles>	 greg-g: Can we go with no logo on gerrit?
[23:22:49] <RainbowSprinkles>	 That'd be an improvement over the b&w one
[23:23:42] <Reedy>	 RainbowSprinkles: undeploy gerrit
[23:23:44] <Reedy>	 problem solved
[23:24:02] * RainbowSprinkles just pouts and leaves gerrit disabled until he gets his way
[23:24:04] <RainbowSprinkles>	 That'll work!
[23:58:55] <wikibugs_>	 10Release-Engineering-Team (Backlog), 10Cloud-Services, 10Phabricator, 10wikitech.wikimedia.org, and 2 others: Blocking an account on wikitech should disable LDAP logins - https://phabricator.wikimedia.org/T168692#3373658 (10bd808) There is probably some hook that we can attach code to to make some adjustm...