[01:07:55] (03PS1) 10Legoktm: composer.json: Document PHP version requirement [integration/docroot] - 10https://gerrit.wikimedia.org/r/386563 [01:08:48] (03PS1) 10Legoktm: Page: Don't call flush() in handleDirIndex() [integration/docroot] - 10https://gerrit.wikimedia.org/r/386564 [01:08:50] (03PS1) 10Legoktm: Show code coverage percent on index page [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) [01:08:52] (03CR) 10jerkins-bot: [V: 04-1] Show code coverage percent on index page [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [01:08:55] (03CR) 10Legoktm: [C: 032] Publish clover.xml files for machine-readable coverage information [integration/config] - 10https://gerrit.wikimedia.org/r/386543 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [01:08:56] (03PS2) 10Legoktm: Show code coverage percent on index page [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) [01:10:14] (03Merged) 10jenkins-bot: Publish clover.xml files for machine-readable coverage information [integration/config] - 10https://gerrit.wikimedia.org/r/386543 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [01:10:53] (03CR) 10Legoktm: [C: 032] composer.json: Document PHP version requirement [integration/docroot] - 10https://gerrit.wikimedia.org/r/386563 (owner: 10Legoktm) [01:11:37] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review: Create pretty landing page at https://doc.wikimedia.org/cover/ - https://phabricator.wikimedia.org/T146970#3711673 (10Legoktm) [01:14:45] (03Merged) 10jenkins-bot: composer.json: Document PHP version requirement [integration/docroot] - 10https://gerrit.wikimedia.org/r/386563 (owner: 10Legoktm) [01:14:47] (03CR) 10jenkins-bot: composer.json: Document PHP version requirement [integration/docroot] - 10https://gerrit.wikimedia.org/r/386563 (owner: 10Legoktm) [01:32:26] 10Release-Engineering-Team (Kanban), 10Scap (Tech Debt Sprint FY201718-Q2): Scap failing to rewrite submodule urls in beta - https://phabricator.wikimedia.org/T179013#3711683 (10mmodell) seems like deployment-sca03 has the correct remote URLs: ``` twentyafterfour@deployment-sca03:/srv/deployment/ores/deploy/s... [01:48:01] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017): Generate clover.xml files for JavaScript libraries - https://phabricator.wikimedia.org/T179051#3711690 (10Legoktm) [02:12:56] https://github.com/gotwarlost/istanbul/blob/master/lib/report/clover.js#L133 [02:13:11] sigh, they hardcoded the name as "All Files" [02:16:29] (03PS3) 10Legoktm: Show code coverage percent on index page [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) [04:22:16] PROBLEM - Puppet errors on deployment-ores-redis-01 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [04:49:50] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [04:52:00] (03CR) 10Umherirrender: "There are the last ones missing banana ;-)" [integration/config] - 10https://gerrit.wikimedia.org/r/386456 (owner: 10Umherirrender) [04:53:48] PROBLEM - Puppet errors on deployment-urldownloader is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [05:02:15] RECOVERY - Puppet errors on deployment-ores-redis-01 is OK: OK: Less than 1.00% above the threshold [0.0] [05:10:06] (03PS15) 10Umherirrender: Update test config [integration/config] - 10https://gerrit.wikimedia.org/r/380790 [05:10:37] (03CR) 10Umherirrender: "Patch Set 15: Rebased and removed voting from LinkedWiki" [integration/config] - 10https://gerrit.wikimedia.org/r/380790 (owner: 10Umherirrender) [05:14:51] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [05:33:50] RECOVERY - Puppet errors on deployment-urldownloader is OK: OK: Less than 1.00% above the threshold [0.0] [06:59:29] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review: Generate clover.xml files for JavaScript libraries - https://phabricator.wikimedia.org/T179051#3711811 (10Legoktm) Also unicodejs and visualeditor put their coverage in a subdirectory called `Chrome... [07:08:20] (03PS1) 10Legoktm: Bump RemexHtml coverage limit to 90 minutes [integration/config] - 10https://gerrit.wikimedia.org/r/386579 [07:08:44] 10Continuous-Integration-Infrastructure, 10RemexHtml: Figure out how to speed up RemexHtml coverage runs - https://phabricator.wikimedia.org/T179055#3711826 (10Legoktm) [07:09:16] (03CR) 10Legoktm: [C: 032] Bump RemexHtml coverage limit to 90 minutes [integration/config] - 10https://gerrit.wikimedia.org/r/386579 (owner: 10Legoktm) [07:11:19] (03Merged) 10jenkins-bot: Bump RemexHtml coverage limit to 90 minutes [integration/config] - 10https://gerrit.wikimedia.org/r/386579 (owner: 10Legoktm) [07:18:23] (03PS1) 10Legoktm: Sync MediaWiki core's clover.xml to docs.wm.o [integration/config] - 10https://gerrit.wikimedia.org/r/386580 [07:20:25] (03CR) 10Legoktm: "Hashar: Do you think this is OK to do? The last clover.xml file was 10MB. If it's too big I could write a script that strips all the infor" [integration/config] - 10https://gerrit.wikimedia.org/r/386580 (owner: 10Legoktm) [07:53:15] PROBLEM - Puppet errors on deployment-ores-redis-01 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [07:54:54] PROBLEM - Puppet errors on deployment-mira is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [08:28:15] RECOVERY - Puppet errors on deployment-ores-redis-01 is OK: OK: Less than 1.00% above the threshold [0.0] [08:34:56] RECOVERY - Puppet errors on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [08:48:42] (03CR) 10Hashar: "Thanks Giuseppe. I haven(t looked in docker-pkg yet though, but definitely plan to look into it soon." [integration/config] - 10https://gerrit.wikimedia.org/r/385996 (owner: 10Giuseppe Lavagetto) [08:55:53] PROBLEM - Puppet errors on deployment-mira is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [09:10:51] 10Continuous-Integration-Infrastructure, 10RemexHtml: Figure out how to speed up RemexHtml coverage runs - https://phabricator.wikimedia.org/T179055#3711945 (10hashar) On my local computer (stretch/php7): | phunit | 8 seconds | phpunit --coverage-html | 6 minutes [09:30:53] RECOVERY - Puppet errors on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [10:17:55] 10Continuous-Integration-Config, 10Goal, 10I18n, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 2 others: Configure banana checker for i18n files to run on all MediaWiki extensions and skins - https://phabricator.wikimedia.org/T94547#3712018 (10Aklapper) I wonder if this could be a #Go... [11:40:51] 10Gerrit: Provide description of linked Phabricator objects in tooltips - https://phabricator.wikimedia.org/T64053#3712167 (10Aklapper) IMHO that upstream ticket does not really explain what you are asking for. If you are "not sure how to create a polygerrit plugin that does this" you should explain over there w... [12:02:58] PROBLEM - Puppet errors on deployment-aqs01 is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [12:22:51] Yippee, build fixed! [12:22:51] Project selenium-GettingStarted » firefox,beta,Linux,BrowserTests build #567: 09FIXED in 50 sec: https://integration.wikimedia.org/ci/job/selenium-GettingStarted/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=BrowserTests/567/ [12:23:08] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [12:35:48] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [12:42:59] RECOVERY - Puppet errors on deployment-aqs01 is OK: OK: Less than 1.00% above the threshold [0.0] [13:24:17] PROBLEM - Puppet errors on integration-slave-docker-1006 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:30:04] PROBLEM - Puppet errors on integration-slave-docker-1002 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:33:13] PROBLEM - Puppet errors on integration-slave-docker-1005 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:33:59] PROBLEM - Puppet errors on deployment-aqs01 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [13:37:15] PROBLEM - Puppet errors on integration-slave-docker-1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:43:36] PROBLEM - Puppet errors on integration-slave-docker-1003 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [14:12:51] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [14:14:01] RECOVERY - Puppet errors on deployment-aqs01 is OK: OK: Less than 1.00% above the threshold [0.0] [14:34:59] PROBLEM - Puppet errors on deployment-aqs01 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [14:50:40] 10Gerrit: Provide description of linked Phabricator objects in tooltips - https://phabricator.wikimedia.org/T64053#3712455 (10demon) The upstream task is fine. [15:01:23] PROBLEM - English Wikipedia Main page on beta-cluster is CRITICAL: CRITICAL - Socket timeout after 10 seconds [15:06:11] RECOVERY - English Wikipedia Main page on beta-cluster is OK: HTTP OK: HTTP/1.1 200 OK - 47367 bytes in 1.069 second response time [15:10:00] RECOVERY - Puppet errors on deployment-aqs01 is OK: OK: Less than 1.00% above the threshold [0.0] [15:22:50] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [15:27:39] !log doing the dance: https://www.mediawiki.org/wiki/Continuous_integration/Jenkins#Hung_beta_code.2Fdb_update [15:27:45] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:27:50] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [15:29:59] !log Jenkins slave agent won't start: https://phabricator.wikimedia.org/P6195 [15:30:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:33:20] zeljkof: uno momento ^ [15:33:39] greg-g: no problemo :) [15:42:51] !log tried the gearman disable/enable, got one beta-scap run, but that's it... in a 1:1 now [15:42:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:55:22] PROBLEM - Puppet errors on integration-slave-jessie-1002 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [16:02:34] hasharAway: do you want to review https://gerrit.wikimedia.org/r/#/c/386565/ ? or is it ok if I self-merge it? [16:04:24] legoktm: he's away sick today :/ [16:27:38] !log fixed it. Had to offline/reonline deployment-tin repeatedly to get through the mediawiki-config-update post-merge backlog one by one. Now jobs are running on deployment-tin again [16:27:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:28:54] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review: Generate clover.xml files for JavaScript libraries - https://phabricator.wikimedia.org/T179051#3712776 (10Jdforrester-WMF) Hmm. Why use this clover XML file rather than the existing machine-readable... [16:46:40] twentyafterfour: I’m looking for a bit of help with my scap.cfg, if you find the time…. https://github.com/wikimedia/mediawiki-services-ores-deploy/blob/master/scap/scap.cfg [16:47:35] I’m deploying using scap -l “ores*.eqiad.wmnet”, which limits to just the new cluster machines. However, I don’t think that any of cmd*.sh are being run, because my virtualenv directory never gets rebuilt. [16:57:13] (03CR) 10Krinkle: [C: 04-1] "-1 for project name" (033 comments) [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [17:03:52] (03CR) 10Krinkle: [C: 04-1] Show code coverage percent on index page (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [17:04:24] (03CR) 10Krinkle: [C: 04-1] Show code coverage percent on index page (031 comment) [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [17:17:37] 10MediaWiki-Codesniffer: Add sniff to ensure doc blocks don't use "@cover", but "@covers" instead - https://phabricator.wikimedia.org/T176031#3713034 (10Krinkle) [17:17:40] 10MediaWiki-Codesniffer: Add sniff to ensure doc blocks don't use "@cover", but "@covers" instead - https://phabricator.wikimedia.org/T176031#3611736 (10Krinkle) p:05Triage>03Normal [17:21:52] PROBLEM - Puppet errors on deployment-mira is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [17:24:40] 10MediaWiki-Codesniffer: Add rule to require use of @covers in PHPUnit tests - https://phabricator.wikimedia.org/T179094#3713099 (10Krinkle) [17:25:56] 10Release-Engineering-Team, 10ORES, 10Scoring-platform-team (Current): Scap doesn't rebuilt virtualenv directory when deploying to ores* targets - https://phabricator.wikimedia.org/T179095#3713113 (10awight) [17:26:04] 10MediaWiki-Codesniffer: Add sniff to ensure doc blocks don't use "@cover", but "@covers" instead - https://phabricator.wikimedia.org/T176031#3713127 (10Legoktm) 05Open>03Resolved a:03Jdforrester-WMF This was implemented in {423c101fc0b4309e974018130ae28b839140c299}. [17:26:51] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review: Generate clover.xml files for JavaScript libraries - https://phabricator.wikimedia.org/T179051#3713138 (10Legoktm) >>! In T179051#3712776, @Jdforrester-WMF wrote: > Hmm. Why use this clover XML file... [17:26:53] 10MediaWiki-Codesniffer: Add sniff to ensure doc blocks don't use "@cover", but "@covers" instead - https://phabricator.wikimedia.org/T176031#3713144 (10Jdforrester-WMF) Oh, whoops, didn't look for a task. Thanks! [17:27:06] 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Kanban), 10Developer-Relations (Oct-Dec 2017), 10User-zeljkofilipin: Tech talk: Selenium tests in Node.js - https://phabricator.wikimedia.org/T171852#3713145 (10zeljkofilipin) [17:27:36] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review: Generate clover.xml files for JavaScript libraries - https://phabricator.wikimedia.org/T179051#3713151 (10Jdforrester-WMF) >>! In T179051#3713138, @Legoktm wrote: >>>! In T179051#3712776, @Jdforrest... [17:33:19] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review: Generate clover.xml files for JavaScript libraries - https://phabricator.wikimedia.org/T179051#3713198 (10Krinkle) >>! In T179051#3713151, @Jdforrester-WMF wrote: > Seems reasonable. Should we drop... [17:41:48] 10Continuous-Integration-Config, 10Goal, 10I18n, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 2 others: Configure banana checker for i18n files to run on all MediaWiki extensions and skins - https://phabricator.wikimedia.org/T94547#3713232 (10Umherirrender) 05Open>03Resolved a:0... [17:43:06] (03PS4) 10Legoktm: Show code coverage percent on index page [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) [17:43:52] 10Continuous-Integration-Config, 10Goal, 10I18n, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), and 2 others: Configure banana checker for i18n files to run on all MediaWiki extensions and skins - https://phabricator.wikimedia.org/T94547#3713250 (10Legoktm) @Umherirrender You are amazing.... [17:45:28] (03CR) 10Legoktm: Show code coverage percent on index page (034 comments) [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [17:51:25] 10Release-Engineering-Team, 10ORES, 10Patch-For-Review, 10Scoring-platform-team (Current): Scap doesn't rebuilt virtualenv directory when deploying to ores* targets - https://phabricator.wikimedia.org/T179095#3713285 (10awight) Now I'm seeing a mostly empty venv directory... [17:52:59] 10MediaWiki-Codesniffer: Add sniff to ensure doc blocks don't use "@cover", but "@covers" instead - https://phabricator.wikimedia.org/T176031#3713290 (10Umherirrender) The task was created because the sniff only looks for function docs, not class docs where a @covers could be added to. In my opinion that part i... [17:53:37] 10MediaWiki-Codesniffer: Add sniff to ensure doc blocks don't use "@cover", but "@covers" instead - https://phabricator.wikimedia.org/T176031#3713292 (10Legoktm) 05Resolved>03Open Ah, you're right. [18:01:53] RECOVERY - Puppet errors on deployment-mira is OK: OK: Less than 1.00% above the threshold [0.0] [18:01:55] 10Release-Engineering-Team, 10ORES, 10Patch-For-Review, 10Scoring-platform-team (Current): Scap doesn't rebuilt virtualenv directory when deploying to ores* targets - https://phabricator.wikimedia.org/T179095#3713306 (10awight) The target machine's logs don't say exactly what happens, I see: ``` Executing... [18:06:17] 10Release-Engineering-Team, 10ORES, 10Patch-For-Review, 10Scoring-platform-team (Current): Scap doesn't rebuilt virtualenv directory when deploying to ores* targets - https://phabricator.wikimedia.org/T179095#3713331 (10awight) Running in a user virtualenv, I obtained the clue: ``` pip install --use-wheel... [18:06:56] (03PS5) 10Krinkle: Show code coverage percent on index page [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [18:07:54] 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Kanban), 10Developer-Relations (Oct-Dec 2017), 10User-zeljkofilipin: Tech talk: Selenium tests in Node.js - https://phabricator.wikimedia.org/T171852#3713332 (10zeljkofilipin) Sent announcement: [[ https://lists.wikimedia.org/pipermail/wikitech-l/... [18:08:15] no_justification i supose this https://gerrit-review.googlesource.com/?polygerrit=0#/c/gerrit/+/106713/ will make blocking unblocking easier? :) [18:08:38] (03CR) 10Krinkle: "Made 3 minor changes:" [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [18:11:06] (03CR) 10Legoktm: "I think that all looks fine for now." [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [18:11:15] (03CR) 10Krinkle: [C: 032] Page: Don't call flush() in handleDirIndex() [integration/docroot] - 10https://gerrit.wikimedia.org/r/386564 (owner: 10Legoktm) [18:12:16] 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Kanban), 10Developer-Relations (Oct-Dec 2017), 10User-zeljkofilipin: Tech talk: Selenium tests in Node.js - https://phabricator.wikimedia.org/T171852#3478168 (10zeljkofilipin) Added to Phabricator calendar (E766) and Google calendar (WMF Fun & Lea... [18:13:02] (03Merged) 10jenkins-bot: Page: Don't call flush() in handleDirIndex() [integration/docroot] - 10https://gerrit.wikimedia.org/r/386564 (owner: 10Legoktm) [18:13:08] (03CR) 10jenkins-bot: Page: Don't call flush() in handleDirIndex() [integration/docroot] - 10https://gerrit.wikimedia.org/r/386564 (owner: 10Legoktm) [18:13:16] (03CR) 10Krinkle: [C: 032] Show code coverage percent on index page [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [18:14:04] (03CR) 10Krinkle: [C: 032] "Yeah, agreed. Although maybe without the table borders. Less clutter is better here. But there are other ways to make it look table-ish." [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [18:18:09] (03Merged) 10jenkins-bot: Show code coverage percent on index page [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [18:18:14] (03CR) 10jenkins-bot: Show code coverage percent on index page [integration/docroot] - 10https://gerrit.wikimedia.org/r/386565 (https://phabricator.wikimedia.org/T146970) (owner: 10Legoktm) [18:18:48] https://doc.wikimedia.org/cover/ yay [18:20:03] Krinkle: hmm, looks like for some of the repos there's so little coverage that the percentage bar isn't wide enough [18:21:19] legoktm: Ah, yeah, the number is white [18:21:24] on light grey [18:21:32] And centred [18:21:34] to fall out [18:21:36] on the left side [18:21:42] Maybe we're using the bootstrap component incorrectly [18:22:08] IIRC the documentation said to use min-width or something [18:22:10] let me find it [18:22:27] https://getbootstrap.com/docs/3.3/components/#progress-label [18:22:53] also I think we can just round it to an integer [18:23:06] legoktm: https://getbootstrap.com/docs/3.3/components/#progress-label [18:23:09] Right [18:23:14] Yes [18:23:17] :) [18:23:59] so round to integer means max of 3 characters (XX%), so min-width: 3em? [18:25:19] legoktm: Right, but how much % is it when it gets to 3 characters wide naturally? [18:25:24] width* [18:25:29] as opposed to <10% [18:25:38] 2em should suffice, but not 100% sure [18:25:44] hmm [18:25:56] Ah, you're right. it's too small [18:26:02] 12% is 1 character wide [18:26:04] PROBLEM - Free space - all mounts on integration-slave-jessie-1002 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1002.diskspace._mnt.byte_percentfree (No valid datapoints found)integration.integration-slave-jessie-1002.diskspace._srv.byte_percentfree (<100.00%) [18:26:09] yeah, 3em looks right [18:27:14] Although it would be nice to output 2em if the number is <10 [18:28:08] legoktm: it seems to be broken for PasswordBlacklist [18:28:35] or... [18:28:43] I don't get it. It's a 100% implied based on 0/0 [18:28:43] Krinkle: https://github.com/wikimedia/mediawiki-libs-PasswordBlacklist/blob/master/tests/PasswordBlacklistTest.php [18:28:48] okay, different interpretation I guess [18:28:57] empty class [18:29:13] Yeah, the src is empty as well [18:29:21] arguably a 100% of 0 is 0. [18:29:39] Anyway :) [18:29:42] It's not as broken as I thought [18:32:44] 10Release-Engineering-Team, 10ORES, 10Patch-For-Review, 10Scoring-platform-team (Current): Scap doesn't rebuilt virtualenv directory when deploying to ores* targets - https://phabricator.wikimedia.org/T179095#3713427 (10awight) I've rebuilt the wheels again, on ores-misc-01. Python version is the same, ma... [18:35:35] (03PS1) 10Legoktm: cover: Round to integers, and set min-width so percent is visible [integration/docroot] - 10https://gerrit.wikimedia.org/r/386676 [18:35:43] Krinkle: ^ [18:36:52] (03CR) 10Krinkle: [C: 032] cover: Round to integers, and set min-width so percent is visible [integration/docroot] - 10https://gerrit.wikimedia.org/r/386676 (owner: 10Legoktm) [18:37:14] (03Merged) 10jenkins-bot: cover: Round to integers, and set min-width so percent is visible [integration/docroot] - 10https://gerrit.wikimedia.org/r/386676 (owner: 10Legoktm) [18:37:20] (03CR) 10jenkins-bot: cover: Round to integers, and set min-width so percent is visible [integration/docroot] - 10https://gerrit.wikimedia.org/r/386676 (owner: 10Legoktm) [18:37:35] (03PS1) 10Legoktm: cover: Avoid division by zero warnings [integration/docroot] - 10https://gerrit.wikimedia.org/r/386677 [18:37:54] Krinkle: and ^ for passwordblacklist [18:44:38] legoktm: hm.. RemexHtml should work, right? [18:44:47] that's a different issue [18:44:54] https://phabricator.wikimedia.org/T179055 [18:44:57] it's just too slow [18:45:08] it hasn't had a successful coverage run in months [18:45:10] legoktm: wanna make it default to 100% for 0/0 to match PHPUnit? [18:45:28] sure [18:45:48] or 1, I suppose [18:45:54] given * 100 [18:45:57] didn't see that [18:45:59] anyway [18:46:10] yeah, I used 1 [18:46:23] (03PS2) 10Legoktm: cover: Avoid division by zero warnings [integration/docroot] - 10https://gerrit.wikimedia.org/r/386677 [18:46:25] (03CR) 10Krinkle: [C: 032] cover: Avoid division by zero warnings [integration/docroot] - 10https://gerrit.wikimedia.org/r/386677 (owner: 10Legoktm) [18:47:07] 10Continuous-Integration-Infrastructure, 10RemexHtml: Figure out how to speed up RemexHtml coverage runs - https://phabricator.wikimedia.org/T179055#3713440 (10Legoktm) On my laptop with php 7.1 it hits the memory limit around 66% and dies. But let's give PHP 7 a shot! I can't think of any reason why it would... [18:47:46] Also, why does OOjs (which we put a lot of effort getting to 100%) not show a number? :-P [18:48:13] James_F: I don't think the clover.xml patch landed yet [18:48:58] legoktm: Oh, right, I didn't include one of the files in my commit to fix the repo. Bleh. [18:49:05] (03Merged) 10jenkins-bot: cover: Avoid division by zero warnings [integration/docroot] - 10https://gerrit.wikimedia.org/r/386677 (owner: 10Legoktm) [18:49:11] (03CR) 10jenkins-bot: cover: Avoid division by zero warnings [integration/docroot] - 10https://gerrit.wikimedia.org/r/386677 (owner: 10Legoktm) [18:49:38] And now I'm in meetings. [18:50:58] (03PS1) 10Legoktm: Run RemexHtml coverage on PHP 7 [integration/config] - 10https://gerrit.wikimedia.org/r/386679 (https://phabricator.wikimedia.org/T179055) [18:57:26] 10Release-Engineering-Team, 10ORES, 10Patch-For-Review, 10Scoring-platform-team (Current): Scap doesn't rebuilt virtualenv directory when deploying to ores* targets - https://phabricator.wikimedia.org/T179095#3713459 (10awight) I tried `pip install pip==1.5.6`, then rebuilt wheels, but we're still getting... [18:58:18] paladox: Why? It's easy enough via the SSH commands :) [18:58:24] Although I guess people like guis [18:58:31] heh [18:58:42] I guess name suggestion is a plus [18:58:52] heh [18:58:53] yeh [18:58:59] but it wont work if the user is blocked [18:59:15] Decoupling the block permission from admin rights would be nice too [18:59:22] Then you could delegate it to like "moderators" [18:59:26] yeh [18:59:36] it would reduce spam too if there's any [18:59:38] Kinda wanted to do the same with Phab [18:59:57] yeh [19:00:09] im currently working on fixing the search bar in there [19:00:17] it's broken, only autocomplete works [19:00:44] though it's probaly because of the switch to paper-button [19:01:15] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review: Create pretty landing page at https://doc.wikimedia.org/cover/ - https://phabricator.wikimedia.org/T146970#3713462 (10Legoktm) Woohoo, with help from @Krinkle it looks a lot better already. Two thin... [19:01:24] 10MediaWiki-Codesniffer: Add rule to require use of @covers in PHPUnit tests - https://phabricator.wikimedia.org/T179094#3713087 (10Tgr) A lot of extensions do not follow the `tests/phpunit` directory structure. [19:01:51] Project selenium-CentralNotice » chrome,beta,Windows 7,BrowserTests build #560: 15ABORTED in 3 hr 0 min: https://integration.wikimedia.org/ci/job/selenium-CentralNotice/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Windows%207,label=BrowserTests/560/ [19:01:59] Project selenium-CentralNotice » firefox,beta,Windows 7,BrowserTests build #560: 15ABORTED in 3 hr 0 min: https://integration.wikimedia.org/ci/job/selenium-CentralNotice/BROWSER=firefox,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Windows%207,label=BrowserTests/560/ [19:02:09] thye need to rewrite there whole blocking system so that a:, you can search for blocked users too and block them [19:02:16] b: show a list of blocked users [19:21:17] Can someone confirm for me that scap3 is able to deploy from a non-master branch, without any trickery? I’m hoping to merge to a stable branch, which is represented in gerrit as a true branch, and check that out on tin to deploy. [19:22:20] no_justification: ^ [19:24:20] awight: it should work from any branch [19:24:48] it tags HEAD when you run `scap deploy` so it actually deploys from a tag each time [19:25:26] (03PS16) 10Umherirrender: Update test config [integration/config] - 10https://gerrit.wikimedia.org/r/380790 [19:26:01] (03CR) 10Umherirrender: "Added npm for BlueSpiceSubPageTree - I05b4a78c5043a7ff78634c255f9f43d79aab26fd" [integration/config] - 10https://gerrit.wikimedia.org/r/380790 (owner: 10Umherirrender) [19:28:51] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review: Generate clover.xml files for JavaScript libraries, removing the karma JSON report files if they exist - https://phabricator.wikimedia.org/T179051#3713539 (10Jdforrester-WMF) [19:29:09] twentyafterfour: ty! [19:33:30] twentyafterfour: > fatal: reference is not a tree: fc68253702867d0b9c2efa17da52589408ad6cbe [19:33:38] strange... [19:33:47] PROBLEM - Puppet errors on deployment-eventlog02 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [19:34:35] twentyafterfour: apologies for the spam, I used “scap -r HEAD -f” and the deployment looks healthy now. [19:35:59] PROBLEM - Puppet errors on deployment-aqs01 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [19:36:36] hmm [19:37:25] awight: are you still seeing the submodule rewrite issue? I couldn't reproduce last night [19:37:33] re: T179013 [19:37:33] T179013: Scap failing to rewrite submodule urls in beta - https://phabricator.wikimedia.org/T179013 [19:37:45] twentyafterfour: I haven’t tried today, but I will as soon as this other fire is out... [19:42:35] legoktm: https://doc.wikimedia.org/cover/ looks great :] [19:49:21] no_justification lol they are thinking of renaming project to repository https://groups.google.com/forum/#!topic/repo-discuss/Rdn6Nk_Txwk heh [19:49:44] (for you to read later, i know your dealing with -operations :)) [20:04:21] aha i figured the problem out, we need to use dom-repeat since we were presuming account.<> was not an array. [20:04:31] it took me like an hour to figure that out heh [20:11:00] RECOVERY - Puppet errors on deployment-aqs01 is OK: OK: Less than 1.00% above the threshold [0.0] [20:13:49] RECOVERY - Puppet errors on deployment-eventlog02 is OK: OK: Less than 1.00% above the threshold [0.0] [20:58:00] 10Release-Engineering-Team (Kanban), 10Scap (Tech Debt Sprint FY201718-Q2): Scap failing to rewrite submodule urls in beta - https://phabricator.wikimedia.org/T179013#3713816 (10mmodell) [21:04:52] no_justification i finally got the group thing fixed (one week later heh) [21:14:08] PROBLEM - Puppet errors on deployment-mathoid is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [21:49:44] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Scap (Tech Debt Sprint FY201718-Q2), 10ORES, and 3 others: Support git-lfs files in gerrit - https://phabricator.wikimedia.org/T171758#3713875 (10awight) [21:50:27] 10Beta-Cluster-Infrastructure, 10ORES, 10Scoring-platform-team: ORESFetchScoreJob: RuntimeException No model available for [goodfaith] - https://phabricator.wikimedia.org/T178792#3713878 (10Halfak) p:05Triage>03High [21:53:14] 10Beta-Cluster-Infrastructure, 10Scoring-platform-team: FetchScoreJob is trying to update scores for nonexistent models - https://phabricator.wikimedia.org/T177967#3676372 (10Halfak) p:05Triage>03Normal [21:53:19] 10Beta-Cluster-Infrastructure, 10Scoring-platform-team, 10Beta-Cluster-reproducible: FetchScoreJob is trying to update scores for nonexistent models - https://phabricator.wikimedia.org/T177967#3713895 (10awight) p:05Normal>03Triage [21:54:08] RECOVERY - Puppet errors on deployment-mathoid is OK: OK: Less than 1.00% above the threshold [0.0] [22:04:49] i like the new polygerrit header in https://gerrit-review.googlesource.com/#/c/gerrit/+/136850/ [22:26:05] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Watching / External), 10Performance-Team, 10Availability (Multiple-active-datacenters): Performance Q2 2017/18 goal: Install and use mcrouter in deployment-prep - https://phabricator.wikimedia.org/T151466#3713969 (10aaron) [22:26:07] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Watching / External), 10Availability (Multiple-active-datacenters): Create new instances memc05 and memc06 running memcached - https://phabricator.wikimedia.org/T175418#3713968 (10aaron) 05Open>03Resolved [22:28:06] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017): Generate clover.xml files for JavaScript libraries, removing the karma JSON report files if they exist - https://phabricator.wikimedia.org/T179051#3713971 (10Jdforrester-WMF) Any repos left to do? [22:37:39] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), 10Patch-For-Review: Create pretty landing page at https://doc.wikimedia.org/cover/ - https://phabricator.wikimedia.org/T146970#3713977 (10Legoktm) [22:37:41] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017): Generate clover.xml files for JavaScript libraries, removing the karma JSON report files if they exist - https://phabricator.wikimedia.org/T179051#3713975 (10Legoktm) 05Open>03Resolved Nope, all the repos without inf...