[02:30:46] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:43:30] PROBLEM - Puppet errors on deployment-mira is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [02:49:21] PROBLEM - Puppet errors on deployment-tin is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [03:16:14] (03PS3) 10Legoktm: Ignore maintenance scripts in ClassMatchesFilenameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398621 (https://phabricator.wikimedia.org/T178725) [03:16:16] (03PS2) 10Legoktm: Be aware of extension MediaWiki compatibility [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398625 (https://phabricator.wikimedia.org/T175465) [03:16:19] (03CR) 10Legoktm: Ignore maintenance scripts in ClassMatchesFilenameSniff (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398621 (https://phabricator.wikimedia.org/T178725) (owner: 10Legoktm) [03:55:18] 10MediaWiki-Codesniffer: Upgrade to squizlabs/php_codesniffer 3.2.0 - https://phabricator.wikimedia.org/T183074#3842719 (10Legoktm) [03:55:30] (03PS2) 10Legoktm: Update PHP_CodeSniffer to 3.2.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398050 (https://phabricator.wikimedia.org/T183074) (owner: 10Ricordisamoa) [03:59:16] (03PS1) 10Legoktm: Use upstream Generic.PHP.DiscourageGoto [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398671 [04:47:37] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<33.33%) [04:54:09] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [04:59:28] PROBLEM - Puppet staleness on deployment-restbase01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0] [05:14:09] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [05:22:27] PROBLEM - Puppet staleness on deployment-restbase02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0] [06:35:49] PROBLEM - Puppet errors on deployment-aqs03 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [06:38:39] (03PS1) 10Legoktm: Add sniff for using is_int over is_integer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398677 (https://phabricator.wikimedia.org/T173175) [06:41:08] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff to prefer short is_int over is_integer - https://phabricator.wikimedia.org/T173175#3842766 (10Legoktm) a:03Legoktm [07:10:52] RECOVERY - Puppet errors on deployment-aqs03 is OK: OK: Less than 1.00% above the threshold [0.0] [07:17:39] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [07:22:39] (03PS1) 10Legoktm: Check function definitions for the same variable name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398678 (https://phabricator.wikimedia.org/T164653) [07:22:41] (03PS1) 10Legoktm: Require that an explicit visiblity is set on methods and properties [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398679 (https://phabricator.wikimedia.org/T164653) [07:30:37] PROBLEM - puppet last run on contint2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [07:38:52] 10MediaWiki-Codesniffer, 10Wikidata, 10Patch-For-Review: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS - https://phabricator.wikimedia.org/T164653#3842800 (10Legoktm) I tried enabling `Squiz.WhiteSpace.FunctionSpacing` but it did not play well with global functions (pr... [08:00:37] RECOVERY - puppet last run on contint2001 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [08:16:36] 10Beta-Cluster-Infrastructure, 10Android-app-Bugs, 10Commons, 10Wikipedia-Android-App-Backlog: Testing out 2FA in Wikimedia Commons Android app - https://phabricator.wikimedia.org/T183079#3842817 (10maskaravivek) [08:27:51] 10Beta-Cluster-Infrastructure, 10Android-app-Bugs, 10Commons, 10Wikipedia-Android-App-Backlog: Testing out 2FA in Wikimedia Commons Android app - https://phabricator.wikimedia.org/T183079#3842817 (10Legoktm) What's your username on beta? I can give you admin rights there. [08:40:29] 10Gerrit, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Clean up mediawiki/extensions/Wikibase ACL - https://phabricator.wikimedia.org/T183081#3842843 (10Legoktm) [08:47:48] 10Continuous-Integration-Config, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Phan did not catch missing use statement in Wikibase patch - https://phabricator.wikimedia.org/T183083#3842867 (10Legoktm) [09:09:17] (03CR) 10MaxSem: [C: 032] Ignore maintenance scripts in ClassMatchesFilenameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398621 (https://phabricator.wikimedia.org/T178725) (owner: 10Legoktm) [09:10:00] (03Merged) 10jenkins-bot: Ignore maintenance scripts in ClassMatchesFilenameSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398621 (https://phabricator.wikimedia.org/T178725) (owner: 10Legoktm) [09:29:30] 10Beta-Cluster-Infrastructure, 10Android-app-Bugs, 10Commons, 10Wikipedia-Android-App-Backlog: Testing out 2FA in Wikimedia Commons Android app - https://phabricator.wikimedia.org/T183079#3842892 (10maskaravivek) Its `Maskaravivek`. Thanks @Legoktm [09:32:49] 10MediaWiki-Codesniffer, 10Patch-For-Review: ClassMatchesFilename.WrongCase should ignore maintenance scripts - https://phabricator.wikimedia.org/T178725#3842894 (10Legoktm) 05Open>03Resolved [10:06:52] 10Beta-Cluster-Infrastructure, 10Android-app-Bugs, 10Commons, 10Wikipedia-Android-App-Backlog: Testing out 2FA in Wikimedia Commons Android app - https://phabricator.wikimedia.org/T183079#3842899 (10Legoktm) Done. (change visibility) 10:05, 17 December 2017 Legoktm (talk | contribs | block) changed gro... [10:47:54] 10Beta-Cluster-Infrastructure, 10Android-app-Bugs, 10Commons, 10Wikipedia-Android-App-Backlog, 10User-Luke081515: Testing out 2FA in Wikimedia Commons Android app - https://phabricator.wikimedia.org/T183079#3842912 (10Luke081515) 05Open>03Resolved a:03Luke081515 Looks like the task is done. [10:48:04] 10Beta-Cluster-Infrastructure, 10Android-app-Bugs, 10Commons, 10Wikipedia-Android-App-Backlog, 10User-Luke081515: Testing out 2FA in Wikimedia Commons Android app - https://phabricator.wikimedia.org/T183079#3842916 (10Luke081515) a:05Luke081515>03Legoktm [14:37:13] 10Continuous-Integration-Config, 10MinusX, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add MinusX to MediaWiki extensions and PHP library repos - https://phabricator.wikimedia.org/T175794#3843149 (10Albert221) [14:52:40] 10Gerrit, 10Release-Engineering-Team: Unable to log in into gerrit: "Cannot assign user name "ashley" to account ; name already in use." - https://phabricator.wikimedia.org/T181945#3843164 (10ashley) >>! In T181945#3842472, @demon wrote: > I'm sooooooo so so so so sorry for letting this slip. I've... [15:22:14] 10MediaWiki-Codesniffer, 10Patch-For-Review: ClassMatchesFilename.WrongCase should ignore maintenance scripts - https://phabricator.wikimedia.org/T178725#3843191 (10Huji) @Legoktm the patch is merged now, but I think it should have been programmed slightly differently: the `isMaintenanceScript` should have bee... [16:31:15] 10MediaWiki-Codesniffer, 10Patch-For-Review: Upgrade to squizlabs/php_codesniffer 3.2.0 - https://phabricator.wikimedia.org/T183074#3842719 (10Ricordisamoa) It should be noted that the old-style `@codingStandards` comments, although deprecated, will continue to work until PHP_CodeSniffer 4. Are you aware of an... [17:57:50] (03CR) 10Thiemo Kreuz (WMDE): "This looks like a duplicate implementation of the existing Generic_Sniffs_PHP_ForbiddenFunctionsSniff. Why not just use this, and configur" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398677 (https://phabricator.wikimedia.org/T173175) (owner: 10Legoktm) [17:59:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "I would like to see this enforced on all code bases. How many exceptions do currently exist in, let's say, the core code base?" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398679 (https://phabricator.wikimedia.org/T164653) (owner: 10Legoktm) [18:04:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "This is a trivial one that really should not have any exceptions. I can think of code that uses duplicate function parameters as a feature" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398678 (https://phabricator.wikimedia.org/T164653) (owner: 10Legoktm) [18:09:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Use upstream Generic.PHP.DiscourageGoto [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398671 (owner: 10Legoktm) [18:54:28] PROBLEM - Puppet errors on deployment-secureredirexperiment is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:05:11] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [19:25:01] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff to prefer short is_int over is_integer - https://phabricator.wikimedia.org/T173175#3843344 (10Ricordisamoa) [19:43:41] 10MediaWiki-Codesniffer: Detect use of create_function with codesniffer - https://phabricator.wikimedia.org/T181865#3843349 (10Ricordisamoa) [20:20:54] PROBLEM - Puppet errors on deployment-ms-be04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:27:36] Yippee, build fixed! [20:27:36] Project selenium-Wikibase-chrome ยป chrome,beta,Linux,DebianJessie && contintLabsSlave build #45: 09FIXED in 40 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase-chrome/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=DebianJessie%20&&%20contintLabsSlave/45/ [20:46:29] PROBLEM - Puppet errors on deployment-ms-be03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:49:10] PROBLEM - Puppet errors on deployment-mediawiki06 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:55:13] PROBLEM - Puppet errors on deployment-mediawiki05 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:56:10] PROBLEM - Puppet errors on deployment-mediawiki04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]