[02:05:25] weird [02:53:32] * twentyafterfour cannot reproduce by disabling Project Details [02:54:14] ah it really is only on /tag/ [03:12:02] Project mediawiki-core-code-coverage build #3211: 04FAILURE in 12 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/3211/ [04:42:07] aw [05:04:41] Project mediawiki-core-code-coverage build #3212: 04STILL FAILING in 12 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/3212/ [08:27:08] 10Release-Engineering-Team, 10GitHub-Mirrors: Enable Travis CI builds for wikimedia-lucene-explain-parser - https://phabricator.wikimedia.org/T183533#3856238 (10Smalyshev) [08:57:15] Krinkle: upstreamed at https://secure.phabricator.com/T13033 [08:58:05] Thanks for debugging the issue, it looks like it's definitely a phabricator bug. [09:00:49] (03PS3) 10Hashar: docker: convert ci-src-setup to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399754 (https://phabricator.wikimedia.org/T177276) [09:01:04] (03CR) 10Hashar: [C: 032] docker: convert ci-src-setup to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399754 (https://phabricator.wikimedia.org/T177276) (owner: 10Hashar) [09:02:53] (03Merged) 10jenkins-bot: docker: convert ci-src-setup to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399754 (https://phabricator.wikimedia.org/T177276) (owner: 10Hashar) [09:04:02] mediawiki-core-php70-phan-docker mwext-php70-phan-docker [09:08:33] !log updating mediawiki-core-php70-phan-docker mwext-php70-phan-docker jobs to the new ci-src-setup docker image mediawiki-core-php70-phan-docker mwext-php70-phan-docker [09:08:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:08:45] !log updating mediawiki-core-php70-phan-docker mwext-php70-phan-docker jobs to the new ci-src-setup docker image https://gerrit.wikimedia.org/r/399754 [09:08:50] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:09:44] f*** [09:14:41] (03PS1) 10Hashar: Fix ci-src-setup image name in JJB [integration/config] - 10https://gerrit.wikimedia.org/r/399789 [09:15:46] Yippee, build fixed! [09:15:46] Project mediawiki-core-code-coverage build #3213: 09FIXED in 1 hr 31 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/3213/ [09:16:17] (03PS2) 10Hashar: Fix ci-src-setup image name in JJB [integration/config] - 10https://gerrit.wikimedia.org/r/399789 [09:17:18] !log Fixed mediawiki-core-php70-phan-docker mwext-php70-phan-docker jobs that used a wrong Docker image name | https://gerrit.wikimedia.org/r/399789 [09:17:23] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [09:20:09] (03CR) 10Hashar: [C: 032] Fix ci-src-setup image name in JJB [integration/config] - 10https://gerrit.wikimedia.org/r/399789 (owner: 10Hashar) [09:21:21] (03Merged) 10jenkins-bot: Fix ci-src-setup image name in JJB [integration/config] - 10https://gerrit.wikimedia.org/r/399789 (owner: 10Hashar) [09:34:11] (03PS1) 10Hashar: Convert ci-src-setup-simple to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399791 (https://phabricator.wikimedia.org/T177276) [09:34:16] (03CR) 10Hashar: [C: 032] Convert ci-src-setup-simple to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399791 (https://phabricator.wikimedia.org/T177276) (owner: 10Hashar) [09:35:41] (03Merged) 10jenkins-bot: Convert ci-src-setup-simple to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399791 (https://phabricator.wikimedia.org/T177276) (owner: 10Hashar) [09:46:44] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Discovery, 10Wikimedia-Portals, and 2 others: Create a Jenkins Job that builds the portal deployment artifacts in CI - https://phabricator.wikimedia.org/T179694#3856309 (10hashar) 05Open>03Resolved Thank you very much @greg and @de... [09:55:16] Reedy no_justification twentyafterfour: can you disable https://phabricator.wikimedia.org/p/Perpetualamb3606/ please, spamming [09:58:31] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3856327 (10zeljkofilipin) Results for the above script: P6499 (mwv-stretch). [10:36:25] (03PS1) 10Hashar: Convert tox docker images to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399793 (https://phabricator.wikimedia.org/T177276) [11:02:56] (03PS2) 10Hashar: Convert tox docker images to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399793 (https://phabricator.wikimedia.org/T177276) [11:04:55] (03PS3) 10Hashar: Convert tox docker images to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399793 (https://phabricator.wikimedia.org/T177276) [11:05:06] (03CR) 10Hashar: [C: 032] Convert tox docker images to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399793 (https://phabricator.wikimedia.org/T177276) (owner: 10Hashar) [11:06:22] (03Merged) 10jenkins-bot: Convert tox docker images to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399793 (https://phabricator.wikimedia.org/T177276) (owner: 10Hashar) [12:39:26] (03PS1) 10Hashar: Convert lintr docker image to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399801 (https://phabricator.wikimedia.org/T177276) [12:43:57] (03CR) 10Hashar: [C: 032] Convert lintr docker image to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399801 (https://phabricator.wikimedia.org/T177276) (owner: 10Hashar) [12:43:59] 10Release-Engineering-Team (Kanban), 10Collaboration-Team-Triage, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review, 10User-zeljkofilipin: Port Echo Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T171848#3856546 (10zeljkofilipin) p:05Low>03Nor... [12:45:29] (03Merged) 10jenkins-bot: Convert lintr docker image to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/399801 (https://phabricator.wikimedia.org/T177276) (owner: 10Hashar) [13:17:03] (03Abandoned) 10Hashar: Convert ci-jessie to use docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/385996 (owner: 10Giuseppe Lavagetto) [13:19:41] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: mwext-php70-phan-docker should've php-curl extension installed - https://phabricator.wikimedia.org/T183322#3856622 (10hashar) The problem is ci-src-setup is a very basic container. It is used to checkout the code and run composer install. The test ru... [13:26:35] (03PS2) 10Hashar: Add php7.0-curl to ci-src-setup [integration/config] - 10https://gerrit.wikimedia.org/r/399318 (https://phabricator.wikimedia.org/T183322) (owner: 10Florianschmidtwelzow) [13:28:02] (03CR) 10Hashar: "Rebased since I have changed the build system." [integration/config] - 10https://gerrit.wikimedia.org/r/399318 (https://phabricator.wikimedia.org/T183322) (owner: 10Florianschmidtwelzow) [13:28:55] (03CR) 10Hashar: [C: 032] Add php7.0-curl to ci-src-setup [integration/config] - 10https://gerrit.wikimedia.org/r/399318 (https://phabricator.wikimedia.org/T183322) (owner: 10Florianschmidtwelzow) [13:29:59] (03Merged) 10jenkins-bot: Add php7.0-curl to ci-src-setup [integration/config] - 10https://gerrit.wikimedia.org/r/399318 (https://phabricator.wikimedia.org/T183322) (owner: 10Florianschmidtwelzow) [13:30:54] 10Continuous-Integration-Infrastructure (shipyard), 10Patch-For-Review: mwext-php70-phan-docker should've php-curl extension installed - https://phabricator.wikimedia.org/T183322#3856669 (10hashar) a:03Florian [13:33:02] (03PS1) 10Hashar: Update ci-src-setup in mediawiki-core-php70-phan-docker [integration/config] - 10https://gerrit.wikimedia.org/r/399807 [13:36:06] (03CR) 10Hashar: [C: 032] Update ci-src-setup in mediawiki-core-php70-phan-docker [integration/config] - 10https://gerrit.wikimedia.org/r/399807 (owner: 10Hashar) [13:37:31] (03Merged) 10jenkins-bot: Update ci-src-setup in mediawiki-core-php70-phan-docker [integration/config] - 10https://gerrit.wikimedia.org/r/399807 (owner: 10Hashar) [13:39:19] 10Continuous-Integration-Infrastructure (shipyard), 10Patch-For-Review: mwext-php70-phan-docker should've php-curl extension installed - https://phabricator.wikimedia.org/T183322#3856692 (10hashar) 05Open>03Resolved I did a rebuild of the CirrusSearch patch and it passed fine. https://integration.wikimedia... [13:46:19] (03Abandoned) 10Hashar: Convert php to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/388451 (owner: 10Giuseppe Lavagetto) [13:49:17] 10Release-Engineering-Team (Kanban), 10releng-201718-q1, 10MediaWiki-General-or-Unknown, 10Epic, and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3856703 (10zeljkofilipin) [13:59:26] (03CR) 10Hashar: Convert npm, npm-test to docker-pkg (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/388450 (owner: 10Giuseppe Lavagetto) [14:02:30] (03PS4) 10Hashar: Convert npm, npm-test to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/388450 (owner: 10Giuseppe Lavagetto) [14:05:10] zeljkof: https://phabricator.wikimedia.org/T181353 that is a nice report :) [14:05:40] hashar: I am really proud of it :) [14:05:49] I hope it will be useful [14:06:25] zeljkof: though a table might be more practical ? :) [14:06:45] thought of that myself, but too late :) [14:08:05] let me try :) [14:11:46] please do [14:11:59] some vim table plugin would probably help [14:12:17] zeljkof: yeah well I am doing some regex search and replace :D [14:12:31] notepad++ is mostly useful for such things as well [14:14:27] hmm [14:14:59] Sagan: notepad++ has features/plugins to create markdown/text tables? [14:15:09] zeljkof: it actually it is faster to just write a quick script that process the output files [14:15:36] zeljkof: not sure, I guess no, but if I need to format big text things, I usually use notepad++ to edit multiple lines at once, or create macros [14:15:41] hashar: could be, since text is pretty much not structured [14:16:16] hashar: I remeber that quote: A programmer is a person, who spends 2 weeks on automating a task that actually takes 10 minutes :D [14:16:20] Sagan: vim has some plugins that can transform text to tables, but I would have to google it [14:27:08] zeljkof: I am going to do it [14:28:19] hashar: be bold! :D [14:32:36] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3856800 (10zeljkofilipin) @bd808 @dduvall I would like to set up CI for #mediawiki-vagrant. The g... [14:38:49] zeljkof: done https://phabricator.wikimedia.org/T181353 :D [14:38:58] 12 minutes, not too bad :) [14:39:43] hashar: looks good! [14:39:46] (03CR) 10Hashar: [C: 032] Convert npm, npm-test to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/388450 (owner: 10Giuseppe Lavagetto) [14:40:04] hashar: next steps for vagrant CI https://phabricator.wikimedia.org/T183456#3856800 [14:40:07] (03PS5) 10Hashar: Convert npm, npm-test to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/388450 (https://phabricator.wikimedia.org/T177276) (owner: 10Giuseppe Lavagetto) [14:40:09] (03CR) 10Hashar: [C: 032] Convert npm, npm-test to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/388450 (https://phabricator.wikimedia.org/T177276) (owner: 10Giuseppe Lavagetto) [14:40:11] not sure if I'm doing it wrong [14:40:36] havent you ever connected to a labs instance???? [14:42:55] and probably we could add rspec-puppet to it [14:43:02] to compile catalogs for each of the roles [14:43:02] (03Merged) 10jenkins-bot: Convert npm, npm-test to docker-pkg [integration/config] - 10https://gerrit.wikimedia.org/r/388450 (https://phabricator.wikimedia.org/T177276) (owner: 10Giuseppe Lavagetto) [15:37:57] 10Continuous-Integration-Infrastructure (shipyard), 10Patch-For-Review: mwext-php70-phan-docker should've php-curl extension installed - https://phabricator.wikimedia.org/T183322#3856999 (10Addshore) @hashar You can simply add --ignore-platform-reqs to the composer update / install and avoid adding anything un... [15:43:52] role::abusefilter [15:43:52] should compile into a catalogue without dependency cycles [15:43:55] zeljkof: so hmm [15:44:02] I got rspec configured for mediawiki/Vagrant :] [15:44:30] hashar: re labs instance, not sure :) [15:44:38] zeljkof: no no [15:44:43] bundle exec rake spec [15:44:45] and blam [15:44:51] it tries to compile each of the catalogs hehe [15:45:02] hashar: cool [15:45:13] did you push to gerrit? [15:45:14] I am trying to figure out how rspec is installed [15:45:22] in vagrant? [15:45:25] via gemfile? [15:45:30] (bundler) [15:45:38] mediawiki-vagrant.gemspec has rspec ~> 3.1 [15:45:50] s.add_development_dependency 'rspec', '~> 3.1', '>= 3.1.0' [15:45:54] ah, gemspec [15:45:55] I am not sure what that means really :] [15:46:06] I want 3.5.XXX [15:46:09] it's pretty similar to gem file, [15:46:39] 'rspec', '~> 3.5' [15:46:55] '~> 3.5.0' [15:46:56] :) [15:47:15] hashar: re "havent you ever connected to a labs instance????" not sure :) [15:48:10] no no [15:48:15] so that is using rspec-puppet [15:48:26] it configures puppet, read the manifests and attempt to compile a catalog [15:48:35] then you can do bunch of assertions on the catalog [15:48:36] but really [15:48:46] if it compiles. That is already a proof that it is working (more or less) [15:49:09] so you are saying, we could run rspec-puppet per commit? [15:49:18] as a first line of defense? [15:51:02] it is way too slow though :( [15:51:39] faster than provisioning roles [15:55:26] well [15:55:33] it is just a catalog compilation [15:55:40] and does not actually run any command [15:57:42] 13) role::wikimediaproduction should compile into a catalogue without dependency cycles [15:57:42] Failure/Error: it { is_expected.to compile } [15:57:42] error during compilation: Duplicate declaration: Mediawiki::Extension[GlobalUsage] is already declared in file /home/hashar/projects/mediawiki/vagrant/puppet/modules/role/manifests/commons.pp:38; cannot redeclare at /home/hashar/projects/mediawiki/vagrant/puppet/modules/role/manifests/globalusage.pp:5 on node pico.hashar [15:57:43] # ./spec/integration/roles_spec.rb:11:in `block (3 levels) in ' [15:57:43] 14) role::wikitech should compile into a catalogue without dependency cycles [15:58:52] zeljkof: https://phabricator.wikimedia.org/P6503 :) [16:11:33] zeljkof: https://gerrit.wikimedia.org/r/399834 rspec-puppet for all the roles [16:11:39] zeljkof: but the puppet version is wrong [16:12:18] !log rebuilding npm and npm-test docker images https://gerrit.wikimedia.org/r/#/c/388450/ [16:12:23] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:26:53] (03PS1) 10Hashar: Revert "Convert npm, npm-test to docker-pkg" [integration/config] - 10https://gerrit.wikimedia.org/r/399837 (https://phabricator.wikimedia.org/T177276) [16:29:57] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3857197 (10bd808) @zeljkofilipin I have added you as a project admin so that you can create new V... [16:37:21] (03PS2) 10Hashar: Revert "Convert npm, npm-test to docker-pkg" [integration/config] - 10https://gerrit.wikimedia.org/r/399837 (https://phabricator.wikimedia.org/T177276) [16:37:50] !log cancelled update of npm and npm-test images. npm is broken when used with a proxy | https://gerrit.wikimedia.org/r/#/c/399837/ [16:37:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [16:38:35] (03CR) 10Hashar: [C: 032] Revert "Convert npm, npm-test to docker-pkg" [integration/config] - 10https://gerrit.wikimedia.org/r/399837 (https://phabricator.wikimedia.org/T177276) (owner: 10Hashar) [16:39:56] (03Merged) 10jenkins-bot: Revert "Convert npm, npm-test to docker-pkg" [integration/config] - 10https://gerrit.wikimedia.org/r/399837 (https://phabricator.wikimedia.org/T177276) (owner: 10Hashar) [16:43:23] 10Continuous-Integration-Infrastructure (shipyard), 10Operations: npm 1.4.21 can't use a http proxy - https://phabricator.wikimedia.org/T183569#3857222 (10hashar) [16:49:32] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3857273 (10hashar) p:05Triage>03Normal [17:07:14] 10Continuous-Integration-Infrastructure (shipyard), 10Operations: npm 1.4.21 can't use a http proxy - https://phabricator.wikimedia.org/T183569#3857222 (10Paladox) Why are we using npm 1.4? I thought we upgraded to npm3? [17:12:00] (03PS1) 10Chad: Remove emacs file from make-release. We don't commit editor files [tools/release] - 10https://gerrit.wikimedia.org/r/399845 [17:12:03] (03CR) 10Chad: [C: 032] Remove emacs file from make-release. We don't commit editor files [tools/release] - 10https://gerrit.wikimedia.org/r/399845 (owner: 10Chad) [17:13:07] (03Merged) 10jenkins-bot: Remove emacs file from make-release. We don't commit editor files [tools/release] - 10https://gerrit.wikimedia.org/r/399845 (owner: 10Chad) [17:14:16] (03PS1) 10Chad: Don't pin a specific python3 version in tox [tools/release] - 10https://gerrit.wikimedia.org/r/399846 [17:15:16] (03CR) 10Chad: [C: 032] Don't pin a specific python3 version in tox [tools/release] - 10https://gerrit.wikimedia.org/r/399846 (owner: 10Chad) [17:16:11] (03Merged) 10jenkins-bot: Don't pin a specific python3 version in tox [tools/release] - 10https://gerrit.wikimedia.org/r/399846 (owner: 10Chad) [17:19:09] no_justification: lets roll MCR out right now? ;) [17:19:18] noone will know [17:21:14] I want to go on vacation though [17:21:31] true [17:21:39] well, whats a vacation without a bang [17:21:40] ... [17:21:46] (03PS2) 10Chad: make-release: Pylint basically everything [tools/release] - 10https://gerrit.wikimedia.org/r/399550 [17:27:06] 10MediaWiki-Releasing, 10MediaWiki-Vendor: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857465 (10demon) So I think what we should do is drop vendor from the REL1_xx branches. Then only extensions and skins will be submodules. Vendor will continue to be a "build... [17:27:46] no_justification hi, im wondering could you create a wmf specific branch in https://phabricator.wikimedia.org/source/gerrit/ for 2.14 please? [17:28:04] I would like to add the gelf dep so that we can include tracebacks in logstash :). [17:30:03] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10Patch-For-Review, 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3857484 (10hashar) [17:36:12] (03CR) 10Chad: [C: 032] make-release: Pylint basically everything [tools/release] - 10https://gerrit.wikimedia.org/r/399550 (owner: 10Chad) [17:37:25] (03CR) 10Chad: "vendor is getting its submodules removed, see T172927" [tools/release] - 10https://gerrit.wikimedia.org/r/391295 (owner: 10Reedy) [17:37:42] (03Merged) 10jenkins-bot: make-release: Pylint basically everything [tools/release] - 10https://gerrit.wikimedia.org/r/399550 (owner: 10Chad) [17:37:47] (03PS2) 10Chad: Remove DataTypes extension from make-wmf-branch script [tools/release] - 10https://gerrit.wikimedia.org/r/394286 (https://phabricator.wikimedia.org/T180455) (owner: 10Addshore) [17:48:23] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10Patch-For-Review, 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3857529 (10hashar) a:05zeljkofilipin>03hashar [17:52:49] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant: Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3857537 (10hashar) p:05Triage>03Normal [17:56:57] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant: Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3857550 (10bd808) On my stretch-migration testing VM: ``` $ vagrant ssh -- puppet --version 4.8.2 ``` ``` $ apt-cache show puppet Package: puppet Version: 4.8.2-... [18:18:03] paladox: Ugh, since it's in mirror mode, you can't write to it [18:18:14] Pushable By: Not a Hosted Repository [18:49:54] Ah ok. [18:53:56] (03CR) 10Krinkle: [C: 031] Run RemexHtml coverage on PHP 7 [integration/config] - 10https://gerrit.wikimedia.org/r/386679 (https://phabricator.wikimedia.org/T179055) (owner: 10Legoktm) [19:09:38] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857790 (10Legoktm) >>! In T172927#3857465, @demon wrote: > So I think what we should do is drop vendor from the REL1_xx branches. Then only extensions a... [19:15:10] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3513508 (10Bawolff) > So I think what we should do is drop vendor from the REL1_xx branches. Then only extensions and skins will be submodules. Vendor wi... [19:48:43] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857873 (10demon) >>! In T172927#3857790, @Legoktm wrote: >>>! In T172927#3857465, @demon wrote: >> So I think what we should do is drop vendor from the... [19:53:17] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857877 (10demon) This also raises an interesting question: should the bundled extensions be added as submodules on master as well? I think you could mak... [20:07:42] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857905 (10Legoktm) >>! In T172927#3857873, @demon wrote: >>>! In T172927#3857790, @Legoktm wrote: >>>>! In T172927#3857465, @demon wrote: >>> So I think... [20:09:44] 10MediaWiki-Releasing, 10MediaWiki-Vendor, 10Patch-For-Review: mediawiki/vendor is bloated for tarball releases - https://phabricator.wikimedia.org/T172927#3857919 (10demon) That's also a valid option [20:25:37] * paladox may have found a bug in chrome :) [20:27:19] (03PS1) 10Chad: make-release: Actually make snapshot names sensible [tools/release] - 10https://gerrit.wikimedia.org/r/399889 [20:28:18] Project selenium-Wikibase-chrome ยป chrome,beta,Linux,DebianJessie && contintLabsSlave build #52: 04FAILURE in 41 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase-chrome/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=DebianJessie%20&&%20contintLabsSlave/52/ [20:36:19] Apparently chrome is now broken on integration systems that doint use --headless [20:59:14] bd808: in the end I am installing mediawiki-vagrant with libvirt and fixing up the doc :] [21:04:31] Anyone know of a good place where i can play with docker? And not have to host my own images [21:04:41] Im asking here cause you all use docker [21:09:05] Zppix: why dont you get it installed on your machine? [21:09:22] really docker is just a huge wrapper around process to be started in a more or less isolated environment [21:09:30] Im lazy [21:09:33] ... [21:09:47] That and my pc cant handle it [21:09:48] assuming you ahve a linux machine, it should be straightforward [21:09:56] Oh no windows :) [21:09:59] (03CR) 10Catrope: "FIXME: This broke the job. CI has been failing consistently in the VisualEditor/VisualEditor repo since this was merged, and nothing has b" [integration/config] - 10https://gerrit.wikimedia.org/r/397583 (owner: 10Hashar) [21:10:01] ah [21:10:01] (03PS1) 10Catrope: Revert "Migrate VisualEditor 'npm doc' job to Docker" [integration/config] - 10https://gerrit.wikimedia.org/r/399905 [21:10:13] hashar: Didn't expect you to be around this late, but ----^^ [21:10:18] Doesn't addshore do docker on windows? [21:10:25] RoanKattouw: yeah hmm [21:10:38] VisualEditor core CI is broken which is not a great place to be when trying to merge a UBN patch [21:10:38] Hi, yes [21:10:43] RoanKattouw: will dig in it. I am pretty sure I had it tested [21:10:43] I was hoping not to have to do this locally [21:10:48] (Not that we can deploy it anyway, so no particular rush) [21:10:50] As my pc is only 32 bit [21:10:59] hashar: You might have tested the extensions/VisualEditor repo instead of the VisualEditor/VisualEditor repo [21:11:06] ohhhh [21:11:12] hashar: Zppix docker on windows works just fine :) [21:11:23] addshore: on a 32 bit machine? [21:11:26] https://gerrit.wikimedia.org/r/#/c/399894/ is a test commit showing the breakage [21:11:31] Mhhm, no, 64 bit [21:11:39] Thats my issue [21:11:57] Or maybe https://gerrit.wikimedia.org/r/#/c/399899/1 is a better example because the recent karma upgrade also broke the unit tests, and that commit fixes that (but still fails on the doc job) [21:12:33] RoanKattouw: yeah so doc is broken it is missing an env variable. I am going to dig into it [21:12:37] maybe I forgot to update the job [21:12:58] the other one works at least [21:15:19] hashar: I've created https://gerrit.wikimedia.org/r/#/c/399905/ in case you need it, feel free to abandon it if you end up fixing it a different way [21:15:31] hmm [21:15:39] the first build of https://integration.wikimedia.org/ci/job/visualeditor-npm-run-doc-node-6-docker/ worked at least so I definitely tested it [21:17:19] Ha yeah [21:17:20] 18:13:26 + npm run-script doc [21:17:24] And it ran the right command too [21:18:26] yup [21:18:36] while the other run the wrong one 'run-script test' [21:18:43] and since the image has no browser available... that fails [21:18:58] * hashar hates when stuff breaks [21:19:14] :D [21:19:21] hashar: I have had that same feeling today [21:19:25] NPM_RUN_SCRIPT=doc [21:19:31] * addshore starts looking into tomato farms again [21:19:37] OH MEN [21:19:39] * hashar facepalms [21:20:24] the jobs parameters are not taken in account when triggered by Zuul :( [21:22:39] (03PS2) 10Hashar: Revert "Migrate VisualEditor 'npm doc' job to Docker" [integration/config] - 10https://gerrit.wikimedia.org/r/399905 (owner: 10Catrope) [21:24:49] (03PS3) 10Hashar: Revert "Migrate VisualEditor 'npm doc' job to Docker" [integration/config] - 10https://gerrit.wikimedia.org/r/399905 (owner: 10Catrope) [21:25:10] RoanKattouw: so yeah reverting. Very sorry aobut that [21:26:16] that looked so nice on the paper :( [21:26:22] even worked when run manually bah [21:26:27] I will have to dig into some java code ;((( [21:28:02] (03CR) 10Hashar: [C: 032] "I have regenerated the job visualeditor-npm-run-doc-node-6-jessie" [integration/config] - 10https://gerrit.wikimedia.org/r/399905 (owner: 10Catrope) [21:30:34] (03Merged) 10jenkins-bot: Revert "Migrate VisualEditor 'npm doc' job to Docker" [integration/config] - 10https://gerrit.wikimedia.org/r/399905 (owner: 10Catrope) [21:31:12] RoanKattouw: thanks for the revert patch [21:41:08] RoanKattouw: and the Nodepool job still works at least https://gerrit.wikimedia.org/r/#/c/399899/1 [21:41:24] RoanKattouw: really sorry. Seems manually running a build is not enough to validate! [21:44:48] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant: Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3858112 (10hashar) On a Jessie one, the **initial provisioning** is done with: 3.7.2 ``` $ apt-cache policy puppet puppet: Installed: 3.7.2-4+deb8u1 Candidate... [21:46:31] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant: Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3858125 (10bd808) Stretch will be the master branch in ~2 weeks (T181353). I wouldn't waste much energy on things like this in master right now. [21:49:22] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant: Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3858182 (10hashar) Definitely :] I guess we can keep this around as a reminder to bump the Puppet version in the Gemfile to match the one installed in Stretch. [21:54:39] 10Release-Engineering-Team, 10MediaWiki-Vagrant, 10Operations, 10Epic, and 2 others: [EPIC] Migrate base image to Debian Jessie - https://phabricator.wikimedia.org/T136429#3858236 (10hashar) [22:02:03] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3858284 (10hashar) MediaWiki-Vagrant has libvirt support made by @scfc (and update to jessie with... [22:19:21] integration-slave-jessie-1004 is out of space [22:26:27] marking offline and looking [22:27:01] the tmp there is full of leaked crap [22:27:46] looks like /srv is the mount that's full up [22:28:05] * bd808 blames pbuilder [22:28:32] 16G jenkins-workspace [22:28:53] looks mostly like php55 lint git dir? [22:29:13] or a good chunk of that anyway [22:29:37] yeah, a 3rd [22:30:19] it's all .git/objects :/ [22:32:06] thcipriani: there's a bug open for that [22:32:18] but I just rm -rf jenkins-workspace and move on [22:32:33] https://phabricator.wikimedia.org/T179963 [22:33:30] I guess with git history that huge we should be doing some shallow clone fanciness [22:33:50] CI is always "fun" to keep running on a big code base [22:34:25] looks like we're doing some fanciness somewhere "use-remote-zuul-shallow-clone" [22:38:42] AIUI we're constantly shallow cloning into the same .git repo [22:38:50] so eventually it just keeps adding up [22:38:59] !log integration-slave-jessie-1004 removed mediawiki-core-jsduck, mwgate-php55lint, mediawikicore-php55lint as /srv mount was full T179963 [22:39:06] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:39:06] T179963: mwgate-php55lint workspaces are getting huge - https://phabricator.wikimedia.org/T179963 [22:41:41] legoktm: thanks for the task pointer [22:41:44] node is back online [22:42:05] big repos are big :( [23:23:29] no_justification i converted http://gerrit-new.wmflabs.org/r/ to notedb today :). It then caused phabricator to send me alot of emails due to me cloning the All-Project repo from gerrit-new. [23:23:58] it also helped to see how the notedb migration goes when doing it online.