[09:02:45] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10Patch-For-Review, 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3860767 (10hashar) [09:02:47] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant: Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3860765 (10hashar) 05Open>03Resolved Thanks Bryan. I did the rspec-puppet patch on the `stretch-migration`. The Gemfile has puppet 4.8.2 which match the Debia... [09:04:06] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10Patch-For-Review, 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3857273 (10hashar) https://gerrit.wikimedia.org/r/399965 more or less compiles the catalog for... [11:51:52] 10Beta-Cluster-Infrastructure: various .beta.wmflabs.org domains use an invalid ssl certificate - https://phabricator.wikimedia.org/T182927#3860911 (10Krenair) https://letsencrypt.org/2017/12/07/looking-forward-to-2018.html >First, we’re planning to introduce an ACME v2 protocol API endpoint and support for wild... [19:02:38] just a note that deployment-tin is still broken because of https://gerrit.wikimedia.org/r/#/c/392221/ (no hiera setting so puppet doesn't run, blah blah) [19:02:45] this is likely not news, but just in case [19:04:59] happy holidays, hopefully none of you are around to have to look at that! [20:09:43] (03PS1) 10Umherirrender: Handle alternative if in IfElseStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400240 (https://phabricator.wikimedia.org/T178772) [20:12:28] (03CR) 10Umherirrender: "Works on the apex skin when the exclude of "MediaWiki.ControlStructures.IfElseStructure.SpaceAfterElse" is removed from .phpcs.xml" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400240 (https://phabricator.wikimedia.org/T178772) (owner: 10Umherirrender) [20:12:43] 10MediaWiki-Codesniffer, 10Patch-For-Review: IfElseStructureSniff creates php error on autofix with alternative if else - https://phabricator.wikimedia.org/T178772#3861199 (10Umherirrender) p:05Triage>03Normal a:03Umherirrender [20:26:02] 10MediaWiki-Codesniffer: phpcbf formatting error - https://phabricator.wikimedia.org/T183298#3849568 (10Umherirrender) Seems to be the upstream Generic.ControlStructures.InlineControlStructure On windows it results in ``` if ( !$title->isSpecial( $page ) ) { continue; }$groups = $g; ``` needs isolate test, if... [20:26:46] 10MediaWiki-Codesniffer: phpcbf formatting error on inline control structure - https://phabricator.wikimedia.org/T183298#3861215 (10Umherirrender) [21:14:18] (03PS1) 10Umherirrender: Rework ExtendClassUageSniff to avoid private class member [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400243 (https://phabricator.wikimedia.org/T179753) [21:14:45] 10MediaWiki-Codesniffer, 10Patch-For-Review: ExtendClassUsageSniff is buggy because it maintains state in the sniff - https://phabricator.wikimedia.org/T179753#3861241 (10Umherirrender) p:05Triage>03Normal a:03Umherirrender [21:17:27] 10MediaWiki-Codesniffer: Mediawiki CodeSniffer MediaWiki.Classes.UnusedUseStatement.UnusedUse does not recognize Annotations - https://phabricator.wikimedia.org/T176885#3861244 (10Umherirrender) [21:31:39] 10Gerrit, 10Documentation: Add documentation on the new assignee feature in gerrit - https://phabricator.wikimedia.org/T183705#3861247 (10Paladox) [21:34:39] (03CR) 10Umherirrender: "It seems the test loops on mw-tools-codesniffer-mwcore-testrun, I hope there is a timeout, so it fail in some minutes." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400243 (https://phabricator.wikimedia.org/T179753) (owner: 10Umherirrender) [21:45:09] 10Gerrit, 10Documentation: Add documentation on the new assignee feature in gerrit - https://phabricator.wikimedia.org/T183705#3861259 (10Paladox) [21:51:05] 10Gerrit, 10Documentation: Add documentation on the new assignee feature in gerrit - https://phabricator.wikimedia.org/T183705#3861263 (10Aklapper) While https://www.mediawiki.org/wiki/Gerrit/Code_review and https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews come to my mind, I am not sure yet ho... [21:55:08] (03PS2) 10Umherirrender: Rework ExtendClassUageSniff to avoid private class member [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400243 (https://phabricator.wikimedia.org/T179753) [21:55:42] (03CR) 10Umherirrender: "Patch Set 2: Fixed endless loop" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400243 (https://phabricator.wikimedia.org/T179753) (owner: 10Umherirrender) [22:10:19] (03PS1) 10Umherirrender: Skip inner functions in FunctionCommentSniff::processReturn [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400249 (https://phabricator.wikimedia.org/T178243) [22:14:39] 10MediaWiki-Codesniffer, 10Patch-For-Review: Ignore returns in inner functions for MissingReturn sniff - https://phabricator.wikimedia.org/T178243#3861271 (10Umherirrender) p:05Triage>03Normal a:03Umherirrender [22:18:07] (03PS2) 10Umherirrender: Skip inner functions in FunctionCommentSniff::processReturn [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400249 (https://phabricator.wikimedia.org/T178243) [22:18:32] (03CR) 10Umherirrender: "Patch Set 2: Expanded tests" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400249 (https://phabricator.wikimedia.org/T178243) (owner: 10Umherirrender) [22:19:07] 10MediaWiki-Codesniffer: Add sniff to ensure doc blocks don't use "@cover", but "@covers" instead - https://phabricator.wikimedia.org/T176031#3861273 (10Umherirrender) a:05Jdforrester-WMF>03None [22:21:50] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860109 (10Umherirrender) https://gerrit.wikimedia.org/r/#/c/394578/ will handle many of t... [22:40:30] 10MediaWiki-Codesniffer: Relax MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.EmptyComment for multiline comments - https://phabricator.wikimedia.org/T133743#3861284 (10Umherirrender) 05Open>03Resolved a:03Tgr Sniff was removed in https://gerrit.wikimedia.org/r/#/c/390178/ [22:42:06] 10MediaWiki-Codesniffer, 10Patch-For-Review: Provide Codesniffer rules to enforce "short" type definitions (int/bool, not integer/boolean) - https://phabricator.wikimedia.org/T145162#3861287 (10Umherirrender) 05Open>03Resolved I would say that all work is done here. Feel free to create a new task, if anyth... [22:49:55] 10MediaWiki-Codesniffer: Look for @parma typo (should be @param) - https://phabricator.wikimedia.org/T182057#3811450 (10Umherirrender) Looks not like a common case/common typo in php code http://codesearch.wmflabs.org/search/?q=%40parma&i=nope&files=&repos= I would suggest to detect this by using a whitelist of... [22:54:16] 10Release-Engineering-Team (Kanban): Investigate the Extension Submittal Review process - https://phabricator.wikimedia.org/T182731#3861293 (10Jrbranaa) Reached out to Daniel for more info. Also reached out to Marko regarding the review process for services. [23:00:01] 10MediaWiki-Codesniffer: PHPCS should make sure @covers tags are absolute - https://phabricator.wikimedia.org/T183218#3847140 (10Umherirrender) With T171899 these would be found to, but having them checked by phpcs sounds also good [23:02:18] 10MediaWiki-Codesniffer: PHPCS should make sure @covers tags are absolute - https://phabricator.wikimedia.org/T183218#3861311 (10Umherirrender) Should than also check @coversDefaultClass for full qualified class name