[00:10:56] 10Gerrit, 10Documentation: Add documentation on the new assignee feature in gerrit - https://phabricator.wikimedia.org/T183705#3861321 (10demon) I don't like this feature, I'd rather it be disabled. [03:01:27] 10Gerrit, 10Documentation: Add documentation on the new assignee feature in gerrit - https://phabricator.wikimedia.org/T183705#3861367 (10Paladox) @demon oh should this task be declined? I see no way to disable this feature so this may need to be filled upstream as a feature request. [07:04:56] 10Gerrit, 10GitHub-Mirrors, 10TechCom-RfC: Replace Gerrit & GitHub with GitLab - https://phabricator.wikimedia.org/T167547#3336369 (10Samwilson) Debian is using GitLab: "salsa.debian.org (git.debian.org replacement) going into beta" https://lwn.net/Articles/742297/ (By the way, this ticket is closed, but th... [08:32:55] (03CR) 10Thiemo Kreuz (WMDE): "Looks fine. But I wonder what the point is, because we don't even allow this syntax, as far as I'm aware of." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400240 (https://phabricator.wikimedia.org/T178772) (owner: 10Umherirrender) [08:50:25] 10Gerrit, 10GitHub-Mirrors, 10TechCom-RfC: Replace Gerrit & GitHub with GitLab - https://phabricator.wikimedia.org/T167547#3336369 (10Peachey88) >>! In T167547#3861427, @Samwilson wrote: > (By the way, this ticket is closed, but there isn't a log entry above saying so; is there some 'hidden close' feature in... [08:58:47] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Skip inner functions in FunctionCommentSniff::processReturn [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400249 (https://phabricator.wikimedia.org/T178243) (owner: 10Umherirrender) [09:11:11] 10Gerrit, 10GitHub-Mirrors, 10TechCom-RfC: Replace Gerrit & GitHub with GitLab - https://phabricator.wikimedia.org/T167547#3861503 (10Aklapper) >>! In T167547#3861427, @Samwilson wrote: > (By the way, this ticket is closed, but there isn't a log entry above saying so; is there some 'hidden close' feature in... [09:27:34] (03CR) 10Umherirrender: "Yes, the syntax is not allowed. But it is still used by some skins and when running "composer fix" on that repository with the sniff enabl" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400240 (https://phabricator.wikimedia.org/T178772) (owner: 10Umherirrender) [09:32:02] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "I should have read T178772. It explains why this patch is not an added feature (the commit message makes it sound like an added feature), " [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400240 (https://phabricator.wikimedia.org/T178772) (owner: 10Umherirrender) [09:56:11] (03PS2) 10Umherirrender: Fix handling of alternative if in IfElseStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400240 (https://phabricator.wikimedia.org/T178772) [12:31:10] 10Gerrit, 10GitHub-Mirrors, 10TechCom-RfC: Replace Gerrit & GitHub with GitLab - https://phabricator.wikimedia.org/T167547#3861647 (10Samwilson) Oh yes, it was there all along; I missed it. :) [17:22:08] (03CR) 10D3r1ck01: [C: 031] Changed settings for BlueSpice-repos [integration/config] - 10https://gerrit.wikimedia.org/r/394578 (owner: 10Robert Vogel) [17:31:44] 10Gerrit, 10Documentation: Add documentation on the new assignee feature in gerrit - https://phabricator.wikimedia.org/T183705#3861833 (10demon) I don't think it's worth getting upstream to make it disable-able. But we also don't need to provide guidance on a feature that I think is marginally useful to us @ WMF. [17:33:26] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3861836 (10D3r1ck01) >>! In T183674#3861278, @Umherirrender wrote: > https://gerrit.wikime... [17:57:48] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3861880 (10Umherirrender) [17:59:23] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860109 (10Umherirrender) [18:00:04] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3861882 (10Umherirrender) >>! In T183674#3861836, @D3r1ck01 wrote: >>>! In T183674#3861278... [18:01:00] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3861883 (10D3r1ck01) Okay @Umherirrender, thanks very much! Wondering if this task will go... [18:39:46] (03CR) 10Paladox: [C: 031] Changed settings for BlueSpice-repos [integration/config] - 10https://gerrit.wikimedia.org/r/394578 (owner: 10Robert Vogel) [19:38:56] Project mediawiki-core-code-coverage build #3226: 04FAILURE in 6.1 sec: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/3226/ [19:41:12] 19:38:54 DEBUG:git.cmd:AutoInterrupt wait stderr: 'fatal: write error: No space left on device\nfatal: index-pack failed' [19:42:04] !log legoktm@integration-slave-jessie-1003:/srv/jenkins-workspace/workspace$ sudo rm -rf * [19:42:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:42:39] rebuilding coverage now [20:50:39] 10Gerrit, 10Documentation: Add documentation on the new assignee feature in gerrit - https://phabricator.wikimedia.org/T183705#3861938 (10Paladox) 05Open>03declined Ok, declining then. [21:10:24] 10MediaWiki-Codesniffer: Add PHPCS rule to autofix some aliased PHP function names for consistency - https://phabricator.wikimedia.org/T183220#3861984 (10Krinkle) [21:18:41] Yippee, build fixed! [21:18:42] Project mediawiki-core-code-coverage build #3227: 09FIXED in 1 hr 36 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/3227/ [22:15:17] (03CR) 10Legoktm: [C: 032] "Thanks!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400243 (https://phabricator.wikimedia.org/T179753) (owner: 10Umherirrender) [22:16:27] (03Merged) 10jenkins-bot: Rework ExtendClassUageSniff to avoid private class member [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400243 (https://phabricator.wikimedia.org/T179753) (owner: 10Umherirrender) [22:20:41] 10MediaWiki-Codesniffer, 10Patch-For-Review: ExtendClassUsageSniff is buggy because it maintains state in the sniff - https://phabricator.wikimedia.org/T179753#3862016 (10Legoktm) 05Open>03Resolved [22:20:56] (03CR) 10Legoktm: [C: 032] Skip inner functions in FunctionCommentSniff::processReturn [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400249 (https://phabricator.wikimedia.org/T178243) (owner: 10Umherirrender) [22:21:06] 10MediaWiki-Codesniffer, 10Patch-For-Review: Ignore returns in inner functions for MissingReturn sniff - https://phabricator.wikimedia.org/T178243#3862017 (10Legoktm) 05Open>03Resolved [22:21:33] (03Merged) 10jenkins-bot: Skip inner functions in FunctionCommentSniff::processReturn [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400249 (https://phabricator.wikimedia.org/T178243) (owner: 10Umherirrender) [22:26:47] (03CR) 10Legoktm: [C: 032] Fix handling of alternative if in IfElseStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400240 (https://phabricator.wikimedia.org/T178772) (owner: 10Umherirrender) [22:27:24] (03Merged) 10jenkins-bot: Fix handling of alternative if in IfElseStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/400240 (https://phabricator.wikimedia.org/T178772) (owner: 10Umherirrender) [22:28:25] Projects in gerrit is now known as repos :). https://gerrit-review.googlesource.com/#/c/gerrit/+/142193/