[00:32:15] 10Release-Engineering-Team (Watching / External), 10Operations, 10Ops-Access-Requests, 10Patch-For-Review: Allow "releasers-mediawiki" sudo rights to manage Jenkins - https://phabricator.wikimedia.org/T183972#3870174 (10greg) [00:32:22] 10Release-Engineering-Team (Kanban), 10Scap, 10Wikimedia-Incident: Investigate deployment that caused high error-rate but wasn't prevented by Scap - https://phabricator.wikimedia.org/T183952#3870176 (10greg) [00:32:27] 10Release-Engineering-Team (Watching / External), 10Operations, 10LDAP: Create 'releng' LDAP group - https://phabricator.wikimedia.org/T183507#3870178 (10greg) [02:51:39] (03PS1) 10Legoktm: Add suite-edit.py [integration/jenkins] - 10https://gerrit.wikimedia.org/r/401657 (https://phabricator.wikimedia.org/T71685) [03:11:56] (03PS1) 10Chad: Remove unused shell scripts [tools/release] - 10https://gerrit.wikimedia.org/r/401660 [03:12:54] (03CR) 10Chad: [C: 032] "Oh, and I guess fix import orders too..." [tools/release] - 10https://gerrit.wikimedia.org/r/401660 (owner: 10Chad) [03:13:25] (03Merged) 10jenkins-bot: Remove unused shell scripts [tools/release] - 10https://gerrit.wikimedia.org/r/401660 (owner: 10Chad) [03:16:30] (03CR) 10Legoktm: [C: 032] Add suite-edit.py [integration/jenkins] - 10https://gerrit.wikimedia.org/r/401657 (https://phabricator.wikimedia.org/T71685) (owner: 10Legoktm) [03:17:06] (03Merged) 10jenkins-bot: Add suite-edit.py [integration/jenkins] - 10https://gerrit.wikimedia.org/r/401657 (https://phabricator.wikimedia.org/T71685) (owner: 10Legoktm) [03:24:35] (03PS1) 10Legoktm: Add mwext-phpunit-coverage-publish job [integration/config] - 10https://gerrit.wikimedia.org/r/401662 (https://phabricator.wikimedia.org/T71685) [03:24:38] (03PS1) 10Legoktm: Linter: Run mwext-phpunit-coverage-publish as postmerge [integration/config] - 10https://gerrit.wikimedia.org/r/401663 [03:26:44] (03CR) 10Legoktm: [C: 032] "Deployed, will probably iterate on in follow-ups." [integration/config] - 10https://gerrit.wikimedia.org/r/401662 (https://phabricator.wikimedia.org/T71685) (owner: 10Legoktm) [03:27:45] (03CR) 10Legoktm: [C: 032] "Let's try it :o" [integration/config] - 10https://gerrit.wikimedia.org/r/401663 (owner: 10Legoktm) [03:28:01] (03Merged) 10jenkins-bot: Add mwext-phpunit-coverage-publish job [integration/config] - 10https://gerrit.wikimedia.org/r/401662 (https://phabricator.wikimedia.org/T71685) (owner: 10Legoktm) [03:28:50] (03Merged) 10jenkins-bot: Linter: Run mwext-phpunit-coverage-publish as postmerge [integration/config] - 10https://gerrit.wikimedia.org/r/401663 (owner: 10Legoktm) [03:30:56] (03PS2) 10Chad: make-release: Rewrite make-branches as branch [tools/release] - 10https://gerrit.wikimedia.org/r/399111 [03:33:24] (03CR) 10Chad: [C: 032] make-release: Rewrite make-branches as branch [tools/release] - 10https://gerrit.wikimedia.org/r/399111 (owner: 10Chad) [03:33:58] (03Merged) 10jenkins-bot: make-release: Rewrite make-branches as branch [tools/release] - 10https://gerrit.wikimedia.org/r/399111 (owner: 10Chad) [03:36:50] (03CR) 10Legoktm: make-release: Rewrite make-branches as branch (033 comments) [tools/release] - 10https://gerrit.wikimedia.org/r/399111 (owner: 10Chad) [03:39:12] https://doc.wikimedia.org/cover/mediawiki-extensions-Linter/ [03:46:53] took ~6 minutes not counting the mw-core clone [03:47:50] (03PS1) 10Legoktm: Don't use cloverphp plugin for extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401664 [03:49:57] (03PS1) 10Legoktm: Don't allow concurrent runs for extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401665 [03:50:16] (03CR) 10Legoktm: [C: 032] Don't use cloverphp plugin for extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401664 (owner: 10Legoktm) [03:50:23] (03CR) 10Legoktm: [C: 032] Don't allow concurrent runs for extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401665 (owner: 10Legoktm) [03:51:40] (03Merged) 10jenkins-bot: Don't use cloverphp plugin for extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401664 (owner: 10Legoktm) [03:51:42] (03Merged) 10jenkins-bot: Don't allow concurrent runs for extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401665 (owner: 10Legoktm) [03:59:04] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#3870366 (10Legoktm) Ta-da: https://doc.wikimedia.org/cover/mediawiki-extensions-Linter/ - still have some bug... [04:43:06] (03PS1) 10Legoktm: Move CoveragePage into shared/ for reuse [integration/docroot] - 10https://gerrit.wikimedia.org/r/401670 [04:44:04] (03PS2) 10Legoktm: Move CoveragePage into shared/ for reuse [integration/docroot] - 10https://gerrit.wikimedia.org/r/401670 [04:48:37] (03CR) 10Legoktm: [C: 032] Move CoveragePage into shared/ for reuse [integration/docroot] - 10https://gerrit.wikimedia.org/r/401670 (owner: 10Legoktm) [04:48:58] (03Merged) 10jenkins-bot: Move CoveragePage into shared/ for reuse [integration/docroot] - 10https://gerrit.wikimedia.org/r/401670 (owner: 10Legoktm) [04:49:04] (03CR) 10jenkins-bot: Move CoveragePage into shared/ for reuse [integration/docroot] - 10https://gerrit.wikimedia.org/r/401670 (owner: 10Legoktm) [05:19:18] (03PS1) 10Legoktm: cover: Create separate sub-directory for extensions [integration/docroot] - 10https://gerrit.wikimedia.org/r/401672 [05:20:42] (03CR) 10Legoktm: [C: 032] cover: Create separate sub-directory for extensions [integration/docroot] - 10https://gerrit.wikimedia.org/r/401672 (owner: 10Legoktm) [05:21:05] (03Merged) 10jenkins-bot: cover: Create separate sub-directory for extensions [integration/docroot] - 10https://gerrit.wikimedia.org/r/401672 (owner: 10Legoktm) [05:21:10] (03CR) 10jenkins-bot: cover: Create separate sub-directory for extensions [integration/docroot] - 10https://gerrit.wikimedia.org/r/401672 (owner: 10Legoktm) [05:22:08] (03PS1) 10Legoktm: Use subdirectory for extension coverage reports [integration/config] - 10https://gerrit.wikimedia.org/r/401673 [05:34:20] Project mwext-phpunit-coverage-publish build #3: 04FAILURE in 32 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/3/ [05:36:47] oh [05:37:27] legoktm@integration-slave-jessie-1004:~$ php7.0 -d zend_extension=xdebug.so -i | grep xdebug [05:37:27] Failed loading /usr/lib/php/20151012/xdebug.so: /usr/lib/php/20151012/xdebug.so: cannot open shared object file: No such file or directory [05:37:29] bummer [05:40:56] Project mwext-phpunit-coverage-publish build #4: 04STILL FAILING in 20 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/4/ [05:41:59] 05:40:56 + nice -n 19 phpdbg7.0 -qrr /srv/jenkins-workspace/workspace/mwext-phpunit-coverage-publish/src/tests/phpunit/phpunit.php --testsuite extensions --coverage-clover log/clover.xml --coverage-html /srv/jenkins-workspace/workspace/mwext-phpunit-coverage-publish/cover [05:41:59] 05:40:56 This script must be run from the command line+ : [05:42:05] I mean [05:42:06] 10Gerrit, 10Diffusion: Commits merged in Gerrit should appear near-instantly in Phabricator - https://phabricator.wikimedia.org/T183792#3870473 (10demon) Tbh, I'd rather stop using Phabricator for our repo viewer. It kinda sucks :\ [05:42:19] 10Gerrit, 10Diffusion: Commits merged in Gerrit should appear near-instantly in Phabricator - https://phabricator.wikimedia.org/T183792#3870474 (10demon) But I guess we can enable this plugin, barring that :( [05:44:13] no_justification: Yes, it's terrible. :( Can we investigate other viewers like cgit or gogs? [05:44:38] Let's go back to gitblit! [05:44:41] jk [05:45:03] groans [05:45:23] yea, let's evaluate the other ones :) [05:46:09] but honestly diffusion is pretty unusable. After you've figure out how to find the URL (usually search mw.o and click a link), then you try viewing files and scroll down and realize it's paginated, and then directories aren't hoisted to the top, and arghhh [05:46:14] Actually I'm planning to use gitiles [05:46:29] It's developed by the same team as Gerrit itself [05:46:34] And it'd run as a plugin within Gerrit [05:46:47] link/screenshot? [05:46:54] https://gerrit.googlesource.com/plugins/gitiles/ [05:47:17] Well, I mostly want it just to replace those *awful* (view in gitweb) or w/e links [05:47:20] That I'd rather outright kill [05:47:24] But meh, people like them [05:47:31] For a general purpose viewer? Idgaf [05:48:10] looks nice, guess it depends on how it handles giant repos [05:48:24] Why anyone wants to leave the gerrit context just to view the changeset in a different viewer, Idk [05:48:41] But hey, xkcd 1172 [05:48:42] +1 [05:48:47] heh [05:48:50] I was thinking about setting up cgit on a cloud vps for something usable, but now I'll wait :) [05:49:01] I need 2.14.x though for gitiles [05:49:07] hm [05:49:08] Something something, multiple repo links [05:49:15] 2.14.x is blocked on a zuul upgrade [05:49:18] Which was blocked on Christmas [05:49:28] (something something, people like holidays?) [05:49:45] allhands is the best time :p [05:49:55] https://gerrit.googlesource.com/plugins/gitiles/+/master/BUILD how do you view/get a raw version of the file? [05:50:16] https://gerrit.googlesource.com/plugins/gitiles/+blame/master/BUILD is mostly paladox :D [05:50:39] all of that, yes please, better than diffusion, better than github links, YES on "why leave Gerrit context" [05:51:01] legoktm: He went on a commit spree awhile back fixing up plugin build files when they swapped build software (again...) [05:51:13] In the years we've used Gerrit, they've gone from Maven to Buck to now Bazel [05:51:16] heh [05:51:30] will gitiles have predictable/sane urls? [05:51:39] Ya [05:51:57] (tbh, I want to nuke all of our git repos from Phab except the high-traffic ones. 99% of them nobody gives 2 shits about) [05:52:06] (cf: github replication) [05:52:23] it's useful to be able to link to sha1s and have the commit summary auto-show up [05:52:58] but I wonder if we could have an extension or something handle that for an external repo viewer [05:53:26] (03PS1) 10Chad: branch.py: Assume python3 [tools/release] - 10https://gerrit.wikimedia.org/r/401676 [05:53:48] I imagine so [05:54:10] Considering Phab is basically useless for any organization with more than 20 or so repos.... [05:54:16] (seriously...) [05:54:17] also, lovely that phpdbg has PHP_SAPI set to 'phpdbg' so MW bails out since it's not 'cli' [05:54:22] agreed [05:55:54] Oh, and 401676 is for you ^ <3 [05:56:04] (I'm just now reading my e-mail and seeing after the fact CR) [05:57:23] :D [05:57:51] I'm trying to get this extension coverage thing working, and I'm somehow making commits across 5 different repos to make this not suck [06:01:05] !log manually installing php-xdebug on integration-slave-jessie-1004 to make sure this works (temporary) [06:01:11] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:06:44] q: why does the extension coverage job seem twice as slow? a: it's running the tests twice -.- [06:08:25] Yippee, build fixed! [06:08:26] Project mwext-phpunit-coverage-publish build #5: 09FIXED in 2 min 35 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/5/ [06:11:56] woohoo [06:12:04] (03CR) 10Legoktm: [C: 032] branch.py: Assume python3 [tools/release] - 10https://gerrit.wikimedia.org/r/401676 (owner: 10Chad) [06:12:37] (03Merged) 10jenkins-bot: branch.py: Assume python3 [tools/release] - 10https://gerrit.wikimedia.org/r/401676 (owner: 10Chad) [06:13:11] https://doc.wikimedia.org/cover/extensions/Linter/ says PHP 5.6 at the bottom but it definitely ran with PHP 7 [06:21:48] 10Continuous-Integration-Config, 10Readers-Web-Backlog (Tracking): Proof of concept to generate coverage report of some Wikimedia mediawiki extensions - https://phabricator.wikimedia.org/T151333#3870583 (10Legoktm) [06:21:52] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#3870586 (10Legoktm) [06:31:50] (03PS1) 10Legoktm: Only run tests once in extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401678 [06:31:52] (03PS1) 10Legoktm: Run extension coverage on PHP 7 [integration/config] - 10https://gerrit.wikimedia.org/r/401679 [06:31:54] (03PS1) 10Legoktm: [DO NOT MERGE] Pin extension coverage to jessie-1004 [integration/config] - 10https://gerrit.wikimedia.org/r/401680 [06:33:04] (03CR) 10Legoktm: [C: 032] Run extension coverage on PHP 7 [integration/config] - 10https://gerrit.wikimedia.org/r/401679 (owner: 10Legoktm) [06:33:08] (03CR) 10Legoktm: [C: 032] Only run tests once in extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401678 (owner: 10Legoktm) [06:33:14] (03CR) 10Legoktm: [C: 032] Use subdirectory for extension coverage reports [integration/config] - 10https://gerrit.wikimedia.org/r/401673 (owner: 10Legoktm) [06:33:35] (03CR) 10Legoktm: [C: 04-2] "I deployed this temporarily, and will revert once the linked puppet patch is merged." [integration/config] - 10https://gerrit.wikimedia.org/r/401680 (owner: 10Legoktm) [06:34:32] (03Merged) 10jenkins-bot: Use subdirectory for extension coverage reports [integration/config] - 10https://gerrit.wikimedia.org/r/401673 (owner: 10Legoktm) [06:34:34] (03Merged) 10jenkins-bot: Only run tests once in extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401678 (owner: 10Legoktm) [06:34:43] (03Merged) 10jenkins-bot: Run extension coverage on PHP 7 [integration/config] - 10https://gerrit.wikimedia.org/r/401679 (owner: 10Legoktm) [07:07:57] 10Beta-Cluster-Infrastructure, 10Language-2017-Oct-Dec, 10Language-2018-Jan-Mar: [betacluster] Special:Translate does not allow to translate article content - multiple "Uncaught SyntaxError: Unexpected token < in JSON at position 0" - https://phabricator.wikimedia.org/T180841#3771141 (10Arrbee) [07:08:03] (03PS1) 10Legoktm: ORES: Run mwext-phpunit-coverage-publish as postmerge [integration/config] - 10https://gerrit.wikimedia.org/r/401684 [07:08:27] (03CR) 10Legoktm: [C: 032] ORES: Run mwext-phpunit-coverage-publish as postmerge [integration/config] - 10https://gerrit.wikimedia.org/r/401684 (owner: 10Legoktm) [07:09:32] (03Merged) 10jenkins-bot: ORES: Run mwext-phpunit-coverage-publish as postmerge [integration/config] - 10https://gerrit.wikimedia.org/r/401684 (owner: 10Legoktm) [07:25:45] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#3870646 (10Legoktm) OK, I also added this for https://doc.wikimedia.org/cover/extensions/ORES/ These reports... [07:45:52] (03PS1) 10Legoktm: cover: Rename to "test coverage", and add a blurb explaining the concept [integration/docroot] - 10https://gerrit.wikimedia.org/r/401696 [07:47:20] (03CR) 10Legoktm: [C: 032] cover: Rename to "test coverage", and add a blurb explaining the concept [integration/docroot] - 10https://gerrit.wikimedia.org/r/401696 (owner: 10Legoktm) [07:47:44] (03Merged) 10jenkins-bot: cover: Rename to "test coverage", and add a blurb explaining the concept [integration/docroot] - 10https://gerrit.wikimedia.org/r/401696 (owner: 10Legoktm) [07:47:50] (03CR) 10jenkins-bot: cover: Rename to "test coverage", and add a blurb explaining the concept [integration/docroot] - 10https://gerrit.wikimedia.org/r/401696 (owner: 10Legoktm) [08:20:05] 10Continuous-Integration-Infrastructure, 10MediaWiki-Core-Tests: Figure out how to accurately backfill MediaWiki core test code coverage data - https://phabricator.wikimedia.org/T182750#3870734 (10Legoktm) 05Open>03declined I disagree from myself from last week that this data would be neat - it would just... [08:30:17] good morning hashar :) [08:44:07] 10Continuous-Integration-Config, 10commit-message-validator, 10Pywikibot-core, 10Patch-For-Review: Check the style of the commit message - https://phabricator.wikimedia.org/T109119#3870764 (10jayvdb) 05Open>03Resolved a:03jayvdb @Legoktm , @hashar , I guess this task can be closed. It was originally... [09:57:26] 10Continuous-Integration-Config, 10commit-message-validator, 10Pywikibot-core, 10Patch-For-Review: Check the style of the commit message - https://phabricator.wikimedia.org/T109119#3870856 (10hashar) a:05jayvdb>03Dalba Indeed that is resolved by https://gerrit.wikimedia.org/r/#/c/368793/ :) [10:06:26] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#738524 (10Physikerwelt) @Legoktm >>! In T71685#2107621, @Physikerwelt wrote: > @Legoktm: Can we add math her... [10:13:11] 10Continuous-Integration-Infrastructure, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#3870880 (10Legoktm) >>! In T71685#3870865, @Physikerwelt wrote: > @Legoktm >>>! In T71685#2107621, @Physiker... [10:24:12] (03CR) 10Florianschmidtwelzow: "Looks good, one question, though" (031 comment) [integration/config] - 10https://gerrit.wikimedia.org/r/401628 (https://phabricator.wikimedia.org/T183674) (owner: 10Divadsn) [10:24:16] (03CR) 10Florianschmidtwelzow: [C: 031] Add BlueSpicePageAccess extension to zuul/layout.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/401627 (https://phabricator.wikimedia.org/T183674) (owner: 10Divadsn) [10:38:36] 10RelEng-Archive-FY201718-Q2, 10MediaWiki-Vagrant, 10Security, 10User-zeljkofilipin: Security vulnerabilities in yard - https://phabricator.wikimedia.org/T183440#3870924 (10zeljkofilipin) >>! In T183440#3867813, @Bawolff wrote: > Its because bot does not have permission to see this bug I see. It makes sen... [10:52:32] (03PS3) 10Divadsn: Add BlueSpiceNamespaceCSS extension to zuul/layout.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/401628 (https://phabricator.wikimedia.org/T183674) [10:54:17] (03CR) 10Hashar: "Dont they all depends on BlueSpiceFoundation? Lot of them are listed in zuul/parameter_functions.py  already." [integration/config] - 10https://gerrit.wikimedia.org/r/394578 (owner: 10Robert Vogel) [10:56:15] (03CR) 10Florianschmidtwelzow: [C: 031] Add BlueSpiceNamespaceCSS extension to zuul/layout.yaml [integration/config] - 10https://gerrit.wikimedia.org/r/401628 (https://phabricator.wikimedia.org/T183674) (owner: 10Divadsn) [11:34:54] (03PS1) 10Legoktm: Math: Run mwext-phpunit-coverage-publish as postmerge [integration/config] - 10https://gerrit.wikimedia.org/r/401718 [11:35:06] (03CR) 10Legoktm: [C: 032] Math: Run mwext-phpunit-coverage-publish as postmerge [integration/config] - 10https://gerrit.wikimedia.org/r/401718 (owner: 10Legoktm) [11:36:16] (03Merged) 10jenkins-bot: Math: Run mwext-phpunit-coverage-publish as postmerge [integration/config] - 10https://gerrit.wikimedia.org/r/401718 (owner: 10Legoktm) [11:43:15] (03PS1) 10Legoktm: Run coverage for all extensions from https://tools.wmflabs.org/coverage/ [integration/config] - 10https://gerrit.wikimedia.org/r/401720 [11:43:27] (03CR) 10Legoktm: [C: 032] Run coverage for all extensions from https://tools.wmflabs.org/coverage/ [integration/config] - 10https://gerrit.wikimedia.org/r/401720 (owner: 10Legoktm) [11:44:49] (03Merged) 10jenkins-bot: Run coverage for all extensions from https://tools.wmflabs.org/coverage/ [integration/config] - 10https://gerrit.wikimedia.org/r/401720 (owner: 10Legoktm) [12:27:33] 10Continuous-Integration-Config, 10Operations: tox 2.5.0 on phabricator-jessie-diffs fails with ERROR: Commands not specified - https://phabricator.wikimedia.org/T184060#3871088 (10fgiunchedi) [13:14:50] 10Continuous-Integration-Config, 10Technical-Debt, 10Zuul: test-requirements.txt in ci-config still points to precise deb - https://phabricator.wikimedia.org/T162191#3871240 (10Paladox) I think we can remove trusty branches too as we doint use trusty any more in CI. Probaly also want to support stretch at s... [15:03:37] Project mwext-phpunit-coverage-publish build #15: 04FAILURE in 3 min 36 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/15/ [16:24:17] 10Continuous-Integration-Config, 10MinusX, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add MinusX to MediaWiki extensions and PHP library repos - https://phabricator.wikimedia.org/T175794#3871792 (10OmkarJ) [16:31:32] Travis tests on Wikibase gives out segment fault in php5.5 only, hope that doesn't affect production. We are looking into it but should it keep the train? [16:31:57] https://travis-ci.org/manicki/mediawiki-extensions-Wikibase/builds/324560026 [16:32:46] legoktm no_justification mutante heh [16:33:20] Amir1: Well, command line stuff still uses php5.5 [16:33:35] Sooo, depends on how important the dispatchChanges cron is on terbium :) [16:34:00] Well, if that's affected I s'pose [16:34:17] okay, let me check it in details [16:37:54] Amir1: Train's not for ~3h, so no rush, just lemme know :) [16:38:06] okay [16:39:50] no_justification we can always give gitiles a test when we upgrade to 2.14 as we doint need to change any links just then. [16:40:01] Yep [16:40:04] That's my plan [16:40:22] :) [16:41:46] no_justification: This commit fixes the problem but the branch was cut around half an hour before this commit, so just backporting this to wmf.15 would be enough: https://phabricator.wikimedia.org/rEWBAe21bdc368b5a6e628800d0405d72a90384e75b43 [16:42:16] Ok. I'm actually on my mobile device right now but I'll poke at it shortly [16:44:10] Also yeh i actually fixed alot of plugins to work with gerrit 2.14+ [16:44:20] i even fixed plugins where they were broken with 2.15 or master [16:44:34] its-base and its-phabricator were fixed by me :). [16:57:20] Yippee, build fixed! [16:57:21] Project mwext-phpunit-coverage-publish build #16: 09FIXED in 2 min 54 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/16/ [16:59:58] Amir1: Backporting: https://gerrit.wikimedia.org/r/#/c/401753/ [17:00:27] no_justification: Thanks [17:00:43] Lemme do it now before I have to go offline for a bit (swapping ISPs today) [17:03:36] Cool, thanks [17:07:27] (03PS1) 10Umherirrender: Remove unneeded @codingStandardsIgnoreLine from test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/401754 [17:33:04] 10Release-Engineering-Team (Watching / External), 10Operations, 10Ops-Access-Requests, 10Patch-For-Review: Allow "releasers-mediawiki" sudo rights to manage Jenkins - https://phabricator.wikimedia.org/T183972#3868664 (10RobH) So this technically is sudo, and thus requires ops meeting approval. We'll make... [17:37:08] 10Continuous-Integration-Config, 10MinusX, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add MinusX to MediaWiki extensions and PHP library repos - https://phabricator.wikimedia.org/T175794#3872042 (10OmkarJ) [17:41:47] 10Gerrit, 10Release-Engineering-Team, 10Operations: Add prometheus exporter to Gerrit - https://phabricator.wikimedia.org/T184086#3872047 (10demon) p:05Triage>03Normal [17:42:05] 10Gerrit, 10Release-Engineering-Team, 10Operations: Add prometheus exporter to Gerrit - https://phabricator.wikimedia.org/T184086#3872061 (10demon) Right after posting, I notice there's a stable-2.13 branch, so maybe I don't need to wait for the upgrade? [17:44:47] 10Gerrit, 10Release-Engineering-Team (Someday), 10Patch-For-Review: Update gerrit to 2.14.6 - https://phabricator.wikimedia.org/T156120#3872077 (10demon) [17:44:49] 10Gerrit, 10Release-Engineering-Team, 10Operations: Add prometheus exporter to Gerrit - https://phabricator.wikimedia.org/T184086#3872075 (10demon) [17:46:28] 10Beta-Cluster-Infrastructure, 10VisualEditor, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10User-Ryasmeen, 10Verified: Special pages is not working on the beta cluster - https://phabricator.wikimedia.org/T183883#3872090 (10Ryasmeen) [17:51:00] 10Gerrit, 10Release-Engineering-Team, 10Operations: Add prometheus exporter to Gerrit - https://phabricator.wikimedia.org/T184086#3872132 (10fgiunchedi) To give an outline of what's needed: * install prometheus-jmx-exporter debian package * tweak jvm's options to include `-javaagent ...` * ship an empty con... [18:06:28] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10Operations, 10Goal, and 2 others: Add Prometheus exporter to Jenkins instances - https://phabricator.wikimedia.org/T182759#3872299 (10hashar) [18:11:31] 10Continuous-Integration-Infrastructure, 10MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#3872317 (10hashar) Coverage reports genera... [18:18:25] 10Continuous-Integration-Config, 10Operations: tox 2.5.0 on phabricator-jessie-diffs fails with ERROR: Commands not specified - https://phabricator.wikimedia.org/T184060#3871088 (10hashar) D940 added a command to the env. Previously the tox.ini looked something like: ``` lang=ini [tox] skipsdist = True envlist... [18:41:39] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: Swap node for jq in mw-fetch-composer-dev.sh - https://phabricator.wikimedia.org/T181938#3807139 (10hashar) The Nodepool instances have jq installed: ``` $ jq --version jq-1.4-1-e73951f $ apt-cache policy jq jq: Installed: 1.4-2.1+deb8u1 Candidat... [18:41:56] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Swap node for jq in mw-fetch-composer-dev.sh - https://phabricator.wikimedia.org/T181938#3872386 (10hashar) [18:42:14] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Swap node for jq in mw-fetch-composer-dev.sh - https://phabricator.wikimedia.org/T181938#3807139 (10hashar) p:05Triage>03Low [18:45:12] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Swap node for jq in mw-fetch-composer-dev.sh - https://phabricator.wikimedia.org/T181938#3872393 (10Reedy) Depending on the timeline for this... Would it be worth restoring my patch that only fixes T181937, and... [18:53:47] (03CR) 10Hashar: [C: 032] Remove unneeded @codingStandardsIgnoreLine from test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/401754 (owner: 10Umherirrender) [18:54:58] (03Merged) 10jenkins-bot: Remove unneeded @codingStandardsIgnoreLine from test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/401754 (owner: 10Umherirrender) [18:55:59] (03CR) 10jenkins-bot: Remove unneeded @codingStandardsIgnoreLine from test [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/401754 (owner: 10Umherirrender) [18:56:05] 10Continuous-Integration-Infrastructure, 10VisualEditor: Provide the same version of Chrom{e|ium} in Docker and non-Docker (or migrate extensions to Docker) - https://phabricator.wikimedia.org/T184102#3872423 (10Jdforrester-WMF) [18:56:26] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Kanban), 10Discovery, 10Wikimedia-Portals, and 2 others: Update Portals page on Beta to reflect head of master branch - https://phabricator.wikimedia.org/T181799#3872436 (10hashar) [18:57:26] 10Continuous-Integration-Infrastructure, 10VisualEditor: Provide the same version of Chrom{e|ium} in Docker and Nodepool (or migrate qunit for extensions to Docker) - https://phabricator.wikimedia.org/T184102#3872442 (10Jdforrester-WMF) [18:58:54] 10Continuous-Integration-Infrastructure, 10VisualEditor: Provide the same version of Chrome/Chromium in Docker and Nodepool (or migrate qunit for extensions to Docker) - https://phabricator.wikimedia.org/T184102#3872449 (10matmarex) [19:07:27] !log deployment-prep: restored all the cherry picks on the puppet master [19:07:32] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:09:53] !log apt-get upgrade on deployment-tin . "downgrade" scap from 3.7.4-3 (apt.wm.o) to 3.7.4-1~20180103034049.266 (from CI) [19:09:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:11:47] Project beta-scap-eqiad build #189194: 04FAILURE in 1 min 44 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/189194/ [19:12:27] bah [19:18:25] deployment-mediawiki04.deployment-prep.eqiad.wmflabs returned [127]: bash: /srv/deployment/scap/scap/bin/scap: No such file or directory [19:18:43] Project beta-scap-eqiad build #189195: 04STILL FAILING in 5 min 0 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/189195/ [19:19:32] and of course puppet is broken everywhere [19:20:34] !log deployment-tin "upgrade" scap to 3.7.4-3 the version in apt.wm.o [19:20:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:24:37] no_justification: Might you have a look at T181923 (give us an idea of when we can do it) please? Greg said you'd be the right one to beg for deployment :) [19:24:38] T181923: Delete als.wik(ibooks|iquote|tionary), mo.wik(ipedia|tionary) - https://phabricator.wikimedia.org/T181923 [19:24:40] Yippee, build fixed! [19:24:40] Project beta-scap-eqiad build #189196: 09FIXED in 2 min 58 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/189196/ [19:24:42] !log deployment-prep: fix puppet run broken by a duplicate definition due to profile::base::firewall vs base::firewall [19:24:47] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:25:58] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Kanban), 10Discovery, 10Wikimedia-Portals, and 2 others: Update Portals page on Beta to reflect head of master branch - https://phabricator.wikimedia.org/T181799#3872627 (10hashar) I have cherry picked https://gerrit.wikimedia.org/r/#/c/394555/ on... [19:28:29] no_justification: ^ I think the bin directory thing caused some beta scap failures from the look of scrollback here [19:36:11] Well crud [19:36:13] Can revert [19:36:29] (sorry, been afk-ish setting up new ISP + redoing my whole entertainment center wiring) [19:39:41] entertainment center... [19:39:58] tv [19:39:59] :P [19:40:00] me wants one [19:44:49] lol [19:45:15] 10Beta-Cluster-Infrastructure, 10cloud-services-team (Kanban): Upgrade puppet 4.8 on all deployment-prep instance - https://phabricator.wikimedia.org/T184114#3872738 (10hashar) p:05Triage>03Normal [19:46:37] 10Beta-Cluster-Infrastructure, 10Puppet, 10Tracking: Deployment-prep hosts with puppet errors (tracking) - https://phabricator.wikimedia.org/T132259#3872756 (10hashar) [19:46:45] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Kanban): Various puppet issues in deployment-prep - https://phabricator.wikimedia.org/T180935#3872752 (10hashar) 05Open>03declined The original purpose of this task was to have puppet upgraded on all the beta cluster instances . I have created T184... [19:47:11] 10Beta-Cluster-Infrastructure, 10cloud-services-team (Kanban): Upgrade puppet 4.8 on all deployment-prep instance - https://phabricator.wikimedia.org/T184114#3872738 (10hashar) [19:50:03] 10Beta-Cluster-Infrastructure, 10cloud-services-team (Kanban): Upgrade puppet 4.8 on all deployment-prep instance - https://phabricator.wikimedia.org/T184114#3872775 (10hashar) deployment-mx fails due to mtail requiring systemd: Error: Could not retrieve catalog from remote server: Error 500 on SERVER: {"mess... [19:52:20] !log purging old kernels on deployment-mx / deployment-redis01 / deployment-redis02 | T184114 [19:52:25] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:52:25] T184114: Upgrade puppet 4.8 on all deployment-prep instance - https://phabricator.wikimedia.org/T184114 [19:55:03] !log manually upgrading puppet to 4.8 on deployment-mx / deployment-redis01 / deployment-redis02 | T184114 [19:55:08] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:58:05] 10Beta-Cluster-Infrastructure, 10cloud-services-team (Kanban): Upgrade puppet 4.8 on all deployment-prep instance - https://phabricator.wikimedia.org/T184114#3872803 (10hashar) 05Open>03Resolved a:03hashar ``` hashar@deployment-cumin:~$ sudo cumin --force '*' 'puppet --version' 77 hosts will be targeted:... [20:07:58] 10Gerrit: Setup gitiles for use with gerrit as a repo viewer - https://phabricator.wikimedia.org/T184116#3872823 (10Paladox) [20:08:06] legotkm mutante ^^ [20:08:22] legoktm ^^ [20:08:38] like a phab diffusion? [20:08:44] Yep [20:08:48] yay!!! [20:08:56] there was a disccusion about this in the scroll. [20:09:05] I'm tired to run like a headless chicken from one way to another to see the code [20:09:14] heh [20:10:26] 10Beta-Cluster-Infrastructure, 10Scap: scap package installed by CI breaks apt and thus puppet - https://phabricator.wikimedia.org/T184118#3872850 (10hashar) [20:10:28] 10Gerrit: Setup gitiles for use with gerrit as a repo viewer - https://phabricator.wikimedia.org/T184116#3872823 (10Dzahn) I like gitiles better than Diffusion or Github links. I think it's great if i can do code review and view repos in the same tool (Gerrit). So +1 to using that plugin. Also per IRC chat with... [20:10:40] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Kanban), 10Scap: scap package installed by CI breaks apt and thus puppet - https://phabricator.wikimedia.org/T184118#3872863 (10hashar) [20:12:21] paladox: +1 , commented on ticket, i like it [20:12:26] :) [20:12:36] especially the part where i dont have to use 2 different tools for code review and viewing repos [20:12:44] heh [20:13:12] i am not sure about the "seperate domain for it". no opinion yet [20:13:44] i know you mean like we had gitblit.wm.org [20:14:10] but this is just a plugin to gerrit. so i guess it's all under gerrit.wm.org and no real advantage for a separate one? hmm [20:15:32] if we wanted to separate the "code review" and "just view repos" part by having 2 seperate names.. what would that be? repos.wikimedia.org ? [20:15:52] really-git.wikimedia.org [20:16:06] * paladox begins testing gitiles [20:16:06] is there an advantage to not just using gerrit.wm.org? [20:16:15] i will be testing that [20:16:31] mutante legoktm https://gerrit.git.wmflabs.org/r/plugins/gitiles/test/+/7366a06f29ab68d65ee89b30b70e4579d3f12ae3 [20:16:45] https://gerrit.git.wmflabs.org/r/plugins/gitiles/?format=HTML [20:16:48] oh wow [20:16:52] yay it list all repos [20:17:00] nice and simple [20:17:19] :D [20:17:34] paladox: the only feature I couldn't find was "view raw file" [20:17:43] ah [20:17:46] yeh [20:17:51] e.g. https://raw.githubusercontent.com/wikimedia/mediawiki/master/composer.json [20:18:10] was I missing it or could we ask upstream to add that? [20:18:16] they wont support that for security reasons [20:18:37] oh? [20:18:39] Upstream blocked someone supporting that. [20:18:52] if we want to support it we can [20:18:57] by using the custom change [20:18:59] do you have a link? [20:19:15] I would have thought it could be safe with content-disposition but maybe not [20:19:56] https://gerrit-review.googlesource.com/#/c/gitiles/+/107739/ [20:19:57] something like ^^ [20:20:05] but would need to be ported to plugins/gitiles [20:20:53] and https://gerrit-review.googlesource.com/#/c/gitiles/+/107850/ [20:22:07] https://github.com/google/gitiles/issues/7 aha [20:22:22] Hauskatze, Reedy: Well, it's more than just a TV. It also has a Nintendo Switch and PC hooked up, as well as a very nice sound system :p [20:22:25] :p [20:23:53] lol. /me has a soundbar with a woofer. [20:25:39] * hashar has headphones [20:25:57] My friend bought some headphones. I yelled at him for buying bad ones :p [20:26:01] * no_justification is an audiophile [20:26:58] lol [20:29:15] 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10Patch-For-Review, 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3872896 (10hashar) I did most of the suite integration during my holidays. Bryan happily revie... [20:29:50] no_justification: planning to upload playthroughs on YouTube as well? :P [20:30:13] I don't understand the appeal there. Like, why would I want to *watch* someone play? [20:30:22] (much less waste time recording it so others can watch me?) [20:30:30] maybe I can hire you to wire and install a proper recording system in my courtroom [20:30:42] You own a courtroom? [20:30:44] Ministry says no funds yet [20:31:48] legoktm heh [20:32:08] no_justification isen't the nintendo switch basically a wii? [20:33:36] Um, no? It's like 182921821812981 times better [20:33:41] Native 1080p, for one [20:33:42] tonight on Twitch, watch the Wikipedia devs deploying live changes [20:33:52] LOL [20:34:05] well, I'd like to watch that tbh [20:34:17] video-tutorial on using scap [20:34:23] yea, heh [20:35:27] something about cherry-picking [20:35:52] lol [20:36:06] what about 4k? [20:37:38] scap in 4k? [20:38:27] * Hauskatze dinner, bbl [20:41:21] (03PS1) 10Legoktm: Disable timer for extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401798 [20:41:44] (03CR) 10Legoktm: [C: 032] "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/401798 (owner: 10Legoktm) [20:41:55] (03Abandoned) 10Legoktm: [DO NOT MERGE] Pin extension coverage to jessie-1004 [integration/config] - 10https://gerrit.wikimedia.org/r/401680 (owner: 10Legoktm) [20:44:49] (03Merged) 10jenkins-bot: Disable timer for extension coverage job [integration/config] - 10https://gerrit.wikimedia.org/r/401798 (owner: 10Legoktm) [20:46:08] legoktm actually we can chery pick that change then built the plugin against gitiles. (there's two type, one is https://github.com/google/gitiles/ and the other one is the gerrit plugin) [20:46:59] but that may be harder to build as it would requires us to build google/gitiles then modify the external_plugin_deps.bzl file and get it to use the local maven path. [20:50:06] 10Beta-Cluster-Infrastructure, 10VisualEditor, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10User-Ryasmeen, 10Verified: Special pages is not working on the beta cluster - https://phabricator.wikimedia.org/T183883#3872994 (10Jdforrester-WMF) [20:54:50] paladox: yeah, I'm not sure we want to keep local patches [20:54:58] yep. [21:04:19] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Zuul: Update zuul to upstream master - https://phabricator.wikimedia.org/T158243#3873014 (10hashar) I have created the branch `patch-queue/debian/jessie-wikimedia` which points to the same commit as `patch-queue/debian/precise-wikimedia`.... [21:36:18] 10Gerrit, 10Patch-For-Review: Setup gitiles for use with gerrit as a repo viewer - https://phabricator.wikimedia.org/T184116#3873106 (10Paladox) We should do this when upgrading to 2.14. [21:44:17] 10Gerrit, 10Patch-For-Review: Setup gitiles for use with gerrit as a repo viewer - https://phabricator.wikimedia.org/T184116#3873132 (10Paladox) [21:44:20] 10Gerrit, 10Release-Engineering-Team (Someday), 10Patch-For-Review: Update gerrit to 2.14.6 - https://phabricator.wikimedia.org/T156120#3873131 (10Paladox) [21:44:41] 10Gerrit, 10Patch-For-Review: Setup gitiles for use with gerrit as a repo viewer - https://phabricator.wikimedia.org/T184116#3872823 (10Paladox) [21:44:45] 10Gerrit, 10Release-Engineering-Team (Someday), 10Patch-For-Review: Update gerrit to 2.14.6 - https://phabricator.wikimedia.org/T156120#3263406 (10Paladox) [21:44:49] 10Gerrit, 10Patch-For-Review: Setup gitiles for use with gerrit as a repo viewer - https://phabricator.wikimedia.org/T184116#3872823 (10Paladox) [21:44:53] 10Gerrit, 10Release-Engineering-Team (Someday), 10Patch-For-Review: Update gerrit to 2.14.6 - https://phabricator.wikimedia.org/T156120#3263406 (10Paladox) [21:59:21] * paladox added syntax highlighting to polygerrit's editor yesturday :). [22:14:07] thcipriani: I'm just catching scrollback. Is beta broken by bin_dir swap? [22:14:27] Ah, probably not using a fully-qualified path to `scap` might break tasks.* [22:14:51] I think antoine fixed [22:15:14] but I think he fixed by putting us on the release branch release of scap [22:16:39] https://integration.wikimedia.org/ci/job/beta-scap-eqiad/189195/console [22:16:49] was what was happening [22:17:01] (possibly among other things...) [22:18:19] no_justification did you see https://gerrit-analytics.gerritforge.com/ ? :) [22:18:48] Nope, I haven't had the time. [22:19:07] thcipriani: Ah, yesh [22:19:10] Need fully qualified path [22:41:15] no_justification: does --fix in namespacedupes will fix pagelinks from https://phabricator.wikimedia.org/P6522 ? [22:48:43] thcipriani: https://phabricator.wikimedia.org/D941 [23:04:24] PROBLEM - puppet last run on contint2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [23:04:56] hrm, so does D941 mean that /srv/deployment/scap/scap/bin/scap is still in the path some place? Is that what caused https://integration.wikimedia.org/ci/job/beta-scap-eqiad/189195/console ? [23:04:57] D941: Fix path to scap in tasks.py - https://phabricator.wikimedia.org/D941 [23:07:12] thcipriani: Well I'm not sure *why* it would've been looking in /srv/deployment/scap/scap anyway [23:07:19] That...shouldn't even need to exist [23:07:25] I wonder [23:07:28] (much less why we'd be there as our cwd) [23:07:29] is this in /etc/scap.cfg? [23:07:46] would that make sense? maybe not... [23:09:32] or [23:09:51] did we just learn something about the beta-scap-eqiad job :) [23:11:05] no_justification: https://github.com/wikimedia/integration-config/blob/master/jjb/beta.yaml#L154 [23:11:08] :) [23:11:39] Dafuq? [23:11:42] so get_script_path is working just fine [23:11:56] Why are we bothering to build the Deb package then? [23:12:38] (also tasks.py still needs a patch cuz it depended on $PATH) [23:12:51] well the directory doesn't exist on the targets it seems. I don't think it should exist on deployment-tin. [23:13:01] Hauskatze: I dunno I haven't touched namespaceDupes in ages [23:13:17] thcipriani: we should nuke it from high orbit [23:13:19] true enough about tasks.py [23:13:28] accepted [23:13:52] yeah, we should kill it on deployment-tin and fix that job [23:15:56] (03PS1) 10Thcipriani: beta-scap-eqiad fix scap path [integration/config] - 10https://gerrit.wikimedia.org/r/401818 [23:20:02] alright, updated beta-scap-eqiad scap path, if the next run looks ok I'll merge ^ and rm -rf /srv/deployment/scap on deployment-tin [23:24:40] Should we revert to broken master, then apply our fixes? [23:24:44] To make sure they work? [23:27:44] (03CR) 10Thcipriani: [C: 032] "Seems to work" [integration/config] - 10https://gerrit.wikimedia.org/r/401818 (owner: 10Thcipriani) [23:27:45] eddiegp: Lemme read up on T181923 and give you a real ETA now that we're back from the holidays. Maybe tomorrow? :) [23:27:45] T181923: Delete als.wik(ibooks|iquote|tionary), mo.wik(ipedia|tionary) - https://phabricator.wikimedia.org/T181923 [23:28:56] (03Merged) 10jenkins-bot: beta-scap-eqiad fix scap path [integration/config] - 10https://gerrit.wikimedia.org/r/401818 (owner: 10Thcipriani) [23:29:24] RECOVERY - puppet last run on contint2001 is OK: OK: Puppet is currently enabled, last run 58 seconds ago with 0 failures [23:29:40] sure we can revert to broken master. I think that we were somehow breaking puppet. I think changelog needs to be updated for master is what antoine said. [23:30:02] I also don't know if it'll be broken now that we're invoking scap from the right path. [23:31:27] ah, scap package is currently breaking puppet it seems [23:42:49] alright, new/old/master scap version is on deployment-tin now [23:42:54] and puppet is fixed there [23:43:09] let's see if beta-scap-eqiad stays fixed [23:46:05] 10Gerrit, 10Patch-For-Review: Setup gitiles for use with gerrit as a repo viewer - https://phabricator.wikimedia.org/T184116#3873613 (10demon) >>! In T184116#3873106, @Paladox wrote: > We should do this when upgrading to 2.14. `s/when/after/` [23:46:48] Ok, landing D941 [23:46:49] D941: Fix path to scap in tasks.py - https://phabricator.wikimedia.org/D941 [23:49:16] 10MediaWiki-Codesniffer: PHPCS sniff to use namespaced PHPUnit classes - https://phabricator.wikimedia.org/T184137#3873615 (10Legoktm)