[01:22:04] 10Deployments, 10Release-Engineering-Team (Watching / External), 10Wikidata, 10Patch-For-Review, 10User-Ladsgroup: Make one group1 wiki a client of testwikidata (preferably a test wiki) - https://phabricator.wikimedia.org/T182326#3820084 (10Tgr) At a glance the special uses of test2wiki are: * test front... [01:32:19] no_justification: hey, any ideas why I cannot submit a change at https://gerrit.wikimedia.org/r/#/c/402460/ ? I'm the project admin according to https://gerrit.wikimedia.org/r/#/admin/groups/1432,members [01:35:18] bmansurov: you also need the "submit" permission. Fixed though [01:35:34] legoktm: thanks? [01:35:36] oops [01:35:38] thanks! [01:35:41] :) [01:35:49] legoktm: for future reference, how can I get the "submit" permission? [01:35:55] Add to the ACLs [01:36:00] https://gerrit.wikimedia.org/r/#/admin/projects/research/landing-page,access [01:36:29] thanks! [01:36:33] All-Projects doesn't contain a default submit policy. We let the root in a tree do it [01:36:47] So mediawiki/ operations/ etc [01:37:02] and the default expectation is that jenkins normally submits [01:37:34] sorry, what's ACL? [01:38:06] Usually we let owners do it too in most trees but for those that only want Jenkins to you have to set DENY in addition to ALLOW [01:38:20] Less confusing to be permissive [01:38:27] Access control lists [01:38:39] ok, got it, i'm gonna have to read up on this [01:39:35] Generally you don't have to think about it cuz most new repos are fine just setting owner. But a new top level usually trips folks up [01:40:24] i see [02:52:09] Project mediawiki-core-code-coverage-php7 build #5: 04FAILURE in 44 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-php7/5/ [02:58:10] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<33.33%) [03:08:07] Project mwext-phpunit-coverage-publish build #51: 04FAILURE in 8 min 6 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/51/ [03:44:44] Project mediawiki-core-code-coverage-php7 build #6: 04STILL FAILING in 44 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-php7/6/ [04:30:55] PROBLEM - Puppet staleness on deployment-kafka03 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [43200.0] [04:33:04] Project mediawiki-core-code-coverage build #3246: 04FAILURE in 1 hr 33 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/3246/ [04:59:29] PROBLEM - Puppet staleness on deployment-restbase01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0] [05:06:15] I filed T184333 for the broken coverage job [05:06:15] T184333: Query: DROP TEMPORARY TABLE IF EXISTS unittest_imagelinks Error: 1 near "TEMPORARY": syntax error breaking coverage job - https://phabricator.wikimedia.org/T184333 [05:09:31] PROBLEM - Puppet errors on deployment-sca01 is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [05:22:27] PROBLEM - Puppet staleness on deployment-restbase02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [43200.0] [05:28:20] PROBLEM - Work requests waiting in Zuul Gearman server on contint1001 is CRITICAL: CRITICAL: 53.33% of data above the critical threshold [140.0] https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10fullscreenorgId=1 [05:34:39] Yippee, build fixed! [05:34:40] Project mwext-phpunit-coverage-publish build #52: 09FIXED in 3 min 12 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/52/ [05:39:29] RECOVERY - Work requests waiting in Zuul Gearman server on contint1001 is OK: OK: Less than 30.00% above the threshold [90.0] https://grafana.wikimedia.org/dashboard/db/zuul-gearman?panelId=10fullscreenorgId=1 [05:49:31] RECOVERY - Puppet errors on deployment-sca01 is OK: OK: Less than 1.00% above the threshold [0.0] [05:50:03] (03PS1) 10Legoktm: Add breadcrumb navigation for finding extension coverage index [integration/docroot] - 10https://gerrit.wikimedia.org/r/402482 [05:52:47] (03CR) 10Legoktm: [C: 032] "I skimmed through https://getbootstrap.com/docs/3.3/components/#breadcrumbs and breadcrumbs looked like the most applicable thing to use." [integration/docroot] - 10https://gerrit.wikimedia.org/r/402482 (owner: 10Legoktm) [05:53:12] (03Merged) 10jenkins-bot: Add breadcrumb navigation for finding extension coverage index [integration/docroot] - 10https://gerrit.wikimedia.org/r/402482 (owner: 10Legoktm) [05:53:18] (03CR) 10jenkins-bot: Add breadcrumb navigation for finding extension coverage index [integration/docroot] - 10https://gerrit.wikimedia.org/r/402482 (owner: 10Legoktm) [06:17:03] (03PS1) 10Legoktm: Don't manually set $wgScribuntoDefaultEngine anymore [integration/jenkins] - 10https://gerrit.wikimedia.org/r/402483 [06:22:41] (03CR) 10Legoktm: "I noticed that coverage jobs using PHP7.0 don't have luasandbox installed yet (T184270), and realized that we can remove this now that lua" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/402483 (owner: 10Legoktm) [06:56:42] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [07:05:56] RECOVERY - Puppet staleness on deployment-kafka03 is OK: OK: Less than 1.00% above the threshold [3600.0] [07:07:04] RECOVERY - Puppet errors on deployment-kafka03 is OK: OK: Less than 1.00% above the threshold [0.0] [07:18:08] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [09:16:18] 10Continuous-Integration-Config, 10BlueSpice, 10Patch-For-Review: Enable unit tests on BlueSpice* repos - https://phabricator.wikimedia.org/T130811#2194298 (10Umherirrender) Many tests are now failing with missing classes. Please set the necessary dependency in integration/config in zuul/parameter_functions.... [09:17:20] 10Beta-Cluster-Infrastructure, 10Puppet: Puppet broken on deployment-netbox, looks like it thinks its a prod box - https://phabricator.wikimedia.org/T184242#3880063 (10hashar) [09:19:21] 10Beta-Cluster-Infrastructure, 10Puppet: Puppet broken on deployment-redis0[12] due to systemd on trusty - https://phabricator.wikimedia.org/T184243#3880068 (10hashar) [09:19:47] 10Beta-Cluster-Infrastructure, 10Operations, 10Patch-For-Review, 10Prometheus-metrics-monitoring, 10User-fgiunchedi: Move deployment-prep redis instances to stretch - https://phabricator.wikimedia.org/T179371#3722645 (10hashar) [09:20:11] 10Beta-Cluster-Infrastructure, 10Puppet: Puppet broken on deployment-redis0[12] due to systemd on trusty - https://phabricator.wikimedia.org/T184243#3877182 (10hashar) Will be fixed by upgrading them to stretch T179371 [09:20:29] 10Beta-Cluster-Infrastructure, 10Operations, 10Patch-For-Review, 10Prometheus-metrics-monitoring, 10User-fgiunchedi: Move deployment-prep redis instances to stretch - https://phabricator.wikimedia.org/T179371#3722645 (10hashar) [09:20:31] 10Beta-Cluster-Infrastructure, 10Puppet, 10Tracking: Deployment-prep hosts with puppet errors (tracking) - https://phabricator.wikimedia.org/T132259#3880073 (10hashar) [09:27:35] Hey, can I be an admin in deployment-prep project in labs? I thought I am but I can't make a new instance and I'm not in the list: https://tools.wmflabs.org/openstack-browser/project/deployment-prep [09:28:38] It is very weird because I remember making an instance (deployment-sca03), if it's taken away, I'm not notified or missed the message (which is very unlikely) [09:28:55] 10Continuous-Integration-Infrastructure: integration.integration-slave-jessie-1001 disk space full - https://phabricator.wikimedia.org/T184269#3880077 (10hashar) That is due to T179963 [09:29:53] 10Beta-Cluster-Infrastructure, 10ORES, 10Scoring-platform-team, 10Wikimedia-log-errors: Move beta cluster ORES to its own machine - https://phabricator.wikimedia.org/T184282#3880079 (10Ladsgroup) I was working on it and tried to make an instance in deployment-prep so I thought an admin but I'm not in the l... [09:30:00] 10Continuous-Integration-Infrastructure: integration.integration-slave-jessie-1001 disk space full - https://phabricator.wikimedia.org/T184269#3880080 (10hashar) 05Open>03Resolved a:03hashar I have deleted the php55lint jobs under /srv/jenkins-workspace/workspace [09:35:08] 10Beta-Cluster-Infrastructure, 10Operations, 10media-storage, 10Puppet: Puppet broken on deployment-ms-be0[34] with evaluation error in swift module - https://phabricator.wikimedia.org/T184236#3880084 (10hashar) That sounds like a puppet 4 issue. The mystery is why is Swift on production not affected by th... [09:40:42] RECOVERY - Free space - all mounts on integration-slave-jessie-1001 is OK: OK: integration.integration-slave-jessie-1001.diskspace._mnt.byte_percentfree (No valid datapoints found) [11:18:36] 10Continuous-Integration-Infrastructure: integration.integration-slave-jessie-1001 disk space full - https://phabricator.wikimedia.org/T184269#3880106 (10Paladox) Thanks. [11:26:21] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix Undefined index: scope_opener in IfElseStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402418 (https://phabricator.wikimedia.org/T183828) (owner: 10Umherirrender) [11:27:10] (03Merged) 10jenkins-bot: Fix Undefined index: scope_opener in IfElseStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402418 (https://phabricator.wikimedia.org/T183828) (owner: 10Umherirrender) [11:28:08] (03CR) 10jenkins-bot: Fix Undefined index: scope_opener in IfElseStructureSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402418 (https://phabricator.wikimedia.org/T183828) (owner: 10Umherirrender) [11:42:52] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team (Kanban), 10Scap: Scap not working in Beta - https://phabricator.wikimedia.org/T184176#3880123 (10mobrovac) Hm, I'm still getting the same message when trying to deploy Mathoid from `deployment-tin`, and it seems Scap hasn't been downgraded there: ``... [12:29:04] PROBLEM - Puppet errors on deployment-sca03 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [12:31:08] PROBLEM - Puppet errors on deployment-pdfrender02 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [12:31:59] PROBLEM - Puppet errors on deployment-logstash2 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [12:32:41] PROBLEM - Puppet errors on deployment-parsoid09 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [12:32:58] PROBLEM - Puppet errors on deployment-mcs01 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [12:33:09] PROBLEM - Puppet errors on deployment-sca02 is CRITICAL: CRITICAL: 11.11% of data above the critical threshold [0.0] [12:34:56] PROBLEM - Puppet errors on deployment-cpjobqueue is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [12:37:00] PROBLEM - Puppet errors on deployment-aqs03 is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [0.0] [12:39:10] PROBLEM - Puppet errors on deployment-cassandra3-01 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [12:39:47] PROBLEM - Puppet errors on deployment-changeprop is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [12:40:00] more puppet errors on beta? [12:40:31] PROBLEM - Puppet errors on deployment-sca01 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [12:42:51] PROBLEM - Puppet errors on deployment-aqs01 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [12:42:59] PROBLEM - Puppet errors on deployment-mira is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [12:44:34] PROBLEM - Puppet errors on deployment-imagescaler01 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [12:45:09] 10MediaWiki-Codesniffer, 10Patch-For-Review: Undefined index: scope_opener in IfElseStructureSniff - https://phabricator.wikimedia.org/T183828#3880365 (10Umherirrender) 05Open>03Resolved [12:45:18] PROBLEM - Puppet errors on deployment-cassandra3-02 is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [12:45:46] PROBLEM - Puppet errors on deployment-aqs02 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [12:47:01] PROBLEM - Puppet errors on deployment-tmh01 is CRITICAL: CRITICAL: 50.00% of data above the critical threshold [0.0] [12:47:53] PROBLEM - Puppet errors on deployment-tin is CRITICAL: CRITICAL: 33.33% of data above the critical threshold [0.0] [12:50:04] PROBLEM - Puppet errors on deployment-mathoid is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [12:50:28] PROBLEM - Puppet errors on deployment-mediawiki06 is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [12:52:01] PROBLEM - Puppet errors on deployment-eventlog02 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [12:52:43] PROBLEM - Puppet errors on deployment-jobrunner02 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [12:55:29] PROBLEM - Puppet errors on deployment-mediawiki04 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [12:57:31] Krenair: ^ ? [12:57:36] PROBLEM - Puppet errors on deployment-mediawiki05 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [12:58:50] PROBLEM - Puppet errors on deployment-zotero01 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [12:58:54] (03PS1) 10Umherirrender: Expand sniff to replace some php aliases with main function [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402581 (https://phabricator.wikimedia.org/T183220) [13:03:32] (03CR) 10jerkins-bot: [V: 04-1] Expand sniff to replace some php aliases with main function [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402581 (https://phabricator.wikimedia.org/T183220) (owner: 10Umherirrender) [13:06:14] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Personally I'm fine with all of these. But I think it's would be good to add test cases before merging this." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402581 (https://phabricator.wikimedia.org/T183220) (owner: 10Umherirrender) [13:08:22] (03PS2) 10Umherirrender: Expand sniff to replace some php aliases with main function [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402581 (https://phabricator.wikimedia.org/T183220) [13:09:35] (03CR) 10Umherirrender: "Patch Set 2: Fixed tests" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402581 (https://phabricator.wikimedia.org/T183220) (owner: 10Umherirrender) [15:47:22] Yippee, build fixed! [15:47:23] Project mediawiki-core-code-coverage-php7 build #7: 09FIXED in 47 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-php7/7/ [15:59:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Expand sniff to replace some php aliases with main function [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402581 (https://phabricator.wikimedia.org/T183220) (owner: 10Umherirrender) [16:41:51] Yippee, build fixed! [16:41:52] Project mediawiki-core-code-coverage build #3247: 09FIXED in 1 hr 41 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/3247/ [17:13:50] 10commit-message-validator, 10Google-Code-in-2017: Make Change-Id optional - https://phabricator.wikimedia.org/T179905#3880587 (10jayvdb) [17:14:49] 10commit-message-validator, 10Google-Code-in-2017: Make Change-Id optional - https://phabricator.wikimedia.org/T179905#3739796 (10jayvdb) [17:16:33] 10commit-message-validator, 10Google-Code-in-2017: Make Change-Id optional - https://phabricator.wikimedia.org/T179905#3739796 (10Paladox) Gerrit supports not having a change id, but dosen't support i think having a change reviewed without a change id due to it using that to update changes when you need to mak... [17:17:46] RECOVERY - Puppet errors on deployment-snapshot01 is OK: OK: Less than 1.00% above the threshold [0.0] [17:17:48] 10commit-message-validator, 10Google-Code-in-2017: Make Change-Id optional - https://phabricator.wikimedia.org/T179905#3880605 (10jayvdb) @Paladox , this isnt about Gerrit. Please read first. [17:19:33] 10commit-message-validator, 10Google-Code-in-2017: Make Change-Id optional - https://phabricator.wikimedia.org/T179905#3880606 (10Paladox) I did read it first. You want to use the same hook for GitHub, differential, gitlab and gerrit. But doint want to be forced to use the gerrit change id. [17:22:05] 10commit-message-validator, 10Google-Code-in-2017: Make Change-Id optional - https://phabricator.wikimedia.org/T179905#3880607 (10jayvdb) There will be no impact on how this tool is installed in Gerrit. [17:28:11] 10commit-message-validator, 10Google-Code-in-2017: Make Change-Id optional - https://phabricator.wikimedia.org/T179905#3880608 (10jayvdb) Imported as https://codein.withgoogle.com/dashboard/tasks/4929536800063488/ [17:28:48] PROBLEM - Puppet errors on deployment-snapshot01 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [18:22:39] 10commit-message-validator, 10Google-Code-in-2017: Make Change-Id optional - https://phabricator.wikimedia.org/T179905#3739796 (10Legoktm) > but I doubt a post-commit hook has access to that I think you can shell out to `git remote get-url origin` probably. [18:37:27] (03CR) 10Legoktm: [C: 032] Expand sniff to replace some php aliases with main function [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402581 (https://phabricator.wikimedia.org/T183220) (owner: 10Umherirrender) [18:38:10] (03Merged) 10jenkins-bot: Expand sniff to replace some php aliases with main function [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402581 (https://phabricator.wikimedia.org/T183220) (owner: 10Umherirrender) [18:39:08] (03CR) 10jenkins-bot: Expand sniff to replace some php aliases with main function [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402581 (https://phabricator.wikimedia.org/T183220) (owner: 10Umherirrender) [18:42:58] 10MediaWiki-Codesniffer: Add PHPCS rule to autofix some aliased PHP function names for consistency - https://phabricator.wikimedia.org/T183220#3880667 (10Umherirrender) Added: - is_writeable => is_writable - join => implode - key_exists => array_key_exists - pos => current - sizeof => count There are still some... [18:54:29] PROBLEM - Puppet errors on deployment-secureredirexperiment is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:56:57] PROBLEM - Puppet staleness on deployment-kafka03 is CRITICAL: CRITICAL: 10.00% of data above the critical threshold [43200.0] [18:58:41] 10Continuous-Integration-Infrastructure: mwgate-npm-node-6-docker job fails on AJAXPoll patch saying 'CoffeeScript on NPM has moved to "coffeescript"' - https://phabricator.wikimedia.org/T184350#3880680 (10SamanthaNguyen) [19:01:36] 10Continuous-Integration-Config: mwgate-npm-node-6-docker job fails on AJAXPoll patch saying 'CoffeeScript on NPM has moved to "coffeescript"' - https://phabricator.wikimedia.org/T184350#3880693 (10SamanthaNguyen) [19:35:43] 10Continuous-Integration-Config: mwgate-npm-node-6-docker job fails on AJAXPoll patch saying 'CoffeeScript on NPM has moved to "coffeescript"' - https://phabricator.wikimedia.org/T184350#3880680 (10Umherirrender) Also seen on Flow - https://gerrit.wikimedia.org/r/#/c/402154/ [19:35:55] 10Continuous-Integration-Config: mwgate-npm-node-6-docker job fails saying 'CoffeeScript on NPM has moved to "coffeescript"' - https://phabricator.wikimedia.org/T184350#3880711 (10Umherirrender) [20:03:42] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [20:20:55] PROBLEM - Puppet errors on deployment-ms-be04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:33:41] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [20:46:31] PROBLEM - Puppet errors on deployment-ms-be03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:36:06] 10Continuous-Integration-Infrastructure, 10MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Generate code coverage reports for extensions - https://phabricator.wikimedia.org/T71685#3880767 (10Legoktm) I ended up moving the... [22:23:06] (03PS1) 10Umherirrender: Skip __construct on checking for @return tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402603 (https://phabricator.wikimedia.org/T177323) [22:42:50] legoktm about the code coverage in polygerrit, is there a way we can parse a json file? [22:43:06] 10Continuous-Integration-Config: mwgate-npm-node-6-docker job fails saying 'CoffeeScript on NPM has moved to "coffeescript"' - https://phabricator.wikimedia.org/T184350#3880857 (10Legoktm) I'm not sure if this is related to https://npmjs.statuspage.io/incidents/41zfb8qpvrdj [22:43:12] since parsing xml files is not supported native in javascript. [22:43:20] uhhh [22:43:45] https://developer.mozilla.org/en-US/docs/Web/Guide/Parsing_and_serializing_XML [22:44:43] ahh [22:45:26] we could just copy the coverage xml file to some where static and use that url within the plugin. [22:46:16] we will probaly need to use this.getBaseUrl() [23:04:41] 10Continuous-Integration-Config: mwgate-npm-node-6-docker job fails saying 'CoffeeScript on NPM has moved to "coffeescript"' - https://phabricator.wikimedia.org/T184350#3880862 (10SamanthaNguyen) Thanks to both for you for the information :) So it seems that was related/the cause, and now that I've asked jenkins... [23:10:21] 10Continuous-Integration-Config: mwgate-npm-node-6-docker job fails saying 'CoffeeScript on NPM has moved to "coffeescript"' - https://phabricator.wikimedia.org/T184350#3880867 (10Umherirrender) 05Open>03Resolved >>! In T184350#3880862, @SamanthaNguyen wrote: > Also @Umherirrender Sorry, I accidentally reche... [23:17:26] (03PS1) 10Umherirrender: Fix SpaceyParenthesisSniff comment detection for ignore statements [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/402605