[00:03:56] Yippee, build fixed! [00:03:56] Project mwext-phpunit-coverage-publish build #658: 09FIXED in 3 min 29 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/658/ [00:07:37] 10Gerrit: Support OAuth for login onto gerrit.wikimedia.org - https://phabricator.wikimedia.org/T147864#3951025 (10demon) Would suck to have to install PHP just for that but I get your point: can do it indirectly via authnz_fcgi or similar. [00:14:47] how do i know if i have deploy rights for m/w? i know i have it for parsoid. [00:15:50] subbu: you have it [00:16:09] ah, ok .. thanks. [00:16:24] you are in the group called "deployment" (not just parsoid-admin and deploy-service) [00:16:33] that is what should tell us [00:16:49] in puppet://modules/admin/data/data.yaml [00:17:22] i see. ok. [00:31:16] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [00:34:33] 10Gerrit: Support OAuth for login onto gerrit.wikimedia.org - https://phabricator.wikimedia.org/T147864#3951201 (10Tgr) I think authnz_fcgi allows the CGI script to be hosted remotely so it could be centralized (and then use something like mod_session to remember the user). [00:35:55] Krinkle: is the Gerrit login page as you intended it now [00:37:26] mutante: Yep, looks perfect [00:37:28] renders faster, too! [00:38:09] :) cool! [00:38:15] thanks for the fixes [00:56:29] (03CR) 10Legoktm: [C: 032] Redo "Install php7.0-gd in `php` image" [integration/config] - 10https://gerrit.wikimedia.org/r/408230 (https://phabricator.wikimedia.org/T185393) (owner: 10Legoktm) [00:56:46] (03PS2) 10Legoktm: Redo "Install php7.0-gd in `php` image" [integration/config] - 10https://gerrit.wikimedia.org/r/408230 (https://phabricator.wikimedia.org/T185393) [00:56:50] (03CR) 10Legoktm: [C: 032] Redo "Install php7.0-gd in `php` image" [integration/config] - 10https://gerrit.wikimedia.org/r/408230 (https://phabricator.wikimedia.org/T185393) (owner: 10Legoktm) [00:58:00] (03Merged) 10jenkins-bot: Redo "Install php7.0-gd in `php` image" [integration/config] - 10https://gerrit.wikimedia.org/r/408230 (https://phabricator.wikimedia.org/T185393) (owner: 10Legoktm) [01:00:29] !log deploying https://gerrit.wikimedia.org/r/408230 [01:00:33] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:17:09] (03PS1) 10Legoktm: Add php7.0-gd to ci-src-setup [integration/config] - 10https://gerrit.wikimedia.org/r/408735 [01:17:26] (03CR) 10Legoktm: [C: 032] Add php7.0-gd to ci-src-setup [integration/config] - 10https://gerrit.wikimedia.org/r/408735 (owner: 10Legoktm) [01:18:55] (03Merged) 10jenkins-bot: Add php7.0-gd to ci-src-setup [integration/config] - 10https://gerrit.wikimedia.org/r/408735 (owner: 10Legoktm) [01:19:57] !log deploying https://gerrit.wikimedia.org/r/408735 [01:20:02] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [01:29:00] 10Gerrit, 10Operations, 10Patch-For-Review, 10Performance: New gerrit login ui is causing performance problems when going through gerrit.wikimedia.org - https://phabricator.wikimedia.org/T185506#3951289 (10Krinkle) 05Open>03Resolved [01:29:06] 10Gerrit, 10Operations, 10Performance: New gerrit login ui is causing performance problems when going through gerrit.wikimedia.org - https://phabricator.wikimedia.org/T185506#3917733 (10Krinkle) [01:32:20] (03PS1) 10Legoktm: Bump ci-sr-setup and mediawiki-phan image versions [integration/config] - 10https://gerrit.wikimedia.org/r/408737 [01:40:21] (03CR) 10Legoktm: [C: 032] Bump ci-sr-setup and mediawiki-phan image versions [integration/config] - 10https://gerrit.wikimedia.org/r/408737 (owner: 10Legoktm) [01:42:05] (03Merged) 10jenkins-bot: Bump ci-sr-setup and mediawiki-phan image versions [integration/config] - 10https://gerrit.wikimedia.org/r/408737 (owner: 10Legoktm) [01:43:30] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Patch-For-Review: mwext-php70-phan-docker fails (missing ext-gd) - https://phabricator.wikimedia.org/T185393#3951330 (10Legoktm) 05Open>03Resolved a:03Legoktm Fixed by a combination of: * {87e1c7b654379331c52b94418f68c5f706b571... [02:02:17] 10Continuous-Integration-Infrastructure, 10Operations, 10Traffic: Lower varnish caching length on doc.wikimedia.org - https://phabricator.wikimedia.org/T184255#3951341 (10Legoktm) 05Open>03Resolved a:03Legoktm Yep! [02:08:40] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<22.22%) [02:21:15] 10Continuous-Integration-Infrastructure: Pin jsduck version? - https://phabricator.wikimedia.org/T179362#3951356 (10Legoktm) 05Open>03declined jsduck is being replaced, so I guess this is moot: {T138401}. [02:38:38] 10Continuous-Integration-Infrastructure: Move commit-message-validator.py tool out of integration/jenkins repository - https://phabricator.wikimedia.org/T121609#3951398 (10Legoktm) 05Open>03Resolved a:03Legoktm This happened, it's now integration/commit-message-validator. [02:38:54] 10Continuous-Integration-Infrastructure, 10Analytics, 10Patch-For-Review: Add json linting test for schemas in mediawiki/event-schemas - https://phabricator.wikimedia.org/T124319#3951401 (10Legoktm) [02:43:06] 10Continuous-Integration-Infrastructure: Disable xdebug's html formatting of PHP errors for Apache on Jenkins slaves - https://phabricator.wikimedia.org/T97040#3951403 (10Legoktm) [02:52:18] (03CR) 10Legoktm: [C: 032] Add job to run seccheck plugin [integration/config] - 10https://gerrit.wikimedia.org/r/408368 (https://phabricator.wikimedia.org/T182599) (owner: 10Legoktm) [02:52:28] (03PS2) 10Legoktm: Add job to run seccheck plugin [integration/config] - 10https://gerrit.wikimedia.org/r/408368 (https://phabricator.wikimedia.org/T182599) [02:52:39] (03CR) 10Legoktm: [C: 032] Add job to run seccheck plugin [integration/config] - 10https://gerrit.wikimedia.org/r/408368 (https://phabricator.wikimedia.org/T182599) (owner: 10Legoktm) [02:55:52] (03Merged) 10jenkins-bot: Add job to run seccheck plugin [integration/config] - 10https://gerrit.wikimedia.org/r/408368 (https://phabricator.wikimedia.org/T182599) (owner: 10Legoktm) [02:57:00] !log deploying https://gerrit.wikimedia.org/r/408368 [02:57:06] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [03:00:50] (03PS1) 10Legoktm: Add mwext-php70-phan-seccheck-docker as experimental [integration/config] - 10https://gerrit.wikimedia.org/r/408746 (https://phabricator.wikimedia.org/T182599) [03:03:03] (03PS1) 10Legoktm: fabfile: Run docker-pkg as our own users [integration/config] - 10https://gerrit.wikimedia.org/r/408747 [03:07:10] (03CR) 10Legoktm: [C: 032] Add mwext-php70-phan-seccheck-docker as experimental [integration/config] - 10https://gerrit.wikimedia.org/r/408746 (https://phabricator.wikimedia.org/T182599) (owner: 10Legoktm) [03:09:49] (03Merged) 10jenkins-bot: Add mwext-php70-phan-seccheck-docker as experimental [integration/config] - 10https://gerrit.wikimedia.org/r/408746 (https://phabricator.wikimedia.org/T182599) (owner: 10Legoktm) [03:15:57] !log deployed https://gerrit.wikimedia.org/r/408746 [03:16:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [03:45:51] 10Continuous-Integration-Config, 10Security-Team, 10phan-taint-check-plugin, 10Patch-For-Review: Make jenkins run security-check-plugin non-voting - https://phabricator.wikimedia.org/T182599#3951542 (10Legoktm) After a bit of fiddling... https://integration.wikimedia.org/ci/job/mwext-php70-phan-seccheck-do... [03:47:06] (03PS1) 10Legoktm: Fix up mwext-php70-phan-seccheck-docker job [integration/config] - 10https://gerrit.wikimedia.org/r/408754 [03:47:16] (03CR) 10Legoktm: [C: 032] Fix up mwext-php70-phan-seccheck-docker job [integration/config] - 10https://gerrit.wikimedia.org/r/408754 (owner: 10Legoktm) [03:47:31] 10Continuous-Integration-Config, 10Security-Team, 10phan-taint-check-plugin, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Make jenkins run security-check-plugin non-voting - https://phabricator.wikimedia.org/T182599#3951544 (10Legoktm) [03:49:41] (03Merged) 10jenkins-bot: Fix up mwext-php70-phan-seccheck-docker job [integration/config] - 10https://gerrit.wikimedia.org/r/408754 (owner: 10Legoktm) [06:43:27] (03PS1) 10Legoktm: Begin migrating php-compile-* jobs to docker [integration/config] - 10https://gerrit.wikimedia.org/r/408760 [07:08:39] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [08:28:28] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, 10Patch-For-Review: mwext-php70-phan-docker fails (missing ext-gd) - https://phabricator.wikimedia.org/T185393#3951707 (10WMDE-Fisch) Thanks for working on this! [08:45:01] 10Gerrit, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Clean up mediawiki/extensions/Wikibase ACL - https://phabricator.wikimedia.org/T183081#3842843 (10JeroenDeDauw) I poked at this stuff way back in 2013(?) and remember we had some problems with the default config. I believe one of the issues we... [10:10:19] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3951831 (10MarcoAurelio) [11:28:56] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3952140 (10MarcoAurelio) [11:38:40] (03PS1) 10MarcoAurelio: Archive mediawiki/php/FastStringSearch [integration/config] - 10https://gerrit.wikimedia.org/r/408781 (https://phabricator.wikimedia.org/T186684) [12:26:02] 10Gerrit, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Clean up mediawiki/extensions/Wikibase ACL - https://phabricator.wikimedia.org/T183081#3952268 (10Addshore) I remember when I first joined the Wikidata team I accidently just pushed to gerrit, and it let me šŸ“¦... IMO I see no reason that we can... [12:30:54] PROBLEM - Puppet errors on deployment-ores01 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [13:51:24] hi, any idea why this test fails... https://gerrit.wikimedia.org/r/#/c/408549/ i tried to look at the jenkins output https://integration.wikimedia.org/ci/job/service-pipeline-test-only/27/console but I can not relate that to my change [14:11:03] 10Phabricator, 10JavaScript: When creating a new task, tags should be middle-clickable to go to their description page - https://phabricator.wikimedia.org/T186710#3952468 (10Od1n) [14:26:01] 10Scap: Add DEPLOY_DIR env var to scap command checks - https://phabricator.wikimedia.org/T154612#3952507 (10awight) [14:26:06] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review, 10Scoring-platform-team (Current), 10Wikimedia-Incident: Cache ORES virtualenv within versioned source - https://phabricator.wikimedia.org/T181071#3952506 (10awight) [14:28:27] 10Scap: Add DEPLOY_DIR env var to scap command checks - https://phabricator.wikimedia.org/T154612#3952518 (10awight) Just noting that we're blocked by this bug, and I have a patch {D955} ready for review. Please let us know when this might make it into your team's workflow, thanks! [14:30:11] 10Phabricator (Upstream), 10Upstream: When creating a new task, tags should be middle-clickable to go to their description page - https://phabricator.wikimedia.org/T186710#3952535 (10Aklapper) 05Open>03declined You can see a short summary when using the magnifier class icon in the "Tags" field to choose ta... [14:47:33] 10Phabricator (Upstream), 10Upstream: When creating a new task, tags should be middle-clickable to go to their description page - https://phabricator.wikimedia.org/T186710#3952628 (10Od1n) Even in this "Browse Projects" modal, there is no link to go to the tag page! I think this request should be reconsidered... [14:53:18] PROBLEM - Host deployment-puppetdb01 is DOWN: CRITICAL - Host Unreachable (10.68.23.76) [15:24:13] 10Scap, 10ORES, 10Operations, 10Scoring-platform-team: Use external dsh group to list pooled ORES nodes - https://phabricator.wikimedia.org/T179501#3726795 (10akosiaris) ORES dsh groups populated via conftool alongside 2 canaries is in https://gerrit.wikimedia.org/r/#/c/408799/. Some changes are required... [15:39:54] 10Phabricator, 10DBA, 10Security: Improve privilege separation for phabricator's config files and mysql credentials - https://phabricator.wikimedia.org/T146055#3952848 (10jcrespo) We need to catch up on a lot of pending DBA-phabricator tasks (this, some pending failovers, upgrades to strech/mariadb 10.1) and... [15:45:01] 10Continuous-Integration-Infrastructure, 10Operations, 10Patch-For-Review: legoktm can't deploy docker images on contint1001 - https://phabricator.wikimedia.org/T186475#3952875 (10akosiaris) >>! In T186475#3950009, @hashar wrote: > Both @Legoktm and @Addshore already have the privileges to run privileged cod... [16:01:18] Iā€™m trying to run selenium tests under mediawiki-vagrant, hoping someone can point me to docs? [16:02:14] Iā€™m following https://www.mediawiki.org/wiki/Selenium/Node.js/Inside_MediaWiki-Vagrant and get these errors, https://phabricator.wikimedia.org/P6665 [16:17:16] Seems like there are lots of missing node modules, are we sure that this is enough?: cd /vagrant/mediawiki; npm install [16:24:53] zeljkof: ^ :) [16:26:00] awight: it works on my machine! ;) [16:26:13] sorry, meetings start in a few minutes, will take a look later [16:26:35] awight: can you please create phab task and assign it to me? [16:26:38] so it does not get lost [16:28:01] 10Phabricator (Upstream), 10Upstream: When creating a new task, tags should be middle-clickable to go to their description page - https://phabricator.wikimedia.org/T186710#3953050 (10Aklapper) Feel free to discuss with upstream developers as this is not up to Wikimedia and we will not maintain a custom patch f... [16:28:08] zeljkof: sure, will do. Sorry for the noise but it would be great to get this working. [16:29:55] awight: no problem, I'm glad you have found the problem [16:30:07] it used to work, I did test everything, I think [16:30:28] while writing the docs, but we don't have any CI for it yet, so changes go undetected [16:33:19] PROBLEM - Puppet errors on deployment-logstash2 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [16:34:51] I like that you immediately thought of meta-testing ;-) [16:37:02] 10Release-Engineering-Team, 10Browser-Tests: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3953125 (10awight) [16:50:47] 10Release-Engineering-Team, 10Browser-Tests: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3953185 (10awight) [16:51:06] 10Release-Engineering-Team, 10Browser-Tests: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3953125 (10awight) Very strange, I ran the whole sequence again and got different errors: ``` vagrant@mediawikivagrant:/vagrant/mediawiki$ npm run selenium > @ se... [17:06:31] 10Phabricator (Upstream), 10Upstream: When creating a new task, tags should be middle-clickable to go to their description page - https://phabricator.wikimedia.org/T186710#3953257 (10Od1n) Phabricator's [[ https://secure.phabricator.com/book/phabcontrib/article/contributing_code/ | Contributing Code ]]: > To... [17:06:33] 10Release-Engineering-Team (Watching / External), 10Epic, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Deploy refactored comment storage - https://phabricator.wikimedia.org/T166733#3953258 (10Anomie) [17:59:27] hey releng folks, I need to spin up a memcached that will be used only by php7 mw instances, and I'm thinking of calling it deployment-memc-php701 so people don't try to immediately use it for $random_mw_instance, but [18:00:00] will it pick up the deployment-memc settings in the prefix properly? and, do you think that name is too gross? :-P [18:17:00] no_justification, what do you think? [18:26:03] (03PS2) 10Thcipriani: fabfile: Run docker-pkg as our own users [integration/config] - 10https://gerrit.wikimedia.org/r/408747 (owner: 10Legoktm) [18:26:24] (03CR) 10Thcipriani: [C: 032] "Looks like an oversight from 3114e4ae5c6" [integration/config] - 10https://gerrit.wikimedia.org/r/408747 (owner: 10Legoktm) [18:28:05] (03Merged) 10jenkins-bot: fabfile: Run docker-pkg as our own users [integration/config] - 10https://gerrit.wikimedia.org/r/408747 (owner: 10Legoktm) [18:31:56] apergos: I lack opinions really šŸ˜Š [18:32:21] geethanks :-P [18:32:54] I might just trial and error it tomorrow then, if it fails I delte the instance [18:33:00] shrug [18:33:13] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Variant expansion recursion doesn't work for multiple variants - https://phabricator.wikimedia.org/T186544#3953589 (10dduvall) [18:33:24] I mean the names seem OK. Whether or not the hiera sticks is a question for the regex matches we do [18:34:03] I looked at the coe and it seemed like it would work but if someone knows better, figued asking can't hurt [18:34:09] *code [18:34:11] *figured [18:34:14] see what happens? :P [18:34:14] *typos suck [18:34:35] greg-g: scheduled for tomorrow am :-P [18:34:48] solid [18:34:51] your am,right? [18:34:56] uh huh [18:35:18] it's not going to break deployment prep because it's only going to be used by the snapshot instance [18:35:33] at worst puppet would whine on the instance itself [18:36:00] *only on the snapshot instance for NOW [18:36:18] later we'll add more to that pool I guess, when it comes time to try appservers on php7 generally [18:37:14] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Variant expansion recursion doesn't work for multiple variants - https://phabricator.wikimedia.org/T186544#3953596 (10dduvall) 05Open>03Resolved [18:39:30] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Blubber should support python/tox - https://phabricator.wikimedia.org/T186545#3946912 (10dduvall) a:03dduvall [18:44:50] ah I have to get an ip address for it... grumble [18:47:44] oh maybe I don't need anything but the internal one whew [18:54:28] PROBLEM - Puppet errors on deployment-secureredirexperiment is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:59:05] PROBLEM - Puppet errors on deployment-memc-php01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:59:47] yeah, I don't remember how to use the deployment-prep puppetmaster [18:59:59] it's giving the whine about the self-signed cert from deployment-puppetmaster02 [19:00:04] ummm [19:03:18] hashar thcipriani : sorry to trouble you but is there someone from releng that can update the npm-browser-test Docker image with the latest version of Chromium or give me permission to? (background: https://phabricator.wikimedia.org/T179552#3947612) [19:05:13] niedzielski: I saw that in the SoS notes, I'll see if I can take a look at what's involved after SWAT [19:05:37] thcipriani: thanks so much! [19:05:43] * thcipriani doffs hat [19:06:32] šŸŽ©šŸŽ©šŸŽ© [19:09:27] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Blubber should support python/tox - https://phabricator.wikimedia.org/T186545#3953680 (10dduvall) I'm not exactly sure how we can implement the same cache efficiency for Python project dependencies as we did for Node projects. Blubber would hav... [19:10:49] ok i give up, what is the workaround for this? [19:12:09] https://phabricator.wikimedia.org/P6667 [19:12:09] apergos: I usually do https://www.mediawiki.org/wiki/Continuous_integration/Docker#Jenkins_Agent_Creation [19:12:29] it's not self-hosted and I don't want it to be [19:12:47] ah ugh [19:12:48] I see [19:12:56] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Blubber should support python/tox - https://phabricator.wikimedia.org/T186545#3953691 (10dduvall) For an example of what I mean, look at [[ https://phabricator.wikimedia.org/source/scap/browse/master/Dockerfile.ci;954541b6d93cd4b7b747023f47dbd9... [19:14:28] I thought I didn't have to do that for non-self-hosted but must have remembered wrong, thanks! [19:15:40] I didn't have to do that much, just move /var/lib/puppet/ssl out of the way, rerun puppet, go sign the cert and rerun puppet one last time [19:17:16] yw, glad that worked :) [19:19:45] me too :-) [19:20:12] 10Gerrit, 10Release-Engineering-Team, 10Security: Upgrade gerrit from 2.14.6 to 2.14.7 - https://phabricator.wikimedia.org/T186135#3953744 (10demon) p:05Triage>03Low [19:20:22] 10Gerrit, 10Release-Engineering-Team, 10Security: Upgrade gerrit from 2.14.6 to 2.14.7 - https://phabricator.wikimedia.org/T186135#3934807 (10demon) Didn't really need to be private tbh :) [19:24:07] RECOVERY - Puppet errors on deployment-memc-php01 is OK: OK: Less than 1.00% above the threshold [0.0] [19:39:24] 10MediaWiki-Codesniffer, 10Readers-Web-Backlog (Tracking): Add rule to require use of @covers in PHPUnit tests - https://phabricator.wikimedia.org/T179094#3953863 (10Legoktm) a:03Legoktm [19:40:12] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3953864 (10demon) Ok, so did a couple of things here # Added you to group 119 # Renamed the group to "Project and Group Managers" (instead of Creators) # Also granted "Delete Project... [19:40:22] 10MediaWiki-Codesniffer, 10Readers-Web-Backlog (Tracking): Add rule to require use of @covers in PHPUnit tests - https://phabricator.wikimedia.org/T179094#3713087 (10Legoktm) [19:46:26] Hauskatze: Sooooo, I poked T186690.... [19:46:26] T186690: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690 [19:47:26] Actually, I'll /msg you [19:47:33] no_justification: okay [19:53:20] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3953898 (10demon) Also granted permissions on `refs/meta/config` to said group. They're already trusted folks :) [19:54:05] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3953899 (10demon) 05Open>03Resolved a:03demon I **think** this should cover it. Lemme know if you run into problems. [19:54:06] so, let's say we change 'DB_REPLICA' to 'DB_MASTER' in https://phabricator.wikimedia.org/source/mediawiki/browse/master/maintenance/cleanupSpam.php;5db74eb56e425ba803b2cc936fbe3e5cc219b482$66 [19:54:25] will that get the most up-to-date results? [19:54:44] cause maurelio@deployment-tin:~$ mwscript cleanupSpam.php --wiki=deploymentwiki *.eladia.space --delete claims no article has such data [19:54:55] 10Gerrit, 10Release-Engineering-Team (Someday), 10Cleanup, 10Wikidata, and 3 others: Mark extension-Wikidata & wikidata-build-resources on Gerrit as ARCHIVED - https://phabricator.wikimedia.org/T181838#3953902 (10Addshore) MW-Vagrant is no longer using this :) [19:54:59] but https://deployment.wikimedia.beta.wmflabs.org/wiki/Tarot_Hratis says {{liez}} [19:55:07] 10Release-Engineering-Team, 10Wikidata, 10Epic, 10Patch-For-Review, 10User-Addshore: [Epic] Kill the Wikidata build step - https://phabricator.wikimedia.org/T173818#3953905 (10Addshore) [19:55:11] 10Gerrit, 10Release-Engineering-Team (Someday), 10Cleanup, 10Wikidata, and 3 others: Mark extension-Wikidata & wikidata-build-resources on Gerrit as ARCHIVED - https://phabricator.wikimedia.org/T181838#3953903 (10Addshore) 05Open>03Resolved a:03Addshore [19:57:12] PROBLEM - Puppet errors on deployment-snapshot01 is CRITICAL: CRITICAL: 22.22% of data above the critical threshold [0.0] [19:58:22] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3953935 (10MarcoAurelio) Thanks @demon - just to be sure: is it allowed that I self +2 changes like https://gerrit.wikimedia.org/r/#/c/408787/ and https://gerrit.wikimedia.org/r/#/c/... [19:59:13] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3953936 (10demon) Definitely the latter is ok. I personally think the former is ok too as it's just general maintenance already agreed to on the underlying task. [20:04:27] I'm the puppet errors again, working on it [20:05:06] apergos: puppet is broken on labs when you have a self puppetmaster [20:05:23] nah, it's not that [20:05:27] apergos: https://phabricator.wikimedia.org/T152941 has the fix (look at workaround) [20:05:41] this is using the regular puppetmaster, it was just acting up, thanks though [20:05:46] hasharAway puppet works for me @ labs. [20:06:59] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3953958 (10MarcoAurelio) Well, don't worry, I do not have +2 outside refs/meta/config so I'll still need someone else to merge the changes there. Safer I think :) [20:07:04] what I broke now is just changing the memcached server for my snapshot instance, but it's fixed now [20:11:41] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3953968 (10Legoktm) Awesome! [20:17:05] (03PS1) 10Legoktm: docker: Move config.yaml to expected docker-pkg name [integration/config] - 10https://gerrit.wikimedia.org/r/408866 [20:17:14] RECOVERY - Puppet errors on deployment-snapshot01 is OK: OK: Less than 1.00% above the threshold [0.0] [20:31:34] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render and chromium-render-deploy repositories - https://phabricator.wikimedia.org/T179552#3728431 (10thcipriani) >>! In T179552#3947612, @Niedzielski wrote: > Fo... [20:41:13] paladox: o/ o/ i don't suppose you have permission to give me write permissions to this Gerrit repo I'm trying to configure: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/services/chromium-render/deploy [20:41:21] someone set the push limit to 100 bytes! i can't even open a patch against it :] [20:41:39] niedzielski hi, nope [20:41:42] no_justification ^^ [20:41:51] Bad timing. [20:41:58] I'll look in a minute [20:42:01] i basically just want to remove the byte limit so it'll go back to the default (100m) as seen in this example: https://gerrit.wikimedia.org/r/#/admin/projects/marvin [20:42:19] thanks paladox no_justification ! [20:42:30] :) [20:43:20] Set to 100m manually [20:43:26] (also, 100m is still really freaking big :() [20:45:28] hooray!! [20:45:34] thanks so much no_justification paladox ! [20:45:39] :) [20:46:24] thcipriani: if i run `apt-get install` in the npm-browser-test container, is that going to change the state for all other users? i want to run the tests after installing the latest version of the chromium package but i didn't want to botch the container for other jobs! [20:47:38] niedzielski: no? do you mean the container's dockerfile or just the run script? [20:49:01] legoktm: o/ well, i'm doing something like `docker run ... -u root -ti --entrypoint=/bin/bash docker-registry.wikimedia.org/releng/npm-browser-test:0.1.0`. i don't want to install a dependency if this mutates the container [20:49:11] (i hardly have any docker experience) [20:49:19] oh [20:49:58] basically think of docker images as frozen VMs, every time you do something in a container, you've copied the docker image into a new instance, modified that instance, and so on. Whatever you do won't affect the state of any other instances [20:50:00] (but i need to install the dependency to run the tests that determine whether we should update the container for everyone :] ) [20:50:43] nice! so the only time they get updated is when they're published, right? [20:50:46] yeah [20:50:52] is all you want the latest version of chromium to be installed? [20:51:00] ok well then i'm in a great spot [20:51:41] I can just rebuild the image to pull in a newer version of chromium [20:52:05] legoktm: yeah, we're working on T179552 and thcipriani was following up on my comment. i just need to run these tests and then we'll solicit feedback from hashar [20:52:06] T179552: Set up Jenkins for chromium-render and chromium-render-deploy repositories - https://phabricator.wikimedia.org/T179552 [20:52:13] (who made the container) [20:59:33] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render and chromium-render-deploy repositories - https://phabricator.wikimedia.org/T179552#3728431 (10Legoktm) It should be fine to just upgrade it - Chromium 64... [21:01:04] (03PS1) 10Legoktm: Rebuild npm-browser-test image [integration/config] - 10https://gerrit.wikimedia.org/r/408876 [21:01:07] (03PS1) 10Legoktm: Update jobs to use npm-browser-test:0.1.1 [integration/config] - 10https://gerrit.wikimedia.org/r/408877 [21:01:23] thanks legoktm, i was able to run the test šŸ‘ [21:02:41] 10Project-Admins, 10Africa-Wikimedia-Developers: Project work board request for WikiFundi - https://phabricator.wikimedia.org/T186754#3954122 (10D3r1ck01) [21:03:24] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render and chromium-render-deploy repositories - https://phabricator.wikimedia.org/T179552#3954133 (10Legoktm) * https://gerrit.wikimedia.org/r/#/c/408876/ * http... [21:03:54] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render and chromium-render-deploy repositories - https://phabricator.wikimedia.org/T179552#3954135 (10Niedzielski) @thcipriani, @Legoktm, @hashar, the latest vers... [21:08:22] PROBLEM - Puppet errors on deployment-mx02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:54:04] (03PS2) 10Legoktm: Archive mediawiki/php/FastStringSearch [integration/config] - 10https://gerrit.wikimedia.org/r/408781 (https://phabricator.wikimedia.org/T186684) (owner: 10MarcoAurelio) [21:54:08] (03CR) 10Legoktm: [C: 032] Archive mediawiki/php/FastStringSearch [integration/config] - 10https://gerrit.wikimedia.org/r/408781 (https://phabricator.wikimedia.org/T186684) (owner: 10MarcoAurelio) [21:55:13] (03Merged) 10jenkins-bot: Archive mediawiki/php/FastStringSearch [integration/config] - 10https://gerrit.wikimedia.org/r/408781 (https://phabricator.wikimedia.org/T186684) (owner: 10MarcoAurelio) [21:56:47] !log deploying https://gerrit.wikimedia.org/r/408781 [21:56:52] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:57:31] 10Gerrit: Provide statistics about the delinquency of patches under review - https://phabricator.wikimedia.org/T186759#3954262 (10Huji) [21:57:37] no_justification: Hauskatze: are we deleting github mirrors or using their new "archive" feature? [21:57:56] (re: archiving faststringsearch / https://phabricator.wikimedia.org/T186684 ) [21:57:57] I keep deleting them [21:58:10] Mostly because I think mirroring them /all/ was a mistake to begin with [21:58:29] I always ask Mr. Chad [21:58:34] no GitHub access [21:59:11] I deleted it [21:59:36] :) [21:59:40] We really should write a tool for archiving projects [21:59:49] I have a task for this, but not enough hours in the day [22:00:02] legoktm: Oh, status of vendor branches? [22:00:09] well, it works https://gerrit.wikimedia.org/r/#/c/408788/ [22:00:13] I was gonna jfdi yesterday but realized I don't have a clone that still has 'em ;-) [22:00:17] let me do that [22:00:19] now [22:00:20] for refs/meta/config [22:02:44] PROBLEM - Free space - all mounts on integration-slave-jessie-1004 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1004.diskspace._srv.byte_percentfree (<20.00%) [22:10:07] legoktm: Did you just do something odd? I just got a gerrit e-mail that you'd merged https://gerrit.wikimedia.org/r/#/c/350661/ though it was merged back in April? [22:10:13] James_F: yes [22:10:41] James_F: I was direct pushing stuff and gerrit seems to have taken it weirdly [22:11:23] no_justification: ok, the four branches are back https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/vendor/ [22:11:28] Ha. [22:11:49] I used the .htaccess backports as the branch positions, there were no more recent patches in gerrit for those branches [22:12:19] Is this where we renamed mediawiki/vendor to operations/wikimedia-production-vendor? [22:12:49] nope [22:13:03] Still just no_justification's hope? OK. [22:13:13] I gave up on hope [22:13:28] I HAVE NO HOPE [22:13:31] Aww. [22:13:38] * James_F hands no_justification a sackful of hope. [22:14:32] mw/vendor can live as a submodule. We just need to tweak our branching process to either A) only add wmf dependencies to wmf branches or B) Drop those dependencies when we make a REL1_* branch [22:14:41] So we don't pollute the downloads with crap [22:15:07] I think the latter is much easier [22:15:54] Yeah. The former makes it confusing [22:16:13] You'd need a place to define "extra libs to add at build time, plus patches" [22:16:22] Vs "delete a bunch of shit" [22:16:44] Could we have two composer.json files, a 'real' one and an 'extras' one? [22:18:07] Well, my idea *is* to merge the branching scripts between REL1_* and wmf/* [22:18:28] So we *will* be dealing with one config file for all branching (they'd be different "bundles") [22:18:51] But the branching script doesn't speak composer (why should it, if we have a vendor *repo*?) [22:19:58] Compare https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/release/+/master/make-wmf-branch/MakeWmfBranch.php and https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/release/+/master/make-release/branch.py [22:20:10] Mostly the same logic, branch.py just being a rewrite in python that's actually fast [22:20:20] (hint: it doesn't clone stuff just to `git branch` then push) [22:24:14] (03PS1) 10Chad: Drop .arcconfig. Was gonna move to Differential but nvm [tools/release] - 10https://gerrit.wikimedia.org/r/408939 [22:24:16] (03CR) 10Chad: [C: 032] Drop .arcconfig. Was gonna move to Differential but nvm [tools/release] - 10https://gerrit.wikimedia.org/r/408939 (owner: 10Chad) [22:25:42] (03Merged) 10jenkins-bot: Drop .arcconfig. Was gonna move to Differential but nvm [tools/release] - 10https://gerrit.wikimedia.org/r/408939 (owner: 10Chad) [22:26:21] I need to finish branch.py -- once it's done I wanna drop make-wmf-branch and move the weekly branch cut to a Jenkins job [22:26:30] (so no more asking "hey when are ya gonna cut it?" [22:26:43] :) [22:26:57] no_justification: did we establish that "#*# export-ignore" works in .gitattributes ? [22:27:05] Er, no [22:27:06] I didn't test [22:27:09] or is it interpreted as a comment? [22:27:22] ok [22:27:34] https://git-scm.com/docs/gitignore: A line starting with # serves as a comment. Put a backslash ("\") in front of the first hash for patterns that begin with a hash. [22:27:45] There's the answer, should be \# [22:28:36] does is .gitattributes parsed using the same rules? [22:28:41] I'm assuming so [22:28:49] It says that lines starting with # are ignored. [22:29:02] https://git-scm.com/docs/gitattributes [22:29:11] That is, a pattern followed by an attributes list, separated by whitespaces. Leading and trailing whitespaces are ignored. Lines that begin with # are ignored. Patterns that begin with a double quote are quoted in C style. When the pattern matches the path in question, the attributes listed on the line are given to the path. [22:29:23] Could maybe do "#*#"? [22:29:25] Idk [22:29:40] Tbh, nobody should've committed them to begin with ;-) [22:30:10] I think master also needs a patch right? [22:32:33] PROBLEM - puppet last run on contint2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [23:02:33] RECOVERY - puppet last run on contint2001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [23:53:40] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.20 deployment blockers - https://phabricator.wikimedia.org/T183959#3954543 (10demon)