[00:17:01] legoktm: Hmm. I'm not sure why https://integration.wikimedia.org/ci/job/mediawiki-phpunit-coverage-patch/205/console (of 408940) is counted as a general decrease in coverage (Title up from 17% to 25% is the main thing, surely?). [00:55:46] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer: Create and apply PHPCS and eslint rules for if else blocks with missing `else`s? - https://phabricator.wikimedia.org/T186939#3959970 (10Jdforrester-WMF) [03:21:40] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<55.56%) [04:41:28] James_F: the tool is currently marking coverage as lower if any file drops in coverage [04:42:15] Hmm. [04:42:40] Oh well. [04:43:31] I've been wondering lately if using two decimal points of precision is helpful [04:43:50] like 16.39 -> 16.33 is nothing [04:44:13] Yeah. [04:44:38] Well, rounded that’s 16.4->16.3 so it’d still count. [04:44:53] right [04:45:38] Also I’m not sure why those files went down. I added code and added tests for all of it except the deprecated functions, which I thought were exempt? [04:48:26] We'd have to look at the clover.xml files to see exactly what changed - I have plans in my head to make a HTML report that clearly shows changes in coverage [04:49:02] (also we don't even keep the clover.xml files so >.<) [04:50:45] :-) [04:53:10] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer: Create and apply PHPCS and eslint rules for if else blocks with missing `else`s? - https://phabricator.wikimedia.org/T186939#3959970 (10Legoktm) https://3v4l.org/6SthD I guess in PHP you can just put brackets around a statement that don't do anything...... [05:16:11] is it okay to create a parsoid branch in mediawiki/core on gerrit? i can push the code used for prototyping a port to that branch. [05:19:08] legoktm, James_F ^ [05:19:43] subbu: Sure, though it’s uncommon. [05:19:55] what is the recommended approach? [05:21:22] i had a few files sitting around on my laptop since last week .. figured i would push it out to gerrit. anyway, i don't have to do it now. i should probably go sleep instead :) [05:21:32] See you. :-) [05:22:05] later! :) [06:24:00] subbu: sandbox//whatever [06:24:28] subbu: https://www.mediawiki.org/wiki/Gerrit/personal_sandbox [06:56:39] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [08:39:32] 10MediaWiki-Codesniffer, 10Patch-For-Review: Avoid assignment in return statements - https://phabricator.wikimedia.org/T170332#3960198 (10Umherirrender) 05Open>03Resolved [08:46:43] Project mwext-phpunit-coverage-publish build #768: 04FAILURE in 52 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/768/ [08:51:51] Yippee, build fixed! [08:51:52] Project mwext-phpunit-coverage-publish build #769: 09FIXED in 50 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/769/ [09:16:57] 10Continuous-Integration-Infrastructure, 10Jenkins, 10Zuul: jenkins no longer starts gate-and-submit when parent is in gate-and-submit pipeline - https://phabricator.wikimedia.org/T186949#3960209 (10Umherirrender) [11:12:55] (03CR) 10Umherirrender: [C: 031] Add sniff to find tests without @covers tags (035 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/409444 (https://phabricator.wikimedia.org/T179094) (owner: 10Legoktm) [11:20:14] PROBLEM - App Server Main HTTP Response on deployment-mediawiki05 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [11:25:08] RECOVERY - App Server Main HTTP Response on deployment-mediawiki05 is OK: HTTP OK: HTTP/1.1 200 OK - 47168 bytes in 3.143 second response time [12:03:11] (03PS1) 10MarcoAurelio: zuul: archive the SemanticComments extension [integration/config] - 10https://gerrit.wikimedia.org/r/409548 (https://phabricator.wikimedia.org/T186878) [12:21:40] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3960413 (10MarcoAurelio) @demon @Legoktm So I've been testing the new access at https://gerrit.wikimedia.org/r/#/c/409556/ and while I can C2 and V2 I can't submit, so I still can't... [12:40:57] 10Beta-Cluster-Infrastructure, 10AbuseFilter, 10User-MarcoAurelio: Purge old IP data from AbuseFilter on the Beta Cluster - https://phabricator.wikimedia.org/T186870#3960423 (10MarcoAurelio) 05Open>03stalled Script can't be run until {T186928} is resolved. [15:27:44] PROBLEM - Puppet errors on deployment-redis01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:33:42] PROBLEM - Puppet errors on deployment-redis02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:39:23] PROBLEM - Puppet errors on deployment-mx is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:45:30] I guess the 'foreachwikiindblist' doesn't work for extension scripts right? [18:46:54] !log Ran mwscript extensions/AbuseFilter/maintenance/addMissingLoggingEntries.php --wiki=deploymentwiki (17 rows inserted) [18:47:01] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:49:43] !log maurelio@deployment-tin:~$ mwscript extensions/AbuseFilter/maintenance/addMissingLoggingEntries.php --wiki=zhwiki (22 rows missing inserted) [18:49:48] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:58:24] !log maurelio@deployment-tin:~$ mwscript extensions/AbuseFilter/maintenance/purgeOldLogIPData.php --wiki=eswiki (1695 rows purged - T186870) [18:58:31] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:58:31] T186870: Purge old IP data from AbuseFilter on the Beta Cluster - https://phabricator.wikimedia.org/T186870 [19:09:20] 10Beta-Cluster-Infrastructure, 10AbuseFilter, 10User-MarcoAurelio: Purge old IP data from AbuseFilter on the Beta Cluster - https://phabricator.wikimedia.org/T186870#3960746 (10MarcoAurelio) I choose beta `eswiki` since it is closed and I guess I can more safely do that there. Test plan consisted in: First:... [19:10:54] 10Beta-Cluster-Infrastructure, 10AbuseFilter, 10User-MarcoAurelio: Purge old IP data from AbuseFilter on the Beta Cluster - https://phabricator.wikimedia.org/T186870#3960747 (10MarcoAurelio) 05stalled>03Open [19:44:22] 10Beta-Cluster-Infrastructure, 10AbuseFilter, 10User-MarcoAurelio: Purge old IP data from AbuseFilter on the Beta Cluster - https://phabricator.wikimedia.org/T186870#3960778 (10Huji) @MarcoAurelio we should make sure it can be run automatically. What was the execution time on beta eswiki? [19:46:14] 10Beta-Cluster-Infrastructure, 10AbuseFilter, 10User-MarcoAurelio: Purge old IP data from AbuseFilter on the Beta Cluster - https://phabricator.wikimedia.org/T186870#3960791 (10MarcoAurelio) It took about few seconds to complete. [20:07:01] 10Beta-Cluster-Infrastructure, 10AbuseFilter, 10User-MarcoAurelio: Purge old IP data from AbuseFilter on the Beta Cluster - https://phabricator.wikimedia.org/T186870#3960856 (10Huji) That should be fine, I guess? In the production version of enwiki, there are about 8000 abuse logs every day (see graph below)... [20:21:55] (03CR) 10Umherirrender: [C: 031] zuul: archive the SemanticComments extension [integration/config] - 10https://gerrit.wikimedia.org/r/409548 (https://phabricator.wikimedia.org/T186878) (owner: 10MarcoAurelio) [20:36:43] 10Beta-Cluster-Infrastructure, 10AbuseFilter, 10User-MarcoAurelio: Purge old IP data from AbuseFilter on the Beta Cluster - https://phabricator.wikimedia.org/T186870#3960873 (10MarcoAurelio) I'm not a Wikimedia sysadmin, so I might be wrong. My idea is that for production wikis I assume that the first run sh... [20:39:01] PROBLEM - Puppet errors on deployment-videoscaler01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:39:01] PROBLEM - Puppet errors on deployment-mediawiki07 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:45:36] PROBLEM - Puppet errors on deployment-tmh01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0]