[00:16:59] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech-Sprint, 10Patch-For-Review: Deploy GlobalPreferences on beta cluster - https://phabricator.wikimedia.org/T184668#3969984 (10Niharika) [01:00:40] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<44.44%) [01:18:09] 10Beta-Cluster-Infrastructure, 10MediaWiki-extensions-LoginNotify, 10Wikimedia-Site-requests, 10Community-Tech (2015-2017): Clarify LoginNotify emails are from beta - https://phabricator.wikimedia.org/T181908#3970182 (10TBolliger) [01:45:18] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3970442 (10demon) They **are** project owners. Project ownership inherits. I guess what we need to do is give "Project and Group Creators" project ownership rights on All-Projects? B... [02:23:50] !log manually created the global_preferences table on betalabs' centralauth DB [02:23:57] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [02:25:08] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Unable to log in on Gerrit - https://phabricator.wikimedia.org/T187269#3970543 (10Paladox) 05Open>03Resolved Change was merged. [03:09:46] (03PS2) 10Legoktm: ci-src-setup: Install extension's composer dependencies too [integration/config] - 10https://gerrit.wikimedia.org/r/410005 (https://phabricator.wikimedia.org/T186315) [03:10:01] (03CR) 10Legoktm: [C: 032] ci-src-setup: Install extension's composer dependencies too [integration/config] - 10https://gerrit.wikimedia.org/r/410005 (https://phabricator.wikimedia.org/T186315) (owner: 10Legoktm) [03:11:08] (03Merged) 10jenkins-bot: ci-src-setup: Install extension's composer dependencies too [integration/config] - 10https://gerrit.wikimedia.org/r/410005 (https://phabricator.wikimedia.org/T186315) (owner: 10Legoktm) [03:12:31] !log deploying https://gerrit.wikimedia.org/r/410005 [03:12:37] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [03:19:09] (03PS1) 10Legoktm: Bump ci-src-setup to 0.2.2 [integration/config] - 10https://gerrit.wikimedia.org/r/410371 [03:28:45] oh dammit I'm really dumb [03:31:21] (03PS2) 10Legoktm: Bump ci-src-setup to 0.2.3 [integration/config] - 10https://gerrit.wikimedia.org/r/410371 [03:31:23] (03PS1) 10Legoktm: Install dev dependencies in ci-src-setup for extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410372 [03:31:44] (03CR) 10Legoktm: [C: 032] Install dev dependencies in ci-src-setup for extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410372 (owner: 10Legoktm) [03:32:51] (03Merged) 10jenkins-bot: Install dev dependencies in ci-src-setup for extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410372 (owner: 10Legoktm) [03:33:34] !log deploying https://gerrit.wikimedia.org/r/410372 [03:33:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [03:46:41] (03CR) 10Legoktm: [C: 032] Bump ci-src-setup to 0.2.3 [integration/config] - 10https://gerrit.wikimedia.org/r/410371 (owner: 10Legoktm) [03:47:14] 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-General, 10Patch-For-Review: Create composer package that contains most of the MediaWiki extension phan config instead of copy/pasting it each time - https://phabricator.wikimedia.org/T186315#3970591 (10Legoktm) The TwoColConflict PoC patch shou... [03:47:55] (03Merged) 10jenkins-bot: Bump ci-src-setup to 0.2.3 [integration/config] - 10https://gerrit.wikimedia.org/r/410371 (owner: 10Legoktm) [03:48:02] (03PS3) 10Legoktm: Add WikiEditor to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410194 (owner: 10Reedy) [03:48:09] (03CR) 10Legoktm: [C: 032] Add WikiEditor to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410194 (owner: 10Reedy) [03:49:23] (03Merged) 10jenkins-bot: Add WikiEditor to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410194 (owner: 10Reedy) [03:50:00] !log deployed https://gerrit.wikimedia.org/r/410194 [03:50:07] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [03:59:18] you're a machine lately, legoktm :) [04:00:56] greg-g: heh, I have less time in the day because of school so I get to cram it in the few hours I allot for this [04:01:16] :) I do notice the spurts [04:01:29] (03CR) 10Legoktm: [C: 032] "Passed in https://gerrit.wikimedia.org/r/#/c/410374/" [integration/config] - 10https://gerrit.wikimedia.org/r/410254 (owner: 10Legoktm) [04:02:37] (03Merged) 10jenkins-bot: Add CodeEditor to gated extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410254 (owner: 10Legoktm) [04:03:15] !log deployed https://gerrit.wikimedia.org/r/410254 [04:03:21] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:28:36] !log CodeEditor and WikiEditor are now part of shared MediaWiki gate job [04:28:41] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:49:29] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [05:14:30] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [07:00:38] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [07:00:38] PROBLEM - Free space - all mounts on integration-slave-jessie-1002 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1002.diskspace._mnt.byte_percentfree (No valid datapoints found)integration.integration-slave-jessie-1002.diskspace._srv.byte_percentfree (<10.00%) [07:16:06] PROBLEM - Host deployment-mathoid is DOWN: CRITICAL - Host Unreachable (10.68.23.236) [07:16:24] PROBLEM - Host integration-slave-jessie-1001 is DOWN: CRITICAL - Host Unreachable (10.68.16.72) [07:16:28] PROBLEM - Host deployment-sca02 is DOWN: CRITICAL - Host Unreachable (10.68.20.153) [07:17:45] PROBLEM - Host deployment-elastic05 is DOWN: CRITICAL - Host Unreachable (10.68.20.21) [07:17:59] PROBLEM - Host deployment-changeprop is DOWN: CRITICAL - Host Unreachable (10.68.16.88) [07:18:38] PROBLEM - Host integration-slave-jessie-1002 is DOWN: CRITICAL - Host Unreachable (10.68.16.199) [07:19:32] PROBLEM - Host deployment-ircd is DOWN: CRITICAL - Host Unreachable (10.68.20.19) [07:22:59] :o [07:24:55] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render repository - https://phabricator.wikimedia.org/T179552#3970792 (10phuedx) [07:25:11] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render repository - https://phabricator.wikimedia.org/T179552#3742071 (10phuedx) ^ Per T179552#3969087. [07:35:02] (03CR) 10Hashar: "Hurrah!!! Thank you to have handled the transition :)" [integration/config] - 10https://gerrit.wikimedia.org/r/410101 (owner: 10Legoktm) [08:06:44] 10Continuous-Integration-Infrastructure, 10Release Pipeline (Blubber): jenkins-slave@contint1001 not a member of docker group (CI tests for mathoid broken) - https://phabricator.wikimedia.org/T186790#3970902 (10hashar) I thought of moving the `jenkins-slave` user to admin but it seems to be merely for mortals,... [08:07:45] 10Continuous-Integration-Infrastructure, 10Release Pipeline (Blubber): jenkins-slave@contint1001 not a member of docker group (CI tests for mathoid broken) - https://phabricator.wikimedia.org/T186790#3970903 (10hashar) [08:08:48] (03PS1) 10Legoktm: Run seccheck plugin as non-voting for all bundled extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410397 (https://phabricator.wikimedia.org/T182599) [08:11:54] (03CR) 10jerkins-bot: [V: 04-1] Run seccheck plugin as non-voting for all bundled extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410397 (https://phabricator.wikimedia.org/T182599) (owner: 10Legoktm) [08:12:47] (03PS2) 10Legoktm: Run seccheck plugin as non-voting for all bundled extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410397 (https://phabricator.wikimedia.org/T182599) [08:24:00] 10Continuous-Integration-Config, 10Security-Team, 10phan-taint-check-plugin, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Make jenkins run security-check-plugin non-voting - https://phabricator.wikimedia.org/T182599#3970929 (10Legoktm) Results from running locally using the CI do... [08:24:11] (03CR) 10Legoktm: [C: 032] Run seccheck plugin as non-voting for all bundled extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410397 (https://phabricator.wikimedia.org/T182599) (owner: 10Legoktm) [08:25:32] (03Merged) 10jenkins-bot: Run seccheck plugin as non-voting for all bundled extensions [integration/config] - 10https://gerrit.wikimedia.org/r/410397 (https://phabricator.wikimedia.org/T182599) (owner: 10Legoktm) [08:26:15] !log deployed https://gerrit.wikimedia.org/r/410397 [08:26:21] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [08:34:25] 10Continuous-Integration-Config, 10Security-Team, 10phan-taint-check-plugin, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Make jenkins run security-check-plugin non-voting - https://phabricator.wikimedia.org/T182599#3970954 (10Reedy) >>! In T182599#3970929, @Legoktm wrote: > Resu... [08:34:36] 10Scap, 10ORES, 10Operations, 10Scoring-platform-team: Use external dsh group to list pooled ORES nodes - https://phabricator.wikimedia.org/T179501#3970955 (10akosiaris) And scap configuration updated in https://gerrit.wikimedia.org/r/#/c/409932/. When that one is merged this can be called done as well [08:39:23] 10Continuous-Integration-Config, 10Security-Team, 10phan-taint-check-plugin, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Make jenkins run security-check-plugin non-voting - https://phabricator.wikimedia.org/T182599#3970967 (10Legoktm) {P6693} {P6694} {P6695} Also you can just s... [09:29:35] (03CR) 10Hashar: [C: 032] docker: mvn wrapper now cd when given -f [integration/config] - 10https://gerrit.wikimedia.org/r/410348 (owner: 10Hashar) [09:30:43] (03Merged) 10jenkins-bot: docker: mvn wrapper now cd when given -f [integration/config] - 10https://gerrit.wikimedia.org/r/410348 (owner: 10Hashar) [09:41:15] !log restart Docker on all Jenkins agents [09:41:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [10:00:31] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [10:27:02] 10Gerrit, 10MediaWiki-Special-pages: Special:Upload prepending "== {{int:filedesc}} ==" twice (Commons) - https://phabricator.wikimedia.org/T187302#3971207 (10Perhelion) [10:31:17] 10Gerrit, 10Commons, 10MediaWiki-Special-pages: Special:Upload prepending "== {{int:filedesc}} ==" twice (Commons) - https://phabricator.wikimedia.org/T187302#3971222 (10Perhelion) [10:33:55] 10Gerrit, 10Commons, 10MediaWiki-Special-pages: Special:Upload prepending "== {{int:filedesc}} ==" twice (Commons) - https://phabricator.wikimedia.org/T187302#3971236 (10Perhelion) [10:35:06] 10Gerrit, 10Commons, 10MediaWiki-Special-pages, 10Multimedia, 10Multimedia-Team-Working-Board: Special:Upload prepending "== {{int:filedesc}} ==" twice (Commons) - https://phabricator.wikimedia.org/T187302#3971240 (10matthiasmullie) a:03matthiasmullie [11:11:44] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3971341 (10MarcoAurelio) I don't think that'd be okay. Okay, don't worry; I'll stick with what I was given for now. If my need increases I'll see if asking for mediawiki or mediawiki... [11:12:17] 10Gerrit: Cannot "Submit" on Gerrit, list of permissions says I should be able to - https://phabricator.wikimedia.org/T187120#3971343 (10MarcoAurelio) [11:12:19] 10Gerrit, 10Release-Engineering-Team: Access to manage Gerrit repos to @MarcoAurelio - https://phabricator.wikimedia.org/T186690#3971346 (10MarcoAurelio) [11:12:40] 10Gerrit: Cannot "Submit" on Gerrit, list of permissions says I should be able to - https://phabricator.wikimedia.org/T187120#3965191 (10MarcoAurelio) Not really dupe but the Q/A is there and the root cause is also there, so closing. [11:48:22] 10Phabricator, 10Developer-Relations (Jan-Mar-2018): Find best way to allow CoC committee to temporarily disable Phab user accounts - https://phabricator.wikimedia.org/T183116#3971432 (10Aklapper) 05Open>03Resolved The URL in T183116#3961213 got added to the page about enforcing on https://techconduct.wiki... [12:27:58] 10Phabricator: Phabricator advanced search should index task title - https://phabricator.wikimedia.org/T187238#3971524 (10Aklapper) 05Open>03Invalid It does. Use quotation marks to search for that phrase (instead of five separate words) and get https://phabricator.wikimedia.org/T89213 listed. See https://www... [12:31:38] 10Phabricator (Upstream), 10Upstream: Distinguish "mentions" from "subscribers" - https://phabricator.wikimedia.org/T150766#2795792 (10mmodell) Mail Stamps will soon be exposed in the body of messages, rather than only in the X-Phabricator-Mail-Stamps header. This should make it possible for gmail users to cre... [12:34:59] 10Phabricator: Display of subtasks in graphs for large tree is unusable as it cuts off task names or task IDs - https://phabricator.wikimedia.org/T171648#3971534 (10Aklapper) 05Open>03declined p:05Triage>03Lowest >>! In T171648#3968816, @Bugreporter wrote: > Reopen. > # "Search" button can not search i... [12:35:37] 10Deployments, 10Jouncebot: Jouncebot: `jouncebot thisweek` functionality - https://phabricator.wikimedia.org/T187229#3971537 (10Aklapper) [12:38:16] (03PS4) 10Hashar: Migrate xgboost MjoLniR maven jobs to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/410260 [12:38:18] (03PS1) 10Hashar: docker: containers for mjolnir/xgboost [integration/config] - 10https://gerrit.wikimedia.org/r/410436 [12:38:49] (03PS5) 10Hashar: Migrate xgboost MjoLniR maven jobs to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/410260 [12:39:06] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971548 (10mmodell) Here is the one that I expect to be slow: https://secure.phabricator.com/source/phabricator/browse/master/resources/sql/autopa... [12:39:40] (03CR) 10Hashar: [C: 032] docker: containers for mjolnir/xgboost [integration/config] - 10https://gerrit.wikimedia.org/r/410436 (owner: 10Hashar) [12:40:53] (03Merged) 10jenkins-bot: docker: containers for mjolnir/xgboost [integration/config] - 10https://gerrit.wikimedia.org/r/410436 (owner: 10Hashar) [12:44:52] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971553 (10jcrespo) I do not see any schema change, only updates using ids, is there an actual schema change done before that? https://secure.phab... [12:46:01] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971554 (10Marostegui) >>! In T187143#3971548, @mmodell wrote: > Here is the one that I expect to be slow: https://secure.phabricator.com/source/p... [12:47:03] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971555 (10mmodell) https://secure.phabricator.com/source/phabricator/browse/master/resources/sql/autopatches/20180208.maniphest.01.close.sql [12:48:42] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971556 (10mmodell) The slow one is backfilling the data, the alter table is in a separate migration which should be much quicker than the populat... [12:49:05] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971557 (10jcrespo) Is it easy to trick phabricator into skipping migrations?- we could do that safely and online, and it seems backwards compatible. [12:49:20] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971558 (10Marostegui) >>! In T187143#3971555, @mmodell wrote: > https://secure.phabricator.com/source/phabricator/browse/master/resources/sql/aut... [12:51:31] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971560 (10mmodell) @jcrespo: it's possible but I'd have to hack around some detection scheme, phabricator normally refuses to even serve pages wh... [12:53:10] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971567 (10mmodell) @marostegui: that's one of the largest `maniphest_task` tables in teh world, despite it's size in raw bytes ;) I'm surprised... [13:00:25] (03CR) 10Hashar: [C: 032] "mjolnir passed : https://integration.wikimedia.org/ci/job/search-mjolnir-maven-java8-docker/6/" [integration/config] - 10https://gerrit.wikimedia.org/r/410260 (owner: 10Hashar) [13:02:18] (03Merged) 10jenkins-bot: Migrate xgboost MjoLniR maven jobs to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/410260 (owner: 10Hashar) [13:31:34] !log maurelio@deployment-tin:~$ foreachwikiindblist all-labs.dblist extensions/AbuseFilter/maintenance/purgeOldLogIPData.php > purge_abusefilter_20180214.log 2>&1 [13:31:39] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971656 (10jcrespo) The alter is done on the slave already- try to see if you can cleanly skip that migration- if there are other alters backwards... [13:31:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:32:47] 10Phabricator (2018-02-xx), 10DBA, 10Release: Upcoming phabricator upgrade requires unusually long database migrations - https://phabricator.wikimedia.org/T187143#3971668 (10jcrespo) The switchover will probably require your help restarting apache/phab at the time. [14:16:31] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 80.00% of data above the critical threshold [10.0] [14:41:32] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [10.0] [14:44:43] 10Gerrit, 10BlueSpice, 10GitHub-Mirrors, 10Repository-Admins: extension-BlueSpiceMenues is empty - https://phabricator.wikimedia.org/T185662#3971891 (10MarcoAurelio) @SamanthaNguyen Any idea about this repo? Can it go? [14:48:44] Yippee, build fixed! [14:48:45] Project selenium-Wikibase-chrome » chrome,beta,Linux,DebianJessie && contintLabsSlave build #107: 09FIXED in 39 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase-chrome/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=DebianJessie%20&&%20contintLabsSlave/107/ [15:04:28] 10Phabricator: Display of subtasks in graphs for large tree is unusable as it cuts off task names or task IDs - https://phabricator.wikimedia.org/T171648#3971956 (10Bugreporter) >>! In T171648#3971534, @Aklapper wrote: >>>! In T171648#3968816, @Bugreporter wrote: >> Reopen. >> # "Search" button can not search... [15:27:43] PROBLEM - Puppet errors on deployment-redis01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:32:08] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, 10User-Elukey: Apache on phab1001 is gradually leaking worker processes which are stuck in "Gracefully finishing" state - https://phabricator.wikimedia.org/T182832#3972056 (10elukey) >>! In T182832#3968786, @Dzahn wrote... [15:33:42] PROBLEM - Puppet errors on deployment-redis02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:41:32] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [15:51:04] RECOVERY - Host integration-slave-jessie-1002 is UP: PING OK - Packet loss = 0%, RTA = 0.46 ms [15:51:06] RECOVERY - Host integration-slave-jessie-1001 is UP: PING OK - Packet loss = 0%, RTA = 1.13 ms [16:14:12] Project mwext-phpunit-coverage-publish build #920: 04FAILURE in 10 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/920/ [16:14:20] Yippee, build fixed! [16:14:20] Project mwext-phpunit-coverage-publish build #921: 09FIXED in 4 min 16 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/921/ [16:14:21] (03CR) 10Jforrester: [C: 031] Add sniff to find tests without @covers tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/409444 (https://phabricator.wikimedia.org/T179094) (owner: 10Legoktm) [16:14:23] RECOVERY - Host deployment-mathoid is UP: PING OK - Packet loss = 0%, RTA = 0.75 ms [16:14:23] RECOVERY - Host deployment-elastic05 is UP: PING OK - Packet loss = 0%, RTA = 1.19 ms [16:14:30] RECOVERY - Host deployment-changeprop is UP: PING OK - Packet loss = 0%, RTA = 7.06 ms [16:14:43] RECOVERY - Host deployment-sca02 is UP: PING OK - Packet loss = 0%, RTA = 7.48 ms [16:15:58] RECOVERY - Host deployment-ircd is UP: PING OK - Packet loss = 0%, RTA = 4.75 ms [16:16:42] PROBLEM - Free space - all mounts on integration-slave-jessie-1002 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1002.diskspace._mnt.byte_percentfree (No valid datapoints found)integration.integration-slave-jessie-1002.diskspace._srv.byte_percentfree (<10.00%) [16:17:47] RECOVERY - SSH on deployment-sca02 is OK: SSH OK - OpenSSH_6.7p1 Debian-5+deb8u3 (protocol 2.0) [16:22:31] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [16:28:55] 10Scap, 10Operations: Install git-lfs client (at least on scap targets & masters) - https://phabricator.wikimedia.org/T180628#3972303 (10Halfak) Ping. :) [16:40:29] 10Phabricator (Upstream), 10Upstream: Display of subtasks in graphs for large tree is unusable as it cuts off task names or task IDs - https://phabricator.wikimedia.org/T171648#3972326 (10Aklapper) 05declined>03Open >>! In T171648#3971956, @Bugreporter wrote: > Note the task graph of T144272 is so wide tha... [16:42:20] 10Phabricator (Upstream), 10Upstream: Display of subtasks in graphs for large tree is unusable as it cuts off task names or task IDs - https://phabricator.wikimedia.org/T171648#3472197 (10greg) (That looks like it should be a project/tag, not a tracking task, right?) [16:43:13] 10Phabricator (Upstream), 10Upstream: Display of subtasks in graphs for large tree is unusable as it cuts off task names or task IDs - https://phabricator.wikimedia.org/T171648#3972361 (10Aklapper) @greg: That's what Phabricator upstream developers would likely tell us, yes. [16:52:30] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [10.0] [16:57:16] andre__: that's my current thinking now too :) [16:58:50] Project selenium-Wikibase-chrome » chrome,beta,Linux,DebianJessie && contintLabsSlave build #109: 04FAILURE in 37 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase-chrome/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=DebianJessie%20&&%20contintLabsSlave/109/ [16:58:53] 10Gerrit: PolyGerrit has wrong URLs in links in "Your" menu - https://phabricator.wikimedia.org/T187347#3972513 (10Smalyshev) [17:00:03] 10Gerrit: PolyGerrit has wrong URLs in links in "Your" menu - https://phabricator.wikimedia.org/T187347#3972513 (10Paladox) Hi, this is a know issue. If you go to gwtui and then go to settings and go to https://gerrit-review.googlesource.com/#/settings/preferences and click reset that should fix it for now. Whe... [17:04:16] 10Gerrit: PolyGerrit has wrong URLs in links in "Your" menu - https://phabricator.wikimedia.org/T187347#3972556 (10Smalyshev) @Paladox Did you mean to https://gerrit.wikimedia.org/r/settings or to actual Google site? Also, I do not see any "reset" in either that I could click. [17:05:09] 10Gerrit: PolyGerrit has wrong URLs in links in "Your" menu - https://phabricator.wikimedia.org/T187347#3972575 (10Paladox) Oh whoops, i meant https://gerrit.wikimedia.org/r/#/settings/preferences . [17:05:50] PROBLEM - Free space - all mounts on deployment-mediawiki04 is CRITICAL: CRITICAL: deployment-prep.deployment-mediawiki04.diskspace.root.byte_percentfree (<11.11%) [17:06:06] 10Gerrit: PolyGerrit has wrong URLs in links in "Your" menu - https://phabricator.wikimedia.org/T187347#3972587 (10Smalyshev) Ah, ok, missed the old UI part. Yes, that seems to fix it. [17:33:01] (03CR) 10Jforrester: [C: 032] Be aware of extension MediaWiki compatibility [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398625 (https://phabricator.wikimedia.org/T175465) (owner: 10Legoktm) [17:33:06] (03CR) 10Jforrester: [C: 032] Add sniff to find tests without @covers tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/409444 (https://phabricator.wikimedia.org/T179094) (owner: 10Legoktm) [17:35:09] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, 10User-Elukey: Apache on phab1001 is gradually leaking worker processes which are stuck in "Gracefully finishing" state - https://phabricator.wikimedia.org/T182832#3972736 (10elukey) [17:35:39] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, 10User-Elukey: Apache on phab1001 is gradually leaking worker processes which are stuck in "Gracefully finishing" state - https://phabricator.wikimedia.org/T182832#3836191 (10elukey) [17:36:31] (03Merged) 10jenkins-bot: Be aware of extension MediaWiki compatibility [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398625 (https://phabricator.wikimedia.org/T175465) (owner: 10Legoktm) [17:36:36] (03Merged) 10jenkins-bot: Add sniff to find tests without @covers tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/409444 (https://phabricator.wikimedia.org/T179094) (owner: 10Legoktm) [17:37:35] !log Upgraded Jenkins to 2.89.4 [17:37:40] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:37:51] !log Manually deleting some Nodepool instances following Jenkins restart [17:37:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [17:40:04] mwext-testextension-hhvm-jessie always takes a lot of time to start [17:41:34] HausAFKatze: yeah the jobs having a '-jessie' suffix are run on a small pool of virtual machines [17:41:47] so usually they are idling/waiting for a virtual machine to be made available [17:43:00] hashar: pardon my ignorance but could you maybe enlarge that pool a bit? Lots of extensions still runs those tests :) [17:44:28] (03CR) 10jenkins-bot: Be aware of extension MediaWiki compatibility [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/398625 (https://phabricator.wikimedia.org/T175465) (owner: 10Legoktm) [17:45:30] (03CR) 10jenkins-bot: Add sniff to find tests without @covers tags [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/409444 (https://phabricator.wikimedia.org/T179094) (owner: 10Legoktm) [17:47:47] HausAFKatze: yeah we are aware. But no the pool cant be made larger [17:48:04] HausAFKatze: anyway I will migrate those jobs to Docker containers eventually [17:48:19] ok merci [17:48:21] and that smallish pool will be removed entirely at some point [17:50:38] PROBLEM - Host integration-slave-k8s-1003 is DOWN: CRITICAL - Host Unreachable (10.68.19.238) [18:25:14] Hi... Is anyone on this morning's swat deploy? [18:25:25] thx in advance :) [18:27:12] greg-g ^ ? [18:30:13] Hmm, why does extensions/Kartographer not have any wmf/* branches? [18:31:20] It's in the make-wmf-branch config, I don't see what's special about it [18:32:07] It's 30 minutes into the SWAT deploy slot but no one assigned on the Deployments schedule seems available..... [18:33:26] RoanKattouw: and doesn't them generate automatically? [18:33:37] Well they're not there [18:33:57] Hmm wait [18:33:58] They are https://github.com/wikimedia/mediawiki-extensions-Kartographer/branches [18:34:03] What is wrong with my setup then :/ [18:34:42] I can do git fetch origin wmf/1.31.0-wmf.21 and it'll fetch it [18:34:54] But it doesn't automatically fetch those branches like it does for my other git clones [18:35:13] git pull ? [18:35:19] fetch & merge [18:35:41] can ruin any work though [18:35:42] Maybe Vagrant changed and cloned this repo with --single-branch [18:36:10] RoanKattouw: multiple remotes? did you try git fetch --all or git pull --all ? [18:36:18] Yup, I see it [18:36:33] My situation is consistent with --single-branch: https://stackoverflow.com/questions/17714159/how-do-i-undo-a-single-branch-clone [18:37:48] wow that's an interesting situation [18:37:51] And the instructions there fixed it [18:37:58] Vagrant must have changed how it clones new repos [18:38:36] hmmm [18:38:43] RoanKattouw: whom should I ping about no one around or apparently available for a swat deploy this morning? apologies for the bother [18:39:05] They rescheduled the SWAT to be during teams' standups as well as Scrum of Scrums [18:39:11] So I'm not that surprised nobody's available [18:39:22] PROBLEM - Puppet errors on deployment-mx is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:39:32] Sorry for ignoring your ping but I am also in meetings [18:39:42] hummm yeah no worries of course, thx [18:41:32] thcipriani: if you have time today to review this patch, that'd be awesome! there's not a rush on getting this in but we're trying to wrap up some outstanding tasks. https://gerrit.wikimedia.org/r/c/409115/ [18:43:59] I would offer to do it even, if that were a legit procedure, but I've not deployed stuff to prod myself a whole lot, kinda scary... at least, I'd have to re-read all the doc carefully and find someone more knowledgeable to supervise.... [18:50:52] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Blubber should support python/tox - https://phabricator.wikimedia.org/T186545#3973013 (10dduvall) [19:00:31] 10Diffusion, 10Gerrit, 10Phabricator: Delete all Phabricator git repos that haven't been referenced / aren't used. - https://phabricator.wikimedia.org/T187149#3973042 (10Jayprakash12345) [19:07:25] (03CR) 10MarcoAurelio: "@hashar I'm archiving that one too in T187310; feel free to merge or wait until I submit the patch for the other one. I'll do as you instr" [integration/config] - 10https://gerrit.wikimedia.org/r/409851 (https://phabricator.wikimedia.org/T186516) (owner: 10MarcoAurelio) [19:13:28] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [19:14:23] (03PS1) 10Legoktm: Use SPDX 3.0 license identifier [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/410534 (https://phabricator.wikimedia.org/T183858) [19:15:06] (03PS2) 10Legoktm: Use SPDX 3.0 license identifier [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/410534 (https://phabricator.wikimedia.org/T186481) [19:15:47] 10Continuous-Integration-Infrastructure, 10Composer, 10Patch-For-Review: Upgrade integration/composer to 1.4.3 stable - https://phabricator.wikimedia.org/T125343#3973086 (10Legoktm) [19:15:49] 10MediaWiki-Codesniffer, 10Patch-For-Review: License "GPL-2.0+" is a deprecated SPDX license identifier, use "GPL-2.0-or-later" instead - https://phabricator.wikimedia.org/T186481#3973085 (10Legoktm) [19:16:20] 10MediaWiki-Codesniffer, 10Patch-For-Review: License "GPL-2.0+" is a deprecated SPDX license identifier, use "GPL-2.0-or-later" instead - https://phabricator.wikimedia.org/T186481#3945182 (10Legoktm) a:03Legoktm We can do this regardless of updating integration/composer, since it'll emit a non-failing warnin... [19:17:47] (03CR) 10Jforrester: [C: 032] Use SPDX 3.0 license identifier [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/410534 (https://phabricator.wikimedia.org/T186481) (owner: 10Legoktm) [19:18:12] 10MediaWiki-Codesniffer: PHPCS sometimes reports incorrect line numbers - https://phabricator.wikimedia.org/T186333#3973095 (10Legoktm) 05Open>03Invalid I don't really have any great ideas, including the line in the output seems like an interesting idea, but that would need to be implemented by upstream PHPCS. [19:18:37] 10MediaWiki-Codesniffer, 10Patch-For-Review: Be aware of extension's minimum MediaWiki version supported - https://phabricator.wikimedia.org/T175465#3973097 (10Umherirrender) 05Open>03Resolved p:05Triage>03Normal [19:18:40] (03Merged) 10jenkins-bot: Use SPDX 3.0 license identifier [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/410534 (https://phabricator.wikimedia.org/T186481) (owner: 10Legoktm) [19:19:20] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): Add rule to require use of @covers in PHPUnit tests - https://phabricator.wikimedia.org/T179094#3973101 (10Umherirrender) 05Open>03Resolved p:05Triage>03Normal [19:22:10] 10MediaWiki-Codesniffer, 10Patch-For-Review: License "GPL-2.0+" is a deprecated SPDX license identifier, use "GPL-2.0-or-later" instead - https://phabricator.wikimedia.org/T186481#3973116 (10Legoktm) 05Open>03Resolved [19:25:11] 10Diffusion, 10MediaWiki-Codesniffer, 10Documentation: MediaWiki-Codesniffer README looks broken in Diffusion - https://phabricator.wikimedia.org/T128705#3973124 (10Legoktm) 05Open>03declined Looks great in Gitiles: https://gerrit.wikimedia.org/g/mediawiki/tools/codesniffer [19:25:33] (03CR) 10jenkins-bot: Use SPDX 3.0 license identifier [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/410534 (https://phabricator.wikimedia.org/T186481) (owner: 10Legoktm) [19:25:50] (03PS1) 10Jforrester: Release v16.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/410535 [19:26:13] legoktm: ^^ Unless you have more things to push out? [19:26:50] no_justification lol as soon as someone reported https://phabricator.wikimedia.org/T187347 someone from the eclipse foundation filled one [19:26:51] heh [19:27:03] Anyways i know excatly whats wrong [19:27:08] but have no easy fixes [19:27:27] James_F: probably not, but I'm going through the board in case there's anything easy/important [19:27:43] Cool. [19:29:18] 10Gerrit: PolyGerrit has wrong URLs in links in "Your" menu - https://phabricator.wikimedia.org/T187347#3973144 (10Paladox) Someone reported it upstream here https://bugs.chromium.org/p/gerrit/issues/detail?id=8373 [19:30:09] * paladox looks at source code to see if he can fix ^^ [19:32:18] no_justification fyi anyone seeing 404 errors in the console log when using polygerrit (https://gerrit.wikimedia.org/plugins/lfs/static/lfs-project-info.js), that's expected. Should be fixed in 2.15+. [19:32:41] gr-menu-editor [19:33:07] (03CR) 10Umherirrender: Release v16.0.0 (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/410535 (owner: 10Jforrester) [19:37:32] (03PS1) 10EBernhardson: Add maven support to tox-pyspark docker image [integration/config] - 10https://gerrit.wikimedia.org/r/410537 [19:39:00] (03PS2) 10EBernhardson: Add maven support to tox-pyspark docker image [integration/config] - 10https://gerrit.wikimedia.org/r/410537 [19:39:41] (03CR) 10EBernhardson: "Built the docker image locally and tested against related patch, works as expected. The maven configuration provided puts jars downloaded " [integration/config] - 10https://gerrit.wikimedia.org/r/410537 (owner: 10EBernhardson) [19:42:08] (03CR) 10Jforrester: Release v16.0.0 (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/410535 (owner: 10Jforrester) [19:44:33] (03PS2) 10Jforrester: Release v16.0.0 [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/410535 [19:50:32] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [10.0] [20:00:36] (03CR) 10Umherirrender: Release v16.0.0 (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/410535 (owner: 10Jforrester) [20:05:50] ebernhardson: good morning. For search/MjoLniR maybe we could have a single job that first runs maven verify then run tox using the produced jar? [20:06:22] no_justification lol was already fixed upstream in 2.15. So i am backporting the fix. (still need to fix base url to be added) [20:06:35] 10Gerrit: PolyGerrit has wrong URLs in links in "Your" menu - https://phabricator.wikimedia.org/T187347#3973374 (10Paladox) Partially fixed in https://gerrit-review.googlesource.com/#/c/gerrit/+/159532/ and https://gerrit-review.googlesource.com/#/c/gerrit/+/159650/ [20:09:44] hashar: hmm, probably could if we want a custom container. Not sure how jenkins integration with test output would work but it's not a big dea [20:11:01] ebernhardson: the python suite could act on some env variable like MJOLNIR_JAR [20:11:17] so at first one run maven, then lookup the file name under /target/ and pass it to the tox job [20:11:22] paladox: Maybe we should just upgrade ;-) [20:11:26] or well hmm the python test suite could directly look it up [20:11:27] (jk, I ain't got time for that right now, heh) [20:11:43] no_justification heh, we wont be able to upgrade, no stable release yet too :) [20:11:54] i am supprised how long it's taking for them to push it out [20:12:00] but i know it's related to notedb [20:12:25] notedb today got fixed to use less heap when migrating from reviewdb to notedb [20:12:37] hashar: right now i simply hardcoded a relative path from the test files to the maven default output dir, but an env variable could work. I'll have to see what i need to do to merge the maven job with this [20:12:57] no_justification there's no fix for the base url problem anyways [20:13:01] ebernhardson: but we can keep them separate if that is easier :] [20:13:05] True true [20:13:05] it's because up stream doint test with base urls [20:13:11] it was me who added this :) [20:13:16] hashar: well, the current is only easier because i thought of it first and already tested it :) [20:13:16] Hmmmmmmmmmmmm [20:13:26] though wyatta did add soy, which made what i did possible [20:14:17] Hmmmmmm. Actually.... [20:14:21] ebernhardson: so I guess I can deploy the new tox-pyspark image AND bump the container version in the jenkins job :) [20:14:37] no_justification i guess what i could do is this [20:14:46] hashar: ahh, of course i forgot to bump the container version in the job too [20:14:46] ebernhardson: also the maven job running for mjolnir is now a docker container :] [20:14:51] if (linkObj.url.indexOf(this.baseUrl()) === 0) { [20:15:19] hashar: sweet. Now when do i get my fancy multi-wiki docker image with sister wikis, commons, etc all setup? ;P [20:16:21] ebernhardson: 3 years? :] That will take a bit of a time but yeah I guess we could replac emediawiki/vagrant with some docker magic thing [20:16:58] hashar: i actually wanted it for integration testing, but local dev would work too i suppose [20:17:41] (03PS3) 10Hashar: Add maven support to tox-pyspark docker image [integration/config] - 10https://gerrit.wikimedia.org/r/410537 (owner: 10EBernhardson) [20:18:30] (03CR) 10Hashar: [C: 032] "That is "simply" adding maven so hardly an issue for the current tox run. I have amended your commit to bump the container version in the" [integration/config] - 10https://gerrit.wikimedia.org/r/410537 (owner: 10EBernhardson) [20:18:49] hashar: thanks! [20:18:49] no_justification upstream abstracted most things and put it into gr-navigation heh. [20:18:52] gr-router [20:19:00] ebernhardson: we had that discussion during the releng offsite. And I think dev and CI environements are closely related [20:19:17] so whatever we come up with for CI would probably be useful for developers hopefully [20:20:38] (03Merged) 10jenkins-bot: Add maven support to tox-pyspark docker image [integration/config] - 10https://gerrit.wikimedia.org/r/410537 (owner: 10EBernhardson) [20:21:36] hashar: btw is there an easy way to build just one image with docker-pkg? I ended up deleting all the directories in dockerfiles/ i didn't want it to build :) [20:21:46] (03PS1) 10Legoktm: Run tox for labs/codesearch [integration/config] - 10https://gerrit.wikimedia.org/r/410554 [20:21:49] !log building docker-registry.wikimedia.org/releng/tox-pyspark:0.1.1 [20:21:52] ebernhardson: nop :( [20:21:53] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:22:08] (03CR) 10Legoktm: [C: 032] Run tox for labs/codesearch [integration/config] - 10https://gerrit.wikimedia.org/r/410554 (owner: 10Legoktm) [20:22:12] ebernhardson: I just build everything on my local machine so that when I invoke docker-pkg there is only the image I have touched that get build [20:22:20] but joe filled a task to add filtering [20:22:21] hashar: i suppose that works :) [20:22:31] or [20:22:35] you could docker pull all of them [20:23:10] ebernhardson: you basically have to suck it up once and then it'll only build the new images whenever you want to mess with something [20:23:13] (03Merged) 10jenkins-bot: Run tox for labs/codesearch [integration/config] - 10https://gerrit.wikimedia.org/r/410554 (owner: 10Legoktm) [20:23:47] !log deploying https://gerrit.wikimedia.org/r/410554 [20:23:53] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:24:02] no_justification ah i have easy reproduction steps now. [20:24:15] if someone edits the menu in polygerrit, it breaks the urls. [20:30:09] ebernhardson: guess you can now rebase the tox jvm-skiptest change https://gerrit.wikimedia.org/r/#/c/410403/ :] [20:30:25] your container patch is deployed so the tox job should have maven now [20:39:00] PROBLEM - Puppet errors on deployment-mediawiki07 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:49:52] no_justification i see you opened up plugins for everyone to view :) [20:53:12] paladox: Yeah, I don't see a reason folks can't see them :) [20:53:17] Plus, some link to nice docs and such [20:53:17] :) [20:53:53] hashar: success! thanks a bunch [20:54:52] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T183960#3973525 (10mmodell) [20:56:15] no_justification "Once this change is merged, the rendered markdown can be linked to in the official GWTUI deprecation announcement." https://gerrit-review.googlesource.com/#/c/gerrit/+/159330/ [20:56:16] heh [20:56:38] apparemtly there's going to be an offical gwtui deprecation annoucement. [20:56:46] but there's already a change to remove gwtui [20:58:05] "Kasper's original intention here was an announcement to googlesource.com users to motivate them to stop using the old UI." [21:00:13] yay the redesgned dashboard https://gerrit-review.googlesource.com/#/c/gerrit/+/159670/ [21:00:26] * paladox hopes this one won't look old [21:01:57] 10Diffusion, 10Gerrit, 10Phabricator: Delete all Phabricator git repos that haven't been referenced / aren't used. - https://phabricator.wikimedia.org/T187149#3965942 (10mmodell) I disagree. I still think all repos should be sync'd to phabricator. [21:12:58] 10Diffusion, 10Gerrit, 10Phabricator: Delete all Phabricator git repos that haven't been referenced / aren't used. - https://phabricator.wikimedia.org/T187149#3973616 (10mmodell) Phabricator doesn't only exist as an accessory for gerrit. Having repositories in Phabricator, for one thing, provides a mirror we... [21:28:24] gerrit question - when I go git review -d, it downloads the patch into branch review/smalyshev/topic. Is there any way to make it use just "topic"? [21:31:31] SMalyshev: nop that is hardcoded in git-review [21:31:42] :( sad [21:32:40] maybe I should make a patch to git-review [21:33:06] SMalyshev: https://github.com/openstack-infra/git-review/blob/master/git_review/cmd.py#L1230-L1235 [21:33:23] that is the method fetch_review [21:33:31] yeah I see thanks! [21:34:14] SMalyshev: that could be a configurable option of some sort. I cant remember off hand how git-review handles its configuration but I think it is based on git config [21:34:29] I'd be fine with command-line option even [21:34:55] it would look at .gitconfig in the local repo / home dir [21:34:57] e.g. git review -d blah -b topic (or just -b which auto-selects topic from topic name) [21:35:29] look up for a [gitreview] section. so theroically one can add support for a download_branch_pattern = '%(topic)s' [21:35:39] or a switch yeah :] [21:35:43] yeah that would be nice too [21:36:03] cool, I think I have the idea now how it can be fixed :) [21:36:23] but what I am really missing is: if I have dependent changes A -> B -> C all under topic "foobar" [21:36:34] I would like to be able to say: give me "foobar" [21:36:44] which would get me C (and thus B and A ) [21:36:53] ie get the latest change of a chain of changes [21:36:55] I don't even go that far :) at least not having two branches for each patch would be nice :) [21:37:08] but I guess what I am looking for is a feature branch [21:38:12] once upon a time I was just fetching all of refs/changes/* in my local workspace [21:38:33] so I could then just: git checkout refs/changes/45/12345/2 (change 12345 patchset 2) [21:38:43] but that is too many refs [21:38:59] yeah that'd be nice if there was a good way to manage multi-commit feature branches [21:39:35] also for git-review, the way I have set it up is to clone their repo [21:39:48] then I installed it in development mode: pip install -e . [21:40:07] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render repository - https://phabricator.wikimedia.org/T179552#3742077 (10Niedzielski) I'm shuffling this over to blocked on our board since it needs releng review... [21:40:42] this way the module is pointing to the cloned repo, then I can just hack away and "git-review" is reflecting the changes immediately [21:41:01] or: [21:41:05] tox -e venv -- git-review [21:41:21] (which setup a virtualenv with all the dependencies, and run the command after -- in that venv) [21:41:41] !log Deployed to beta cluster: [mobileapps/deploy@9bad612]: Update mobileapps to f23519f [21:41:48] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:37:44] (03CR) 10Hashar: Update chromium-render to use Debian Chromium (032 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/409115 (https://phabricator.wikimedia.org/T179552) (owner: 10Niedzielski) [22:38:24] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render repository - https://phabricator.wikimedia.org/T179552#3973869 (10hashar) I have done a bit of review on the change https://gerrit.wikimedia.org/r/#/c/4091... [22:54:29] ebernhardson: that MJolnir patch, I have no idea why it fails [22:54:44] ebernhardson: I commented on PS7 just before you sent your new patch :) [22:56:21] OH MAN [22:56:25] hashar: i think the failure is unrelated to this stuff, i just restructured recent work which i think will allow it all to work (the same failures were happening before this update and prompted me to make it work direct) [22:56:53] I also found you are responsible for xgboost :D [22:57:06] hashar: :) [22:57:14] I tried to migrate its maven job to a docker container only to have it fails horribly in some mysterious way [22:57:44] my last comment on https://gerrit.wikimedia.org/r/#/c/410441/ highlights the difference between the regular job and the docker one bah [22:58:16] hashar: so for extra fun, there are exception traces in the xgboost output that are supposed to be there (testing failure cases), and ones that shouldn't. will take a minute to figure out which are which [22:58:29] yeah I noticed that [22:58:39] seems some settings are not properly applied [22:59:18] there are probably a bunch of logs those maven jobs should attach to the build report [23:00:13] wow that really does fail everything though. hmm [23:00:46] yeah the first failures I had were due to lack of some packages such as cmake/g++ etc [23:01:01] eventually I reached a state that looked almost good :] [23:01:55] for xgboost that uses a dedicated container in dockerfiles/java8-xgboost [23:02:12] but hey. One problem at a time :] [23:03:35] i'm going to have to ponder this one, nothing obvious :( It's clear at least that the c++ part is building fine, and the jvm integration with c++ tests fine, but the spark integration layer (which is just a normal scala app, no fancyness) is failing for unknown reasons :S [23:03:57] is that using mjolnir ? [23:04:10] hashar: other way around, mjolnir uses xgboost [23:04:19] xgboost is upstream code, but we had to make some small modifications [23:04:55] so I guess mjolnir is the most important part :] [23:06:09] hashar: yea, that's all our magic :) [23:10:37] ebernhardson: most probably the Docker image is missing a debian package of some sort. I will figure it out eventually :) [23:11:16] hashar: maybe, but it seems odd to me because this step is plain scala/jvm stuff, so maven should have magic'd all those dependencies into place [23:12:32] or spark cant starts because of a missing lib [23:12:48] it is not like I have any idea about what spark mjolnir or scala are :) [23:12:58] I am just shouting random ideas [23:13:08] will try tomorrow with more debian packages installed and see what happens [23:14:18] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Blubber should implement a better file permissions convention - https://phabricator.wikimedia.org/T187372#3973412 (10dduvall) [23:14:46] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Blubber should implement a better file permissions convention - https://phabricator.wikimedia.org/T187372#3973412 (10dduvall) p:05Triage>03High a:03dduvall [23:16:02] Cause: java.lang.RuntimeException: failed to resolve resource /agaricus.txt.train [23:16:02] :!!! [23:19:25] hashar: hmm, that shuld have resolved from the test resources dir. hmm [23:19:46] only happens when I do -rf :xgboost4j-spark [23:19:55] what does -rf do? :) [23:20:08] I dont know? :) [23:20:13] lol [23:20:15] maven hints at it on test failure [23:20:35] I guess it is to only run a specific phase / goal / reactor target / test whatever the name [23:20:39] -rf is apparently resume from, so it would skip the earlier tests [23:20:41] one sure thing: it is faster [23:20:46] AH [23:20:51] see I know nothing about maven/java :((( [23:21:34] i'll spin up the instance locally and see if anything makes sense [23:22:02] maybe there are some traces/log floating around somewhere [23:32:45] ebernhardson: MjoLniR seems happy now well done ! :] [23:33:03] I am heading to bed, thanks for the tests improvement [23:33:09] at least one down, g'night! [23:36:58] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure: jenkins-debian-glue is failing for unstable - https://phabricator.wikimedia.org/T187405#3974050 (10Legoktm) [23:40:10] SMalyshev thanks for the feedback, i've forward it upstream onto goolge groups. [23:40:17] https://groups.google.com/forum/#!forum/repo-discuss [23:40:23] https://groups.google.com/forum/#!topic/repo-discuss/yX8jYkdXsjI [23:40:33] SMalyshev inline editing has only recently been added. [23:41:01] sure, I hope it will be helpful [23:41:07] :) [23:41:29] I may file tasks for all this on there bug tracker if i doin't here anything on that thread. [23:42:25] SMalyshev also the reply button colour was changed [23:43:07] SMalyshev https://phabricator.wikimedia.org/F13752165 [23:43:31] great! [23:43:43] http://gerrit-test.wmflabs.org/gerrit/?polygerrit=1 [23:44:02] SMalyshev this is gerrit 2.15 ^^ [23:54:41] nice! [23:55:11] SMalyshev 2.15 has had alot of changes since 2.15 [23:55:21] 2.15 = 2.14 [23:55:35] 2.15 has had alot of changes since 2.14