[00:08:43] Hm.. gerrit tells me on most patches I view "Updated | in the future" [00:08:58] I distinctly drafting the patch last week though, not in the future [00:10:50] Krinkle: maybe you are a time traveler. Either a Time Lord or something like Quantum Leap [00:11:14] I like the idea of Krinkle as a Time Lord [00:13:09] Darn, I should've worn my Tardis/DeLorean shirt today! [00:13:30] I got it last year for my birthday https://i.imgur.com/1JAkf3e.jpg [00:38:39] PROBLEM - Free space - all mounts on integration-slave-jessie-1003 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1003.diskspace._srv.byte_percentfree (<44.44%) [00:38:47] legoktm ^^ [00:38:49] 1003 [01:17:39] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<22.22%) [01:42:25] 10Gerrit, 10Upstream: PolyGerrit has wrong URLs in links in "Your" menu - https://phabricator.wikimedia.org/T187347#3977588 (10Paladox) [04:52:31] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [10.0] [04:58:40] PROBLEM - Free space - all mounts on integration-slave-jessie-1003 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1003.diskspace._srv.byte_percentfree (<55.56%) [05:07:30] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [06:13:57] 10Phabricator (2018-02-15), 10Upstream: Distinguish "mentions" from "subscribers" - https://phabricator.wikimedia.org/T150766#3977670 (10Quiddity) I.e. for gmail, do this in phabricator: {F13792319} and create a new filter in gmail, using `"mention(@YOURNAME)"` {F13792320} which will result in (screenshot fr... [07:07:38] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [07:21:36] !log legoktm@integration-slave-jessie-1003:/srv/jenkins-workspace/workspace$ sudo rm -rf * [07:21:40] paladox: ^ [07:21:42] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [07:33:41] RECOVERY - Free space - all mounts on integration-slave-jessie-1003 is OK: OK: All targets OK [08:01:01] legoktm: thanks :) [08:10:52] (03PS1) 10Legoktm: Add extension-coverage for a few extensions [integration/config] - 10https://gerrit.wikimedia.org/r/411185 [08:11:13] (03CR) 10Legoktm: [C: 04-1] "Still pending on open patches" [integration/config] - 10https://gerrit.wikimedia.org/r/411185 (owner: 10Legoktm) [08:19:08] (03PS1) 10Legoktm: Read phan-taint-check-plugin version out of composer.json [integration/config] - 10https://gerrit.wikimedia.org/r/411186 (https://phabricator.wikimedia.org/T187497) [09:11:37] (03PS5) 10Krinkle: mwconf: Use built-in DevelopmentSettings.php instead when available [integration/jenkins] - 10https://gerrit.wikimedia.org/r/383040 (https://phabricator.wikimedia.org/T177669) [09:11:43] (03CR) 10jerkins-bot: [V: 04-1] mwconf: Use built-in DevelopmentSettings.php instead when available [integration/jenkins] - 10https://gerrit.wikimedia.org/r/383040 (https://phabricator.wikimedia.org/T177669) (owner: 10Krinkle) [09:11:45] (03CR) 10Hashar: "On https://gerrit.wikimedia.org/r/#/c/400157/ legoktm wrote:" [integration/config] - 10https://gerrit.wikimedia.org/r/400159 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [09:12:54] (03PS6) 10Krinkle: mwconf: Use built-in DevelopmentSettings.php instead when available [integration/jenkins] - 10https://gerrit.wikimedia.org/r/383040 (https://phabricator.wikimedia.org/T177669) [09:12:56] (03PS7) 10Krinkle: mwconf: Use built-in DevelopmentSettings.php instead when available [integration/jenkins] - 10https://gerrit.wikimedia.org/r/383040 (https://phabricator.wikimedia.org/T177669) [09:15:27] (03PS8) 10Krinkle: mwconf: Use built-in DevelopmentSettings.php instead when available [integration/jenkins] - 10https://gerrit.wikimedia.org/r/383040 (https://phabricator.wikimedia.org/T177669) [09:15:37] (03CR) 10Krinkle: "Core patch landed. This is ready to go now." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/383040 (https://phabricator.wikimedia.org/T177669) (owner: 10Krinkle) [09:16:05] (03PS9) 10Krinkle: mwconf: Use built-in DevelopmentSettings.php instead when available [integration/jenkins] - 10https://gerrit.wikimedia.org/r/383040 (https://phabricator.wikimedia.org/T177669) [09:16:24] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team, 10MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), 10Patch-For-Review: Maintain debug settings in MediaWiki core - https://phabricator.wikimedia.org/T177669#3977889 (10Krinkle) p:05Triage>03Low a:03Krin... [09:16:33] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10MediaWiki-Platform-Team, 10Patch-For-Review: Maintain debug settings in MediaWiki core - https://phabricator.wikimedia.org/T177669#3666254 (10Krinkle) [09:49:42] 10Phabricator, 10Zero, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)): Phab file uploads are blocked for inactive Zero IP ranges - https://phabricator.wikimedia.org/T173537#3977946 (10Zoranzoki21) LOL: I now see only pictuers which are default on profiles of users. [11:01:38] (03PS2) 10Hashar: Add support to pass options to 'docker run' [integration/config] - 10https://gerrit.wikimedia.org/r/411098 (https://phabricator.wikimedia.org/T186145) [11:01:40] (03PS4) 10Hashar: Migrate mw-config composer job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/410950 (https://phabricator.wikimedia.org/T186145) [11:04:56] !log updating all docker related jobs https://gerrit.wikimedia.org/r/#/c/411098/ [11:05:02] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [11:05:21] (03CR) 10Hashar: [C: 032] Add support to pass options to 'docker run' [integration/config] - 10https://gerrit.wikimedia.org/r/411098 (https://phabricator.wikimedia.org/T186145) (owner: 10Hashar) [11:07:04] (03PS5) 10Hashar: Experimental mw-config composer job on Docker [integration/config] - 10https://gerrit.wikimedia.org/r/410950 (https://phabricator.wikimedia.org/T186145) [11:07:21] (03Merged) 10jenkins-bot: Add support to pass options to 'docker run' [integration/config] - 10https://gerrit.wikimedia.org/r/411098 (https://phabricator.wikimedia.org/T186145) (owner: 10Hashar) [11:07:54] (03CR) 10Hashar: [C: 032] Experimental mw-config composer job on Docker [integration/config] - 10https://gerrit.wikimedia.org/r/410950 (https://phabricator.wikimedia.org/T186145) (owner: 10Hashar) [11:09:13] (03Merged) 10jenkins-bot: Experimental mw-config composer job on Docker [integration/config] - 10https://gerrit.wikimedia.org/r/410950 (https://phabricator.wikimedia.org/T186145) (owner: 10Hashar) [11:16:34] Hi [11:22:26] (03CR) 10Hashar: Add few extensions in zuul/layout.yaml to Jenkins can run builds (034 comments) [integration/config] - 10https://gerrit.wikimedia.org/r/406524 (https://phabricator.wikimedia.org/T183674) (owner: 10Zoranzoki21) [11:26:17] (03PS1) 10Hashar: Switch mw-config composer job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411206 (https://phabricator.wikimedia.org/T186145) [11:28:03] (03CR) 10Hashar: [C: 032] "Zuul queues are kept intact :]" [integration/config] - 10https://gerrit.wikimedia.org/r/411206 (https://phabricator.wikimedia.org/T186145) (owner: 10Hashar) [11:29:31] (03Merged) 10jenkins-bot: Switch mw-config composer job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411206 (https://phabricator.wikimedia.org/T186145) (owner: 10Hashar) [11:30:02] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Migrate operations-mw-config-composer-hhvm-jessie to Docker - https://phabricator.wikimedia.org/T186145#3978164 (10hashar) 05Open>03Resolved I have switched operations/mediawiki-config job for com... [11:31:25] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Jenkins, and 2 others: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3978167 (10Zoranzoki21) [12:35:21] 10Project-Admins, 10Africa-Wikimedia-Developers: Project work board request for WikiFundi - https://phabricator.wikimedia.org/T186754#3978321 (10D3r1ck01) p:05Triage>03Normal [12:44:19] 10Phabricator, 10WMNO-General: Herald rule for WMNO - https://phabricator.wikimedia.org/T187539#3978377 (10jhsoby-WMNO) [12:51:43] (03CR) 10Hashar: [C: 031] mwconf: Use built-in DevelopmentSettings.php instead when available [integration/jenkins] - 10https://gerrit.wikimedia.org/r/383040 (https://phabricator.wikimedia.org/T177669) (owner: 10Krinkle) [13:19:06] 10Phabricator, 10Zero, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)): Phab file uploads are blocked for inactive Zero IP ranges - https://phabricator.wikimedia.org/T173537#3978528 (10Aklapper) >>! In T173537#3977302, @Zoranzoki21 wrote: > I need to telenor work for me because I can not see... [13:23:10] 10Phabricator, 10Zero, 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)): Phab file uploads are blocked for inactive Zero IP ranges - https://phabricator.wikimedia.org/T173537#3531993 (10Zoranzoki21) Nothing, I have to suffer. [13:25:23] 10MediaWiki-Codesniffer: Forbid parse_str() without a second argument - https://phabricator.wikimedia.org/T183739#3978538 (10Ricordisamoa) [13:33:47] (03PS1) 10Hashar: Migrate analytics-refinery-maven to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411232 [13:34:06] (03CR) 10Hashar: [C: 032] "Passed https://integration.wikimedia.org/ci/job/analytics-refinery-maven-java8-docker/ :]" [integration/config] - 10https://gerrit.wikimedia.org/r/411232 (owner: 10Hashar) [13:35:56] (03Merged) 10jenkins-bot: Migrate analytics-refinery-maven to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411232 (owner: 10Hashar) [13:56:40] !log Jenkins: disabled JNLP protocol entirely | https://integration.wikimedia.org/ci/configureSecurity/ [13:56:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:57:26] 10Continuous-Integration-Config, 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10Patch-For-Review, 10User-Zoranzoki21: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3978611 (10hashar) [14:22:27] (03PS1) 10Hashar: Docker job for apps-android-java-mwapi [integration/config] - 10https://gerrit.wikimedia.org/r/411247 [14:49:39] (03Abandoned) 10Hashar: Docker job for apps-android-java-mwapi [integration/config] - 10https://gerrit.wikimedia.org/r/411247 (owner: 10Hashar) [15:09:47] zeljkof: still around? I am wondering what https://integration.wikimedia.org/ci/job/selenium-CirrusSearch-jessie/ is for ? :] [15:10:15] there are three of them: selenium-CirrusSearch-jessie selenium-Popups-jessie selenium-RelatedArticles-jessie apparently run on a daily basis [15:10:35] hashar: selenium+node (smoke) tests [15:10:42] targeting beta cluster [15:10:49] like we had for ruby framework [15:11:09] do they report anywhere? [15:11:30] I don't think so, yet, there is a task to do it [15:11:40] on my list for next week [15:13:13] hmm [15:13:20] I will look at them next week [15:13:26] but seems there is no need to install mediawiki [15:13:33] I think so too [15:13:39] it is probably all about cloning mediawiki + extension [15:13:39] not sure why I did that :) [15:13:43] then running npm install [15:13:50] and finally launching wdio against beta [15:13:54] yes [15:13:57] copy paste I guess :] [15:14:02] probably [15:14:06] we can surely refactor it [15:14:08] and I forgot to clean up [15:14:09] and [15:14:14] create a docker container for it :] [15:15:04] I wish npm / package.json had support for groups of dependencies [15:27:44] PROBLEM - Puppet errors on deployment-redis01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:28:35] (03PS1) 10Hashar: Migrate translatewiki-composer-hhvm to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411263 [15:28:48] (03CR) 10Hashar: [C: 032] Migrate translatewiki-composer-hhvm to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411263 (owner: 10Hashar) [15:30:16] (03Merged) 10jenkins-bot: Migrate translatewiki-composer-hhvm to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411263 (owner: 10Hashar) [15:33:41] PROBLEM - Puppet errors on deployment-redis02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:34:40] (03PS1) 10Hashar: Add Castor to composer jobs running on Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411267 [15:35:04] (03CR) 10Hashar: [C: 032] Add Castor to composer jobs running on Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411267 (owner: 10Hashar) [15:36:22] (03Merged) 10jenkins-bot: Add Castor to composer jobs running on Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411267 (owner: 10Hashar) [15:39:49] !log castor02: sudo rm -fR /srv/jenkins-workspace/caches/*/*/*trusty [15:39:54] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [15:43:49] (03PS1) 10Hashar: Migrate mediawiki/vendor hhvm composer job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411271 [15:48:32] (03CR) 10Hashar: [C: 04-1] "Need to bump the timeout. mediawiki/vendor fails: https://integration.wikimedia.org/ci/job/mwgate-composer-hhvm-docker/44/console" [integration/config] - 10https://gerrit.wikimedia.org/r/411271 (owner: 10Hashar) [15:52:47] (03PS2) 10Hashar: Migrate mediawiki/vendor hhvm composer job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411271 [15:53:01] (03CR) 10Hashar: [C: 032] Migrate mediawiki/vendor hhvm composer job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411271 (owner: 10Hashar) [15:54:13] (03Merged) 10jenkins-bot: Migrate mediawiki/vendor hhvm composer job to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411271 (owner: 10Hashar) [15:58:57] 10Continuous-Integration-Infrastructure, 10Gerrit, 10Jenkins, 10Zuul: jenkins no longer starts gate-and-submit when parent is in gate-and-submit pipeline - https://phabricator.wikimedia.org/T186949#3979060 (10Umherirrender) [16:00:20] (03CR) 10Hashar: [C: 032] "rechecked on https://gerrit.wikimedia.org/r/#/c/409698/ and it passed https://integration.wikimedia.org/ci/job/mwgate-composer-hhvm-docker" [integration/config] - 10https://gerrit.wikimedia.org/r/411271 (owner: 10Hashar) [16:04:19] (03PS1) 10Hashar: Replace experimental composer-hhvm by a Docker version [integration/config] - 10https://gerrit.wikimedia.org/r/411279 [16:05:22] (03PS1) 10Hashar: Use docker for HHVM in composer-test template [integration/config] - 10https://gerrit.wikimedia.org/r/411280 [16:05:57] (03PS1) 10Hashar: Use docker for HHVM in mwgate-composer template [integration/config] - 10https://gerrit.wikimedia.org/r/411281 [16:10:27] (03CR) 10Hashar: [C: 032] Replace experimental composer-hhvm by a Docker version [integration/config] - 10https://gerrit.wikimedia.org/r/411279 (owner: 10Hashar) [16:11:37] (03Merged) 10jenkins-bot: Replace experimental composer-hhvm by a Docker version [integration/config] - 10https://gerrit.wikimedia.org/r/411279 (owner: 10Hashar) [16:22:34] (03PS1) 10Hashar: Migrate composer-test-package to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411285 [16:24:03] (03CR) 10Hashar: [C: 032] Migrate composer-test-package to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411285 (owner: 10Hashar) [16:24:55] (03CR) 10Hashar: [C: 032] Use docker for HHVM in composer-test template [integration/config] - 10https://gerrit.wikimedia.org/r/411280 (owner: 10Hashar) [16:25:11] (03Merged) 10jenkins-bot: Migrate composer-test-package to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/411285 (owner: 10Hashar) [16:25:15] (03CR) 10Hashar: [C: 032] Use docker for HHVM in mwgate-composer template [integration/config] - 10https://gerrit.wikimedia.org/r/411281 (owner: 10Hashar) [16:26:06] (03Merged) 10jenkins-bot: Use docker for HHVM in composer-test template [integration/config] - 10https://gerrit.wikimedia.org/r/411280 (owner: 10Hashar) [16:26:22] (03Merged) 10jenkins-bot: Use docker for HHVM in mwgate-composer template [integration/config] - 10https://gerrit.wikimedia.org/r/411281 (owner: 10Hashar) [16:49:28] hashar: um, I think we have a serious problem [16:49:46] I think CI is running against master, not the patches being merged? [16:50:19] in https://gerrit.wikimedia.org/r/#/c/411058/ we removed jscs/jshint but in the job https://integration.wikimedia.org/ci/job/mwgate-npm-node-6-docker/20518/console it ran those [16:50:29] and then the next CA patch is now failing when it tries to run eslint [16:50:42] thcipriani: ^^ [16:50:55] I've seen a few random failures in other places that make no sense either [16:51:12] * thcipriani looks [16:51:22] e.g. https://gerrit.wikimedia.org/r/#/c/410696/ - the follow up passes [16:52:39] another example: https://gerrit.wikimedia.org/r/#/c/410423/ PHPCS should have failed, but it didn't, then it started failing on https://gerrit.wikimedia.org/r/#/c/410424/2 [16:53:08] I originally thought they were flukes but now the pattern is making more sense [16:54:18] legoktm: hello [16:54:47] hi :) [16:54:53] so we would run the wrong patch? :((( [16:55:08] for that console above the HEAD was HEAD is now at b6bb278... build: Bump devDependencies to latest [16:55:51] which is wrong, it should have been "build: Replace jshint and jscs with eslint" [16:56:06] hmm [16:56:10] https://integration.wikimedia.org/ci/job/mwgate-npm-node-6-docker/20518/parameters/ looking at that [16:56:14] will check on the zuul merger [16:56:45] * legoktm files a task [16:57:59] so is docker ci-src-setup not doing the right thing? [16:58:24] I think it fetches the proper ref [16:58:40] in that case that was refs/zuul/master/Zcb21260c372a48d295ef55f57f2a1bb5 [16:58:50] which on the zuul-merger point to another commit :/ [16:58:52] the failure I saw on https://gerrit.wikimedia.org/r/#/c/410696/ is not a docker job [16:59:09] on contint1001 : git -C /srv/zuul/git/mediawiki/extensions/CentralAuth show b6bb278254b96f23beaac321461dac67be2ba8cb [16:59:33] so that would be the zuul merger misbehaving [17:00:13] 10Continuous-Integration-Infrastructure: CI is running against parent patches, not the patches themselves - https://phabricator.wikimedia.org/T187567#3979150 (10Legoktm) p:05Triage>03Unbreak! [17:02:57] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render repository - https://phabricator.wikimedia.org/T179552#3979166 (10Jdrewniak) Ok, Jenkin's is successfully -1 and +2'ing the patches. This patch was +2'd ht... [17:04:25] 10Continuous-Integration-Infrastructure: CI is running against parent patches, not the patches themselves - https://phabricator.wikimedia.org/T187567#3979150 (10hashar) https://integration.wikimedia.org/ci/job/mwgate-npm-node-6-docker/20518/console got triggered with refs/zuul/master/Zcb21260c372a48d295ef55f57f... [17:04:26] hmm [17:04:39] so that happens both in test and gate-and-submit [17:04:43] hrm, zuul-merger debug log is full of Unable to find commit for ref and No base commit found for (u'mediawiki/extensions/TimedMediaHandler', u'master') [17:04:59] dunno if that's noise or not [17:05:03] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render repository - https://phabricator.wikimedia.org/T179552#3979173 (10Niedzielski) 05Open>03Resolved Thanks @Jdrewniak! {icon thumbs-up} [17:05:10] oh [17:07:02] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Proton, 10Readers-Web-Backlog, and 2 others: Set up Jenkins for chromium-render repository - https://phabricator.wikimedia.org/T179552#3979177 (10Jdrewniak) [17:07:25] 10Continuous-Integration-Infrastructure: CI is running against parent patches, not the patches themselves - https://phabricator.wikimedia.org/T187567#3979179 (10hashar) The commit that show up is from the parent change https://gerrit.wikimedia.org/r/#/c/411057/ which was still open. So the chain was: https://g... [17:07:32] yeah so we had two changes A -> B [17:07:36] chained in Gerrit [17:07:46] but B does not get tested :( [17:11:42] don't know if it's related, but https://phabricator.wikimedia.org/T186949 is another issue with chained patches [17:13:45] 10Continuous-Integration-Config: docker-registry.wikimedia.org/releng/composer-package-php55:0.2.1 missing - https://phabricator.wikimedia.org/T187569#3979196 (10Legoktm) [17:16:07] 10Continuous-Integration-Config: docker-registry.wikimedia.org/releng/composer-package-php55:0.2.1 missing - https://phabricator.wikimedia.org/T187569#3979212 (10Legoktm) ``` composer-package-php55 (0.2.2) wikimedia; urgency=medium * Use docker-registry.wikimedia.org/releng/composer -- Antoine Musso (03PS1) 10Legoktm: Fix composer-package-php55 docker image version [integration/config] - 10https://gerrit.wikimedia.org/r/411300 (https://phabricator.wikimedia.org/T187569) [17:17:15] 10Continuous-Integration-Infrastructure: CI is running against parent patches, not the patches themselves - https://phabricator.wikimedia.org/T187567#3979221 (10hashar) When the changes got a +2: 2018-02-16 05:51:01,357 DEBUG zuul.Merger: Merging for change 411057,1. 2018-02-16 05:51:01,357 DEBUG zuul.Merger: P... [17:17:22] legoktm: yeah chained patches are broken apparently [17:19:22] (03PS1) 10Hashar: docker: containers for php5.6 based on Jessie [integration/config] - 10https://gerrit.wikimedia.org/r/411301 [17:19:24] (03PS1) 10Hashar: This change should have JJB diff job running [integration/config] - 10https://gerrit.wikimedia.org/r/411302 (https://phabricator.wikimedia.org/T187567) [17:19:32] grr [17:19:42] > Processing refspec None for project mediawiki/extensions/CentralAuth / master ref Z8adf4337cdbb4e5585b97d261f550143 [17:19:56] yeah so definitely broken [17:20:07] https://gerrit.wikimedia.org/r/#/c/411302/ depends on another change that is still open [17:20:17] it modify a JJB file which should run the jjb-diff job [17:20:24] but it is actually tested against the parent bah [17:22:11] merge jobs entering the pipeline with items where the refspec is empty [17:22:28] er, gearman, not pipeline [17:23:31] yeah [17:23:39] I think the zuul-merger does the job properly [17:23:45] but the zuul-scheduler send the wrong info [17:23:49] I am digging in its log [17:23:56] Preparing ref for: [17:24:02] Change depends on changes [] [17:24:04] which is good [17:24:19] Submitting job [17:24:29] (which is the scheduler asking the merger to craft a merge commit [17:24:34] the parameters being: [17:24:41] {'items': [{'oldrev': None, 'newrev': None, 'refspec': u'refs/changes/01/411301/1', 'merge_mode': 2, 'number': '411301', 'connection_name': 'gerrit', 'project': 'integration/config', 'url': 'ssh://jenkins-bot@gerrit.wikimedia.org:29418/integration/config', 'branch': u'master', 'patchset': 1, 'ref': 'Z9c6cc7d316b44ac3bc35d38fa3fe226d'}, {'oldrev': None, 'newrev': None, 'refspec': None, 'merge_mode': 2, 'number': u'411302', 'connection_name': [17:24:41] 'gerrit', 'project': 'integration/config', 'url': 'ssh://jenkins-bot@gerrit.wikimedia.org:29418/integration/config', 'branch': u'master', 'patchset': u'1', 'ref': 'Zb9c4ca84abe74be79e1b43aa7991eed3'}]} [17:24:45] grr [17:24:53] (03CR) 10Legoktm: [C: 032] "Deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/411300 (https://phabricator.wikimedia.org/T187569) (owner: 10Legoktm) [17:25:12] 10Continuous-Integration-Config, 10Patch-For-Review: docker-registry.wikimedia.org/releng/composer-package-php55:0.2.1 missing - https://phabricator.wikimedia.org/T187569#3979248 (10Legoktm) 05Open>03Resolved [17:26:28] (03Abandoned) 10Hashar: This change should have JJB diff job running [integration/config] - 10https://gerrit.wikimedia.org/r/411302 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [17:26:46] (03Merged) 10jenkins-bot: Fix composer-package-php55 docker image version [integration/config] - 10https://gerrit.wikimedia.org/r/411300 (https://phabricator.wikimedia.org/T187569) (owner: 10Legoktm) [17:33:18] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567#3979277 (10Legoktm) [17:35:07] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567#3979288 (10hashar) In the zuul-scheduler debug logs: ``` Checking for changes needed by :... [17:35:14] legoktm: thcipriani: I got log and pasted them on the task [17:35:51] o.O so why is it none? :( [17:40:40] ohh [17:40:49] I think I got it [17:43:55] I do not have it, but where I am for reference: change object has properties needs_changes and needed_by_changes it seems like whatever is putting the change objects into those lists is building the change object in such a way that refspec is None...I think... [17:44:10] being set in zuul/source/gerrit.py maybe [17:45:55] > Updating : Getting git-needed change 411058,1 [17:51:33] https://github.com/wikimedia/integration-zuul/blob/patch-queue/debian/jessie-wikimedia/zuul/source/gerrit.py#L252 maybe? [17:54:01] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567#3979321 (10hashar) Zuul get the change metadata via _updateChange in zuul/source/gerrit.py. It does: gerrit query --... [17:54:09] thcipriani: yeah I have reached the same conclusion [17:54:43] but I cant see how it would fail [17:54:59] different data types? [17:55:19] potentially yeah [17:55:38] cast it all to int? [17:55:43] it get the change informations using: gerrit query --format json --all-approvals --comments --commit-message --current-patch-set --dependencies --files --patch-sets --submit-records 411302 [17:55:59] in the json output, the patchset number / currentPatchSet.number seems to be int [17:55:59] I can't seem to find: 'Received data from Gerrit query' in the debug log [17:56:08] hmm [17:56:12] I guess it is not logged [17:57:12] well, seems like an easy test: either: str(ps['number']) or int(change.patchset) [17:57:33] and see if that makes different problems. [17:58:52] ZUUL_CHANGES=integration/config:master:refs/changes/01/411301/1^integration/config:master:None # notice the none [17:59:08] so yeah the change.patchset is not populated [17:59:09] hmm [18:00:06] hrm. deeper still I guess [18:00:53] looking at changes made to zuul/source/gerrit.py by upstream [18:03:37] so wait. if change.patchset is empty that would mean dep_ps is empty here: https://github.com/wikimedia/integration-zuul/blob/patch-queue/debian/jessie-wikimedia/zuul/source/gerrit.py#L325-L329 [18:04:45] 2018-02-16 05:51:01,041 DEBUG zuul.source.Gerrit: Updating : Getting git-dependent change 411057,1 [18:04:49] so I guess it is not empty [18:05:26] yeah so how could patchset be empty later [18:05:55] oh the patchset is not empty [18:05:56] getCachedChange? [18:05:58] the refspec is [18:06:31] I think we can add some debug logging to inspect the change at the beginning and end of _updateChange [18:06:46] self.log(change.__hash__) maybe :) [18:07:11] +1 [18:07:33] for some extra logging so we can see what's in change [18:08:30] hmm not __hash__ [18:08:35] grblbl [18:08:54] I wanted something to show all the attributes [18:10:18] self.log("Change is: %s" % vars(change)) [18:10:19] vars? [18:10:21] yeah [18:11:49] PROBLEM - Free space - all mounts on deployment-eventlog02 is CRITICAL: CRITICAL: deployment-prep.deployment-eventlog02.diskspace.root.byte_percentfree (<50.00%) [18:12:11] (03CR) 10Jforrester: "Extension now archived and removed from mediawiki/extensions.git. Good to go whenever." [integration/config] - 10https://gerrit.wikimedia.org/r/410360 (owner: 10Jforrester) [18:16:30] wait. I think we have already established that change.patchset is a string since it comes from splitting a string on '/'. And gerrit query returns an int so ps['number'] is an int and change.patchset is a string which would explain why refspec is not set https://github.com/wikimedia/integration-zuul/blob/patch-queue/debian/jessie-wikimedia/zuul/source/gerrit.py#L252 leaving it as None [18:18:03] (03PS1) 10Hashar: wmf: debug log for GerritSource._updateChange [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411321 (https://phabricator.wikimedia.org/T187567) [18:18:12] thcipriani: my terrible hack ^^ :( [18:18:32] (meanwhile I still have a can of IPA from the US) [18:19:13] at least it passes flake8 [18:20:56] (03PS1) 10Hashar: 2.5.1-wmf3: debug logging for GerritSource._updateChange [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411322 (https://phabricator.wikimedia.org/T187567) [18:21:18] package is building. I need a break to check home [18:21:19] (03CR) 10jerkins-bot: [V: 04-1] 2.5.1-wmf3: debug logging for GerritSource._updateChange [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411322 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [18:21:29] grr [18:22:00] pbuilder-satisfydepends-dummy : Depends: dh-virtualenv (>= 0.9) but it is not going to be installed. [18:27:18] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567#3979432 (10hashar) https://people.wikimedia.org/~hashar/debs/zuul_2.5.1-wmf3/ [18:34:47] upgraded [18:35:49] (03Restored) 10Hashar: This change should have JJB diff job running [integration/config] - 10https://gerrit.wikimedia.org/r/411302 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [18:35:51] (03PS2) 10Hashar: This change should have JJB diff job running [integration/config] - 10https://gerrit.wikimedia.org/r/411302 (https://phabricator.wikimedia.org/T187567) [18:37:01] thcipriani: there are logs in /var/log/zuul/debug.log now. [18:37:04] checking for 411302,2 [18:37:31] ahah [18:37:38] bug fixed ;) [18:37:50] so that is the changeCache that has some issue :((((((((( [18:39:21] PROBLEM - Puppet errors on deployment-mx is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:39:24] hrm. [18:40:53] but the only place that gets updated is from _getChange afaict [18:44:19] (03CR) 10Hashar: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/411302 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [18:45:29] thcipriani: there is also a change cache [18:46:09] in zuul/connection/gerrit? or a different one? [18:48:07] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567#3979523 (10hashar) After restarting Zuul, a new change yields: ``` 2018-02-16 18:35:54,974 Updating (03PS1) 10Hashar: Dummy commit [integration/config] - 10https://gerrit.wikimedia.org/r/411360 [18:58:17] thcipriani: so I am out of idea [18:58:23] it is late, I am taking a break [18:58:42] seems it managed to get all the change.refspec proerply :- [18:59:03] k, I'll try to come up with another theory (if I can find another broken change)... [18:59:35] there is an in process cache for the changes so maybe that is there [18:59:46] but I dont know that area of the code at all [19:00:37] https://github.com/wikimedia/integration-zuul/blob/patch-queue/debian/jessie-wikimedia/zuul/source/gerrit.py#L161-L177 [19:02:58] yeah, the cache should be in zuul/connection/gerrit.py [19:03:20] https://github.com/wikimedia/integration-zuul/blob/patch-queue/debian/jessie-wikimedia/zuul/connection/gerrit.py#L240-L243 [19:03:47] but the only place that is updated is in the function you sent: https://github.com/wikimedia/integration-zuul/blob/patch-queue/debian/jessie-wikimedia/zuul/source/gerrit.py#L171 [19:04:02] so that is still happening [19:04:11] https://gerrit.wikimedia.org/r/#/c/410625/ is part of a chain [19:04:26] and that is the parent that got tested :( [19:05:45] 10MediaWiki-Codesniffer: FunctionCommentSniff fails on substr_compare - https://phabricator.wikimedia.org/T187575#3979554 (10Umherirrender) [19:06:13] > T187567 post change: {'files': [], 'status': u'NEW', 'needed_by_changes': [], 'needs_changes': [], 'refspec': None [19:06:14] T187567: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567 [19:06:23] * thcipriani keeps digging [19:06:46] Is this the same change id need to be a string bug? [19:07:02] paladox: probably related [19:07:08] Ok [19:07:08] well not change id [19:07:58] i guess make all change_num code a str? [19:08:32] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [19:10:01] $ grep "T187567 post change.*refspec': None," /var/log/zuul/debug.log|grep -o -P 'Change 0x.*?>' [19:10:01] Change 0x7f5d74f45ed0 411302,1> [19:10:01] Change 0x7f5d74e35490 411311,1> [19:10:01] Change 0x7f5d74e015d0 411325,2> [19:10:02] Change 0x7f5d74e07a50 410434,2> [19:10:02] Change 0x7f5d753b1950 410627,11> [19:10:02] Change 0x7f5d75c381d0 410625,10> [19:10:02] Change 0x7f5d7523f8d0 409184,9> [19:10:03] Change 0x7f5d7523f8d0 409184,9> [19:10:03] Change 0x7f5d75c381d0 410625,10> [19:10:03] Change 0x7f5d753b1950 410627,11> [19:10:04] Change 0x7f5d753b1950 410627,11> [19:10:04] Change 0x7f5d7523f8d0 409184,9> [19:10:05] Change 0x7f5d75c381d0 410625,10> [19:11:26] Is this problem only happening for changes that depend on something else? [19:12:25] paladox: apparently [19:12:32] legoktm thanks [19:12:33] Upstream doint seem to have fixed it in 3.0 either. [19:16:54] thcipriani: soo yeah [19:16:57] 10Continuous-Integration-Infrastructure, 10Patch-For-Review: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567#3979604 (10hashar) Updating 2018-02-16 18:40:24,714 DEBUG zuul.source.Gerrit: pre chan... [19:17:07] eventually updateChange is given a Change object that has patchset=u'10' [19:17:24] then it iterates other each of the patchsets received from Gerrit [19:17:37] but they all have a for their patch number [19:17:49] so there is no match [19:18:07] so I guess the lame patch is to cast again :( [19:19:19] https://gist.github.com/thcipriani/395f9a27bbc93a87033bac4b35c62e97 [19:19:30] heh, yeah, just came here to paste that same conclusion. [19:19:44] COOL [19:19:50] that shows all aligned we are! [19:20:18] - if ps['number'] == change.patchset [19:20:18] types. [19:20:29] + if str(ps['number']) == str(change.patchset) [19:20:30] maybe [19:20:38] and then make sure we hint down why a string ends up there :( [19:20:49] I am taking a quick break now [19:21:34] +1 to that patchset. [19:23:32] >.< [19:24:10] * legoktm hugs thcipriani and hashar [19:25:04] * hashar hugs legoktm for reporting issues ! :D [19:25:18] having a glass of water and one of wine and I will be back [19:25:41] :) [19:26:39] tgr: I finally added my gpg key to github like you pinged me about $days ago [19:27:56] yay! [19:40:28] (03PS1) 10Thcipriani: Ensure patchset comparison in the case of different types [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411372 (https://phabricator.wikimedia.org/T187567) [19:40:35] (03PS2) 10Hashar: wmf: debug log for GerritSource._updateChange [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411321 (https://phabricator.wikimedia.org/T187567) [19:40:48] (03CR) 10Hashar: "reworked to show more details" [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411321 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [19:42:47] (03PS2) 10Hashar: Ensure patchset comparison in the case of different types [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411372 (https://phabricator.wikimedia.org/T187567) (owner: 10Thcipriani) [19:42:49] (03PS3) 10Hashar: wmf: debug log for GerritSource._updateChange [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411321 (https://phabricator.wikimedia.org/T187567) [19:42:50] thcipriani: rebuilding [19:43:18] that was a quick glass of water/wine :) [19:44:25] (03PS2) 10Hashar: 2.5.1-wmf3: fix patchset comparaison [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411322 (https://phabricator.wikimedia.org/T187567) [19:44:41] oh [19:44:48] I have decided to finish the bottle at my desk [19:44:49] (03CR) 10jerkins-bot: [V: 04-1] 2.5.1-wmf3: fix patchset comparaison [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411322 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [19:45:07] (the job is broken because jessie-wikimedia/backports is suddenly missing) [19:47:31] thcipriani: deployed [19:47:36] and I reworked the logging patch [19:47:42] cool [19:48:24] so that each debug log line has the change number showing up [19:48:25] eg: [19:48:32] 2018-02-16 19:48:18,536 DEBUG zuul.source.Gerrit: T187567 checking Gerrit ps 4 == 4 [19:48:32] 2018-02-16 19:48:18,536 DEBUG zuul.source.Gerrit: T187567 found matching patchset: change.refspec = refs/changes/14/409714/4 [19:48:32] T187567: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567 [19:48:38] and it is now logging whether a patch got found [19:48:54] then at the end of the method call, only shows the patchset and refspec of the change [19:48:54] T187567 post change: patchset = 4, refspec = refs/changes/14/409714/4 [19:49:22] hehe : checking Gerrit ps 1 == 1 [19:49:23] here is our bug [19:49:34] 2018-02-16 19:49:07,289 DEBUG zuul.source.Gerrit: T187567 found matching patchset: change.refspec = refs/changes/16/410716/1 [19:49:38] but your patch fix it [19:49:49] thcipriani: kudos! [19:49:58] I am off for a bit more will try to hunt the root cause [19:50:16] but most probably we should implement your idea of having the change.patchset and change.number to always yield an int [19:50:22] even when set as a string [19:50:25] bbl [19:50:27] k [19:50:49] I did have a patch set for that. I'll see if I can find it. [19:52:14] in this instance though, it was on the gerrit type side, not the change side. So ¯\_(ツ)_/¯ [19:53:10] dynamic typing whack-a-mole when connection starts returning something different. It is probably more correct to try to correct at the connection-side rather than in the change object. [20:37:21] paladox: Two quick questions... 1) https://gerrit.wikimedia.org/r/settings/#Groups -- could these group lists link *to* the group page? Would save some searching/clicking (maybe it's fixed in stable-2.15?).... should be easy if not. And 2) Upper right menu -> Switch Account 404s for us [20:37:32] Is (2) a configuration thing? A 2.15 thing? [20:37:37] no_justification polygerrit i guess? [20:37:42] Yep [20:37:47] no_justification aha, yes [20:37:59] I actually would like to do that, that's not done in master yet. [20:38:11] though groups have been implemented there :) [20:38:19] thcipriani: so I think that fixed it [20:38:23] Ah, https://gerrit.wikimedia.org/r/Documentation/config-gerrit.html#auth.switchAccountUrl [20:38:37] no_justification switch account i guess is using the a none base url [20:38:39] * paladox tests [20:38:57] URL to switch user identities and login as a different account than the currently active account. This is disabled by default except when auth.type is OPENID and DEVELOPMENT_BECOME_ANY_ACCOUNT. If set the "Switch Account" link is displayed next to "Sign Out". [20:39:01] PROBLEM - Puppet errors on deployment-mediawiki07 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:39:02] Fun, we use LDAP! [20:39:03] :p [20:39:06] ah [20:39:07] https://gerrit.wikimedia.org/r/switch-account [20:39:19] no_justification lol they hide it for the develop auth [20:39:23] but show it for ldap [20:39:34] (in gwtui they hide it for ldap but show it for develop) [20:39:58] hashar: that's good :) [20:40:11] 10Continuous-Integration-Infrastructure, 10Zuul: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567#3979783 (10hashar) p:05Unbreak!>03High @thcipriani and I looked at it at the same time and we ended up with the same conclusion a... [20:40:22] no_justification though it seems that switch-account is hidden for ldap users @ master [20:40:26] not sure about 2.15 though [20:40:33] I think it's done in there too. [20:40:35] Must be broken in 2.14 :) [20:40:40] yes [20:40:42] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Zuul: Exception while launching job: TypeError: 'int' object has no attribute '__getitem__' - https://phabricator.wikimedia.org/T186381#3942743 (10hashar) Different issue having the same root cause (patchset number changed to an... [20:40:47] no_justification alot of things were broken in that release [20:40:53] most things are fixed in 2.15 :) [20:42:27] no_justification the registeration form is fixed in 2.15 but broken in 2.14 [20:42:49] Though i kept changing my format for it. [20:42:55] So kaspern did the fix [20:43:58] no_justification this is the new groups page http://gerrit-test.wmflabs.org/gerrit/admin/groups/3,members :) [20:44:32] AHAH [20:44:34] thcipriani: found it [20:44:47] well at least I found one of the reason for the string [20:44:55] ? [20:46:15] no_justification and you can search for plugins now, i made that request as i wanted to make all pages under /admin/ which use a table use that gr-list-view [20:47:10] And that reminds me i need to backport a bug fix sometime soon for polygerrit [20:47:33] the buttons doin't have a background colour in settings, making things look ugly [20:47:54] that was fixed @ master but it had a few different changes compared to 2.15 so not easy to backport yet. [20:49:43] no_justification my two backports into 2.14 was merged [20:49:51] so the menu problem is now fixed. [20:50:06] i will do the groups things after i write some tests for https://gerrit-review.googlesource.com/c/gerrit/+/160072/ [20:52:33] lol i found mistmatch in the name in tests [20:52:45] suite('gr-settings-view tests', () => { for gr-menu-editor [20:57:45] 10Continuous-Integration-Infrastructure, 10Zuul: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567#3979822 (10hashar) I found a code path that injects a string for the patchset. The list of dependencies obtained via the --dependenc... [20:58:40] What. The. Actual. Fuck. [20:58:43] sshd.maxConnectionsPerUser: Maximum number of concurrent SSH sessions that a user account may open at one time. This is the number of distinct SSH logins that each user may have active at one time, and is not related to the number of commands a user may issue over a single connection. If set to 0, there is no limit. [20:58:48] By default, 64. [20:58:52] 64 CONNECTIONS PER USER?! [20:58:54] lol [20:59:03] no_justification some clonning to many repos heh [20:59:08] (that's a joke :)) [20:59:18] good lord. [20:59:40] lower it? [20:59:51] though what side affect will that have? [20:59:54] brb git config --global submodule.fetchJobs = 64 [21:00:02] no_justification i guess it's 64 for large projects or that ^^ [21:00:35] (I actually have fetchJobs set to 0 aka no limit, but I fetch over HTTPS) [21:01:13] thcipriani: oh actually that is what you wrote in the commit message bah [21:01:39] simultaneous connections? No. Absolutely not. 64 is insane. [21:01:45] Guess what, we're halving that. [21:01:58] no_justification 32? [21:02:03] or 12? [21:02:15] (03PS3) 10Hashar: Ensure patchset comparison in the case of different types [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411372 (https://phabricator.wikimedia.org/T187567) (owner: 10Thcipriani) [21:02:17] (03PS4) 10Hashar: wmf: debug log for GerritSource._updateChange [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411321 (https://phabricator.wikimedia.org/T187567) [21:02:58] thcipriani: https://gerrit.wikimedia.org/r/#/c/411372/2..3/zuul/source/gerrit.py cast some stuff to integer [21:04:29] hashar: that works for me if that's where you want to do the casting [21:04:49] thcipriani: well the patch keeps both [21:04:53] just to be safe :] [21:05:17] belt and suspenders :) [21:05:24] (03CR) 10Thcipriani: [C: 031] Ensure patchset comparison in the case of different types [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411372 (https://phabricator.wikimedia.org/T187567) (owner: 10Thcipriani) [21:05:27] wfm [21:06:01] paladox: I'm going with 32 for now [21:06:07] ok [21:06:23] https://gerrit.wikimedia.org/r/c/411397/ [21:06:49] no_justification question will this idleTimeout = 43200 s work? [21:06:55] ie the s being one space away? [21:08:30] (03PS3) 10Hashar: 2.5.1-wmf3: fix patchset comparaison [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411322 (https://phabricator.wikimedia.org/T187567) [21:08:49] thcipriani: I will stop messing with it [21:08:52] (03CR) 10jerkins-bot: [V: 04-1] 2.5.1-wmf3: fix patchset comparaison [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411322 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [21:09:01] seems we got a working patch. So that is good enough for now [21:09:08] seems it should work [21:09:08] maxWait = 5 min [21:09:09] legoktm: thank you very much to have reported the issue [21:09:30] :) np [21:09:32] paladox: That's how all other time things are in gerrit.config [21:09:36] Idk why they do that, but they do [21:09:40] yep [21:09:55] no_justification lol i like your user status :) [21:10:02] cf: maxAge = 1 hour [21:11:04] Hmm, this is kinda a cool feature: https://gerrit.wikimedia.org/r/Documentation/config-gerrit.html#repository.name.basePath [21:11:31] Yep [21:12:14] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, 10User-Elukey: Apache on phab1001 is gradually leaking worker processes which are stuck in "Gracefully finishing" state - https://phabricator.wikimedia.org/T182832#3979836 (10mmodell) If it's really as simple as importi... [21:12:45] !log Upgraded Zuul to https://gerrit.wikimedia.org/r/#/c/411322/3 [21:12:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:13:00] (03CR) 10Hashar: "recheck" [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411322 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [21:13:28] (03CR) 10jerkins-bot: [V: 04-1] 2.5.1-wmf3: fix patchset comparaison [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411322 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [21:14:02] (03CR) 10Hashar: "recheck" [integration/config] - 10https://gerrit.wikimedia.org/r/411302 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [21:19:05] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.22 deployment blockers - https://phabricator.wikimedia.org/T183961#3979847 (10mmodell) [21:23:31] (03PS2) 10Legoktm: Read phan-taint-check-plugin version out of composer.json [integration/config] - 10https://gerrit.wikimedia.org/r/411186 (https://phabricator.wikimedia.org/T187497) [21:23:41] (03CR) 10Legoktm: [C: 032] Read phan-taint-check-plugin version out of composer.json [integration/config] - 10https://gerrit.wikimedia.org/r/411186 (https://phabricator.wikimedia.org/T187497) (owner: 10Legoktm) [21:23:59] (03CR) 10Hashar: [C: 04-1] Ensure patchset comparison in the case of different types (032 comments) [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411372 (https://phabricator.wikimedia.org/T187567) (owner: 10Thcipriani) [21:24:23] thcipriani: well thank you very much. I am done for this week [21:24:28] :P [21:24:41] there are still some unicode string despite my int() casting hack :( [21:24:51] (03PS1) 10Legoktm: Bump mediawiki-phan-seccheck image to 0.1.1 [integration/config] - 10https://gerrit.wikimedia.org/r/411401 [21:24:54] I saw that [21:24:57] well [21:24:59] I saw your comment [21:25:15] (03Merged) 10jenkins-bot: Read phan-taint-check-plugin version out of composer.json [integration/config] - 10https://gerrit.wikimedia.org/r/411186 (https://phabricator.wikimedia.org/T187497) (owner: 10Legoktm) [21:25:20] and today I migrated a bunch of jobs to their docker version [21:25:27] I havent deleted the old ones from Jenkins [21:25:34] but apparently nothing bad happened [21:25:53] there is not much left [21:26:03] looking at the tests, they evidently mean _getChange to take either ints or strings [21:26:15] !log deploying https://gerrit.wikimedia.org/r/411186 [21:26:20] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:28:05] hashar: https://github.com/wikimedia/integration-zuul/blob/patch-queue/debian/jessie-wikimedia/tests/test_scheduler.py#L4323 vs https://github.com/wikimedia/integration-zuul/blob/patch-queue/debian/jessie-wikimedia/tests/test_scheduler.py#L817 [21:28:57] thcipriani: yeah you can tell it is a bit of a mess :] [21:29:15] there are probably multiple other issues here and there [21:29:18] specially in the test suite [21:29:48] but in the end the cache key is a string "%s/%s" (number, patchset) [21:29:52] so that is cast to a string [21:29:59] but the change is hmm ... not always the same [21:30:24] I wonder if casting inside source/gerrit is the right place? [21:30:39] partially yeah [21:30:40] since that's ultimately where types have changed: in json responses [21:30:53] (03CR) 10Legoktm: [C: 032] Bump mediawiki-phan-seccheck image to 0.1.1 [integration/config] - 10https://gerrit.wikimedia.org/r/411401 (owner: 10Legoktm) [21:31:01] then neededBy / changedBy only expose the reference as as tring [21:31:13] and zuul extract the change/patchset from that string, which yield strings [21:31:32] if we had change.patchset to magically always be normalized to an int, that would solve it [21:31:35] (or a string) [21:31:49] was that the @property thingy? [21:32:24] (03Merged) 10jenkins-bot: Bump mediawiki-phan-seccheck image to 0.1.1 [integration/config] - 10https://gerrit.wikimedia.org/r/411401 (owner: 10Legoktm) [21:32:46] anyway. I should stop [21:34:56] (03PS1) 10Thcipriani: WIP: ensure that Change.number is a string [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411466 (https://phabricator.wikimedia.org/T186381) [21:35:05] ^ hashar that's the @property thing [21:35:43] would do the same for change.patchset in this instance [21:39:16] ;=] [21:39:29] and then we can drop the other patch I guess [21:40:04] I will dig in their branch, try to craft a patch that break the test suite and apply your patch on top of it [21:40:13] cause that seems worth upstreaming [21:40:23] (if zuulv3 is affected , they might have fixed it already) [21:40:33] well done! [21:42:36] (03CR) 10Hashar: WIP: ensure that Change.number is a string (031 comment) [integration/zuul] (patch-queue/debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411466 (https://phabricator.wikimedia.org/T186381) (owner: 10Thcipriani) [21:52:14] Project mwext-phpunit-coverage-publish build #1077: 04FAILURE in 43 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/1077/ [21:52:51] 21:52:13 Cannot open file "/srv/jenkins-workspace/workspace/mwext-phpunit-coverage-publish/src/extensions/Math/tests/phpunit.php". [21:52:55] Yippee, build fixed! [21:52:55] thcipriani ^^ [21:52:55] Project mwext-phpunit-coverage-publish build #1078: 09FIXED in 40 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/1078/ [21:53:02] oh [21:54:15] I know about the Math failure [22:01:40] no_justification https://gerrit-review.googlesource.com/c/gerrit/+/159030 lol some user is trying to spam that [22:21:20] 10Continuous-Integration-Config, 10Security-Team, 10phan-taint-check-plugin, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Patch-For-Review: Make jenkins run phan-taint-check-plugin non-voting and then voting - https://phabricator.wikimedia.org/T182599#3979969 (10Legoktm) [22:32:22] 10Continuous-Integration-Infrastructure, 10Zuul: jenkins no longer starts gate-and-submit when parent is in gate-and-submit pipeline - https://phabricator.wikimedia.org/T186949#3979984 (10hashar) I have failed to notice this task until now. It is most probably related to T187567 , namely the dependent changes... [22:47:11] no_justification i finally got the test done lol [22:47:37] I know this will fail as i didnt test it [22:49:34] 10Continuous-Integration-Infrastructure, 10Zuul: jenkins no longer starts gate-and-submit when parent is in gate-and-submit pipeline - https://phabricator.wikimedia.org/T186949#3980006 (10hashar) 2018-02-09 23:11:47,684 DEBUG zuul.DependentPipelineManager: Checking for changes needed by 10Continuous-Integration-Infrastructure, 10Zuul: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567#3980011 (10hashar) T186949 is an other issue which has the same root cause. [22:50:21] 10Continuous-Integration-Infrastructure, 10Zuul: jenkins no longer starts gate-and-submit when parent is in gate-and-submit pipeline - https://phabricator.wikimedia.org/T186949#3960209 (10hashar) p:05Triage>03High [22:50:39] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Zuul: CI is running against parent patches, not the patches themselves for chained patches - https://phabricator.wikimedia.org/T187567#3980015 (10hashar) [22:50:46] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Zuul: jenkins no longer starts gate-and-submit when parent is in gate-and-submit pipeline - https://phabricator.wikimedia.org/T186949#3960209 (10hashar) [22:51:10] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Zuul: Zuul no longer starts gate-and-submit when parent is in gate-and-submit pipeline - https://phabricator.wikimedia.org/T186949#3960209 (10hashar) [22:51:37] oh yay the test pass :) :) [22:55:57] 10Phabricator: Improve default Maniphest search settings - https://phabricator.wikimedia.org/T187587#3980038 (10Tgr) [22:57:37] 10Phabricator: Improve default Maniphest search settings - https://phabricator.wikimedia.org/T187587#3980048 (10Tgr) (Side note: the non-Maniphest search (top right search bar) does order by relevance, but it doesn't display project tags, making it also useless because more often than not you can't tell what a t... [22:59:06] * paladox works on linkin'fying groups in settings now :) [22:59:44] 10Phabricator (Upstream), 10Upstream: Improve default Maniphest search settings - https://phabricator.wikimedia.org/T187587#3980059 (10Aklapper) > The current default setting for task search is Please provide steps for / URLs to reproduce what you call "default settings". [23:02:09] 10Phabricator (Upstream), 10Upstream: Improve default Maniphest search settings - https://phabricator.wikimedia.org/T187587#3980038 (10mmodell) @tgr: You can set a default search settings, it's a per-user preference. [[ https://secure.phabricator.com/book/phabricator/article/search/#saving-and-sharing-queri |... [23:02:14] 10Phabricator (Upstream), 10Upstream: Improve default Maniphest search settings - https://phabricator.wikimedia.org/T187587#3980077 (10Tgr) https://phabricator.wikimedia.org/maniphest/ Open Phabricator main screen while logged out, click on "Tasks & Bugs". (Or visit a task and click "Maniphest" in the breadcr... [23:03:12] 10Phabricator (Upstream), 10Upstream: Improve default Maniphest search settings - https://phabricator.wikimedia.org/T187587#3980078 (10Tgr) >>! In T187587#3980075, @mmodell wrote: > @tgr: You can set a default search settings, it's a per-user preference. [[ https://secure.phabricator.com/book/phabricator/artic... [23:04:44] 10Phabricator (Upstream), 10Upstream: Improve default Maniphest search settings - https://phabricator.wikimedia.org/T187587#3980081 (10mmodell) The default query in maniphest doesn't use a search keyword so relevance doesn't come into play at all, that's why it's grouped and ordered. [23:14:24] 10Phabricator (Upstream), 10Upstream: Improve default Maniphest search settings - https://phabricator.wikimedia.org/T187587#3980151 (10Tgr) >>! In T187587#3980081, @mmodell wrote: > The default query in maniphest doesn't use a search keyword so relevance doesn't come into play at all, that's why it's grouped a...