[00:00:23] You did already? [00:04:23] Anyhow, done now [00:48:26] api.php seems broken on beta due to some kind of DB deadlock -> T187756 [00:48:26] T187756: LinksUpdate::acquirePageLock deadlocks on beta enwiki - https://phabricator.wikimedia.org/T187756 [01:14:20] Krinkle: oops, "I just..." meant the last time I manually rebuilt the images [02:06:40] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<22.22%) [02:13:41] Project beta-scap-eqiad build #196317: 04FAILURE in 0.38 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/196317/ [02:27:12] Yippee, build fixed! [02:27:12] Project beta-scap-eqiad build #196318: 09FIXED in 3 min 33 sec: https://integration.wikimedia.org/ci/job/beta-scap-eqiad/196318/ [03:14:02] legoktm: ah, okay. the past-tense of deleted confused me, but makes sense now. [03:14:34] I suppose it would've been obvious if I heard it out loud [03:14:35] Hehe [04:16:50] 10Release-Engineering-Team, 10MediaWiki-SWAT-deployments: Proposal: Effective immediately, disallow multi-file or multi-dir patch deployment - https://phabricator.wikimedia.org/T187761#3984680 (10Krinkle) [04:17:07] 10Release-Engineering-Team, 10MediaWiki-SWAT-deployments: Proposal: Effective immediately, disallow multi-sync patch deployment - https://phabricator.wikimedia.org/T187761#3984691 (10Krinkle) [04:29:50] PROBLEM - Free space - all mounts on deployment-mediawiki05 is CRITICAL: CRITICAL: deployment-prep.deployment-mediawiki05.diskspace.root.byte_percentfree (<11.11%) [04:39:48] RECOVERY - Free space - all mounts on deployment-mediawiki05 is OK: OK: All targets OK [04:53:03] 10Release-Engineering-Team (Someday), 10Scap, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, and 5 others: Jobs invoking SiteConfiguration::getConfig cause HHVM to fail updating the bytecode cache due to being filesize limited to 512MBytes - https://phabricator.wikimedia.org/T145819#3984705 (10tstar... [04:57:56] 10Deployments, 10Release-Engineering-Team (Someday), 10Operations, 10Beta-Cluster-reproducible, and 2 others: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7) - https://phabricator.wikimedia.org/T146285#3984714 (10tstarling) >>! In T146285#3827389, @Joe wrote: > @tstarling AIUI... [05:02:19] 10Deployments, 10Release-Engineering-Team (Someday), 10Operations, 10Beta-Cluster-reproducible, and 2 others: Switch mwscript from Zend PHP5 to default php alternative (e.g. HHVM or PHP7) - https://phabricator.wikimedia.org/T146285#3984723 (10Krinkle) [07:01:40] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [07:19:28] (03CR) 10Hashar: [C: 032] "Excellent, thank you :-]" [integration/config] - 10https://gerrit.wikimedia.org/r/412815 (https://phabricator.wikimedia.org/T187310) (owner: 10MarcoAurelio) [07:20:41] (03Merged) 10jenkins-bot: zuul: archive Semantic Page Maker and Wiki Object Model [integration/config] - 10https://gerrit.wikimedia.org/r/412815 (https://phabricator.wikimedia.org/T187310) (owner: 10MarcoAurelio) [08:27:09] RECOVERY - Puppet errors on integration-slave-jessie-1004 is OK: OK: Less than 1.00% above the threshold [0.0] [08:53:07] PROBLEM - Puppet errors on integration-slave-jessie-1004 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [09:10:46] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3984875 (10zeljkofilipin) p:05Triage>03Normal a:03zeljkofilipin [09:26:43] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3984904 (10zeljkofilipin) I was not able to reproduce `Error: Cannot find module ...` error message, but I was able to reproduce `ERROR: unknown erro... [09:38:53] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3984919 (10zeljkofilipin) ``` vagrant@vagrant:/vagrant/mediawiki$ chromium --version Chromium 64.0.3282.119 built on Debian 9.3, running on Debian 9.... [09:41:22] (03PS1) 10Hashar: debian-glue: fix copy of our hooks [integration/config] - 10https://gerrit.wikimedia.org/r/412864 [09:43:23] (03CR) 10Hashar: "recheck" [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411322 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [09:43:42] (03CR) 10Hashar: "Hopefully debian-glue got fixed by:" [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/411322 (https://phabricator.wikimedia.org/T187567) (owner: 10Hashar) [09:44:42] (03CR) 10Hashar: [C: 032] "That fixed cumin and zuul :]" [integration/config] - 10https://gerrit.wikimedia.org/r/412864 (owner: 10Hashar) [09:46:17] (03Merged) 10jenkins-bot: debian-glue: fix copy of our hooks [integration/config] - 10https://gerrit.wikimedia.org/r/412864 (owner: 10Hashar) [10:13:26] PROBLEM - Puppet errors on deployment-imagescaler02 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [10:28:01] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3985011 (10zeljkofilipin) Looks like chromium and chromium-driver packages are not in sync in stretch. :( If I install chromium and chromium-driver... [10:48:06] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3985045 (10zeljkofilipin) I thought this would do the trick, but I still get the same error message. :( ``` apt-get download chromium-driver sudo d... [10:48:24] RECOVERY - Puppet errors on deployment-imagescaler02 is OK: OK: Less than 1.00% above the threshold [0.0] [11:02:03] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3985087 (10zeljkofilipin) I don't think this is needed any more: ``` export PATH=$PATH:/usr/lib/chromium ``` [11:07:27] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3985101 (10zeljkofilipin) >>! In T186724#3953185, @awight wrote: > $ npm run selenium The difference in error messages could be because the first ti... [11:18:51] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3985132 (10zeljkofilipin) This should work: ``` cd /vagrant/mediawiki sudo apt-get install chromium-driver xvfb xvfb-run npm run selenium ``` [11:23:36] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Trouble running selenium tests inside of mediawiki-vagrant - https://phabricator.wikimedia.org/T186724#3985144 (10zeljkofilipin) 05Open>03Resolved I have updated the page. I have tested it and it works fine (on my machine). https://www.mediawiki.o... [11:35:14] (03PS6) 10Reedy: Swap node for jq [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) [11:35:17] (03PS7) 10Reedy: Swap node for jq [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) [11:35:28] (03CR) 10jerkins-bot: [V: 04-1] Swap node for jq [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) (owner: 10Reedy) [11:35:30] (03CR) 10jerkins-bot: [V: 04-1] Swap node for jq [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) (owner: 10Reedy) [11:40:49] (03PS6) 10Hashar: Add php55-compile to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412718 [11:41:04] (03CR) 10Hashar: [C: 032] Add php55-compile to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412718 (owner: 10Hashar) [11:41:29] (03CR) 10Hashar: [C: 04-2] Add php55-compile to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412718 (owner: 10Hashar) [11:41:40] (03CR) 10jerkins-bot: [V: 04-1] Add php55-compile to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412718 (owner: 10Hashar) [11:44:30] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Someday), 10Patch-For-Review, 10User-Addshore, 10Zuul: Upgrade pbr for zuul - https://phabricator.wikimedia.org/T162787#3985165 (10Paladox) Now that we use a shorter version, should we try making it shorter as we doint include the dist... [11:45:41] (03PS7) 10Hashar: Add php55-compile to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412718 [11:45:52] (03CR) 10Hashar: [C: 032] Add php55-compile to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412718 (owner: 10Hashar) [11:47:18] (03Merged) 10jenkins-bot: Add php55-compile to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412718 (owner: 10Hashar) [11:49:54] (03Draft1) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.3) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [11:49:57] (03Draft2) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.3) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [11:50:00] (03PS3) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.3) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [11:50:09] (03CR) 10jerkins-bot: [V: 04-1] Fix support for pbr 1.x (change version to 2.5.1.3) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 (owner: 10Paladox) [11:51:57] (03PS4) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.dev1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [11:52:10] (03CR) 10jerkins-bot: [V: 04-1] Fix support for pbr 1.x (change version to 2.5.1.dev1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 (owner: 10Paladox) [11:52:54] (03PS5) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.dev1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [11:52:57] (03PS6) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.dev1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [11:53:10] (03PS7) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.dev1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [11:53:14] (sorry for spam) [11:53:23] (03CR) 10jerkins-bot: [V: 04-1] Fix support for pbr 1.x (change version to 2.5.1.dev1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 (owner: 10Paladox) [11:54:31] hashar hi, im not sure why jenkins keeps failing on ^^ [11:54:42] i see this [11:54:43] gbp:error: Can't determine upstream version from changelog [11:56:44] (03PS1) 10Hashar: Switch php-compile-php55 to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412887 [11:57:55] (03CR) 10Hashar: [C: 032] Switch php-compile-php55 to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412887 (owner: 10Hashar) [11:59:17] (03Merged) 10jenkins-bot: Switch php-compile-php55 to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412887 (owner: 10Hashar) [12:04:07] (03Abandoned) 10Paladox: Make zuul semver compatible with pbr 1.10.0 [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/328554 (https://phabricator.wikimedia.org/T153877) (owner: 10Paladox) [12:04:19] (03Abandoned) 10Paladox: test: do not merge [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/375836 (owner: 10Paladox) [12:10:45] (03PS1) 10Hashar: Add hhvm-compile jobs on Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412889 [12:14:38] (03CR) 10Hashar: [C: 032] Add hhvm-compile jobs on Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412889 (owner: 10Hashar) [12:17:03] (03Merged) 10jenkins-bot: Add hhvm-compile jobs on Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412889 (owner: 10Hashar) [12:21:35] (03PS8) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [12:21:50] (03CR) 10jerkins-bot: [V: 04-1] Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 (owner: 10Paladox) [12:37:48] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3985227 (10zeljkofilipin) What I did so far: - go to mediawiki-vagrant instances https://horizon... [12:49:43] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, 10User-Elukey: Apache on phab1001 is gradually leaking worker processes which are stuck in "Gracefully finishing" state - https://phabricator.wikimedia.org/T182832#3985257 (10mmodell) I posted this upstream: https://dis... [13:07:39] 10Phabricator, 10WMSE-Bug-Reporting-and-Translation-2018: Trying to import workboard for some projects give error 400 - https://phabricator.wikimedia.org/T186189#3985319 (10Lokal_Profil) 05Open>03Invalid I've looked through our other projects and I can't find any still missing boards. It's unclear to me wh... [13:12:57] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3985341 (10zeljkofilipin) The same steps as above, but creating [[ https://horizon.wikimedia.org/... [13:13:00] (03PS1) 10Hashar: Promote php-compile-hhvm jobs on wikidiff2 [integration/config] - 10https://gerrit.wikimedia.org/r/412897 [13:18:12] (03PS1) 10Hashar: Promote php-compile-hhvm jobs on luasandbox [integration/config] - 10https://gerrit.wikimedia.org/r/412899 [13:19:36] (03CR) 10jerkins-bot: [V: 04-1] Promote php-compile-hhvm jobs on luasandbox [integration/config] - 10https://gerrit.wikimedia.org/r/412899 (owner: 10Hashar) [13:20:12] (03PS1) 10Hashar: Remove php-compile-hhvm and php-compile-hhvm-test [integration/config] - 10https://gerrit.wikimedia.org/r/412900 [13:20:39] (03CR) 10Hashar: [C: 032] Promote php-compile-hhvm jobs on wikidiff2 [integration/config] - 10https://gerrit.wikimedia.org/r/412897 (owner: 10Hashar) [13:21:23] (03PS2) 10Hashar: Promote php-compile-hhvm jobs on luasandbox [integration/config] - 10https://gerrit.wikimedia.org/r/412899 [13:21:49] (03Merged) 10jenkins-bot: Promote php-compile-hhvm jobs on wikidiff2 [integration/config] - 10https://gerrit.wikimedia.org/r/412897 (owner: 10Hashar) [13:22:23] (03CR) 10jerkins-bot: [V: 04-1] Remove php-compile-hhvm and php-compile-hhvm-test [integration/config] - 10https://gerrit.wikimedia.org/r/412900 (owner: 10Hashar) [13:25:04] (03CR) 10Hashar: [C: 032] Promote php-compile-hhvm jobs on luasandbox [integration/config] - 10https://gerrit.wikimedia.org/r/412899 (owner: 10Hashar) [13:25:12] (03PS2) 10Hashar: Remove php-compile-hhvm and php-compile-hhvm-test [integration/config] - 10https://gerrit.wikimedia.org/r/412900 [13:26:12] (03Merged) 10jenkins-bot: Promote php-compile-hhvm jobs on luasandbox [integration/config] - 10https://gerrit.wikimedia.org/r/412899 (owner: 10Hashar) [13:30:04] (03CR) 10Hashar: [C: 032] Remove php-compile-hhvm and php-compile-hhvm-test [integration/config] - 10https://gerrit.wikimedia.org/r/412900 (owner: 10Hashar) [13:31:21] (03Merged) 10jenkins-bot: Remove php-compile-hhvm and php-compile-hhvm-test [integration/config] - 10https://gerrit.wikimedia.org/r/412900 (owner: 10Hashar) [14:00:57] (03PS1) 10Awight: Add tests for Extension:JADE [integration/config] - 10https://gerrit.wikimedia.org/r/412915 [14:05:32] (03PS1) 10Hashar: Migrate jenkins-plugin-jdk7-jessie to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412917 [14:12:58] (03CR) 10Hashar: [C: 032] Add tests for Extension:JADE [integration/config] - 10https://gerrit.wikimedia.org/r/412915 (owner: 10Awight) [14:14:07] (03Merged) 10jenkins-bot: Add tests for Extension:JADE [integration/config] - 10https://gerrit.wikimedia.org/r/412915 (owner: 10Awight) [14:14:17] hashar: Thanks! [14:27:14] awight: it is deployed now :) [14:28:27] magical pixie dust: applied. [14:30:22] hashar hi, im wondering if you could take a look at why this is failing https://gerrit.wikimedia.org/r/412884 please? [14:30:42] we can finally fix the pbr problem now that we do not need to include the dist name in the version :) [14:35:07] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10Patch-For-Review, and 2 others: Apache on phab1001 is gradually leaking worker processes which are stuck in "Gracefully finishing" state - https://phabricator.wikimedia.org/T182832#3985661 (10mmodell) [14:39:57] (03PS9) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [14:40:07] (03CR) 10jerkins-bot: [V: 04-1] Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 (owner: 10Paladox) [14:41:42] 10Phabricator, 10Release-Engineering-Team, 10Operations, 10User-Elukey: Phabricator down due to "Failed to `proc_open()`: proc_open() expects parameter 2 to be array" - https://phabricator.wikimedia.org/T186620#3985688 (10mmodell) @elukey: I'm working on it. I'll create separate tasks for each actionable,... [14:41:45] (03PS10) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [14:41:54] (03CR) 10jerkins-bot: [V: 04-1] Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 (owner: 10Paladox) [14:42:23] (03PS11) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [14:42:34] (03CR) 10jerkins-bot: [V: 04-1] Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 (owner: 10Paladox) [14:42:41] PROBLEM - Puppet errors on deployment-imagescaler01 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [14:44:26] PROBLEM - Puppet errors on deployment-imagescaler02 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [14:46:38] (03PS12) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [14:46:48] (03CR) 10jerkins-bot: [V: 04-1] Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 (owner: 10Paladox) [14:46:58] hmm [14:50:15] (03PS13) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [14:51:27] (03PS2) 10Hashar: Migrate jenkins-plugin-jdk7-jessie to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412917 [14:59:41] (03PS14) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1.1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [15:01:26] hashar yay [15:01:31] i got it working with pbr 1 [15:01:36] root@jenkins-slave-01:/home/paladox# zuul --version [15:01:36] Zuul version: 2.5.1.dev-1 [15:02:16] (03PS15) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1-1.gbpbbb92b) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 [15:02:42] (03PS16) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1-1.gbpbbb92b) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 (https://phabricator.wikimedia.org/T162787) [15:06:39] (03PS17) 10Paladox: Fix support for pbr 1.x (change version to 2.5.1-1.wmf1) [integration/zuul] (debian/jessie-wikimedia) - 10https://gerrit.wikimedia.org/r/412884 (https://phabricator.wikimedia.org/T162787) [15:06:45] 10Diffusion, 10Cloud-Services, 10Community-Tech-Tool-Labs, 10labs-sprint-119: Figure out a git hosting solution for tools/kubernetes - https://phabricator.wikimedia.org/T117071#3985835 (10Liuxinyu970226) [15:07:02] 10Diffusion, 10Community-Tech-Tool-Labs, 10Toolforge, 10labs-sprint-119: Figure out a git hosting solution for tools/kubernetes - https://phabricator.wikimedia.org/T117071#1766048 (10Liuxinyu970226) [15:08:16] Project mwext-phpunit-coverage-publish build #1244: 04FAILURE in 22 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/1244/ [15:09:04] hashar when you get a chance could you review https://gerrit.wikimedia.org/r/412884 please? [15:09:10] python-mock requires pbr 1.3+ [15:09:28] which python-conftool depends on another python package which depends on python-mock [15:09:34] thus breaking stretch. [15:10:28] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10User-Elukey, 10Wikimedia-Incident: Phabricator: Clean up deadlocked apache processes - https://phabricator.wikimedia.org/T187790#3985850 (10mmodell) p:05Triage>03High [15:10:47] (03PS3) 10Hashar: Migrate jenkins-plugin-jdk7-jessie to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412917 [15:16:16] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10User-Elukey, 10Wikimedia-Incident: Phabricator: Clean up deadlocked apache processes - https://phabricator.wikimedia.org/T187790#3985875 (10elukey) I'd personally just restart apache2 once every week in a low-traffic time of the day rath... [15:18:13] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10User-Elukey, 10Wikimedia-Incident: Phabricator: Clean up deadlocked apache processes - https://phabricator.wikimedia.org/T187790#3985884 (10mmodell) Every week would leave a ton of resources tied up in the mean time - those processes are... [15:19:23] RECOVERY - Puppet errors on deployment-imagescaler02 is OK: OK: Less than 1.00% above the threshold [0.0] [15:20:27] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10User-Elukey, 10Wikimedia-Incident: Phabricator: Clean up deadlocked apache processes - https://phabricator.wikimedia.org/T187790#3985898 (10elukey) I would proceed with the simplest solution first, then see how it goes and refine if need... [15:22:40] RECOVERY - Puppet errors on deployment-imagescaler01 is OK: OK: Less than 1.00% above the threshold [0.0] [15:22:57] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: selenium-EXTENSION-jessie Jenkins job should have e-mail notification - https://phabricator.wikimedia.org/T185315#3985912 (10zeljkofilipin) p:05Triage>03Normal a:03zeljkofilipin [15:23:49] 10Release-Engineering-Team (Kanban), 10releng-201718-q1, 10MediaWiki-General-or-Unknown, 10Epic, and 5 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3985916 (10zeljkofilipin) p:05High>03Normal a:05zeljkofilipin>03None [15:24:38] 10Release-Engineering-Team (Kanban), 10releng-201718-q1, 10MediaWiki-General-or-Unknown, 10Epic, and 4 others: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740#3751361 (10zeljkofilipin) [15:27:45] PROBLEM - Puppet errors on deployment-redis01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:28:15] (03CR) 10Hashar: [C: 032] Migrate jenkins-plugin-jdk7-jessie to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412917 (owner: 10Hashar) [15:28:23] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3985928 (10zeljkofilipin) [15:29:41] (03Merged) 10jenkins-bot: Migrate jenkins-plugin-jdk7-jessie to Docker [integration/config] - 10https://gerrit.wikimedia.org/r/412917 (owner: 10Hashar) [15:29:47] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10User-Elukey, 10Wikimedia-Incident: Phabricator: Clean up deadlocked apache processes - https://phabricator.wikimedia.org/T187790#3985939 (10mmodell) Well, that really depends on how you define "needed." The proposed script is definitely... [15:30:24] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3853760 (10zeljkofilipin) [15:31:58] (03PS1) 10Zfilipin: selenium-EXTENSION-jessie Jenkins job e-mail notification [integration/config] - 10https://gerrit.wikimedia.org/r/412931 (https://phabricator.wikimedia.org/T185315) [15:33:42] PROBLEM - Puppet errors on deployment-redis02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:34:57] (03CR) 10Zfilipin: "DCausse, EBernhardson, Jdlrobson, Phuedx: let me know if you or somebody else should be added/removed from the list." [integration/config] - 10https://gerrit.wikimedia.org/r/412931 (https://phabricator.wikimedia.org/T185315) (owner: 10Zfilipin) [15:56:24] 10Release-Engineering-Team (Kanban), 10MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), 10Patch-For-Review, 10User-zeljkofilipin: Q3 Selenium framework improvements - https://phabricator.wikimedia.org/T182421#3986082 (10zeljkofilipin) [15:56:26] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10User-zeljkofilipin, 10Wikimedia-Incident: Create selenium-core-jessie daily Jenkins job - https://phabricator.wikimedia.org/T185011#3986081 (10zeljkofilipin) [15:57:25] legoktm: I managed to migrate the php compile jobs for php5.5 and hhvm [15:57:31] yay :) [15:57:33] legoktm: at the expanse of dirty hack for hhvm [15:57:36] but that is good enough :D [15:57:36] oh? [15:57:49] luasandbox requires to use a wrapper instead of just make test [15:57:55] so I have just hardcoded that in the compiler [15:57:58] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.21 deployment blockers - https://phabricator.wikimedia.org/T183960#3986087 (10mmodell) 05Open>03Resolved [15:58:06] also locally luasandbox failed on stretch but passed on jessie [15:58:09] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10User-zeljkofilipin: Update page object pattern in Selenium tests - https://phabricator.wikimedia.org/T185094#3905855 (10zeljkofilipin) a:03zeljkofilipin [15:58:15] but that does not happen on CI ;] [15:58:32] legoktm: long story short: all php compile jobs are on docker! [15:58:33] ah, I see [15:58:35] yay :) [15:58:43] -f luasandbox.so [15:58:46] heh :) [15:58:50] :) [15:59:15] hashar i've been running that change on my test instance :) [15:59:19] I will keep migrating what is left on Nodepool until we are left with jobs requiring mediawiki [15:59:29] paladox: \o/ :) [16:00:25] hashar http://gerrit-jenkins.wmflabs.org/job/composer-gerrit-test/77/console [16:00:27] works too [16:00:32] http://gerrit-test.wmflabs.org/gerrit/#/c/testing/test/+/1068/ [16:00:38] (still supports pbr 0.8) [16:02:11] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban): Migrate leftover Nodepool jobs to Docker - https://phabricator.wikimedia.org/T187797#3986123 (10hashar) [16:02:22] it has -wmf1 at the end, but at least pbr 1.10 is supported. [16:02:30] so we won't have any more outages i doin't think :) [16:10:21] 10Release-Engineering-Team, 10MediaWiki-SWAT-deployments: Proposal: Effective immediately, disallow multi-sync patch deployment - https://phabricator.wikimedia.org/T187761#3986157 (10demon) [16:10:42] paladox: zuul/pbr I am unlikely to look at it any time soon [16:10:49] oh [16:11:04] I am focusing on migrating stuff to Docker [16:11:31] 10Release-Engineering-Team, 10MediaWiki-SWAT-deployments: Proposal: Effective immediately, disallow multi-sync patch deployment - https://phabricator.wikimedia.org/T187761#3984680 (10demon) (removed `sync-dir` references in description since it's just a deprecated back-compat alias to `sync-file`) [16:12:07] ok [16:14:10] 10Release-Engineering-Team, 10MediaWiki-SWAT-deployments: Proposal: Effective immediately, disallow multi-sync patch deployment - https://phabricator.wikimedia.org/T187761#3986178 (10demon) I agree with this proposal. In fact, let's just go ahead and make this Official™ -- all we'd need to do is make some doc... [16:17:16] Yippee, build fixed! [16:17:17] Project mwext-phpunit-coverage-publish build #1245: 09FIXED in 1 min 55 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/1245/ [16:22:38] (03CR) 10Legoktm: [C: 04-1] "Can you restore the composer-dev-args.js script and delete it in a follow-up change? Otherwise I think CI will be broken in the period of " [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) (owner: 10Reedy) [16:23:33] (03PS8) 10Reedy: Swap node for jq [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) [16:24:02] (03CR) 10jerkins-bot: [V: 04-1] Swap node for jq [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) (owner: 10Reedy) [16:26:32] (03PS2) 10Reedy: Swap a nodejs oneliner to jq [integration/config] - 10https://gerrit.wikimedia.org/r/395100 (https://phabricator.wikimedia.org/T181938) (owner: 10Hashar) [16:26:56] (03CR) 10Reedy: "recheck" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) (owner: 10Reedy) [16:30:31] (03PS1) 10Reedy: Remove composer-dev-args.js [integration/jenkins] - 10https://gerrit.wikimedia.org/r/412944 [16:32:26] (03CR) 10Reedy: "Done. Rebased the dependant patch too" [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) (owner: 10Reedy) [16:36:16] Reedy: I'll try and deploy it in a few hours [16:36:22] whee :) [16:36:33] is jq everywhere we need it to be, as far as we know? [16:40:19] all the mw jobs are on nodepool, and I checked last night that it has it [16:50:18] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10User-zeljkofilipin: Update page object pattern in Selenium tests - https://phabricator.wikimedia.org/T185094#3986431 (10zeljkofilipin) [17:08:19] (03CR) 10Phuedx: [C: 031] selenium-EXTENSION-jessie Jenkins job e-mail notification [integration/config] - 10https://gerrit.wikimedia.org/r/412931 (https://phabricator.wikimedia.org/T185315) (owner: 10Zfilipin) [17:23:59] 10Release-Engineering-Team (Kanban), 10releng-201718-q3, 10Epic, 10RelEng FY201718 Q2 Goals: FY2017/18 Program 3 Outcome 1 Objective 2: Identify and find stewards for high-priority/high use code segment orphans - https://phabricator.wikimedia.org/T174091#3986645 (10Jrbranaa) First pass of stewardship revie... [17:38:00] Hi, I'm trying to deploy RESTBase to beta cluster and scap fails with the following log "deploy-local failed: {}" - is that a klnown issue or it deserves a ticket? [17:39:58] cc thcipriani ^^ [17:40:29] * thcipriani checks [17:40:43] 10Scap, 10Services (watching): RESTBase deployment fails in beta cluster - https://phabricator.wikimedia.org/T187815#3986712 (10Pchelolo) [17:43:04] I've actually went ahead and created a ticket [17:44:10] thank you! [17:45:48] ah, I think I see what's happening. My new patch set is failing in the case that there are checks in an environment overriding other checks. [17:46:42] since all the checks are empty for restbase in beta. [17:46:45] ok, fix incoming. [17:53:56] great, thank you thcipriani [18:03:46] hrm now phab just needs to acknowledge that I landed the commit... [18:11:34] Pchelolo: should be fixed in beta with scap 3.8.0-1~20180220180531.294. I updated deployment-tin and deployment-restbase0{1,2} so they have that version of scap now. [18:19:10] no_justification we may want to update its-phabricator to include this https://gerrit-review.googlesource.com/c/plugins/its-base/+/150250 fix. [18:19:46] I'll get back to you on it. I'm afk [18:19:59] ok [18:21:20] Probably yes, but want to review it 😊 [18:24:21] ok [18:24:41] no_justification it fixes something that only became a problem in gerrit 2.14 it seems. though this issue was in 2.13. [18:25:37] unless event.submitter managed to be allowed to be null in 2.14. [18:26:27] We did get a bunch of NPEs on comments going back to at least early 2.13 [18:26:40] oh [18:26:40] So if it fixes that I'm thrilled [18:27:09] im hopping it does. i at least doin't get null pointers any more in the logs. (but you never know in prod :)) [18:28:15] no_justification also on another note, i implemented your feature request here https://gerrit-review.googlesource.com/c/gerrit/+/160034 :) [18:28:21] you led me to finding other bugs too [18:28:45] no_justification there was a big bug that was undiscovered until i found it over the weekend. [18:29:51] Hidden bugs are fun [18:39:22] PROBLEM - Puppet errors on deployment-mx is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:40:46] no_justification heh. [18:41:00] no_justification it was all caused by the singleusergroup plugin. [18:43:16] no_justification though you also led me to javascript bugs in polygerrit. [18:45:39] no_justification looks like upstream may change the way gitiles links are shown https://bugs.chromium.org/p/gerrit/issues/detail?id=8367#c7 :) [18:46:29] Wheeee. [18:46:39] I'm glad. The current links aren't intuitive [18:49:30] no_justification also its-base is getting updated to support per project config files [18:49:30] https://gerrit-review.googlesource.com/c/plugins/its-base/+/160316 [19:09:48] Oooh, that's kinda cool. So if $some_project used something other than Phab, they could :) [19:09:52] (not that we'd encourage it, lol) [19:10:21] 10Phabricator, 10Wikimedia-Site-requests: Create a form for site requests - https://phabricator.wikimedia.org/T139844#3987037 (10MarcoAurelio) Ping. Except for my objections above, is there anything else remaining to do here? [19:12:27] 10Release-Engineering-Team (Kanban), 10Scap, 10Services (watching): RESTBase deployment fails in beta cluster - https://phabricator.wikimedia.org/T187815#3987040 (10thcipriani) 05Open>03Resolved a:03thcipriani This should be resolved by scap version 3.8.0-1~20180220180531.294 which is available on beta... [19:14:06] no_justification yeh [19:14:56] no_justification they are also adding support for mutiple servers see https://gerrit-review.googlesource.com/c/plugins/its-base/+/148715 [19:15:00] (in its-base) [19:17:19] no_justification oh, you can configure the server to use in project.config if that ^^ is merged. so basically, you could have phab + other trackers. [19:26:35] Does beta have a terbium equivalent? [19:26:38] I can't actually see one.. [19:35:56] Reedy: no [19:36:08] it's all deployment-tin [19:36:27] btw, how do you look for servers? [19:36:36] horizon [19:36:39] https://github.com/wikimedia/puppet/blob/3f2eacb05f1de7afcea1604b2e41492175fbabe1/modules/profile/manifests/mediawiki/maintenance.pp#L18-L40 [19:36:45] aha [19:36:47] All those should probably be on beta somewhere [19:37:23] purge abusefilter I'm running it manually whenever I remember because there's no cronjob [19:37:26] I opened a task [19:37:40] purge checkuser not needed as there's no checkuser on beta [19:37:47] well, that doesn't matter so much [19:37:58] It can just error out and fail [19:38:06] the script will fail that^ [19:38:12] Not worth refactoring it out to that extent [19:38:27] I'm wondering where the hell we can get cron jobs for beta run [19:38:42] so far, I've been shouting in the desert [19:38:55] Either put them on deployment-tin, or we create a deployment-terbium [19:39:31] cron on deployment-tin? [19:39:45] I guess crontab -e won't work [19:39:58] Well, we'd get puppet to put them there [19:40:03] Otherwise that kinda defeats the point [19:41:40] !log maurelio@deployment-tin:~$ foreachwikiindblist all-labs.dblist extensions/AbuseFilter/maintenance/purgeOldLogIPData.php [19:41:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:42:17] 217 rows cleaned [19:42:37] shall I attempt to run the generate captcha one or is not straightforward? [19:42:54] You need wordlists [19:42:57] They don't exist on tin [19:43:02] So you won't get very far [19:43:58] https://github.com/wikimedia/puppet/blob/68c39bc68d3ead808d2cca8ac3d9a6af361ee3c9/modules/mediawiki/manifests/maintenance/generatecaptcha.pp#L10-L24 [19:44:21] https://github.com/wikimedia/puppet/blob/df0bb775798316cde02ddfbbabd7e8bf239e3199/modules/mediawiki/manifests/maintenance/generatecaptcha.pp [19:44:40] If I remember correctly, beta does have a couple of dummy lists in the "private" puppet repo for it [19:45:48] greg-g: Any thoughts whether we should just make deployment-tin run the production cron jobs? Or should we create a deplomyment-terbium? [19:46:21] ideally the later but ugh [19:46:27] heh [19:46:49] mwscript extensions/TorBlock/maintenance/loadExitNodes.php --wiki=aawiki --force > /dev/null', <-- what that does actually do? [19:47:21] shoves them in memcached IIRC [19:47:51] dinner, bbl [19:52:08] 10Beta-Cluster-Infrastructure: Create mediawiki::maintenance server (ala terbium) in deployment-prep - https://phabricator.wikimedia.org/T187826#3987182 (10Reedy) [19:52:23] 10Beta-Cluster-Infrastructure: Create mediawiki::maintenance server (ala terbium) in deployment-prep - https://phabricator.wikimedia.org/T187826#3987193 (10Reedy) [19:52:25] 10Beta-Cluster-Infrastructure, 10Operations, 10Puppet: Setup cron for foreachwikiindblist all-labs.dblist extensions/AbuseFilter/maintenance/purgeOldLogIPData.php on Beta - https://phabricator.wikimedia.org/T187658#3987192 (10Reedy) [20:05:29] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Operations, 10User-Elukey, 10Wikimedia-Incident: Phabricator: Clean up deadlocked apache processes - https://phabricator.wikimedia.org/T187790#3987225 (10Dzahn) re: "simplest solution first" i would suggest we just do systemctl apache2 restart also... [20:09:19] there's deployment-mira heh [20:39:00] PROBLEM - Puppet errors on deployment-mediawiki07 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:40:24] Reedy: ^^ ? -- what that means? [20:40:30] and how to fix them :) [20:40:39] ? [20:40:49] puppet broke [20:40:52] PROBLEM - Puppet errors on deployment-mediawiki07 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:40:57] Or more likely, the puppetmaster died [20:40:59] Wait and see [20:41:11] I'd like to know how to fix those [20:41:32] Depends what's actually wrong [20:43:51] (03PS3) 10Krinkle: Swap a nodejs oneliner to jq [integration/config] - 10https://gerrit.wikimedia.org/r/395100 (https://phabricator.wikimedia.org/T181938) (owner: 10Hashar) [20:44:02] (03PS4) 10Krinkle: Swap a nodejs oneliner to jq [integration/config] - 10https://gerrit.wikimedia.org/r/395100 (https://phabricator.wikimedia.org/T181938) (owner: 10Hashar) [20:44:26] (03CR) 10Legoktm: [C: 032] Swap node for jq [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) (owner: 10Reedy) [20:44:35] :D [20:44:46] ohai Krinkle [20:45:04] (03PS9) 10Legoktm: Swap node for jq [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) (owner: 10Reedy) [20:45:34] (03CR) 10Legoktm: [C: 032] "I dropped the dependency since we're not dependent upon it anymore with splitting the removal of composer-dev-args to a separate patch." [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) (owner: 10Reedy) [20:45:39] MERGE ALL THE THINGS [20:46:25] (03PS2) 10Krinkle: Remove composer-dev-args.js [integration/jenkins] - 10https://gerrit.wikimedia.org/r/412944 (owner: 10Reedy) [20:46:28] (03Merged) 10jenkins-bot: Swap node for jq [integration/jenkins] - 10https://gerrit.wikimedia.org/r/394856 (https://phabricator.wikimedia.org/T181938) (owner: 10Reedy) [20:47:05] legoktm: Hi, sorry about that :) [20:47:14] :p [20:47:50] !log mwscript extensions/TorBlock/maintenance/loadExitNodes.php --wiki=deploymentwiki --force [20:47:56] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:48:00] https://integration.wikimedia.org/zuul/ civicrm has a really long patch stack [20:50:10] !log refreshing nodepool image: nodepool@labnodepool1001:~$ nodepool image-update wmflabs-eqiad snapshot-ci-jessie [20:50:16] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:50:32] I forgot to start that in a screen...I hope it keeps going [20:50:35] ctrl+c doesn't seem to work [20:57:15] !log Refreshed tor exit node lists for all Beta Cluster wikis [20:57:22] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:05:50] (03PS1) 10Paladox: Modify access rules [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/413005 [21:06:30] 21:01:58 [21:06:30] 21:01:58 [21:06:30] 21:01:58 [21:06:51] this is gonna be fun [21:07:47] (03CR) 10Krinkle: "Why? Only the change owner and project maintainers (those with +2) should modify a person's change. What is the use case for rebasing some" [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/413005 (owner: 10Paladox) [21:08:02] Krinkle because cherry pick is basically rebase :) [21:08:39] paladox: Cherry-pick for creating new changes in a different branch. They get a new change number, and the actor gets assinged as uploader. [21:08:50] Krinkle you can cherry pick to the same branch [21:08:51] If cherry-pick allows rebasing an existing change, that is an upstream bug you should report to Gerrit. [21:08:54] I am aware of that. [21:08:56] so basically creating a rebase [21:09:07] But that is not a reason to enforce it, it is a reason to fix it :) [21:09:35] Does it even matter? I could just rebase locally and upload over your patch anyways [21:09:39] Please don't amend or rebase other user's changes. [21:09:45] legoktm: No, only project owners can do that. [21:09:55] E.g. +2 or change owner. [21:09:59] I'm pretty sure anyone can edit anyone's changes. [21:10:03] Nope. [21:10:09] Unless that was enabled in the last 3 months. [21:10:16] Which would be a Bad Idea (TM) [21:10:42] Krinkle gerrit has always done that since the version inline edit came in [21:10:55] e.g. https://gerrit.wikimedia.org/r/#/c/120811/ [21:11:05] owner is different from the person currently updating the patch [21:15:47] It was changed in https://gerrit.wikimedia.org/r/plugins/gitiles/All-Projects/+/7186790c0e27eb3923d6bdd24ea1e5d65df3b3ef [21:15:53] During a Gerrit upgrade in late 2016 [21:15:56] That's unfortunate. [21:16:24] Krinkle that would be when we went from 2.12 to 2.13 [21:16:46] Krinkle also why is that unfortunate? [21:16:47] Thanks for making me aware, now I have to go back into 2 years of changes and make sure I didn't accidentally re-approve a modified PS where I trusted the author and co-maintainers but not the 1000s other random accounts that were able to make changes at any point. [21:16:51] We should be more open? [21:17:21] It is a process violation. You can't do this on GitHub either. A change proposal is a personal sandbox owned by the author, that can only be amended by the author or a merger. [21:17:31] This isn't related to being open. you can still fork my patch and re-upload it under our own name. [21:17:39] That's open. [21:21:26] paladox: Can you compare https://gerrit.wikimedia.org/r/#/c/407755/ (mw/core) and https://gerrit.wikimedia.org/r/#/c/411560/ (categoryTree) and see if both look the same to you? E.g. ability to remove reviewer or do inline edits? [21:21:54] Krinkle: I think you're overreacting a bit [21:22:03] Krinkle i can do inline edit's. But i carn't remove reviewers. [21:22:20] Krinkle also you can tell if some edited the change with the Uploader: piece shown on the change [21:23:15] paladox: are you sure cherry pick to same branch and/or inline edit on https://gerrit.wikimedia.org/r/#/c/411560/ still works? [21:23:31] Krinkle yes. [21:24:54] legoktm: I really am not overreacting. No CR system allows this by default, it's a massive process violation, and certainly not beneficial in any meaningful way. Gerrit is a big enough detriment to our productivity and code quality as it is (you can only spend your energy once). I really don't want to have to verify whenever I get around to +2'ing a change yesterday that some new spam account hasn't made some hard to spot [21:24:54] modifications to it. It's insane. [21:25:20] It's only possible because of how Gerrit stores changes as unnamespaced branches, unlike GitHub, but the principle should be the same. [21:25:33] Just look at the diff between patches [21:25:49] if author == committer you're safe [21:25:55] Plus it shows you who made the changes [21:25:58] Just check the usernames [21:26:03] ^^ [21:26:10] Yes, I can recursively check everything everytime, but like I said: Trust and productivity. [21:26:16] It is pretty beneficial in that people can adopt other peoples changes, like the one I linked early [21:26:18] earlier* [21:26:29] ^^ [21:26:49] It's not really a productivity loss given I (and I would assume most people) check this already - mostly to prevent people from accidentally commiting things while updating an old patch [21:26:52] It's trivial to download and re-upload for the rare occasion a change from a registered user is changing ownership to another registered user. [21:27:13] * legoktm class -> bbl [21:27:26] And besides, it woudl still show the original author as creator, which messes with various other assumptions we have. [21:27:30] Krinkle if you want, you could create a trusted group if you feel that would be better. But i think this feature should be open, as we doint get much spam. [21:27:32] I always close changes when they change owner. [21:28:22] I disabled the add-patch-set right on that repo as experiment but apparently it doesn't work. Restricting it to "Change Owner & Project Owner" should've worked but apparently it doesn't. [21:28:50] At least for the smaller repos I maintain I don't have time to mess with this, I'd prefer disabling it, if it's even possible, unless that's another bug. [21:32:47] Krinkle i think its because you have to deny the reigstered group access [21:33:07] [x] Exclusive should fix that. According to the manual. [21:50:20] legoktm: Is it worth changing PHPUnit_TextUI_Command for its namespaced version? witha class_exists [21:51:05] Reedy: I think we have to right? [21:51:16] Not gonna get much further [21:51:21] * Reedy starts making some changes [21:52:37] Krinkle: I think opening an RfC for this is the way to go forward if you feel strongly. But starting to change project ACLs is probably going to be disruptive. [21:53:00] I think this happens more frequently than you expect (but that's just based on my own anecdotal experiences as well) [21:53:58] legoktm: I agree. I've reverted my experiment. But to be fair, it was massively more disruptive that this hole was opened up by a Gerrit upgrade, without an RFC, either. It was apparently in the release notes, but maybe we missed that and/or didn't mind. [21:54:18] if ( class_exists( 'PHPUnit_TextUI_Command' ) ) { [21:54:18] $textUICommand = new PHPUnit_TextUI_Command(); [21:54:18] } else { [21:54:18] $textUICommand = new PHPUnit\TextUI\Command(); [21:54:18] } [21:54:21] or.. [21:54:28] Do we want to $class = 'some string' [21:54:31] new $class() [21:54:38] https://gerrit-documentation.storage.googleapis.com/Documentation/2.13/access-control.html#category_add_patch_set [21:59:26] Reedy: I like the former [21:59:41] Just looking what to do in phpunit.php [21:59:51] Which allows you to pass in a parameter to set the class :/ [21:59:57] Ah, actually [22:12:20] Reedy: so https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-jessie/19698/console still says PHPUnit 4... [22:12:52] the phan one was def using PHP 6 [22:12:59] yeah, that's 7.0 [22:13:05] legoktm: Is that because of that repo where we commit PHPunit? [22:13:10] no... [22:13:53] 21:14:55 - Installing phpunit/phpunit (4.8.36) [22:14:14] What version of php does hhvm 3.18 think it is? [22:15:09] hphpd> echo PHP_VERSION [22:15:09] echo PHP_VERSION [22:15:10] 5.6.99-hhvm [22:15:28] legoktm: So it's going to, isn't it? [22:15:37] PHPUnit 5 PHP 5.6, PHP 7.0, PHP 7.1 [22:15:48] PHPUnit 6 doesn't support PHP 5.6 [22:22:59] hrmmm [22:24:39] Yeah, unless we enable php7 mode in HHVM, which is broken. [22:24:58] HHVM's default mode is to pretend to be PHP 5.6, but whilst at the same time already enabling virtually all PHP7 features. [22:25:09] It's not completely broken, is it? [22:25:18] I'm sure PHPUnit 6 works under HHVM 3.18 [22:25:26] but composer won't give it to it [22:25:41] heh [22:25:49] I suspect you'd be right, yeah [22:26:13] can we enable php 7 mode on the cli using an argument just to run composer? :P [22:26:34] Or we can use php7 for the install step [22:26:37] :) [22:26:42] actual php7 [22:26:58] heh [22:27:10] or maybe there's a way to ignore the platform requirements and then before install modify .json to only list ^6 [22:27:13] I thinkthat exists [22:27:24] Anyway, have fun :) [22:28:28] btw, is there a task for having Jenkins-bot link to CLI of phan and/or to have non-errors be included in the style report? [22:28:41] THe current situation of "phan fails, see https://integration.wikimedia.org/ci/job/mediawiki-core-php70-phan-docker/5662/checkstyleResult/ " where said link shows 0 errors is less than useful :( [22:29:12] Ah, there's https://phabricator.wikimedia.org/T180630 [22:31:37] 10Continuous-Integration-Config: Default link by jenkins-bot on Gerrit for mediawiki-core-php70-phan-docker does not show failures - https://phabricator.wikimedia.org/T180630#3987588 (10Krinkle) [22:33:38] 10Continuous-Integration-Config: Default link by jenkins-bot on Gerrit for mediawiki-core-php70-phan-docker does not show failures - https://phabricator.wikimedia.org/T180630#3764103 (10Krinkle) I thought this was about a distinction between "errors" and "warnings". The CheckStyle report talks about "0 warnings"... [22:35:54] (03PS1) 10Krinkle: Disable custom 'checkstyleResult' failure link for phan jobs [integration/config] - 10https://gerrit.wikimedia.org/r/413060 (https://phabricator.wikimedia.org/T180630) [22:38:37] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Migrate operations-mw-config-composer-hhvm-jessie to Docker - https://phabricator.wikimedia.org/T186145#3987600 (10Reedy) [22:38:42] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban): Swap node for jq in mw-fetch-composer-dev.sh - https://phabricator.wikimedia.org/T181938#3987597 (10Reedy) 05Open>03Resolved a:03Reedy [22:39:02] 10Continuous-Integration-Infrastructure: mw-fetch-composer-dev.sh/composer-dev-args.js is too naive with value handling - https://phabricator.wikimedia.org/T181937#3987601 (10Reedy) 05Open>03Resolved a:03Reedy [22:46:02] Grrr [22:46:08] Why is it still trying to use hte old class [22:54:51] legoktm: Do we know if it's running the phpunit from vendor? [23:06:01] legoktm: https://github.com/wikimedia/mediawiki-tools-phan/blob/master/composer.json#L18 [23:23:27] 22:45:36 PHP Fatal error: Declaration of MediaWikiTestCase::run(PHPUnit_Framework_TestResult $result = NULL) must be compatible with PHPUnit\Framework\Test::run(PHPUnit\Framework\TestResult $result = NULL) in /home/jenkins/workspace/mediawiki-phpunit-php70-jessie/src/tests/phpunit/MediaWikiTestCase.php on line 17 [23:24:35] A lot of these changes aren't backwards compatible... [23:29:50] 10Beta-Cluster-Infrastructure, 10Beta-Cluster-reproducible: Getting 400 errors while trying to open a page with VE in Beta cluster - https://phabricator.wikimedia.org/T187837#3987667 (10Ryasmeen) [23:30:18] 10Beta-Cluster-Infrastructure, 10Beta-Cluster-reproducible: Getting 400 error while trying to open a page with VE in Beta cluster - https://phabricator.wikimedia.org/T187837#3987677 (10Ryasmeen) [23:36:38] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10MediaWiki-Vagrant, 10User-zeljkofilipin: Continuous integration for mediawiki-vagrant - https://phabricator.wikimedia.org/T183456#3987689 (10bd808) The failure to download the `debian/stretch64` base image is something I have s...