[00:40:12] 10Project-Admins: Create the user-physikerwelt personal project - https://phabricator.wikimedia.org/T188855#4021861 (10Aklapper) 05Open>03Resolved a:03Aklapper Requested public project #User-Physikerwelt has been created: https://phabricator.wikimedia.org/project/view/3272/ Please encourage interested peo... [00:40:20] 10Phabricator (Upstream), 10Upstream: Per-user projects for personal work in progress tracking - https://phabricator.wikimedia.org/T555#1756843 (10Aklapper) [01:04:22] Krinkle: https://gerrit.wikimedia.org/r/#/c/416618/ [01:05:17] (mmm I could also bug someone else with that... sorry for the bother) [01:10:07] 10Gerrit: In PolyGerrit change UI, do not display single-option "More" button - https://phabricator.wikimedia.org/T188964#4025657 (10Smalyshev) [03:43:49] !log Jenkins postmerge queue has 'beta-scap-eqiad' and 'beta-update-databases-eqiad' stuck "Waitinf for execute" for over 3h [03:43:55] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [04:08:02] $ sync scap-file; error; $ scap scap-file; error; scap sync-file; works [04:08:05] Oops :) [04:48:31] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [10.0] [04:58:29] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 60.00% of data above the critical threshold [10.0] [05:10:57] PROBLEM - Puppet errors on deployment-aqs01 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [05:45:55] RECOVERY - Puppet errors on deployment-aqs01 is OK: OK: Less than 1.00% above the threshold [0.0] [06:59:44] James_F: I think you normally create these? https://phabricator.wikimedia.org/T181310#4026143 but we should ideally automate this... :/ [08:50:09] PROBLEM - Puppet errors on integration-slave-jessie-1004 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [08:50:59] PROBLEM - Puppet errors on integration-slave-jessie-1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [09:37:28] legoktm: Meh, sorry, had that in the back of my mind to do. [09:42:22] legoktm: Done through to wmf.30. [09:54:31] (03PS4) 10Hashar: Polling job for MediaWiki doxygen [integration/config] - 10https://gerrit.wikimedia.org/r/415588 (https://phabricator.wikimedia.org/T115755) [10:05:49] PROBLEM - Free space - all mounts on deployment-mediawiki04 is CRITICAL: CRITICAL: deployment-prep.deployment-mediawiki04.diskspace.root.byte_percentfree (<11.11%) [10:15:47] RECOVERY - Free space - all mounts on deployment-mediawiki04 is OK: OK: All targets OK [10:24:31] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [10.0] [10:44:30] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [11:17:54] 10Gerrit, 10Commons, 10MediaWiki-Special-pages, 10Multimedia, and 3 others: Special:Upload prepending "== {{int:filedesc}} ==" twice (Commons) - https://phabricator.wikimedia.org/T187302#4026511 (10TheDJ) > there is no community consensus on Wikimedia Commons that every image page should start with " {{int... [11:24:56] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Find a few people interested in reviewing Selenium patches - https://phabricator.wikimedia.org/T188744#4026537 (10zeljkofilipin) @Niedzielski, @dcausse: just checking if your subscription/token to this task is "I'm mildly interested" or "SUBSCRIBE šŸ“¬" šŸ˜‰ [11:27:00] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Find a few people interested in reviewing Selenium patches - https://phabricator.wikimedia.org/T188744#4026540 (10dcausse) @zeljkofilipin I'm interested but I don't consider myself a very knowledgeable developer for this kind of reviews, I'd be happy t... [11:33:16] Project mwext-phpunit-coverage-publish build #1808: 04FAILURE in 43 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/1808/ [11:35:29] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [10.0] [11:55:31] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [11:58:48] 10Gerrit: Bring diffusion links back - https://phabricator.wikimedia.org/T187439#4026591 (10MarcoAurelio) 05Open>03declined Per T187149; let's see how that develops. [12:11:33] Yippee, build fixed! [12:11:33] Project mwext-phpunit-coverage-publish build #1809: 09FIXED in 59 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/1809/ [12:31:14] (03PS1) 10Thiemo Kreuz (WMDE): Use Thiemos changed legal name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416669 [12:31:40] (03PS1) 10Hashar: Run Doxygen for MediaWiki tags [integration/config] - 10https://gerrit.wikimedia.org/r/416670 [12:31:48] (03Abandoned) 10Hashar: Run Doxygen for MediaWiki tags [integration/config] - 10https://gerrit.wikimedia.org/r/416670 (owner: 10Hashar) [12:31:52] 10Release-Engineering-Team, 10MediaWiki-extensions-Other, 10User-MarcoAurelio: Add mediawiki/extensions/NamespaceSidebar to mediawiki/extensions - https://phabricator.wikimedia.org/T188940#4026683 (10MarcoAurelio) 05Open>03Resolved a:03MarcoAurelio https://gerrit.wikimedia.org/r/#/c/416661/ [12:37:14] (03PS5) 10Hashar: Polling job for MediaWiki doxygen [integration/config] - 10https://gerrit.wikimedia.org/r/415588 (https://phabricator.wikimedia.org/T115755) [12:38:02] (03CR) 10jerkins-bot: [V: 04-1] Polling job for MediaWiki doxygen [integration/config] - 10https://gerrit.wikimedia.org/r/415588 (https://phabricator.wikimedia.org/T115755) (owner: 10Hashar) [12:38:51] (03PS6) 10Hashar: Polling job for MediaWiki doxygen [integration/config] - 10https://gerrit.wikimedia.org/r/415588 (https://phabricator.wikimedia.org/T115755) [12:39:25] (03CR) 10Hashar: [C: 032] "I have spent enough time on that one. It is good enough for now." [integration/config] - 10https://gerrit.wikimedia.org/r/415588 (https://phabricator.wikimedia.org/T115755) (owner: 10Hashar) [12:39:58] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10releng-201718-q4, 10Patch-For-Review: Migrate leftover Nodepool jobs to Docker - https://phabricator.wikimedia.org/T187797#4026694 (10hashar) [12:40:00] 10Continuous-Integration-Infrastructure, 10Zuul: Find a way to deduplicate post-merge builds like mediawiki-core-doxygen-publish - https://phabricator.wikimedia.org/T94715#4026695 (10hashar) [12:40:04] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure (Little Steps Sprint), 10Release-Engineering-Team (Kanban), 10Patch-For-Review: Rewrite mediawiki-core-doxygen-publish Jenkins job to poll scm instead of being triggered by Zuul - https://phabricator.wikimedia.org/T115755#4026692 (10ha... [12:40:36] (03Merged) 10jenkins-bot: Polling job for MediaWiki doxygen [integration/config] - 10https://gerrit.wikimedia.org/r/415588 (https://phabricator.wikimedia.org/T115755) (owner: 10Hashar) [12:41:00] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10releng-201718-q4, 10Patch-For-Review: Migrate leftover Nodepool jobs to Docker - https://phabricator.wikimedia.org/T187797#3986123 (10hashar) [13:24:23] (03CR) 10Hashar: [C: 032] Use Thiemos changed legal name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416669 (owner: 10Thiemo Kreuz (WMDE)) [13:31:20] (03Merged) 10jenkins-bot: Use Thiemos changed legal name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416669 (owner: 10Thiemo Kreuz (WMDE)) [13:31:53] (03CR) 10jenkins-bot: Use Thiemos changed legal name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416669 (owner: 10Thiemo Kreuz (WMDE)) [13:53:59] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Find a few people interested in reviewing Selenium patches - https://phabricator.wikimedia.org/T188744#4026992 (10Niedzielski) Sure @zeljkofilipin! I'd be especially interested to help with the web team's repos, although, like David, I'm not as experie... [14:02:38] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4027035 (10Lucas_Werkmeister_WMDE) The first instance of that ā€œmust be an instance of `ApiMain`ā€ error in `EntityContentFactory` is at 13:46 UTC, so a bit before... [14:04:25] PROBLEM - puppet last run on contint2001 is CRITICAL: CRITICAL: Catalog fetch fail. Either compilation failed or puppetmaster has issues [14:21:54] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4027092 (10Lucas_Werkmeister_WMDE) ``` #0 /srv/mediawiki/php-master/extensions/Wikibase/repo/Wikibase.php(250): MWExceptionHandler::handleError(integer, string,... [14:29:25] RECOVERY - puppet last run on contint2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [14:42:38] (03PS1) 10Thiemo Kreuz (WMDE): Utilize convenient addContentBefore() in LeadingZeroInFloatSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416689 [14:43:49] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4027264 (10Lucas_Werkmeister_WMDE) > it looks to me like `$wgApiModules['wbsearchentities']['factory']` (`Wikibase.php` L250) was somehow registered as a content... [14:45:03] (03PS1) 10Thiemo Kreuz (WMDE): Use faster array_key_exists instead of in_array in 2 sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416690 [14:45:14] (03PS1) 10Thiemo Kreuz (WMDE): Use faster strcasecmp() instead of strtolower() for comparisons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416691 [14:45:41] (03PS1) 10Thiemo Kreuz (WMDE): Consistently use @inheritDoc on all Sniff::register() methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416692 [14:46:01] (03PS1) 10Thiemo Kreuz (WMDE): Remove not needed "@return void" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416693 [14:46:27] (03PS1) 10Thiemo Kreuz (WMDE): Specify "@return void" on all Sniff::process() methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416694 [14:46:42] (03PS1) 10Thiemo Kreuz (WMDE): Remove comments describing a File object as a "File object" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416695 [14:50:27] (03PS1) 10Thiemo Kreuz (WMDE): Use strict, type-safe === and !== comparisons everywhere [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416696 [14:56:50] (03CR) 10jerkins-bot: [V: 04-1] Remove comments describing a File object as a "File object" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416695 (owner: 10Thiemo Kreuz (WMDE)) [15:27:45] PROBLEM - Puppet errors on deployment-redis01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:32:27] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10User-zeljkofilipin: Investigate replacing nodemw with mwbot - https://phabricator.wikimedia.org/T181284#4027419 (10zeljkofilipin) Created pull request with license file: https://github.com/Fannon/mwbot/pull/12 [15:33:42] PROBLEM - Puppet errors on deployment-redis02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:44:57] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4027545 (10Lucas_Werkmeister_WMDE) So I temporarily added a few debug statements (only long enough for me to make one web request, then removed again immediately... [15:45:59] 10Gerrit, 10Wikimedia-Incident: In Gerrit set receive.rejectImplicitMerges = True in All-Projects - https://phabricator.wikimedia.org/T189024#4027555 (10hashar) [15:49:06] 10Gerrit, 10Wikimedia-Incident: In Gerrit set receive.rejectImplicitMerges = True in All-Projects - https://phabricator.wikimedia.org/T189024#4027555 (10Paladox) Can this be set in project.config though? Looking at the name of it, it seems it is a gerrit.config variable. [15:49:27] 10Gerrit, 10Wikimedia-Incident: In Gerrit set receive.rejectImplicitMerges = True in All-Projects - https://phabricator.wikimedia.org/T189024#4027584 (10hashar) That is to set `receive.rejectImplicitMerges` in Gerrit to prevent it from magically merging the master branch into a wmf branch. Typically happens on... [15:52:33] 10Gerrit, 10Wikimedia-Incident: In Gerrit set receive.rejectImplicitMerges = True in All-Projects - https://phabricator.wikimedia.org/T189024#4027596 (10Paladox) Ah found it https://gerrit-review.googlesource.com/#/c/gerrit/+/85854/1/project.config [15:53:24] (03Draft1) 10Paladox: Set receive.rejectImplicitMerges to true in project.config [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416704 [15:53:26] (03PS2) 10Paladox: Set receive.rejectImplicitMerges to true in project.config [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416704 (https://phabricator.wikimedia.org/T189024) [15:55:36] (03CR) 10Hashar: [C: 031] "That is what I have in mind. I would let Chad checks whether that is correct :]" [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416704 (https://phabricator.wikimedia.org/T189024) (owner: 10Paladox) [15:56:42] 10Gerrit, 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Wikimedia-Incident: In Gerrit set receive.rejectImplicitMerges = True in All-Projects - https://phabricator.wikimedia.org/T189024#4027632 (10hashar) [16:17:23] 10Gerrit, 10ORES, 10Operations, 10Scoring-platform-team, 10Patch-For-Review: Plan migration of ORES repos to git-lfs - https://phabricator.wikimedia.org/T181678#4027714 (10Halfak) [16:45:52] 10Continuous-Integration-Infrastructure, 10Front-end-Standards-Group, 10MediaWiki-extensions-General: Decide whether we want the package-lock.json to commit or ignore - https://phabricator.wikimedia.org/T179229#4027794 (10Jdforrester-WMF) There's now a non-trivial reason to prefer having these in git, albeit... [17:15:25] 10Gerrit: mediawiki/extensions repo broken: "Server does not allow request for unadvertised object 41f3316732949b9a97cd36f3d1a603ae076dddbd" - https://phabricator.wikimedia.org/T189031#4027884 (10matmarex) [17:20:42] 10Continuous-Integration-Infrastructure (shipyard), 10Release-Engineering-Team (Kanban), 10releng-201718-q4, 10Patch-For-Review: Migrate leftover Nodepool jobs to Docker - https://phabricator.wikimedia.org/T187797#4027922 (10hashar) Tyler and I had a chat about migrating the /deploy repositories to Blubber... [17:21:13] 10Gerrit, 10BlueSpice: mediawiki/extensions repo broken: "Server does not allow request for unadvertised object 41f3316732949b9a97cd36f3d1a603ae076dddbd" - https://phabricator.wikimedia.org/T189031#4027926 (10Reedy) [17:24:07] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4027930 (10Addshore) This is starting to sound like some sort of odd beta issue, it feels like something is cached somewhere? I also wonder if the version of hvv... [17:26:25] 10Gerrit, 10BlueSpice: mediawiki/extensions repo broken: "Server does not allow request for unadvertised object 41f3316732949b9a97cd36f3d1a603ae076dddbd" - https://phabricator.wikimedia.org/T189031#4027884 (10Paladox) Try git submodule sync https://github.com/AppImage/AppImageKit/issues/511 [17:31:00] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4027997 (10Lucas_Werkmeister_WMDE) > I also wonder if the version of hvvm is the same on beta on production. Good question. Special:Version reports the same str... [17:38:12] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4024243 (10thcipriani) >>! In T188924#4027930, @Addshore wrote: > This is starting to sound like some sort of odd beta issue, it feels like something is cached s... [17:48:20] Would anyone be able to spend a couple of minutes helping me to understand/debug a Gerrit issue? Specifically, I am trying to push to a review that was opened by someone else, and am being told that I'm not allowed to...not sure if it's me/my permissions, something about the review, or if I'm just messing something up. [17:59:45] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4028134 (10Lucas_Werkmeister_WMDE) Would you be willing to proceed with group0 without knowing whether this bug will occur there or not, as @Addshore suggested,... [18:00:14] marlier hi, not sure what you mean? Do you mean uploading a change to someone elses? [18:00:56] And link the patch [18:01:51] paladox: Yep -- ` ! [remote rejected] HEAD -> refs/publish/master/oversample-test (cannot add patch set to 416627.)` (This is a change to the NavigationTiming extension, originally uploaded by Timo, which I modified and am attempting to update: https://gerrit.wikimedia.org/r/#/c/416627/) [18:01:59] marlier aha [18:02:10] refs/publish/master/oversample-test sounds like a change edit? [18:02:40] I don't know? [18:03:08] What command are you running? [18:03:23] `git review -R` [18:03:32] Per https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_(your_own_or_someone_else's) [18:03:43] shouldn't need -R (lol bug 1) [18:04:54] ^^ [18:05:01] But that shouldn't cause the problem either [18:05:05] Same output when I run without -R [18:05:26] i doin't think we allow refs/publish/ though i will check [18:06:12] It could be that git review just got set up weird, for some reason. [18:06:18] marlier is this for aha [18:06:20] aha [18:06:23] found it [18:06:28] Reedy marlier [18:06:32] https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/NavigationTiming,access [18:06:40] where it says "Add Patchset" [18:06:51] it's blank with exclusive [18:07:09] meaning someone purposely is denying anyone editing other users changes. [18:07:18] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/NavigationTiming/+/6af8bb1b1bd8390cc07a0928afd22a2c417a685a%5E%21/#F0 [18:07:35] Or it was just setup badly [18:07:43] Reedy see link :) [18:07:51] Aye, I think the issue here is that it seems marlier is not in mediawiki/* [18:08:03] That inherits from ldap/wmf [18:08:16] Krinkle i doint think so [18:08:22] you set exclusive on Add Patchset [18:08:26] thus overiding things [18:09:05] paladox: Thanks, but If I recall correctly, we apply the same exclusive flag to other permissions in All-Projects default, and that works fine. [18:09:24] Removing the restriction entirely will naturally make it work, but that is somewhat besides the point. [18:10:08] marlier: When you press "Reply.." on https://gerrit.wikimedia.org/r/#/c/416627/, do you see Code-Review +1/+2 as options? [18:12:06] Krinkle "Revoking this permission (by granting it to no groups and setting the "Exclusive" flag) will prevent users from uploading a patch set to a change they do not own." [18:12:12] https://gerrit-review.googlesource.com/Documentation/access-control.html#category_add_patch_set [18:12:16] Krinkle: I do, yes. [18:13:41] paladox: "Change Owner and Project Owner will always be able to amend the patch, regardless of this setting." [18:13:45] That's from a previous version of the documentation. [18:13:49] Looks like that changed. [18:13:58] well change owner [18:14:38] marlier: OK. Try pushing for review again? [18:14:57] Worked that time! [18:15:25] OK. So this was my bad :) I tested out a new setting 2 weeks ago, and apparently it's not working as advertised, but the docs have been adjusteed to match reality in the last release. [18:15:40] Krinkle the docs havent changed though :). [18:15:44] according too https://github.com/GerritCodeReview/gerrit/commits/master/Documentation/access-control.txt [18:18:59] paladox: There have been over 50 changes in the last 3 releases one of which are are not running in prod yet. Did you check all changes? [18:19:14] Krinkle yeh, i checked in the 2.14 branch [18:20:09] Krinkle https://github.com/GerritCodeReview/gerrit/commits/stable-2.14/Documentation/access-control.txt [18:21:26] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Blubber should support python/tox - https://phabricator.wikimedia.org/T186545#4028195 (10dduvall) 05Open>03Resolved [18:21:44] paladox: Hm.. you're right :) I was thinking of the edit change *topic* documentation I think. https://github.com/GerritCodeReview/gerrit/blob/596f3643a49cb1e8568ac1c79996f21284be267c/Documentation/access-control.txt#L847 [18:21:56] I misread that to apply the same to other edit permissions. [18:21:58] Good to know :) [18:22:02] ah, heh [18:23:54] paladox: Reedy: Krinkle: Thanks much -- I appreciate the help! [18:24:24] your welcome :) [18:34:28] !log deployed to beta: [mobileapps/deploy@5986ab7]: Update mobileapps to afbe9af [18:34:34] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:39:22] PROBLEM - Puppet errors on deployment-mx is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:41:08] Reedy or no_justification, could I get a review of https://gerrit.wikimedia.org/r/#/c/416607/ (and help with merging/applying) when you have some spare time? [18:41:51] (03PS1) 10DCausse: Add search/analysis-extra to jenkins [integration/config] - 10https://gerrit.wikimedia.org/r/416743 [18:43:01] (03CR) 10jerkins-bot: [V: 04-1] Add search/analysis-extra to jenkins [integration/config] - 10https://gerrit.wikimedia.org/r/416743 (owner: 10DCausse) [18:43:31] (03PS2) 10DCausse: Add search/analysis-extra to jenkins [integration/config] - 10https://gerrit.wikimedia.org/r/416743 [18:45:03] (03CR) 10jerkins-bot: [V: 04-1] Add search/analysis-extra to jenkins [integration/config] - 10https://gerrit.wikimedia.org/r/416743 (owner: 10DCausse) [18:48:10] (03PS3) 10DCausse: Add search/analysis-extra to jenkins [integration/config] - 10https://gerrit.wikimedia.org/r/416743 [18:50:07] (03CR) 10DCausse: "test patch: https://gerrit.wikimedia.org/r/#/c/415788/" [integration/config] - 10https://gerrit.wikimedia.org/r/416743 (owner: 10DCausse) [18:50:22] andrewbogott: I'm out sick today [18:50:34] oh no! feel better :) [18:51:48] 10Scap, 10Operations, 10Packaging: Install git-lfs client (at least on scap targets & masters) - https://phabricator.wikimedia.org/T180628#4028393 (10mmodell) [18:52:07] I'll leave a quick comment at least. [18:52:16] (generally your changes look ok) [18:56:57] twentyafterfour is the repo in gerrit? :) [18:58:57] 10Scap, 10Operations, 10Packaging: Install git-lfs client (at least on scap targets & masters) - https://phabricator.wikimedia.org/T180628#4028541 (10mmodell) @akosiaris: What would it take to get the git-lfs package back-ported to stretch? It's written in go, however, I am unsure if it will work with the ve... [19:02:50] andrewbogott: Comment left. Mostly fine. Just one point of clarification [19:02:59] thank you! [19:03:27] yw [19:08:36] no_justification: get well soon [19:09:54] Ty. I hope to be back tomorrow [19:10:12] * no_justification goes to take a nap [19:26:41] PROBLEM - Free space - all mounts on deployment-tin is CRITICAL: CRITICAL: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found)deployment-prep.deployment-tin.diskspace._srv.byte_percentfree (<10.00%) [19:29:13] no_justification also get better soon too :) [19:31:56] !log maurelio@deployment-tin:~$ foreachwiki extensions/AbuseFilter/maintenance/purgeOldLogIPData.php [19:32:01] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:32:32] (03Draft1) 10Paladox: Add lfs to research/ores/wheels [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416756 [19:32:37] (03PS2) 10Paladox: Increase lfs resources on research/ores/wheels to 50gb [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416756 (https://phabricator.wikimedia.org/T188446) [19:34:40] !log maurelio@deployment-tin:~$ foreachwiki extensions/TorBlock/maintenance/loadExitNodes.php --force [19:34:46] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [19:37:30] twentyafterfour https://gerrit.wikimedia.org/r/#/c/416756/ :) [19:38:14] (03CR) 1020after4: [C: 032] "I think we have enough storage for this?" [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416756 (https://phabricator.wikimedia.org/T188446) (owner: 10Paladox) [19:43:30] (03Draft1) 10Paladox: Disable lfs on research/ores/wheels [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416758 [19:43:32] (03PS2) 10Paladox: Disable lfs on research/ores/wheels [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416758 (https://phabricator.wikimedia.org/T188446) [19:43:55] (03CR) 10Paladox: [V: 032 C: 032] "(Self merging as it is disabling lfs per request)" [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416758 (https://phabricator.wikimedia.org/T188446) (owner: 10Paladox) [19:44:07] hmm carn't seem to submit [19:44:16] twentyafterfour wondering if you could submit ^^ please? [19:44:22] (03Abandoned) 10Paladox: Increase lfs resources on research/ores/wheels to 50gb [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416756 (https://phabricator.wikimedia.org/T188446) (owner: 10Paladox) [19:45:31] (03CR) 10Chad: [V: 032 C: 032] "Fine I guess" [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416704 (https://phabricator.wikimedia.org/T189024) (owner: 10Paladox) [19:45:39] thanks no_justification :) [19:53:33] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [10.0] [19:54:37] guys, EQUIAD ip flooding testwikidata with crap [19:54:47] ntegration-slave-jessie-1002.integration.eqiad.wmflabs [19:55:00] https://test.wikidata.org/wiki/Special:Contributions/10.68.16.199 [19:59:08] hasharDinner / legoktm and Krinkle -- I've blocked 10.68.16.199 on test.wikidata; looks like an integration thing misconfigured creating bunch of nonsense at test.wikidata [19:59:28] WHOIS says it is integration-slave-jessie-1002.integration.eqiad.wmflabs [20:00:27] history goes back to 2017; in case what the IP is doing is right, please let me know [20:00:48] heh now it's "Selenium user" [20:01:23] 10Gerrit, 10BlueSpice: mediawiki/extensions repo broken: "Server does not allow request for unadvertised object 41f3316732949b9a97cd36f3d1a603ae076dddbd" - https://phabricator.wikimedia.org/T189031#4028968 (10matmarex) 05Open>03Invalid @Paladox Thanks, that solved it! I wonder why it broke, although that'... [20:02:29] 10Gerrit, 10BlueSpice: mediawiki/extensions repo broken: "Server does not allow request for unadvertised object 41f3316732949b9a97cd36f3d1a603ae076dddbd" - https://phabricator.wikimedia.org/T189031#4028973 (10Paladox) your welcome :) [20:05:15] 10Continuous-Integration-Config: integration-slave-jessie-1002.integration.eqiad.wmflabs editting under 10.68.16.199 on test.wikidata - https://phabricator.wikimedia.org/T189047#4028984 (10MarcoAurelio) [20:08:30] PROBLEM - Mediawiki Error Rate on graphite-labs is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [10.0] [20:13:14] 10Gerrit, 10ORES, 10Operations, 10Scoring-platform-team, 10Patch-For-Review: Plan migration of ORES repos to git-lfs - https://phabricator.wikimedia.org/T181678#4029020 (10awight) We're currently thinking that we want to normalize our repo locations in gerrit, and introduce git-lfs in the new locations.... [20:18:33] Hauskatze: please unblock it. That is integration tests for Wikibase [20:19:17] Hauskatze: that is going to cause some test suite to fail and cause headhaches to WMDE developers. They rely on those tests to ensure wikidata is working :] [20:20:15] (03PS1) 10Paladox: Modify access rules [scoring/ores/assets] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416760 [20:20:20] (03CR) 10Paladox: [V: 032 C: 032] Modify access rules [scoring/ores/assets] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416760 (owner: 10Paladox) [20:23:10] 10Continuous-Integration-Config, 10StructuredDiscussions, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10SQLite: Flow does not depend upon Echo in CI - https://phabricator.wikimedia.org/T185608#4029059 (10jmatazzoni) [20:24:04] hasharDinner: did unblocked it after filing a task, was blocked for ~5 minutes [20:24:18] Selenium user appeared instantly to continue with that [20:24:23] more or less [20:24:49] we though it was a spambot or some sort of crap-generator [20:25:24] dinner time [20:26:55] 10Gerrit, 10ORES, 10Operations, 10Patch-For-Review, 10Scoring-platform-team (Current): Plan migration of ORES repos to git-lfs - https://phabricator.wikimedia.org/T181678#4029065 (10awight) [20:28:32] The jenkins-bot check to check if there is a bug mentioned in the header of a commit message is buggy, it detects Bugzilla mentions as bug mentions, so you can't fix bugs in bugzilla module without triggering the bug-detection :) [20:30:58] mutante: Guten Tag. May you fill a task against #commit-message-validator https://phabricator.wikimedia.org/project/view/2163/ ? :) [20:31:20] mutante: the source code being in integration/commit-message-validator.git [20:31:25] I am not familiar with that code though [20:32:23] hasharDinner: Guten Abend. Klar, dann mache ich da ein Ticket auf. [20:32:37] it's going to be extremely rare to trigger this bug :) [20:32:49] because "who would touch bugzilla-static" :) [20:33:29] hasharDinner wondering could you submit https://gerrit.wikimedia.org/r/416760 please? [20:35:05] phabricator reboot is coming. very short downtime [20:38:21] pfff [20:38:31] paladox: I am fed up with the gerrit repos creations really [20:38:50] hasharDinner oh why? [20:38:54] scoring/ores/assets [20:39:01] PROBLEM - Puppet errors on deployment-mediawiki07 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:39:03] there is no scoring/ores nor any scoring/ parent repo :d [20:39:16] but I guess we can instead inherit rights from research/ores [20:39:18] yeh, see https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests [20:39:23] also this was discussed in -ai [20:39:33] or ask them to create the repo under research/ores maybe [20:39:43] this way they would inherit rights automatically [20:39:59] awight halfak ^^ [20:40:16] so eg they need a parent repo [20:40:37] ah [20:40:44] probably want to first create scoring/ [20:40:50] make them a owner of it [20:41:03] then a parent scoring/ores [20:41:07] and create all the others under that [20:41:09] (03PS1) 10Paladox: Modify access rules [scoring/ores/assets] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416766 [20:41:20] hasharDinner: Thanks for the help. It can wait until tomorrow, donā€™t spoil yr dinner! [20:41:37] hasharDinner done https://gerrit.wikimedia.org/r/416766 [20:41:54] or we could drop the scoring/ entirely [20:41:59] and just use ores/XXX ores/VVV [20:42:10] phab is back [20:42:15] thanks mutante [20:42:22] (since probably "scoring" team will disapear/get renamed over the next two years or so :] when ores is probably going to stick around :] [20:42:43] hasharDinner: We want the scoring/ root path, cos weā€™ll have things other than ā€œoresā€, but itā€™s a valid argument that we might want ores/ as the top-level. [20:42:46] halfak: ^ [20:43:00] there is no good policy really :] [20:43:35] there is also a research/ores repo hehe [20:43:40] and mediawiki/services/ores [20:45:19] awight: or just stick to the good old mediawiki/services/ores :] [20:46:13] paladox: something that would be very nice is to migrate https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests to a Phabricator form so we could handle those in Phabricator :] [20:46:24] hashar there is [20:46:40] hashar: We were discussing in #wikimedia-ai, and this path change makes sense to our team. I hadnā€™t considered bare ā€œores/ā€œ, though. Waiting for halfak to take a look at your suggestion. [20:46:43] hashar https://phabricator.wikimedia.org/maniphest/task/edit/form/1/ [20:47:07] paladox: well it misses all the boiler plate :] [20:47:09] ā€œmediawikiā€ isnā€™t right, because ORES isnā€™t just a MediaWiki service, and ā€œresearchā€ isnā€™t right because it isnā€™t owned by the research team [20:47:13] oh [20:47:24] awight: want me to join that channel ? [20:47:28] awight maybe ores/* [20:47:31] ores/assets [20:47:35] ores/wheel [20:47:38] etc? :) [20:47:39] hashar: FYI, the main justification for creating new repos at all is that we need to experiment with git-lfs, without breaking our current reposā€¦ [20:47:40] we have systems other than ores [20:47:46] awight: so yeah probably ores/ would be simpler [20:47:47] e.g. wikilabels and jade [20:47:49] and revscoring [20:48:08] ahhh E_TOO_MANY_REPOS [20:48:09] :D [20:48:10] Would be OK, but it seems like the style is more like "analytics/kafka-herpderp" [20:48:22] okkk [20:48:32] so lets stick to your initial proposal and use scoring/ [20:48:41] paladox: I will create the scoring and scoring/ores repos [20:48:51] hashar: +1 cool, thank you for asking the difficult question, though :-] [20:48:51] hashar ok [20:49:02] awight: oh I am just running in circles :D [20:49:19] lol as long as nobody bites their own tail [20:49:21] awight: where would the actual ores code be? [20:49:33] simply scoring/ores ? [20:49:38] The main deployment repo for ores is planned to be in scoring/ores/deploy [20:50:11] ores :( would be scoring/ores/ores, but AFAIK we arenā€™t planning to host that in gerrit. Currently the main ORES repo is in github, and itā€™s mirror to Diffusion for production deployment. [20:50:28] *mirrored [20:51:34] well that is going to deploy from scoring/ores/deploy [20:51:45] I dont think we can accept to deploy from a github mirrored repo [20:51:49] +1 [20:51:50] but that is a different topic [20:52:05] If you want, take a look at our currently deployment root, mediawiki/services/ores/deploy [20:52:05] so yeah gonna create scoring and scoring/ores as parent repos [20:52:14] That has submodules which are hosted in Phab [20:52:22] Apparently that was approved by security [20:52:27] +1 that itā€™s strange. [20:52:32] !log refreshing spoofuser on beta [20:52:37] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:53:11] paladox: awight: and would we use the Gerrit group "research-ores" as the owner? https://gerrit.wikimedia.org/r/#/admin/groups/1166,members [20:53:22] +1 [20:53:23] hashar you can :) [20:54:43] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4029118 (10Lucas_Werkmeister_WMDE) Well, test.wikidata.org seems to be on .24 now and no breakage to be seen so farā€¦ [20:55:00] 10Diffusion, 10Gerrit, 10Patch-For-Review: Commits merged in Gerrit should appear near-instantly in Phabricator - https://phabricator.wikimedia.org/T183792#4029119 (10Legoktm) 05Open>03declined Sure. [20:55:58] 10Beta-Cluster-Infrastructure, 10Operations: Beta cluster Obama page often responds with 503 - https://phabricator.wikimedia.org/T188913#4029124 (10Niedzielski) BC continues to be very slow. 503s appear to always emit from deployment-cache-text04 deployment-cache-text04: ``` Request from 73.252.38.252 via dep... [20:56:29] (03PS1) 10Paladox: Modify access rules [scoring/ores/assets] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416769 [20:56:33] !log gerrit: created scoring/ parent project with owner being research-ores ( https://gerrit.wikimedia.org/r/#/admin/projects/scoring,access ) [20:56:33] hashar ^^ [20:56:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:59:19] !log gerrit: created scoring/ores/draftquality scoring/ores/drafttopic scoring/ores/articlequality scoring/ores/editquality scoring/ores/deploy all inherit permissions from scoring/ores itself inheriting from scoring/ [20:59:25] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:59:32] !log gerrit: changed scoring/ores/assets parent permission group to scoring/ores [20:59:38] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:59:40] (03Abandoned) 10Paladox: Modify access rules [scoring/ores/assets] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416769 (owner: 10Paladox) [20:59:50] (03Abandoned) 10Paladox: Modify access rules [scoring/ores/assets] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416760 (owner: 10Paladox) [20:59:59] (03Abandoned) 10Paladox: Modify access rules [scoring/ores/assets] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416766 (owner: 10Paladox) [21:00:02] awight: paladox all the repositories are created. They are inheriting rights from scoring/ores which itself inherits from scoring/ repo [21:00:11] hashar :) [21:00:13] awight: paladox: and research-ores group is an owner (or should be) [21:00:52] paladox: sorry for the patch review. it is just easier to do it directly in the graphical interface :] [21:01:00] hashar yep :) [21:01:23] awight: halfak: paladox: for git-lfs I have no idea how to enable it / set the quota. twentyafterfour / no_justification would know about it [21:01:32] hashar /me knows how to enable it [21:01:36] :) [21:01:37] https://gerrit.wikimedia.org/r/#/admin/projects/?filter=scoring%252F ! [21:01:47] you should be able to fill descriptions for each of them [21:02:28] twentyafterfour: about? [21:02:45] hashar: what can/should be done https://gerrit.wikimedia.org/r/#/c/416511/ and similar? [21:02:51] chasemp: yo [21:03:20] (03Draft1) 10Paladox: enable lfs on scoring/ores/* [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416775 [21:03:22] (03Draft2) 10Paladox: enable lfs on scoring/ores/* [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416775 [21:03:24] hashar https://gerrit.wikimedia.org/r/#/c/416775/ [21:03:25] twentyafterfour: you, me and andrew b are the only folks usng the CST_awake_hours time settings in icinga, we were goign to loosen it a bit instead of 9 am to start at 7 [21:03:26] * twentyafterfour doesn't know anything about git-lfs in gerrit [21:03:36] do you want me to make a new group for that? [21:03:42] or are you cool w/ trying it? [21:03:42] twentyafterfour https://gerrit.wikimedia.org/r/#/c/416775/ :) [21:03:53] 9 is pretty late to be considered "awake" hours for us [21:03:53] twentyafterfour: It just works ;-) [21:03:54] Volker_E: argh that is annoying :/ The job just timed out after 30 minutes [21:03:59] chasemp: it controls paging? I'm ok with being paged at 7am [21:04:03] twentyafterfour: ack [21:04:14] (03PS3) 10Paladox: enable lfs on scoring/ores/* [All-Projects] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416775 [21:04:18] Volker_E: I guess it ran on an overloaded instance which caused it to be to slow. [21:04:31] * twentyafterfour is usually still awake at 7am [21:04:32] lol [21:04:35] :D [21:04:41] didn't want to sneak that in on you [21:04:49] seemed like a crappy trick to pull...:) [21:05:08] Volker_E: seems chrome times out somehow :( [21:05:14] twentyafterfour did you reboot phabricator in labs? (just wondering) [21:05:25] icinga2 is sending notifications that it cannot connect [21:06:44] actually puppet-phabricator seems down [21:07:53] hmm someone shut down puppet-phabricator [21:08:33] Volker_E: I guess you can +2 it again [21:08:59] twentyafterfour we need a per project puppetmaster to test puppet changes [21:09:01] Volker_E: but surely we should make it faster ( https://integration.wikimedia.org/ci/job/oojs-ui-npm-run-jenkins-node-6-docker/buildTimeTrend ) [21:09:06] like for phabricator-stretch1 [21:09:12] and also it includes a mailing fix [21:09:34] otherwise ops are going to get angry at me again for the spam it sends to root [21:10:44] anyway it is gaming time [21:16:22] 10Continuous-Integration-Config, 10Release-Engineering-Team, 10GitHub-Mirrors, 10Repository-Admins: Set up CI and github sync for new extra-analysis repo - https://phabricator.wikimedia.org/T188686#4029142 (10TJones) @dcausse set up the CI here: https://gerrit.wikimedia.org/r/#/c/416743/ [21:18:42] (03CR) 10Legoktm: [C: 032] "Nice :)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416689 (owner: 10Thiemo Kreuz (WMDE)) [21:19:15] (03PS4) 10Greg Grossmeier: Add search/analysis-extra to jenkins [integration/config] - 10https://gerrit.wikimedia.org/r/416743 (https://phabricator.wikimedia.org/T188686) (owner: 10DCausse) [21:20:43] (03CR) 10Legoktm: [C: 032] Use faster strcasecmp() instead of strtolower() for comparisons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416691 (owner: 10Thiemo Kreuz (WMDE)) [21:21:13] (03CR) 10Legoktm: [C: 032] Use strict, type-safe === and !== comparisons everywhere [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416696 (owner: 10Thiemo Kreuz (WMDE)) [21:21:47] (03CR) 10Legoktm: [C: 032] Consistently use @inheritDoc on all Sniff::register() methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416692 (owner: 10Thiemo Kreuz (WMDE)) [21:22:04] (03CR) 10Legoktm: [C: 032] Use faster array_key_exists instead of in_array in 2 sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416690 (owner: 10Thiemo Kreuz (WMDE)) [21:22:24] (03CR) 10Legoktm: [C: 032] Remove not needed "@return void" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416693 (owner: 10Thiemo Kreuz (WMDE)) [21:23:14] (03CR) 10Legoktm: [C: 032] Specify "@return void" on all Sniff::process() methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416694 (owner: 10Thiemo Kreuz (WMDE)) [21:25:11] (03CR) 10Legoktm: [C: 04-1] "These were mostly added to satisfy MediaWiki.Commenting.FunctionComment.MissingParamComment. Until we come to a resolution on that sniff (" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416695 (owner: 10Thiemo Kreuz (WMDE)) [21:27:42] thanks hashar [21:28:15] hashar, legoktm proposed in editing: [21:28:24] https://www.irccloud.com/pastebin/dyUt54E4/ [21:29:42] (03PS1) 10Niharika29: Switch default dashboard to custom [extensions/PageAssessments] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/416846 [21:34:14] Project mwext-phpunit-coverage-publish build #1832: 04FAILURE in 47 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/1832/ [21:35:03] Yippee, build fixed! [21:35:03] Project mwext-phpunit-coverage-publish build #1833: 09FIXED in 48 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/1833/ [21:37:53] Project mwext-phpunit-coverage-publish build #1836: 04FAILURE in 20 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/1836/ [21:38:36] (03Merged) 10jenkins-bot: Utilize convenient addContentBefore() in LeadingZeroInFloatSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416689 (owner: 10Thiemo Kreuz (WMDE)) [21:38:38] (03Merged) 10jenkins-bot: Use faster strcasecmp() instead of strtolower() for comparisons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416691 (owner: 10Thiemo Kreuz (WMDE)) [21:39:48] (03CR) 10jenkins-bot: Utilize convenient addContentBefore() in LeadingZeroInFloatSniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416689 (owner: 10Thiemo Kreuz (WMDE)) [21:40:40] (03CR) 10jenkins-bot: Use faster strcasecmp() instead of strtolower() for comparisons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416691 (owner: 10Thiemo Kreuz (WMDE)) [21:40:56] (03Merged) 10jenkins-bot: Use faster array_key_exists instead of in_array in 2 sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416690 (owner: 10Thiemo Kreuz (WMDE)) [21:41:25] (03CR) 10jenkins-bot: Use faster array_key_exists instead of in_array in 2 sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416690 (owner: 10Thiemo Kreuz (WMDE)) [21:42:44] Yippee, build fixed! [21:42:44] Project mwext-phpunit-coverage-publish build #1837: 09FIXED in 29 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/1837/ [21:43:47] hey! https://gerrit.wikimedia.org/r/#/admin/groups/539,members < i need stream events. Anyone got permission to add? twentyafterfour thcipriani maybe? [21:43:59] (for user barrybrowsertestbot) [21:46:43] legoktm: Did you see about the new `npm ci` command? I commented on https://phabricator.wikimedia.org/T179229#4027794 in relation. [21:47:54] thcipriani: any hunces about https://phabricator.wikimedia.org/T188924 ? [21:48:09] any idea what the differences between wmf4 anf wmf5 of hhvm are? [21:48:27] jdlrobson: I don't have permission to add there :/ sorry [21:48:39] jdlrobson your in that group :) [21:50:37] addshore: hhvm differences is something I would ping mori moritzm about he would know what the difference are there. [21:51:08] ack, I can try to remember to poke him tomorrow [21:52:59] interesting.... [21:53:02] I think I just fixed it [21:56:24] paladox: I am but i cant add new people... [21:56:30] oh i see [21:58:24] jdlrobson: added BarryTheBrowserTestBot -- TIL I have that super power. [21:58:34] \o/ [21:58:37] thank you! [21:58:41] yw :) [21:58:44] AND IT WORKS [22:03:50] Volker_E: legoktm : re oojs/ui one of the trouble in splitting it in different jobs is that all of them will end up doing the whole svgDist thing :( [22:17:51] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4029245 (10Addshore) p:05High>03Normal So i poked around a little bit and did the following on mediawiki04 while reading https://wikitech.wikimedia.org/wiki/... [22:18:07] thcipriani: removed it as a train blocker [22:18:12] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T183963#4029250 (10Addshore) [22:18:15] 10Beta-Cluster-Infrastructure, 10Wikidata: Stack overflow in WikibaseRepo initialization on Wikidata Beta - https://phabricator.wikimedia.org/T188924#4029249 (10Addshore) [22:18:22] addshore: \o/ awesome, thanks! [22:18:27] what was the deal? [22:18:31] i made hhvm crash and when it came back up all was okay [22:18:31] * thcipriani looks [22:18:51] hashar: yeah, that task is horrific. Have no idea how to speed it up. also the svgmin part of grunt image hasn't made the situation better. [22:19:09] wrote some details down and maybe moritzmm can have a look tommorrow and speculate as to how hhvm got in a messed up state in the first place [22:19:49] Volker_E: yeah we should probably not run that part :] [22:19:55] Volker_E: I am filling a task about it [22:24:00] hashar: I'll decline it. [22:25:08] right, im off! o/ [22:35:58] 10Continuous-Integration-Config, 10OOUI: Speed up oojs/ui CI job/tests - https://phabricator.wikimedia.org/T189055#4029330 (10hashar) [22:38:02] 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure (Little Steps Sprint), 10OOUI (OOjs-UI-0.20.1): Speed up oojs/ui Jenkins jobs - https://phabricator.wikimedia.org/T155483#2944459 (10hashar) Fast forward months later: Nodepool is being discarded so there is less incentive to save up in... [23:03:54] no_justification when you have a chance (and feeling better, could you rebuild its-phabricator against 2.14 please?) my change was merged https://gerrit-review.googlesource.com/c/plugins/its-base/+/161730 :) [23:04:31] legoktm we can fix the gerritbot now once its-phabricator is re built :) [23:14:35] (03PS2) 10Legoktm: Use strict, type-safe === and !== comparisons everywhere [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416696 (owner: 10Thiemo Kreuz (WMDE)) [23:14:37] (03PS2) 10Legoktm: Consistently use @inheritDoc on all Sniff::register() methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416692 (owner: 10Thiemo Kreuz (WMDE)) [23:14:39] (03PS2) 10Legoktm: Remove not needed "@return void" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416693 (owner: 10Thiemo Kreuz (WMDE)) [23:14:41] (03PS2) 10Legoktm: Specify "@return void" on all Sniff::process() methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416694 (owner: 10Thiemo Kreuz (WMDE)) [23:14:48] (03CR) 10Legoktm: [C: 032] Use strict, type-safe === and !== comparisons everywhere [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416696 (owner: 10Thiemo Kreuz (WMDE)) [23:14:56] (03CR) 10Legoktm: [C: 032] Consistently use @inheritDoc on all Sniff::register() methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416692 (owner: 10Thiemo Kreuz (WMDE)) [23:15:03] (03CR) 10Legoktm: [C: 032] Remove not needed "@return void" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416693 (owner: 10Thiemo Kreuz (WMDE)) [23:15:11] (03CR) 10Legoktm: [C: 032] Specify "@return void" on all Sniff::process() methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416694 (owner: 10Thiemo Kreuz (WMDE)) [23:16:18] (03Merged) 10jenkins-bot: Use strict, type-safe === and !== comparisons everywhere [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416696 (owner: 10Thiemo Kreuz (WMDE)) [23:16:30] (03Merged) 10jenkins-bot: Consistently use @inheritDoc on all Sniff::register() methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416692 (owner: 10Thiemo Kreuz (WMDE)) [23:17:17] (03CR) 10jenkins-bot: Use strict, type-safe === and !== comparisons everywhere [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416696 (owner: 10Thiemo Kreuz (WMDE)) [23:20:56] (03CR) 10jenkins-bot: Consistently use @inheritDoc on all Sniff::register() methods [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/416692 (owner: 10Thiemo Kreuz (WMDE)) [23:22:55] 10Release-Engineering-Team (Kanban): Find out if there's an existing task/plan to get rid of globals. - https://phabricator.wikimedia.org/T189059#4029469 (10Jrbranaa) [23:24:44] greg-g: i think these new stats that cindy put together are of intesrest for your team https://pingback.wmflabs.org [23:25:01] greg-g: mediawiki versions/os ... [23:25:44] greg-g: they need a bit of work but they are probably useful even now [23:30:30] 10Release-Engineering-Team (Kanban): Follow up with platform team regarding refactoring plans - https://phabricator.wikimedia.org/T189062#4029507 (10Jrbranaa) [23:37:36] (03PS1) 10Thcipriani: Update make-deploy-notes [tools/release] - 10https://gerrit.wikimedia.org/r/416871 [23:42:49] nuria_: coolio! [23:44:00] greg-g: we need to prettyfy abit [23:44:03] Reedy: https://pingback.wmflabs.org/#database-type/database-type-timeseries [23:44:14] greg-g: but data is of value [23:44:25] thanks, looks good [23:50:20] (03CR) 10Thcipriani: "this change was used to make https://www.mediawiki.org/wiki/MediaWiki_1.31/wmf.24/Changelog" [tools/release] - 10https://gerrit.wikimedia.org/r/416871 (owner: 10Thcipriani) [23:57:08] (03CR) 10Chad: [C: 032] "Oh crap you already finished this and used it for today? I <3 you. The rest should be easy from here." [tools/release] - 10https://gerrit.wikimedia.org/r/416871 (owner: 10Thcipriani) [23:57:45] (03Merged) 10jenkins-bot: Update make-deploy-notes [tools/release] - 10https://gerrit.wikimedia.org/r/416871 (owner: 10Thcipriani) [23:58:36] thcipriani: 300 lines of PHP -> 200 lines of Python. Runs in what....1/20th of the time? I approvez [23:59:00] :) [23:59:06] Also doesn't fail because the prior_branch wasn't just branch_num - 1