[00:05:04] 10Gerrit, 10MediaWiki-General-or-Unknown: Restore lost git tags for older releases - https://phabricator.wikimedia.org/T190363#4071366 (10Reedy) [00:05:26] 10MediaWiki-Releasing: Big holes in the MediaWiki release archive - https://phabricator.wikimedia.org/T190369#4071367 (10Reedy) [01:12:12] 10Differential, 10Gerrit-Migration: Create useful `.arcconfig`s for migrated repos - https://phabricator.wikimedia.org/T130787#2146510 (10TerraCodes) Isn't this task a duplicate of {T170}? [01:39:40] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<22.22%) [04:34:14] (03PS1) 10BryanDavis: Allow over length subject line for reverts [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421209 (https://phabricator.wikimedia.org/T174136) [04:51:50] (03PS1) 10BryanDavis: Allow Depends-On to follow Change-Id [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421211 (https://phabricator.wikimedia.org/T182173) [04:59:50] 10Release-Engineering-Team (Watching / External), 10Developer-Wishlist, 10Composer: Setup a Composer Repository (Packagist) for MediaWiki Extensions - https://phabricator.wikimedia.org/T170897#4071700 (10dbarratt) 05Open>03declined [06:01:48] (03PS1) 10BryanDavis: Add colored error message support [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421213 (https://phabricator.wikimedia.org/T179904) [06:03:08] 10commit-message-validator, 10Patch-For-Review: Depends-On should come after Change-Id - https://phabricator.wikimedia.org/T182173#4071817 (10bd808) a:03bd808 [06:03:27] 10commit-message-validator, 10Patch-For-Review: Make errors more colorful - https://phabricator.wikimedia.org/T179904#4071818 (10bd808) a:03bd808 [06:04:41] 10commit-message-validator, 10Patch-For-Review: Revert messages for valid commits still trigger validation failures - https://phabricator.wikimedia.org/T174136#4071819 (10bd808) Proposed patch does not skip all validation. Doing that will take a lot more invasive changes to the codebase. [06:59:37] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [08:28:08] 10Gerrit, 10MediaWiki-Releasing: Restore lost git tags for older releases - https://phabricator.wikimedia.org/T190363#4072045 (10Aklapper) [08:29:54] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban): phabricator-jessie-diffs fails with "echo : No such file or directory" - https://phabricator.wikimedia.org/T189660#4072049 (10Gilles) 05Open>03Resolved [08:50:09] PROBLEM - Puppet errors on integration-slave-jessie-1004 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [08:50:57] PROBLEM - Puppet errors on integration-slave-jessie-1001 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [08:53:39] 10Project-Admins, 10Africa-Wikimedia-Developers: Project work board request for WikiFundi - https://phabricator.wikimedia.org/T186754#4072080 (10Aklapper) @Anthere: So... is this still wanted, after I asked maybe too many questions? :) [09:56:36] 10Gerrit, 10MediaWiki-Releasing: Restore lost git tags for older releases - https://phabricator.wikimedia.org/T190363#4072177 (10HappyDog) [10:02:25] (03CR) 10Hashar: [C: 032] Allow over length subject line for reverts [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421209 (https://phabricator.wikimedia.org/T174136) (owner: 10BryanDavis) [10:02:28] (03CR) 10Hashar: [C: 032] Allow Depends-On to follow Change-Id [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421211 (https://phabricator.wikimedia.org/T182173) (owner: 10BryanDavis) [10:03:01] (03Merged) 10jenkins-bot: Allow over length subject line for reverts [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421209 (https://phabricator.wikimedia.org/T174136) (owner: 10BryanDavis) [10:03:03] (03Merged) 10jenkins-bot: Allow Depends-On to follow Change-Id [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421211 (https://phabricator.wikimedia.org/T182173) (owner: 10BryanDavis) [10:13:51] (03CR) 10Paladox: "The commit-msg hook was updated to support Depends-on, you should update the commit-msg." [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421211 (https://phabricator.wikimedia.org/T182173) (owner: 10BryanDavis) [10:14:57] (03PS1) 10Paladox: Revert "Allow Depends-On to follow Change-Id" [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421257 [10:23:35] Project mwext-phpunit-coverage-publish build #2480: 04FAILURE in 1.8 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/2480/ [10:25:24] (03CR) 10Hashar: "The git config part looks fine to me. A future change could add an option to the git commit message validator to force color when running " (031 comment) [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421213 (https://phabricator.wikimedia.org/T179904) (owner: 10BryanDavis) [10:26:30] Yippee, build fixed! [10:26:31] Project mwext-phpunit-coverage-publish build #2481: 09FIXED in 2 min 55 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/2481/ [10:42:09] 10Release-Engineering-Team (Kanban), 10Advanced-Search, 10TCB-Team, 10User-zeljkofilipin: Cannot find module nodemw - https://phabricator.wikimedia.org/T190307#4072249 (10Tonina_Zhelyazkova_WMDE) The failures in [[ https://gerrit.wikimedia.org/r/#/c/392854/ | 392854 ]] don't seem related to nodemw module.... [10:58:23] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10Patch-For-Review, 10User-zeljkofilipin: Replace nodemw with mwbot - https://phabricator.wikimedia.org/T181284#4072279 (10thiemowmde) [11:19:10] (03Abandoned) 10Phedenskog: Run WebPageTest tests from Asia to verify the new cache pop. [integration/config] - 10https://gerrit.wikimedia.org/r/362972 (https://phabricator.wikimedia.org/T168416) (owner: 10Phedenskog) [11:25:10] (03PS1) 10Phedenskog: Run WebPageTest tests from Singapore to verify the new cache pop. [integration/config] - 10https://gerrit.wikimedia.org/r/421266 (https://phabricator.wikimedia.org/T168416) [11:26:03] (03CR) 10jerkins-bot: [V: 04-1] Run WebPageTest tests from Singapore to verify the new cache pop. [integration/config] - 10https://gerrit.wikimedia.org/r/421266 (https://phabricator.wikimedia.org/T168416) (owner: 10Phedenskog) [11:28:27] (03PS2) 10Phedenskog: Run WebPageTest tests from Singapore to verify the new cache pop. [integration/config] - 10https://gerrit.wikimedia.org/r/421266 (https://phabricator.wikimedia.org/T168416) [11:47:05] 10Release-Engineering-Team (Kanban), 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10Patch-For-Review, 10User-zeljkofilipin: Warning: Task "stylelint:src" failed due to postcss-less@1.1.4 - https://phabricator.wikimedia.org/T190269#4072384 (10hashar) At least on CirrusSearch https://gerr... [12:28:21] !log removed two patches from deployment-puppetmaster02's operations/puppet repo because git-sync was failing (https://gerrit.wikimedia.org/r/#/c/361648/ and https://gerrit.wikimedia.org/r/#/c/402758/) [12:28:23] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [12:38:40] PROBLEM - Puppet errors on deployment-ms-be04 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [12:54:27] PROBLEM - Puppet errors on deployment-ms-be03 is CRITICAL: CRITICAL: 66.67% of data above the critical threshold [0.0] [13:36:34] PROBLEM - Puppet errors on deployment-eventlog05 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:36:52] 10Release-Engineering-Team (Kanban), 10MediaWiki-SWAT-deployments: Proposal: Effective immediately, disallow multi-sync patch deployment - https://phabricator.wikimedia.org/T187761#4072672 (10zeljkofilipin) How would one deploy [[ https://gerrit.wikimedia.org/r/#/c/421093/ | 421093 ]]? It changes `static/imag... [13:37:04] 10Release-Engineering-Team (Kanban), 10MediaWiki-SWAT-deployments, 10User-zeljkofilipin: Proposal: Effective immediately, disallow multi-sync patch deployment - https://phabricator.wikimedia.org/T187761#4072673 (10zeljkofilipin) [14:48:45] PROBLEM - Puppet errors on deployment-cache-text04 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [15:03:00] (03PS1) 10Thiemo Kreuz (WMDE): Replace string "type" comparisons with int "code" comparisons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421310 [15:08:58] (03CR) 10jerkins-bot: [V: 04-1] Replace string "type" comparisons with int "code" comparisons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421310 (owner: 10Thiemo Kreuz (WMDE)) [15:10:15] PROBLEM - Puppet errors on deployment-snapshot01 is CRITICAL: CRITICAL: 44.44% of data above the critical threshold [0.0] [15:12:52] it should be ok [15:12:57] I just ran it over there [15:13:44] RECOVERY - Puppet errors on deployment-cache-text04 is OK: OK: Less than 1.00% above the threshold [0.0] [15:15:00] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10Patch-For-Review, 10User-zeljkofilipin: Replace nodemw with mwbot - https://phabricator.wikimedia.org/T181284#4072914 (10zeljkofilipin) [15:15:57] PROBLEM - SSH on integration-slave-docker-1003 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [15:16:40] 10Release-Engineering-Team (Kanban), 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10Patch-For-Review, 10User-zeljkofilipin: Warning: Task "stylelint:src" failed due to postcss-less@1.1.4 - https://phabricator.wikimedia.org/T190269#4072917 (10zeljkofilipin) a:05zeljkofilipin>03None [15:17:18] 10Release-Engineering-Team (Kanban), 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10Patch-For-Review, 10User-zeljkofilipin: Warning: Task "stylelint:src" failed due to postcss-less@1.1.4 - https://phabricator.wikimedia.org/T190269#4068266 (10zeljkofilipin) Removed myself from assignee s... [15:19:43] PROBLEM - Puppet errors on deployment-cache-text04 is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [0.0] [15:20:14] RECOVERY - Puppet errors on deployment-snapshot01 is OK: OK: Less than 1.00% above the threshold [0.0] [15:20:48] RECOVERY - SSH on integration-slave-docker-1003 is OK: SSH OK - OpenSSH_6.7p1 Debian-5+deb8u4 (protocol 2.0) [15:21:15] (03CR) 10Thiemo Kreuz (WMDE): "I actually have no idea how these failures are related to what I do in this patch." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421310 (owner: 10Thiemo Kreuz (WMDE)) [15:24:32] (03PS1) 10Thiemo Kreuz (WMDE): Use elseif in two …GlobalVariables sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421315 [15:26:25] (03PS2) 10Thiemo Kreuz (WMDE): Replace string "type" comparisons with int "code" comparisons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421310 [15:27:39] (03PS2) 10Thiemo Kreuz (WMDE): Use elseif in two …GlobalVariables sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421315 [15:27:43] PROBLEM - Puppet errors on deployment-redis01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:32:37] 10Release-Engineering-Team (Kanban), 10Release Pipeline: Verify functionality of the 'production' image in the context of an isolated k8s deployment - https://phabricator.wikimedia.org/T183165#4073003 (10thcipriani) [15:32:42] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release Pipeline (Blubber): Add blubber to docker integration agents - https://phabricator.wikimedia.org/T186548#4073000 (10thcipriani) 05Open>03Resolved Thanks for the merge @akosiaris ! [15:33:42] PROBLEM - Puppet errors on deployment-redis02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:44:44] RECOVERY - Puppet errors on deployment-cache-text04 is OK: OK: Less than 1.00% above the threshold [0.0] [15:50:42] Project mwext-phpunit-coverage-publish build #2484: 04FAILURE in 2 min 12 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/2484/ [15:52:48] 10Beta-Cluster-Infrastructure, 10CodeEditor: CodeEditor doesn't seem to load on Beta Cluster enwiki (but does on Beta Cluster dewiki and production) - https://phabricator.wikimedia.org/T190423#4073093 (10Jdforrester-WMF) [15:53:51] (03CR) 10Thiemo Kreuz (WMDE): "I got confused by the non-voting job. All fine now." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421310 (owner: 10Thiemo Kreuz (WMDE)) [15:58:02] 10Beta-Cluster-Infrastructure, 10CodeEditor: CodeEditor doesn't seem to load on Beta Cluster enwiki (but does on Beta Cluster dewiki and production) - https://phabricator.wikimedia.org/T190423#4073093 (10TerraCodes) CodeEditor loads on those pages for me, tho I don't know if me not being an admin affects anyth... [16:08:47] 10Release-Engineering-Team (Watching / External), 10Operations, 10Scoring-platform-team (Current), 10Wikimedia-Incident: Cache ORES virtualenv within versioned source - https://phabricator.wikimedia.org/T181071#4073147 (10awight) This has been reverted in https://gerrit.wikimedia.org/r/#/c/421316/, since I... [16:13:09] (03PS1) 10Thiemo Kreuz (WMDE): Simplify UnusedGlobalVariables sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421332 [17:25:01] 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Retrospective for T139740 Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T188740#4073457 (10zeljkofilipin) a:05Jrbranaa>03zeljkofilipin [18:05:30] hmm [18:05:36] no_justification this link dosen't seem to work https://gerrit.wikimedia.org/g/mediawiki/core.git/+/52aeaa7a5fb0c233caa9f7815882f7a99cf4ece3 [18:05:51] aha [18:06:02] no_justification we should strip .git from the end of the repo [18:06:56] Back in my day we had to put .git in our repo names and liked it 😂 [18:09:19] lol [18:11:21] Yippee, build fixed! [18:11:22] Project mwext-phpunit-coverage-publish build #2485: 09FIXED in 7 min 51 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/2485/ [18:39:23] PROBLEM - Puppet errors on deployment-mx is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:01:35] 10Release-Engineering-Team (Kanban), 10MediaWiki-SWAT-deployments, 10User-zeljkofilipin: Proposal: Effective immediately, disallow multi-sync patch deployment - https://phabricator.wikimedia.org/T187761#4073810 (10demon) >>! In T187761#4072672, @zeljkofilipin wrote: > How would one deploy [[ https://gerrit.w... [19:10:05] 10Continuous-Integration-Infrastructure, 10VisualEditor: Provide the same version of Chrome/Chromium in Docker and Nodepool (or migrate qunit for extensions to Docker) - https://phabricator.wikimedia.org/T184102#4073849 (10Jdforrester-WMF) "migrate qunit for extensions to Docker" is part of {T190097} and seems... [19:28:53] Did something deploy today that changes the behavior of index.php?action=raw for JSON pages? [19:28:53] This is serving an HTML error where it did not used to: https://meta.wikimedia.org/w/index.php?action=raw&title=User:Sage%20(Wiki%20Ed)/dashboard%20modules/nonexistent.json [19:32:17] 10Release-Engineering-Team (Kanban), 10MediaWiki-SWAT-deployments, 10User-zeljkofilipin: Proposal: Effective immediately, disallow multi-sync patch deployment - https://phabricator.wikimedia.org/T187761#4073885 (10Krinkle) @zeljkofilipin In my opinion, the correct way to deploy that would indeed be an (ineff... [19:46:52] for all pages, I guess? I think action=raw previously returned an empty response for a 404 (matching the format for a 200, which returns the raw wiki text), but now it returns the HTML 404 page. [19:50:13] 10Release-Engineering-Team (Kanban), 10MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), 10Patch-For-Review, 10User-zeljkofilipin, 10Wikimedia-log-errors (Jenkins Failure): Warning: Task "stylelint:src" failed due to postcss-less@1.1.4 - https://phabricator.wikimedia.org/T190269#4073921 (10Kr... [19:50:59] no_justification i think this https://gerrit-review.googlesource.com/c/plugins/delete-project/+/167574 you may like :) [19:56:50] no_justification: ^ ragesoss [19:57:40] ragesoss: We went to wmf.26, but I was delayed today...didn't go out until 5mins ago [19:57:46] Oh, meta...coulda been yesterday? [19:59:19] cool. I found a fix in my code. I assume that action=raw is mainly used programmatically, so that change is likely to cause some pain for many consumers. [20:08:00] no_justification wondering when you get a chance could you pull in upstream 2.14 (for the patch that fixes T161206) please? :) [20:08:00] T161206: Gerrit patchset 99101 cannot be accessed: "500 Internal server error" - https://phabricator.wikimedia.org/T161206 [20:11:12] ragesoss: can you file a task? I’ll check for impact in an hour [20:12:12] Krinkle: will do. [20:15:29] ragesoss: for what it’s worth, I’m fairly certain the change is not caused by a change in MediaWiki, rather it’s due to an infrastructure change at the Varnish level. Which probably happened a couple weeks ago [20:16:49] Krinkle: the change I'm observing definitely came within the last ~13 hours. It caused my CI builds to start failing today. [20:17:06] (03CR) 10Umherirrender: [V: 032 C: 032] Mark repository as read only [extensions/PushToWatch] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/421106 (owner: 10MarcoAurelio) [20:23:08] Krinkle: https://phabricator.wikimedia.org/T190450 [20:30:19] (03CR) 10Umherirrender: [C: 032] "I like the 'code' variant, too." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421310 (owner: 10Thiemo Kreuz (WMDE)) [20:30:47] paladox: Building it [20:30:54] no_justification thanks :) [20:31:04] (03Merged) 10jenkins-bot: Replace string "type" comparisons with int "code" comparisons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421310 (owner: 10Thiemo Kreuz (WMDE)) [20:31:04] Unrelated, but also: https://gerrit.wikimedia.org/r/#/c/421382/ [20:31:55] (03CR) 10jenkins-bot: Replace string "type" comparisons with int "code" comparisons [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421310 (owner: 10Thiemo Kreuz (WMDE)) [20:32:34] :) [20:33:48] (03CR) 10Umherirrender: [C: 032] Use elseif in two …GlobalVariables sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421315 (owner: 10Thiemo Kreuz (WMDE)) [20:33:48] Project selenium-Wikibase-chrome » chrome,beta,Linux,DebianJessie && contintLabsSlave build #154: 04FAILURE in 46 min: https://integration.wikimedia.org/ci/job/selenium-Wikibase-chrome/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=DebianJessie%20&&%20contintLabsSlave/154/ [20:34:36] (03Merged) 10jenkins-bot: Use elseif in two …GlobalVariables sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421315 (owner: 10Thiemo Kreuz (WMDE)) [20:35:15] (03CR) 10jenkins-bot: Use elseif in two …GlobalVariables sniffs [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421315 (owner: 10Thiemo Kreuz (WMDE)) [20:36:51] no_justification this https://gerrit.wikimedia.org/r/c/419790/ needs v+2 [20:36:55] :) [20:36:59] I know [20:37:03] ok [20:37:08] I reviewed it, now I'm building to verify it [20:37:13] ah [20:37:14] i see [20:37:14] (barring any jobs to do a build for us) [20:37:15] ok [20:39:01] PROBLEM - Puppet errors on deployment-mediawiki07 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [20:42:16] jdlrobson: Could you double-check https://gerrit.wikimedia.org/r/#/c/336447/14/modules/ext.wikimediaEvents.readingDepth.js ? Was just perusing some start-up code on most pages and noticed the double call. [20:53:50] (03CR) 10Umherirrender: "The task is only about static function, because than the function would be a global one. I cannot say, if all types of functions should be" (036 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/420231 (https://phabricator.wikimedia.org/T183756) (owner: 10MaxSem) [20:56:48] Not sure where to report this exactly, but this significantly hampers my ability to debug production issues: T190455 [20:56:48] T190455: Logstash no longer captures DB queries in debug mode - https://phabricator.wikimedia.org/T190455 [20:56:54] (cc greg-g no_justification ) [20:57:04] 10Release-Engineering-Team, 10MediaWiki-Debug-Logger: Logstash no longer captures DB queries in debug mode - https://phabricator.wikimedia.org/T190455#4074157 (10Catrope) [20:57:08] 10commit-message-validator, 10Patch-For-Review: Revert messages for valid commits still trigger validation failures - https://phabricator.wikimedia.org/T174136#4074170 (10bd808) 05Open>03Resolved a:03bd808 [20:57:15] 10commit-message-validator, 10Patch-For-Review: Depends-On should come after Change-Id - https://phabricator.wikimedia.org/T182173#4074173 (10bd808) 05Open>03Resolved [20:57:44] 10Release-Engineering-Team, 10MediaWiki-Debug-Logger, 10Wikimedia-Logstash: Logstash no longer captures DB queries in debug mode - https://phabricator.wikimedia.org/T190455#4074174 (10greg) [21:02:45] (03CR) 10BryanDavis: "> The git config part looks fine to me. A future change could add an" (031 comment) [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421213 (https://phabricator.wikimedia.org/T179904) (owner: 10BryanDavis) [21:03:07] (03CR) 10Umherirrender: [C: 032] Simplify UnusedGlobalVariables sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421332 (owner: 10Thiemo Kreuz (WMDE)) [21:03:13] (03CR) 10jerkins-bot: [V: 04-1] Simplify UnusedGlobalVariables sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421332 (owner: 10Thiemo Kreuz (WMDE)) [21:03:41] (03CR) 10Umherirrender: [C: 031] Simplify UnusedGlobalVariables sniff [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421332 (owner: 10Thiemo Kreuz (WMDE)) [21:05:04] (03CR) 10BryanDavis: "> The commit-msg hook was updated to support Depends-on, you should" [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421211 (https://phabricator.wikimedia.org/T182173) (owner: 10BryanDavis) [21:06:23] (03CR) 10BryanDavis: "You are recommending that every user of this utility upgrade their local copy of git-review and then update the existing hook for every gi" [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421257 (owner: 10Paladox) [21:07:17] (03CR) 10Paladox: "> Patch Set 1:" [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421257 (owner: 10Paladox) [21:07:41] no_justification lol why is it me always finding the bugs in gerrit @ master heh and not the paid google employees :) [21:07:44] i found this bug [21:07:48] https://bugs.chromium.org/p/gerrit/issues/detail?id=8620 [21:08:02] apparently i am the only one that noticed it when using the rebase dialog [21:08:08] it has a drop down now [21:10:41] (03CR) 10Krinkle: Prohibit nested functions (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/420231 (https://phabricator.wikimedia.org/T183756) (owner: 10MaxSem) [21:10:51] (03Abandoned) 10Paladox: Revert "Allow Depends-On to follow Change-Id" [integration/commit-message-validator] - 10https://gerrit.wikimedia.org/r/421257 (owner: 10Paladox) [21:24:34] paladox: I thought they used a fork of gerrit? That's what this paper published ~2015 suggests: https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/43322.pdf [21:24:57] greg-g hmm, yes, but it is mostly on the current gerrit code [21:25:24] They always block changes, pending changes internally [21:25:30] to fix any incompaitibility [21:26:18] though i can reproduce that bug locally. [21:29:06] i think this is notedb related *sigh* [21:31:57] yep, but works in 2.15 with notedb but broken on master [21:32:30] greg-g: Eh, it's not a fork so much as internal secret sauce they add to it. [21:32:37] ^^ [21:32:44] secret stuff [21:34:43] that sounds like a fork [21:35:58] it sounds cooler if you say it is a custom-foo install [21:36:09] even if you only changed the css :) [21:36:42] polygerrit is seperate from gerrit (it's hosted on a cdn for gerrit-review) [21:36:50] so i think it's just the backend [21:42:24] Krenair: Not really....they have plugins & such [21:42:45] like codemirror which is maintained by the pg team [21:42:50] I guess by that metric, we have a fork too! [21:42:56] heh [21:43:18] s/fork/highly customized/ ;) [21:49:11] ^^ [21:49:27] i doint think we are running any seperate changes that wern't merged upstream now :) [22:15:32] 10Gerrit, 10Release-Engineering-Team (Next), 10DBA, 10Operations, 10Patch-For-Review: Gerrit is failing to connect to db on gerrit2001 thus preventing systemd from working - https://phabricator.wikimedia.org/T176532#4074444 (10Dzahn) - added parameter to base monitoring class to allow disabling of system... [22:20:21] (03PS1) 10Umherirrender: Use File::getDeclarationName to get the function name [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/421439 [22:50:30] Project beta-code-update-eqiad build #198673: 04FAILURE in 42 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/198673/ [22:51:06] Gerrit was restarted for config change and is back. [22:52:43] PROBLEM - Puppet errors on saucelabs-02 is CRITICAL: CRITICAL: 40.00% of data above the critical threshold [0.0] [22:53:32] 10Beta-Cluster-Infrastructure, 10CodeEditor: CodeEditor doesn't seem to load on Beta Cluster enwiki (but does on Beta Cluster dewiki and production) - https://phabricator.wikimedia.org/T190423#4074513 (10Jdforrester-WMF) 05Open>03Invalid Don't mind me, had an odd preference set. [22:53:44] Yippee, build fixed! [22:53:44] Project beta-code-update-eqiad build #198674: 09FIXED in 43 sec: https://integration.wikimedia.org/ci/job/beta-code-update-eqiad/198674/ [23:32:44] RECOVERY - Puppet errors on saucelabs-02 is OK: OK: Less than 1.00% above the threshold [0.0] [23:36:33] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T183963#4074615 (10Huji) [23:41:08] paladox: Release built: 2.14.7-6-g19f837a133 [23:41:17] I'll uploaded to archiva shortly and put a patch for the deploy repo [23:41:23] thanks :) [23:41:33] This is HEAD~1. The plugin bump fails to build....I didn't check reviewers well enough [23:41:39] oh [23:41:40] ah [23:41:46] no_justification yeh, they made a mistake [23:41:57] releasing 2.14.7 without the patch that now breaks 2.14 [23:42:00] reviewers [23:42:24] ERROR: /Users/chad/gerrit-workspace/gerrit/plugins/reviewers/BUILD:9:1: Building plugins/reviewers/libreviewers__plugin-class.jar (19 source files) failed (Exit 1) [23:42:25] plugins/reviewers/src/main/java/com/googlesource/gerrit/plugins/reviewers/ReviewersConfig.java:72: error: cannot find symbol [23:42:25] cfg = cfgFactory.getProjectPluginConfigWithMergedInheritance(projectName, pluginName); [23:42:25] ^ [23:42:25] symbol: method getProjectPluginConfigWithMergedInheritance(NameKey,String) [23:42:25] location: variable cfgFactory of type PluginConfigFactory [23:43:10] ah [23:43:11] yes [23:43:14] that's the one [23:43:26] no_justification if you build from head of stable-2.14 that will fix it [23:44:06] no_justification https://github.com/GerritCodeReview/gerrit/commit/b432980c97e4b57d45cc32c3f368b1ce69c8540c [23:44:19] that's the change that adds it to gerrit 2.14 (but was not released in 2.14.7) [23:47:54] no_justification or there's another solution [23:48:36] you could revert git revert 1cd900b8bfe20483971d7437fa38454c22458262 [23:48:40] which is https://github.com/GerritCodeReview/plugins_reviewers/commit/1cd900b8bfe20483971d7437fa38454c22458262 [23:49:01] I'll just revert the plugin back tbh [23:49:09] ok [23:55:52] no_justification twentyafterfour do we know why we use a php.ini (actual file) in the puppet repo for phab, compared to using matching keywords? [23:56:55] this question was asked by someone else, but i wasen't sure why we do :) [23:57:35] wow big differences between php5.5 ini (wmf) and php 7.2 ini https://www.diffchecker.com/Cdeq848o (wmf customisations too) [23:57:57] The original implementation did that. Same reason as most things heh [23:58:05] oh [23:58:13] "nobody has bothered to fix it" [23:59:03] ah [23:59:12] i guess we can fix this after moving to stretch