[00:31:16] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [00:46:22] 10Gerrit, 10Phabricator, 10Release-Engineering-Team: Consider disabling differential - https://phabricator.wikimedia.org/T191182#4096177 (10Peachey88) I think this should be discussed in a wider scope of what WMF and MW should support, For example we currently have WMF teams using GitHub as their canonical s... [05:57:32] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<10.00%) [07:22:32] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [07:37:58] PROBLEM - Free space - all mounts on integration-slave-jessie-1002 is CRITICAL: CRITICAL: integration.integration-slave-jessie-1002.diskspace._mnt.byte_percentfree (No valid datapoints found)integration.integration-slave-jessie-1002.diskspace._srv.byte_percentfree (<10.00%) [08:23:58] 10Gerrit: Enable avatars in gerrit - https://phabricator.wikimedia.org/T191183#4096616 (10Tgr) Using something like [[https://github.com/ThomasLeister/gravatar-privacy-proxy|gravatar-privacy-proxy]] would solve both the privacy and the performance issues. [08:40:41] 10Gerrit, 10Developer-Relations, 10Developer-Wishlist (2017): Implement a way to bring GitHub pull requests into gerrit - https://phabricator.wikimedia.org/T37497#398624 (10Tgr) Another gerrit plugin doing this is [[https://gerrit.googlesource.com/plugins/github-pullrequest/|github-pullrequest]]. [09:01:48] 10Gerrit, 10Phabricator, 10Release-Engineering-Team: Consider disabling differential - https://phabricator.wikimedia.org/T191182#4096177 (10MarcoAurelio) I agree. We should have development centralized in one place, at least for Wikimedia extensions, tools and dependencies. Current status is bad as EddieGP m... [09:31:44] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T183966#3868571 (10jcrespo) There is something ongoing with the database, but cannot see it is 26 or 27-related, it may have started after 27 deploy. Security task: T191116 [09:32:07] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T183966#4096671 (10jcrespo) [10:40:50] 10Gerrit: Enable avatars in gerrit - https://phabricator.wikimedia.org/T191183#4096728 (10Peachey88) >>! In T191183#4096616, @Tgr wrote: > Using something like [[https://github.com/ThomasLeister/gravatar-privacy-proxy|gravatar-privacy-proxy]] would solve both the privacy and the performance issues. Gravatar sti... [10:54:06] PROBLEM - Host deployment-videoscaler01 is DOWN: CRITICAL - Host Unreachable (10.68.19.130) [10:54:52] PROBLEM - Host deployment-tmh01 is DOWN: CRITICAL - Host Unreachable (10.68.16.211) [11:17:28] 10Gerrit: Enable avatars in gerrit - https://phabricator.wikimedia.org/T191183#4096752 (10Tgr) The primary email address in gerrit is already public and can be viewed by typing e.g. `owner:` in the search box. The [[https://wikitech.wikimedia.org/wiki/Special:CreateAccount|registration interface]] warn... [13:50:40] (03PS1) 10Hashar: Test quibble.backend.getDBClass [integration/quibble] - 10https://gerrit.wikimedia.org/r/423473 [14:06:23] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T183966#4097120 (10jcrespo) [14:12:50] 10Beta-Cluster-Infrastructure, 10Puppet: Error: Could not find class role::kafka::jumbo::mirror for deployment-kafka0[45] - https://phabricator.wikimedia.org/T191154#4097133 (10Ottomata) Ah ya, sorry! Lots of mirror maker stuff moving around. Will fix today. [14:46:25] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4097205 (10CCicalese_WMF) I suggest bundling the following additional extensions wit... [14:53:15] PROBLEM - Host deployment-puppetdb01 is DOWN: CRITICAL - Host Unreachable (10.68.23.76) [15:07:58] 10Gerrit, 10Phabricator, 10Release-Engineering-Team: Consider disabling differential - https://phabricator.wikimedia.org/T191182#4096177 (10demon) I'm fine with moving Scap back to Gerrit tbh. [15:10:24] yeah! +1 no_justification [15:10:31] s/1/100/ [15:12:58] RECOVERY - Free space - all mounts on integration-slave-jessie-1002 is OK: OK: integration.integration-slave-jessie-1002.diskspace._mnt.byte_percentfree (No valid datapoints found) [15:25:52] 10Beta-Cluster-Infrastructure, 10Puppet: Error: Could not find class role::kafka::jumbo::mirror for deployment-kafka0[45] - https://phabricator.wikimedia.org/T191154#4097292 (10Ottomata) Hm actually, I don't seem to have access to the deployment-prep project in Horizon anymore. I don't see it in the project d... [15:48:42] PROBLEM - Puppet errors on integration-slave-docker-1003 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:52:54] greg-g: when you have a second could you remove me from the recurring invite on https://calendar.google.com/calendar/r/eventedit/dGhrcnJycWc4cXVodWQ4OGNrNHJpNzFmdmNfMjAxODA0MDJUMTYwMDAwWiBhYm9nb3R0QHdpa2ltZWRpYS5vcmc?t=AKUaPmazl66Q8Z_mJIhu-OdpiZhhjXFnbOF-8_HIrEcV2_YMTdyrunFZ5JIx7kiMPs4wENcsfLGSsBiD0Xw3D0LL_p7UKHoGWQ%3D%3D ? [15:52:57] Dang, that's a big link [15:53:10] 10Release-Engineering-Team (Kanban), 10Release Pipeline (Blubber): Support for Blubber defaults and/or policies - https://phabricator.wikimedia.org/T174631#4097492 (10dduvall) 05Open>03Resolved Solved with implementation of {D999} and {D1003}. [15:59:26] andrewbogott: heh, and not sure it works across accounts, but yes :) [15:59:48] andrewbogott: done [16:08:53] (03PS8) 10Paladox: [operations-puppet-catalog-compiler] Adding it to jenkins job builder [integration/config] - 10https://gerrit.wikimedia.org/r/315994 (https://phabricator.wikimedia.org/T97513) [16:10:02] (03PS17) 10Paladox: Create operations-puppet-catalog-compiler job in jjb [integration/config] - 10https://gerrit.wikimedia.org/r/325064 (https://phabricator.wikimedia.org/T97513) [16:10:06] (03PS18) 10Paladox: Create operations-puppet-catalog-compiler job in jjb [integration/config] - 10https://gerrit.wikimedia.org/r/325064 (https://phabricator.wikimedia.org/T97513) [16:10:41] (03PS19) 10Paladox: Create operations-puppet-catalog-compiler job in jjb [integration/config] - 10https://gerrit.wikimedia.org/r/325064 (https://phabricator.wikimedia.org/T97513) [16:10:57] (03CR) 10Paladox: [C: 04-1] "Per joe." [integration/config] - 10https://gerrit.wikimedia.org/r/325064 (https://phabricator.wikimedia.org/T97513) (owner: 10Paladox) [16:14:57] 10Release-Engineering-Team (Kanban), 10Release Pipeline: Permission denied upon `minikube start` as non-root user - https://phabricator.wikimedia.org/T191211#4097575 (10dduvall) [16:15:37] 10Release-Engineering-Team (Kanban), 10Release Pipeline: Permission denied upon `minikube start` as non-root user - https://phabricator.wikimedia.org/T191211#4097585 (10dduvall) [16:15:39] 10Release-Engineering-Team (Kanban), 10Release Pipeline, 10Patch-For-Review: ensure minikube running on integration agents - https://phabricator.wikimedia.org/T188936#4097586 (10dduvall) [16:16:26] (03CR) 10Chad: [C: 032] Drop Modern/CologneBlue from tarball bundle [tools/release] - 10https://gerrit.wikimedia.org/r/422963 (owner: 10Chad) [16:17:34] (03Merged) 10jenkins-bot: Drop Modern/CologneBlue from tarball bundle [tools/release] - 10https://gerrit.wikimedia.org/r/422963 (owner: 10Chad) [16:19:22] (03CR) 10Chad: [C: 04-2] "This should either be handled by puppet or by scap. Definitely not by Jenkins." [integration/config] - 10https://gerrit.wikimedia.org/r/417263 (owner: 10Hashar) [16:24:19] 10Release-Engineering-Team (Kanban), 10Release Pipeline: Permission denied upon `minikube start` as non-root user - https://phabricator.wikimedia.org/T191211#4097622 (10dduvall) p:05Triage>03High [16:27:28] (03CR) 10Paladox: [C: 04-1] "@Giuseppe Lavagetto it seems the tool dosen't work for wmf jenkins anymore (needs authorisation it seems)" [integration/config] - 10https://gerrit.wikimedia.org/r/325064 (https://phabricator.wikimedia.org/T97513) (owner: 10Paladox) [16:27:34] PROBLEM - Free space - all mounts on integration-slave-k8s-1013 is CRITICAL: CRITICAL: integration.integration-slave-k8s-1013.diskspace.root.byte_percentfree (<40.00%) [16:41:57] PROBLEM - SSH on integration-slave-docker-1003 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [16:46:03] greg-g: thanks! [16:46:49] RECOVERY - SSH on integration-slave-docker-1003 is OK: SSH OK - OpenSSH_6.7p1 Debian-5+deb8u4 (protocol 2.0) [16:55:16] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4097703 (10Tgr) MobileFrontend is the top non-bundled extension in ExtensionDownload... [16:57:58] (03CR) 10Hashar: [C: 032] Test quibble.backend.getDBClass [integration/quibble] - 10https://gerrit.wikimedia.org/r/423473 (owner: 10Hashar) [16:58:25] (03Merged) 10jenkins-bot: Test quibble.backend.getDBClass [integration/quibble] - 10https://gerrit.wikimedia.org/r/423473 (owner: 10Hashar) [17:26:15] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Phlogiston (Reporting): Phlogiston reports don't have new data since mid-February - https://phabricator.wikimedia.org/T188149#4097807 (10JAufrecht) [17:28:27] 10Release-Engineering-Team (Kanban), 10Discovery, 10Wikidata, 10Wikidata-Query-Service, 10User-Smalyshev: Set up user for automatic WDQS GUI builds - https://phabricator.wikimedia.org/T189811#4097819 (10Smalyshev) [17:28:55] Hi! Could I get some help on https://phabricator.wikimedia.org/T189811 - namely on setting up credentials stuff? [17:36:36] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Phlogiston (Reporting): Phlogiston reports don't have new data since mid-February - https://phabricator.wikimedia.org/T188149#4097850 (10JAufrecht) a:05mmodell>03JAufrecht I've fixed a number of obvious bugs in the new code; still quality-testing the... [17:37:33] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Phlogiston (Reporting): Phlogiston reports don't have new data since mid-February - https://phabricator.wikimedia.org/T188149#4097853 (10mmodell) Thanks @JAufrecht. Would it be helpful to convert the data now to the new format? If there are still issues... [17:44:30] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Phlogiston (Reporting): Phlogiston reports don't have new data since mid-February - https://phabricator.wikimedia.org/T188149#4097891 (10JAufrecht) It shouldn't make any difference; the code works with both formats. I haven't yet identified anything that... [18:10:49] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4098082 (10CCicalese_WMF) For those four additional extensions, here are the statist... [18:34:37] PROBLEM - App Server Main HTTP Response on deployment-mediawiki07 is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 hphp_invoke - string 'Wikipedia' not found on 'http://en.wikipedia.beta.wmflabs.org:80/wiki/Main_Page?debug=true' - 287 bytes in 0.044 second response time [18:35:58] PROBLEM - Puppet errors on deployment-etcd-01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:53:18] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4098201 (10Tgr) The vagrant role for MobileFrontend just sets a couple PHP globals a... [18:54:28] PROBLEM - Puppet errors on deployment-secureredirexperiment is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:56:42] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4098205 (10Tgr) VisualEditor is the top download via ExtensionDistributor and very p... [19:02:32] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4098218 (10Tgr) LoginNotify and OATHAuth are too new to show up in those lists but t... [19:39:36] PROBLEM - Puppet errors on deployment-kafka05 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:41:30] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4098304 (10Mholloway) >>! In T178349#4098201, @Tgr wrote: > The vagrant role for Mob... [19:41:31] PROBLEM - Puppet errors on deployment-kafka04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [19:43:19] status update for 1.31.0-wmf.27: Currently working through more problems (still tracked under T190960) but group1 is on the new branch and hopefully group2 will happen sometime today [19:43:19] T190960: 1.31.0-wmf.27 rolled back due to increase in fatals: "Replication wait failed: lost connection to MySQL server during query" - https://phabricator.wikimedia.org/T190960 [20:13:43] no_justification http://gerrit-wm.wmflabs.org/r/q/status:open :) (it's secure, no one can log into it, only allows anon browsing) [20:15:32] http://gerrit-wm.wmflabs.org/r/admin/repos/mediawiki/core [20:19:16] takes a minute to load [20:19:16] !log deployed to BC: [mobileapps/deploy@940bd48]: Update mobileapps to 58a0a88 [20:19:18] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:30:21] i pinged in #operations earlier, but does anyone know why i cannot log onto wmnet anymore? do we need to update credentials or puppet somewhere post changes of the deployment and bast servers? [20:30:37] subbu are you using bas1001? [20:30:41] or bast1002? [20:30:48] 1002 [20:31:14] ok, not sure then. [20:34:02] http://gerrit-wm.wmflabs.org/r/q/owner:thomasmulhall410%2540yahoo.com [20:34:26] joining dates will be wrong if it's anytime before the 25 of july 2016 [20:36:10] PROBLEM - Host integration-slave-k8s-1013 is DOWN: CRITICAL - Host Unreachable (10.68.23.238) [20:41:48] 10Phabricator, 10Release-Engineering-Team (Kanban), 10Phlogiston (Reporting): Phlogiston reports don't have new data since mid-February - https://phabricator.wikimedia.org/T188149#4098574 (10JAufrecht) 05Open>03Resolved I think this fix has passed enough spot testing to be generally considered resolved.... [20:46:47] 10Release-Engineering-Team, 10DNS, 10Operations, 10Traffic, and 2 others: Move Foundation Wiki to new URL when new Wikimedia Foundation website launches - https://phabricator.wikimedia.org/T188776#4098592 (10Varnent) Just to be clear around expectations - Foundation Wiki is managed by the Foundation and is... [21:01:48] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4098617 (10demon) >>! In T178349#4098201, @Tgr wrote: > Come to think of it, should... [21:08:21] PROBLEM - Puppet errors on deployment-mx02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [21:10:23] fixed .. i had a stray bast1001 reference in my ssh config. [21:11:17] \o/ [21:12:29] PROBLEM - Puppet errors on integration-slave-k8s-1014 is CRITICAL: CRITICAL: 20.00% of data above the critical threshold [0.0] [21:17:07] 10Gerrit: Enable avatars in gerrit - https://phabricator.wikimedia.org/T191183#4096194 (10demon) `avatars-gravatar` I am not installing. I did once, and was very quickly told not remove it. While that Wordpress proxy plugin solves the problem of performance/caching and exposing your IP to them, it still sends th... [21:18:18] 10Gerrit: Enable avatars in gerrit - https://phabricator.wikimedia.org/T191183#4098658 (10Paladox) I think we could do a avatars-commons or the phab one, but with phab it was slow when we used there conduit. [21:31:28] RECOVERY - Mediawiki Error Rate on graphite-labs is OK: OK: Less than 1.00% above the threshold [1.0] [21:32:22] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.28 deployment blockers - https://phabricator.wikimedia.org/T183967#4098681 (10mmodell) [21:32:25] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T183966#4098682 (10mmodell) [21:42:28] RECOVERY - Puppet errors on integration-slave-k8s-1014 is OK: OK: Less than 1.00% above the threshold [0.0] [21:42:51] paladox: was reading https://gerrit-documentation.storage.googleapis.com/Documentation/2.15/dev-plugins.html#user-settings-screen....is there a similar way to do it in Polygerrit? [21:42:57] Like, a simple way to add a preference? [21:43:26] no_justification not currently, though i really have been thinking about something like that [21:43:40] would go along well with my plan for custom themes (through preference) [21:44:11] I'm thinking about this re: avatars. [21:44:29] Like, sometimes we want them to specify a custom thing, not just rely on ${user} and ${email} substitution [21:44:38] yep [21:45:29] The other way I could see it happening work would be using ${user} and ${email} but having like an All-Avatars repo or something [21:45:37] 10Phabricator (Upstream), 10MediaWiki-Vagrant, 10Upstream: Phabricator doesn't run with PHP 7.0 (default on Stretch) - https://phabricator.wikimedia.org/T185287#3911921 (10Ebe123) When using a pp for 7.2 then enabling the `phabricator` module, `vagrant provision` fails: ``` ==> default: Error: /usr/local/bin... [21:45:42] no_justification aha [21:45:47] no_justification yes [21:45:52] i was thinking of the same thing [21:45:56] i created this: [21:45:58] Or plugin/avatars-ondisk/data [21:46:03] Another clever way :) [21:46:15] https://gerrit-new.wmflabs.org/r/plugins/gitiles/avatar-gerrit [21:46:43] no_justification oh yes [21:46:48] that would be better :) [21:47:18] since we could call https://gerrit.wikimedia.org/r/plugin/avatars-ondisk/data//name.png [21:49:04] no_justification there's also this one https://gerrit-review.googlesource.com/admin/repos/plugins/imagare [21:49:36] though that's currently broken with 2.15 and master [21:50:51] It tries to do both internal and external images. Why? [21:50:52] Lol [21:51:36] heh [21:54:49] I think avatars-ondisk and using the plugin directory would be easiest :) [21:54:54] :) [21:55:18] PROBLEM - Host integration-slave-k8s-1014 is DOWN: CRITICAL - Host Unreachable (10.68.19.135) [21:56:37] no_justification we should also add fallback to the default image too :) [22:04:33] 10Continuous-Integration-Config, 10Security-Team, 10phan-taint-check-plugin, 10MW-1.31-release, and 2 others: Make jenkins run phan-taint-check-plugin non-voting and then voting - https://phabricator.wikimedia.org/T182599#4098733 (10Legoktm) I'd like to aim to get this implemented by 1.31 branching to show... [22:07:50] no_justification i am not sure if polygerrit will use a seperate url for plugins settings (user settings) [22:07:57] i think they may store it on /settings/ [22:11:36] * paladox has filled a task for a redesgn of the admin ui in polygerrit [22:27:34] PROBLEM - Puppet errors on integration-slave-k8s-1015 is CRITICAL: CRITICAL: 55.56% of data above the critical threshold [0.0] [22:32:33] RECOVERY - Puppet errors on integration-slave-k8s-1015 is OK: OK: Less than 1.00% above the threshold [0.0] [22:44:01] paladox: I did a thing: https://github.com/demon/avatars-ondisk [22:44:27] oh [22:44:29] * paladox tests [22:44:42] bin/? [22:44:44] https://github.com/demon/avatars-ondisk/blob/master/bin/src/main/java/com/googlesource/gerrit/plugins/avatars/ondisk/OnDiskAvatarProvider.class [22:45:24] Whoops [22:45:37] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T183966#4098910 (10mmodell) [22:45:49] gone hehe [22:45:58] heh :) [22:46:01] * paladox builds it [22:46:02] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T183966#3868571 (10mmodell) [22:46:49] Untested beyond "does it build" [22:46:54] It may break immediately :p [22:47:07] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.28 deployment blockers - https://phabricator.wikimedia.org/T183967#4098915 (10mmodell) [22:47:10] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T183966#3868571 (10mmodell) [22:47:15] no_justification it works [22:47:20] (as in loaded) [22:47:22] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.28 deployment blockers - https://phabricator.wikimedia.org/T183967#3868579 (10mmodell) [22:47:25] https://gerrit.git.wmflabs.org/r/plugins/avatars-ondisk/Documentation/index.html [22:47:26] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T183966#3868571 (10mmodell) [22:47:35] * paladox wonders how to get the images uploaded? [22:47:44] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T183966#4098931 (10mmodell) 05Open>03Resolved [22:48:42] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4098945 (10Legoktm) I can't see it being appropriate and consistent with our values... [22:48:53] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.28 deployment blockers - https://phabricator.wikimedia.org/T183967#3868579 (10mmodell) p:05Normal>03High [22:49:05] paladox: In our case, I was thinking like a dedicated git repo that we'd deploy automatically with puppet (ensure latest?) [22:49:13] So you just upload your foouser.png [22:49:14] ah [22:49:15] And bam? [22:49:23] yay /me tests then :) [22:49:41] no_justification does it default to default.png if it carn't find a image? [22:49:50] I guess that relies on people assuming good faith and not overwriting someone else's avatar [22:50:07] yeh [22:50:23] though gerrit has low spam, as it's only code review :) [22:50:32] Nope it defaults to null, for no avatar [22:51:11] no_justification oh, if it does that it shows no images [22:51:20] thus polygerrit show a silver background circle [22:51:22] like this: [22:51:27] Just for that individual person [22:51:44] https://phabricator.wikimedia.org/F16603433 [22:52:04] All I see is page-not-implemented? [22:52:18] see the top [22:52:23] and to the right [22:52:32] next to the search bar [22:52:32] Ah. But what if you have a username.png? [22:52:41] * paladox is testing that :) [22:52:49] no_justification what is the path for the folder? [22:53:00] Ummm, data/plugins/name/data? [22:53:02] Maybe? [22:53:54] so /var/lib/gerrit2/review_site/plugins//data [22:54:55] No, I was thinking it was /var/lib/gerrit2/review_site/data/plugins/avatars-ondisk/data? [22:54:59] ah [22:55:05] Idk really :) [22:57:06] no_justification i think that's correct [22:57:42] no_justification drwxr-xr-x 2 gerrit2 gerrit2 4096 Apr 2 22:46 avatars-ondisk [22:57:44] lol [22:57:50] it created the folder for me [22:59:12] Probably because of the plugin annotation use. That's nice of it [23:01:18] heh [23:03:33] no_justification dosen't seem to work url wise [23:03:33] https://gerrit.git.wmflabs.org/r/plugin/avatars-ondisk/data/paladox.png [23:03:47] boo [23:03:59] https://phabricator.wikimedia.org/P6926 [23:04:19] Well plugins/ for one [23:04:23] But still 404 [23:04:56] Oh crud, it doesn't expose that by default I bet. I probably need to make an Http endpoint [23:04:58] Or something [23:05:24] no_justification yeh [23:05:27] i think that too [23:05:31] looking at the console [23:05:41] it seems it found the avatar endpoint for my user [23:05:51] as it's only throwing now for user with account id 2 [23:07:32] 10Phabricator (Upstream), 10MediaWiki-Vagrant, 10Upstream: Phabricator doesn't run with PHP 7.0 (default on Stretch) - https://phabricator.wikimedia.org/T185287#4099003 (10bd808) >>! In T185287#4098691, @Ebe123 wrote: > When using a pp for 7.2 then enabling the `phabricator` module, `vagrant provision` fails... [23:10:11] (03CR) 10Legoktm: [C: 04-1] Prohibit PHP's vanilla execution (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/423030 (owner: 10MaxSem) [23:12:42] (03CR) 10Legoktm: [C: 04-1] Prohibit PHP's vanilla execution (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/423030 (owner: 10MaxSem) [23:19:14] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4099040 (10demon) >>! In T178349#4098945, @Legoktm wrote: > I can't see it being app... [23:21:35] no_justification i guess something like https://github.com/GerritCodeReview/plugins_gitiles/blob/master/src/main/java/com/googlesource/gerrit/plugins/gitiles/HttpModule.java [23:21:40] for the avatar plugin [23:24:11] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4099058 (10CCicalese_WMF) >>! In T178349#4099040, @demon wrote: >>>! In T178349#4098... [23:26:59] no_justification oh wait [23:27:05] what if we stored it in static? [23:27:22] that's accessible [23:27:24] and we could do [23:27:28] data/avatars [23:30:55] uh i mean static/avatars [23:30:59] so full path would be [23:31:20] /var/lib/gerrit2/review_site/static/avatars/.png [23:31:41] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4099085 (10CCicalese_WMF) >>! In T178349#4098617, @demon wrote: >>>! In T178349#4098... [23:32:34] no_justification is this SitePath exposed to plugins? [23:33:58] and also not sure how we would get the file if we created the repo [23:34:08] uh never mind heh :) [23:35:36] yay it does [23:35:36] https://github.com/GerritCodeReview/plugins_hooks-its/blob/0318d7c9ecc6d125982e4022ff4f4625b604b3ae/hooks-its/src/main/java/com/googlesource/gerrit/plugins/hooks/workflow/RuleBase.java#L53 [23:38:18] oh there's [23:38:19] SitePaths [23:48:55] no_justification oh yayayayay [23:48:57] it worked [23:49:00] woopeee [23:49:10] check me out [23:49:11] https://gerrit.git.wmflabs.org/r/c/3/ [23:49:14] im a red cross [23:49:15] lol [23:50:39] im now my profile picture from phab [23:50:57] no_justification i will import your repo, if you have no objections? :) [23:51:04] then i can create my change against it [23:51:09] for your review [23:51:19] though i will wait for your yes before doing anything for now [23:51:55] Import to....? [23:52:04] gerrit.wikimedia.org [23:52:33] Ahh. I figured we could upstream it since I wrote it standalone [23:52:33] :) [23:52:34] i guess i should let you do it no_justification so that it has you as the author on the first upload [23:52:38] oh [23:52:40] yeh [23:52:44] though that may take time [23:55:55] * no_justification shrugs [23:55:58] No rush [23:56:11] ok [23:56:53] no_justification https://github.com/demon/avatars-ondisk/pull/1 [23:57:52] no_justification also should we use .toLowerCase() for user files? [23:58:15] I don't think so. Or if we did, it should vary based on settings [23:58:23] You could have UsEr on some configs, but not ours [23:59:11] yep [23:59:12] no_justification you mean for the lower case part? [23:59:13] or the static/ part? [23:59:38] Lower case [23:59:56] ok :)