[00:02:10] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<11.11%) [00:03:26] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Patch-For-Review, 10User-zeljkofilipin: Use a more complex password for WikiAdmin in selenium tests - https://phabricator.wikimedia.org/T188520#4010763 (10Krinkle) @Reedy @zeljkofilipin Merging/deploying this... [00:07:41] (03PS2) 10Krinkle: Use a more complex password for wikiadmin user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/415312 (https://phabricator.wikimedia.org/T188520) (owner: 10Reedy) [00:08:29] (03PS3) 10Krinkle: Use a more complex password for wikiadmin user [integration/jenkins] - 10https://gerrit.wikimedia.org/r/415312 (https://phabricator.wikimedia.org/T188520) (owner: 10Reedy) [00:08:55] (03PS4) 10Krinkle: Expose wikiadmin user/pass via env and use a more complex password [integration/jenkins] - 10https://gerrit.wikimedia.org/r/415312 (https://phabricator.wikimedia.org/T188520) (owner: 10Reedy) [00:09:09] (03CR) 10Krinkle: [C: 031] Expose wikiadmin user/pass via env and use a more complex password [integration/jenkins] - 10https://gerrit.wikimedia.org/r/415312 (https://phabricator.wikimedia.org/T188520) (owner: 10Reedy) [00:20:55] Yippee, build fixed! [00:20:55] Project mediawiki-core-code-coverage-php7 build #205: 09FIXED in 1 hr 1 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-php7/205/ [00:23:31] YAY [00:27:44] twentyafterfour performance with phab (using php7.2) is really good [00:27:49] legoktm or Reedy: sanity check https://gerrit.wikimedia.org/r/#/c/415312/ ? [00:28:04] we upgraded a server today, and it would load the site slowly under php5 [00:28:14] as soon as we upgraded to 7.2 it started working instantly [00:28:37] paladox: good to know, nice! [00:28:42] mutante :) [00:31:17] PROBLEM - Long lived cherry-picks on puppetmaster on deployment-puppetmaster02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [00:31:27] heh [00:31:50] eats some cherries [00:42:46] (03CR) 10Krinkle: [C: 04-1] "The qunit ones use Apache. Setting PHP_BIN doesn't cut it afaik. It needs to use a different base image most likely, and/or Apache configu" [integration/config] - 10https://gerrit.wikimedia.org/r/426115 (https://phabricator.wikimedia.org/T190548) (owner: 10Jforrester) [00:43:39] legoktm: btw, code-coverage can go to php7 only now, right? [00:45:20] btw, the fixing of that db error for code-coverage-php7 wasn't blocking afaik, because the php5 was was having the same error. [00:45:28] but it's good to make sure there's no other error behind it I suppose [00:49:24] (03Abandoned) 10Krinkle: Run RemexHtml coverage on PHP 7 [integration/config] - 10https://gerrit.wikimedia.org/r/386679 (https://phabricator.wikimedia.org/T179055) (owner: 10Legoktm) [00:50:04] 10Continuous-Integration-Config, 10RemexHtml, 10Patch-For-Review, 10Test-Coverage: Figure out how to speed up RemexHtml coverage runs - https://phabricator.wikimedia.org/T179055#4131258 (10Krinkle) 05Open>03Resolved a:03Krinkle Got fixed by @hashar with {c860504d5a709a399eaba44b25194130082bc5f6} ( Krinkle: We need a baseline PHP 5 run to compare historically before we swap to PHP 7 because it'll calculate differently [01:25:47] legoktm: Hm.. okay, so what does that mean for CI config. [01:25:55] When are we going to drop the php5 coverage job [01:33:51] Krinkle: after this run finishes and https://tools.wmflabs.org/coverage/mediawiki/chart.png picks it up :) [01:36:10] OK [01:36:23] Yippee, build fixed! [01:36:23] Project mediawiki-core-code-coverage build #3444: 09FIXED in 2 hr 17 min: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/3444/ [01:40:19] 10MediaWiki-Releasing, 10MW-1.31-release: Bundle CodeEditor extension with MW 1.31 - https://phabricator.wikimedia.org/T191742#4131326 (10Legoktm) [01:42:20] 10MediaWiki-Releasing, 10MW-1.31-release: Bundle CodeEditor extension with MW 1.31 - https://phabricator.wikimedia.org/T191742#4115166 (10Legoktm) https://gerrit.wikimedia.org/r/#/q/topic:T191742-cleanup [01:43:23] (03PS1) 10Legoktm: Bundle CodeEditor extension [tools/release] - 10https://gerrit.wikimedia.org/r/426369 (https://phabricator.wikimedia.org/T191742) [01:44:27] yay [01:50:24] https://tools.wmflabs.org/coverage/mediawiki/chart.png [01:53:02] Krinkle: ok, we can swap it now [01:57:13] (03Abandoned) 10Legoktm: [WIP] mwext-test-php70-sqlite image [integration/config] - 10https://gerrit.wikimedia.org/r/416213 (owner: 10Legoktm) [01:57:20] (03Abandoned) 10Legoktm: Create integration-jenkins image [integration/config] - 10https://gerrit.wikimedia.org/r/416212 (owner: 10Legoktm) [01:57:51] (03Abandoned) 10Legoktm: ci-src-setup: Add setup-mwext-vendor.sh and documentation [integration/config] - 10https://gerrit.wikimedia.org/r/416203 (owner: 10Legoktm) [02:02:37] (03PS1) 10Legoktm: Run MediaWiki coverage job with PHP 7 [integration/config] - 10https://gerrit.wikimedia.org/r/426377 (https://phabricator.wikimedia.org/T147778) [02:07:43] legoktm: is the other one not in config.git? [02:07:49] I'd expect a job removal as well [02:10:16] (03CR) 10Krinkle: [C: 031] Run MediaWiki coverage job with PHP 7 [integration/config] - 10https://gerrit.wikimedia.org/r/426377 (https://phabricator.wikimedia.org/T147778) (owner: 10Legoktm) [02:10:20] Hm.. guess not [02:10:48] it's not [02:11:09] I'll delete it once I deploy that [02:12:08] k [02:12:11] Gogo :) [02:21:34] one of my firefox addons is deleting cookies too aggressively, and that's making jenkins constantly refresh the console log page [02:48:08] (03CR) 10Legoktm: [C: 032] "INFO:jenkins_jobs.builder:Number of jobs generated: 1" [integration/config] - 10https://gerrit.wikimedia.org/r/426377 (https://phabricator.wikimedia.org/T147778) (owner: 10Legoktm) [02:49:53] (03Merged) 10jenkins-bot: Run MediaWiki coverage job with PHP 7 [integration/config] - 10https://gerrit.wikimedia.org/r/426377 (https://phabricator.wikimedia.org/T147778) (owner: 10Legoktm) [02:50:59] hmm, it's still using php5 for composer [03:42:36] Project mwext-phpunit-coverage-publish build #3378: 04FAILURE in 3.6 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/3378/ [03:45:37] Yippee, build fixed! [03:45:37] Project mwext-phpunit-coverage-publish build #3379: 09FIXED in 1 min 14 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/3379/ [06:20:46] Krinkle: So... how do we make a new base image? [06:51:43] base image for? [07:32:36] 10Release-Engineering-Team, 10Epic, 10WMF-deploy-2015-06-30_(1.26wmf12): [EPIC] Encourage developers to increase code coverage - https://phabricator.wikimedia.org/T100294#4131496 (10Legoktm) [07:32:40] 10Continuous-Integration-Config, 10Release-Engineering-Team (Someday), 10Patch-For-Review, 10Test-Coverage: Switch MediaWiki coverage job from PHP 5 to PHP 7 - https://phabricator.wikimedia.org/T147778#4131495 (10Legoktm) [07:59:01] 10MediaWiki-Releasing, 10MW-1.31-release: Bundle Multimedia Viewer extension with MW 1.31 - https://phabricator.wikimedia.org/T191744#4131499 (10Legoktm) [07:59:53] 10MediaWiki-Releasing, 10MW-1.31-release: Bundle Multimedia Viewer extension with MW 1.31 - https://phabricator.wikimedia.org/T191744#4115186 (10Legoktm) I tested with the web installer, using both instant commons and a local upload. both worked :) [08:10:27] (03PS1) 10Legoktm: Run phan for MultimediaViewer [integration/config] - 10https://gerrit.wikimedia.org/r/426548 [08:11:28] 10MediaWiki-Releasing, 10MW-1.31-release: Bundle Multimedia Viewer extension with MW 1.31 - https://phabricator.wikimedia.org/T191744#4131503 (10Legoktm) Cleanup: https://gerrit.wikimedia.org/r/#/q/topic:T191744-cleanup Phan: https://gerrit.wikimedia.org/r/#/c/426547/ [08:13:42] (03CR) 10Legoktm: "Which Apache configuration is it using? Is it puppet/modules/contint/templates/apache/localvhost.erb ?" [integration/config] - 10https://gerrit.wikimedia.org/r/426115 (https://phabricator.wikimedia.org/T190548) (owner: 10Jforrester) [09:09:22] 10Continuous-Integration-Config, 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10Patch-For-Review, 10User-zeljkofilipin: Use a more complex password for WikiAdmin in selenium tests - https://phabricator.wikimedia.org/T188520#4131548 (10Reedy) Works for me, yeah. Obviously (you mention a cl... [09:15:54] (03PS1) 10Legoktm: Run phan for ReplaceText [integration/config] - 10https://gerrit.wikimedia.org/r/426578 [09:23:10] (03CR) 10Thiemo Kreuz (WMDE): "In the first round of optimizations I did before version 17 I focused on actual bottlenecks I found while profiling. This round of patches" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/425504 (owner: 10Thiemo Kreuz (WMDE)) [09:27:04] (03CR) 10Thiemo Kreuz (WMDE): "I don't mind. Merge or squash in whatever order you prefer." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/426002 (owner: 10Thiemo Kreuz (WMDE)) [10:04:34] (03PS1) 10Hashar: tcp_wait: use a different socket on each retry [integration/quibble] - 10https://gerrit.wikimedia.org/r/426600 [10:10:01] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 18.0.0 [integration/docroot] - 10https://gerrit.wikimedia.org/r/426617 (owner: 10Libraryupgrader) [10:10:36] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 18.0.0 [integration/docroot] - 10https://gerrit.wikimedia.org/r/426617 (owner: 10Libraryupgrader) [10:11:18] (03PS2) 10Hashar: Relay chromedriver stderr at WARNING level [integration/quibble] - 10https://gerrit.wikimedia.org/r/426242 [10:14:04] (03CR) 10jerkins-bot: [V: 04-1] Relay chromedriver stderr at WARNING level [integration/quibble] - 10https://gerrit.wikimedia.org/r/426242 (owner: 10Hashar) [10:18:14] (03CR) 10Thiemo Kreuz (WMDE): "Uh, nice. Thanks a lot for all the reviews and the fast release!" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/426133 (owner: 10Legoktm) [10:43:30] 10Continuous-Integration-Config, 10MediaWiki-Core-Tests, 10Test-Coverage: Figure out some way to not use addUncoveredFilesFromWhitelist="true" when running only some PHPUnit tests - https://phabricator.wikimedia.org/T192078#4131584 (10Legoktm) > a simple solution would be to change it to false in the repo an... [13:45:05] 10Phabricator (Upstream), 10Upstream: Get my created tasks, get my created tasks or commented by me, get the tasks of a project - https://phabricator.wikimedia.org/T150527#4131668 (10Aklapper) 05Open>03Invalid Existing solutions provided in T150527#2790892 hence closing. [13:46:45] 10Phabricator (Upstream), 10Accessibility, 10JavaScript, 10Upstream: A lot of functionality in Phabricator is missing / not working when JavaScript is off in the browser - https://phabricator.wikimedia.org/T147134#4131674 (10Aklapper) [13:46:49] 10Phabricator (Upstream), 10Accessibility, 10Upstream: "Show Older Changes" in Maniphest tasks not working in browsers with JavaScript disabled - https://phabricator.wikimedia.org/T147132#4131672 (10Aklapper) 05Open>03declined Upstream has no plans to work on this (see https://secure.phabricator.com/T105... [13:49:44] 10Phabricator (Upstream), 10Upstream: Indicate what page of results is the current page and the number of pages - https://phabricator.wikimedia.org/T148931#4131676 (10Aklapper) 05Open>03Resolved The current page has a `current` CSS class which defines a margin (`border-color: #333;`) nowadays. This is a su... [13:54:09] 10Phabricator (Upstream), 10Upstream: Expanded long task title ("{T9999999}" markup) does not wrap in task description, so cannot be read fully - https://phabricator.wikimedia.org/T148829#4131681 (10Aklapper) p:05Low>03Lowest [13:56:15] 10Phabricator, 10MediaWiki-Authentication-and-authorization: Phabricator (on iPhone) gives login error and incorrectly says that I have disabled cookies - https://phabricator.wikimedia.org/T132268#4131683 (10Aklapper) 05Open>03declined Nobody else has managed to reproduce this in the last 2 years, so I am... [13:56:39] 10Phabricator (Upstream), 10Upstream: Search by commenter on Phabricator - https://phabricator.wikimedia.org/T98326#4131685 (10Aklapper) p:05Low>03Lowest [14:08:30] 10MediaWiki-Codesniffer, 10Security-Team, 10Security: Security related Static Analysis - https://phabricator.wikimedia.org/T192207#4131691 (10Reedy) [14:09:48] 10Phabricator (Upstream), 10Upstream: Write correctly and normally, not With Absurd Capital Letters Everywhere - https://phabricator.wikimedia.org/T147131#4131701 (10Aklapper) 05Open>03declined Declining as per previous comment - tastes differ and I don't see a problem big enough here to justify maintainin... [14:11:09] 10Phabricator (Upstream), 10Upstream: Specific diff of a description edit in a task shows an additional full stop (which is in the task description) - https://phabricator.wikimedia.org/T148906#4131703 (10Aklapper) 05Open>03Resolved This problem cannot be reproduced anymore - somehow it fixed itself in the... [14:12:39] 10Phabricator (Upstream), 10Upstream: Tags: Use the entered text for the search, and stop erasing the entered text in the field Tags - https://phabricator.wikimedia.org/T150522#4131705 (10Aklapper) 05Open>03declined As far as I know there are no plans to change the current behavior and the last comment exp... [14:15:14] 10Phabricator: After "Login to comment", I land at the home page of Phabricator - https://phabricator.wikimedia.org/T132335#4131707 (10Aklapper) In upstream this works according to https://secure.phabricator.com/T6870 , but for Wikimedia the issue is the OAuth redirect to mediawiki.org [14:16:57] 10Phabricator (Upstream), 10Upstream: The screen “Change Details” cuts the line in the middle of a word - https://phabricator.wikimedia.org/T91929#4131709 (10Aklapper) 05Open>03Resolved This is not a problem anymore nowadays. [14:18:49] 10Phabricator, 10MediaWiki-Authentication-and-authorization: Phabricator asks to log in but does not show SUL dialog, and traps the user (starting on www.mediawiki.org and ending on m.mediawiki.org?) - https://phabricator.wikimedia.org/T131697#4131711 (10Aklapper) p:05Triage>03Low [14:47:27] 10Continuous-Integration-Config, 10Librarization, 10Security-Team, 10Composer, and 2 others: Expand our usage of FriendsOfPHP/security-advisories - https://phabricator.wikimedia.org/T180278#4131722 (10Reedy) Another is https://github.com/sensiolabs/security-checker too [15:22:30] 10Beta-Cluster-Infrastructure, 10Scoring-platform-team, 10Beta-Cluster-reproducible: FetchScoreJob is trying to update scores for nonexistent models - https://phabricator.wikimedia.org/T177967#4131742 (10Ladsgroup) I think I know what's going on here, these are being overwritten by prod settings. I will get... [17:19:25] 10Beta-Cluster-Infrastructure, 10Scoring-platform-team, 10Beta-Cluster-reproducible: FetchScoreJob is trying to update scores for nonexistent models - https://phabricator.wikimedia.org/T177967#4131819 (10Ladsgroup) This has been resolved very long time ago. [17:19:35] 10Beta-Cluster-Infrastructure, 10Scoring-platform-team, 10Beta-Cluster-reproducible: FetchScoreJob is trying to update scores for nonexistent models - https://phabricator.wikimedia.org/T177967#4131820 (10Ladsgroup) 05Open>03Resolved [18:38:05] 10Phabricator (Upstream), 10Upstream: Keep the Phabricator toolbar on the top visible when scrolling down - https://phabricator.wikimedia.org/T191540#4131870 (10Johnywhy) [18:44:57] 10Phabricator (Upstream), 10Upstream: Keep the Phabricator toolbar on the top visible when scrolling down - https://phabricator.wikimedia.org/T191540#4131884 (10Johnywhy) @Aklapper ok, thx [20:09:56] 10Continuous-Integration-Infrastructure: Get rid of the check pipeline - https://phabricator.wikimedia.org/T192217#4131942 (10EddieGP) [20:10:35] 10Continuous-Integration-Infrastructure: Get rid of the check pipeline - https://phabricator.wikimedia.org/T192217#4131942 (10EddieGP) [20:52:23] Project mwext-phpunit-coverage-publish build #3427: 04FAILURE in 2 min 3 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/3427/ [20:53:36] Yippee, build fixed! [20:53:36] Project mwext-phpunit-coverage-publish build #3428: 09FIXED in 1 min 12 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/3428/ [21:10:07] (03CR) 10Hashar: [C: 032] tcp_wait: use a different socket on each retry [integration/quibble] - 10https://gerrit.wikimedia.org/r/426600 (owner: 10Hashar) [21:10:39] (03Merged) 10jenkins-bot: tcp_wait: use a different socket on each retry [integration/quibble] - 10https://gerrit.wikimedia.org/r/426600 (owner: 10Hashar) [21:54:52] (03PS3) 10Hashar: Relay chromedriver stderr at WARNING level [integration/quibble] - 10https://gerrit.wikimedia.org/r/426242 [21:54:54] (03PS1) 10Hashar: Remove obsolete mocking in TestChromeWebDriver [integration/quibble] - 10https://gerrit.wikimedia.org/r/426727 [21:56:44] (03CR) 10Hashar: [C: 032] Relay chromedriver stderr at WARNING level [integration/quibble] - 10https://gerrit.wikimedia.org/r/426242 (owner: 10Hashar) [21:56:48] (03CR) 10Hashar: [C: 032] Remove obsolete mocking in TestChromeWebDriver [integration/quibble] - 10https://gerrit.wikimedia.org/r/426727 (owner: 10Hashar) [21:57:09] (03Merged) 10jenkins-bot: Relay chromedriver stderr at WARNING level [integration/quibble] - 10https://gerrit.wikimedia.org/r/426242 (owner: 10Hashar) [21:57:15] (03Merged) 10jenkins-bot: Remove obsolete mocking in TestChromeWebDriver [integration/quibble] - 10https://gerrit.wikimedia.org/r/426727 (owner: 10Hashar) [21:57:43] (03CR) 10Hashar: "recheck" [integration/quibble] - 10https://gerrit.wikimedia.org/r/426280 (owner: 10Hashar) [21:57:50] (03CR) 10jerkins-bot: [V: 04-1] Fix up hhvm server logging [integration/quibble] - 10https://gerrit.wikimedia.org/r/426280 (owner: 10Hashar) [21:57:55] (03CR) 10Hashar: [C: 04-2] Fix up hhvm server logging [integration/quibble] - 10https://gerrit.wikimedia.org/r/426280 (owner: 10Hashar) [22:00:06] (03PS3) 10Hashar: Fix up hhvm server logging [integration/quibble] - 10https://gerrit.wikimedia.org/r/426280