[00:22:39] 10MediaWiki-Releasing, 10MediaWiki-extensions-LoginNotify, 10MW-1.31-release: Bundle LoginNotify extension with MW 1.31 - https://phabricator.wikimedia.org/T191746#4134923 (10cicalese) [00:22:49] 10MediaWiki-Releasing, 10MediaWiki-extensions-CategoryTree, 10MW-1.31-release: Bundle CategoryTree extension with MW 1.31 - https://phabricator.wikimedia.org/T191735#4134924 (10cicalese) [00:23:23] 10MediaWiki-Releasing, 10MediaWiki-extensions-Scribunto, 10MW-1.31-release, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Bundle Scribunto extension with MW 1.31 - https://phabricator.wikimedia.org/T191737#4134926 (10cicalese) [00:23:39] Krinkle: for some reason it doesn't seem like https://github.com/sebastianbergmann/phpunit/commit/052d8bc91b3df5be4d40fe7a904e46f1f2242894 is working in the coverage report that was just generated [00:24:10] 10MediaWiki-Releasing, 10MediaWiki-extensions-ReplaceText, 10MW-1.31-release: Bundle Replace Text extension with MW 1.31 - https://phabricator.wikimedia.org/T191741#4134929 (10cicalese) [00:24:21] Krinkle: err, nvm. varnish caching [00:24:22] legoktm: You mean depr code is not auto-covered or is auto-covered? [00:24:38] afaik it's auto-covered/ignored and always has been. [00:24:42] That com.... ok :) [00:24:54] That commit makes it configurable but afaik we don't use that. [00:25:01] PHPUnit 4 auto-covered deprecated code, PHPUnit 6 disabled that by default [00:25:08] oh, interesting [00:25:17] 10MediaWiki-Releasing, 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10MW-1.31-release, 10Patch-For-Review: Bundle Multimedia Viewer extension with MW 1.31 - https://phabricator.wikimedia.org/T191744#4134930 (10cicalese) [00:25:19] it became configurable and changed its default [00:25:21] Hm. [00:25:25] I suppose that's fair in a major release. [00:25:26] https://github.com/sebastianbergmann/php-code-coverage/issues/351#issuecomment-283494495 heh [00:25:42] 10MediaWiki-Releasing, 10MobileFrontend, 10MW-1.31-release, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), 10Patch-For-Review: Bundle MobileFrontend extension with MW 1.31 - https://phabricator.wikimedia.org/T191734#4134932 (10cicalese) [00:25:53] 10MediaWiki-Releasing, 10MinervaNeue, 10MW-1.31-release: Bundle Minerva Neue skin with MW 1.31 - https://phabricator.wikimedia.org/T191743#4134933 (10cicalese) [00:25:58] 10MediaWiki-Releasing, 10CodeEditor, 10MW-1.31-release, 10Patch-For-Review: Bundle CodeEditor extension with MW 1.31 - https://phabricator.wikimedia.org/T191742#4134934 (10cicalese) [00:26:10] 10MediaWiki-Releasing, 10AbuseFilter, 10MW-1.31-release, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Bundle AbuseFilter extension with MW 1.31 - https://phabricator.wikimedia.org/T191740#4134935 (10cicalese) [00:26:33] legoktm: Ha [00:26:35] Fun [00:26:40] 10MediaWiki-Releasing, 10Collaboration-Team-Triage, 10Notifications, 10MW-1.31-release: Bundle Echo extension with MW 1.31 - https://phabricator.wikimedia.org/T191738#4134938 (10cicalese) [00:26:49] legoktm: So.. we need to set it in core then, right? [00:26:55] 10MediaWiki-Releasing, 10Collaboration-Team-Triage, 10Thanks, 10MW-1.31-release: Bundle Thanks extension with MW 1.31 - https://phabricator.wikimedia.org/T191739#4134940 (10cicalese) [00:27:02] no, I wanted it disabled [00:27:03] 10MediaWiki-Releasing, 10AntiSpoof, 10MW-1.31-release: Bundle AntiSpoof extension with MW 1.31 - https://phabricator.wikimedia.org/T191736#4134942 (10cicalese) [00:27:06] It's a bad idea IMO [00:27:13] Hm.. [00:27:29] We still want accurate coverage data for e.g. Revision even though it's unused [00:27:35] I suppose we can manually ignore where intended. [00:27:52] I'm thinking of cases where features are on the way out and deprecated and never had tests. [00:28:01] e.g. to be removed next release. [00:28:11] esp standalone classes [00:28:12] 10MediaWiki-Codesniffer: Find cases where a function argument without a default is used after one with a default - https://phabricator.wikimedia.org/T192322#4134943 (10Huji) @Legoktm well then phan should have caught the example I gave, why didn't it? And the special case you mentioned should of course be ignored. [00:28:17] But yeah, perhaps not by default. [00:29:05] 10MediaWiki-Codesniffer: Find cases where a function argument without a default is used after one with a default - https://phabricator.wikimedia.org/T192322#4134944 (10Legoktm) I don't think phan is setup for AbuseFilter yet. [00:31:54] If you really wanted to, in those cases @codeCoverageIgnore would work [00:32:06] But as long as code has the potential to be called, I'd want it [00:32:17] ...want it correctly counted [00:32:38] I agree with https://github.com/sebastianbergmann/php-code-coverage/issues/351#issuecomment-156114960 might make sense for libraries, but not really applications [00:35:25] 10Continuous-Integration-Config, 10MediaWiki-General-or-Unknown, 10PHP 7.0 support: Make Wikimedia CI run PHP in either PHP 7.0+ or HHVM - https://phabricator.wikimedia.org/T190547#4134970 (10Legoktm) [00:35:30] 10Continuous-Integration-Config, 10Release-Engineering-Team (Someday), 10Patch-For-Review, 10Test-Coverage: Switch MediaWiki coverage job from PHP 5 to PHP 7 - https://phabricator.wikimedia.org/T147778#4134967 (10Legoktm) 05Open>03Resolved a:03Legoktm Thanks to @Krinkle for talking through it on IRC... [00:36:10] (03Abandoned) 10Krinkle: data-values/value-view is not a MediaWiki extension [integration/config] - 10https://gerrit.wikimedia.org/r/387986 (owner: 10Legoktm) [00:36:53] legoktm: Yeah, agreed. [01:27:32] (03CR) 10Cicalese: [C: 032] Bundle MultimediaViewer extension [tools/release] - 10https://gerrit.wikimedia.org/r/427026 (https://phabricator.wikimedia.org/T191744) (owner: 10Legoktm) [01:27:46] (03CR) 10Cicalese: [C: 032] Bundle CodeEditor extension [tools/release] - 10https://gerrit.wikimedia.org/r/426369 (https://phabricator.wikimedia.org/T191742) (owner: 10Legoktm) [01:28:22] (03Merged) 10jenkins-bot: Bundle CodeEditor extension [tools/release] - 10https://gerrit.wikimedia.org/r/426369 (https://phabricator.wikimedia.org/T191742) (owner: 10Legoktm) [01:28:27] (03Merged) 10jenkins-bot: Bundle MultimediaViewer extension [tools/release] - 10https://gerrit.wikimedia.org/r/427026 (https://phabricator.wikimedia.org/T191744) (owner: 10Legoktm) [01:31:56] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release, 10Patch-For-Review: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4135055 (10Legoktm) [02:41:43] !log Fix Jenkins config for console section "Composer" end pattern (rm mandatory .+ match from end) [02:41:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:26:31] 10MediaWiki-Releasing, 10AbuseFilter, 10MW-1.31-release, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Bundle AbuseFilter extension with MW 1.31 - https://phabricator.wikimedia.org/T191740#4135265 (10Daimona) [07:21:21] 10Continuous-Integration-Config, 10Release-Engineering-Team (Someday), 10Patch-For-Review, 10Test-Coverage: Switch MediaWiki coverage job from PHP 5 to PHP 7 - https://phabricator.wikimedia.org/T147778#4135298 (10hashar) Very well done! \O/ [07:25:21] 10Phabricator-Bot-Requests: Bot Request for Jenkins Phabricator Plugin - https://phabricator.wikimedia.org/T192337#4135300 (10Mpendulon) [07:25:25] (03CR) 10Hashar: [C: 032] Use composer unit tests for BlueSpiceAbout [integration/config] - 10https://gerrit.wikimedia.org/r/417970 (owner: 10Umherirrender) [07:26:46] (03Merged) 10jenkins-bot: Use composer unit tests for BlueSpiceAbout [integration/config] - 10https://gerrit.wikimedia.org/r/417970 (owner: 10Umherirrender) [07:31:16] (03CR) 10Hashar: [C: 032] Add RandomPages extension in zuul [integration/config] - 10https://gerrit.wikimedia.org/r/426255 (owner: 10Zoranzoki21) [07:32:32] (03Merged) 10jenkins-bot: Add RandomPages extension in zuul [integration/config] - 10https://gerrit.wikimedia.org/r/426255 (owner: 10Zoranzoki21) [07:36:01] 10Phabricator-Bot-Requests: Bot Request for Jenkins Phabricator Plugin - https://phabricator.wikimedia.org/T192337#4135324 (10Aklapper) 05Open>03stalled @Mpendulon: What is Luno and how does Luno plan to get involved in developing code in Wikimedia's software projects? Please elaborate. Are you sure you are... [07:51:12] 10Phabricator-Bot-Requests: Bot Request for Jenkins Phabricator Plugin - https://phabricator.wikimedia.org/T192337#4135348 (10Mpendulon) @Aklapper we are adding Phabricator plugin on Jenkins and it requires a phabricator bot. See https://github.com/uber/phabricator-jenkins-plugin under Phabricator Configuration. [08:00:28] 10Phabricator-Bot-Requests: Bot Request for Jenkins Phabricator Plugin - https://phabricator.wikimedia.org/T192337#4135357 (10Aklapper) @Mpendulon: How is that related to Wikimedia's Phabricator instance? Again: Who is "we" and how does "Luno" plan to contribute in Wikimedia? We use Jenkins on gerrit.wikimedia.o... [08:06:50] (03PS1) 10Hashar: Move MediaWiki composer test under quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427071 [08:07:19] (03CR) 10jerkins-bot: [V: 04-1] Move MediaWiki composer test under quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427071 (owner: 10Hashar) [08:13:19] (03PS2) 10Hashar: Move MediaWiki composer test under quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427071 [08:13:21] (03PS1) 10Hashar: Discover tests solely in ./tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/427072 [08:34:59] 10Phabricator-Bot-Requests: Bot Request for Jenkins Phabricator Plugin - https://phabricator.wikimedia.org/T192337#4135416 (10Aklapper) 05stalled>03Invalid Closing this task as invalid as this task was created in a place that is entirely unrelated to the request. [08:38:36] 10Phabricator, 10Release-Engineering-Team (Someday): Create Phab account for "jenkins-bot / Gerrit Code Review" to set an avatar image to ease recognition in commit histories - https://phabricator.wikimedia.org/T173877#4135421 (10Aklapper) p:05Triage>03Lowest [08:39:39] 10Phabricator-Bot-Requests: Bot Request for Jenkins Phabricator Plugin - https://phabricator.wikimedia.org/T192337#4135425 (10Aklapper) Same confusion as in T163782, I guess. [08:47:57] (03PS2) 10Hashar: Ignore potential false tests in ./quibble/ [integration/quibble] - 10https://gerrit.wikimedia.org/r/427072 [08:47:59] (03PS3) 10Hashar: Move MediaWiki composer test under quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427071 [08:48:25] (03CR) 10jerkins-bot: [V: 04-1] Move MediaWiki composer test under quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427071 (owner: 10Hashar) [09:38:40] 10Continuous-Integration-Infrastructure: CI: run tests with multiple Python3 versions - https://phabricator.wikimedia.org/T191764#4135484 (10hashar) Yup that is definitely needed, but I am not sure how to implement it. For the context: the CI tox jobs are all based on a Jessie container and get python 2.7.9 and... [09:41:30] (03PS3) 10Hashar: Ignore quibble/test.py when running tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/427072 [09:41:32] (03PS4) 10Hashar: Move MediaWiki composer test under quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427071 [10:08:17] Project mwext-phpunit-coverage-publish build #3508: 04FAILURE in 1 min 17 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/3508/ [10:09:19] Yippee, build fixed! [10:09:19] Project mwext-phpunit-coverage-publish build #3509: 09FIXED in 1 min 1 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/3509/ [12:22:07] (03PS1) 10Hashar: Convenience wrappers for phpunit Database group [integration/quibble] - 10https://gerrit.wikimedia.org/r/427098 [12:22:09] (03PS1) 10Hashar: Activity Manager [integration/quibble] - 10https://gerrit.wikimedia.org/r/427099 [12:45:55] (03PS1) 10Hashar: Drop 'mediawiki-core' prefix from quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/427102 [12:52:31] 10Beta-Cluster-Infrastructure, 10Mobile-Content-Service, 10Operations, 10Page-Previews, and 3 others: [Bug] Beta cluster page summary endpoint sometimes reponds with 5xx - https://phabricator.wikimedia.org/T192287#4135923 (10Pchelolo) 05Open>03Resolved The deployment-mediawiki04.deployment-prep.eqiad.w... [13:06:58] (03CR) 10Hashar: [C: 032] Drop 'mediawiki-core' prefix from quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/427102 (owner: 10Hashar) [13:08:21] (03Merged) 10jenkins-bot: Drop 'mediawiki-core' prefix from quibble jobs [integration/config] - 10https://gerrit.wikimedia.org/r/427102 (owner: 10Hashar) [13:32:25] !log removed role::mediawiki::imagescaler from deployment-prep, per watroles the only use of that role in WMCS [13:32:27] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:33:08] !log removed role::mediawiki::imagescaler from deployment-mediawiki05, per watroles the only use of that role in WMCS [13:33:10] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [13:41:53] (03PS1) 10Hashar: Matrix job to run quibble [integration/config] - 10https://gerrit.wikimedia.org/r/427112 [14:03:28] PROBLEM - puppet last run on contint2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Exec[helm-init] [14:07:17] PROBLEM - puppet last run on contint1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 3 minutes ago with 1 failures. Failed resources (up to 3 shown): Exec[helm-init] [14:32:02] !log Added integration-slave-docker-1008 and integration-slave-docker-1009 (m4executor label) [14:32:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:37:16] RECOVERY - puppet last run on contint1001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [14:57:44] 10Release-Engineering-Team: Jenkins daily builds broken (config parser) - https://phabricator.wikimedia.org/T192367#4136260 (10Jdlrobson) p:05Triage>03High [15:03:30] RECOVERY - puppet last run on contint2001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [15:16:51] 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10MediaWiki-Parser, 10Quibble, and 2 others: [REL1_30] Some parserTests fail on debian stretch using Tidy, because of a new version of libtidy - https://phabricator.wikimedia.org/T191771#4136388 (10hashar) [15:18:13] the glorious quibble future is here [15:18:32] hashar: how did you come up with the name quibble? [15:20:44] 10MediaWiki-Releasing, 10MediaWiki-extensions-LoginNotify, 10MW-1.31-release: Bundle LoginNotify extension with MW 1.31 - https://phabricator.wikimedia.org/T191746#4136430 (10Legoktm) [15:20:47] 10MediaWiki-Releasing, 10Collaboration-Team-Triage, 10Thanks, 10MW-1.31-release: Bundle Thanks extension with MW 1.31 - https://phabricator.wikimedia.org/T191739#4136432 (10Legoktm) [15:20:53] 10MediaWiki-Releasing, 10CodeEditor, 10MW-1.31-release, 10Patch-For-Review: Bundle CodeEditor extension with MW 1.31 - https://phabricator.wikimedia.org/T191742#4136431 (10Legoktm) [15:31:51] legoktm: a weird conversation late at night i guess [15:32:11] I wanted something similar to "being picky" [15:32:22] in french taht would be more or less "chicaner" or "pinailler" [15:32:32] and eventually either marxarelli|afk or thcipriani mentionned quibble [15:33:13] "A trivial or minor complaint, objection or argument. " [15:33:25] eg that is the command you would run and it would complain/object :] [15:35:32] gotta grab kids from school [15:47:39] 10Release-Engineering-Team (Watching / External), 10Epic, 10MediaWiki-Platform-Team (MWPT-Q4-Apr-Jun-2018), 10User-notice: Deploy refactored comment storage - https://phabricator.wikimedia.org/T166733#4136554 (10Marostegui) [15:57:15] 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Kanban), 10Lexicographical data, 10Wikidata, and 2 others: MediaWiki core's selenium tests flaky when run as part of mwext-mw-selenium-node-composer-jessie job - https://phabricator.wikimedia.org/T191537#4136593 (10WMDE-leszek) I've made... [15:57:39] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release, 10Patch-For-Review: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4136595 (10CCicalese_WMF) [15:58:16] 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release, 10Patch-For-Review: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#3695774 (10CCicalese_WMF) [16:08:38] no_justification https://groups.google.com/forum/#!topic/repo-discuss/meEWJO7c4pA [16:39:42] hasharAway: When you're back, could you help with T190548 on image finding? Last blocker for PHP7 for core in CI. [16:39:42] T190548: Update mediawiki-core-qunit-selenium-jessie/mediawiki-extensions-qunit-jessie jobs from PHP5 to PHP7/HHVM - https://phabricator.wikimedia.org/T190548 [17:25:34] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10MediaWiki-Core-Tests: PHPCS should not complain about @covers and @dataProvider being used in traits - https://phabricator.wikimedia.org/T192384#4136860 (10daniel) [18:14:56] (03PS3) 10Krinkle: WebPageTest: Remove the Windows test agent [integration/config] - 10https://gerrit.wikimedia.org/r/423653 (https://phabricator.wikimedia.org/T165626) (owner: 10Phedenskog) [18:15:12] (03CR) 10Krinkle: [C: 032] "Manually removing the job." [integration/config] - 10https://gerrit.wikimedia.org/r/423653 (https://phabricator.wikimedia.org/T165626) (owner: 10Phedenskog) [18:16:10] !log Deleted performance-webpagetest-wmf job (removed from config.git) [18:16:12] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [18:16:41] (03Merged) 10jenkins-bot: WebPageTest: Remove the Windows test agent [integration/config] - 10https://gerrit.wikimedia.org/r/423653 (https://phabricator.wikimedia.org/T165626) (owner: 10Phedenskog) [18:21:54] 10Phabricator, 10Wikimedia-Hackathon-2018: Build a bot that pushes Phabricator updates to Google Chat - https://phabricator.wikimedia.org/T189313#4137191 (10dbarratt) Isn't the software that is run on telecom's servers that handles SMS messages and Phone Calls proprietary software? If so, should the foundation... [18:42:18] 10Project-Admins: Create Technical Writing Project - https://phabricator.wikimedia.org/T192093#4137301 (10srodlund) @bd808 @Aklapper I am interested in any recommendations. The ask for the technical writing project came out of a discussion I had with some newly on-boarded folks. They encountered a ton of doc... [18:52:04] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: Request for access to the beta cluster - https://phabricator.wikimedia.org/T190755#4137340 (10mpopov) I am able to connect to the beta cluster, thanks! But when I try to connect to the mysql database (`mysql -h 127.0.0.1 --user=eventlogging --password=... [19:00:10] (03PS3) 10Hashar: Enhance MySQL exceptions [integration/quibble] - 10https://gerrit.wikimedia.org/r/426938 [19:00:50] (03CR) 10Hashar: [C: 032] Enhance MySQL exceptions [integration/quibble] - 10https://gerrit.wikimedia.org/r/426938 (owner: 10Hashar) [19:01:18] (03Merged) 10jenkins-bot: Enhance MySQL exceptions [integration/quibble] - 10https://gerrit.wikimedia.org/r/426938 (owner: 10Hashar) [19:01:26] (03PS4) 10Hashar: Ignore quibble/test.py when running tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/427072 [19:01:31] (03CR) 10Hashar: [C: 032] Ignore quibble/test.py when running tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/427072 (owner: 10Hashar) [19:01:36] (03PS5) 10Hashar: Move MediaWiki composer test under quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427071 [19:02:00] (03Merged) 10jenkins-bot: Ignore quibble/test.py when running tests [integration/quibble] - 10https://gerrit.wikimedia.org/r/427072 (owner: 10Hashar) [19:13:00] (03PS6) 10Hashar: Move MediaWiki composer test under quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427071 [19:13:02] (03PS2) 10Hashar: Convenience wrappers for phpunit Database group [integration/quibble] - 10https://gerrit.wikimedia.org/r/427098 [19:13:04] (03CR) 10Hashar: [C: 032] Move MediaWiki composer test under quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427071 (owner: 10Hashar) [19:13:06] (03CR) 10Hashar: [C: 032] Convenience wrappers for phpunit Database group [integration/quibble] - 10https://gerrit.wikimedia.org/r/427098 (owner: 10Hashar) [19:13:10] (03Merged) 10jenkins-bot: Move MediaWiki composer test under quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427071 (owner: 10Hashar) [19:13:12] (03Merged) 10jenkins-bot: Convenience wrappers for phpunit Database group [integration/quibble] - 10https://gerrit.wikimedia.org/r/427098 (owner: 10Hashar) [19:15:25] 10Gerrit, 10Release-Engineering-Team, 10Operations, 10Ops-Access-Requests: Requesting access to deployment for pmiazga - https://phabricator.wikimedia.org/T192159#4137418 (10demon) >>! In T192159#4130162, @Dzahn wrote: > I _think_ it's that you are missing here: > > https://gerrit.wikimedia.org/r/#/admin/... [19:28:58] (03PS1) 10Hashar: Move npm test to quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427194 [19:29:20] (03CR) 10Hashar: [C: 032] Move npm test to quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427194 (owner: 10Hashar) [19:29:48] (03Merged) 10jenkins-bot: Move npm test to quibble.test [integration/quibble] - 10https://gerrit.wikimedia.org/r/427194 (owner: 10Hashar) [19:34:00] (03CR) 10Smalyshev: [C: 031] [Wikibase] Temporarily remove flaky mwext-mw-selenium-composer-jessie from test [integration/config] - 10https://gerrit.wikimedia.org/r/425929 (https://phabricator.wikimedia.org/T189762) (owner: 10Jforrester) [19:35:30] 10MediaWiki-Codesniffer: PHPCS should not complain about @covers and @dataProvider being used in traits - https://phabricator.wikimedia.org/T192384#4137473 (10Legoktm) [19:36:11] (03CR) 10Smalyshev: [C: 031] "We have it broken for a month now, and there doesn't seem to be any improvement." [integration/config] - 10https://gerrit.wikimedia.org/r/425929 (https://phabricator.wikimedia.org/T189762) (owner: 10Jforrester) [19:43:02] 10Release-Engineering-Team (Kanban), 10Release, 10Train Deployments: 1.31.0-wmf.29 deployment blockers - https://phabricator.wikimedia.org/T183968#4137508 (10greg) 05Open>03Resolved [20:02:19] 10Gerrit, 10Release-Engineering-Team, 10Operations, 10Ops-Access-Requests: Requesting access to deployment for pmiazga - https://phabricator.wikimedia.org/T192159#4137543 (10Dzahn) 05Open>03Resolved a:03Dzahn Thanks @demon! @pmiazga Now you should have the +2 and things should just work. I'm callin... [20:12:43] (03PS2) 10Hashar: Activity Manager [integration/quibble] - 10https://gerrit.wikimedia.org/r/427099 [20:13:35] 10Gerrit, 10Release-Engineering-Team, 10Operations, 10Ops-Access-Requests: Requesting access to deployment for pmiazga - https://phabricator.wikimedia.org/T192159#4137561 (10Niharika) @pmiazga Feel free to ping me on IRC and/or setup calendar time to do a walkthrough during a morning SWAT. I'm based in SF. [20:13:41] (03CR) 10Hashar: [C: 04-1] "Not sure where I am going with that one but the idea is to skip some test commands when we know they are not affected." [integration/quibble] - 10https://gerrit.wikimedia.org/r/427099 (owner: 10Hashar) [20:15:19] (03PS2) 10Hashar: Matrix job to run quibble [integration/config] - 10https://gerrit.wikimedia.org/r/427112 (https://phabricator.wikimedia.org/T192372) [20:15:24] (03PS3) 10Hashar: Matrix job to run quibble [integration/config] - 10https://gerrit.wikimedia.org/r/427112 (https://phabricator.wikimedia.org/T192372) [20:15:32] (03CR) 10Hashar: [C: 032] "https://integration.wikimedia.org/ci/job/quibble-integration/" [integration/config] - 10https://gerrit.wikimedia.org/r/427112 (https://phabricator.wikimedia.org/T192372) (owner: 10Hashar) [20:16:03] legoktm: I crafted a job to run quibble against all combinations of branch/php/database/package source: https://integration.wikimedia.org/ci/job/quibble-integration/ :] [20:16:29] legoktm: tests are broken under sqlite, not a big deal. php7 breakage are mostly due to libtidy which will get resolved tomorrow [20:16:30] :D [20:16:39] woah woah [20:16:43] you can do that in jenkins?? [20:16:57] (03Merged) 10jenkins-bot: Matrix job to run quibble [integration/config] - 10https://gerrit.wikimedia.org/r/427112 (https://phabricator.wikimedia.org/T192372) (owner: 10Hashar) [20:17:34] hasharAway: why is master/mysql/php55 failing? [20:18:07] (03CR) 10Legoktm: "WOW" [integration/config] - 10https://gerrit.wikimedia.org/r/427112 (https://phabricator.wikimedia.org/T192372) (owner: 10Hashar) [20:21:08] legoktm: maybe it got confused or I killed it https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php55-docker/2/console :D [20:21:22] phpunit returned non-zero exit status -11 [20:22:01] maybe quibble should catch SIGTERM [20:23:53] 10MediaWiki-Releasing, 10MediaWiki-extensions-CategoryTree, 10MW-1.31-release: Bundle CategoryTree extension with MW 1.31 - https://phabricator.wikimedia.org/T191735#4137604 (10CCicalese_WMF) [20:24:02] (03PS1) 10Cicalese: Bundle CategoryTree extension [tools/release] - 10https://gerrit.wikimedia.org/r/427209 [20:24:04] (03PS1) 10Hashar: quibble 0.0.8 [integration/config] - 10https://gerrit.wikimedia.org/r/427210 [20:25:32] (03CR) 10Hashar: [C: 032] "Specially for Kunal patch to skip test commands. There is also ChromeDriver output being logged which is a life saver whenever chromium f" [integration/config] - 10https://gerrit.wikimedia.org/r/427210 (owner: 10Hashar) [20:25:42] 10MediaWiki-Releasing, 10Collaboration-Team-Triage, 10Notifications, 10MW-1.31-release: Bundle Echo extension with MW 1.31 - https://phabricator.wikimedia.org/T191738#4137609 (10CCicalese_WMF) [20:25:59] ty :) [20:27:08] (03Merged) 10jenkins-bot: quibble 0.0.8 [integration/config] - 10https://gerrit.wikimedia.org/r/427210 (owner: 10Hashar) [20:28:56] !log building releng/quibble.*:0.0.8 images [20:28:58] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:37:38] 10MediaWiki-Releasing, 10MediaWiki-extensions-Scribunto, 10MW-1.31-release, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Bundle Scribunto extension with MW 1.31 - https://phabricator.wikimedia.org/T191737#4137632 (10CCicalese_WMF) There are two deprecation warnings... [20:38:48] 10MediaWiki-Releasing, 10MobileFrontend, 10MW-1.31-release, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), 10Patch-For-Review: Bundle MobileFrontend extension with MW 1.31 - https://phabricator.wikimedia.org/T191734#4137633 (10pmiazga) /cc @Jdlrobson [20:39:12] 10MediaWiki-Releasing, 10MobileFrontend, 10MW-1.31-release, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), and 2 others: Bundle MobileFrontend extension with MW 1.31 - https://phabricator.wikimedia.org/T191734#4137635 (10pmiazga) [20:41:36] 10MediaWiki-Releasing, 10MinervaNeue, 10MW-1.31-release, 10Readers-Web-Backlog (Tracking): Bundle Minerva Neue skin with MW 1.31 - https://phabricator.wikimedia.org/T191743#4137637 (10pmiazga) [20:43:12] 10MediaWiki-Releasing, 10MediaWiki-extensions-Scribunto, 10MW-1.31-release, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: Bundle Scribunto extension with MW 1.31 - https://phabricator.wikimedia.org/T191737#4137648 (10Legoktm) [20:58:27] 10Project-Admins: Create Technical Writing Project - https://phabricator.wikimedia.org/T192093#4137687 (10bd808) >>! In T192093#4137301, @srodlund wrote: > I am interested in any recommendations. What do you think about starting with changes to the workboard and description page for #documentation? There are a... [21:10:42] !log Running https://integration.wikimedia.org/ci/job/quibble-integration/6/ overnight [21:10:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [21:22:44] 10MediaWiki-Releasing, 10Collaboration-Team-Triage, 10Thanks, 10MW-1.31-release: Bundle Thanks extension with MW 1.31 - https://phabricator.wikimedia.org/T191739#4137721 (10CCicalese_WMF) [21:32:13] (03PS1) 10Chad: Fixes from REL1_31 branching snafus [tools/release] - 10https://gerrit.wikimedia.org/r/427266 [21:32:49] 10MediaWiki-Releasing, 10MediaWiki-extensions-LoginNotify, 10MW-1.31-release: Bundle LoginNotify extension with MW 1.31 - https://phabricator.wikimedia.org/T191746#4137735 (10CCicalese_WMF) >>! In T191746#4124556, @MaxSem wrote: > Does the installer support extension dependencies now? Yes, as of today. [21:33:11] 10MediaWiki-Releasing, 10MediaWiki-extensions-LoginNotify, 10MW-1.31-release: Bundle LoginNotify extension with MW 1.31 - https://phabricator.wikimedia.org/T191746#4137737 (10CCicalese_WMF) [21:34:00] (03CR) 10Jforrester: [C: 031] Fixes from REL1_31 branching snafus [tools/release] - 10https://gerrit.wikimedia.org/r/427266 (owner: 10Chad) [21:34:06] (03CR) 10Legoktm: [C: 032] Fixes from REL1_31 branching snafus [tools/release] - 10https://gerrit.wikimedia.org/r/427266 (owner: 10Chad) [21:34:43] (03Merged) 10jenkins-bot: Fixes from REL1_31 branching snafus [tools/release] - 10https://gerrit.wikimedia.org/r/427266 (owner: 10Chad) [21:45:12] (03PS1) 10Chad: Move branchpoint to master, give full repo name for core [tools/release] - 10https://gerrit.wikimedia.org/r/427268 [21:45:52] (03CR) 10Legoktm: [C: 032] Move branchpoint to master, give full repo name for core [tools/release] - 10https://gerrit.wikimedia.org/r/427268 (owner: 10Chad) [21:46:35] (03Merged) 10jenkins-bot: Move branchpoint to master, give full repo name for core [tools/release] - 10https://gerrit.wikimedia.org/r/427268 (owner: 10Chad) [22:22:52] When making a mediawiki config chagnge, the Gerrit +2 should happen right before the actual deploy, correct? [22:23:19] So, if there's a related beta cluster config change that should be tested first, that should go in a separate Gerrit change, no? [22:24:18] greg-g: thcipriani: twentyafterfour: no_justification: ^ [22:24:30] yes [22:25:27] no_justification: cool thx!! :) [22:25:58] no_justification: and so it's expected that it'll be someone from ops or releng who'd +2 the prod change, no? (We're putting it on a SWAT deploy) [22:26:14] But it's OK for other teams to +2 beta cluster changes? [22:26:35] Any deployer can +2 changes to that repo [22:26:49] But even beta-only ones should also be sync'd in prod for consistency [22:27:55] no_justification: ok cool :) [22:46:02] 10Phabricator, 10Wikimedia-Hackathon-2018: Build a bot that pushes Phabricator updates to Google Chat - https://phabricator.wikimedia.org/T189313#4137854 (10Tgr) We only support TOTP as a second factor, not SMS tokens. [22:46:42] 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team: Request for access to the beta cluster - https://phabricator.wikimedia.org/T190755#4137855 (10EddieGP) According to the [[https://dev.mysql.com/doc/refman/5.5/en/can-not-connect-to-server.html|manual]], specifying nothing is equivalent to specifying `l... [22:48:19] 10Phabricator, 10Wikimedia-Hackathon-2018: Build a bot that pushes Phabricator updates to Google Chat - https://phabricator.wikimedia.org/T189313#4137866 (10dbarratt) >>! In T189313#4137854, @Tgr wrote: > We only support TOTP as a second factor, not SMS tokens. I saw that and edited my comment. thanks! [22:49:47] no_justification: do you know what credentials does https://logstash-beta.wmflabs.org want? [22:51:12] AaronSchulz: your browser is supressing the tip: The site says: “Logstash (ssh deployment-tin.eqiad.wmflabs sudo cat /root/secrets.txt)” [22:53:48] got it [23:04:49] 10MediaWiki-Releasing, 10MediaWiki-extensions-LoginNotify, 10MW-1.31-release: Bundle LoginNotify extension with MW 1.31 - https://phabricator.wikimedia.org/T191746#4115206 (10Niharika) Is MIT license not acceptable? [23:05:49] 10Phabricator, 10Wikimedia-Hackathon-2018: Build a bot that pushes Phabricator updates to Google Chat - https://phabricator.wikimedia.org/T189313#4137894 (10Tgr) The [[https://wikitech.wikimedia.org/wiki/SMS/USSD|SMS service]] we use (used? not sure if it is still up) is opensource AFAIK. [23:06:39] Niharika: it is [23:06:46] MIT license is compatible with GPLv2 [23:07:18] Platonides: Thought so. I'm wondering why that isn't being checked off in the list. [23:09:03] 10MediaWiki-Releasing, 10MediaWiki-extensions-LoginNotify, 10MW-1.31-release: Bundle LoginNotify extension with MW 1.31 - https://phabricator.wikimedia.org/T191746#4115206 (10Platonides) @Niharika: It is acceptable. MIT license is compatible with GPL v2 or later. [23:11:09] 10MediaWiki-Releasing, 10MediaWiki-extensions-LoginNotify, 10MW-1.31-release: Bundle LoginNotify extension with MW 1.31 - https://phabricator.wikimedia.org/T191746#4137913 (10Platonides) [23:11:10] * Platonides ticks it [23:12:22] Platonides: I think there's a reason. It's not being checked in other similar tickets. [23:12:35] hmm [23:15:25] Hm.. what do I need to do to make the GitHub mirror of a new repo appear? [23:15:36] Seems like performance/coal is missing. [23:15:41] But created several days ago [23:15:45] incl a few commits [23:26:45] (03PS5) 10Krinkle: Expose wikiadmin user/pass via env and use a more complex password [integration/jenkins] - 10https://gerrit.wikimedia.org/r/415312 (https://phabricator.wikimedia.org/T188520) (owner: 10Reedy) [23:27:19] (03CR) 10Krinkle: [C: 032] Expose wikiadmin user/pass via env and use a more complex password [integration/jenkins] - 10https://gerrit.wikimedia.org/r/415312 (https://phabricator.wikimedia.org/T188520) (owner: 10Reedy) [23:28:19] (03Merged) 10jenkins-bot: Expose wikiadmin user/pass via env and use a more complex password [integration/jenkins] - 10https://gerrit.wikimedia.org/r/415312 (https://phabricator.wikimedia.org/T188520) (owner: 10Reedy) [23:38:32] 10Project-Admins: Create Technical Writing Project - https://phabricator.wikimedia.org/T192093#4138006 (10srodlund) Only 600? No problem ;-) I think that's a fine place to start. Yes. I agree, if we have the existing infrastructure, we should use it and integrated it, and this can definitely work for us! [23:40:47] !log Rebuilding Nodepool snapshot for https://gerrit.wikimedia.org/r/415312 [23:40:49] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL