[08:14:20] <wikibugs_>	 10Release-Engineering-Team, 10MediaWiki-Parser, 10MediaWiki-Platform-Team, 10Operations, and 2 others: Different production servers have different versions of tidy installed, resulting in varying output - https://phabricator.wikimedia.org/T193414#4168635 (10MoritzMuehlenhoff) I've created some test package...
[09:14:28] <tgr>	 are there any plans for upgrading to gerrit 2.15?
[09:14:39] <tgr>	 I want https://bugs.chromium.org/p/gerrit/issues/detail?id=5987 so hard
[09:22:04] <Hauskatze>	 paladox should know tgr 
[09:53:42] <wikibugs_>	 10Phabricator: Improve default Maniphest search settings - https://phabricator.wikimedia.org/T187587#4189761 (10Aklapper) p:05Triage>03Low
[09:55:49] <wikibugs_>	 10Phabricator, 10Project-Admins: Creating private tasks by filling a web form (for AffCom) - https://phabricator.wikimedia.org/T89335#4189762 (10Aklapper) 05Open>03stalled >>! In T89335#2037909, @mmodell wrote: > I just need to know what the defaults should be and which fields should be shown/hidden. >>! I...
[09:58:48] <wikibugs_>	 10Phabricator: Make new tasks within a specific project use a template in description field - https://phabricator.wikimedia.org/T91538#4189775 (10Aklapper) 05Open>03stalled @ggellerman: Is this still wanted? If so, which existing project tag should be set in that form? Or who involved in "Research and Data"...
[10:11:00] <paladox>	 tgr there’s https://phabricator.wikimedia.org/T177201 that task
[10:12:34] <tgr>	 paladox: thx. I know we will upgrade eventually; I was really wondering how far that is.
[10:18:31] <Hauskatze>	 tgr: any updates wrt https://phabricator.wikimedia.org/T194032 ?
[10:19:37] <tgr>	 added you to the task
[10:19:56] <tgr>	 I'm not a mailman developer or admin so I won't do anything myself
[10:20:13] <paladox>	 tgr no_justification should know :)
[10:20:19] <Hauskatze>	 tnx
[10:47:17] <wikibugs_>	 10Phabricator: Update Herald (H168) to include project 3367 - https://phabricator.wikimedia.org/T194072#4189900 (10Aklapper) -> #Phabricator config
[10:50:35] <wikibugs_>	 10Phabricator: Build a bot that pushes Phabricator updates to Google Chat - https://phabricator.wikimedia.org/T189313#4189903 (10Aklapper) 05Open>03declined As the last edit implies that nobody plans to work on this I'm going to boldly decline this task for the time being.
[11:22:23] <wikibugs_>	 10Phabricator (Upstream), 10Legalpad, 10Upstream: Granularize Legalpad view/edit/sign permissions - https://phabricator.wikimedia.org/T194148#4190004 (10MarcoAurelio)
[11:39:41] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Wikimedia-Hackathon-2018, 10JavaScript, 10User-zeljkofilipin: Write Selenium tests in JavaScript/Node.js workshop - https://phabricator.wikimedia.org/T190046#4190035 (10zeljkofilipin) Thanks for the reminder. This session is a follow up for T185580, so I will schedule...
[12:10:33] <wikibugs_>	 10Beta-Cluster-Infrastructure: Remove deployment-mediawiki06 app server? - https://phabricator.wikimedia.org/T194151#4190102 (10MoritzMuehlenhoff)
[12:19:25] <moritzm>	 !log upgrading app servers in beta to wikidiff 1.6.0 (T190717)
[12:19:27] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[12:19:28] <stashbot>	 T190717: Update wikidiff2 library on the WMF production cluster - https://phabricator.wikimedia.org/T190717
[13:03:38] <wikibugs_>	 10Phabricator: searching "db1055" on phabricator search doesn't find the only open task with "db1055" on the title - https://phabricator.wikimedia.org/T194154#4190263 (10jcrespo)
[13:17:01] <wikibugs_>	 10Release-Engineering-Team, 10MediaWiki-Parser, 10MediaWiki-Platform-Team, 10Operations, and 2 others: Different production servers have different versions of tidy installed, resulting in varying output - https://phabricator.wikimedia.org/T193414#4190334 (10ssastry) >>! In T193414#4189417, @MoritzMuehlenho...
[13:27:41] <wikibugs_>	 10Release-Engineering-Team, 10MediaWiki-Parser, 10MediaWiki-Platform-Team, 10Operations, and 2 others: Different production servers have different versions of tidy installed, resulting in varying output - https://phabricator.wikimedia.org/T193414#4190380 (10MoritzMuehlenhoff) Ack, at this point only four j...
[13:33:33] <wikibugs_>	 10Gerrit: mediawiki/extensions repo lacks extensions - https://phabricator.wikimedia.org/T194156#4190450 (10MarcoAurelio)
[13:36:32] <wikibugs_>	 10Gerrit: mediawiki/extensions repo lacks extensions - https://phabricator.wikimedia.org/T194156#4190494 (10MarcoAurelio) Updated subscribers as per access list found at https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/production/modules/admin/data/data.yaml#50 `et seq.`
[13:39:00] <Hauskatze>	 thcipriani: you around?
[14:53:49] <wikibugs_>	 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release, 10Patch-For-Review: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4108793 (10ashley) >>! In T178349#4188521, @Isarra wrote: > Ok...
[15:42:51] <wikibugs_>	 (03PS1) 10Chad: makerelease: Some line-too-long errors [tools/release] - 10https://gerrit.wikimedia.org/r/431772
[15:42:53] <wikibugs_>	 (03CR) 10Chad: [C: 032] makerelease: Some line-too-long errors [tools/release] - 10https://gerrit.wikimedia.org/r/431772 (owner: 10Chad)
[15:43:24] <wikibugs_>	 (03Merged) 10jenkins-bot: makerelease: Some line-too-long errors [tools/release] - 10https://gerrit.wikimedia.org/r/431772 (owner: 10Chad)
[15:53:28] <wikibugs_>	 10Release-Engineering-Team, 10MediaWiki-Parser, 10MediaWiki-Platform-Team, 10Operations, and 2 others: Different production servers have different versions of tidy installed, resulting in varying output - https://phabricator.wikimedia.org/T193414#4191075 (10Legoktm) >>! In T193414#4190334, @ssastry wrote:...
[16:02:56] <andrewbogott>	 no_justification, I just created a new python repo which right now Jenkins is totally ignoring.  What's involved in adding automatic pep8/flake8 tests?
[16:03:35] <no_justification>	 Adding to zuuls config 
[16:04:13] <andrewbogott>	 ok, I'll have a look
[16:04:17] <no_justification>	 Look in the integration/config repo for a repo you wanna copy what it does
[16:04:25] <no_justification>	 That config is a Lotta copy paste
[16:12:46] <andrewbogott>	 no_justification: hm, looks like this is in transition, a lot of the good stuff is in config/dockerfiles
[16:12:51] <andrewbogott>	 I guess I should skip to the end and do that
[16:22:16] <wmf-insecte>	 Project mwext-phpunit-coverage-publish build #4244: 04FAILURE in 3.3 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/4244/
[16:25:37] <wmf-insecte>	 Yippee, build fixed!
[16:25:37] <wmf-insecte>	 Project mwext-phpunit-coverage-publish build #4245: 09FIXED in 3 min 15 sec: https://integration.wikimedia.org/ci/job/mwext-phpunit-coverage-publish/4245/
[16:37:13] <wikibugs_>	 (03PS1) 10Chad: branch.py: Work around inconsistent mediawiki/* prefixes [tools/release] - 10https://gerrit.wikimedia.org/r/431784
[16:37:15] <wikibugs_>	 (03CR) 10Chad: [C: 032] branch.py: Work around inconsistent mediawiki/* prefixes [tools/release] - 10https://gerrit.wikimedia.org/r/431784 (owner: 10Chad)
[16:37:44] <wikibugs_>	 (03Merged) 10jenkins-bot: branch.py: Work around inconsistent mediawiki/* prefixes [tools/release] - 10https://gerrit.wikimedia.org/r/431784 (owner: 10Chad)
[16:47:50] <wikibugs_>	 10Phabricator: Update Herald (H168) to include project 3367 - https://phabricator.wikimedia.org/T194072#4191313 (10MBinder_WMF) Thanks, @Aklapper !   @LGoto , can you update the template links that create tasks like these to include the #phabricator tag, and also tag requests like these with the backlog of the g...
[16:54:29] <wikibugs_>	 10Scap, 10Patch-For-Review: Update Debian Package for Scap3 - https://phabricator.wikimedia.org/T127762#4191334 (10fgiunchedi) 05Open>03Resolved a:03fgiunchedi
[17:22:17] <wikibugs_>	 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release, 10Patch-For-Review: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4191444 (10demon) So, this is all a great discussion to have,...
[17:24:12] <no_justification>	 paladox: Every time I build the stable-2.14 branch, I end up with a dirty repo because something is adding .apt_generated to .gitignore again and again
[17:24:24] <paladox>	 hmm
[17:24:30] <no_justification>	 https://phabricator.wikimedia.org/P7097
[17:24:31] <paladox>	 no_justification which bazel version are you using?
[17:24:33] <no_justification>	 (ignore the motd bit)
[17:25:03] <no_justification>	 Build label: 0.13.0-homebrew
[17:25:55] <paladox>	 this same version as me, no_justification do git reset --hard origin/wmf/stable-2.14
[17:26:13] <paladox>	 https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/gerrit/gerrit/+/wmf/stable-2.14/.bazelproject
[17:26:13] <no_justification>	 I do that, but when I build it adds more entries
[17:26:37] <no_justification>	 That's what my .bazelproject looks like
[17:27:17] * paladox will try running bazel on that repo
[17:27:28] <no_justification>	 I did a hard reset and building again
[17:27:32] <no_justification>	 I wonder why this happens tho
[17:29:06] <no_justification>	 Hmmm, didn't happen this time
[17:29:07] <no_justification>	 Weird
[17:29:11] <paladox>	 hmm
[17:29:16] <paladox>	 heh
[17:32:08] <paladox>	 no_justification i think gerrit has gotten faster in ChangeJson
[17:32:15] <paladox>	 https://gerrit-review.googlesource.com/c/gerrit/+/172437
[17:38:50] <no_justification>	 And it did it again!
[17:39:51] <wikibugs_>	 10Phabricator, 10Project-Admins: Add #SVG tag to Phabricator - https://phabricator.wikimedia.org/T194188#4191471 (10Volker_E)
[17:40:56] <paladox>	 no_justification hmm, reclone the repo?
[17:41:15] <no_justification>	 I blame bazel doing something weird
[17:41:18] <no_justification>	 It's not a repo thing?
[17:44:44] <paladox>	 no_justification bazel should only add the bazel-* dirs
[17:45:08] <paladox>	 it dosen't happen to me
[17:46:12] <no_justification>	 +/bazel-out/
[17:46:12] <no_justification>	 +/.apt_generated/
[17:46:19] <no_justification>	 Both getting added now :)
[17:46:21] <no_justification>	 Weirdddddd
[17:46:25] <no_justification>	 Something's up with mah bazel
[17:46:31] <paladox>	 i have
[17:46:33] <paladox>	  /tools/format
[17:46:41] <paladox>	 no_justification bazel expunge?
[17:46:46] <paladox>	 or bazel shutdown
[17:47:00] <paladox>	 that just cleans things
[17:49:23] <paladox>	 https://gerrit.googlesource.com/gerrit/+/08180de4deb931a8fa29a579ce4d40f885054cca%5E%21/.gitignore
[17:55:07] <no_justification>	 Ah, so it's eclipse doing funky stuff
[17:57:50] <paladox>	 no_justification oh you were using a IDE
[17:57:51] <paladox>	 heh
[17:58:02] <paladox>	 guess it was this file then https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/gerrit/gerrit/+/wmf/stable-2.14/.bazelproject
[17:58:06] <no_justification>	 Well I build on the cli with bazel
[17:58:10] <no_justification>	 But eclipse does funky stuff
[17:58:14] <no_justification>	 Maybe disable auto-build?
[17:58:56] <paladox>	 yeh though how do you disable that?
[17:59:09] <wikibugs_>	 (03PS1) 10MarcoAurelio: Add AbuseFilter dependency on TorBlock [integration/config] - 10https://gerrit.wikimedia.org/r/431806
[17:59:11] <no_justification>	 In the Build menu
[17:59:14] <no_justification>	 "Build Automatically"
[17:59:39] <paladox>	 there's a build menu?
[17:59:44] <paladox>	 oh
[17:59:45] <paladox>	 eclipse
[17:59:59] <no_justification>	 Yeah
[17:59:59] <paladox>	 lol, some how i managed to delete eclipse though i never really ran it
[18:00:05] <paladox>	 only to get mariadb supported
[18:00:08] <no_justification>	 Basically I want to only build w/ bazel and have eclipse just use what I build
[18:00:14] <paladox>	 yeh
[18:00:17] <no_justification>	 Don't have it try to be smarter :p
[18:00:22] <paladox>	 lol
[18:13:57] <twentyafterfour>	 awight_mob: new scap should be deployed now.
[18:16:45] <no_justification>	 paladox: Found it!
[18:16:52] <paladox>	 no_justification heh :)
[18:16:56] <no_justification>	 Eclipse preferences.
[18:17:03] <paladox>	 :)
[18:17:07] <no_justification>	 Team -> Git -> Projects
[18:17:17] <paladox>	 i havent used eclipse in over 1 a bit years
[18:17:26] <paladox>	 i could never get it working properly
[18:17:30] <no_justification>	 Uncheck "Automatically ignore derived resources by adding them to .gitignore"
[18:19:15] <Hauskatze>	 no_justification: could you please update mediawiki/extensions as per T194156 ? - the shell/python scripts ain't working for me
[18:19:16] <stashbot>	 T194156: mediawiki/extensions repo lacks extensions - https://phabricator.wikimedia.org/T194156
[18:19:35] <no_justification>	 Anyone can do that....
[18:19:46] <Hauskatze>	 well not me
[18:19:54] <Hauskatze>	 permission denied publickey
[18:19:56] <no_justification>	 That script isn't meant to be run server side...?
[18:20:02] <paladox>	 heh
[18:20:11] <Hauskatze>	 serverside != anyone
[18:20:36] <Hauskatze>	 that or any of the ones listed there, I don't know which is the good one :/
[18:20:39] <no_justification>	 Well I mean A) it's using a crappy SSH thing instead of the actual rest api
[18:21:09] <no_justification>	 I don't know much of anything about those scripts
[18:28:36] <wikibugs_>	 10Phabricator, 10Release-Engineering-Team (Kanban): searching "db1055" on phabricator search doesn't find the only open task with "db1055" on the title - https://phabricator.wikimedia.org/T194154#4191638 (10mmodell) a:03mmodell There is something about that search term that is confusing the engine. I don't q...
[18:50:17] <wikibugs_>	 10Phabricator, 10Release-Engineering-Team (Kanban): searching "db1055" on phabricator search doesn't find the only open task with "db1055" on the title - https://phabricator.wikimedia.org/T194154#4191731 (10jcrespo) note if it is 1 in a million, I don't care so much (I can bookmark it/favorite it), I am report...
[18:51:30] <wikibugs_>	 10Phabricator, 10Release-Engineering-Team (Kanban): searching "db1055" on phabricator search doesn't find the only open task with "db1055" on the title - https://phabricator.wikimedia.org/T194154#4191758 (10mmodell) @jcrespo: I think I found the problem! there are 70,000+ search worker tasks backed up in the q...
[18:52:01] <no_justification>	 paladox: All done https://gerrit.wikimedia.org/r/#/c/431818/!
[18:52:11] <no_justification>	 Just gotta get them in archiva
[18:52:14] <paladox>	 :)!
[18:52:28] <wikibugs_>	 10Phabricator, 10Release-Engineering-Team (Kanban): searching "db1055" on phabricator search doesn't find the only open task with "db1055" on the title - https://phabricator.wikimedia.org/T194154#4191761 (10Aklapper) For the records, cannot find that task in Maniphest's advanced search either: https://phabrica...
[18:52:34] <paladox>	 no_justification size decrease too!
[18:52:35] <paladox>	 86645433
[18:52:51] <paladox>	 must have been the deps being removed (or the ones that were unused)
[18:54:38] <no_justification>	 Eh, size is why we have git-fat :p
[18:54:49] <paladox>	 heh
[18:56:37] <wikibugs_>	 10Phabricator, 10Release-Engineering-Team (Kanban): searching "db1055" on phabricator search doesn't find the only open task with "db1055" on the title - https://phabricator.wikimedia.org/T194154#4191783 (10mmodell) @aklapper: yeah I'm fixing that now. Somehow a bunch of bogus search worker tasks got queued up...
[19:06:05] <no_justification>	 paladox: any chance you could get a list of the schema changes for 2.15? Like not as their ORM stuff but like a normal human would do using SQL? 
[19:06:25] <paladox>	 no_justification ok, though it would mostly be either deleting
[19:06:29] <no_justification>	 I wanna analyze the changes before we upgrade but their abstraction makes that difficult 
[19:06:34] <paladox>	 notedb is the default in 2.15 for new sites
[19:06:56] <no_justification>	 Yeah. We'd start with receiwdb then convert. 
[19:08:02] * paladox goes looking :)
[19:09:08] <no_justification>	 Unrelated: https://github.com/bazelbuild/bazel/issues/30 bugs me :(
[19:09:39] <no_justification>	 30 and https://github.com/bazelbuild/bazel/issues/1372
[19:10:09] <paladox>	 you want to publish to maven?
[19:10:18] <no_justification>	 Well, archiva
[19:10:22] <no_justification>	 "Publish" generally
[19:10:28] <no_justification>	 https://github.com/google/bazel-common/commit/2782531da81d4002bce16e853953d9e8117a6fc1 is a step in the right direction
[19:10:37] <paladox>	 no_justification i know 100% the accounts table is gone
[19:10:50] <no_justification>	 Well the updater doesn't drop them by default, it just does /changes/
[19:10:56] <no_justification>	 Then says "You can drop these....."
[19:11:34] <paladox>	 yeh
[19:11:52] <paladox>	 by gone i mean they are not using that table any more
[19:12:08] <paladox>	 though i guess they will write to both tables during the reviewdb -> notedb migration
[19:13:22] <paladox>	 no_justification updates start from https://github.com/GerritCodeReview/gerrit/blob/master/java/com/google/gerrit/server/schema/Schema_140.java
[19:13:37] <paladox>	 140->168
[19:13:42] <paladox>	 140 to 168
[19:13:44] <paladox>	 oh
[19:14:11] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_140.java
[19:14:22] <paladox>	 140 to 161
[19:15:04] <paladox>	 there's https://github.com/GerritCodeReview/gerrit/commit/5a142312e9f83cf2a230263fbc1cafb838cf5940
[19:15:35] <paladox>	 oh
[19:15:45] <paladox>	 ah
[19:15:48] <paladox>	 143 to 161
[19:15:58] <paladox>	 https://github.com/GerritCodeReview/gerrit/commit/276b8a897f516cf1f26953154b92cbbaba9a5669
[19:17:43] <paladox>	 https://github.com/GerritCodeReview/gerrit/commit/98ddc8a658b838451097e2e1f003ac753c102b9e
[19:18:24] <no_justification>	 This is why I hate their schema system: https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_143.java
[19:18:28] <no_justification>	 That tells me /nothing/
[19:18:29] <no_justification>	 :)
[19:19:55] <Reedy>	 line 20? :P
[19:21:08] <no_justification>	 Well, barring useful comments
[19:22:57] <no_justification>	 Eh, I guess these are all fine
[19:24:25] <no_justification>	 paladox: https://archiva.apache.org/docs/1.4-M4/userguide/deploy.html#Deploying_Third-Party_Artifacts_to_Archiva_using_Maven should be good enough for my usages
[19:24:26] <stashbot>	 M4: Phabricator project labels - https://phabricator.wikimedia.org/M4
[19:24:33] <no_justification>	 Oh shut up stashbot
[19:49:13] <legoktm>	 !log aborted mwext-phpunit-coverage-patch #2819 
[19:49:15] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL
[19:50:10] <wikibugs_>	 10Release-Engineering-Team, 10MediaWiki-Parser, 10MediaWiki-Platform-Team, 10Operations, and 2 others: Different production servers have different versions of tidy installed, resulting in varying output - https://phabricator.wikimedia.org/T193414#4191968 (10hashar) T191771 is MediaWiki parser tests failing...
[19:51:19] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10MediaWiki-Core-Tests, 10MediaWiki-Parser, 10Quibble, and 2 others: [REL1_30] Some parserTests fail on debian stretch using Tidy, because of a new version of libtidy - https://phabricator.wikimedia.org/T191771#4191972 (10hashar) I have kept this task open since the CI...
[19:55:15] <wikibugs_>	 10Deployments, 10Scap, 10WorkType-NewFunctionality: Create canary deploy process for MediaWiki - https://phabricator.wikimedia.org/T136883#4191994 (10thcipriani)
[19:55:22] <wikibugs_>	 10Scap (Scap3-MediaWiki-MVP), 10scap2, 10MediaWiki-API, 10Patch-For-Review, and 3 others: Create a script to run test requests for the MediaWiki service - https://phabricator.wikimedia.org/T136839#4191992 (10thcipriani) 05Open>03Resolved Now that Scap 3.8.1-1 is out we are checking the swagger spec at...
[19:56:00] <paladox>	 no_justification lol
[19:57:28] <paladox>	 that is adding the is_private field to the json
[19:57:30] <paladox>	 (change)
[19:58:58] <wikibugs_>	 10Deployments, 10Scap, 10WorkType-NewFunctionality: Create canary deploy process for MediaWiki - https://phabricator.wikimedia.org/T136883#4192020 (10thcipriani)
[19:59:00] <wikibugs_>	 10Scap (Scap3-MediaWiki-MVP), 10scap2, 10Wikimedia-Incident: Implement MediaWiki pre-promote checks - https://phabricator.wikimedia.org/T121597#4192017 (10thcipriani) 05Open>03Resolved a:03thcipriani Now that Scap 3.8.1-1 is out we are checking the swagger spec at https://en.wikipedia.org/spec.yaml via...
[20:01:04] <paladox>	 no_justification i guess this https://gerrit-review.googlesource.com/c/gerrit/+/176973 is what you want to do redis?
[20:03:49] <paladox>	 no_justification wip schema too
[20:03:52] <wikibugs_>	 10Deployments, 10Scap, 10WorkType-NewFunctionality: Create canary deploy process for MediaWiki - https://phabricator.wikimedia.org/T136883#4192045 (10thcipriani) 05Open>03Resolved a:03thcipriani For MediaWiki we are currently running a basic swagger check to check responses for a small number of endpoi...
[20:04:02] <paladox>	 as it adds the is_work_in_progress field
[20:04:50] <wikibugs_>	 10Scap (Scap3-MediaWiki-MVP), 10scap2, 10Wikimedia-Incident: Implement MediaWiki pre-promote checks - https://phabricator.wikimedia.org/T121597#4192050 (10MaxSem) > https://en.wikipedia.org/spec.yaml  Already out of date: `version: 1.31.0` :)
[20:06:13] <wikibugs_>	 (03PS1) 10Cicalese: Add tests for Extension:VEForAll [integration/config] - 10https://gerrit.wikimedia.org/r/431853
[20:11:12] <wikibugs_>	 10Scap (Scap3-MediaWiki-MVP), 10scap2, 10Wikimedia-Incident: Implement MediaWiki pre-promote checks - https://phabricator.wikimedia.org/T121597#4192074 (10thcipriani) >>! In T121597#4192050, @MaxSem wrote: >> https://en.wikipedia.org/spec.yaml >  > Already out of date: `version: 1.31.0` :)  good looking out...
[20:21:20] <wikibugs_>	 10MediaWiki-Releasing, 10MediaWiki-Installer, 10MW-1.31-release, 10Patch-For-Review: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349#4192136 (10Isarra) Sounds good - and now we should have both a...
[20:24:15] <paladox>	 so here's what i could find judging by the description of the schemas, schemas that are done are isPrivate  field, account_external_ids and
[20:24:15] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_144.java#L70
[20:24:18] <paladox>	 no_justification ^^
[20:24:37] <wikibugs_>	 (03CR) 10Yaron Koren: [C: 031] Add tests for Extension:VEForAll [integration/config] - 10https://gerrit.wikimedia.org/r/431853 (owner: 10Cicalese)
[20:24:37] <paladox>	 an index is added to account_external_ids_byEmail
[20:24:39] <awight>	 hmm, the ur1.ca shortener in this channel's topic seems to be offline.
[20:25:07] <no_justification>	 Fair 'nuff
[20:25:15] <paladox>	 this https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_146.java one creates a user branch for all users
[20:25:25] <paladox>	 no_justification so we will need to run gc on All-Users
[20:25:35] <no_justification>	 We do that :)
[20:25:35] <paladox>	 (after the notedb migration)
[20:25:50] <paladox>	 no_justification yeh though we will need it to be every hour for that repo :)
[20:26:17] <paladox>	 or the repo will grow really huge
[20:26:41] <paladox>	 though maybe we wont be hit by the performance problem gerrithub is having with the large All-Users repo
[20:27:57] <paladox>	 there's a schema that deletes user branches if the account does not exists
[20:27:58] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_147.java
[20:28:28] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_149.java work in progress
[20:28:48] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_150.java drops the ACCOUNT_EXTERNAL_IDS table
[20:29:11] <paladox>	 you can now tell when a group was created
[20:29:12] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_151.java
[20:29:30] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_152.java drops unused indexes from the accounts table
[20:29:51] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_153.java adds the reviewStarted field to change
[20:30:15] <paladox>	 i guess that's a follow up to wip!
[20:30:17] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_154.java migrates accounts to notedb
[20:30:43] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_155.java adds account sequence to notedb
[20:31:04] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_156.java adds the revertOf field to change
[20:31:33] <awight>	 twentyafterfour: scap version => 3.8.1-1...  YASSS
[20:31:33] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_157.java drops more unused index fields from the account table
[20:31:48] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_158.java drops the account table
[20:32:09] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_159.java migrates draft changes to either private or wip
[20:32:15] <paladox>	 with wip being the default now i think
[20:33:03] <thcipriani>	 awight: yep, went out this morning (my morning, anyway :))!
[20:33:21] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_160.java removes the my draft menu as drafts were removed
[20:34:22] <paladox>	 https://github.com/GerritCodeReview/gerrit/blob/stable-2.15/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_161.java replaces Mute/Unmute with Mark as Reviewed/Unreviewed
[20:34:30] <awight>	 twentyafterfour: greg-g: I'd like to deploy our experimental git-lfs branch for ORES after the MW train today, if that's sane.
[20:34:43] <paladox>	 which is basically really dosen't affect us as when upgrading it will do mute then replace it with that.
[20:34:51] <paladox>	 which means you can now mute changes
[20:34:53] <paladox>	 no_justification ^^
[20:34:59] <paladox>	 that's all of them now i think
[20:35:26] <twentyafterfour>	 awight: sure thing!
[20:35:36] <awight>	 :D
[20:35:56] <paladox>	 so that is alot of schema upgrades heh
[20:37:28] <paladox>	 hmm http://ur1.ca/qlpgz is not loading for me
[20:38:52] <awight>	 paladox: +1 I had that, too.  Here's where I think it should point, if you're actually looking for the logs: https://wm-bot.wmflabs.org/browser/index.php?display=%23wikimedia-releng
[20:39:07] <paladox>	 awight ah thanks
[20:39:29] <paladox>	 safari is throwing a carn't open http://ur1.ca/qlpgz now.
[20:39:40] <paladox>	 maybe we should replace the url with  https://wm-bot.wmflabs.org/browser/index.php?display=%23wikimedia-releng in the topic?
[20:40:48] <paladox>	 no_justification im looking forward to this https://docs.google.com/presentation/d/1xOwLICLyDuK8jQYiu6I2Wu0aF0AWCMsnXMqQNz0Kmhw/edit#slide=id.g365f09a753_0_261
[20:41:41] <paladox>	 im also looking forward to https://docs.google.com/presentation/d/1xOwLICLyDuK8jQYiu6I2Wu0aF0AWCMsnXMqQNz0Kmhw/edit#slide=id.g365f09a753_0_278
[20:41:49] <paladox>	 if they decide to implement this draft ui
[20:47:24] <paladox>	 no_justification did you push the gerrit update to archiva? :)
[20:50:43] <no_justification>	 Not yet. Went down a rabbit hole trying to do it semi-automatically with maven or gradle
[20:54:08] <paladox>	 ok
[20:54:54] <paladox>	 no_justification you could do https://github.com/GerritCodeReview/gerrit/blob/master/tools/maven/mvn.py
[20:55:51] <paladox>	 with notedb there should be very little load on the db!
[20:56:15] <awight>	 no_justification: Should I knock on your door for setting up a GitHub -> gerrit mirror?  I want https://gerrit.wikimedia.org/r/scoring/ores/drafttopic to sync from http://github.com/wiki-ai/drafttopic
[20:56:26] <no_justification>	 There's no such thing as an auto github -> gerrit mirror
[20:56:38] * awight strains at shackles
[20:56:43] <no_justification>	 And if we're deploying from gerrit, we /definitely/ don't want it automatic
[20:57:05] <awight>	 I think we might already be doing this, for example https://gerrit.wikimedia.org/r/#/admin/projects/scoring/ores/editquality
[20:57:21] <no_justification>	 (also, I have a gripe about wiki-ai being a separate org that The Usual Suspects can't help maintain, but that's another topic)
[20:57:50] <no_justification>	 It's not being imported automatically by gerrit. If it's being sync'd, someone else is doing it
[20:57:50] <awight>	 I agree that it's a security hole, but somehow grandparented in
[20:58:02] <awight>	 from Phabricator, I'm assuming?
[20:58:23] <no_justification>	 Phabricator....could be observing then mirroring...yeah
[20:58:52] <awight>	 no_justification: I'm on-board with not being a gigantic, pustulent wart...
[20:59:37] <no_justification>	 Generally speaking: we just don't trust deployments from a third-party repository. This is not github specific (I would say the same re: bitbucket, sourceforge, you name it)
[21:00:07] <no_justification>	 And auto-importing the git from that third party repo kind of obscures what's being deployed & when
[21:00:16] <no_justification>	 (eh, what, not when)
[21:00:35] <wikibugs_>	 10Release-Engineering-Team, 10Scoring-platform-team: Another round of discussion about wiki-ai's GitHub->gerrit mirroring - https://phabricator.wikimedia.org/T194212#4192258 (10awight)
[21:01:50] <no_justification>	 To be fair, "syncing manually" isn't hard/time consuming. You can do it on one repo with two remotes
[21:01:54] <awight>	 no_justification: The only mitigating factor that I know of is that these are exclusively deployed as submodules of a repo native to gerrit, so *assuming* that the Scoring team is being careful with our git log and submodule pointer hygiene, it's impossible for rogue patches to sneak in.
[21:02:15] <no_justification>	 That's a true statement yeah
[21:02:33] <no_justification>	 I guess considering these aren't auto-deployed, syncing back to gerrit automatically isn't a terrible thing
[21:02:56] <no_justification>	 It's moreso I get sketchy when we're doing auto-deploys with git::clone{} in puppet
[21:02:59] <no_justification>	 And stuff sneaks in!
[21:04:18] <wikibugs_>	 10Release-Engineering-Team, 10Scoring-platform-team: Another round of discussion about wiki-ai's GitHub->gerrit mirroring - https://phabricator.wikimedia.org/T194212#4192286 (10awight)
[21:04:21] <wikibugs_>	 10Release-Engineering-Team, 10Scoring-platform-team: Another round of discussion about wiki-ai's GitHub->gerrit mirroring - https://phabricator.wikimedia.org/T194212#4192258 (10awight)
[21:04:33] <awight>	 no_justification: Yes that would be horrible.
[21:04:45] * awight sneaks into Phabricator to set up the mirroring
[21:05:05] <no_justification>	 Yeah that's prolly the easiest method
[21:05:16] <no_justification>	 (there's no reverse-replication plugin, which would be cool)
[21:05:50] <no_justification>	 There's the github plugin specifically which mirrors things in, but that's a sledgehammer for our usecase
[21:06:35] <wikibugs_>	 10Project-Admins: Add #SVG tag to Phabricator - https://phabricator.wikimedia.org/T194188#4192306 (10Aklapper) Generally in favor; though we will have to make clear the difference to #Wikimedia-SVG-Rendering and I'm wondering how to phrase that. The latter might be for issue with displaying files in SVG format w...
[21:08:03] <wikibugs_>	 10Project-Admins: Add #SVG tag to Phabricator - https://phabricator.wikimedia.org/T194188#4192315 (10Volker_E) T185596 is an example from my recent work.
[21:10:34] <awight>	 It seems to have worked /o\
[21:22:45] <awight>	 no_justification: I might have missed some kind of config in gerrit.  This repo, https://phabricator.wikimedia.org/source/drafttopic/manage/uris/ is correctly observing from GitHub, but so far has not pushed changes to gerrit.
[21:23:21] <no_justification>	 https://phabricator.wikimedia.org/source/drafttopic/manage/basics/
[21:23:26] <no_justification>	 Cuz it's not done importing :)
[21:24:10] <awight>	 That's weird, I was watching that but the Phabricator repo has been correct for a while now.. I guess this is some mungey background thing, then.
[21:26:03] <no_justification>	 The repo is fine, but phabricator wants to import each individual commit
[21:26:06] <no_justification>	 Into the database
[21:26:30] <no_justification>	 eg: https://phabricator.wikimedia.org/R2341:39a095ae4861c0a211663a7da63a5e93378f3998
[21:26:41] <awight>	 aha thanks for the explanation
[21:26:54] * awight kicks the tires
[21:33:04] <no_justification>	 Ah, looks like someone registered with a bogus e-mail address, so two of the worker daemons were spinning on those.
[21:33:16] <no_justification>	 Looks like phab's job queue will start catching up a bit
[21:33:18] <awight>	 ty!
[21:35:22] <twentyafterfour>	 awight: I'm done with the train. 
[21:35:58] <twentyafterfour>	 also no_justification and awight: the phabricator queue has been backed up with thousands of bogus search worker tasks. I'm clearing them out now which should further free up the background processing in phabricator 
[21:36:40] <twentyafterfour>	 I really wish phabricator handled errors in the queue more gracefully... pausing and restarting at a snale pace isn't the best way of handling errors IMO
[21:36:48] <awight>	 gross
[21:36:53] <no_justification>	 cpu utilization is only 25%. Surely we could spin up another phd process or 2?
[21:37:09] <twentyafterfour>	 no_justification: yeah we could try that
[21:37:18] <no_justification>	 25% at peak, to be clear
[21:37:32] <no_justification>	 Hovers a bit lower like 10-20%
[21:37:54] <awight>	 At some point you have to respect the optimism of Phabricator programmers, thinking that the queue code will never encounter unhappy path.
[21:37:58] <twentyafterfour>	 it's set to 10 taskmasters 
[21:38:06] <awight>	 The greatest, biggest queues.
[21:38:18] <no_justification>	 897418 17899:mpta3d localhost 17899    Apr 12 2018, 12:35:13 AM PhabricatorRepositoryPullLocalDaemon 
[21:38:18] <no_justification>	 920817 17899:75fkaz localhost 17899    Apr 12 2018, 12:35:13 AM PhabricatorTaskmasterDaemon          
[21:38:18] <no_justification>	 897420 17899:tiw7rr phab1001  17899    Apr 12 2018, 12:35:13 AM PhabricatorTaskmasterDaemon          
[21:38:18] <no_justification>	 897419 17899:4ilfoo phab1001  17899    Apr 12 2018, 12:35:13 AM PhabricatorTriggerDaemon    
[21:38:24] <no_justification>	 That's all I get outta phd status
[21:38:46] <twentyafterfour>	 no_justification: yeah, they changed the way it spawns workers and I don't fully understand the new way
[21:39:12] <twentyafterfour>	 the part that I suspect is the problem is that any exception causes the worker to exit and then it pauses a while before respawning that worker 
[21:39:39] <twentyafterfour>	 which helps keep it from thrashing wildly but also keeps it from progressing much when there are some error'd tasks stuck in the queue
[21:39:55] <twentyafterfour>	 I don't know if more workers would help much
[21:40:06] <twentyafterfour>	 reducing the delay to respawn would help
[21:42:03] <twentyafterfour>	 awight: I know I said I'm done with train but I forgot the last step :-/
[21:42:17] <twentyafterfour>	 this will only take two minutes though ...
[21:42:30] <awight>	 I'm hands-off
[21:47:23] <no_justification>	 PhabricatorRepositoryGitCommitMessageParserWorker has been stuck at 117
[21:47:31] <no_justification>	 I wonder if something about those commits is....stuck?
[21:49:23] <awight>	 lmk if it's my repo
[21:49:24] <twentyafterfour>	 awight: really done now
[21:49:30] <awight>	 :) thanks
[21:49:52] <twentyafterfour>	 no_justification: there is one commit by gilles that's yuge 
[21:50:06] <twentyafterfour>	 but I thought I canceled that one
[21:58:25] <no_justification>	 Well it'd reattempt, right?
[21:58:39] <no_justification>	 Later on?
[21:58:45] <no_justification>	 It doesn't blacklist it forever :)
[22:03:34] <no_justification>	 paladox: Actually, my script mostly works :)
[22:03:41] <paladox>	 no_justification heh :)
[22:13:14] <wikibugs_>	 10Phabricator: Add support for task types - https://phabricator.wikimedia.org/T93499#1852425 (10Niedzielski) @mmodell, this is great functionality! I was curious if it's possible to customize the browser tab / window title? When a user clicks our "[[ https://phabricator.wikimedia.org/project/board/67/ | bug repo...
[22:35:36] * awight frowns at 0% repo imported
[22:41:36] <no_justification>	 paladox: Holy crap it worked!
[22:41:45] <paladox>	 no_justification hehe :)
[22:42:05] <no_justification>	 https://phabricator.wikimedia.org/P7100
[22:43:18] <no_justification>	 Amended copy incoming
[22:44:09] <wikibugs_>	 10Gerrit, 10Developer-Relations (Apr-Jun-2018): Develop a newcomer bot for Gerrit - https://phabricator.wikimedia.org/T192046#4192660 (10srishakatux) 05Open>03Resolved All details are here: https://github.com/srish/gerrit-newcomer-bot
[22:50:30] <awight>	 twentyafterfour: bad news, my test LFS deployment failed to pull the files again
[22:51:09] <awight>	 tin:/srv/deployment/ores/deploy/scap/log/scap-sync-2018-05-01-0003-1-gae55746.log
[22:51:48] <awight>	 git lfs install --global did happen
[22:51:55] <awight>	 ah.
[22:52:07] <awight>	 It's probably because git lfs install happened after submodule update -i.
[22:52:11] <awight>	 twentyafterfour: ^
[22:52:28] <paladox>	 no_justification :)
[23:21:26] <wikibugs_>	 10Release-Engineering-Team (Kanban), 10Scap, 10Scoring-platform-team, 10Patch-For-Review: Support git-lfs - https://phabricator.wikimedia.org/T180627#4192775 (10awight) 15:50 < awight> twentyafterfour: bad news, my test LFS deployment failed to pull the files again 15:51 < awight> tin:/srv/deployment/ores/...
[23:26:41] <paladox>	 no_justification https://gerrit.git.wmflabs.org/r/q/status:open
[23:26:43] <paladox>	 works!
[23:26:47] <paladox>	 (gerrit 2.14.8)