[00:07:27] PROBLEM - Host deployment-secureredirexperiment is DOWN: PING CRITICAL - Packet loss = 100% [03:10:16] RECOVERY - Free space - all mounts on deployment-tin is OK: OK: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found) [03:16:16] PROBLEM - Free space - all mounts on deployment-tin is CRITICAL: CRITICAL: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found)deployment-prep.deployment-tin.diskspace.root.byte_percentfree (<22.22%) WARN: deployment-prep.deployment-tin.diskspace._srv.byte_percentfree (<55.56%) [05:17:42] (03PS2) 10Legoktm: Whitelist Sjoerddebruin [integration/config] - 10https://gerrit.wikimedia.org/r/433960 (owner: 10Hoo man) [05:17:45] (03CR) 10Legoktm: [C: 032] Whitelist Sjoerddebruin [integration/config] - 10https://gerrit.wikimedia.org/r/433960 (owner: 10Hoo man) [05:17:55] (03PS4) 10Legoktm: Temporarily increase the timeout of selenium jobs [integration/config] - 10https://gerrit.wikimedia.org/r/434037 (https://phabricator.wikimedia.org/T167432) (owner: 10WMDE-leszek) [05:19:04] (03PS3) 10Legoktm: Add Prssanna to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/433363 (owner: 10Lucas Werkmeister (WMDE)) [05:19:13] (03CR) 10Legoktm: [C: 032] "Yay, welcome :)" [integration/config] - 10https://gerrit.wikimedia.org/r/433363 (owner: 10Lucas Werkmeister (WMDE)) [05:19:31] (03Merged) 10jenkins-bot: Whitelist Sjoerddebruin [integration/config] - 10https://gerrit.wikimedia.org/r/433960 (owner: 10Hoo man) [05:20:36] (03Merged) 10jenkins-bot: Add Prssanna to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/433363 (owner: 10Lucas Werkmeister (WMDE)) [05:21:36] !log deployed https://gerrit.wikimedia.org/r/433960 https://gerrit.wikimedia.org/r/433363 [05:21:39] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [05:22:44] (03CR) 10Legoktm: [C: 032] "INFO:jenkins_jobs.builder:Reconfiguring jenkins job selenium-CentralAuth" [integration/config] - 10https://gerrit.wikimedia.org/r/434037 (https://phabricator.wikimedia.org/T167432) (owner: 10WMDE-leszek) [05:24:21] (03Merged) 10jenkins-bot: Temporarily increase the timeout of selenium jobs [integration/config] - 10https://gerrit.wikimedia.org/r/434037 (https://phabricator.wikimedia.org/T167432) (owner: 10WMDE-leszek) [05:24:33] (03PS2) 10Legoktm: Add link to show how to whitelist a user [integration/config] - 10https://gerrit.wikimedia.org/r/422187 (owner: 10BearND) [05:24:39] (03CR) 10Legoktm: [C: 032] "Thanks!" [integration/config] - 10https://gerrit.wikimedia.org/r/422187 (owner: 10BearND) [05:26:08] (03Merged) 10jenkins-bot: Add link to show how to whitelist a user [integration/config] - 10https://gerrit.wikimedia.org/r/422187 (owner: 10BearND) [05:37:12] (03PS1) 10Legoktm: Pass all environment variables to seccheck [integration/config] - 10https://gerrit.wikimedia.org/r/434625 [05:37:14] (03PS1) 10Legoktm: Run extension-coverage for Cargo [integration/config] - 10https://gerrit.wikimedia.org/r/434626 [05:37:41] (03CR) 10Legoktm: [C: 032] Pass all environment variables to seccheck [integration/config] - 10https://gerrit.wikimedia.org/r/434625 (owner: 10Legoktm) [05:37:46] (03CR) 10Legoktm: [C: 032] Run extension-coverage for Cargo [integration/config] - 10https://gerrit.wikimedia.org/r/434626 (owner: 10Legoktm) [05:39:16] (03Merged) 10jenkins-bot: Pass all environment variables to seccheck [integration/config] - 10https://gerrit.wikimedia.org/r/434625 (owner: 10Legoktm) [05:39:18] (03Merged) 10jenkins-bot: Run extension-coverage for Cargo [integration/config] - 10https://gerrit.wikimedia.org/r/434626 (owner: 10Legoktm) [05:39:36] PROBLEM - Free space - all mounts on deployment-fluorine02 is CRITICAL: CRITICAL: deployment-prep.deployment-fluorine02.diskspace._srv.byte_percentfree (<20.00%) [05:39:42] !log deployed https://gerrit.wikimedia.org/r/434626 [05:39:44] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [06:32:41] (03PS2) 10Legoktm: Remove mediawiki/core phpcs job and docker container [integration/config] - 10https://gerrit.wikimedia.org/r/427698 (owner: 10Hashar) [06:33:33] (03CR) 10Legoktm: [C: 032] "I deleted the job in Jenkins, it hadn't been triggered for over a month. I guess the docker image will just stay in the registry forever?" [integration/config] - 10https://gerrit.wikimedia.org/r/427698 (owner: 10Hashar) [06:34:15] (03PS2) 10Legoktm: Remove mediawiki-core-npm-node-6-docker [integration/config] - 10https://gerrit.wikimedia.org/r/427699 (owner: 10Hashar) [06:34:43] (03CR) 10Legoktm: [C: 032] "Deleted in jenkins, not triggered for over a month." [integration/config] - 10https://gerrit.wikimedia.org/r/427699 (owner: 10Hashar) [06:35:49] (03Merged) 10jenkins-bot: Remove mediawiki/core phpcs job and docker container [integration/config] - 10https://gerrit.wikimedia.org/r/427698 (owner: 10Hashar) [06:36:09] (03Merged) 10jenkins-bot: Remove mediawiki-core-npm-node-6-docker [integration/config] - 10https://gerrit.wikimedia.org/r/427699 (owner: 10Hashar) [06:49:33] RECOVERY - Free space - all mounts on deployment-fluorine02 is OK: OK: All targets OK [06:50:39] PROBLEM - Free space - all mounts on deployment-mx is CRITICAL: CRITICAL: deployment-prep.deployment-mx.diskspace._var_log.byte_percentfree (<100.00%) [07:13:37] (03PS1) 10Legoktm: Pass information from slimer -> Python over the filesystem [integration/audit-resources] - 10https://gerrit.wikimedia.org/r/434635 [07:13:39] (03PS1) 10Legoktm: Properly clean up temporary profile directory [integration/audit-resources] - 10https://gerrit.wikimedia.org/r/434636 [07:15:03] (03CR) 10Legoktm: [C: 032] Pass information from slimer -> Python over the filesystem [integration/audit-resources] - 10https://gerrit.wikimedia.org/r/434635 (owner: 10Legoktm) [07:15:08] (03CR) 10Legoktm: [C: 032] Properly clean up temporary profile directory [integration/audit-resources] - 10https://gerrit.wikimedia.org/r/434636 (owner: 10Legoktm) [07:15:41] (03Merged) 10jenkins-bot: Pass information from slimer -> Python over the filesystem [integration/audit-resources] - 10https://gerrit.wikimedia.org/r/434635 (owner: 10Legoktm) [07:15:43] (03Merged) 10jenkins-bot: Properly clean up temporary profile directory [integration/audit-resources] - 10https://gerrit.wikimedia.org/r/434636 (owner: 10Legoktm) [07:33:19] legoktm: o/ :P [07:33:30] hi addshore [07:33:42] congratz on finals being done :D [07:33:54] :)) thanks [07:33:58] care to help me with some tin confusion quickly? :) [07:34:01] sure [07:34:05] so, srv/mediawiki-staging/php-1.32.0-wmf.4 [07:34:25] "git log HEAD..origin/wmf/1.32.0-wmf.4" shows 2 commits, one i was expecting and one I was not [07:34:27] On branch wmf/1.32.0-wmf.4 [07:34:27] Your branch and 'origin/wmf/1.32.0-wmf.4' have diverged, [07:34:27] and have 1 and 2 different commits each, respectively. [07:34:52] which commit were you not expecting? [07:35:01] https://gerrit.wikimedia.org/r/#/c/434529/ [07:35:09] the ContentTranslation one [07:35:40] If I saw it there, i would have thought that it is not deployed... but it is... but also I don't see it in the git log... [07:37:03] hmmm [07:37:11] https://www.irccloud.com/pastebin/cXDWjJ5B/ [07:37:24] yeah, I checked that [07:37:39] So I don't know what happened or how this got like this [07:37:46] legoktm@tin:/srv/mediawiki-staging/php-1.32.0-wmf.4$ git diff --submodule [07:37:46] Submodule extensions/ContentTranslation f2f025cf34..da12af5fef: [07:37:46] > Fix PHP notice: Undefined index CX_CATEGORY_METADATA [07:37:58] hmmm, right [07:38:23] fetched into the submodule only? and seperatly? [07:38:33] I guess so? [07:38:34] sounds like I'll be fine to just rebase both changes then? [07:39:11] * addshore might followup with twenty-after-four and find out later / tomorrow. I'm pretty sure this is the second time I had this during EU morning time recently :( [07:39:17] https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/bdee12aeb245cf8fee38a46eef40de1a00520208 [07:39:20] I don't see that either [07:39:21] Yeah [07:39:23] I think you're fine [07:39:28] the contents on filesystem are correct [07:39:32] the git tracking is messed up [07:39:40] I think the core submodule commits were never pulled [07:39:56] and the submodule repo itself was just updated [07:40:11] ack, thanks for brain checking me :) [07:40:35] also wtf why is extensions/JADE dirty [07:40:44] so indeed "git submodule update --init --recursive extensions/ContentTranslation" was a noop [07:41:09] 10MediaWiki-Codesniffer, 10PHP 7.0 support: Report PREG_REPLACE_EVAL as deprecated in codesniffer - https://phabricator.wikimedia.org/T191676#4224093 (10thiemowmde) p:05Triage>03Low I totally support the idea of disallowing `/e` in any code. Unfortunately I can not think of a way to make this work in PHPCS... [07:46:35] 10Release-Engineering-Team, 10JADE, 10Wikimedia-General-or-Unknown: JADE submodule on tin is dirty - https://phabricator.wikimedia.org/T195343#4224100 (10Legoktm) p:05Triage>03High [07:47:06] filed ^ for the JADE issue [07:47:50] thanks! :) [07:48:03] 10Release-Engineering-Team, 10JADE, 10Wikimedia-General-or-Unknown: JADE submodule on tin is dirty - https://phabricator.wikimedia.org/T195343#4224113 (10Paladox) [08:06:27] (03CR) 10Legoktm: [C: 04-1] "Thanks, I tested against MediaWiki core, and noted two issues." [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/424554 (https://phabricator.wikimedia.org/T182057) (owner: 10Thiemo Kreuz (WMDE)) [08:21:22] (03PS5) 10Legoktm: Prohibit PHP's vanilla execution [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/423030 (owner: 10MaxSem) [08:21:35] (03PS6) 10Legoktm: Prohibit PHP's vanilla execution [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/423030 (owner: 10MaxSem) [08:22:29] (03PS7) 10Legoktm: Prohibit PHP's vanilla execution [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/423030 (owner: 10MaxSem) [08:31:52] (03CR) 10Legoktm: Prohibit PHP's vanilla execution (032 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/423030 (owner: 10MaxSem) [08:32:37] (03CR) 10Legoktm: [C: 032] "PS5: Added popen and improved doc comment" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/423030 (owner: 10MaxSem) [08:33:32] (03Merged) 10jenkins-bot: Prohibit PHP's vanilla execution [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/423030 (owner: 10MaxSem) [08:33:59] (03CR) 10jenkins-bot: Prohibit PHP's vanilla execution [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/423030 (owner: 10MaxSem) [08:59:50] 10Continuous-Integration-Config: Only run limited set of needed tests when the commit message is updated - https://phabricator.wikimedia.org/T186032#3931525 (10hashar) A change in a commit message still needs to be tested: * Some repositories have a commit message validation tool enabled: https://www.mediawiki.... [09:02:51] (03CR) 10Legoktm: [C: 04-1] "Also I don't see anywhere that fixes the bug request that started this (T182057, @parma->@param)" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/424554 (https://phabricator.wikimedia.org/T182057) (owner: 10Thiemo Kreuz (WMDE)) [09:14:53] (03PS1) 10Legoktm: Add InArrayUsageSniff from Wikibase CodeSniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434646 [09:16:17] (03CR) 10Legoktm: "https://codesearch.wmflabs.org/search/?q=in_array.*array_keys&i=nope&files=&repos=" [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434646 (owner: 10Legoktm) [09:17:11] RECOVERY - Free space - all mounts on integration-slave-jessie-1004 is OK: OK: All targets OK [10:05:16] Anyone got any idea about the jobqueue perhaps being broken on beta? [10:51:36] (03PS1) 10Legoktm: Reorganize PHP 7.0 compatibility sniffs into a category [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434665 [10:51:38] (03PS1) 10Legoktm: Prevent usage of new PHP 7.0 features [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434666 [10:51:40] (03PS1) 10Legoktm: Prevent usage of nullable and void type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 [10:54:25] guys mediawiki/core patches failing due to a new sniff rule I think? I didn't touched tests/qunit/QUnitTestResources.php but it fails there due to 'too long' (more +100 chars) [10:55:09] scratch that [10:55:12] passing now [10:56:33] (03CR) 10jerkins-bot: [V: 04-1] Prevent usage of nullable and void type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 (owner: 10Legoktm) [10:57:41] (03CR) 10jerkins-bot: [V: 04-1] Prevent usage of new PHP 7.0 features [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434666 (owner: 10Legoktm) [10:57:43] Hauskatze: hm? [10:58:08] (03PS2) 10Legoktm: Prevent usage of nullable and void type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 [10:58:27] (03Abandoned) 10Legoktm: Prevent usage of new PHP 7.0 features [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434666 (owner: 10Legoktm) [10:58:28] legoktm: sorry I was looking at https://gerrit.wikimedia.org/r/#/c/434662/ instead of my own patch [10:58:45] :p no worries [11:03:20] (03PS1) 10Legoktm: PHP 7.1 features TODO list [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434671 [11:03:56] (03CR) 10jerkins-bot: [V: 04-1] Prevent usage of nullable and void type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 (owner: 10Legoktm) [11:07:15] (03PS3) 10Legoktm: Prevent usage of nullable and void type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 [11:08:12] (03CR) 10jerkins-bot: [V: 04-1] PHP 7.1 features TODO list [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434671 (owner: 10Legoktm) [11:08:53] (03PS4) 10Legoktm: Prevent usage of nullable and void type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 [11:10:38] (03PS2) 10Legoktm: PHP 7.1 features TODO list [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434671 [11:19:44] PROBLEM - SSH on integration-slave-docker-1017 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [11:34:35] RECOVERY - SSH on integration-slave-docker-1017 is OK: SSH OK - OpenSSH_6.7p1 Debian-5+deb8u4 (protocol 2.0) [12:38:40] PROBLEM - Puppet errors on deployment-ms-be04 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [12:54:27] PROBLEM - Puppet errors on deployment-ms-be03 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [13:31:15] PROBLEM - Free space - all mounts on deployment-tin is CRITICAL: CRITICAL: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found)deployment-prep.deployment-tin.diskspace.root.byte_percentfree (<22.22%) WARN: deployment-prep.deployment-tin.diskspace._srv.byte_percentfree (<100.00%) [13:36:34] PROBLEM - Puppet errors on deployment-eventlog05 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [14:18:49] i just had another tshirt idea [14:21:06] "I broke teh_ wikis and all I got is this crappy t-shirt (and my deployment access was revoked)" [14:21:14] :) [14:21:18] RECOVERY - Free space - all mounts on deployment-tin is OK: OK: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found) [14:22:10] !log updating torblock database on deployment-prep [14:22:13] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [14:32:16] PROBLEM - Free space - all mounts on deployment-tin is CRITICAL: CRITICAL: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found)deployment-prep.deployment-tin.diskspace.root.byte_percentfree (<22.22%) [14:43:25] 10Release-Engineering-Team (Kanban), 10Release Pipeline, 10Wikimedia-Hackathon-2018, 10Services (watching), 10User-zeljkofilipin: Wikimedia Continuous Delivery Pipeline: Say What? - https://phabricator.wikimedia.org/T194940#4225532 (10thcipriani) 05Open>03Resolved a:03thcipriani >>! In T194940#4220... [14:49:33] Hauskatze: haha I've never even got a t-shirt :D [14:50:14] Nikerabbit: and I don't wear t-shirts either :) [15:17:17] RECOVERY - Free space - all mounts on deployment-tin is OK: OK: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found) [15:23:17] PROBLEM - Free space - all mounts on deployment-tin is CRITICAL: CRITICAL: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found)deployment-prep.deployment-tin.diskspace.root.byte_percentfree (<22.22%) [15:24:12] (03PS1) 10Catrope: Add Hagar Shilo to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/434722 [15:24:31] (03PS2) 10Catrope: Add Hagar Shilo to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/434722 [15:27:44] PROBLEM - Puppet errors on deployment-redis01 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:33:43] PROBLEM - Puppet errors on deployment-redis02 is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [15:52:20] PROBLEM - SSH on integration-slave-docker-1013 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [15:53:50] PROBLEM - SSH on integration-slave-docker-1015 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [16:03:12] (03PS1) 10Gergő Tisza: Add Edlira to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/434727 [16:08:41] RECOVERY - SSH on integration-slave-docker-1015 is OK: SSH OK - OpenSSH_6.7p1 Debian-5+deb8u4 (protocol 2.0) [16:17:09] RECOVERY - SSH on integration-slave-docker-1013 is OK: SSH OK - OpenSSH_6.7p1 Debian-5+deb8u4 (protocol 2.0) [16:24:51] 10Release-Engineering-Team, 10MediaWiki-Database, 10Performance-Team, 10Wikimedia-log-errors: Wikimedia\Rdbms\ChronologyProtector::initPositions: expected but failed to find position index. - https://phabricator.wikimedia.org/T194403#4226015 (10Krinkle) [16:28:18] 10Continuous-Integration-Config, 10Mobile-Content-Service, 10Patch-For-Review, 10Reading-Infrastructure-Team-Backlog (Kanban): Create a CI task for MCS periodic tests - https://phabricator.wikimedia.org/T177896#4226031 (10bearND) Probably need to set the correct Docker image somewhere, see https://integrat... [16:34:51] 10Project-Admins: Would like to create project Wikidocumentaries - https://phabricator.wikimedia.org/T195391#4226052 (10Susannaanas) [16:48:05] RECOVERY - Host deployment-secureredirproto is UP: PING OK - Packet loss = 0%, RTA = 7.37 ms [17:01:41] PROBLEM - Host deployment-secureredirproto is DOWN: CRITICAL - Host Unreachable (10.68.22.127) [17:14:43] 10Gerrit, 10User-zeljkofilipin: Can not download a specific patch from Gerrit using git-review - https://phabricator.wikimedia.org/T194520#4226145 (10thcipriani) >>! In T194520#4202208, @zeljkofilipin wrote: > @thcipriani are you saying the documentation is wrong and that the feature does not work? Yeah, I su... [17:15:20] (03PS1) 10MarcoAurelio: Modify access rules [extensions/PrimarySources] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/434742 [17:15:30] (03CR) 10MarcoAurelio: [V: 032 C: 032] Modify access rules [extensions/PrimarySources] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/434742 (owner: 10MarcoAurelio) [17:28:17] RECOVERY - Free space - all mounts on deployment-tin is OK: OK: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found) [17:34:16] PROBLEM - Free space - all mounts on deployment-tin is CRITICAL: CRITICAL: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found)deployment-prep.deployment-tin.diskspace.root.byte_percentfree (<11.11%) [17:47:34] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: rename naos to deploy2001 and reinstall with stretch - https://phabricator.wikimedia.org/T193916#4226224 (10Dzahn) [17:54:07] 10Release-Engineering-Team (Kanban), 10Wikimedia-Hackathon-2018, 10User-zeljkofilipin: Technical Debt - https://phabricator.wikimedia.org/T194934#4226261 (10Jrbranaa) Slide set used during the session is available at: https://drive.google.com/open?id=1YCht9AI6SSXxEcIeriz-ipI_WXYwenK4Y6obCkxYDeE [17:54:24] 10Release-Engineering-Team (Kanban), 10Wikimedia-Hackathon-2018, 10User-zeljkofilipin: Technical Debt - https://phabricator.wikimedia.org/T194934#4226262 (10Jrbranaa) 05Open>03Resolved [18:00:24] (03CR) 10Zfilipin: [C: 031] Add Edlira to the CI whitelist [integration/config] - 10https://gerrit.wikimedia.org/r/434727 (owner: 10Gergő Tisza) [18:05:35] 10Release-Engineering-Team, 10MediaWiki-Core-Tests, 10User-zeljkofilipin: Q4 Selenium framework improvements - https://phabricator.wikimedia.org/T190994#4226285 (10zeljkofilipin) [18:05:37] 10Release-Engineering-Team (Kanban), 10Wikimedia-Hackathon-2018, 10JavaScript, 10User-zeljkofilipin: Pair on writing Selenium tests in JavaScript/Node.js - https://phabricator.wikimedia.org/T190687#4080702 (10zeljkofilipin) 05Open>03Resolved [18:06:39] 10Release-Engineering-Team (Kanban), 10Quibble, 10Wikimedia-Hackathon-2018, 10User-zeljkofilipin: Breakout session: Quibble a test runner for MediaWiki - https://phabricator.wikimedia.org/T194970#4226286 (10zeljkofilipin) a:05zeljkofilipin>03hashar [18:06:54] 10Phabricator, 10Project-Admins, 10Security-Team: Create Tag for WMDE Fundraising Security issues - https://phabricator.wikimedia.org/T194286#4226290 (10MarcoAurelio) (moved to Administration; this task requires a Phabricator administrator as it stands. Spaces can only be created by them if that's the option... [18:21:06] people interested in the php5->php7/hhvm stuff might check out https://phabricator.wikimedia.org/T195393 [18:21:14] we intend to hustle this along [18:22:45] s/php5/php/ is one proposed solution, https://gerrit.wikimedia.org/r/#/c/434754/ [18:34:22] it has the virtue of being fastest (assuming nothnig breaks): script modification, puppet run, and done [18:35:36] Could do a few simple tests... Run the scripts with time on php5, and then run them again on hhvm to see if any major differences [18:37:43] depends where the output goes [18:37:51] if it's update to live dbs it's hard to repeat that [18:38:47] most of it's purging crap [18:39:23] PROBLEM - Puppet errors on deployment-mx is CRITICAL: CRITICAL: 100.00% of data above the critical threshold [0.0] [18:39:54] well, is there someone who would know what to look for and knock those tests out pretty fast? [18:42:58] 10Project-Admins: Create two projects: Wikimedia-Technical-Conference-2018 & Wikimedia-Technical-Conference-2018-Organization - https://phabricator.wikimedia.org/T195398#4226383 (10Rfarrand) [18:43:32] I would settle for a few someones if we could farm out the testing [18:55:11] 10Project-Admins: Would like to create project Wikidocumentaries - https://phabricator.wikimedia.org/T195391#4226405 (10Susannaanas) [18:55:29] real 7m8.995s [18:55:38] To run the checkuser purge (a lot of dbs with no rows) [18:58:27] so someone(s) could probably slam through all these tests in a day [18:58:37] 918 wikis... [18:58:40] Like half a second for a wiki [18:58:47] that's fast [18:59:52] I'd suspect initSiteStats and updateSpecialPages would be the slowest ones [19:00:02] (lots of slow/long sql queries) [19:00:29] oh dear [19:00:33] initSitestats [19:00:39] you could really only test that on tiny tiny wikis [19:00:47] same with the other one [19:00:58] still for testing purposes that's all we need [19:02:04] * Reedy runs a hacked copy of foreachwikiindblist with hhvm over the same maintenance script [19:08:16] tick... tock... tick... snoooze... tock... [19:17:35] real 15m43.211s [19:17:43] lol, so it takes over twice as long on hhvm [19:20:34] owie [19:20:47] is that going to kill us until terbium becomes mwmaint1001? [19:22:02] I don't think for most of them that we actually care [19:22:09] If it takes a bit longer, meh, they're not urgent [19:22:16] 10Release-Engineering-Team (Kanban), 10Patch-For-Review, 10Release, 10Train Deployments: 1.32.0-wmf.5 deployment blockers - https://phabricator.wikimedia.org/T191051#4226470 (10mmodell) [19:22:36] CirrusSearch and Echo jobs might be the problematic ones [19:22:55] as AFAIK they're run a lot more frequently [19:29:20] RECOVERY - Free space - all mounts on deployment-tin is OK: OK: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found) [19:35:17] PROBLEM - Free space - all mounts on deployment-tin is CRITICAL: CRITICAL: deployment-prep.deployment-tin.diskspace._mnt.byte_percentfree (No valid datapoints found)deployment-prep.deployment-tin.diskspace.root.byte_percentfree (<22.22%) [19:37:15] ic [19:37:24] how frequent is frequent? [19:38:01] nm reading your comment [19:38:02] hmmm [19:38:13] reinstalling naos as deploy2001 right now [19:38:20] the one a day doesn't seem so bad as long as it finishes well within a day [20:07:02] !log Beta Cluster: Update mobileapps to 29ebe0f [20:07:04] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [20:31:26] (03PS1) 10Legoktm: Make seccheck voting for RevisionSlider and ElectronPdfService [integration/config] - 10https://gerrit.wikimedia.org/r/434799 [21:17:36] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: rename naos to deploy2001 and reinstall with stretch - https://phabricator.wikimedia.org/T193916#4226921 (10Dzahn) [21:19:28] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: rename naos to deploy2001 and reinstall with stretch - https://phabricator.wikimedia.org/T193916#4183490 (10Dzahn) [21:20:31] (03PS1) 10Legoktm: Don't allow 'iterable' type hint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434805 [21:22:33] (03Abandoned) 10Legoktm: PHP 7.1 features TODO list [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434671 (owner: 10Legoktm) [21:24:23] (03PS2) 10Legoktm: Don't allow 'iterable' type hint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434805 [21:27:59] (03CR) 10Jforrester: [C: 032] Reorganize PHP 7.0 compatibility sniffs into a category [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434665 (owner: 10Legoktm) [21:28:49] (03Merged) 10jenkins-bot: Reorganize PHP 7.0 compatibility sniffs into a category [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434665 (owner: 10Legoktm) [21:29:13] (03CR) 10jenkins-bot: Reorganize PHP 7.0 compatibility sniffs into a category [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434665 (owner: 10Legoktm) [21:30:06] (03CR) 10Jforrester: Prevent usage of nullable and void type hints (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 (owner: 10Legoktm) [21:30:20] (03CR) 10Jforrester: [C: 031] Prevent usage of nullable and void type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 (owner: 10Legoktm) [21:30:23] (03CR) 10Jforrester: [C: 031] Don't allow 'iterable' type hint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434805 (owner: 10Legoktm) [21:31:37] (03CR) 10Legoktm: Prevent usage of nullable and void type hints (031 comment) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 (owner: 10Legoktm) [21:37:54] (03CR) 10Jforrester: [C: 032] Prevent usage of nullable and void type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 (owner: 10Legoktm) [21:38:04] (03CR) 10Jforrester: [C: 032] Don't allow 'iterable' type hint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434805 (owner: 10Legoktm) [21:38:52] (03Merged) 10jenkins-bot: Prevent usage of nullable and void type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 (owner: 10Legoktm) [21:38:56] (03Merged) 10jenkins-bot: Don't allow 'iterable' type hint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434805 (owner: 10Legoktm) [21:39:21] (03CR) 10Jforrester: [C: 031] Add InArrayUsageSniff from Wikibase CodeSniffer [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434646 (owner: 10Legoktm) [21:39:36] (03CR) 10jenkins-bot: Prevent usage of nullable and void type hints [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434667 (owner: 10Legoktm) [21:39:53] James_F: thanks :) [21:39:56] (03CR) 10jenkins-bot: Don't allow 'iterable' type hint [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434805 (owner: 10Legoktm) [21:40:15] legoktm: Thanks for being awesome. :-) [21:40:26] legoktm: https://codesearch.wmflabs.org/search/?q=in_array.*array_keys&i=nope&files=&repos= makes me sigh a bit. [21:40:57] yeah :( [21:51:48] when you click "create subtask" in Maniphest and it copies all the subscribers from parent task.. i think it should not do that. in 95% of the cases i find myself _removing_ a bunch of people that i don't want to spam and that are subscribed to the parent task. the purpose of separating something into a subtask is usually "because other people do that and not everybody needs all the details" so [21:51:54] you never want that copy [21:59:32] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: rename naos to deploy2001 and reinstall with stretch - https://phabricator.wikimedia.org/T193916#4183490 (10Dzahn) [22:03:54] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: rename naos to deploy2001 and reinstall with stretch - https://phabricator.wikimedia.org/T193916#4183490 (10Dzahn) [22:06:25] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: rename naos to deploy2001 and reinstall with stretch - https://phabricator.wikimedia.org/T193916#4227070 (10Dzahn) [22:06:49] legoktm: Hm.. any experience with doxygen readme not showing up? [22:06:52] https://doc.wikimedia.org/WrappedString/master/index.html [22:06:56] https://integration.wikimedia.org/ci/job/doxygen-publish/813/console [22:06:59] Not seeing any error [22:07:02] :o [22:07:28] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: rename naos to deploy2001 and reinstall with stretch - https://phabricator.wikimedia.org/T193916#4183490 (10Dzahn) [22:07:35] Krinkle: does it work locally? [22:08:07] * Krinkle tries [22:08:12] legoktm: nope, broken locally as well [22:08:22] doxygen --version; 1.8.14 [22:08:27] same empty canvas [22:08:30] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: rename naos to deploy2001 and reinstall with stretch - https://phabricator.wikimedia.org/T193916#4227075 (10Dzahn) p:05Normal>03High [22:08:36] I'll try it out in a bit [22:20:16] (03CR) 10Krinkle: Add InArrayUsageSniff from Wikibase CodeSniffer (033 comments) [tools/codesniffer] - 10https://gerrit.wikimedia.org/r/434646 (owner: 10Legoktm) [22:21:58] (03PS1) 10Legoktm: Create mediawiki-phpcs-dryrun image [integration/config] - 10https://gerrit.wikimedia.org/r/434815 [22:22:13] (03CR) 10Legoktm: [C: 032] Create mediawiki-phpcs-dryrun image [integration/config] - 10https://gerrit.wikimedia.org/r/434815 (owner: 10Legoktm) [22:22:37] (03PS1) 10Legoktm: Use mediawiki-phpcs-dryrun image [integration/config] - 10https://gerrit.wikimedia.org/r/434816 [22:23:31] (03Merged) 10jenkins-bot: Create mediawiki-phpcs-dryrun image [integration/config] - 10https://gerrit.wikimedia.org/r/434815 (owner: 10Legoktm) [22:24:29] !log deploying https://gerrit.wikimedia.org/r/434815 [22:24:31] Logged the message at https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL [22:41:11] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: rename naos to deploy2001 and reinstall with stretch - https://phabricator.wikimedia.org/T193916#4227138 (10Dzahn) - rename/reinstall is done - naos has been removed from everything (except DNS) - deploy2001 has been added... [22:43:02] (03PS2) 10Legoktm: Use mediawiki-phpcs-dryrun image [integration/config] - 10https://gerrit.wikimedia.org/r/434816 (https://phabricator.wikimedia.org/T116348) [22:43:34] (03CR) 10Legoktm: [C: 032] "Already deployed" [integration/config] - 10https://gerrit.wikimedia.org/r/434816 (https://phabricator.wikimedia.org/T116348) (owner: 10Legoktm) [22:45:14] (03Merged) 10jenkins-bot: Use mediawiki-phpcs-dryrun image [integration/config] - 10https://gerrit.wikimedia.org/r/434816 (https://phabricator.wikimedia.org/T116348) (owner: 10Legoktm) [22:50:12] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: setup/install/deploy deploy1001 as deployment server - https://phabricator.wikimedia.org/T175288#4227160 (10Dzahn) [22:51:55] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10Patch-For-Review: Make mw-tools-codesniffer-mwcore-testrun job more like the actual mediawiki-core-phpcs job - https://phabricator.wikimedia.org/T116348#4227163 (10Legoktm) 05Open>03Resolved a:03Legoktm FYI @Umherirrender and @thiemowmde The... [22:52:10] 10Continuous-Integration-Config, 10MediaWiki-Codesniffer, 10Patch-For-Review: Make mw-tools-codesniffer-mwcore-testrun job more like the actual mediawiki-core-phpcs job - https://phabricator.wikimedia.org/T116348#4227168 (10Legoktm) Oh, https://integration.wikimedia.org/ci/job/mw-tools-codesniffer-mwcore-tes... [22:52:54] (03Abandoned) 10Legoktm: Update MW codesniffer test core test to use mediawiki phpcs file [integration/config] - 10https://gerrit.wikimedia.org/r/303802 (https://phabricator.wikimedia.org/T116348) (owner: 10Paladox) [22:57:54] 10Release-Engineering-Team (Watching / External), 10Operations, 10Patch-For-Review: setup/install/deploy deploy1001 as deployment server - https://phabricator.wikimedia.org/T175288#4227190 (10Dzahn) We'll need the database grants above added or that might block the switch. That being said, not sure why exact... [23:22:41] 10MediaWiki-Codesniffer: PHPCS Internal error when using SPDX license expressions like OR - https://phabricator.wikimedia.org/T195429#4227254 (10Legoktm) [23:37:03] Hm.. it seeems quibble consistently times out on medawiki-vendor [23:37:07] https://gerrit.wikimedia.org/r/#/c/434812/ [23:37:35] During the php lint phase. [23:40:04] that's not quibble [23:40:08] PROBLEM - SSH on integration-slave-docker-1014 is CRITICAL: CRITICAL - Socket timeout after 10 seconds [23:40:44] Krinkle: can you file a bug though? [23:41:38] HHVM linting is just incredibly slow, and that repo has a lot of files [23:42:52] legoktm: O_O, I read it 4x, still got it wrong. [23:43:00] Indeed, it's the composer job, not quibble. [23:43:00] My bad. [23:45:58] 10Continuous-Integration-Config, 10Wikimedia-log-errors (Jenkins Failure): mwgate-composer-hhvm-docker times out on medawiki-vendor - https://phabricator.wikimedia.org/T195430#4227288 (10Krinkle) [23:59:57] RECOVERY - SSH on integration-slave-docker-1014 is OK: SSH OK - OpenSSH_6.7p1 Debian-5+deb8u4 (protocol 2.0)